[PATCH] D134859: [clang][Interp] Implement basic support for floating point values

tbaeder updated this revision to Diff 477862. tbaeder marked 10 inline comments as done. tbaeder added a comment. Remove some questionable (but unused) `Floating` API that didn't take floating-point semantics into account. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134859/new/

[PATCH] D138655: [clang-tidy] Fix `cppcoreguidelines-init-variables` for invalid vardecl

Sockke updated this revision to Diff 477861. Sockke added a comment. Added test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138655/new/ https://reviews.llvm.org/D138655 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/InitVariablesCheck.cpp

[PATCH] D136694: [clang][Interp] Check that constructor calls initialize all record fields

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136694/new/ https://reviews.llvm.org/D136694 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D137235: [clang][Interp] Fix ImplicitValueInitExprs for pointer types

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137235/new/ https://reviews.llvm.org/D137235 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D136815: [clang][Interp] Unify visiting variable declarations

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136815/new/ https://reviews.llvm.org/D136815 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D138117: [clang][docs] Correct floating point option explanations

kawashima-fj added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138117/new/ https://reviews.llvm.org/D138117 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D127462: [Clang] Begin implementing Plan 9 C extensions

ksaunders added a comment. > Just to check -- do you think (some of) these features are something you wish > to propose to WG14 for adoption into C? e.g., are you aiming to get multiple > compilers to implement Plan 9 extensions to demonstrate to WG14 that this is > existing practice in C

[PATCH] D127910: [Clang][AArch64] Add SME C intrinsics for load and store

bryanpkc commandeered this revision. bryanpkc added a reviewer: sagarkulkarni19. bryanpkc added a comment. In D127910#3885699 , @david-arm wrote: > Hi @sagarkulkarni19, just a gentle ping to see if you are still planning to > do more work on this patch?

[PATCH] D138579: [AArch64] Assembly support for FEAT_LRCPC3

tschuett added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64.td:510 +def FeatureRCPC3 : SubtargetFeature<"rcpc3", "HasRCPC3", +"true", "Enable Armv8.9-A RCPC instructions added to A64 and Advanced SIMD and floating-point instruction set (FEAT_LRCPC3)",

[PATCH] D137205: [clang-tidy] Add performance-unnecessary-copy-on-last-use check

Febbe marked 2 inline comments as done. Febbe added inline comments. Comment at: clang-tools-extra/clang-tidy/performance/UnnecessaryCopyOnLastUseCheck.cpp:123 + hasLHS(ignoringParenImpCasts(declRefExpr(equalsNode(DeclRef)), + Context); + return

[PATCH] D138630: [modules] Fix marking `ObjCMethodDecl::isOverriding` when there a no overrides.

This revision was automatically updated to reflect the committed changes. Closed by commit rG0314ba3acbab: [modules] Fix marking `ObjCMethodDecl::isOverriding` when there are no… (authored by vsapsai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 0314ba3 - [modules] Fix marking `ObjCMethodDecl::isOverriding` when there are no overrides.

Author: Volodymyr Sapsai Date: 2022-11-24T14:26:02-08:00 New Revision: 0314ba3acbabd8dc6d39b6d49798d22b6dc33802 URL: https://github.com/llvm/llvm-project/commit/0314ba3acbabd8dc6d39b6d49798d22b6dc33802 DIFF:

[PATCH] D137205: [clang-tidy] Add performance-unnecessary-copy-on-last-use check

Febbe updated this revision to Diff 477846. Febbe marked an inline comment as done. Febbe added a comment. Herald added subscribers: kadircet, arphaman. Replaces match clauses with `RecursiveASTVisistor`s - doubled performance - fixed also a bug in template spezialisations Repository: rG

[PATCH] D138274: Add version to all LLVM cmake package

mceier added inline comments. Comment at: clang/cmake/modules/ClangConfig.cmake.in:6 +set(LLVM_VERSION ${LLVM_VERSION_MAJOR}.${LLVM_VERSION_MINOR}.${LLVM_VERSION_PATCH}) +find_package(LLVM @LLVM_VERSION@ EXACT REQUIRED CONFIG HINTS "@CLANG_CONFIG_LLVM_CMAKE_DIR@")

[PATCH] D138681: [AVR] Fix broken bitcast for aliases in non-zero address space

arichardson accepted this revision. arichardson added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138681/new/ https://reviews.llvm.org/D138681

[PATCH] D138681: [AVR] Fix broken bitcast for aliases in non-zero address space

aykevl updated this revision to Diff 477828. aykevl added a comment. - now _actually_ add that `CHECK` line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138681/new/ https://reviews.llvm.org/D138681 Files: clang/lib/CodeGen/CodeGenModule.cpp

[PATCH] D138681: [AVR] Fix broken bitcast for aliases in non-zero address space

aykevl updated this revision to Diff 477827. aykevl added a comment. - add `CHECK:` line that I forgot Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138681/new/ https://reviews.llvm.org/D138681 Files: clang/lib/CodeGen/CodeGenModule.cpp

[PATCH] D138681: [AVR] Fix broken bitcast for aliases in non-zero address space

aykevl created this revision. aykevl added reviewers: benshi001, dylanmckay, rjmccall, MaskRay. Herald added subscribers: jeroen.dobbelaere, StephenFan, Jim, arichardson. Herald added a project: All. aykevl requested review of this revision. Herald added a project: clang. Herald added a

[PATCH] D138630: [modules] Fix marking `ObjCMethodDecl::isOverriding` when there a no overrides.

vsapsai added a comment. Thanks for the quick review! During the commit I will also fix the typo s/there a no overrides/there are no overrides/ Comment at: clang/test/Modules/override.m:30-34 +@interface CheckOverrideImplementationOfCategory: NSObject +@end +@interface

[PATCH] D131963: [libc++] Add custom clang-tidy checks

ldionne added a comment. Herald added a reviewer: njames93. Let's make those checks optional until we can figure out the packaging stuff, and land this (with green CI). This is going to become way too stale otherwise. Comment at:

[PATCH] D138677: [Lex] Fix suggested spelling of /usr/bin/../include/foo

kadircet added inline comments. Comment at: clang/lib/Lex/HeaderSearch.cpp:1932 + + llvm::SmallString<32> FilePath(File.begin(), File.end()); + path::remove_dots(FilePath, /*remove_dot_dot=*/true); nit: you can change the method signature to take in a

[clang] 5a90edb - [clang-fuzzer] Add missing dependency

Author: Arthur Eubanks Date: 2022-11-24T09:20:47-08:00 New Revision: 5a90edb3c825b43f7af31eab3284687ee08474ad URL: https://github.com/llvm/llvm-project/commit/5a90edb3c825b43f7af31eab3284687ee08474ad DIFF:

[clang] 66b1f6b - Reland [clang-fuzzer] Use new pass manager for optimizing IR

Author: Arthur Eubanks Date: 2022-11-24T09:12:39-08:00 New Revision: 66b1f6bba51536ff8f75c84adf1df63894016b7d URL: https://github.com/llvm/llvm-project/commit/66b1f6bba51536ff8f75c84adf1df63894016b7d DIFF:

[PATCH] D137213: [clang][modules] NFCI: Pragma diagnostic mappings: write/read FileID instead of SourceLocation

dexonsmith added a comment. I just realized @jansvoboda11 is probably out on holiday this week (IIRC, Apple usually gets this week off). Since this was committed almost a month ago, I'm guessing this isn't enough of a blocker that we need to revert rather than wait until next week (and there

[clang] d75bd5e - Revert "[clang-fuzzer] Use new pass manager for optimizing IR"

Author: Arthur Eubanks Date: 2022-11-24T08:57:19-08:00 New Revision: d75bd5e8bb62eddaccc256eef4e10130d6018ec8 URL: https://github.com/llvm/llvm-project/commit/d75bd5e8bb62eddaccc256eef4e10130d6018ec8 DIFF:

[PATCH] D138679: [clang][CodeGen] Add default attributes to __clang_call_terminate

john.brawn created this revision. john.brawn added reviewers: rsmith, rjmccall, lebedev.ri, miyuki. Herald added a project: All. john.brawn requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When generating __clang_call_terminate use

[PATCH] D138678: [include-cleaner] Capture private headers in PragmaIncludes.

VitaNuo created this revision. Herald added a project: All. VitaNuo requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Save file IDs of IWYU private headers and report them as private. Repository: rG LLVM Github Monorepo

[PATCH] D138677: [Lex] Fix suggested spelling of /usr/bin/../include/foo

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added a project: All. sammccall requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Since D60873 we remove dotdots from the search

[clang] a46a746 - [clang-fuzzer] Use new pass manager for optimizing IR

Author: Arthur Eubanks Date: 2022-11-24T08:39:31-08:00 New Revision: a46a746cfa08a72f9e9188451ed5cac2f77d5237 URL: https://github.com/llvm/llvm-project/commit/a46a746cfa08a72f9e9188451ed5cac2f77d5237 DIFF:

[PATCH] D138676: [include-cleaner] HTMLReport shows headers that would be inserted

sammccall updated this revision to Diff 477809. sammccall added a comment. fix bold/italic of header-to-insert on symbol refs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138676/new/ https://reviews.llvm.org/D138676 Files:

[PATCH] D138676: [include-cleaner] HTMLReport shows headers that would be inserted

sammccall created this revision. sammccall added a reviewer: hokein. Herald added a subscriber: mgrang. Herald added a project: All. sammccall requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Demo:

[PATCH] D60873: [clang][HeaderSuggestion] Handle the case of dotdot with an absolute path

sammccall added a comment. Herald added projects: clang-tools-extra, All. I think this introduced a bug: if your search path has `/usr/bin/../include/c++/v1`, then you'll end up with `FileEntry`s with `Name` like `/usr/bin/../include/c++/v1/__utility/move.h`. Calling the `FileEntry` overload

[PATCH] D137642: [X86][CodeGen] Fix crash in hotpatch

saudi added a comment. Ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137642/new/ https://reviews.llvm.org/D137642 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D138583: Create unused non-trivially-destructible check in clang-tidy

sammccall added a comment. In D138583#3949604 , @ankineri wrote: > I do agree that having it as part of `-Wunused-variable` is better on many > aspects, but I have a few concerns about it. > The proposed check can be applied to any type including STL

[PATCH] D138583: Create unused non-trivially-destructible check in clang-tidy

ankineri added a comment. I do agree that having it as part of `-Wunused-variable` is better on many aspects, but I have a few concerns about it. The proposed check can be applied to any type including STL ones such as `std::string`, all as per codebase owner's choice. Adding this attribute to

[PATCH] D137258: [clang] Optimize storage and lookup of analyzer options

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. BTW the change itself looks good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137258/new/ https://reviews.llvm.org/D137258

[PATCH] D138552: [docs] Document that the modules can improve the linking time

ChuanqiXu added a comment. >> I'd be curious to learn how linking time can be reduced significantly by >> deploying modules. Oh, today I found the conclusion "significant decrease in link time time" was not responsible. Since I didn't recognize that our projects uses thinlto and thinlto

[PATCH] D138668: Correct typos

steakhal accepted this revision. steakhal added a comment. Looks good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138668/new/ https://reviews.llvm.org/D138668 ___ cfe-commits mailing list

[PATCH] D137725: [OpenMP][OMPIRBuilder] Mirgrate getName from clang to OMPIRBuilder

This revision was automatically updated to reflect the committed changes. Closed by commit rG2aa338f68e1e: [OpenMP][OMPIRBuilder] Mirgrate getName from clang to OMPIRBuilder (authored by jsjodin). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github

[clang] 2aa338f - [OpenMP][OMPIRBuilder] Mirgrate getName from clang to OMPIRBuilder

Author: Jan Sjodin Date: 2022-11-24T10:11:13-05:00 New Revision: 2aa338f68e1ee414680f0f08939dd8015b97d014 URL: https://github.com/llvm/llvm-project/commit/2aa338f68e1ee414680f0f08939dd8015b97d014 DIFF: https://github.com/llvm/llvm-project/commit/2aa338f68e1ee414680f0f08939dd8015b97d014.diff

[PATCH] D138655: [clang-tidy] Fix `cppcoreguidelines-init-variables` for invalid vardecl

Eugene.Zelenko added a comment. Will be good idea to add test for this situation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138655/new/ https://reviews.llvm.org/D138655 ___ cfe-commits mailing list

[PATCH] D90568: [clang] Add [is|set]Nested methods to NamespaceDecl

thakis added a comment. My bots look happy at least. Thanks for the quick fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90568/new/ https://reviews.llvm.org/D90568 ___ cfe-commits mailing list

[PATCH] D138668: Correct typos

Sprite created this revision. Sprite added a project: LLVM. Herald added subscribers: Moerafaat, zero9178, steakhal, bzcheeseman, kosarev, sdasgup3, carlosgalvezp, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, martong, Joonsoo, kerbowa,

[PATCH] D112621: [analyzer][solver] Introduce reasoning for not equal to operator

steakhal added a comment. In D112621#3915822 , @manas wrote: > Ping `Analysis/constant-folding.c` seems to fail. Please run the `check-clang-analysis` build target to see what fails and investigate it. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D138649: [include-cleaner] Show details for #include directives (used/unused)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3e658abd4147: [include-cleaner] Show details for #include directives (used/unused) (authored by sammccall). Repository: rG LLVM Github Monorepo

[clang-tools-extra] 3e658ab - [include-cleaner] Show details for #include directives (used/unused)

Author: Sam McCall Date: 2022-11-24T15:36:44+01:00 New Revision: 3e658abd41475640f7460e132513d20e8e332ae7 URL: https://github.com/llvm/llvm-project/commit/3e658abd41475640f7460e132513d20e8e332ae7 DIFF: https://github.com/llvm/llvm-project/commit/3e658abd41475640f7460e132513d20e8e332ae7.diff

[PATCH] D138649: [include-cleaner] Show details for #include directives (used/unused)

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. The demo is really nice! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138649/new/ https://reviews.llvm.org/D138649

[PATCH] D138489: [tsan] Add tsan support for loongarch64

SixWeining added inline comments. Comment at: compiler-rt/lib/sanitizer_common/sanitizer_linux.cpp:1543 +"r"(__fn), "r"(__arg), "r"(nr_clone), "i"(__NR_exit) + : "memory"); + return res; tangyouling wrote: > SixWeining wrote: > > Shall we list

[PATCH] D137652: Remove mandatory define of optional features macros for OpenCL C 3.0

svenvh added inline comments. Comment at: clang/include/clang/Basic/OpenCLExtensions.def:123 +OPENCL_OPTIONALCOREFEATURE(__opencl_c_work_group_collective_functions, false, 300, OCL_C_30) +OPENCL_OPTIONALCOREFEATURE(__opencl_c_int64, false, 300, OCL_C_30) I am

[clang-tools-extra] 0cb2dd5 - [include-cleaner] Make Symbol (and Macro) hashable.

Author: Sam McCall Date: 2022-11-24T15:15:50+01:00 New Revision: 0cb2dd5322f494769a7c31c8ed8aab930919f5f3 URL: https://github.com/llvm/llvm-project/commit/0cb2dd5322f494769a7c31c8ed8aab930919f5f3 DIFF: https://github.com/llvm/llvm-project/commit/0cb2dd5322f494769a7c31c8ed8aab930919f5f3.diff

[PATCH] D138648: [include-cleaner] Make Symbol (and Macro) hashable.

This revision was automatically updated to reflect the committed changes. Closed by commit rG0cb2dd5322f4: [include-cleaner] Make Symbol (and Macro) hashable. (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D138648?vs=477723=477768#toc Repository: rG LLVM Github

[clang] a72609c - [Format] Don't crash on mismatched brackets

Author: Sam McCall Date: 2022-11-24T15:14:06+01:00 New Revision: a72609cabef4c5f5afa3811575a3963830cb13dd URL: https://github.com/llvm/llvm-project/commit/a72609cabef4c5f5afa3811575a3963830cb13dd DIFF: https://github.com/llvm/llvm-project/commit/a72609cabef4c5f5afa3811575a3963830cb13dd.diff

[PATCH] D138583: Create unused non-trivially-destructible check in clang-tidy

sammccall added a comment. Extending --warn-unused to other types seems preferable in a few ways: - clang warnings are more accessible than clang-tidy checks - avoids duplicating implementation - places description of the types along with the types, instead of in clang-tidy config - avoids

[PATCH] D90568: [clang] Add [is|set]Nested methods to NamespaceDecl

njames93 added a comment. In D90568#3949134 , @thakis wrote: > This breaks the build: http://45.33.8.238/linux/92294/step_4.txt > > Please take a look and revert for now if it takes a while to fix. Apologies it took 2 times, It should all be good now,

[PATCH] D132952: [Sema] disable -Wvla for function array parameters

inclyc abandoned this revision. inclyc added a comment. Prefer https://reviews.llvm.org/D137343 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132952/new/ https://reviews.llvm.org/D132952 ___ cfe-commits

[PATCH] D136156: [Clang][Diagnostic] Add hidden-reinterpret-cast diagnostic warning

TWeaver added a comment. Hello all, First of all, thank you so much for your reviews, comments and time. Secondly, I apologise for the late reply. I've be thinking about your statements and I have to somewhat agree. This doesn't catch undefined behaviour, at least by its self. It may help

[PATCH] D129156: Add -fpass-plugin option to Flang

ro added a comment. In D129156#3949194 , @awarzynski wrote: > > Sorry that you are hitting this - things like this happen, sadly. I think > that the easiest to resolve it would be to tweak the expected error so that > it works on Solaris as well

[PATCH] D138651: [CUDA][HIP] Don't diagnose use for __bf16

Pierre-vh updated this revision to Diff 477760. Pierre-vh added a comment. Not all targets have bf16 and AuxTarget may not be available all the time so I changed the condition slightly Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138651/new/

[PATCH] D138559: Record macro references in #ifdef clause.

This revision was automatically updated to reflect the committed changes. Closed by commit rG6ebd0aa42066: [include-cleaner] Record macro references in #ifdef clause. (authored by VitaNuo, committed by hokein). Changed prior to commit: https://reviews.llvm.org/D138559?vs=477722=477759#toc

[clang-tools-extra] 6ebd0aa - [include-cleaner] Record macro references in #ifdef clause.

Author: Viktoriia Bakalova Date: 2022-11-24T14:48:25+01:00 New Revision: 6ebd0aa42066dd1879217b260704571e440ce5ef URL: https://github.com/llvm/llvm-project/commit/6ebd0aa42066dd1879217b260704571e440ce5ef DIFF:

[PATCH] D138649: [include-cleaner] Show details for #include directives (used/unused)

sammccall added a comment. Demo https://htmlpreview.github.io/?https://gist.githubusercontent.com/sam-mccall/24f7bcf835052d4ddcf6dad4f26a500c/raw/db4791b0b80f5c67c6d25c9090bf8166e362c556/PathMapping.cpp.html Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D138579: [AArch64] Assembly support for FEAT_LRCPC3

lenary added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.td:8572 + def STLR_x_64 : BaseLRCPC3IntegerLoadStore<0b11, 0b10, (outs GPR64sp:$Rn_wb) , (ins GPR64:$Rt, GPR64sp:$Rn), "stlr" , "\t$Rt, [$Rn, #-8]!", "$Rn = $Rn_wb">; /* PUSH register

[PATCH] D129156: Add -fpass-plugin option to Flang

awarzynski added a comment. In D129156#3949156 , @ro wrote: > This introduced a new failure on Solaris: > > FAIL: Flang :: Driver/pass-plugin-not-found.f90 > > Running the failing command manually shows: > > error: unable to load plugin 'X.Y': 'Could

[PATCH] D138651: [CUDA][HIP] Don't diagnose use for __bf16

Pierre-vh planned changes to this revision. Pierre-vh added a comment. Need to fix a test crash Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138651/new/ https://reviews.llvm.org/D138651 ___ cfe-commits

[PATCH] D138583: Create unused non-trivially-destructible check in clang-tidy

ankineri requested review of this revision. ankineri added a comment. `-Wunused-variable` does not detect unused non-trivially-destructible objects because they may be used for RAII, i.e. { scoped_lock lock(_mutex); critical_section(); } `lock` here is not an unused variable

[PATCH] D129156: Add -fpass-plugin option to Flang

ro added a comment. This introduced a new failure on Solaris: FAIL: Flang :: Driver/pass-plugin-not-found.f90 Running the failing command manually shows: error: unable to load plugin 'X.Y': 'Could not load library 'X.Y': ld.so.1: flang-new: X.Y: open failed: No such file or directory'

[PATCH] D138559: Record macro references in #ifdef clause.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks, LGTM. I will commit it for you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138559/new/ https://reviews.llvm.org/D138559

[PATCH] D90568: [clang] Add [is|set]Nested methods to NamespaceDecl

thakis added a comment. This breaks the build: http://45.33.8.238/linux/92294/step_4.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90568/new/ https://reviews.llvm.org/D90568

[PATCH] D108230: [analyzer] Ignore single element arrays in getStaticSize() conditionally

steakhal added a comment. I proposed the D138657 and D138659 patches for getting rid of this flag. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108230/new/

[PATCH] D138659: [analyzer] Deprecate FAM analyzer-config, recommend -fstrict-flex-arrays instead

steakhal created this revision. steakhal added reviewers: NoQ, xazax.hun. Herald added subscribers: manas, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. Herald added a reviewer: Szelethus. Herald added a project: All.

[PATCH] D90568: [clang] Add [is|set]Nested methods to NamespaceDecl

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG15e76eed0c76: [clang] Add [is|set]Nested methods to NamespaceDecl (authored by njames93). Changed prior to commit:

[clang] 15e76ee - [clang] Add [is|set]Nested methods to NamespaceDecl

Author: Nathan James Date: 2022-11-24T12:44:35Z New Revision: 15e76eed0c7662f8a4bce849a58637070d3b0a75 URL: https://github.com/llvm/llvm-project/commit/15e76eed0c7662f8a4bce849a58637070d3b0a75 DIFF: https://github.com/llvm/llvm-project/commit/15e76eed0c7662f8a4bce849a58637070d3b0a75.diff LOG:

[PATCH] D138657: [analyzer] Consider single-elem arrays as FAMs by default

steakhal created this revision. steakhal added reviewers: NoQ, xazax.hun. Herald added subscribers: manas, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. Herald added a reviewer: Szelethus. Herald added a project: All.

[PATCH] D138648: [include-cleaner] Make Symbol (and Macro) hashable.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Comment at: clang-tools-extra/include-cleaner/include/clang-include-cleaner/Types.h:147 + using Outer = clang::include_cleaner::Symbol; + constexpr

[PATCH] D138583: Create unused non-trivially-destructible check in clang-tidy

njames93 requested changes to this revision. njames93 added a comment. This revision now requires changes to proceed. Clang already has a warning `-Wunused-variable` that is designed for this specific purpose. So unless this is bringing anything enhanced functionality I don't see the need for

[PATCH] D138579: [AArch64] Assembly support for FEAT_LRCPC3

dmgreen added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64InstrFormats.td:11772 + : I, +Sched<[]> { + bits<5> Rt; One extra nit: Can we add a scheduling description? These sound like they can use WriteAtomic. Repository: rG

[PATCH] D138655: [clang-tidy] Fix `cppcoreguidelines-init-variables` for invalid vardecl

Sockke created this revision. Sockke added a reviewer: aaron.ballman. Herald added subscribers: carlosgalvezp, shchenz, kbarton, xazax.hun, nemanjai. Herald added a reviewer: njames93. Herald added a project: All. Sockke requested review of this revision. Herald added a project: clang-tools-extra.

[PATCH] D70401: [RISCV] Complete RV32E/ilp32e implementation

pcwang-thead added a comment. In D70401#3948829 , @StephenFan wrote: > In D70401#3873874 , @pcwang-thead > wrote: > >> In D70401#3873347 , @luojia wrote: >> >>> Hello! Any

[PATCH] D137340: [clang-tidy] Add misc-use-anonymous-namespace check

carlosgalvezp added a comment. Another week, another ping @njames93 @aaron.ballman I have addressed all comments since 3 weeks ago, and have not received any objections. I intend to land this patch next week (1st December) if I don't receive any further feedback. Repository: rG LLVM Github

[PATCH] D137531: [clang] Add the check of membership in decltype for the issue #58674

lime updated this revision to Diff 477737. lime added a comment. Undo unrelated format changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137531/new/ https://reviews.llvm.org/D137531 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaExpr.cpp

[PATCH] D137531: [clang] Add the check of membership in decltype for the issue #58674

lime updated this revision to Diff 477735. lime added a comment. Rebase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137531/new/ https://reviews.llvm.org/D137531 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaExpr.cpp clang/test/SemaCXX/decltype.cpp Index:

[PATCH] D138651: [CUDA][HIP] Don't diagnose use for __bf16

Pierre-vh updated this revision to Diff 477734. Pierre-vh added a comment. Add newline at end of file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138651/new/ https://reviews.llvm.org/D138651 Files: clang/lib/AST/ASTContext.cpp

[PATCH] D138579: [AArch64] Assembly support for FEAT_LRCPC3

lenary accepted this revision. lenary added a comment. This revision is now accepted and ready to land. Some comment nits that you can fixup on commit. Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.td:3913 +// are post-indexed, and the immediate values are not inside

[PATCH] D138630: [modules] Fix marking `ObjCMethodDecl::isOverriding` when there a no overrides.

egorzhdan accepted this revision. egorzhdan added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138630/new/ https://reviews.llvm.org/D138630

[PATCH] D138651: [CUDA][HIP] Don't diagnose use for __bf16

Pierre-vh created this revision. Pierre-vh added reviewers: arsenm, rjmccall, tra. Herald added subscribers: kosarev, mattd, kerbowa, pengfei, tpr, yaxunl, jvesely. Herald added a project: All. Pierre-vh requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, wdng.

[PATCH] D138649: [include-cleaner] Show details for #include directives (used/unused)

sammccall created this revision. sammccall added a reviewer: hokein. Herald added a project: All. sammccall requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D138649

[PATCH] D138648: [include-cleaner] Make Symbol (and Macro) hashable.

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added a project: All. sammccall requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. For now, we decided not to add operator< or handle other variants.

[PATCH] D70401: [RISCV] Complete RV32E/ilp32e implementation

StephenFan added a comment. In D70401#3873874 , @pcwang-thead wrote: > In D70401#3873347 , @luojia wrote: > >> Hello! Any further updates to this patch? It seems like all the inline >> comments have been

[PATCH] D138559: Record macro references in #ifdef clause.

VitaNuo updated this revision to Diff 477722. VitaNuo added a comment. Simplify test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138559/new/ https://reviews.llvm.org/D138559 Files: clang-tools-extra/include-cleaner/lib/Record.cpp

[PATCH] D138559: Record macro references in #ifdef clause.

VitaNuo added inline comments. Comment at: clang-tools-extra/include-cleaner/unittests/RecordTest.cpp:249 + + Inputs.Code = MainFile.code(); + auto AST = build(); hokein wrote: > The `elifndef` and `elifdef` is a C++2b extension feature, so >

[PATCH] D138559: Record macro references in #ifdef clause.

VitaNuo updated this revision to Diff 477721. VitaNuo added a comment. Add -std=c++2b argument to avoid compiler warnings. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138559/new/ https://reviews.llvm.org/D138559 Files:

[PATCH] D138559: Record macro references in #ifdef clause.

hokein added inline comments. Comment at: clang-tools-extra/include-cleaner/unittests/RecordTest.cpp:235 + +int main() { + #ifdef Y nit: we can get rid of the main function, it is not needed. Comment at:

[PATCH] D138559: Record macro references in #ifdef clause.

VitaNuo updated this revision to Diff 477716. VitaNuo added a comment. Formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138559/new/ https://reviews.llvm.org/D138559 Files: clang-tools-extra/include-cleaner/lib/Record.cpp

[PATCH] D138559: Record macro references in #ifdef clause.

VitaNuo added inline comments. Comment at: clang-tools-extra/include-cleaner/unittests/RecordTest.cpp:248 + SourceManager = AST.sourceManager(); + ASSERT_THAT(Recorded.MacroReferences, Not(IsEmpty())); + hokein wrote: > nit: this can be removed, as the

[PATCH] D138559: Record macro references in #ifdef clause.

VitaNuo added inline comments. Comment at: clang-tools-extra/include-cleaner/lib/Record.cpp:95 private: - void recordMacroRef(const Token , const MacroInfo ) { + void recordMacroRef(const Token , const MacroInfo , RefType RT) { if (MI.isBuiltinMacro())

[PATCH] D138559: Record macro references in #ifdef clause.

VitaNuo updated this revision to Diff 477711. VitaNuo added a comment. Address review comments. Format and simplify code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138559/new/ https://reviews.llvm.org/D138559 Files:

[clang-tools-extra] 0780811 - [include-cleaner] Remove an unused local variable, NFC.

Author: Haojian Wu Date: 2022-11-24T11:05:34+01:00 New Revision: 078081171c4e916926e14e6204713f131f9ffb28 URL: https://github.com/llvm/llvm-project/commit/078081171c4e916926e14e6204713f131f9ffb28 DIFF: https://github.com/llvm/llvm-project/commit/078081171c4e916926e14e6204713f131f9ffb28.diff

[PATCH] D138559: Record macro references in #ifdef clause.

VitaNuo updated this revision to Diff 477707. VitaNuo added a comment. Add support for #if defined(X), #elifdef, #elifndef Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138559/new/ https://reviews.llvm.org/D138559 Files:

[PATCH] D137149: Use PassGate from LLVMContext if any otherwise global one

ebrevnov updated this revision to Diff 477706. ebrevnov added a comment. Herald added a project: Flang. Fixed build error in flang/lib/Frontend/FrontendActions.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137149/new/

[PATCH] D138559: Record macro references in #ifdef clause.

hokein added inline comments. Comment at: clang-tools-extra/include-cleaner/lib/Record.cpp:87 + void Ifdef(SourceLocation Loc, const Token , + const MacroDefinition ) override { +if (!Active) the indentation doesn't look right, running

  1   2   >