[PATCH] D139507: [Intrinsic] Add get.rounding as alias to flt.rounds and rename related DAG nodes

qiucf added a comment. In D139507#3978449 , @sepavloff wrote: > Thank you for working on this! > > Is there any reason why we should keep the old intrinsic? In case any user outside of clang references it (although I believe no), we can deprecate it

[PATCH] D139604: [PATCH] Github Issue: Create a check that warns about using %p printf specifier #43453

giannicrivello updated this revision to Diff 481154. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139604/new/ https://reviews.llvm.org/D139604 Files: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td clang/lib/StaticAnalyzer/Checkers/UnixAPIChecker.cpp Index:

[PATCH] D139604: [PATCH] Github Issue: Create a check that warns about using %p printf specifier #43453

giannicrivello created this revision. giannicrivello added reviewers: NoQ, tbaeder. giannicrivello added a project: clang. Herald added subscribers: steakhal, martong. Herald added a reviewer: sscalpone. Herald added projects: Flang, All. giannicrivello requested review of this revision. Herald

[PATCH] D139288: [Clang][LoongArch] Add intrinsic for csrrd, csrwr and csrxchg

This revision was automatically updated to reflect the committed changes. Closed by commit rG685bbe65f5c3: [Clang][LoongArch] Add intrinsic for csrrd, csrwr and csrxchg (authored by gonglingqin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 685bbe6 - [Clang][LoongArch] Add intrinsic for csrrd, csrwr and csrxchg

Author: gonglingqin Date: 2022-12-08T14:11:50+08:00 New Revision: 685bbe65f5c3617e79f52a5af827cee2ee0b6f45 URL: https://github.com/llvm/llvm-project/commit/685bbe65f5c3617e79f52a5af827cee2ee0b6f45 DIFF: https://github.com/llvm/llvm-project/commit/685bbe65f5c3617e79f52a5af827cee2ee0b6f45.diff

[clang-tools-extra] aee5910 - [clang-tools-extra] Use std::nullopt instead of None in comments (NFC)

Author: Kazu Hirata Date: 2022-12-07T20:22:27-08:00 New Revision: aee591003c0c1d2eb7f3e038aade820dab20d849 URL: https://github.com/llvm/llvm-project/commit/aee591003c0c1d2eb7f3e038aade820dab20d849 DIFF: https://github.com/llvm/llvm-project/commit/aee591003c0c1d2eb7f3e038aade820dab20d849.diff

[PATCH] D70253: [AArch64][SVE2] Implement remaining SVE2 floating-point intrinsics

Allen added inline comments. Herald added a project: All. Comment at: llvm/test/CodeGen/AArch64/sve2-intrinsics-fp-int-binary-logarithm.ll:31 +; CHECK-NEXT: ret + %out = call @llvm.aarch64.sve.flogb.nxv2f64( %a, +

[PATCH] D139287: [WIP][OpenMP] Introduce basic JIT support to OpenMP target offloading

tianshilei1992 added a comment. We probably want to enable a new test configuration to have each test run in JIT mode. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139287/new/ https://reviews.llvm.org/D139287

[PATCH] D138546: Clangd: Preserve target flags in system includes extractor

cpsauer added a comment. @kadircet, you were asking about what's requiring the use of query-driver--I'll reply over in the issue (as you suggest), keeping everything in one place. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138546/new/ https://reviews.llvm.org/D138546

[PATCH] D138546: Clangd: Preserve target flags in system includes extractor

cpsauer added a comment. @nridge, I took a shot at amending the test. Thanks for the pointer! Please me know if that looks good to you! The host-target cross-compile situation you hypothesize is exactly what caused me to notice this. Super common with Bazel. CHANGES SINCE LAST ACTION

[PATCH] D138546: Clangd: Preserve target flags in system includes extractor

cpsauer updated this revision to Diff 481141. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138546/new/ https://reviews.llvm.org/D138546 Files: clang-tools-extra/clangd/SystemIncludeExtractor.cpp clang-tools-extra/clangd/test/system-include-extractor.test Index:

[PATCH] D138546: Clangd: Preserve target flags in system includes extractor

cpsauer added a comment. Sorry for being so slow this time myself, guys. Took me a while to dig myself out of a deep inbox hole after Thanksgiving (US holiday). Really appreciate you all and your friendly responsiveness, especially as I get up to speed here. Repository: rG LLVM Github

[PATCH] D139496: [CMake] Use perf with LBR for clang-bolt (WIP)

Amir updated this revision to Diff 481138. Amir added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139496/new/ https://reviews.llvm.org/D139496

[PATCH] D127910: [Clang][AArch64] Add SME C intrinsics for load and store

bryanpkc updated this revision to Diff 481137. bryanpkc added a comment. Removed some diffs that weren't necessary. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127910/new/ https://reviews.llvm.org/D127910 Files:

[clang] 6133942 - [OpenMP][FIX] Remove AssertingVHs that outlive their values

Author: Johannes Doerfert Date: 2022-12-07T18:27:55-08:00 New Revision: 61339427961a4399174e3e69240de7d1ad403046 URL: https://github.com/llvm/llvm-project/commit/61339427961a4399174e3e69240de7d1ad403046 DIFF:

[PATCH] D127910: [Clang][AArch64] Add SME C intrinsics for load and store

bryanpkc marked 2 inline comments as done. bryanpkc added a comment. @david-arm, I have moved all the SME definitions into a new file, arm_sme.td. I have moved the common definitions into another file, arm_sve_sme_incl.td, which will be included by both arm_sve.td and arm_sme.td. SveEmitter has

[clang] b89b42b - [tsan] Add tsan support for loongarch64

Author: Youling Tang Date: 2022-12-08T10:08:49+08:00 New Revision: b89b42b31c4590bb01076ed52f1c781ff787e0ef URL: https://github.com/llvm/llvm-project/commit/b89b42b31c4590bb01076ed52f1c781ff787e0ef DIFF: https://github.com/llvm/llvm-project/commit/b89b42b31c4590bb01076ed52f1c781ff787e0ef.diff

[PATCH] D127910: [Clang][AArch64] Add SME C intrinsics for load and store

bryanpkc updated this revision to Diff 481132. bryanpkc marked 5 inline comments as done. bryanpkc edited the summary of this revision. bryanpkc added a comment. Herald added a subscriber: mgrang. Herald added a reviewer: aaron.ballman. Updated the patch according to review comments which suggest

[PATCH] D138489: [tsan] Add tsan support for loongarch64

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb89b42b31c45: [tsan] Add tsan support for loongarch64 (authored by tangyouling, committed by SixWeining). Repository: rG LLVM Github Monorepo

[PATCH] D129531: [clang][C++20] P0960R3 and P1975R0: Allow initializing aggregates from a parenthesized list of values

ayzhao added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:5380 + } + InitExprs.push_back(ER.get()); +} So the libc++ test compile failures are due to this line. One example of a failing unit test is

[PATCH] D139589: [clang][Fuchsia] Re-enable hwasan global instrumentation on hwasan multilibs

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139589/new/ https://reviews.llvm.org/D139589

[PATCH] D139052: [NFC][Profile] Access profile through VirtualFileSystem

akyrtzi added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1729 + if (!Opts.ProfileInstrumentUsePath.empty()) { +auto FS = llvm::vfs::getRealFileSystem(); +setPGOUseInstrumentor(Opts, Opts.ProfileInstrumentUsePath, *FS, Diags);

[PATCH] D125195: [asan][ARMCXXABI] Added missing asan poison array cookie hooks.

rsundahl added a comment. In D125195#3979478 , @vitalybuka wrote: > Is this still relevant? > If so, I would recommend to split ItaniumCXXABI from asan changes. I haven't proceeded with this because this would be ABI breaking. I intend to support the

[PATCH] D134687: [clang] Ensure correct metadata for relative vtables

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG003b6033e1b2: [clang] Ensure correct metadata for relative vtables (authored by leonardchan). Changed prior to commit:

[clang] 003b603 - [clang] Ensure correct metadata for relative vtables

Author: Leonard Chan Date: 2022-12-08T00:42:48Z New Revision: 003b6033e1b254dd96ddb341f375b73ee5bed2af URL: https://github.com/llvm/llvm-project/commit/003b6033e1b254dd96ddb341f375b73ee5bed2af DIFF: https://github.com/llvm/llvm-project/commit/003b6033e1b254dd96ddb341f375b73ee5bed2af.diff LOG:

[PATCH] D137996: Add support for a backdoor driver option that enables emitting header usage information in JSON to a file

ahatanak added a comment. abc87ad4ed6cc5e6568751f375d1c646edb502f7 should fix the failing test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137996/new/

[clang] abc87ad - Remove slash in check string to fix the test that is failng on windows

Author: Akira Hatanaka Date: 2022-12-07T16:17:29-08:00 New Revision: abc87ad4ed6cc5e6568751f375d1c646edb502f7 URL: https://github.com/llvm/llvm-project/commit/abc87ad4ed6cc5e6568751f375d1c646edb502f7 DIFF:

[PATCH] D137996: Add support for a backdoor driver option that enables emitting header usage information in JSON to a file

thakis added a comment. Looks like this breaks tests on windows: http://45.33.8.238/win/71451/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137996/new/

[PATCH] D137996: Add support for a backdoor driver option that enables emitting header usage information in JSON to a file

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3738ce05a70c: Add support for a backdoor driver option that enables emitting header (authored by ahatanak). Repository: rG LLVM Github Monorepo

[clang] 3738ce0 - Add support for a backdoor driver option that enables emitting header

Author: Akira Hatanaka Date: 2022-12-07T15:30:19-08:00 New Revision: 3738ce05a70cf97fc73a07b158a1726f61aed28b URL: https://github.com/llvm/llvm-project/commit/3738ce05a70cf97fc73a07b158a1726f61aed28b DIFF:

[clang-tools-extra] 49e75eb - [Bitcode(Reader|Writer)] Convert Optional to std::optional

Author: Krzysztof Parzyszek Date: 2022-12-07T15:27:38-08:00 New Revision: 49e75ebd854dee1fcf5729c264f4cfadf76e952d URL: https://github.com/llvm/llvm-project/commit/49e75ebd854dee1fcf5729c264f4cfadf76e952d DIFF:

[PATCH] D139589: [clang][Fuchsia] Re-enable hwasan global instrumentation on hwasan multilibs

leonardchan created this revision. leonardchan added reviewers: phosek, mcgrathr. leonardchan added a project: clang. Herald added a subscriber: abrachet. Herald added a project: All. leonardchan requested review of this revision. We can land this once we assert global instrumentation is enabled

[PATCH] D139586: [Clang][C++23] Lifetime extension in range-based for loops

rZhBoYao added a comment. Consider: struct T { const int *begin() const; const int *end() const; T () [[clang::lifetimebound]]; T t(); }; const T (const T [[clang::lifetimebound]]) { return t; } T g(); void foo() { for (auto e : f1(g())) {} for (auto e

[PATCH] D65753: Builtins: Add some v2f16 variants

arsenm abandoned this revision. arsenm added a comment. Herald added a project: All. Looks like __builtin_elementwise_* now exist to handle some of these operations for arbitrary vector elements CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65753/new/ https://reviews.llvm.org/D65753

[PATCH] D139496: [CMake] Use perf with LBR for clang-bolt (WIP)

Amir updated this revision to Diff 481078. Amir added a comment. Fix instrumentation and no-LBR modes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139496/new/ https://reviews.llvm.org/D139496 Files: clang/CMakeLists.txt

[PATCH] D139586: [Clang][C++23] Lifetime extension in range-based for loops

rZhBoYao created this revision. rZhBoYao added a reviewer: clang-language-wg. Herald added a project: All. rZhBoYao requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Implemented the C++23 paper P2718R0 Repository: rG LLVM Github Monorepo

[PATCH] D137826: [clang] Allow comparing pointers to string literals

tahonermann added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:12951-12954 + // ObjC's @encode() + if (isa(E->getLHS()->IgnoreParenImpCasts()) || + isa(E->getRHS()->IgnoreParenImpCasts())) return Error(E); tbaeder

[PATCH] D139547: [NFC] Correct argument comment typo

gAlfonso-bit added a comment. @MaskRay This should be a quickie Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139547/new/ https://reviews.llvm.org/D139547 ___ cfe-commits mailing list

[PATCH] D137488: [clang][Interp] Array initialization via string literal

tahonermann accepted this revision. tahonermann added a comment. This revision is now accepted and ready to land. This looks good to me now. I'm sorry for taking so long to return to review. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:1098-1099 + +unsigned N =

[PATCH] D137996: Add support for a backdoor driver option that enables emitting header usage information in JSON to a file

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM, thank you for working through this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137996/new/

[PATCH] D139580: Run clang-tidy on clang-tidy

gAlfonso-bit created this revision. gAlfonso-bit added projects: LLVM, clang-format, clang-tools-extra. Herald added subscribers: kadircet, carlosgalvezp, arphaman, zzheng, javed.absar, kbarton, nemanjai. Herald added a reviewer: njames93. Herald added a project: All. gAlfonso-bit requested

[PATCH] D139287: [WIP][OpenMP] Introduce basic JIT support to OpenMP target offloading

jdoerfert added a comment. All but a test and this looks good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139287/new/ https://reviews.llvm.org/D139287 ___ cfe-commits mailing list

[PATCH] D139570: Add -Wreturn-local-addr, GCC alias for -Wreturn-stack-address

cjdb accepted this revision. cjdb added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139570/new/ https://reviews.llvm.org/D139570 ___

[PATCH] D139148: Fix nullptr dereference found by Coverity static analysis tool

tahonermann added a comment. Here is a simple test case that fails the assertion in the current location. struct B { B(int, int); }; struct D : B { D() : B(0, 1) {} }; I spent a bit more time looking at the code and finally realized that `Initializer` is only assigned when

[PATCH] D139287: [WIP][OpenMP] Introduce basic JIT support to OpenMP target offloading

jhuber6 added a comment. We should probably make a test for this. Do we currently test the nextgen plugins? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139287/new/ https://reviews.llvm.org/D139287

[PATCH] D129448: [CodeGen][Asan] Emit lifetime intrinsic for bypassed label

vitalybuka requested changes to this revision. vitalybuka added a comment. This revision now requires changes to proceed. Abandon? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129448/new/ https://reviews.llvm.org/D129448

[PATCH] D115103: Leak Sanitizer port to Windows

vitalybuka added a comment. You probably can try to finish pure lsan, and then get back to lsan+asan. So if you continue to work please send smaller and ready pieces for review? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115103/new/ https://reviews.llvm.org/D115103

[PATCH] D115103: Leak Sanitizer port to Windows

clemenswasser updated this revision to Diff 481042. clemenswasser added a comment. @vitalybuka I've been working on this on-off for the past months and have gotten the tests in the following state: Unsupported: 41 Passed : 19 Failed : 48 There is still the bug with the tracer

[PATCH] D125195: [asan][ARMCXXABI] Added missing asan poison array cookie hooks.

vitalybuka requested changes to this revision. vitalybuka added a comment. This revision now requires changes to proceed. Herald added a subscriber: Enna1. Is this still relevant? If so, I would recommend to split ItaniumCXXABI from asan changes. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D115103: Leak Sanitizer port to Windows

vitalybuka requested changes to this revision. vitalybuka added a comment. This revision now requires changes to proceed. Herald added a subscriber: Enna1. Is this still relevant? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115103/new/ https://reviews.llvm.org/D115103

[PATCH] D119621: [SanitizerCoverage] Add instrumentation callbacks for FP cmp instructions

vitalybuka requested changes to this revision. vitalybuka added a comment. This revision now requires changes to proceed. Herald added a subscriber: Enna1. Please update if it's still relevant CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119621/new/ https://reviews.llvm.org/D119621

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam added inline comments. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:572 PrioritizedCXXGlobalInits.push_back(std::make_pair(Key, Fn)); + } else if (D->hasConstantInitialization() && !(D->hasAttr())) { +OrderGlobalInitsOrStermFinalizers Key(201,

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam updated this revision to Diff 481029. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137107/new/ https://reviews.llvm.org/D137107 Files: clang/include/clang/Basic/DiagnosticCommonKinds.td clang/lib/AST/ExprConstant.cpp clang/lib/CodeGen/CGDeclCXX.cpp

[PATCH] D139287: [WIP][OpenMP] Introduce basic JIT support to OpenMP target offloading

tianshilei1992 updated this revision to Diff 481023. tianshilei1992 added a comment. add build components Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139287/new/ https://reviews.llvm.org/D139287 Files:

[PATCH] D139458: [clangd] Full support for #import insertions

dgoldman updated this revision to Diff 481022. dgoldman added a comment. Add tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139458/new/ https://reviews.llvm.org/D139458 Files: clang-tools-extra/clangd/ASTSignals.cpp

[libunwind] c9aff5d - Revert "[libunwind] Use .irp directives. NFC"

Author: David Tenty Date: 2022-12-07T15:41:29-05:00 New Revision: c9aff5d2f9d93636009ae389824f3beacfcbc7b7 URL: https://github.com/llvm/llvm-project/commit/c9aff5d2f9d93636009ae389824f3beacfcbc7b7 DIFF: https://github.com/llvm/llvm-project/commit/c9aff5d2f9d93636009ae389824f3beacfcbc7b7.diff

[PATCH] D139395: Add CFI integer types normalization

rcvalle updated this revision to Diff 481016. rcvalle added a comment. Updated tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139395/new/ https://reviews.llvm.org/D139395 Files: clang/docs/ControlFlowIntegrity.rst

[PATCH] D139287: [WIP][OpenMP] Introduce basic JIT support to OpenMP target offloading

tianshilei1992 marked 5 inline comments as done. tianshilei1992 added inline comments. Comment at: openmp/libomptarget/plugins-nextgen/common/PluginInterface/CMakeLists.txt:24 else() llvm_map_components_to_libnames(llvm_libs Support) endif() Have to figure

[PATCH] D139287: [WIP][OpenMP] Introduce basic JIT support to OpenMP target offloading

tianshilei1992 updated this revision to Diff 481014. tianshilei1992 added a comment. Herald added a subscriber: aheejin. drop LTO and fix comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139287/new/ https://reviews.llvm.org/D139287 Files:

[PATCH] D139570: Add -Wreturn-local-addr, GCC alias for -Wreturn-stack-address

adriandole created this revision. Herald added a subscriber: jeroen.dobbelaere. Herald added a project: All. adriandole requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D139570

[clang] 6cac3dc - [clang] Tweak test to tolerate clang being called "clang" instead of "clang-15"

Author: Nico Weber Date: 2022-12-07T15:03:35-05:00 New Revision: 6cac3dc9db57cbf5f9f9092d97f878be3db5020d URL: https://github.com/llvm/llvm-project/commit/6cac3dc9db57cbf5f9f9092d97f878be3db5020d DIFF: https://github.com/llvm/llvm-project/commit/6cac3dc9db57cbf5f9f9092d97f878be3db5020d.diff

[PATCH] D137275: [Driver][test] Fix test by creating empty archive instead of empty file

lamb-j added a comment. @thakis thanks for reverting that, sorry I didn't see your request sooner! I've switched the patch to use "llvm-ar" instead of "ar", which should solve the issues Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137275/new/

[clang] f9de860 - [Driver][test] Fix test by creating empty archive instead of empty file

Author: Jacob Lambert Date: 2022-12-07T11:50:11-08:00 New Revision: f9de860ca4c4b5827498dc096a26d9ebdf236181 URL: https://github.com/llvm/llvm-project/commit/f9de860ca4c4b5827498dc096a26d9ebdf236181 DIFF: https://github.com/llvm/llvm-project/commit/f9de860ca4c4b5827498dc096a26d9ebdf236181.diff

[PATCH] D136497: [Clang] support for outputs along indirect edges of asm goto

nickdesaulniers added a comment. Probably should copy the release note change from https://reviews.llvm.org/D138078. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136497/new/ https://reviews.llvm.org/D136497

[PATCH] D139564: clang: Don't emit "frame-pointer"="none"

aaron.ballman added reviewers: rjmccall, efriedma. aaron.ballman added a comment. Adding codegen code owners in for awareness, but in general I think this is a good cleanup. Thank you! Assuming the bots are happy, this LGTM, but please give the codegen folks a chance to speak up before landing.

[PATCH] D136497: [Clang] support for outputs along indirect edges of asm goto

nickdesaulniers updated this revision to Diff 480993. nickdesaulniers edited the summary of this revision. nickdesaulniers added a comment. - rebase, use new callbrpad inst Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136497/new/

[PATCH] D139052: [NFC][Profile] Access profile through VirtualFileSystem

benlangmuir accepted this revision. benlangmuir added a comment. This revision is now accepted and ready to land. All my comments are addressed, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139052/new/ https://reviews.llvm.org/D139052

[PATCH] D137113: [Clang] refactor CodeGenFunction::EmitAsmStmt NFC

nickdesaulniers updated this revision to Diff 480992. nickdesaulniers added a comment. - rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137113/new/ https://reviews.llvm.org/D137113 Files: clang/lib/CodeGen/CGStmt.cpp Index:

[PATCH] D136554: Implement CWG2631

aaron.ballman accepted this revision. aaron.ballman added a comment. The new changes LGTM as well and the bots seem to be happy with things. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136554/new/ https://reviews.llvm.org/D136554

[PATCH] D139564: clang: Don't emit "frame-pointer"="none"

arsenm created this revision. arsenm added a reviewer: aaron.ballman. Herald added subscribers: kosarev, jdoerfert, jvesely. Herald added a project: All. arsenm requested review of this revision. Herald added subscribers: sstefan1, wdng. Herald added a reviewer: jdoerfert. This is the default

[PATCH] D139052: [NFC][Profile] Access profile through VirtualFileSystem

steven_wu added inline comments. Comment at: clang/lib/CodeGen/CodeGenAction.cpp:164 LLVMIRGenerationRefCount(0), - Gen(CreateLLVMCodeGen(Diags, InFile, std::move(FS), HeaderSearchOpts, -PPOpts, CodeGenOpts, C, CoverageInfo)),

[PATCH] D139052: [NFC][Profile] Access profile through VirtualFileSystem

steven_wu updated this revision to Diff 480990. steven_wu marked 13 inline comments as done. steven_wu added a comment. Address review feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139052/new/ https://reviews.llvm.org/D139052 Files:

[PATCH] D137343: [clang] add -Wvla-stack-allocation

aaron.ballman added reviewers: clang-language-wg, rjmccall. aaron.ballman added a comment. In D137343#3978313 , @inclyc wrote: > ping :) Thank you for your patience until I could get to this! I've added a few more reviewers for additional opinions on

[PATCH] D139496: [CMake] Use perf with LBR for clang-bolt (WIP)

Amir updated this revision to Diff 480982. Amir added a comment. Avoid using perf2bolt, provide perf.data directly Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139496/new/ https://reviews.llvm.org/D139496 Files: clang/CMakeLists.txt

[PATCH] D139154: [clang-doc] Add template support

brettw updated this revision to Diff 480979. brettw added a comment. New patch with llvm::Optional converted to std::optional (previously collided with a refactor). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139154/new/ https://reviews.llvm.org/D139154 Files:

[PATCH] D138722: Overload all llvm.annotation intrinsics for globals argument

jrtc27 added inline comments. Comment at: clang/test/CodeGen/annotations-field.c:5 -// CHECK: private unnamed_addr constant [8 x i8] c"v_ann_{{.}}\00", section "llvm.metadata" -// CHECK: private unnamed_addr constant [8 x i8] c"v_ann_{{.}}\00", section "llvm.metadata" +//

[clang] 9114ac6 - Overload all llvm.annotation intrinsics for globals argument

Author: Alex Richardson Date: 2022-12-07T18:29:18Z New Revision: 9114ac67a986400155b8b82013d09a9e4f48e534 URL: https://github.com/llvm/llvm-project/commit/9114ac67a986400155b8b82013d09a9e4f48e534 DIFF: https://github.com/llvm/llvm-project/commit/9114ac67a986400155b8b82013d09a9e4f48e534.diff

[PATCH] D138722: Overload all llvm.annotation intrinsics for globals argument

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. arichardson marked 2 inline comments as done. Closed by commit rG9114ac67a986: Overload all llvm.annotation intrinsics for globals argument (authored by arichardson).

[PATCH] D137872: Implement lambdas with inalloca parameters by forwarding to function without inalloca calling convention.

akhuang added a comment. ping @efriedma, do you mind looking at this again? thanks! Comment at: clang/include/clang/CodeGen/CGFunctionInfo.h:571 + /// Whether this function should avoid inalloca arguments. + unsigned DontInAlloca: 1; + rnk wrote: > This is

[clang-tools-extra] 91b38c6 - Revert "[clang-doc] Add template support."

Author: Brett Wilson Date: 2022-12-07T10:22:51-08:00 New Revision: 91b38c6aaddefabad2a4c959ea3865e356761ed5 URL: https://github.com/llvm/llvm-project/commit/91b38c6aaddefabad2a4c959ea3865e356761ed5 DIFF: https://github.com/llvm/llvm-project/commit/91b38c6aaddefabad2a4c959ea3865e356761ed5.diff

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

efriedma added inline comments. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:572 PrioritizedCXXGlobalInits.push_back(std::make_pair(Key, Fn)); + } else if (D->hasConstantInitialization() && !(D->hasAttr())) { +OrderGlobalInitsOrStermFinalizers Key(201,

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam added inline comments. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:572 PrioritizedCXXGlobalInits.push_back(std::make_pair(Key, Fn)); + } else if (D->hasConstantInitialization() && !(D->hasAttr())) { +OrderGlobalInitsOrStermFinalizers Key(201,

[PATCH] D139197: [clang-tidy] Do not warn about redundant static in misc-use-anonymous-namespace

aaron.ballman added a comment. In D139197#3978761 , @carlosgalvezp wrote: > In D139197#3978488 , @aaron.ballman > wrote: > >> LGTM, though please add a release note describing the change > > The original check

[PATCH] D139154: [clang-doc] Add template support

This revision was automatically updated to reflect the committed changes. Closed by commit rG0f6dbb5f1646: [clang-doc] Add template support. (authored by brettw). Changed prior to commit: https://reviews.llvm.org/D139154?vs=480560=480960#toc Repository: rG LLVM Github Monorepo CHANGES

[clang-tools-extra] 0f6dbb5 - [clang-doc] Add template support.

Author: Brett Wilson Date: 2022-12-07T09:48:13-08:00 New Revision: 0f6dbb5f164662c3e6a167a89e7a89f07c60e32b URL: https://github.com/llvm/llvm-project/commit/0f6dbb5f164662c3e6a167a89e7a89f07c60e32b DIFF: https://github.com/llvm/llvm-project/commit/0f6dbb5f164662c3e6a167a89e7a89f07c60e32b.diff

[PATCH] D139197: [clang-tidy] Do not warn about redundant static in misc-use-anonymous-namespace

carlosgalvezp added a comment. PS thanks a lot for the review! :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139197/new/ https://reviews.llvm.org/D139197 ___ cfe-commits mailing list

[PATCH] D139197: [clang-tidy] Do not warn about redundant static in misc-use-anonymous-namespace

carlosgalvezp added a comment. In D139197#3978488 , @aaron.ballman wrote: > LGTM, though please add a release note describing the change The original check is just a few days old. It didn't exist in the previous release. Should I still add a comment

[PATCH] D134859: [clang][Interp] Implement basic support for floating point values

sepavloff added inline comments. Comment at: clang/lib/AST/Interp/Floating.h:109 +Floating RHS = B; +if (!A.compatibleWith(B)) + RHS = B.toSemantics(A, RM); tbaeder wrote: > sepavloff wrote: > > Do we really need this check? In AST operands of

[PATCH] D137269: [Clang][AArch64][Darwin] Enable GlobalISel by default for Darwin ARM64 platforms.

thakis added a comment. In D137269#3925163 , @thakis wrote: > Heads-up: This very visibly broke web page rendering in Chromium (but only > when using LTO) (https://crbug.com/1383873) . Not clear yet if this exposed > UB on our end or not. After

[PATCH] D139541: Fix parameter name in Sema::addInitCapture to ByRef.

shafik added inline comments. Comment at: clang/lib/Sema/SemaLambda.cpp:892-894 + LSI->addCapture(Var, /*isBlock*/ false, ByRef, /*isNested*/ false, Var->getLocation(), SourceLocation(), Var->getType(), /*Invalid*/ false);

[PATCH] D139507: [Intrinsic] Add get.rounding as alias to flt.rounds and rename related DAG nodes

RKSimon added a comment. In D139507#3978449 , @sepavloff wrote: > Thank you for working on this! > > Is there any reason why we should keep the old intrinsic? I'm not clear on the general policy, but for x86 we tend to provide bc of old

[PATCH] D139547: [NFC] Correct argument comment typo

gAlfonso-bit created this revision. gAlfonso-bit added a reviewer: MaskRay. gAlfonso-bit added projects: clang, LLVM. Herald added a subscriber: StephenFan. Herald added a project: All. gAlfonso-bit requested review of this revision. Herald added a subscriber: cfe-commits. For Darwin, the boolean

[PATCH] D139197: [clang-tidy] Do not warn about redundant static in misc-use-anonymous-namespace

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, though please add a release note describing the change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139197/new/

[clang] 40ade84 - Revert "Store OptTable::Info::Name as a StringRef"

Author: serge-sans-paille Date: 2022-12-07T17:29:53+01:00 New Revision: 40ade845be698355b230abc19c7a76b200188772 URL: https://github.com/llvm/llvm-project/commit/40ade845be698355b230abc19c7a76b200188772 DIFF:

[PATCH] D139197: [clang-tidy] Do not warn about redundant static in misc-use-anonymous-namespace

carlosgalvezp added a comment. @njames93 @JonasToth @LegalizeAdulthood Do you have any comments that I should address? If not, could you approve the patch? To recap: this check is a few days old (I added it myself). I realized there's functionality that shouldn't be here so I'm just removing

[PATCH] D139360: [clang][dataflow] Support (in)equality operators in `optional` model.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG390029be8946: [clang][dataflow] Support (in)equality operators in `optional` model. (authored by ymandel). Repository: rG LLVM Github Monorepo

[clang] 390029b - [clang][dataflow] Support (in)equality operators in `optional` model.

Author: Yitzhak Mandelbaum Date: 2022-12-07T16:24:49Z New Revision: 390029be8946cac807e8fc978b9cf3790e7456cc URL: https://github.com/llvm/llvm-project/commit/390029be8946cac807e8fc978b9cf3790e7456cc DIFF: https://github.com/llvm/llvm-project/commit/390029be8946cac807e8fc978b9cf3790e7456cc.diff

[PATCH] D139507: [Intrinsic] Add get.rounding as alias to flt.rounds and rename related DAG nodes

sepavloff added a comment. Thank you for working on this! Is there any reason why we should keep the old intrinsic? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139507/new/ https://reviews.llvm.org/D139507

[PATCH] D139398: [AMDGPU] Add bf16 storage support

arsenm added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPUCallingConv.td:49 + CCIfType<[bf16], CCBitConvertToType>, + CCIfType<[v2bf16], CCBitConvertToType>, CCIfNotInReghttps://reviews.llvm.org/D139398/new/ https://reviews.llvm.org/D139398

[PATCH] D139541: Fix parameter name in Sema::addInitCapture to ByRef.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM. BTW, feel free to send small changes like these without review. The common jargon for them in LLVM is NFC (non-functional change) Repository: rG LLVM Github Monorepo

  1   2   >