[PATCH] D135750: [clang][Interp] Track initialization state of local variables

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/InterpBlock.h:97 void invokeCtor() { -std::memset(data(), 0, getSize()); +std::memset(rawData(), 0, Desc->getAllocSize()); if (Desc->CtorFn) aaron.ballman wrote: > tbaeder wrote: > >

[PATCH] D139257: [clang-format] Link the braces of a block in UnwrappedLineParser

owenpan added a comment. See https://github.com/llvm/llvm-project/issues/59417. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139257/new/ https://reviews.llvm.org/D139257 ___ cfe-commits mailing list

[clang] c25cc84 - [clang] Don't including None.h (NFC)

Author: Kazu Hirata Date: 2022-12-08T23:36:50-08:00 New Revision: c25cc84b87935feefea5a93abc16efdbc9d91640 URL: https://github.com/llvm/llvm-project/commit/c25cc84b87935feefea5a93abc16efdbc9d91640 DIFF: https://github.com/llvm/llvm-project/commit/c25cc84b87935feefea5a93abc16efdbc9d91640.diff

[PATCH] D139387: [NFC][Clang] Add missing test cases for segment load

4vtomat updated this revision to Diff 481521. 4vtomat added a comment. Update failed test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139387/new/ https://reviews.llvm.org/D139387 Files:

[clang] 1f88fb4 - [clang] Use std::nullopt instead of None in comments (NFC)

Author: Kazu Hirata Date: 2022-12-08T22:43:11-08:00 New Revision: 1f88fb406cc323eb36fc5f18626915b4ba75560e URL: https://github.com/llvm/llvm-project/commit/1f88fb406cc323eb36fc5f18626915b4ba75560e DIFF: https://github.com/llvm/llvm-project/commit/1f88fb406cc323eb36fc5f18626915b4ba75560e.diff

[PATCH] D139686: [lsan] Add lsan support for loongarch64

tangyouling added inline comments. Comment at: compiler-rt/lib/lsan/lsan_common.cpp:281 +# elif defined(__loongarch_lp64) + return ((p >> 47) == 0); # else xen0n wrote: > tangyouling wrote: > > xen0n wrote: > > > Since our VM layout is actually flexible,

[PATCH] D139686: [lsan] Add lsan support for loongarch64

xen0n added inline comments. Comment at: compiler-rt/lib/lsan/lsan_common.cpp:281 +# elif defined(__loongarch_lp64) + return ((p >> 47) == 0); # else tangyouling wrote: > xen0n wrote: > > Since our VM layout is actually flexible, would it be better to

[PATCH] D129531: [clang][C++20] P0960R3 and P1975R0: Allow initializing aggregates from a parenthesized list of values

ayzhao added inline comments. Comment at: clang/lib/AST/JSONNodeDumper.cpp:852 case VarDecl::ListInit: JOS.attribute("init", "list"); break; +case VarDecl::ParenListInit: + JOS.attribute("init", "paren-list"); ilya-biryukov wrote: > ayzhao wrote: >

[PATCH] D129531: [clang][C++20] P0960R3 and P1975R0: Allow initializing aggregates from a parenthesized list of values

ayzhao added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:5380 + } + InitExprs.push_back(ER.get()); +} ayzhao wrote: > So the libc++ test compile failures are due to this line. > > One example of a failing unit test is >

[PATCH] D129531: [clang][C++20] P0960R3 and P1975R0: Allow initializing aggregates from a parenthesized list of values

ayzhao updated this revision to Diff 481508. ayzhao added a comment. rebase + (hopefully) fix libc++ c++2b test failures Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129531/new/ https://reviews.llvm.org/D129531 Files:

[PATCH] D139676: [libTooling] Add flag to getRangeForEdit to ignore macro expansions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. li.zhe.hua marked an inline comment as done. Closed by commit rGa78d4b5ba716: [libTooling] Add flag to getRangeForEdit to ignore macro expansions (authored by

[clang] a78d4b5 - [libTooling] Add flag to getRangeForEdit to ignore macro expansions

Author: Eric Li Date: 2022-12-08T22:40:10-05:00 New Revision: a78d4b5ba716d88a90b905c261f53e74e67a7367 URL: https://github.com/llvm/llvm-project/commit/a78d4b5ba716d88a90b905c261f53e74e67a7367 DIFF: https://github.com/llvm/llvm-project/commit/a78d4b5ba716d88a90b905c261f53e74e67a7367.diff LOG:

[PATCH] D139676: [libTooling] Add flag to getRangeForEdit to ignore macro expansions

li.zhe.hua marked 2 inline comments as done. li.zhe.hua added inline comments. Comment at: clang/lib/Tooling/Transformer/SourceCode.cpp:90-92 + Loc = Expansion.getExpansionLocStart(); + if (Loc.isFileID()) +return true; ymandel wrote: > can you

[PATCH] D139676: [libTooling] Add flag to getRangeForEdit to ignore macro expansions

li.zhe.hua updated this revision to Diff 481506. li.zhe.hua added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139676/new/ https://reviews.llvm.org/D139676 Files: clang/include/clang/Tooling/Transformer/SourceCode.h

[PATCH] D137059: [Driver] [C++20] [Modules] Support -fmodule-output= (2/2)

ChuanqiXu updated this revision to Diff 481504. ChuanqiXu retitled this revision from "[Driver] [Modules] Introduce -fsave-std-c++-module-file= to specify the path of the module file (2/2)" to "[Driver] [C++20] [Modules] Support -fmodule-output= (2/2)". ChuanqiXu added a comment. Rename the

[PATCH] D137058: [Driver] [Modules] Support -fmodule-output (1/2)

ChuanqiXu updated this revision to Diff 481503. ChuanqiXu marked 2 inline comments as done. ChuanqiXu retitled this revision from "[Driver] [Modules] Support -fsave-std-c++-module-file (1/2)" to "[Driver] [Modules] Support -fmodule-output (1/2)". ChuanqiXu added a comment. Rename the option

[PATCH] D139612: [Clang][LoongArch] Add intrinsic for iocsrrd and iocsrwr

xen0n accepted this revision. xen0n added a comment. This revision is now accepted and ready to land. This should be good enough (reminiscent of CSR ops) but let's wait for other reviewers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139612/new/

[PATCH] D139686: [lsan] Add lsan support for loongarch64

tangyouling added inline comments. Comment at: compiler-rt/lib/lsan/lsan_common.cpp:281 +# elif defined(__loongarch_lp64) + return ((p >> 47) == 0); # else xen0n wrote: > Since our VM layout is actually flexible, would it be better to document > this, like

[PATCH] D139676: [libTooling] Add flag to getRangeForEdit to ignore macro expansions

ymandel accepted this revision. ymandel added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Tooling/Transformer/SourceCode.cpp:90-92 + Loc = Expansion.getExpansionLocStart(); + if (Loc.isFileID()) +return true;

[PATCH] D139686: [lsan] Add lsan support for loongarch64

xen0n added inline comments. Comment at: compiler-rt/lib/lsan/lsan_common.cpp:281 +# elif defined(__loongarch_lp64) + return ((p >> 47) == 0); # else Since our VM layout is actually flexible, would it be better to document this, like "Support only the most

[PATCH] D139544: [clang][dataflow] Add support for structured bindings of tuple-like types.

ymandel added a comment. In D139544#3982821 , @isuckatcs wrote: >> the temporary's construction should appear before, but the binding decls, >> which use the synthetic variables, should appear after > > I'm confused a bit here. Right now the CFG looks

[PATCH] D138263: [clang-format] Supress aligning of trailing namespace comments

owenpan added a comment. In D138263#3975828 , @owenpan wrote: > Can you rebase (preferably after landing D138402 > )? See D139257#3983332 . If it gets reverted, we have to do

[PATCH] D139257: [clang-format] Link the braces of a block in UnwrappedLineParser

owenpan added a comment. I have second thoughts about linking block braces in `UnwrappedLineParser`. Consider the following example: #if A while (a) { // Linked to the r_brace below #else while(b) { // Also linked to the r_brace below #endif foo(); } // Linked to the l_brace of

[PATCH] D139233: [-Wunsafe-buffer-usage] Add an unsafe gadget for pointer-arithmetic operations

NoQ added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:374-375 + : UnsafeGadget(Kind::PointerArithmetic), +PA(Result.Nodes.getNodeAs("ptrAdd")), +Ptr(Result.Nodes.getNodeAs("ptrAddPtr")) {} + Let's unhardcode the

[PATCH] D139686: [lsan] Add lsan support for loongarch64

tangyouling added a comment. $ cat memory-leak.c #include void *p; int main() { p = malloc(7); p = 0; // The memory is leaked here. return 0; } $ ./build/bin/clang -fsanitize=address -g memory-leak.c ; ASAN_OPTIONS=detect_leaks=1 ./a.out

[PATCH] D139686: [lsan] Add lsan support for loongarch64

tangyouling created this revision. tangyouling added reviewers: Sanitizers, vitalybuka, SixWeining, xen0n, xry111, MaskRay, XiaodongLoong, lixing-star. Herald added subscribers: Enna1, StephenFan, s.egerton, simoncook. Herald added a project: All. tangyouling requested review of this revision.

[PATCH] D137346: [-Wunsafe-buffer-usage] Initial commit - Transition away from raw buffer accesses.

NoQ added inline comments. Comment at: clang/include/clang/Analysis/Analyses/UnsafeBufferUsage.h:17 + +#include "clang/ASTMatchers/ASTMatchFinder.h" + Ok so this is what caused the revert (https://lab.llvm.org/buildbot#builders/121/builds/25877): ```lines=10

[PATCH] D139653: [clang] Set ShowInSystemHeader for module-build and module-import remarks

vsapsai added a comment. From my experience, `ShowInSystemHeader` for `-Rmodule-build` is overall useful. I haven't heard from people who want no remarks from system headers and the rest is just hypothetical guesses that can go both ways (some people might like one option while some people

[clang] 3b7af27 - Revert "Revert "[-Wunsafe-buffer-usage] Initial commit - Transition away from raw buffers.""

Author: Artem Dergachev Date: 2022-12-08T16:57:59-08:00 New Revision: 3b7af2796b3d1a578b7e256f5e5b60e61108ec8d URL: https://github.com/llvm/llvm-project/commit/3b7af2796b3d1a578b7e256f5e5b60e61108ec8d DIFF:

[PATCH] D136515: [builtins] Add __builtin_assume_separate_storage.

davidtgoldblatt updated this revision to Diff 481481. davidtgoldblatt added a comment. Per review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136515/new/ https://reviews.llvm.org/D136515 Files: clang/include/clang/Basic/Builtins.def

[PATCH] D139148: Fix nullptr dereference found by Coverity static analysis tool

schittir updated this revision to Diff 481475. schittir edited the summary of this revision. schittir added a comment. Add assert at the beginning of blocks pointed out by Coverity CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139148/new/ https://reviews.llvm.org/D139148 Files:

[PATCH] D139652: Add the thread sanitizer support for X86_64 WatchOS simulators

yln accepted this revision. yln added a subscriber: rsundahl. yln added a comment. Thank you! LGTM, with one nit. @rsundahl: can you keep an eye on this and resolve potential conflicts? Thanks! Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:3280-3286 if ((IsX86_64 ||

[PATCH] D139137: add floor library function

This revision was automatically updated to reflect the committed changes. Closed by commit rG500e72924305: add floor library function (authored by bob80905). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139137/new/ https://reviews.llvm.org/D139137

[clang] 500e729 - add floor library function

Author: Joshua Batista Date: 2022-12-08T15:41:54-08:00 New Revision: 500e72924305c4a1fac2ffd45b16114d49c3a7d2 URL: https://github.com/llvm/llvm-project/commit/500e72924305c4a1fac2ffd45b16114d49c3a7d2 DIFF:

[PATCH] D138861: [Clang] Implement CWG2640 Allow more characters in an n-char sequence

tahonermann requested changes to this revision. tahonermann added a comment. This revision now requires changes to proceed. This looks really good. I added a suggested edit for a comment that I had a hard time understanding and noted an area of code that I'm not sure is working as expected.

[PATCH] D139676: [libTooling] Add flag to getRangeForEdit to ignore macro expansions

li.zhe.hua created this revision. li.zhe.hua added a reviewer: ymandel. Herald added a project: All. li.zhe.hua requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This commit resolves the FIXME around the behavior of

[PATCH] D139052: [NFC][Profile] Access profile through VirtualFileSystem

akyrtzi added inline comments. Comment at: llvm/include/llvm/Support/PGOOptions.h:18 #include "llvm/Support/Error.h" +#include "llvm/Support/VirtualFileSystem.h" steven_wu wrote: > akyrtzi wrote: > > akyrtzi wrote: > > > I'd suggest to consider moving the

[PATCH] D139653: [clang] Set ShowInSystemHeader for module-build and module-import remarks

kastiglione added a comment. > We could have a separate `-Ruser-module-{build,import}` (and maybe > `-Rsystem-module-{build,import}`) besides the `-Rmodule-{build,import}` (that > would now include both). that sounds good to me. I'll add tests if there are no objections. Repository: rG

[clang] 262c303 - Revert "[AMDGPU] Disable bool range metadata to workaround backend issue"

Author: Yaxun (Sam) Liu Date: 2022-12-08T17:35:10-05:00 New Revision: 262c3034bb44cac8b4ed6d4a3bb99ceb60d9e322 URL: https://github.com/llvm/llvm-project/commit/262c3034bb44cac8b4ed6d4a3bb99ceb60d9e322 DIFF:

[PATCH] D137051: [Clang] Allow additional mathematical symbols in identifiers.

tahonermann added a comment. Oh, also, the review summary mentions "UAX32" (twice); those should be "UAX31". Just please make sure the commit message is correct. Also, I'm terribly sorry for being so slow to get this reviewed! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D137051: [Clang] Allow additional mathematical symbols in identifiers.

tahonermann accepted this revision. tahonermann added a comment. This revision is now accepted and ready to land. This looks great to me. I added a minor comment regarding the grammar of the added diagnostic, but am accepting the review regardless. Comment at:

[PATCH] D139629: clang: Stop emitting "strictfp"

zahiraam added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:2135 -llvm::AttrBuilder FuncAttrs(F->getContext()); -FuncAttrs.addAttribute("strictfp"); -F->addFnAttrs(FuncAttrs); I think it would better to fix this function instead

[PATCH] D139544: [clang][dataflow] Add support for structured bindings of tuple-like types.

isuckatcs added a comment. > the temporary's construction should appear before, but the binding decls, > which use the synthetic variables, should appear after I'm confused a bit here. Right now the CFG looks like this: ... Based on what you say I assume you want something to

[PATCH] D139115: [clang][ExtractAPI] Add support for single symbol SGF

akyrtzi added inline comments. Comment at: clang/include/clang-c/Documentation.h:549 +typedef struct CXAPISetImpl *CXAPISet; + benlangmuir wrote: > @dang please document what this type represents. > > @akyrtzi what's the preferred implementation type name for

[PATCH] D139653: [clang] Set ShowInSystemHeader for module-build and module-import remarks

jansvoboda11 accepted this revision. jansvoboda11 added subscribers: vsapsai, Bigcheese. jansvoboda11 added a comment. This revision is now accepted and ready to land. In D139653#3982272 , @kastiglione wrote: >> Also, do you think this should be

[PATCH] D139166: [OPENMP51] Codegen support for error directive.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaf781f704239: [OPENMP51]Codegen for error directive. (authored by jyu2). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] af781f7 - [OPENMP51]Codegen for error directive.

Author: Jennifer Yu Date: 2022-12-08T13:07:08-08:00 New Revision: af781f7042392910c4cf70106c6a0c2244c69478 URL: https://github.com/llvm/llvm-project/commit/af781f7042392910c4cf70106c6a0c2244c69478 DIFF: https://github.com/llvm/llvm-project/commit/af781f7042392910c4cf70106c6a0c2244c69478.diff

[PATCH] D136176: Implement support for option 'fexcess-precision'.

zahiraam added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136176/new/ https://reviews.llvm.org/D136176 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D139400: [clang] Show error when a local variables is passed as default template parameter

shafik added inline comments. Comment at: clang/lib/Sema/SemaTemplate.cpp:11 +#include // massberg #include "TreeTransform.h" Please remove. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139400/new/

[PATCH] D139444: [ZOS] Convert tests to check 'target={{.*}}-zos'

probinson updated this revision to Diff 481421. probinson added a comment. Add trailing '{{.*}}' as requested. Have not changed the encoding.ll test, waiting on @uweigand about correct value to test in Python. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139444/new/

[PATCH] D139647: [opt] Disincentivize new tests from using old pass syntax

lebedev.ri added a comment. @aeubanks Thank you for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139647/new/ https://reviews.llvm.org/D139647 ___ cfe-commits mailing list

[clang] 5131f44 - Simplify clang/test/CodeGen/annotations-global.c CHECK lines

Author: Alex Richardson Date: 2022-12-08T20:44:40Z New Revision: 5131f444ee7045d58f72fc99e2ac69792e8b7158 URL: https://github.com/llvm/llvm-project/commit/5131f444ee7045d58f72fc99e2ac69792e8b7158 DIFF: https://github.com/llvm/llvm-project/commit/5131f444ee7045d58f72fc99e2ac69792e8b7158.diff

[clang] 121a89f - Fix annotations-field.c CHECK lines being ignored

Author: Alex Richardson Date: 2022-12-08T20:44:40Z New Revision: 121a89fc2aedf48ca4aee43288b67e27b71e72ed URL: https://github.com/llvm/llvm-project/commit/121a89fc2aedf48ca4aee43288b67e27b71e72ed DIFF: https://github.com/llvm/llvm-project/commit/121a89fc2aedf48ca4aee43288b67e27b71e72ed.diff

[PATCH] D139400: [clang] Show error when a local variables is passed as default template parameter

shafik added inline comments. Comment at: clang/test/SemaTemplate/default-template-arguments.cpp:9 + + auto lambda1 = [] {}; // expected-error {{default argument references local variable x of enclosing function}} + auto lambda2 = [] {}; To clarify my

[PATCH] D131830: [OpenMP] Clang Support for taskwait nowait clause

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG100dfe7a8ad3: [OpenMP] Clang Support for taskwait nowait clause (authored by koops, committed by ABataev). Herald added projects: clang, OpenMP.

[clang] 100dfe7 - [OpenMP] Clang Support for taskwait nowait clause

Author: Sunil K Date: 2022-12-08T12:40:44-08:00 New Revision: 100dfe7a8ad3789a98df623482b88d9a3a02e176 URL: https://github.com/llvm/llvm-project/commit/100dfe7a8ad3789a98df623482b88d9a3a02e176 DIFF: https://github.com/llvm/llvm-project/commit/100dfe7a8ad3789a98df623482b88d9a3a02e176.diff LOG:

[PATCH] D136554: Implement CWG2631

cor3ntin updated this revision to Diff 481411. cor3ntin added a comment. Correctly visit array filer when marking default member init as ODR-used Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136554/new/ https://reviews.llvm.org/D136554 Files:

[PATCH] D136554: Implement CWG2631

cor3ntin reopened this revision. cor3ntin added a comment. This revision is now accepted and ready to land. In D136554#3982161 , @aeubanks wrote: > the following now produces a link error: > > $ cat /tmp/a.cc > #include > #include > > struct

[PATCH] D139400: [clang] Show error when a local variables is passed as default template parameter

shafik added inline comments. Comment at: clang/lib/Sema/SemaTemplate.cpp:1594 + if (VarDecl *VD = dyn_cast(DRE->getDecl())) { +if (VD->isLocalVarDecl()) { + Diag(DRE->getLocation(), So if we look at

[PATCH] D139544: [clang][dataflow] Add support for structured bindings of tuple-like types.

ymandel added a comment. Domján -- thanks for the detailed explanations -- this has been really helpful. > After this the get<>() calls simply use this unnamed copy to initialize the > elements from first to last, so everything seems to proceed in order in the > CFG. Agreed -- it definitely

[PATCH] D139608: [Clang][NFC] Add default `getBFloat16Mangling` impl

jcranmer-intel added a comment. I don't normally handle name mangling, so I can't comment too much here, but I will note that Itanium ABI is planning on using DF16b for `std::bfloat16_t`: https://github.com/itanium-cxx-abi/cxx-abi/pull/147 Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D138571: Update ninja and cmake installation commands on LibASTMatchersTutorial

bogner accepted this revision. bogner added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138571/new/ https://reviews.llvm.org/D138571

[PATCH] D139627: clang/X86: Don't emit "min-legal-vector-width"="0"

arsenm added a comment. In D139627#3982381 , @craig.topper wrote: > In D139627#3982349 , @jdoerfert > wrote: > >> Isn't this (inherently) X86 specific? > > Yes it is. We could qualify the attribute emission

[PATCH] D139627: clang/X86: Don't emit "min-legal-vector-width"="0"

arsenm added a comment. In D139627#3982385 , @arsenm wrote: >> [1] `"min-legal-vector-width" = "0"` was clear to indicate there are only >> scalar operations. > > It's not remotely clear what this means It also doesn't mean that, because the IR doesn't

[PATCH] D139627: clang/X86: Don't emit "min-legal-vector-width"="0"

arsenm added a comment. In D139627#3981475 , @pengfei wrote: > The use of `min-legal-vector-width` doesn't look great to me either. I'm more > than glad if we can remove it totally without any user perceivable affects. > I cannot agree with this change

[PATCH] D139627: clang/X86: Don't emit "min-legal-vector-width"="0"

craig.topper added a comment. In D139627#3982349 , @jdoerfert wrote: > Isn't this (inherently) X86 specific? Yes it is. We could qualify the attribute emission with the targeting being X86? CHANGES SINCE LAST ACTION

[PATCH] D139627: clang/X86: Don't emit "min-legal-vector-width"="0"

jdoerfert added a comment. Isn't this (inherently) X86 specific? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139627/new/ https://reviews.llvm.org/D139627 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] 4a1ccfe - When merging lambdas, keep track of the capture lists from each version.

Author: Richard Smith Date: 2022-12-08T11:37:00-08:00 New Revision: 4a1ccfe8a3cfd4569bc962a38b6117a9a2b8ad21 URL: https://github.com/llvm/llvm-project/commit/4a1ccfe8a3cfd4569bc962a38b6117a9a2b8ad21 DIFF: https://github.com/llvm/llvm-project/commit/4a1ccfe8a3cfd4569bc962a38b6117a9a2b8ad21.diff

[PATCH] D139653: [clang] Set ShowInSystemHeader for module-build and module-import remarks

kastiglione added a comment. > Also, do you think this should be configurable on the command line? Do you have a flag in mind? I have worked around the current behavior with `-Wno-system-header`, but there are two problems with that: first, it's not obvious that it's needed (I had to debug

[clang] 05dbdb0 - Revert "[InstCombine] canonicalize trunc + insert as bitcast + shuffle, part 1 (2nd try)"

Author: Sanjay Patel Date: 2022-12-08T14:16:46-05:00 New Revision: 05dbdb0088a3f5541d9e91c61a564d0aa4704f4f URL: https://github.com/llvm/llvm-project/commit/05dbdb0088a3f5541d9e91c61a564d0aa4704f4f DIFF: https://github.com/llvm/llvm-project/commit/05dbdb0088a3f5541d9e91c61a564d0aa4704f4f.diff

[PATCH] D139302: [RISCV] Add Syntacore SCR1 CPU model

anton-afanasyev added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVSchedSCR1.td:14 +// This model covers SCR1_CFG_RV32IMC_MAX configuration (scr1-max). +// SCR1_CFG_RV32EC_MIN (scr1-min) and SCR1_CFG_RV32IC_BASE (scr1-base) +// configurations have essentially same

[PATCH] D137337: Replace LLVM_LIBDIR_SUFFIX by CMAKE_INSTALL_LIBDIR

compnerd added inline comments. Comment at: bolt/lib/RuntimeLibs/RuntimeLibrary.cpp:32 SmallString<128> LibPath = llvm::sys::path::parent_path(Dir); - llvm::sys::path::append(LibPath, "lib" LLVM_LIBDIR_SUFFIX); + llvm::sys::path::append(LibPath, CMAKE_INSTALL_LIBDIR); if

[PATCH] D139653: [clang] Set ShowInSystemHeader for module-build and module-import remarks

jansvoboda11 added a comment. Nice. It would be nice to have tests for this, though. Also, do you think this should be configurable on the command line? I'm thinking about users that are trying to debug their own modular code, but don't really care what happens in the SDK. Repository: rG

[PATCH] D139444: [ZOS] Convert tests to check 'target={{.*}}-zos'

probinson added a comment. In D139444#3978189 , @uweigand wrote: > In D139444#3975182 , @probinson > wrote: > >> The changes in this patch assume that there aren't any possible suffixes >> after the `-zos` part

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

efriedma added inline comments. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:572 PrioritizedCXXGlobalInits.push_back(std::make_pair(Key, Fn)); + } else if (D->hasConstantInitialization() && !(D->hasAttr())) { +OrderGlobalInitsOrStermFinalizers Key(201,

[PATCH] D139115: [clang][ExtractAPI] Add support for single symbol SGF

benlangmuir added subscribers: akyrtzi, benlangmuir. benlangmuir added inline comments. Comment at: clang/include/clang-c/Documentation.h:549 +typedef struct CXAPISetImpl *CXAPISet; + @dang please document what this type represents. @akyrtzi what's the

[clang] 49c86ea - Revert "Implement CWG2631"

Author: Corentin Jabot Date: 2022-12-08T19:57:58+01:00 New Revision: 49c86eab627b0c4089c8d25dac48728c656448a9 URL: https://github.com/llvm/llvm-project/commit/49c86eab627b0c4089c8d25dac48728c656448a9 DIFF:

[PATCH] D139429: [clang] Add test for CWG418

This revision was automatically updated to reflect the committed changes. Closed by commit rG90d4cbb87ce2: [clang] Add test for CWG418 (authored by Endill). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139429/new/ https://reviews.llvm.org/D139429

[clang] 90d4cbb - [clang] Add test for CWG418

Author: Vlad Serebrennikov Date: 2022-12-08T21:57:07+03:00 New Revision: 90d4cbb87ce297d93159d39528767f5f46aa4da4 URL: https://github.com/llvm/llvm-project/commit/90d4cbb87ce297d93159d39528767f5f46aa4da4 DIFF:

[PATCH] D139166: [OPENMP51] Codegen support for error directive.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139166/new/ https://reviews.llvm.org/D139166

[PATCH] D135269: [AMDGPU] Disable bool range metadata to workaround backend issue

yaxunl added a comment. In D135269#3982103 , @jrbyrnes wrote: > In D135269#3981856 , @yaxunl wrote: > >> In D135269#3981561 , @nikic wrote: >> >>> Checking back here

[PATCH] D136554: Implement CWG2631

aeubanks added a comment. the following now produces a link error: $ cat /tmp/a.cc #include #include struct S { std::map a; }; using T = std::array; class C { T t{}; }; int main() { C c; } $ ./build/rel/bin/clang++ -o /dev/null

[PATCH] D139166: [OPENMP51] Codegen support for error directive.

jyu2 added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.h:334 llvm::Value *emitUpdateLocation(CodeGenFunction , SourceLocation Loc, - unsigned Flags = 0); + unsigned Flags = 0, bool EmitLoc =

[PATCH] D139653: [clang] Set ShowInSystemHeader for module-build and module-import remarks

kastiglione created this revision. kastiglione added a reviewer: jansvoboda11. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Without this change, the use of `-Rmodule-build` and `-Rmodule-import`

[PATCH] D139652: Add the thread sanitizer support for X86_64 WatchOS simulators

jyknight accepted this revision. jyknight added a comment. This revision is now accepted and ready to land. Thanks for the change. The description is a bit misleading, this would be better: Allow TSan in clang driver for X86_64 WatchOS simulator. It was already functional, and Apple's

[PATCH] D135269: [AMDGPU] Disable bool range metadata to workaround backend issue

jrbyrnes added a comment. In D135269#3981856 , @yaxunl wrote: > In D135269#3981561 , @nikic wrote: > >> Checking back here again on whether there is any progress on finding the >> root cause of the issue. If no

[PATCH] D138263: [clang-format] Supress aligning of trailing namespace comments

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/WhitespaceManager.cpp:991 +bool DontAlignThisComment = +i > 0 && Changes[i - 1].Tok->is(TT_NamespaceRBrace); bool WasAlignedWithStartOfNextLine = false; owenpan wrote: >

[PATCH] D139652: Add the thread sanitizer support for X86_64 WatchOS simulators

yfyang created this revision. yfyang added a reviewer: jyknight. Herald added a subscriber: pengfei. Herald added a project: All. yfyang requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Thread sanitizer for x86_64 architecutre is

[PATCH] D139629: clang: Stop emitting "strictfp"

arsenm added a comment. In D139629#3982052 , @arsenm wrote: > In D139629#3981991 , @zahiraam > wrote: > >> Can you please be more verbose in your summary? This change is related to >> the use of

[PATCH] D139629: clang: Stop emitting "strictfp"

arsenm added a comment. In D139629#3981991 , @zahiraam wrote: > Can you please be more verbose in your summary? This change is related to the > use of -ffp-exception-behavior=strict right? > This attribute is set here >

[PATCH] D139052: [NFC][Profile] Access profile through VirtualFileSystem

steven_wu added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1729 + if (!Opts.ProfileInstrumentUsePath.empty()) { +auto FS = llvm::vfs::getRealFileSystem(); +setPGOUseInstrumentor(Opts, Opts.ProfileInstrumentUsePath, *FS, Diags);

[clang] d694e24 - Update the status of a few more C DRs

Author: Aaron Ballman Date: 2022-12-08T13:19:29-05:00 New Revision: d694e2490af8b2e92c79b2c1b543bcc4bb3981d1 URL: https://github.com/llvm/llvm-project/commit/d694e2490af8b2e92c79b2c1b543bcc4bb3981d1 DIFF: https://github.com/llvm/llvm-project/commit/d694e2490af8b2e92c79b2c1b543bcc4bb3981d1.diff

[PATCH] D139166: [OPENMP51] Codegen support for error directive.

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.h:334 llvm::Value *emitUpdateLocation(CodeGenFunction , SourceLocation Loc, - unsigned Flags = 0); + unsigned Flags = 0, bool EmitLoc

[PATCH] D139629: clang: Stop emitting "strictfp"

zahiraam added a comment. Can you please be more verbose in your summary? This change is related to the use of -ffp-exception-behavior=strict right? This attribute is set here https://github.com/llvm/llvm-project/blob/main/clang/lib/CodeGen/CodeGenFunction.cpp#L987 but under a condition. Is

[PATCH] D133289: [C2X] N3007 Type inference for object definitions

to268 updated this revision to Diff 481339. to268 added a comment. Removed compound literal diagnostic in ParseExpr Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133289/new/ https://reviews.llvm.org/D133289 Files:

[PATCH] D138597: DebugInfo: Add/support new DW_LANG codes for recent C and C++ versions

dblaikie reopened this revision. dblaikie added a comment. This revision is now accepted and ready to land. (just a side note I discovered while looking into this: seems someone else had this idea before & came to similar conclusions: https://reviews.llvm.org/D104118#2840490 ) Repository:

[PATCH] D135269: [AMDGPU] Disable bool range metadata to workaround backend issue

yaxunl added a subscriber: jrbyrnes. yaxunl added a comment. In D135269#3981561 , @nikic wrote: > Checking back here again on whether there is any progress on finding the root > cause of the issue. If no progress is expected in the near future, I'd ask

[PATCH] D139166: [OPENMP51] Codegen support for error directive.

jyu2 updated this revision to Diff 481319. jyu2 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139166/new/ https://reviews.llvm.org/D139166 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D139302: [RISCV] Add Syntacore SCR1 CPU model

craig.topper added a comment. Should the names be prefixed with "syntacore-". I assume there could be an SCR2, etc. in the future? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139302/new/ https://reviews.llvm.org/D139302

[PATCH] D139302: [RISCV] Add Syntacore SCR1 CPU model

jrtc27 added inline comments. Comment at: llvm/include/llvm/Support/RISCVTargetParser.def:22 PROC(SIFIVE_U74, {"sifive-u74"}, FK_64BIT, {"rv64gc"}) +PROC(SCR1_BASE, {"scr1-base"}, FK_NONE, {"rv32ic"}) +PROC(SCR1_MAX, {"scr1-max"}, FK_NONE, {"rv32imc"})

  1   2   >