[PATCH] D140462: [clangd] Add schema for `.clangd` config

hyperupcall marked 2 inline comments as done. hyperupcall added a comment. In D140462#4018983 , @sammccall wrote: > The difficulty in testing is that: > > - JSON-schema is totally unknown in llvm-project, so there are no tools but > also no expectation

[PATCH] D141226: [clangd] support expanding `decltype(expr)`

v1nh1shungry updated this revision to Diff 487704. v1nh1shungry added a comment. avoid expanding pointer to an array Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141226/new/ https://reviews.llvm.org/D141226 Files:

[PATCH] D139010: [clang][WebAssembly] Implement support for table types and builtins

pmatos updated this revision to Diff 487702. pmatos added a comment. Rebase on top of main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139010/new/ https://reviews.llvm.org/D139010 Files: clang/include/clang/AST/ASTContext.h

[PATCH] D128440: [WebAssembly] Initial support for reference type funcref in clang

pmatos updated this revision to Diff 487700. pmatos added a comment. Rebase on top of main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128440/new/ https://reviews.llvm.org/D128440 Files: clang/include/clang/AST/Type.h

[PATCH] D140307: [clang-tidy] Match derived types in in modernize-loop-convert

carlosgalvezp added a comment. Hi! I'm finding merge conflicts when rebasing the patch on latest trunk, would you mind uploading a rebased version? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140307/new/ https://reviews.llvm.org/D140307

[PATCH] D139168: [C++20] [Modules] [ClangScanDeps] Enable to print make-style dependency file within P1689 format (4/4)

ChuanqiXu added a comment. In D139168#4036850 , @tahonermann wrote: >> Header units have even more need to be involved in the build graph than >> named units. ODR violations and cache invalidation problems await anyone >> just winging it on header

[PATCH] D137534: [C++20] [Modules] [ClangScanDeps] Allow clang-scan-deps to without specified compilation database in P1689 (3/4)

ChuanqiXu marked 3 inline comments as done. ChuanqiXu added a comment. > I originally investigated (and ended up lost) for something like GCC where > P1689 information is extracted via -E > -fdep-file=p1689.json -fdep-output=module.o -fdep-format=p1689 (which is

[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

pmatos updated this revision to Diff 487693. pmatos added a comment. Rebasing on top of main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122215/new/ https://reviews.llvm.org/D122215 Files: clang/include/clang/AST/ASTContext.h

[PATCH] D137534: [C++20] [Modules] [ClangScanDeps] Allow clang-scan-deps to without specified compilation database in P1689 (3/4)

ChuanqiXu updated this revision to Diff 487692. ChuanqiXu added a comment. Address comments: - Add more comments in the test. - Avoid ad-hoc parsing `-o` option manually. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137534/new/ https://reviews.llvm.org/D137534 Files:

[PATCH] D141288: [clang-format] Inherit RightAlign options across scopes

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. Nice! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141288/new/ https://reviews.llvm.org/D141288 ___ cfe-commits mailing list

[PATCH] D141226: [WIP][clangd] support expanding `decltype(expr)`

v1nh1shungry updated this revision to Diff 487688. v1nh1shungry added a comment. - avoid expanding dependent types - avoid expanding reference to a function - avoid expanding array type and reference to an array Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D141198: [Clang][RISCV][NFC] Reorganize test case for rvv intrinsics

eopXD updated this revision to Diff 487683. eopXD added a comment. Address comment from Craig. Also separate test case according to their mnemonics. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141198/new/ https://reviews.llvm.org/D141198

[PATCH] D139185: [clang][Interp] Use placement new to construct opcode args into vector

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139185/new/ https://reviews.llvm.org/D139185 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D137381: [clang][compiler-rt] Exception escape out of an non-unwinding function is an undefined behaviour

MaskRay added a comment. I am unfamiliar with Clang codegen so I am just commenting about what a user may feel about this feature. `compiler-rt/test/ubsan/TestCases/Misc/exception-escape.cpp` cannot demonstrate the value of the new UBSan check `-fsanitize=exception-escape`, as the executable

[PATCH] D141283: [clang] Improve diagnostic for "initializer-string for char array is too long"

tbaeder added a comment. When grepping `clang/test/` for "for char array is too long", I get a bunch of other hits for this diagnostic, are the those tests not failing for you (e.g. `clang/test/Sema/array-init.c:149`)? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D141350: Fix runtime problem for base class member data used in target region.

jyu2 added a comment. In D141350#4038619 , @ye-luo wrote: > Does this patch work when there are more than one level of inheritance? For > example `class B: public A; class C: public B` Yes, that works. For that we emit this[:1] instead. I can add

[PATCH] D141350: Fix runtime problem for base class member data used in target region.

ye-luo added a comment. Does this patch work when there are more than one level of inheritance? For example `class B: public A; class C: public B` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141350/new/ https://reviews.llvm.org/D141350

[PATCH] D141350: Fix runtime problem for base class member data used in target region.

jyu2 created this revision. jyu2 added reviewers: ABataev, jdoerfert, mikerice. jyu2 added a project: OpenMP. Herald added a project: All. jyu2 requested review of this revision. Herald added subscribers: openmp-commits, cfe-commits, sstefan1. Herald added a project: clang. The problem is

[PATCH] D141288: [clang-format] Inherit RightAlign options across scopes

owenpan accepted this revision. owenpan added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141288/new/ https://reviews.llvm.org/D141288

[clang] eded23d - [Clang] Silence a "unused variable" warning when building with MSVC

Author: Alexandre Ganea Date: 2023-01-09T23:45:20-05:00 New Revision: eded23dfdaf050793b70351d5f42400016d57c15 URL: https://github.com/llvm/llvm-project/commit/eded23dfdaf050793b70351d5f42400016d57c15 DIFF:

[PATCH] D140794: [ASTMatcher] Add coroutineBodyStmt matcher

ccotter updated this revision to Diff 487661. ccotter marked an inline comment as not done. ccotter added a comment. - Add hasBody matcher support for coroutineBodyStmt - update doc - Sort list - clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D140794: [ASTMatcher] Add coroutineBodyStmt matcher

ccotter added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:5503 + FunctionDecl, + CoroutineBodyStmt),

[PATCH] D141349: Remove the ThreadLocal template from LLVM.

resistor added a comment. Incorporated build fixes for GCC. Waiting for buildbots to complete. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141349/new/ https://reviews.llvm.org/D141349 ___ cfe-commits

[PATCH] D141349: Remove the ThreadLocal template from LLVM.

resistor created this revision. Herald added subscribers: Moerafaat, zero9178, bzcheeseman, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, mgester, arpith-jacob, antiagainst, shauheen, rriddle, mehdi_amini,

[clang-tools-extra] ef9aa34 - Revert "Remove the ThreadLocal template from LLVM."

Author: Owen Anderson Date: 2023-01-09T21:21:38-07:00 New Revision: ef9aa34f0274cdbfa82c47f8ab99f02679fd0d13 URL: https://github.com/llvm/llvm-project/commit/ef9aa34f0274cdbfa82c47f8ab99f02679fd0d13 DIFF: https://github.com/llvm/llvm-project/commit/ef9aa34f0274cdbfa82c47f8ab99f02679fd0d13.diff

[PATCH] D141347: Remove the ThreadLocal template from LLVM.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG54d78b639b9c: Remove the ThreadLocal template from LLVM. (authored by resistor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 54d78b6 - Remove the ThreadLocal template from LLVM.

Author: Owen Anderson Date: 2023-01-09T21:12:27-07:00 New Revision: 54d78b639b9c18b42abd4fac5c6e76105f06b3ef URL: https://github.com/llvm/llvm-project/commit/54d78b639b9c18b42abd4fac5c6e76105f06b3ef DIFF: https://github.com/llvm/llvm-project/commit/54d78b639b9c18b42abd4fac5c6e76105f06b3ef.diff

[PATCH] D141347: Remove the ThreadLocal template from LLVM.

resistor updated this revision to Diff 487655. resistor added a comment. Fix nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141347/new/ https://reviews.llvm.org/D141347 Files: clang-tools-extra/clangd/support/ThreadCrashReporter.cpp

[PATCH] D141347: Remove the ThreadLocal template from LLVM.

majnemer accepted this revision. majnemer added a comment. This revision is now accepted and ready to land. LGTM Comment at: llvm/lib/Support/CrashRecoveryContext.cpp:23 struct CrashRecoveryContextImpl; - -sys::ThreadLocal () { - static sys::ThreadLocal CurrentContext; -

[PATCH] D141347: Remove the ThreadLocal template from LLVM.

resistor created this revision. Herald added subscribers: Moerafaat, zero9178, bzcheeseman, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, mgester, arpith-jacob, antiagainst, shauheen, rriddle, mehdi_amini,

[PATCH] D140867: [C++20] [Modules] Don't generate global ctors/dtors for variables which are available externally

ChuanqiXu added a comment. In D140867#4036239 , @Jake-Egan wrote: > Hi, this test is failing on AIX, could you take a look please? > https://lab.llvm.org/buildbot/#/builders/214/builds/5242/steps/6/logs/FAIL__Clang__pr59765-modules-global-ctor-dtor_cppm

[clang] 9cb1298 - [NFC] Fix a test faliing in AIX

Author: Chuanqi Xu Date: 2023-01-10T10:41:21+08:00 New Revision: 9cb1298dcc85c357eb97ed0bdc3c82c5d011f6f6 URL: https://github.com/llvm/llvm-project/commit/9cb1298dcc85c357eb97ed0bdc3c82c5d011f6f6 DIFF: https://github.com/llvm/llvm-project/commit/9cb1298dcc85c357eb97ed0bdc3c82c5d011f6f6.diff

[PATCH] D141342: [perf-training] Check extension in findFilesWithExtension

Amir created this revision. Amir added reviewers: phosek, beanz. Herald added a subscriber: pengfei. Herald added a project: All. Amir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. `findFilesWithExtension` helper checks for

[PATCH] D135488: [codegen] Add a remarks based Stack Layout Analysis pass

thegameg added a comment. I don't think I understand why we can't achieve B with remarks? In C and D you generate one remark for each line, can't we generate a single multi-line remark instead? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D136817: [RISCV] Add H extension

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf4c887c3a840: [RISCV] Add H extension (authored by kito-cheng). Changed prior to commit: https://reviews.llvm.org/D136817?vs=485360=487624#toc

[clang] f4c887c - [RISCV] Add H extension

Author: Kito Cheng Date: 2023-01-10T09:52:03+08:00 New Revision: f4c887c3a8406d85f4f942c8350f10026994f4d8 URL: https://github.com/llvm/llvm-project/commit/f4c887c3a8406d85f4f942c8350f10026994f4d8 DIFF: https://github.com/llvm/llvm-project/commit/f4c887c3a8406d85f4f942c8350f10026994f4d8.diff

[PATCH] D135488: [codegen] Add a remarks based Stack Layout Analysis pass

paulkirth added a comment. I think ideally I'd like to surface something like this: A: F26139353: image.png or B: F26139363: image.png The first image uses stdout, and the second uses remarks, but prints everything

[PATCH] D141338: [-Wunsafe-buffer-usage] Filter out conflicting fix-its

ziqingluo-90 created this revision. ziqingluo-90 added reviewers: NoQ, jkorous, t-rasmud, malavikasamak. Herald added a subscriber: mgrang. Herald added a project: All. ziqingluo-90 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Two

[clang] 900e807 - [OpenMP][FIX] Remove version specific check lines

Author: Johannes Doerfert Date: 2023-01-09T17:04:56-08:00 New Revision: 900e80737efd834fa034d5905f14b94c8032ed5a URL: https://github.com/llvm/llvm-project/commit/900e80737efd834fa034d5905f14b94c8032ed5a DIFF:

[PATCH] D137058: [Driver] [Modules] Support -fmodule-output (1/2)

dblaikie added a comment. In D137058#4030331 , @ChuanqiXu wrote: > @dblaikie would you like to take a look at this? Yep, this is still on my radar - sorry for the delays. I'll get to it. CHANGES SINCE LAST ACTION

[PATCH] D140860: [Diagnostics][NFC] Fix -Wlogical-op-parentheses warning inconsistency for const and constexpr values

dblaikie added a comment. In D140860#4033530 , @hazohelet wrote: > I have yet to do thorough checks using this patched clang to build > significant code bases. > It will likely take quite a bit of time as I am not used to editing build > tool files.

[PATCH] D139052: [NFC][Profile] Access profile through VirtualFileSystem

steven_wu updated this revision to Diff 487597. steven_wu added a comment. Address review feedback. Remove NFC from title. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139052/new/ https://reviews.llvm.org/D139052 Files:

[PATCH] D141218: [clangd] Include the correct header for typeid()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG056d4dca7764: [clangd] Include the correct header for typeid() (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang-tools-extra] 056d4dc - [clangd] Include the correct header for typeid()

Author: Nathan Ridge Date: 2023-01-09T18:07:07-05:00 New Revision: 056d4dca7764d92870f717906e7edb4a9563d3cb URL: https://github.com/llvm/llvm-project/commit/056d4dca7764d92870f717906e7edb4a9563d3cb DIFF: https://github.com/llvm/llvm-project/commit/056d4dca7764d92870f717906e7edb4a9563d3cb.diff

[PATCH] D141218: [clangd] Include the correct header for typeid()

nridge updated this revision to Diff 487571. nridge added a comment. Remove test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141218/new/ https://reviews.llvm.org/D141218 Files: clang-tools-extra/clangd/IncludeFixer.cpp Index:

[PATCH] D139737: [-Wunsafe-buffer-usage] Initiate Fix-it generation for local variable declarations

jkorous added inline comments. Comment at: clang/include/clang/Analysis/Analyses/UnsafeBufferUsage.h:46 +/// The text indicating that the user needs to provide input there: +constexpr static const char *const UserFillPlaceHolder = "..."; } // end namespace clang

[PATCH] D141206: [clang] [MinGW] Avoid adding /include and /lib when cross compiling

mstorsjo added a comment. In D141206#4037160 , @alvinhochun wrote: > The idea sounds reasonable. I don't know mingw-w64 toolchains well enough, > but I'll try: > > How does it interact with the following conditions (lines 469-475)? They look > like

[PATCH] D138958: [clang] Better UX for Clang’s unwind-affecting attributes

lebedev.ri updated this revision to Diff 487548. lebedev.ri marked 2 inline comments as done. lebedev.ri added a comment. In D138958#4037526 , @erichkeane wrote: > 2 quick nits, otherwise LFTM. @erichkeane thank you for the review! @aaron.ballman

[PATCH] D140703: [clang][dataflow] Unify `TransferOptions` and `DataflowAnalysisContext::Options`.

xazax.hun accepted this revision. xazax.hun added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysis.h:89 + ? DataflowAnalysisContext::Options{} + : llvm::Optional()}) {} If we already

[PATCH] D141324: [clang] extend external_source_symbol attribute with the USR clause

arphaman created this revision. arphaman added reviewers: bnbarham, ravikandhadai. Herald added a subscriber: ributzka. Herald added a reviewer: aaron.ballman. Herald added a project: All. arphaman requested review of this revision. Allow the user to specify a concrete USR in the

[PATCH] D141319: [clang][dataflow][NFC] Refine names and comments for field filtering.

ymandel created this revision. ymandel added reviewers: xazax.hun, gribozavr2, sgatev. Herald added subscribers: martong, rnkovacs. Herald added a reviewer: NoQ. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang. Tweaks elements of the new API

[PATCH] D124351: [Clang] Implement Change scope of lambda trailing-return-type

cor3ntin updated this revision to Diff 487539. cor3ntin marked 24 inline comments as done. cor3ntin added a comment. - Address Aaron's comments (except renaming ActOnLambdaIntroducer as we pounder on it) - Delete an aditional outdated comment Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D140703: [clang][dataflow] Unify `TransferOptions` and `DataflowAnalysisContext::Options`.

ymandel updated this revision to Diff 487538. ymandel added a comment. Initialize AnalysisOptions as a struct, avoiding a use-after-move bug from incorrect use of the fluent (rvalue-ref) API. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D140584: [Clang] Refactor "Designators" into a unified implementation [NFC]

void added inline comments. Comment at: clang/include/clang/AST/Designator.h:88 + /// An array designator, e.g., "[42] = 0" and "[42 ... 50] = 1". + template struct ArrayDesignatorInfo { +/// Location of the first and last index expression within the designated

[PATCH] D141172: [ModuleUtils][KCFI] Set patchable-function-prefix for synthesized functions

samitolvanen updated this revision to Diff 487536. samitolvanen marked an inline comment as done. samitolvanen added a comment. Addressed feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141172/new/ https://reviews.llvm.org/D141172 Files:

[PATCH] D141172: [ModuleUtils][KCFI] Set patchable-function-prefix for synthesized functions

samitolvanen added inline comments. Comment at: llvm/test/Instrumentation/AddressSanitizer/kcfi-offset.ll:1 +;; Test that we set patchable-function-prefix for asan.module_ctor when kcfi-offset is defined. + MaskRay wrote: >

[PATCH] D138958: [clang] Better UX for Clang’s unwind-affecting attributes

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. 2 quick nits, otherwise LFTM. Comment at: clang/include/clang/Basic/AttrDocs.td:558 + let Content = [{ +A stronger version of ``__attribute__((pure))`` attribute.

[PATCH] D137381: [clang][compiler-rt] Exception escape out of an non-unwinding function is an undefined behaviour

lebedev.ri added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137381/new/ https://reviews.llvm.org/D137381 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D138958: [clang] Better UX for Clang’s unwind-affecting attributes

lebedev.ri added a comment. Herald added a subscriber: StephenFan. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138958/new/ https://reviews.llvm.org/D138958 ___ cfe-commits mailing list

[PATCH] D139737: [-Wunsafe-buffer-usage] Initiate Fix-it generation for local variable declarations

ziqingluo-90 updated this revision to Diff 487527. ziqingluo-90 added a comment. Rebase the patch with respect to the re-architecture: https://reviews.llvm.org/D140062. Since we do not have any `FixableGadget` to trigger fix-its at this point, I let fix-its of local variable declarations

[PATCH] D140455: [Clang] Diagnose undefined behavior in a constant expression while evaluating a compound assignment with remainder as operand

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from some style nits. Can you also add a release note for the fix? Comment at: clang/lib/AST/ExprConstant.cpp:2759-2760

[PATCH] D137244: [Clang] Correctly capture bindings in dependent lambdas.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGee2056e7: [Clang] Correctly capture bindings in dependent lambdas. (authored by cor3ntin). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] e1111e2 - [Clang] Correctly capture bindings in dependent lambdas.

Author: Corentin Jabot Date: 2023-01-09T21:20:57+01:00 New Revision: ee2056e7245b21e24816f6f7ef5ac016ed6f URL: https://github.com/llvm/llvm-project/commit/ee2056e7245b21e24816f6f7ef5ac016ed6f DIFF:

[PATCH] D140794: [ASTMatcher] Add coroutineBodyStmt matcher

aaron.ballman added a comment. Thank you for this! FWIW, it looks like precommit CI found some issues that need to be resolved. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:5503 + FunctionDecl, +

[PATCH] D141226: [WIP][clangd] support expanding `decltype(expr)`

v1nh1shungry updated this revision to Diff 487519. v1nh1shungry added a comment. Herald added projects: clang, LLVM. Herald added a subscriber: llvm-commits. rename the tweak `ExpandAutoType` to `ExpandDeducedType` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam added a comment. ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137107/new/ https://reviews.llvm.org/D137107 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D141158: [OpenMP] Introduce '-f[no-]openmp-target-jit' flag to control JIT for offloading

gribozavr2 added a comment. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141158/new/ https://reviews.llvm.org/D141158 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D140584: [Clang] Refactor "Designators" into a unified implementation [NFC]

void added inline comments. Comment at: clang/include/clang/AST/Designator.h:88 + /// An array designator, e.g., "[42] = 0" and "[42 ... 50] = 1". + template struct ArrayDesignatorInfo { +/// Location of the first and last index expression within the designated

[PATCH] D140703: [clang][dataflow] Unify `TransferOptions` and `DataflowAnalysisContext::Options`.

ymandel updated this revision to Diff 487516. ymandel added a comment. rebasing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140703/new/ https://reviews.llvm.org/D140703 Files: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysis.h

[PATCH] D140694: [clang][dataflow] Only model struct fields that are used in the function being analyzed.

ymandel closed this revision. ymandel added a comment. Committed: https://reviews.llvm.org/rG01ccf7b3cee58dbe02fd97696cae1781746b6137 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140694/new/ https://reviews.llvm.org/D140694

[clang] 01ccf7b - Revert "Revert "[clang][dataflow] Only model struct fields that are used in the function being analyzed.""

Author: Yitzhak Mandelbaum Date: 2023-01-09T19:32:10Z New Revision: 01ccf7b3cee58dbe02fd97696cae1781746b6137 URL: https://github.com/llvm/llvm-project/commit/01ccf7b3cee58dbe02fd97696cae1781746b6137 DIFF: https://github.com/llvm/llvm-project/commit/01ccf7b3cee58dbe02fd97696cae1781746b6137.diff

[PATCH] D141310: [clang] add -Wcompare-function-pointers

adriandole updated this revision to Diff 487511. adriandole added a comment. Release note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141310/new/ https://reviews.llvm.org/D141310 Files: clang/docs/ReleaseNotes.rst

[PATCH] D140694: [clang][dataflow] Only model struct fields that are used in the function being analyzed.

ymandel updated this revision to Diff 487506. ymandel added a comment. fix memory error that cause buildbot failures Fixes a self-move assign. This operation should be safe, but is known to cause problems in some implementations of the standard library. The patch drops the assignment, which was

[PATCH] D141310: [clang] add -Wcompare-function-pointers

adriandole created this revision. Herald added a project: All. adriandole requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Using `icf=all` with lld can cause comparisons between function pointers that previously compared as unequal to

[PATCH] D141051: [CUDA][HIP] Add support for `--offload-arch=native` to CUDA and refactor

jhuber6 updated this revision to Diff 487503. jhuber6 added a comment. Fix typo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141051/new/ https://reviews.llvm.org/D141051 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td

[PATCH] D124351: [Clang] Implement Change scope of lambda trailing-return-type

aaron.ballman added inline comments. Comment at: clang/include/clang/AST/DeclCXX.h:1834-1846 + void setLambdaTypeInfo(TypeSourceInfo *TS) { +auto *DD = DefinitionData; +assert(DD && DD->IsLambda && "setting lambda property of non-lambda class"); +auto =

[PATCH] D133289: [C2X] N3007 Type inference for object definitions

tschuett added a comment. It surprised me that there are no type inference messages? The type of this auto is double. I only found warnings of misuse of auto and codegen tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133289/new/

[PATCH] D141051: [CUDA][HIP] Add support for `--offload-arch=native` to CUDA and refactor

jhuber6 added inline comments. Comment at: clang/test/Driver/amdgpu-hip-system-arch.c:24 + +// case when amdgpu_arch does not return anything with successful execution +// RUN: %clang -### --target=x86_64-unknown-linux-gnu -nogpulib --offload-arch=native

[PATCH] D141206: [clang] [MinGW] Avoid adding /include and /lib when cross compiling

alvinhochun added a comment. The idea sounds reasonable. I don't know mingw-w64 toolchains well enough, but I'll try: How does it interact with the following conditions (lines 469-475)? They look like they may be looking for a mingw-w64 sysroot, which may be ignored by the new check. else

[PATCH] D141051: [CUDA][HIP] Add support for `--offload-arch=native` to CUDA and refactor

yaxunl added inline comments. Comment at: clang/test/Driver/amdgpu-hip-system-arch.c:24 + +// case when amdgpu_arch does not return anything with successful execution +// RUN: %clang -### --target=x86_64-unknown-linux-gnu -nogpulib --offload-arch=native

[PATCH] D137534: [C++20] [Modules] [ClangScanDeps] Allow clang-scan-deps to without specified compilation database in P1689 (3/4)

ben.boeckel added a comment. In D137534#4037064 , @jansvoboda11 wrote: > Another thing to be aware of is that the scanner is tuned for scanning > multiple TUs. Single `clang-scan-deps` invocation maintains a shared > in-memory cache of the filesystem

[PATCH] D139534: [analyzer] Don't escape local static memregions on bind

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. In D139534#4036783 , @steakhal wrote: > In D139534#4034719 , @xazax.hun > wrote: > >>> Here is the

[PATCH] D141307: [WIP] Add -f[no-]loop-versioning option

Leporacanthicus created this revision. Herald added a reviewer: awarzynski. Herald added projects: Flang, All. Leporacanthicus requested review of this revision. Herald added subscribers: cfe-commits, jdoerfert, MaskRay. Herald added a project: clang. Posted to satisfy depenences of another

[PATCH] D139168: [C++20] [Modules] [ClangScanDeps] Enable to print make-style dependency file within P1689 format (4/4)

jansvoboda11 added inline comments. Comment at: clang/tools/clang-scan-deps/ClangScanDeps.cpp:775 +static llvm::StringMap OSs; +std::unique_lock LockGuard(Lock); + How will this work when a different process tries to write the same file?

[PATCH] D140547: Perform access checking to private members in simple requirement.

ilya-biryukov added a comment. I think the only major problem is not checking for error case when accessing `TransReq`, the rest are NITs. Thanks for the change! Will be happy to LGTM it as soon as the access to `TransReq` is fixed. Comment at:

[PATCH] D137534: [C++20] [Modules] [ClangScanDeps] Allow clang-scan-deps to without specified compilation database in P1689 (3/4)

jansvoboda11 added a comment. In D137534#4025898 , @ben.boeckel wrote: > - the format supports doing this for a set of object files (but given the way > it tangles the dep graph, is unlikely to be a perf win for > incremental/developer builds; CI may

[PATCH] D131306: [llvm][misexpect] Track provenance of branch weights

paulkirth added a comment. @tejohnson @xur I kind of dropped the ball on these patches, but what are your thoughts on this approach over the old(more invasive) change to the profdata format I had prototyped before? the patch will obviously need to be rebased, but other than that, do we see a

[PATCH] D137534: [C++20] [Modules] [ClangScanDeps] Allow clang-scan-deps to without specified compilation database in P1689 (3/4)

jansvoboda11 added inline comments. Comment at: clang/test/ClangScanDeps/P1689.cppm:9 +// +// Check the seperated dependency format. +// RUN: clang-scan-deps -format=p1689 --p1689-targeted-file-name=%t/M.cppm --p1689-targeted-output=%t/M.o \ ben.boeckel wrote:

[PATCH] D137244: [Clang] Correctly capture bindings in dependent lambdas.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM assuming precommit CI doesn't discover any problems from the latest changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D140800: [OptTable] Precompute OptTable prefixes union table through tablegen

serge-sans-paille added a comment. @nikic : gentle ping :-) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140800/new/ https://reviews.llvm.org/D140800 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D140699: [OptTable] Make ValuesCode initialisation of Options constexpr

serge-sans-paille added a comment. Herald added a subscriber: StephenFan. @nikic: gentle ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140699/new/ https://reviews.llvm.org/D140699 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D141298: Move from llvm::makeArrayRef to ArrayRef deduction guides - last part

mehdi_amini added a comment. Seems mechanical, and if it build everywhere LGTM :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141298/new/ https://reviews.llvm.org/D141298 ___ cfe-commits mailing list

[PATCH] D141198: [Clang][RISCV][NFC] Reorganize test case for rvv intrinsics

craig.topper added a comment. Please split vmulh* from vmul.c. Remove the vmul tests from the handcrafted vmul.c and vmul-eew64.c. Rename those to vmulh.c and vmulh-eew64.c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141198/new/

[PATCH] D139168: [C++20] [Modules] [ClangScanDeps] Enable to print make-style dependency file within P1689 format (4/4)

tahonermann added a comment. > Header units have even more need to be involved in the build graph than named > units. ODR violations and cache invalidation problems await anyone just > winging it on header units (at least that's the understanding I've gotten > from SG15 meetings). I think

[PATCH] D72103: [Sema] Avoid using an invalid InsertPos

shafik added a comment. Herald added a project: All. It looks like the original bug no longer reproduces: https://github.com/llvm/llvm-project/issues/42566 Is this PR still needed? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72103/new/ https://reviews.llvm.org/D72103

[PATCH] D141298: Move from llvm::makeArrayRef to ArrayRef deduction guides - last part

serge-sans-paille added a comment. Herald added subscribers: Michael137, JDevlieghere. Once that patch lands, I'll mark `makeArrayRef` as deprecated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141298/new/ https://reviews.llvm.org/D141298

[PATCH] D139774: [libclang] Add API to set temporary directory location

vedgy marked an inline comment as not done. vedgy added a comment. In D139774#4036496 , @aaron.ballman wrote: > In terms of the C API, I think it'd make more sense to name in terms of > "override" rather than "set", but I don't feel as strongly about

[PATCH] D140086: [analyzer][solver] Improve reasoning for not equal to operator

steakhal added a comment. Sorry, I don't have the time this week. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140086/new/ https://reviews.llvm.org/D140086 ___ cfe-commits mailing list

[PATCH] D141297: [OpenCL] Allow undefining header-only features

svenvh created this revision. svenvh added reviewers: Anastasia, FMarno. Herald added subscribers: Naghasan, ldrumm, yaxunl. Herald added a project: All. svenvh requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. `opencl-c-base.h` always

[PATCH] D139534: [analyzer] Don't escape local static memregions on bind

steakhal added a comment. In D139534#4034719 , @xazax.hun wrote: >> Here is the gist of one *new* TP: > > Where would `sprops` get escaped? Did I miss that or was that reduced out of > the example? You are right, it 'never' escapes, yet in the past we

  1   2   >