[PATCH] D142085: [Clang][RISCV] Add `__riscv_` prefix for all RVV intrinsics

eopXD added a comment. > Not related to this patch, but this enum should probably be using double > underscores for its names. Thanks for mentioning this, probably should start a PR under rvv-intrinsic-doc before having a patch here. @craig.topper @kito-cheng I don't have a preference here,

[PATCH] D142094: [Clang][Doc] Add release note for changes for the RVV intrinsics

eopXD added a comment. In D142094#4065611 , @asb wrote: > In D142094#4065175 , @eopXD wrote: > >> @asb I just saw the cancellation of the sync-up call today. Regarding the >> branch out on 01/24 I think it would

[PATCH] D141754: [5/15][Clang][RISCV][NFC] Remove extra attribute Policy::IntrinsicWithoutMU by reusing HasTailPolicy and HasMaskPolicy

eopXD added a comment. In D141754#4057829 , @kito-cheng wrote: > Wait, I fell HasTailPolicy and HasMaskPolicy should be part of Policy object, > and then it's the Omit to present it's no policy. I think the simplification here

[PATCH] D141754: [5/15][Clang][RISCV][NFC] Remove extra attribute Policy::IntrinsicWithoutMU by reusing HasTailPolicy and HasMaskPolicy

eopXD updated this revision to Diff 491042. eopXD added a comment. Update code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141754/new/ https://reviews.llvm.org/D141754 Files: clang/include/clang/Support/RISCVVIntrinsicUtils.h

[PATCH] D141754: [5/15][Clang][RISCV][NFC] Remove extra attribute Policy::IntrinsicWithoutMU by reusing HasTailPolicy and HasMaskPolicy

eopXD updated this revision to Diff 491041. eopXD marked 4 inline comments as done. eopXD added a comment. Address comment from Kito. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141754/new/ https://reviews.llvm.org/D141754 Files:

[PATCH] D141886: [Clang][test] Avoid FileCheck error when matching `-cc1`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG275ab246ee81: [Clang][test] Avoid FileCheck error when matching `-cc1` (authored by hezuoqiang hezuoqia...@huawei.com, committed by bryanpkc).

[clang] 275ab24 - [Clang][test] Avoid FileCheck error when matching `-cc1`

Author: hezuoqiang Date: 2023-01-20T23:36:09-05:00 New Revision: 275ab246ee811507a2b1d2e42b2d655a25c8df6c URL: https://github.com/llvm/llvm-project/commit/275ab246ee811507a2b1d2e42b2d655a25c8df6c DIFF: https://github.com/llvm/llvm-project/commit/275ab246ee811507a2b1d2e42b2d655a25c8df6c.diff

[PATCH] D142138: [OpenMP] Clean up AMD handling for `-fopenmp-targets=amdgcn` arch inference

arsenm added a comment. In D142138#4066420 , @JonChesterfield wrote: > @arsenm as above, mcpu != march important? llc takes a different one to clang > iirc I don't know what the difference would be Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D141811: [clang-format] Allow trailing return types in macros

rymiel added a comment. In D141811#4068180 , @HazardyKnusperkeks wrote: > I thought about `auto NAME() -> int { return 42; }`. > > `decltype(auto) a = (b) -> c;` is something else... I'm not sure how that affects this? Using `decltype(auto)` as in

[PATCH] D142268: [clang][DebugInfo] Don't canonicalize names in template argument list for alias templates

Michael137 added a comment. @dblaikie suggested that the best way to go about the recurring "how do we print template names" question is to turn on `-gsimple-template-names` on by default. For alias templates this means we would have to attach template parameters to their DIEs too.

[PATCH] D142268: [clang][DebugInfo] Don't canonicalize names in template argument list for alias templates

Michael137 updated this revision to Diff 491015. Michael137 added a comment. - Update commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142268/new/ https://reviews.llvm.org/D142268 Files: clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D142268: [clang][DebugInfo] Don't canonicalize names in template argument list for alias templates

Michael137 created this revision. Michael137 added reviewers: dblaikie, aprantl. Herald added a subscriber: jeroen.dobbelaere. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. **Summary** This patch

[PATCH] D139395: Add CFI integer types normalization

rcvalle marked an inline comment as done. rcvalle added inline comments. Comment at: clang/docs/ControlFlowIntegrity.rst:241 + +``-fsanitize-cfi--icall-experimental-normalize-integers`` +- samitolvanen

[PATCH] D139395: Add CFI integer types normalization

rcvalle updated this revision to Diff 491013. rcvalle added a comment. Fixed typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139395/new/ https://reviews.llvm.org/D139395 Files: clang/docs/ControlFlowIntegrity.rst clang/docs/UsersManual.rst

[PATCH] D142233: [Clang][OpenMP] Bail out early if `Scope` is nullptr in case of any crash

tianshilei1992 added a comment. In D142233#4070572 , @vitalybuka wrote: > Fails on this bot > https://lab.llvm.org/buildbot/#/builders/5/builds/30884/steps/13/logs/stdio It's been fixed by

[PATCH] D142233: [Clang][OpenMP] Bail out early if `Scope` is nullptr in case of any crash

vitalybuka added a comment. Fails on this bot https://lab.llvm.org/buildbot/#/builders/5/builds/30884/steps/13/logs/stdio https://reviews.llvm.org/D142233 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142233/new/ https://reviews.llvm.org/D142233

[PATCH] D141709: [clang][dataflow] Fix bug in joining bool values.

gribozavr2 added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141709/new/ https://reviews.llvm.org/D141709 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D142265: [AArch64] Function multi-versioning release notes added. NFC.

ilinpv created this revision. ilinpv added reviewers: danielkiss, samtebbs, dmgreen. Herald added a subscriber: kristof.beyls. Herald added a project: All. ilinpv requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits.

[PATCH] D139395: Add CFI integer types normalization

samitolvanen added a comment. In D139395#4067391 , @pcc wrote: > I discussed this out of band with Ramon and we agreed that the new option > should be marked as experimental because the rustc implementation is not yet > finalized. I think that the

[PATCH] D140859: [clang][dataflow] Allow analyzing multiple functions in unit tests

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc8b31da1ef0a: [clang][dataflow] Allow analyzing multiple functions in unit tests (authored by gribozavr). Repository: rG LLVM Github Monorepo

[clang] c8b31da - [clang][dataflow] Allow analyzing multiple functions in unit tests

Author: Dmitri Gribenko Date: 2023-01-21T01:28:03+01:00 New Revision: c8b31da1ef0a3f2a0ba5c39bb4281b1438e511fb URL: https://github.com/llvm/llvm-project/commit/c8b31da1ef0a3f2a0ba5c39bb4281b1438e511fb DIFF:

[PATCH] D140859: [clang][dataflow] Allow analyzing multiple functions in unit tests

gribozavr2 added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/TestingSupport.cpp:59 +if (SM.isPointWithin(Loc, BoundingRange.getBegin(), + BoundingRange.getEnd())) { + LineNumberToContent[SM.getPresumedLineNumber(Loc)] =

[PATCH] D140859: [clang][dataflow] Allow analyzing multiple functions in unit tests

gribozavr updated this revision to Diff 491003. gribozavr added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140859/new/ https://reviews.llvm.org/D140859 Files:

[PATCH] D136315: [clang][Darwin] Try to guess the SDK root with xcrun when unspecified

calebzulawski added a comment. In D136315#4070121 , @steven_wu wrote: > I definitely feel like if to fix your problem, a reverse option like > `-infer-sdkroot-from-xcrun` might be better/safer but it doesn't help the > general case where people doesn't

[PATCH] D136315: [clang][Darwin] Try to guess the SDK root with xcrun when unspecified

calebzulawski updated this revision to Diff 490999. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136315/new/ https://reviews.llvm.org/D136315 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/Darwin.cpp

[PATCH] D141738: Add initial support for cross compile Windows runtimes under Linux when building Fuchsia clang toolchain

haowei added a comment. Thanks for the review. I will land the change once Fuchsia clang builders are green. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141738/new/ https://reviews.llvm.org/D141738

[PATCH] D141441: [clang] Add ElaboratedType sugaring for types on implicit special members

This revision was automatically updated to reflect the committed changes. Closed by commit rG028d13b15612: [clang] Add ElaboratedType sugaring for types on implicit special members (authored by brad.king, committed by rsmith). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D141738: Add initial support for cross compile Windows runtimes under Linux when building Fuchsia clang toolchain

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141738/new/ https://reviews.llvm.org/D141738

[clang] 028d13b - [clang] Add ElaboratedType sugaring for types on implicit special members

Author: Brad King Date: 2023-01-20T15:51:32-08:00 New Revision: 028d13b15612385202ad79269f011e3f1ecf0a25 URL: https://github.com/llvm/llvm-project/commit/028d13b15612385202ad79269f011e3f1ecf0a25 DIFF: https://github.com/llvm/llvm-project/commit/028d13b15612385202ad79269f011e3f1ecf0a25.diff

[PATCH] D141738: Add initial support for cross compile Windows runtimes under Linux when building Fuchsia clang toolchain

haowei updated this revision to Diff 490994. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141738/new/ https://reviews.llvm.org/D141738 Files: clang/cmake/caches/Fuchsia-stage2.cmake llvm/cmake/modules/LLVMExternalProjectUtils.cmake Index:

[PATCH] D142138: [OpenMP] Clean up AMD handling for `-fopenmp-targets=amdgcn` arch inference

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG255922be7f00: [OpenMP] Clean up AMD handling for `-fopenmp-targets=amdgcn` arch inference (authored by jhuber6). Repository: rG LLVM Github

[clang] 255922b - [OpenMP] Clean up AMD handling for `-fopenmp-targets=amdgcn` arch inference

Author: Joseph Huber Date: 2023-01-20T17:33:56-06:00 New Revision: 255922be7f008362bae16c708a2d90f60b4aba35 URL: https://github.com/llvm/llvm-project/commit/255922be7f008362bae16c708a2d90f60b4aba35 DIFF: https://github.com/llvm/llvm-project/commit/255922be7f008362bae16c708a2d90f60b4aba35.diff

[PATCH] D141738: Add initial support for cross compile Windows runtimes under Linux when building Fuchsia clang toolchain

phosek added inline comments. Comment at: clang/cmake/caches/Fuchsia-stage2.cmake:79 + if (LLVM_WINSYSROOT) +set(CLANG_WINDOWS_CROSS_FLAGS + -Xclang I think we'll want to use these flags even when not cross-compiling so I'd change the name to reflect

[PATCH] D142046: [BPF][clang] Ignore stack protector options for BPF target

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG56b038f887f3: [BPF][clang] Ignore stack protector options for BPF target (authored by eddyz87, committed by yonghong-song). Repository: rG LLVM

[clang] 56b038f - [BPF][clang] Ignore stack protector options for BPF target

Author: Eduard Zingerman Date: 2023-01-20T15:12:43-08:00 New Revision: 56b038f887f37f69afac2d3abe02b46dcb9305ec URL: https://github.com/llvm/llvm-project/commit/56b038f887f37f69afac2d3abe02b46dcb9305ec DIFF:

[PATCH] D142138: [OpenMP] Clean up AMD handling for `-fopenmp-targets=amdgcn` arch inference

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. In a follow up we should default to all system archs not the first one. But let's keep them in sync. LG Comment at: clang/lib/Driver/ToolChains/AMDGPUOpenMP.cpp:100 +

[PATCH] D133539: [OpenMP] Replace OpenMP register requires constructor with a global array

jhuber6 marked 2 inline comments as done. jhuber6 added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:10515 +default: + RequiresFlags.push_back(OMP_REQ_NONE); +} jdoerfert wrote: > Really? Not an error or unexpected state?

[PATCH] D133539: [OpenMP] Replace OpenMP register requires constructor with a global array

jdoerfert added a comment. Generally happy with this. Some minor comments. @sandoval, this works for you? Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:3020-3025 + if (!RequiresFlags.empty()) { +for (int64_t Flag : RequiresFlags) + createRegisterRequires(CGM,

[PATCH] D139395: Add CFI integer types normalization

rcvalle updated this revision to Diff 490976. rcvalle added a comment. Mark as experimental Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139395/new/ https://reviews.llvm.org/D139395 Files: clang/docs/ControlFlowIntegrity.rst

[PATCH] D141929: Add support for clang-cl's option -fexcess-precision.

zahiraam added a comment. In D141929#4069763 , @thakis wrote: > This breaks tests on macOS: http://45.33.8.238/macm1/53215/step_7.txt > > Please take a look and revert for now if it takes a while to fix. @thakis I reverted it. The fast value of the

[clang] f97cdc0 - Revert "Add support for clang-cl's option `-fexcess-precision`."

Author: Zahira Ammarguellat Date: 2023-01-20T16:44:51-05:00 New Revision: f97cdc013fe75e18f74fd7bba7de4913c38875a6 URL: https://github.com/llvm/llvm-project/commit/f97cdc013fe75e18f74fd7bba7de4913c38875a6 DIFF:

[PATCH] D141324: [clang] extend external_source_symbol attribute with the USR clause

arphaman added inline comments. Comment at: clang/utils/TableGen/ClangAttrEmitter.cpp:3318 +for (const auto : Attr->getValueAsListOfDefs("Spellings")) { + if (Spelling->getValueAsString("Variety") == Variety || + Spelling->getValueAsString("Variety") ==

[clang] b561c5c - [Clang] Fix test case `clang/test/OpenMP/bug59944.c`

Author: Shilei Tian Date: 2023-01-20T16:41:03-05:00 New Revision: b561c5c149467c98094c87c0e0d07c3b05f17780 URL: https://github.com/llvm/llvm-project/commit/b561c5c149467c98094c87c0e0d07c3b05f17780 DIFF: https://github.com/llvm/llvm-project/commit/b561c5c149467c98094c87c0e0d07c3b05f17780.diff

[PATCH] D142167: [clang][modules] Disallow importing private framework in the implementation

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc3efd52770ca: [clang][modules] Disallow importing private framework in the implementation (authored by jansvoboda11). Repository: rG LLVM Github

[clang] c3efd52 - [clang][modules] Disallow importing private framework in the implementation

Author: Jan Svoboda Date: 2023-01-20T13:37:36-08:00 New Revision: c3efd52770ca964ba46287298c1d2f7697fd446c URL: https://github.com/llvm/llvm-project/commit/c3efd52770ca964ba46287298c1d2f7697fd446c DIFF: https://github.com/llvm/llvm-project/commit/c3efd52770ca964ba46287298c1d2f7697fd446c.diff

[PATCH] D142165: [clang][deps] Account for transitive spurious dependencies

jansvoboda11 updated this revision to Diff 490962. jansvoboda11 added a comment. Fix test on Windows Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142165/new/ https://reviews.llvm.org/D142165 Files:

[PATCH] D141868: [Clang] [Sema] Removed a fix-it for system headers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5e5d901feb3c: [Clang] [Sema] Removed a fix-it for system headers (authored by fahadnayyar). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 5e5d901 - [Clang] [Sema] Removed a fix-it for system headers

Author: Fahad Nayyar Date: 2023-01-20T21:28:59Z New Revision: 5e5d901feb3c4522c2b4d748bd52fda18abde821 URL: https://github.com/llvm/llvm-project/commit/5e5d901feb3c4522c2b4d748bd52fda18abde821 DIFF: https://github.com/llvm/llvm-project/commit/5e5d901feb3c4522c2b4d748bd52fda18abde821.diff LOG:

[PATCH] D136315: [clang][Darwin] Try to guess the SDK root with xcrun when unspecified

steven_wu added a comment. In D136315#4069849 , @calebzulawski wrote: > In my situation, at least, I am the vendor of the toolchain and my > configuration file contains `--sysroot=/../path/to/sysroot` with a > known relative path to where the sysroot

[PATCH] D140059: [APSInt] Fix bug in APSInt mentioned in https://github.com/llvm/llvm-project/issues/59515

This revision was automatically updated to reflect the committed changes. Closed by commit rG0a89825a289d: [APSInt] Fix bug in APSInt mentioned in https://github.com/llvm/llvm… (authored by Peter). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 0a89825 - [APSInt] Fix bug in APSInt mentioned in https://github.com/llvm/llvm-project/issues/59515

Author: Peter Rong Date: 2023-01-20T13:25:15-08:00 New Revision: 0a89825a289d149195be390003424adad026067f URL: https://github.com/llvm/llvm-project/commit/0a89825a289d149195be390003424adad026067f DIFF: https://github.com/llvm/llvm-project/commit/0a89825a289d149195be390003424adad026067f.diff

[PATCH] D142238: [clang/CodeGenActionTest] Use the platform's path separator for the `DebugInfoCWDCodeGen` test

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb2b078adc2d0: [clang/CodeGenActionTest] Use the platforms path

[clang] b2b078a - [clang/CodeGenActionTest] Use the platform's path separator for the `DebugInfoCWDCodeGen` test

Author: Argyrios Kyrtzidis Date: 2023-01-20T13:20:21-08:00 New Revision: b2b078adc2d00db8dc8f0009e2bfca4d8267149a URL: https://github.com/llvm/llvm-project/commit/b2b078adc2d00db8dc8f0009e2bfca4d8267149a DIFF:

[PATCH] D142026: Optimize OptTable::findNearest implementation and usage

nikic added a comment. FYI I just noticed some i686 failures that look something like this: /builddir/build/BUILD/llvm-16.0.0.src/redhat-linux-build/unittests/Option/./OptionTests --gtest_filter=OptTableTest/0.FindNearest --

[PATCH] D142243: [CodeGen] bugfix: ApplyDebugLocation goes out of scope before intended

usama54321 updated this revision to Diff 490949. usama54321 added a comment. Removing unnecessary code from test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142243/new/ https://reviews.llvm.org/D142243 Files:

[PATCH] D142236: [clang/driver] Add `-gno-modules` as the negative version of `-gmodules`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1ff8a687ae15: [clang/driver] Add `-gno-modules` as the negative version of `-gmodules` (authored by akyrtzi). Repository: rG LLVM Github Monorepo

[clang] 1ff8a68 - [clang/driver] Add `-gno-modules` as the negative version of `-gmodules`

Author: Argyrios Kyrtzidis Date: 2023-01-20T12:39:07-08:00 New Revision: 1ff8a687ae151df72ffd3aac534fdd0d1b39f7ca URL: https://github.com/llvm/llvm-project/commit/1ff8a687ae151df72ffd3aac534fdd0d1b39f7ca DIFF:

[clang] 12251c6 - Correct documentation for the refersToType AST matcher

Author: Aaron Ballman Date: 2023-01-20T15:36:57-05:00 New Revision: 12251c64548785cb70b09ffd3ba91f639660341f URL: https://github.com/llvm/llvm-project/commit/12251c64548785cb70b09ffd3ba91f639660341f DIFF: https://github.com/llvm/llvm-project/commit/12251c64548785cb70b09ffd3ba91f639660341f.diff

[PATCH] D142243: [CodeGen] bugfix: ApplyDebugLocation goes out of scope before intended

aprantl added a comment. Code LGTM, it would be nice if we could further reduce the test case. Comment at: clang/test/CodeGenObjC/objc-arc-ubsan-debugging.m:2 +// RUN: %clang -x objective-c -target arm64-apple-macos12.0 -fobjc-arc -std=gnu99 -O0 -fsanitize=undefined

[PATCH] D137268: [clang][Headers] Do not define varargs macros for __need___va_list

zatrazz added a comment. In D137268#4069935 , @enh wrote: > In D137268#4069856 , @zatrazz wrote: > >> I think I have caught this because your standard conformance tests checks >> for __gnuc_va_list >> on

[PATCH] D142222: [PowerPC] Remove the lax warning for explicit casts

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5b4ed4905017: [PowerPC] Remove the lax warning for explicit casts (authored by maryammo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 5b4ed49 - [PowerPC] Remove the lax warning for explicit casts

Author: Maryam Moghadas Date: 2023-01-20T14:23:54-06:00 New Revision: 5b4ed4905017a052501becfde8dd1fca1e476ee3 URL: https://github.com/llvm/llvm-project/commit/5b4ed4905017a052501becfde8dd1fca1e476ee3 DIFF:

[PATCH] D137268: [clang][Headers] Do not define varargs macros for __need___va_list

enh added a comment. In D137268#4069856 , @zatrazz wrote: > I think I have caught this because your standard conformance tests checks for > __gnuc_va_list > on wchar.h, wich is always defined on on GCC (git log shows it was changed to > fix XPG7 >

[PATCH] D141528: [Clang][OpenMP] Fix loop directive nested inside a parallel

doru1004 closed this revision. doru1004 added a comment. Commit: 1407dbeabcfed114f0918b022365d03713dac028 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141528/new/ https://reviews.llvm.org/D141528

[clang] 1407dbe - Allow a target loop to be used inside a parallel.

Author: Doru Bercea Date: 2023-01-20T14:10:43-06:00 New Revision: 1407dbeabcfed114f0918b022365d03713dac028 URL: https://github.com/llvm/llvm-project/commit/1407dbeabcfed114f0918b022365d03713dac028 DIFF: https://github.com/llvm/llvm-project/commit/1407dbeabcfed114f0918b022365d03713dac028.diff

[PATCH] D142246: [HIP] Change default offload arch to gfx906

yaxunl created this revision. yaxunl added a reviewer: tra. Herald added a project: All. yaxunl requested review of this revision. Herald added a subscriber: MaskRay. Change default offload arch to gfx906 since it is the lowest officially supported offload arch

[clang] fb9b3e9 - Update the status of some C11 and C99 features we support

Author: Aaron Ballman Date: 2023-01-20T14:50:39-05:00 New Revision: fb9b3e9a5f23cfc43106c1209fd4a07761eee5e9 URL: https://github.com/llvm/llvm-project/commit/fb9b3e9a5f23cfc43106c1209fd4a07761eee5e9 DIFF: https://github.com/llvm/llvm-project/commit/fb9b3e9a5f23cfc43106c1209fd4a07761eee5e9.diff

[PATCH] D141581: [clang] Make clangBasic and clangDriver depend on LLVMTargetParser.

kwk added a comment. @tstellar as you suspected, I had the following problem when building clang in standalone mode and your patch solved it for me. Thank you. -- Configuring done CMake Error at /usr/lib64/cmake/llvm/AddLLVM.cmake:536 (add_dependencies): The dependency target

[PATCH] D136315: [clang][Darwin] Try to guess the SDK root with xcrun when unspecified

calebzulawski added inline comments. Comment at: clang/test/Driver/darwin-sdk-detect.c:1 +// REQUIRES: system-darwin + steven_wu wrote: > This test won't work in all conditions. Like I said, you requires to have a > Xcode/CommandLineTools installation to make

[PATCH] D141581: [clang] Make clangBasic and clangDriver depend on LLVMTargetParser.

tstellar added a comment. I spent some time looking at this. Rather than changing the dependency from RISCVTargetParserTableGen to LLVMTargetParser, I think the correct fix is to handle RISCVTargetParserTableGen in llvm/cmake/modules/LLVMConfig.cmake.in. alongside the intrinsics_gen,

[PATCH] D137268: [clang][Headers] Do not define varargs macros for __need___va_list

zatrazz added a comment. In D137268#4069779 , @enh wrote: > is there a corresponding glibc change so that `va_list` is exported for > `_POSIX_SOURCE` cases? see > https://android-review.git.corp.google.com/c/platform/bionic/+/2397313 where > i'm

[PATCH] D142233: [Clang][OpenMP] Bail out early if `Scope` is nullptr in case of any crash

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. tianshilei1992 marked an inline comment as done. Closed by commit rG2ebda47619d7: [Clang][OpenMP] Bail out early if `Scope` is nullptr in case of any crash (authored

[clang] 2ebda47 - [Clang][OpenMP] Bail out early if `Scope` is nullptr in case of any crash

Author: Shilei Tian Date: 2023-01-20T14:40:24-05:00 New Revision: 2ebda47619d7e8b72d460a955de4f398f637489f URL: https://github.com/llvm/llvm-project/commit/2ebda47619d7e8b72d460a955de4f398f637489f DIFF: https://github.com/llvm/llvm-project/commit/2ebda47619d7e8b72d460a955de4f398f637489f.diff

[PATCH] D136315: [clang][Darwin] Try to guess the SDK root with xcrun when unspecified

calebzulawski added a comment. In my situation, at least, I am the vendor of the toolchain and my configuration file contains `--sysroot=/../path/to/sysroot` with a known relative path to where the sysroot is distributed. Apple is unique in this situation, since I am not distributing the

[PATCH] D142243: [CodeGen] bugfix: ApplyDebugLocation goes out of scope before intended

usama54321 created this revision. Herald added a project: All. usama54321 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. rdar://103570533 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D142243 Files:

[PATCH] D142242: [CodeGen] bugfix: ApplyDebugLocation goes out of scope before intended

usama54321 updated this revision to Diff 490923. usama54321 added a comment. Renaming identifiers in test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142242/new/ https://reviews.llvm.org/D142242 Files: clang/lib/CodeGen/CodeGenFunction.cpp

[PATCH] D142242: [CodeGen] bugfix: ApplyDebugLocation goes out of scope before intended

usama54321 updated this revision to Diff 490922. usama54321 added a comment. Renaming identifiers in test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142242/new/ https://reviews.llvm.org/D142242 Files: clang/lib/CodeGen/CodeGenFunction.cpp

[PATCH] D141738: Add initial support for cross compile Windows runtimes under Linux when building Fuchsia clang toolchain

haowei updated this revision to Diff 490921. haowei added a comment. Correct an issue llvm-rc and llvm-mt are not part of `TOOLCHAIN_TOOLS` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141738/new/ https://reviews.llvm.org/D141738 Files:

[PATCH] D142242: [CodeGen] bugfix: ApplyDebugLocation goes out of scope before intended

usama54321 created this revision. Herald added a project: All. usama54321 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. rdar://103570533 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D142242 Files:

[PATCH] D137268: [clang][Headers] Do not define varargs macros for __need___va_list

enh added a comment. is there a corresponding glibc change so that `va_list` is exported for `_POSIX_SOURCE` cases? see https://android-review.git.corp.google.com/c/platform/bionic/+/2397313 where i'm having to disable some bionic testing against glibc because the glibc (2.17!) now no longer

[PATCH] D142196: [clang][Lex] Add back PPCallbacks::FileNotFound

jansvoboda11 added a comment. In D142196#4068428 , @Hahnfeld wrote: > I just checked and this "simplified" version of the callback would give us > enough information to implement all we need in ROOT (plus some, the `bool` > return value is nicer than

[PATCH] D139168: [C++20] [Modules] [ClangScanDeps] Enable to print make-style dependency file within P1689 format (4/4)

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139168/new/ https://reviews.llvm.org/D139168 ___ cfe-commits mailing list

[PATCH] D137534: [C++20] [Modules] [ClangScanDeps] Allow clang-scan-deps to without specified compilation database in P1689 (3/4)

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137534/new/ https://reviews.llvm.org/D137534 ___ cfe-commits mailing list

[PATCH] D141929: Add support for clang-cl's option -fexcess-precision.

thakis added a comment. This breaks tests on macOS: http://45.33.8.238/macm1/53215/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141929/new/

[PATCH] D136315: [clang][Darwin] Try to guess the SDK root with xcrun when unspecified

steven_wu added a comment. This is not an apple platform problem. This is a cross compile problem where you have a SDK that is installed for cross compile target. In those cases, you just can't hard code the path to isysroot, and figuring out the sysroot is generally considered a problem for

[PATCH] D140972: [flang] Add -fstack-arrays flag

awarzynski added inline comments. Comment at: clang/include/clang/Driver/Options.td:485-486 +// Works like BoolOption except without specifying a KeyPathAndMacro, as these +// would refer to non-existant members of clang data structures +multiclass

[PATCH] D141871: [Clang][OpenMP] Add parse and sema for iterator map modifier

doru1004 closed this revision. doru1004 added a comment. Commit 49d47c4d2f280d15d1de94c53b72b6ab3c127b35 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141871/new/ https://reviews.llvm.org/D141871

[clang] 49d47c4 - Add Parse/Sema for iterator for map clause.

Author: Doru Bercea Date: 2023-01-20T12:54:49-06:00 New Revision: 49d47c4d2f280d15d1de94c53b72b6ab3c127b35 URL: https://github.com/llvm/llvm-project/commit/49d47c4d2f280d15d1de94c53b72b6ab3c127b35 DIFF: https://github.com/llvm/llvm-project/commit/49d47c4d2f280d15d1de94c53b72b6ab3c127b35.diff

[PATCH] D139774: [libclang] Add API to set temporary directory location

dblaikie added a comment. In D139774#4069014 , @aaron.ballman wrote: > In D139774#4066920 , @dblaikie > wrote: > >> Don't let me hold this up - I think it all feels a bit too ad-hoc for my own >> preferences

[PATCH] D136315: [clang][Darwin] Try to guess the SDK root with xcrun when unspecified

calebzulawski added a comment. If `SDKROOT` is set or `-isysroot` is passed, `xcrun` won't be called so there is no regression for existing use cases like CMake. Additionally, if `xcrun` isn't found, no error is emitted. I also added the `--no-detect-xcode` flag based on similar feedback

[PATCH] D136315: [clang][Darwin] Try to guess the SDK root with xcrun when unspecified

steven_wu added a comment. In D136315#4069582 , @calebzulawski wrote: > That makes more sense, I thought perhaps it was using `DEFAULT_SYSROOT`. The > shim isn't smart enough to choose the sysroot from the target unfortunately. > > It looks like the

[PATCH] D142238: [clang/CodeGenActionTest] Use the platform's path separator for the `DebugInfoCWDCodeGen` test

akyrtzi created this revision. Herald added a project: All. akyrtzi requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes a failure in some Windows configuration. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D142238

[PATCH] D142236: [clang/driver] Add `-gno-modules` as the negative version of `-gmodules`

akyrtzi created this revision. Herald added a project: All. akyrtzi requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D142236 Files:

[PATCH] D136315: [clang][Darwin] Try to guess the SDK root with xcrun when unspecified

calebzulawski added a comment. That makes more sense, I thought perhaps it was using `DEFAULT_SYSROOT`. The shim isn't smart enough to choose the sysroot from the target unfortunately. It looks like the only error is unrelated to this change, something with concepts in libc++. Repository:

[PATCH] D134719: [AArch64] Enable libm vectorized functions via SLEEF

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc4fa504f797f: [AArch64] Enable libm vectorized functions via SLEEF (authored by danielkiss). Herald added a project: clang. Herald added a

[clang] c4fa504 - [AArch64] Enable libm vectorized functions via SLEEF

Author: Daniel Kiss Date: 2023-01-20T18:52:38+01:00 New Revision: c4fa504f797f68297c252dc91a24c7d37c1de4df URL: https://github.com/llvm/llvm-project/commit/c4fa504f797f68297c252dc91a24c7d37c1de4df DIFF: https://github.com/llvm/llvm-project/commit/c4fa504f797f68297c252dc91a24c7d37c1de4df.diff

[PATCH] D142233: [Clang][OpenMP] Bail out early if `Scope` is nullptr in case of any crash

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142233/new/ https://reviews.llvm.org/D142233

[PATCH] D142077: [Clang][SemaCXX][Coroutines] Fix misleading diagnostics with -Wunsequenced

bruno added a comment. Test failure is unrelated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142077/new/ https://reviews.llvm.org/D142077 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D142233: [Clang][OpenMP] Bail out early if `Scope` is nullptr in case of any crash

tianshilei1992 updated this revision to Diff 490896. tianshilei1992 added a comment. fix comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142233/new/ https://reviews.llvm.org/D142233 Files: clang/lib/Sema/SemaOpenMP.cpp

[PATCH] D142222: [PowerPC] Remove the lax warning for explicit casts

maryammo updated this revision to Diff 490895. maryammo added a comment. Adding test for template Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14/new/ https://reviews.llvm.org/D14 Files: clang/lib/Sema/SemaOverload.cpp

  1   2   >