[PATCH] D142564: [clang-doc] Reduce duplicate code with template

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142564/new/ https://reviews.llvm.org/D142564

[clang] 7f48154 - Re-apply "[clang][Interp] Fix left-/right-shifting more than sizeof(unsigned)"

Author: Timm Bäder Date: 2023-01-26T08:02:27+01:00 New Revision: 7f48154ca11fee6579fe29a51ab2a329424d31c4 URL: https://github.com/llvm/llvm-project/commit/7f48154ca11fee6579fe29a51ab2a329424d31c4 DIFF: https://github.com/llvm/llvm-project/commit/7f48154ca11fee6579fe29a51ab2a329424d31c4.diff

[clang] 7e629e4 - [AST] Use llvm::bit_width (NFC)

Author: Kazu Hirata Date: 2023-01-25T22:59:51-08:00 New Revision: 7e629e4e888262abd8f076512b252208acd72d62 URL: https://github.com/llvm/llvm-project/commit/7e629e4e888262abd8f076512b252208acd72d62 DIFF: https://github.com/llvm/llvm-project/commit/7e629e4e888262abd8f076512b252208acd72d62.diff

[PATCH] D139774: [libclang] Add API to set temporary directory location

vedgy added a comment. 3 out of 4 alternatives remain: > 1. Add an option to store the preamble-*.pch files in RAM instead of /tmp and > add a corresponding option in KDevelop configuration UI. This would work > perfectly for me, provided I don't change my mind and decide to turn this >

[clang] 136c7ef - Revert "[clang][Interp] Fix left-/right-shifting more than sizeof(unsigned)"

Author: Timm Bäder Date: 2023-01-26T07:49:10+01:00 New Revision: 136c7ef5d10fca0af101821b05084b428830e670 URL: https://github.com/llvm/llvm-project/commit/136c7ef5d10fca0af101821b05084b428830e670 DIFF: https://github.com/llvm/llvm-project/commit/136c7ef5d10fca0af101821b05084b428830e670.diff

[clang] 5bf56a5 - [clang][Interp][NFCI] Don't crash on void builtin functions

Author: Timm Bäder Date: 2023-01-26T07:32:33+01:00 New Revision: 5bf56a58775cb235b7ed9e9fcc6895b797e9721b URL: https://github.com/llvm/llvm-project/commit/5bf56a58775cb235b7ed9e9fcc6895b797e9721b DIFF: https://github.com/llvm/llvm-project/commit/5bf56a58775cb235b7ed9e9fcc6895b797e9721b.diff

[PATCH] D142604: [Clang] Fix __VA_OPT__ implementation so that it treats the concatenation of a non-placemaker token and placemaker token as a non-placemaker token

shafik created this revision. shafik added reviewers: aaron.ballman, erichkeane, hubert.reinterpretcast. Herald added a project: All. shafik requested review of this revision. Currently the implementation of `__VA_OPT__` will treat the concatenation of a non-placemaker token and placemaker token

[PATCH] D141472: [clang][Interp] Add function pointers

tbaeder updated this revision to Diff 492338. tbaeder marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141472/new/ https://reviews.llvm.org/D141472 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/Context.cpp

[PATCH] D131306: [llvm][misexpect] Track provenance of branch weights

jdoerfert added a comment. Drive by: There should be a lang ref component to this. Also, changing branch weight metadata might impact downstream users, an RFC seems in order (assuming I didn't miss one). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D142596: [RISCV] Bump Zca, Zcd, Zcf version to 1.0.

craig.topper updated this revision to Diff 492337. craig.topper added a comment. Update tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142596/new/ https://reviews.llvm.org/D142596 Files: clang/test/Driver/riscv-arch.c

[PATCH] D141472: [clang][Interp] Add function pointers

tbaeder marked an inline comment as done. tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:138-139 case CK_IntegralToPointer: { if (isa(SubExpr)) return this->visit(SubExpr); aaron.ballman wrote: > Can we still

[PATCH] D137706: [clang][Interp] Implement IntegralToPointer casts

tbaeder added a comment. Note that according to https://clang.llvm.org/docs/ConstantInterpreter.html#pointers, such pointers had their own pointer type (`TargetPointer`), so I'm not sure if the approach here is the right one. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137706/new/

[PATCH] D142596: [RISCV] Bump Zca version to 1.0.

craig.topper updated this revision to Diff 492331. craig.topper added a comment. Add Zcf and Zcd too Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142596/new/ https://reviews.llvm.org/D142596 Files: clang/test/Driver/riscv-arch.c

[PATCH] D140845: [clang][Interp] Fix left-/right-shifting more than sizeof(unsigned)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG00e967f6c2d6: [clang][Interp] Fix left-/right-shifting more than sizeof(unsigned) (authored by tbaeder). Repository: rG LLVM Github Monorepo

[clang] 00e967f - [clang][Interp] Fix left-/right-shifting more than sizeof(unsigned)

Author: Timm Bäder Date: 2023-01-26T07:07:17+01:00 New Revision: 00e967f6c2d626d1913f5af5763beab7946978ce URL: https://github.com/llvm/llvm-project/commit/00e967f6c2d626d1913f5af5763beab7946978ce DIFF: https://github.com/llvm/llvm-project/commit/00e967f6c2d626d1913f5af5763beab7946978ce.diff

[PATCH] D131141: [RISCV] Add MC support of RISCV Zcb Extension

craig.topper updated this revision to Diff 492325. craig.topper added a comment. Update RISCVUsage.rst Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131141/new/ https://reviews.llvm.org/D131141 Files:

[PATCH] D142592: [clang-tidy][libc] Add an inline function checker for the libc project.

sivachandra updated this revision to Diff 492324. sivachandra added a comment. Use explicit type instead of auto. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142592/new/ https://reviews.llvm.org/D142592 Files:

[PATCH] D131141: [RISCV] Add MC support of RISCV Zcb Extension

craig.topper added a comment. @VincentWu are you ok with the changes I made? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131141/new/ https://reviews.llvm.org/D131141 ___ cfe-commits mailing list

[PATCH] D140809: [clang][Interp] Implement logical and/or operators

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd2ea8ae5d43e: [clang][Interp] Implement logical and/or operators (authored by tbaeder). Changed prior to commit:

[clang] d2ea8ae - [clang][Interp] Implement logical and/or operators

Author: Timm Bäder Date: 2023-01-26T06:52:35+01:00 New Revision: d2ea8ae5d43e05791a201e7ca233d3f637254597 URL: https://github.com/llvm/llvm-project/commit/d2ea8ae5d43e05791a201e7ca233d3f637254597 DIFF: https://github.com/llvm/llvm-project/commit/d2ea8ae5d43e05791a201e7ca233d3f637254597.diff

[clang-tools-extra] a5cd202 - Use llvm::Log2_32 and llvm::Log2_64 instead of llvm::findLastSet (NFC)

Author: Kazu Hirata Date: 2023-01-25T21:34:09-08:00 New Revision: a5cd202e21e52c1e00963ad5bdfeb83b4fec820e URL: https://github.com/llvm/llvm-project/commit/a5cd202e21e52c1e00963ad5bdfeb83b4fec820e DIFF: https://github.com/llvm/llvm-project/commit/a5cd202e21e52c1e00963ad5bdfeb83b4fec820e.diff

[clang] a5cd202 - Use llvm::Log2_32 and llvm::Log2_64 instead of llvm::findLastSet (NFC)

Author: Kazu Hirata Date: 2023-01-25T21:34:09-08:00 New Revision: a5cd202e21e52c1e00963ad5bdfeb83b4fec820e URL: https://github.com/llvm/llvm-project/commit/a5cd202e21e52c1e00963ad5bdfeb83b4fec820e DIFF: https://github.com/llvm/llvm-project/commit/a5cd202e21e52c1e00963ad5bdfeb83b4fec820e.diff

[PATCH] D142569: [WIP][OpenMP] Introduce kernel argument

tianshilei1992 updated this revision to Diff 492322. tianshilei1992 added a comment. fix bugs and add plugin support Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142569/new/ https://reviews.llvm.org/D142569 Files:

[PATCH] D141959: [clang-format] Fix inconsistent identification of operator

dkt01 added a comment. David Turner Good to know it worked as expected on your project as well. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141959/new/ https://reviews.llvm.org/D141959 ___ cfe-commits mailing list

[PATCH] D140059: [APSInt] Fix bug in APSInt mentioned in https://github.com/llvm/llvm-project/issues/59515

Peter added a comment. In D140059#4081549 , @vabridgers wrote: > Hello, it appears this patch causes a crash when I analyze this reproducer, > with Z3 enabled. In the case shown here, the analyzer finds that 'f' to the > call a(f) is uninitialized,

[PATCH] D131141: [RISCV] Add MC support of RISCV Zcb Extension

VincentWu updated this revision to Diff 492319. VincentWu added a comment. reset HEAD back to Diff 492315 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131141/new/

[PATCH] D131141: [RISCV] Add MC support of RISCV Zcb Extension

VincentWu updated this revision to Diff 492318. VincentWu added a comment. rebase to upstream Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131141/new/ https://reviews.llvm.org/D131141 Files: clang/test/Preprocessor/riscv-target-features.c

[PATCH] D129008: [Clang][OpenMP] Fix the issue that globalization doesn't work with byval struct function argument

rjmccall added a comment. Right. C structs can require more than just `memcpy` to copy in several different situations (all involving language extensions), but it doesn't require Sema to be involved: it doesn't introduce uses of user declarations, and the compiler can figure out the work it

[PATCH] D142569: [WIP][OpenMP] Introduce kernel argument

tianshilei1992 updated this revision to Diff 492316. tianshilei1992 added a comment. rebase, fix comments, added more code. features are finished now. time to move to tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142569/new/

[PATCH] D142584: [CodeGen] Add a boolean flag to `Address::getPointer` and `Lvalue::getPointer` that indicates whether the pointer is known not to be null

rjmccall added a comment. In D142584#4081345 , @efriedma wrote: > I'm having a little trouble following what the meaning of an "Address" is > with this patch. The `Pointer` member refers to an encoded value, and > calling getPointer() emits IR to

[PATCH] D131141: [RISCV] Add MC support of RISCV Zcb Extension

craig.topper updated this revision to Diff 492315. craig.topper added a comment. Fix RUN line that was duplicate testing riscv64 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131141/new/ https://reviews.llvm.org/D131141 Files:

[PATCH] D142354: [analyzer] Create a stub for an std::variant checker

NoQ added a comment. In D142354#4079643 , @Szelethus wrote: >> In the latter case, have you explored the possibility of force-inlining the >> class instead, like I suggested in the thread? > > I have done some tests then, and figured that the analyzer

[PATCH] D140795: [Flang] Add user option -funderscoring/-fnounderscoring to control trailing underscore added to external names

madanial updated this revision to Diff 492312. madanial retitled this revision from "[Flang] Add user option -funderscoring/-fnounderscoring to enable/disable ExternalNameConversionPass" to "[Flang] Add user option -funderscoring/-fnounderscoring to control trailing underscore added to external

[PATCH] D142592: [clang-tidy][libc] Add an inline function checker for the libc project.

Eugene.Zelenko added a comment. Please add entry in Release Notes. Comment at: clang-tools-extra/clang-tidy/llvmlibc/InlineFunctionDeclCheck.cpp:29 + + auto SrcBegin = FuncDecl->getSourceRange().getBegin(); + // Consider functions only in header files.

[PATCH] D131141: [RISCV] Add MC support of RISCV Zcb Extension

craig.topper updated this revision to Diff 492311. craig.topper added a comment. Fix typo in RISCVBaseInfo.h Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131141/new/ https://reviews.llvm.org/D131141 Files:

[PATCH] D131141: [RISCV] Add MC support of RISCV Zcb Extension

craig.topper updated this revision to Diff 492310. craig.topper added a comment. Merge uimm32_zc into uimm2. Add RISCVOp::OPERAND_TYPE_UIMM2_LSB0 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131141/new/ https://reviews.llvm.org/D131141 Files:

[PATCH] D142596: [RISCV] Bump Zca version to 1.0.

craig.topper created this revision. craig.topper added reviewers: VincentWu, asb, luismarques, reames, jrtc27. Herald added subscribers: luke, vkmr, frasercrmck, jdoerfert, evandro, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01,

[PATCH] D141826: [clang][TemplateBase] Add IsDefaulted bit to TemplateArgument

Michael137 updated this revision to Diff 492306. Michael137 added a comment. - Remove redundant constructor call change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141826/new/ https://reviews.llvm.org/D141826 Files:

[PATCH] D142595: [Driver][AVR] Don't emit default '-Tdata' when a linker script is specified

benshi001 created this revision. benshi001 added reviewers: MaskRay, aykevl, Miss_Grape. Herald added subscribers: Jim, dylanmckay. Herald added a project: All. benshi001 requested review of this revision. Herald added subscribers: cfe-commits, jacquesguan. Herald added a project: clang. Fixes

[PATCH] D142592: [clang-tidy][libc] Add an inline function checker for the libc project.

sivachandra created this revision. sivachandra added a reviewer: aaron.ballman. Herald added subscribers: ChuanqiXu, carlosgalvezp, ecnelises, tschuett, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. sivachandra requested review of this revision. Herald added a

[PATCH] D142569: [WIP][OpenMP] Introduce kernel argument

tianshilei1992 added inline comments. Comment at: openmp/libomptarget/DeviceRTL/src/Configuration.cpp:57 + return !__omp_rtl_assume_no_nested_parallelism || + state::getKernelEnvironment().Configuration.MayUseNestedParallelism; } jdoerfert wrote: >

[PATCH] D142569: [WIP][OpenMP] Introduce kernel argument

jdoerfert added inline comments. Comment at: openmp/libomptarget/DeviceRTL/src/Configuration.cpp:57 + return !__omp_rtl_assume_no_nested_parallelism || + state::getKernelEnvironment().Configuration.MayUseNestedParallelism; } This looks wrong. We want

[PATCH] D131141: [RISCV] Add MC support of RISCV Zcb Extension

craig.topper updated this revision to Diff 492298. craig.topper added a comment. Update for rename CS_ALU to CA_ALU Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131141/new/ https://reviews.llvm.org/D131141 Files:

[PATCH] D140059: [APSInt] Fix bug in APSInt mentioned in https://github.com/llvm/llvm-project/issues/59515

vabridgers added a comment. Hello, it appears this patch causes a crash when I analyze this reproducer, with Z3 enabled. In the case shown here, the analyzer finds that 'f' to the call a(f) is uninitialized, and then is attempted to be refuted through SMTConv, leading to the assertion. If I

[PATCH] D129951: adds `__disable_adl` attribute

cjdb added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:542 If a statement is marked ``nomerge`` and contains call expressions, those call -expressions inside the statement will not be merged during optimization. This +expressions inside the statement

[PATCH] D129951: adds `__disable_adl` attribute

cjdb updated this revision to Diff 492296. cjdb marked 6 inline comments as done. cjdb added a comment. responds to feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129951/new/ https://reviews.llvm.org/D129951 Files:

[PATCH] D131141: [RISCV] Add MC support of RISCV Zcb Extension

craig.topper updated this revision to Diff 492295. craig.topper added a comment. Add CSZN format as named in the spec. Reuse CLoad_ri/CStore_rri classes instead of creating new ones that were almost the same. Use CS_ALU class for c.mul. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D140628: [flang] Add driver install directory to AIX toolchain program paths list

This revision was automatically updated to reflect the committed changes. Closed by commit rG5e72407635a4: [flang] Add driver install directory to AIX toolchain program paths list. (authored by pscoro, committed by w2yehia). Changed prior to commit:

[clang] 5e72407 - [flang] Add driver install directory to AIX toolchain program paths list.

Author: Paul Scoropan Date: 2023-01-26T00:39:51Z New Revision: 5e72407635a43b8b7f85c1658b6738f023a21f03 URL: https://github.com/llvm/llvm-project/commit/5e72407635a43b8b7f85c1658b6738f023a21f03 DIFF: https://github.com/llvm/llvm-project/commit/5e72407635a43b8b7f85c1658b6738f023a21f03.diff

[PATCH] D142577: [clang-doc] Removed unused method in the Info class

This revision was automatically updated to reflect the committed changes. Closed by commit rG881d151c527c: [clang-doc] Removed unused method in the Info class (authored by paulkirth). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142577/new/

[clang-tools-extra] 881d151 - [clang-doc] Removed unused method in the Info class

Author: Paul Kirth Date: 2023-01-25T23:55:59Z New Revision: 881d151c527c0eaae89af5842f4167f7a2439a13 URL: https://github.com/llvm/llvm-project/commit/881d151c527c0eaae89af5842f4167f7a2439a13 DIFF: https://github.com/llvm/llvm-project/commit/881d151c527c0eaae89af5842f4167f7a2439a13.diff LOG:

[PATCH] D142569: [WIP][OpenMP] Introduce kernel argument

tianshilei1992 added inline comments. Comment at: llvm/lib/Transforms/IPO/OpenMPOpt.cpp:2544 - ~AAExecutionDomainFunction() { -delete RPOT; - } + ~AAExecutionDomainFunction() { delete RPOT; } This will be removed properly later. Repository: rG

[PATCH] D142569: [WIP][OpenMP] Introduce kernel argument

tianshilei1992 updated this revision to Diff 492278. tianshilei1992 marked 6 inline comments as done. tianshilei1992 added a comment. rebase, add more code, fix comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142569/new/

[PATCH] D142459: [clang] Deprecate uses of GlobalObject::getAlignment

arsenm added inline comments. Comment at: clang/lib/CodeGen/CGCUDANV.cpp:491 new llvm::LoadInst(Var->getType(), ManagedVar, "ld.managed", false, - llvm::Align(Var->getAlignment()), I); +

[PATCH] D131141: [RISCV] Add MC support of RISCV Zcb Extension

craig.topper updated this revision to Diff 492276. craig.topper added a comment. Add back the new files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131141/new/ https://reviews.llvm.org/D131141 Files:

[PATCH] D131141: [RISCV] Add MC support of RISCV Zcb Extension

craig.topper updated this revision to Diff 492275. craig.topper edited the summary of this revision. craig.topper added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131141/new/ https://reviews.llvm.org/D131141 Files:

[PATCH] D142459: [clang] Deprecate uses of GlobalObject::getAlignment

yaxunl added inline comments. Comment at: clang/lib/CodeGen/CGCUDANV.cpp:491 new llvm::LoadInst(Var->getType(), ManagedVar, "ld.managed", false, - llvm::Align(Var->getAlignment()), I); +

[PATCH] D142564: [clang-doc] Reduce duplicate code with template

paulkirth updated this revision to Diff 492274. paulkirth added a comment. Clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142564/new/ https://reviews.llvm.org/D142564 Files: clang-tools-extra/clang-doc/Representation.cpp Index:

[PATCH] D142587: [clang-tidy] Improved too-small-loop-variable with bit-field support

ClockMan created this revision. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. ClockMan published this revision for review. ClockMan added a comment. Herald added a project: clang-tools-extra. Herald added a subscriber:

[PATCH] D131137: [clang][misexpect] Add support to clang for profitable annotation diagnostics

paulkirth updated this revision to Diff 492269. paulkirth added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131137/new/ https://reviews.llvm.org/D131137 Files: clang/include/clang/Basic/CodeGenOptions.def

[PATCH] D105584: [MLIR][OpenMP] Distribute Construct Operation

abidmalikwaterloo added a comment. In D105584#4081228 , @kiranchandramohan wrote: > Since the plan is to switch to the Canonical Style operation, maybe this can > wait till the `omp.canonical_loop` changes are in? Ok..make sense Repository: rG

[PATCH] D142584: [CodeGen] Add a boolean flag to `Address::getPointer` and `Lvalue::getPointer` that indicates whether the pointer is known not to be null

efriedma added a comment. I'm having a little trouble following what the meaning of an "Address" is with this patch. The `Pointer` member refers to an encoded value, and calling getPointer() emits IR to decode it? Could use a few comments to explain the API. Repository: rG LLVM Github

[PATCH] D142584: [CodeGen] Add a boolean flag to `Address::getPointer` and `Lvalue::getPointer` that indicates whether the pointer is known not to be null

ahatanak created this revision. ahatanak added reviewers: rjmccall, ab, efriedma. ahatanak added a project: clang. Herald added a subscriber: kristof.beyls. Herald added a project: All. ahatanak requested review of this revision. The flag will be used for the arm64e work we plan to upstream in

[PATCH] D140250: Define NULL in its own header

iana planned changes to this revision. iana added a comment. In D140250#4081133 , @iana wrote: > In D140250#4081119 , @rsmith wrote: > >> In D140250#4081102 , @rsmith

[PATCH] D142583: [SPIR-V] Add support for __arithmetic_fence builtin for SYCL targets.

bader added a comment. "[SPIR-V] Add support for __arithmetic_fence builtin for SYCL targets." -> "[SPIR] Add support for __arithmetic_fence builtin for SPIR target." Comment at: clang/test/CodeGen/arithmetic-fence-builtin.c:16 +// Test with fast math on spir target +// RUN:

[clang] 11656f2 - [CUDA] Fix output from `ptxas` being removes as a temporary file

Author: Joseph Huber Date: 2023-01-25T16:24:30-06:00 New Revision: 11656f204aa5fd972564e76641c00ca058ba8c0d URL: https://github.com/llvm/llvm-project/commit/11656f204aa5fd972564e76641c00ca058ba8c0d DIFF: https://github.com/llvm/llvm-project/commit/11656f204aa5fd972564e76641c00ca058ba8c0d.diff

[PATCH] D142583: [SPIR-V] Add support for __arithmetic_fence builtin for SYCL targets.

zahiraam created this revision. zahiraam added reviewers: bader, andrew.w.kaylor. Herald added subscribers: Naghasan, Anastasia, ebevhan, yaxunl. Herald added a project: All. zahiraam requested review of this revision. Herald added a project: clang. __arithmetic_fence enforces ordering on

[PATCH] D142578: [Clang][Doc] Edit the Clang release notes

rymiel added a comment. I don't know sphinx enough to know if the trailing underscore is needed in links, but there's about 5 links that don't have the underscore (Search for >`) ) Comment at: clang/docs/ReleaseNotes.rst:577 + potential false positives, this diagnostic

[PATCH] D105584: [MLIR][OpenMP] Distribute Construct Operation

kiranchandramohan added a comment. Herald added a subscriber: thopre. Since the plan is to switch to the Canonical Style operation, may be this can wait till the `omp.canonical_loop` changes are in? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D142459: [clang] Deprecate uses of GlobalObject::getAlignment

efriedma added inline comments. Comment at: clang/lib/CodeGen/CGCUDANV.cpp:491 new llvm::LoadInst(Var->getType(), ManagedVar, "ld.managed", false, - llvm::Align(Var->getAlignment()), I); +

[PATCH] D129951: adds `__disable_adl` attribute

shafik added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:542 If a statement is marked ``nomerge`` and contains call expressions, those call -expressions inside the statement will not be merged during optimization. This +expressions inside the statement

[PATCH] D140250: Define NULL in its own header

iana added a comment. In D140250#4081119 , @rsmith wrote: > In D140250#4081102 , @rsmith wrote: > >> Our builtin header `stddef.h` shouldn't be built as a module. It >> fundamentally needs to be treated as a

[PATCH] D131306: [llvm][misexpect] Track provenance of branch weights

paulkirth updated this revision to Diff 492246. paulkirth added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131306/new/ https://reviews.llvm.org/D131306 Files: clang/test/CodeGenCXX/attr-likelihood-if-branch-weights.cpp

[clang] bfe4514 - [amdgpuarch] Delete stray hsa #include line

Author: Jon Chesterfield Date: 2023-01-25T21:40:35Z New Revision: bfe4514add5b7ab7e1f06248983a7162d734cffb URL: https://github.com/llvm/llvm-project/commit/bfe4514add5b7ab7e1f06248983a7162d734cffb DIFF: https://github.com/llvm/llvm-project/commit/bfe4514add5b7ab7e1f06248983a7162d734cffb.diff

[PATCH] D140250: Define NULL in its own header

rsmith added a comment. In D140250#4081102 , @rsmith wrote: > Our builtin header `stddef.h` shouldn't be built as a module. It > fundamentally needs to be treated as a textual header, because it consumes > macros defined by the includer. The module map

[PATCH] D140250: Define NULL in its own header

rsmith added a comment. In D140250#4081009 , @iana wrote: > In D140250#4080990 , @rsmith wrote: > >> Wait a second... if an OS wants only `NULL`, we already have a supported way >> of achieving that, which is

[PATCH] D139395: Add CFI integer types normalization

samitolvanen added a reviewer: samitolvanen. samitolvanen accepted this revision. samitolvanen added a comment. This revision is now accepted and ready to land. Thanks, LGTM. @pcc, does this version look fine to you? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D140250: Define NULL in its own header

iana added a comment. In D140250#4081044 , @aaron.ballman wrote: > In D140250#4081009 , @iana wrote: > >> In D140250#4080990 , @rsmith wrote: >> >>> Wait a second... if

[PATCH] D142578: [Clang][Doc] Edit the Clang release notes

royjacobson created this revision. Herald added subscribers: s.egerton, mstorsjo, simoncook, dschuff. Herald added a project: All. royjacobson requested review of this revision. Herald added subscribers: cfe-commits, pcwang-thead, sstefan1, aheejin. Herald added a reviewer: jdoerfert. Herald added

[PATCH] D139774: [libclang] Add API to set temporary directory location

aaron.ballman added a comment. In D139774#4079249 , @vedgy wrote: > Now that a consensus has been reached that this revision is to be discarded, > can we please resume the discussion of which alternative should be > implemented in the replacement

[PATCH] D140250: Define NULL in its own header

aaron.ballman added a comment. In D140250#4081009 , @iana wrote: > In D140250#4080990 , @rsmith wrote: > >> Wait a second... if an OS wants only `NULL`, we already have a supported way >> of achieving that,

[clang-tools-extra] 90f7db8 - Fix clang-tools-extra Sphinx build

Author: Aaron Ballman Date: 2023-01-25T15:52:49-05:00 New Revision: 90f7db87936d967998f90c8b430e5243872223b3 URL: https://github.com/llvm/llvm-project/commit/90f7db87936d967998f90c8b430e5243872223b3 DIFF: https://github.com/llvm/llvm-project/commit/90f7db87936d967998f90c8b430e5243872223b3.diff

[PATCH] D141375: [SYCL][OpenMP] Fix compilation errors for unsupported __bf16 intrinsics

eandrews added a comment. Thanks for the reviews! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141375/new/ https://reviews.llvm.org/D141375 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D141375: [SYCL][OpenMP] Fix compilation errors for unsupported __bf16 intrinsics

This revision was automatically updated to reflect the committed changes. Closed by commit rGf81d529f8955: [Clang] Fix compilation errors for unsupported __bf16 intrinsics (authored by eandrews). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] f81d529 - [Clang] Fix compilation errors for unsupported __bf16 intrinsics

Author: Elizabeth Andrews Date: 2023-01-25T12:43:36-08:00 New Revision: f81d529f8955dbdf64d429c27dee994257b4ee99 URL: https://github.com/llvm/llvm-project/commit/f81d529f8955dbdf64d429c27dee994257b4ee99 DIFF:

[PATCH] D141381: [codegen] Store address of indirect arguments on the stack

fdeazeve added a comment. https://reviews.llvm.org/D142160 Should address the incorrect handling of Mem2Reg, this is not the full picture though, as at the MIR level we handle these two differently: DEBUG_VALUE !DIExpression () indirect// this what dbg.declare gets lowered to

[PATCH] D129951: adds `__disable_adl` attribute

cjdb added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:12934-12936 +// else if (!CandidateSet.empty() && CandidateSet.begin()->FoundDecl->hasAttr()) { +// return; +// } This and below need to be deleted. Repository: rG LLVM

[PATCH] D129951: adds `__disable_adl` attribute

cjdb updated this revision to Diff 492234. cjdb retitled this revision from "[clang] teaches Clang the special ADL rules for functions in std::ranges" to "adds `__disable_adl` attribute". cjdb edited the summary of this revision. cjdb added a comment. - updates patch so that it meets what Aaron

[PATCH] D137753: [Clang][AIX][p]Enable -p Functionality

daltenty accepted this revision. daltenty added a comment. This revision is now accepted and ready to land. LGTM, with small nit to address before commit Comment at: clang/lib/Driver/ToolChains/Clang.cpp:6287-6292 if (!TC.getTriple().isOSAIX() &&

[PATCH] D140250: Define NULL in its own header

iana added a comment. In D140250#4080990 , @rsmith wrote: > Wait a second... if an OS wants only `NULL`, we already have a supported way > of achieving that, which is compatible with GCC and glibc and other POSIX > compilers -- define `__need_NULL`

[PATCH] D140250: Define NULL in its own header

rsmith added a comment. Wait a second... if an OS wants only `NULL`, we already have a supported way of achieving that, which is compatible with GCC and glibc and other POSIX compilers -- define `__need_NULL` before including the header. We shouldn't be providing internal headers with

[PATCH] D142577: [clang-doc] Removed unused method in the Info class

paulkirth created this revision. Herald added a project: All. paulkirth requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D142577 Files:

[PATCH] D140250: Define NULL in its own header

aaron.ballman added a comment. Please be sure to add a release note when landing the changes, btw. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140250/new/ https://reviews.llvm.org/D140250 ___

[PATCH] D140250: Define NULL in its own header

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140250/new/ https://reviews.llvm.org/D140250

[PATCH] D142423: [clang-tidy] Fix segfault in bugprone-standalone-empty

This revision was automatically updated to reflect the committed changes. Closed by commit rG716469b6139a: [clang-tidy] Fix segfault in bugprone-standalone-empty (authored by denik, committed by cjdb). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 716469b - [clang-tidy] Fix segfault in bugprone-standalone-empty

Author: Denis Nikitin Date: 2023-01-25T20:06:41Z New Revision: 716469b6139ab5ec5c5b5dac32891300260db8eb URL: https://github.com/llvm/llvm-project/commit/716469b6139ab5ec5c5b5dac32891300260db8eb DIFF: https://github.com/llvm/llvm-project/commit/716469b6139ab5ec5c5b5dac32891300260db8eb.diff

[PATCH] D142569: [WIP][OpenMP] Introduce kernel argument

jdoerfert added a comment. Link the old review too. Pre-commit, w/o review, the file rename and include changes. Comment at: llvm/lib/Transforms/IPO/OpenMPOpt.cpp:246 + GET_KERNEL_ENVIRONMENT_MEMBER(Configuration, DL, StructC)), \ + V)) +

[PATCH] D135495: [clang-tidy] handle exceptions properly `ExceptionAnalyzer`

isuckatcs updated this revision to Diff 492215. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135495/new/ https://reviews.llvm.org/D135495 Files: clang-tools-extra/clang-tidy/utils/ExceptionAnalyzer.cpp clang-tools-extra/clang-tidy/utils/ExceptionAnalyzer.h

[PATCH] D135495: [clang-tidy] handle exceptions properly `ExceptionAnalyzer`

isuckatcs updated this revision to Diff 492214. isuckatcs added a comment. applied clang-format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135495/new/ https://reviews.llvm.org/D135495 Files: clang-tools-extra/clang-tidy/utils/ExceptionAnalyzer.cpp

[PATCH] D142570: [nvptx-arch] Remove `find_package(CUDA)` as it has been deprecated.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG759dec253695: [nvptx-arch] Remove `find_package(CUDA)` as it has been deprecated. (authored by jhuber6). Repository: rG LLVM Github Monorepo

  1   2   3   >