[PATCH] D136886: [clang] ASTImporter: Fix importing of va_list types and declarations

balazske added a comment. The "Declaration not emitted" crash is reproducible by change of file "test/Index/targeted-cursor.c", the similar lines should be replaced to this (only the `target aarch64` is added): // RUN: env CINDEXTEST_FAILONERROR=1 CINDEXTEST_EDITING=1

[clang] 7b966e2 - [clang][Interp][NFC] Add GetPtrBasePop opcode

Author: Timm Bäder Date: 2023-01-27T08:05:53+01:00 New Revision: 7b966e2156b8b461a29a49122286f804a30236e9 URL: https://github.com/llvm/llvm-project/commit/7b966e2156b8b461a29a49122286f804a30236e9 DIFF: https://github.com/llvm/llvm-project/commit/7b966e2156b8b461a29a49122286f804a30236e9.diff

[PATCH] D142655: [WIP][clang-tidy] Introduce HeaderFileExtensions and ImplementationFileExtensions options

carlosgalvezp added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyOptions.cpp:149 + Options.HeaderFileExtensions = {"", "h", "hh", "hpp", "hxx"}; + Options.ImplementationFileExtensions = {"c", "cc", "cpp", "cxx"}; Options.HeaderFilterRegex = "";

[PATCH] D139926: [clangd] Add semantic token for angle brackets

nridge added a comment. In D139926#4076652 , @ckandeler wrote: > Thanks for the test cases! > All fixed, except: > >> // variable template specialization >> // parameter and argument lists are missing semantic tokens >> template <> >> constexpr int V =

[PATCH] D136886: [clang] ASTImporter: Fix importing of va_list types and declarations

balazske added a comment. In my previous comments I indicated how to fix the problem in the lang-tidy check, and I could reproduce the crash in `ImportCorrectTemplatedDecl` and have the fix for it. I can reproduce the assertion "Declaration not emitted!" but did not found the fix, the AST

[PATCH] D142692: [clang] Store the template param list of an explicit variable template specialization

nridge added a comment. So far the only test I added is in clangd semantic highlighting because that's how I noticed the `template<>` missing from the AST, but I'm open to suggestions on where to add a test at the clang layer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D142692: [clang] Store the template param list of an explicit variable template specialization

nridge created this revision. nridge added reviewers: rsmith, mizvekov. Herald added subscribers: kadircet, arphaman. Herald added a project: All. nridge requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a subscriber: cfe-commits.

[PATCH] D142690: [DRAFT][libc++] Fixes the Clang modular build.

Mordante updated this revision to Diff 492648. Mordante added a comment. Herald added a subscriber: arichardson. Fix CI run instead of libc++. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142690/new/ https://reviews.llvm.org/D142690 Files:

[PATCH] D142690: [DRAFT][libc++] Fixes the Clang modular build.

Mordante added inline comments. Comment at: libcxx/include/module.modulemap.in:1421 + private header "__type_traits/integral_constant.h" + export type_traits.common_reference +} Note this looks wrong from libc++'s perspective. When this "solves"

[PATCH] D141193: [clang][Interp] Implement __builtin_assume

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG760136ff13ba: [clang][Interp] Implement __builtin_assume (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 760136f - [clang][Interp] Implement __builtin_assume

Author: Timm Bäder Date: 2023-01-27T07:54:37+01:00 New Revision: 760136ff13ba172787c3367664fe9f3f7b3b64ef URL: https://github.com/llvm/llvm-project/commit/760136ff13ba172787c3367664fe9f3f7b3b64ef DIFF: https://github.com/llvm/llvm-project/commit/760136ff13ba172787c3367664fe9f3f7b3b64ef.diff

[PATCH] D142690: [DRAFT][libc++] Fixes the Clang modular build.

Mordante created this revision. Herald added a project: All. Mordante requested review of this revision. Herald added projects: clang, libc++. Herald added subscribers: libcxx-commits, cfe-commits. Herald added a reviewer: libc++. This attempts to fix the issue introduced in 12cb1cb3720d

[PATCH] D142688: [Clang][Driver] Handle LoongArch multiarch tuples

xen0n created this revision. xen0n added reviewers: SixWeining, wangleiat, MaskRay, xry111. Herald added a project: All. xen0n requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This follows v1.00 of the LoongArch Toolchain Conventions

[PATCH] D141192: [Clang] Fix warnings on bad shifts.

chestnykh added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141192/new/ https://reviews.llvm.org/D141192 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D139454: [CMake] Replace clang binary if using clang-bolt target

Amir updated this revision to Diff 492638. Amir added a comment. Use generator expression, put clang-bolt temp binary to CMAKE_CURRENT_BINARY_DIR Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139454/new/ https://reviews.llvm.org/D139454 Files:

[PATCH] D142604: [Clang] Fix __VA_OPT__ implementation so that it treats the concatenation of a non-placemaker token and placemaker token as a non-placemaker token

shafik added a comment. It looks like the modules test failures are unrelated and are failing all the recent modules builds. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142604/new/ https://reviews.llvm.org/D142604 ___ cfe-commits mailing

[PATCH] D142123: [clang-tidy] Add header guard style to suggest use of #pragma once

KyleFromKitware updated this revision to Diff 492634. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142123/new/ https://reviews.llvm.org/D142123 Files: clang-tools-extra/clang-tidy/readability/CMakeLists.txt clang-tools-extra/clang-tidy/readability/PragmaOnceHeaderGuardStyle.cpp

[PATCH] D142673: [clang-tidy] Refactor HeaderGuardCheck to add HeaderGuardStyle

KyleFromKitware updated this revision to Diff 492633. KyleFromKitware changed the edit policy from "All Users" to "Only User: KyleFromKitware (Kyle Edwards)". CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142673/new/ https://reviews.llvm.org/D142673 Files:

[PATCH] D142014: [clangd] fix wrong CalleeArgInfo in the hover

v1nh1shungry added a comment. In D142014#4084263 , @nridge wrote: > In D142014#4081922 , @v1nh1shungry > wrote: > >> I just came up with a case where the original implementation and this patch >> behave

[PATCH] D142560: Allow getRawCommentForDecl to find comments in macros

Jake-Egan added a comment. Thank you for looking into the failure. Fortunately the test is passing on the AIX bot now and locally for me - it looks like a clean build fixed it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142560/new/

[PATCH] D141827: [clang][TypePrinter] Test TemplateArgument::IsDefaulted when omitting default arguments

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3d7dcec5db2f: [clang][TypePrinter] Test TemplateArgument::IsDefaulted when omitting default… (authored by Michael137). Repository: rG LLVM Github

[PATCH] D142333: [clang][DebugInfo] Check TemplateArgument::IsDefaulted

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG29ecf0e62cd7: [clang][DebugInfo] Check TemplateArgument::IsDefaulted (authored by Michael137). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D141826: [clang][TemplateBase] Add IsDefaulted bit to TemplateArgument

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8b4279b66fc2: [clang][TemplateBase] Add IsDefaulted bit to TemplateArgument (authored by Michael137). Repository: rG LLVM Github Monorepo

[clang] 29ecf0e - [clang][DebugInfo] Check TemplateArgument::IsDefaulted

Author: Michael Buch Date: 2023-01-27T02:24:34Z New Revision: 29ecf0e62cd7899dee84732a31875179ec4d5a80 URL: https://github.com/llvm/llvm-project/commit/29ecf0e62cd7899dee84732a31875179ec4d5a80 DIFF: https://github.com/llvm/llvm-project/commit/29ecf0e62cd7899dee84732a31875179ec4d5a80.diff LOG:

[PATCH] D142632: [clang][TypePrinter] Support expression template arguments when checking defaultedness

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG798494ed4f11: [clang][TypePrinter] Support expression template arguments when checking… (authored by Michael137). Repository: rG LLVM Github

[clang] 3d7dcec - [clang][TypePrinter] Test TemplateArgument::IsDefaulted when omitting default arguments

Author: Michael Buch Date: 2023-01-27T02:24:33Z New Revision: 3d7dcec5db2f86bd8b9142d180716725a8fc0b0f URL: https://github.com/llvm/llvm-project/commit/3d7dcec5db2f86bd8b9142d180716725a8fc0b0f DIFF: https://github.com/llvm/llvm-project/commit/3d7dcec5db2f86bd8b9142d180716725a8fc0b0f.diff LOG:

[clang] 8b4279b - [clang][TemplateBase] Add IsDefaulted bit to TemplateArgument

Author: Michael Buch Date: 2023-01-27T02:24:33Z New Revision: 8b4279b66fc2f535184642b739b573ead1733711 URL: https://github.com/llvm/llvm-project/commit/8b4279b66fc2f535184642b739b573ead1733711 DIFF: https://github.com/llvm/llvm-project/commit/8b4279b66fc2f535184642b739b573ead1733711.diff LOG:

[clang] 798494e - [clang][TypePrinter] Support expression template arguments when checking defaultedness

Author: Michael Buch Date: 2023-01-27T02:24:32Z New Revision: 798494ed4f112bf64dcabbe8b60becb42b23208f URL: https://github.com/llvm/llvm-project/commit/798494ed4f112bf64dcabbe8b60becb42b23208f DIFF: https://github.com/llvm/llvm-project/commit/798494ed4f112bf64dcabbe8b60becb42b23208f.diff LOG:

[PATCH] D136886: [clang] ASTImporter: Fix importing of va_list types and declarations

jrtc27 added a comment. In D136886#4083762 , @vabridgers wrote: > It appears to me this change https://reviews.llvm.org/D116774 is responsible > for the unexpected behavior. Question for @jrtc27 : do you think if we could > make this change consistent

[PATCH] D136886: [clang] ASTImporter: Fix importing of va_list types and declarations

vabridgers added a comment. I've made a very simple reproducer for this crash, clang-tidy executes on an x86 machine. Requires aarch64 and/or arm support compiled in. crashes - clang-tidy crash.cpp -checks="cert-dcl58-cpp" -- -target arm crashes - clang-tidy crash.cpp -checks="cert-dcl58-cpp"

[PATCH] D142139: [clang-format] Disallow templates to be followed by literal

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8a3de13573bd: [clang-format] Disallow templates to be followed by literal (authored by rymiel). Repository: rG LLVM Github Monorepo CHANGES

[clang] 8a3de13 - [clang-format] Disallow templates to be followed by literal

Author: Emilia Dreamer Date: 2023-01-27T04:01:11+02:00 New Revision: 8a3de13573bdeaee13ec959fa2af0d11f21f5f00 URL: https://github.com/llvm/llvm-project/commit/8a3de13573bdeaee13ec959fa2af0d11f21f5f00 DIFF:

[PATCH] D142578: [Clang][Doc] Edit the Clang release notes

rymiel added a comment. I think it's worthwhile to mark comments with the "Done" checkmark in Phrabricator if they have been addressed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142578/new/ https://reviews.llvm.org/D142578

[PATCH] D142592: [clang-tidy][libc] Add an inline function checker for the libc project.

sivachandra added inline comments. Comment at: clang-tools-extra/clang-tidy/llvmlibc/InlineFunctionDeclCheck.cpp:20 +void InlineFunctionDeclCheck::registerMatchers(MatchFinder *Finder) { + Finder->addMatcher(decl(functionDecl()).bind("func_decl"), this); +}

[PATCH] D142592: [clang-tidy][libc] Add an inline function checker for the libc project.

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:104 +Checks that all implicit and explicit inline functions in header files are +tagged with the ``LIBC_INLINE`` macro. See the `libc style guide +`_

[PATCH] D142592: [clang-tidy][libc] Add an inline function checker for the libc project.

sivachandra updated this revision to Diff 492597. sivachandra added a comment. Update release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142592/new/ https://reviews.llvm.org/D142592 Files:

[PATCH] D142592: [clang-tidy][libc] Add an inline function checker for the libc project.

sivachandra updated this revision to Diff 492596. sivachandra added a comment. Use the HeaderFileExtensions pattern to match constructs in header files. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142592/new/ https://reviews.llvm.org/D142592

[PATCH] D142675: [clang][CGDebugInfo] emit DW_LANG_C_plus_plus_{20|17} DW_LANG_C17

dblaikie added a comment. This was discussed in D138597 & we decided not to implement these due to the risk of breaking existing v5 clients that might not know about the post-v5-release codes. Implementing the v6 codes as an extension might be an option, or

[PATCH] D142014: [clangd] fix wrong CalleeArgInfo in the hover

nridge added a comment. In D142014#4081922 , @v1nh1shungry wrote: > I just came up with a case where the original implementation and this patch > behave differently. > > void foobar(const float &); > int main() { > foobar(0); >^ >

[PATCH] D142675: [clang][CGDebugInfo] emit DW_LANG_C_plus_plus_{20|17} DW_LANG_C17

nickdesaulniers created this revision. nickdesaulniers added reviewers: dblaikie, jcranmer-intel. Herald added a project: All. nickdesaulniers requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Looks like these DW_AT_language tags made it

[PATCH] D142637: A slightly more concise AST dump :)

sammccall added inline comments. Comment at: clang/test/AST/ast-dump-attr-type.cpp:12 +// CHECK-NEXT:`-BuiltinType 0x{{[^ ]*}} 'int' +// CHECK-NOT: `-PointerType 0x564c31a07520 'int *' gribozavr2 wrote: > sammccall wrote: > > Can you add a second

[PATCH] D142604: [Clang] Fix __VA_OPT__ implementation so that it treats the concatenation of a non-placemaker token and placemaker token as a non-placemaker token

shafik updated this revision to Diff 492589. shafik added a comment. - Apply clang-format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142604/new/ https://reviews.llvm.org/D142604 Files: clang/lib/Lex/TokenLexer.cpp clang/test/Preprocessor/macro_vaopt_p1042r1.cpp Index:

Re: [clang] 9dc4af3 - Re-land "[clang] Add early exit when checking for const init of arrays."

This change doesn't look correct to me. It's possible to observe an array during its own initialization, and if that happens, the array needs to be filled with the array filler up to its declared length. It's not beautiful, but here's a testcase that was broken by this change:

[PATCH] D142421: [Sanitizers] fix -fno-sanitize-link-runtime for darwin

rsundahl accepted this revision. rsundahl added a comment. LGTM as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142421/new/ https://reviews.llvm.org/D142421 ___ cfe-commits mailing list

[PATCH] D142421: [Sanitizers] fix -fno-sanitize-link-runtime for darwin

thetruestblue accepted this revision. thetruestblue added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142421/new/ https://reviews.llvm.org/D142421 ___ cfe-commits mailing list

[PATCH] D142421: [Sanitizers] fix -fno-sanitize-link-runtime for darwin

yln added a comment. Looks harmless enough, even though I am not sure why we have a completely separate code path on Darwin. The other toolchain driver seem to have shared code for this in `clang/lib/Driver/ToolChains/CommonArgs.cpp`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D142637: A slightly more concise AST dump :)

gribozavr2 added inline comments. Comment at: clang/test/AST/ast-dump-attr-type.cpp:12 +// CHECK-NEXT:`-BuiltinType 0x{{[^ ]*}} 'int' +// CHECK-NOT: `-PointerType 0x564c31a07520 'int *' sammccall wrote: > Can you add a second example where the

[PATCH] D133574: [C2x] reject type definitions in offsetof

stilor added a comment. In D133574#4083742 , @aaron.ballman wrote: > In D133574#4083724 , @asbirlea > wrote: > >> Following this change, the following emits warnings: >> https://godbolt.org/z/cvGdMWqEa,

[PATCH] D127910: [Clang][AArch64][SME] Add vector load/store (ld1/st1) intrinsics

bryanpkc updated this revision to Diff 492586. bryanpkc added a comment. Minor clean-up. Sorry for the noise. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127910/new/ https://reviews.llvm.org/D127910 Files:

[PATCH] D140730: 59559 Explain code coverage with Lit in docs/SourceBasedCodeCoverage.rst

FlashSheridan added a comment. Per https://llvm.org/docs/Phabricator.html#committing-a-change, I cannot commit the patch myself. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140730/new/ https://reviews.llvm.org/D140730

[PATCH] D127910: [Clang][AArch64][SME] Add vector load/store (ld1/st1) intrinsics

bryanpkc updated this revision to Diff 492585. bryanpkc retitled this revision from "[Clang][AArch64] Add SME C intrinsics for load and store" to "[Clang][AArch64][SME] Add vector load/store (ld1/st1) intrinsics". bryanpkc edited the summary of this revision. bryanpkc added a comment. Updated

[PATCH] D140489: Add builtin_elementwise_log

bob80905 updated this revision to Diff 492581. bob80905 added a comment. remove unrelated commit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140489/new/ https://reviews.llvm.org/D140489 Files: clang/docs/LanguageExtensions.rst

[PATCH] D142606: Lazyly initialize uncommon toolchain detector

zero9178 added inline comments. Comment at: clang/lib/Driver/ToolChains/LazyDetector.h:26 + + mutable std::optional Detector; + Any reason this is `mutable`? I don't see it being used a non-const way in a const method Repository: rG LLVM Github Monorepo

[PATCH] D140489: Add builtin_elementwise_log

NoQ added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:248 if (const auto *VD = dyn_cast(D)) { -assert(Defs.count(VD) == 0 && "Definition already discovered!"); +// FIXME: Assertion temporarily disabled due to a bug in +//

[PATCH] D142121: [clang-tidy] Refactor common functionality of HeaderGuardCheck into HeaderGuardBase

KyleFromKitware abandoned this revision. KyleFromKitware added a comment. Closed in favor of D142673 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142121/new/ https://reviews.llvm.org/D142121

[PATCH] D142123: [clang-tidy] Add header guard style to suggest use of #pragma once

KyleFromKitware updated this revision to Diff 492579. KyleFromKitware retitled this revision from "[clang-tidy] Add check to suggest use of #pragma once" to "[clang-tidy] Add header guard style to suggest use of #pragma once". KyleFromKitware added a comment. Refactored to use HeaderGuardStyle.

[PATCH] D142673: [clang-tidy] Refactor HeaderGuardCheck to add HeaderGuardStyle

KyleFromKitware created this revision. KyleFromKitware added a reviewer: clang-tools-extra. KyleFromKitware added a project: clang-tools-extra. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a reviewer: sscalpone. Herald added a reviewer: njames93. Herald added a project: All.

[PATCH] D142471: [pp-trace] Add PragmaOnce callback

KyleFromKitware updated this revision to Diff 492577. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142471/new/ https://reviews.llvm.org/D142471 Files: clang-tools-extra/pp-trace/PPCallbacksTracker.cpp clang-tools-extra/pp-trace/PPCallbacksTracker.h

[PATCH] D142470: [clang][lex] Add PragmaOnce callback to PPCallbacks

KyleFromKitware updated this revision to Diff 492576. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142470/new/ https://reviews.llvm.org/D142470 Files: clang/include/clang/Lex/PPCallbacks.h clang/include/clang/Lex/Preprocessor.h clang/lib/Lex/Pragma.cpp Index:

[PATCH] D142030: [pp-trace] Print HashLoc/Introducer parameter

KyleFromKitware updated this revision to Diff 492575. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142030/new/ https://reviews.llvm.org/D142030 Files: clang-tools-extra/docs/pp-trace.rst clang-tools-extra/pp-trace/PPCallbacksTracker.cpp

[PATCH] D142606: Lazyly initialize uncommon toolchain detector

tstellar added a comment. In D142606#4082783 , @serge-sans-paille wrote: > In D142606#4082753 , @tstellar > wrote: > >> Does this mean that clang will no longer search for the ROCM and CUDA >> library paths

[PATCH] D142465: [clang][lex] Consolidate PPCallbacks::PragmaDirective parameters

KyleFromKitware updated this revision to Diff 492573. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142465/new/ https://reviews.llvm.org/D142465 Files: clang-tools-extra/clang-tidy/ExpandModularHeadersPPCallbacks.cpp clang-tools-extra/clang-tidy/ExpandModularHeadersPPCallbacks.h

[PATCH] D141705: [HLSL] [Dirver] add dxv as a Driver Action Job

jhuber6 added inline comments. Comment at: clang/lib/Driver/Driver.cpp:4216 + llvm::Triple T(getTargetTriple()); + if (T.getArch() == llvm::Triple::dxil && !Args.getLastArg(options::OPT_dxc_disable_validation)) { +// Only add action when 'dxv' exists.

[PATCH] D140489: Add builtin_elementwise_log

bob80905 added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140489/new/ https://reviews.llvm.org/D140489 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D142584: [CodeGen] Add a boolean flag to `Address::getPointer` and `Lvalue::getPointer` that indicates whether the pointer is known not to be null

rjmccall added inline comments. Comment at: clang/lib/CodeGen/Address.h:97 + llvm::Value * + getPointer(KnownNonNull_t KnownNonNull = KnownNonNull_t::False) const { assert(isValid()); ahatanak wrote: > rjmccall wrote: > > Apologies if this rehashes a

[PATCH] D142604: [Clang] Fix __VA_OPT__ implementation so that it treats the concatenation of a non-placemaker token and placemaker token as a non-placemaker token

shafik added inline comments. Comment at: clang/test/Preprocessor/macro_vaopt_p1042r1.cpp:1 - RUN: %clang_cc1 -E %s -pedantic -std=c++2a | FileCheck -strict-whitespace %s - I removed Windows lines ending from this test, I don't think they matter but if someone

[PATCH] D142604: [Clang] Fix __VA_OPT__ implementation so that it treats the concatenation of a non-placemaker token and placemaker token as a non-placemaker token

shafik updated this revision to Diff 492562. shafik added a comment. - I think I correctly updated line endings this time CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142604/new/ https://reviews.llvm.org/D142604 Files: clang/lib/Lex/TokenLexer.cpp

[PATCH] D141705: [HLSL] [Dirver] add dxv as a Driver Action Job

python3kgae marked 2 inline comments as done. python3kgae added a comment. In D141705#4082935 , @jhuber6 wrote: > I'm not overly familiar with HLSL or DirectX here. Most of the changes are > purely mechanical, but I don't see anywhere we create the

[PATCH] D142604: [Clang] Fix __VA_OPT__ implementation so that it treats the concatenation of a non-placemaker token and placemaker token as a non-placemaker token

shafik updated this revision to Diff 492560. shafik added a comment. - Update line ending in test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142604/new/ https://reviews.llvm.org/D142604 Files: clang/lib/Lex/TokenLexer.cpp clang/test/Preprocessor/macro_vaopt_p1042r1.cpp Index:

[PATCH] D142655: [WIP][clang-tidy] Introduce HeaderFileExtensions and ImplementationFileExtensions options

ClockMan added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyOptions.cpp:149 + Options.HeaderFileExtensions = {"", "h", "hh", "hpp", "hxx"}; + Options.ImplementationFileExtensions = {"c", "cc", "cpp", "cxx"}; Options.HeaderFilterRegex = "";

[PATCH] D141705: [HLSL] [Dirver] add dxv as a Driver Action Job

python3kgae updated this revision to Diff 492559. python3kgae marked an inline comment as done. python3kgae added a comment. Only create dxv job when 'dxv' exist. Test ccc-print-bindings. Code cleanup. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] c10615e - [SYCL] Fix test to conform to SYCL2020

Author: Elizabeth Andrews Date: 2023-01-26T13:52:48-08:00 New Revision: c10615e4a94fc8dec65a48a6eb8f7efccc3fb1fc URL: https://github.com/llvm/llvm-project/commit/c10615e4a94fc8dec65a48a6eb8f7efccc3fb1fc DIFF:

[PATCH] D142639: [clang] Warn by default that implicit capture of 'this' is deprecated in C++20 and later.

shafik accepted this revision. shafik added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142639/new/ https://reviews.llvm.org/D142639 ___ cfe-commits mailing list

[PATCH] D142655: [WIP][clang-tidy] Introduce HeaderFileExtensions and ImplementationFileExtensions options

carlosgalvezp added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.h:233-234 + utils::FileExtensionsSet HeaderFileExtensions; + utils::FileExtensionsSet ImplementationFileExtensions; + @njames93 Would appreciate

[PATCH] D142655: [WIP][clang-tidy] Introduce HeaderFileExtensions and ImplementationFileExtensions options

carlosgalvezp updated this revision to Diff 492555. carlosgalvezp added a comment. Add functions to ClangTidyCheck so checks can get access to them. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142655/new/ https://reviews.llvm.org/D142655 Files:

[PATCH] D142316: [clang] Add test for CWG2396

shafik added inline comments. Comment at: clang/test/CXX/drs/dr23xx.cpp:202 + // void g2(A a) { a.operator B decltype(B())::*(); } + // void h(A a) { a.operator identity::type B::*(); } + // void h2(A a) { a.operator B identity::type::*(); } While gcc

[clang] ca44603 - [OpenMP][OMPIRBuilder]Move SIMD alignment calculation to LLVM Frontend

Author: Dominik Adamski Date: 2023-01-26T15:10:19-06:00 New Revision: ca446037af019d1aa01b1352a30a18df33038359 URL: https://github.com/llvm/llvm-project/commit/ca446037af019d1aa01b1352a30a18df33038359 DIFF:

[PATCH] D141910: [OpenMP][OMPIRBuilder]Move SIMD alignment calculation to LLVM Frontend

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGca446037af01: [OpenMP][OMPIRBuilder]Move SIMD alignment calculation to LLVM Frontend (authored by domada). Repository: rG LLVM Github Monorepo

[clang] f983987 - [LinkerWrapper] Fix `-Bsymbolic` being sent to the compiler and not the linker

Author: Joseph Huber Date: 2023-01-26T15:05:10-06:00 New Revision: f9839876574fe97fdcdf104fbb1c9ba7fd4f9433 URL: https://github.com/llvm/llvm-project/commit/f9839876574fe97fdcdf104fbb1c9ba7fd4f9433 DIFF: https://github.com/llvm/llvm-project/commit/f9839876574fe97fdcdf104fbb1c9ba7fd4f9433.diff

[PATCH] D140179: [-Wunsafe-buffer-usage] Add unsafe buffer checking opt-out pragmas

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Ok I think I'm happy with the patch! Let's give other folks a few days to comment and then land? The commit message will need to be updated to remove mentions of `DiagnosticsEngine`. I'm somewhat

[PATCH] D142560: Allow getRawCommentForDecl to find comments in macros

danakj added a comment. I tried modifying the test to pass an AIX target, running on Linux: // RUN: %clang_cc1 -triple powerpc64-ibm-aix -emit-pch -o %t/out.pch -F %S/Inputs/Frameworks %s // RUN: %clang_cc1 -triple powerpc64-ibm-aix -include-pch %t/out.pch -F %S/Inputs/Frameworks

[PATCH] D131141: [RISCV] Add MC support of RISCV Zcb Extension

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG42c36da9c99b: [RISCV] Add MC support of RISCV Zcb Extension (authored by VincentWu, committed by craig.topper). Repository: rG LLVM Github

[clang] 42c36da - [RISCV] Add MC support of RISCV Zcb Extension

Author: WuXinlong Date: 2023-01-26T12:54:00-08:00 New Revision: 42c36da9c99b84ca7bc843a27ff0da29f5bf8a74 URL: https://github.com/llvm/llvm-project/commit/42c36da9c99b84ca7bc843a27ff0da29f5bf8a74 DIFF: https://github.com/llvm/llvm-project/commit/42c36da9c99b84ca7bc843a27ff0da29f5bf8a74.diff

[PATCH] D142584: [CodeGen] Add a boolean flag to `Address::getPointer` and `Lvalue::getPointer` that indicates whether the pointer is known not to be null

ahatanak added inline comments. Comment at: clang/lib/CodeGen/Address.h:97 + llvm::Value * + getPointer(KnownNonNull_t KnownNonNull = KnownNonNull_t::False) const { assert(isValid()); rjmccall wrote: > Apologies if this rehashes a conversation we had

[PATCH] D136886: [clang] ASTImporter: Fix importing of va_list types and declarations

vabridgers added a comment. @balazske , could you please share how to repro this problem on an x86 machine? Thank you Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136886/new/ https://reviews.llvm.org/D136886

[PATCH] D136886: [clang] ASTImporter: Fix importing of va_list types and declarations

vabridgers added a comment. It appears to me this change https://reviews.llvm.org/D116774 is responsible for the unexpected behavior. Question for @jrtc27 : do you think if we could make this change consistent with https://reviews.llvm.org/D116774 that the problem would be addressed? Looks

[PATCH] D133574: [C2x] reject type definitions in offsetof

erichkeane added a comment. In D133574#4083724 , @asbirlea wrote: > Following this change, the following emits warnings: > https://godbolt.org/z/cvGdMWqEa, https://godbolt.org/z/GhTP85WzE > > Can you please fix fwd or revert until resolved? Those both

[PATCH] D133574: [C2x] reject type definitions in offsetof

aaron.ballman added a comment. In D133574#4083724 , @asbirlea wrote: > Following this change, the following emits warnings: > https://godbolt.org/z/cvGdMWqEa, https://godbolt.org/z/GhTP85WzE > > Can you please fix fwd or revert until resolved? What do

[PATCH] D133574: [C2x] reject type definitions in offsetof

asbirlea added a comment. Following this change, the following emits warnings: https://godbolt.org/z/cvGdMWqEa, https://godbolt.org/z/GhTP85WzE Can you please fix fwd or revert until resolved? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D142560: Allow getRawCommentForDecl to find comments in macros

danakj added a comment. I am not sure how to debug further for AIX, do you have any suggestion? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142560/new/ https://reviews.llvm.org/D142560 ___ cfe-commits

[PATCH] D142650: [OpenMP] Run an extra 'OpenMPOpt' pass in LTO-mode

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6185246f4f62: [OpenMP] Run an extra OpenMPOpt pass in LTO-mode (authored by jhuber6). Changed prior to commit:

[clang] 6185246 - [OpenMP] Run an extra 'OpenMPOpt' pass in LTO-mode

Author: Joseph Huber Date: 2023-01-26T13:23:45-06:00 New Revision: 6185246f4f62345d0cfdaef62da7e15b01d52557 URL: https://github.com/llvm/llvm-project/commit/6185246f4f62345d0cfdaef62da7e15b01d52557 DIFF: https://github.com/llvm/llvm-project/commit/6185246f4f62345d0cfdaef62da7e15b01d52557.diff

[PATCH] D142560: Allow getRawCommentForDecl to find comments in macros

danakj added a comment. Here's the relevant part of the test: #define DECLARE_ENUMS(name) \ /** enumFromMacro IS_DOXYGEN_SINGLE */ \ enum enumFromMacro { A }; \ /** namedEnumFromMacro IS_DOXYGEN_SINGLE */ \ enum name { B }; /// IS_DOXYGEN_NOT_ATTACHED

[PATCH] D142583: [SPIR] Add support for __arithmetic_fence builtin for SPIR target.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb4b06d8ff826: __arithmetic_fence enforces ordering on expression evaluation when fast-math (authored by zahiraam). Repository: rG LLVM Github

[clang] b4b06d8 - __arithmetic_fence enforces ordering on expression evaluation when fast-math

Author: Zahira Ammarguellat Date: 2023-01-26T14:18:28-05:00 New Revision: b4b06d8ff82647824a658356e1e8f7dc9d1ac7d2 URL: https://github.com/llvm/llvm-project/commit/b4b06d8ff82647824a658356e1e8f7dc9d1ac7d2 DIFF:

[clang] 42e371b - [NFC][Concepts] Change the Source Range of Concepts ParamMatching

Author: Erich Keane Date: 2023-01-26T11:14:40-08:00 New Revision: 42e371b174d4407ec5805010c2ecfef9c086b5c2 URL: https://github.com/llvm/llvm-project/commit/42e371b174d4407ec5805010c2ecfef9c086b5c2 DIFF: https://github.com/llvm/llvm-project/commit/42e371b174d4407ec5805010c2ecfef9c086b5c2.diff

[PATCH] D142655: [WIP][clang-tidy] Introduce HeaderFileExtensions and ImplementationFileExtensions options

carlosgalvezp updated this revision to Diff 492526. carlosgalvezp retitled this revision from "[clang-tidy] Introduce HeaderFileExtensions and ImplementationFileExtensions options" to "[WIP][clang-tidy] Introduce HeaderFileExtensions and ImplementationFileExtensions options". carlosgalvezp

[PATCH] D142655: [clang-tidy] Introduce HeaderFileExtensions and ImplementationFileExtensions options

carlosgalvezp created this revision. Herald added a subscriber: xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. carlosgalvezp requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Re-introduce it, now with

[PATCH] D142650: [OpenMP] Run an extra 'OpenMPOpt' pass in LTO-mode

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG, one nit. Comment at: llvm/lib/Passes/PassBuilderPipelines.cpp:1720 + MPM.addPass(OpenMPOptPass(ThinOrFullLTOPhase::FullLTOPostLink)); + // If we didn't decide

[PATCH] D142632: [clang][TypePrinter] Support expression template arguments when checking defaultedness

Michael137 added inline comments. Comment at: clang/lib/AST/TypePrinter.cpp:2019 + // Can't evaluate value-dependent expressions so bail early + Expr const *pattern_expr = Pattern.getAsExpr(); + if (pattern_expr->isValueDependent() || aprantl wrote: > I

  1   2   3   >