[PATCH] D142800: [Clang][Diagnostic] Add `-Wcomparison-op-parentheses` to warn on chained comparisons

hazohelet created this revision. hazohelet added reviewers: dblaikie, aaron.ballman, erichkeane. Herald added a project: All. hazohelet requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. Herald added a project: clang. This patch introduces

[PATCH] D142799: [Clang] Fix unconditional access to Attr pointer when checking if _Nullable is applicable to a type

shafik created this revision. shafik added reviewers: aaron.ballman, erichkeane. Herald added a project: All. shafik requested review of this revision. In `TransformAttributedType(...)` when checking if `_Nullable` can be applied to a type it dereferences `TL.getAttr()` unconditionally which we

[PATCH] D141133: [clang-tidy] Implement CppCoreGuideline F.54

ccotter updated this revision to Diff 492981. ccotter added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141133/new/ https://reviews.llvm.org/D141133 Files:

[PATCH] D14484: [clang-format] Formatting constructor initializer lists by putting them always on different lines

owenpan added a comment. In D14484#4079711 , @HantaoPan wrote: > Hi, > I am interesting in this feature too. You know, consistency is crucial to a > large program... > > regards, As mentioned above, it has been added in D108752

[PATCH] D141959: [clang-format] Fix inconsistent identification of operator

owenpan added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:2488-2490 +(NextToken && NextToken->Tok.isAnyIdentifier()) && +(NextToken->getNextNonComment() && + (NextToken->getNextNonComment()->isOneOf( dkt01 wrote: >

[PATCH] D139737: [-Wunsafe-buffer-usage] Initiate Fix-it generation for local variable declarations

jkorous added a comment. I am sorry I haven't notice this earlier - let's fix this before we land the patch. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:690 + Val.toString(Txt, 10, true); + return Txt.data(); +} We either need a zero to terminate

[clang] 00ecf3f - Added a note that "%p" is also a Lit token and needs to be escaped.

Author: Flash Sheridan Date: 2023-01-27T17:57:59-08:00 New Revision: 00ecf3f339624dc8b44737a2347076382de3720f URL: https://github.com/llvm/llvm-project/commit/00ecf3f339624dc8b44737a2347076382de3720f DIFF:

[PATCH] D140730: 59559 Explain code coverage with Lit in docs/SourceBasedCodeCoverage.rst

This revision was automatically updated to reflect the committed changes. Closed by commit rG01f13f487775: Explain code coverage with Lit in docs/SourceBasedCodeCoverage.rst (authored by FlashSheridan, committed by gkistanova). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 01f13f4 - Explain code coverage with Lit in docs/SourceBasedCodeCoverage.rst

Author: Flash Sheridan Date: 2023-01-27T17:51:18-08:00 New Revision: 01f13f4877751e6d5aa6f07984ebd76f67047839 URL: https://github.com/llvm/llvm-project/commit/01f13f4877751e6d5aa6f07984ebd76f67047839 DIFF:

[PATCH] D139737: [-Wunsafe-buffer-usage] Initiate Fix-it generation for local variable declarations

NoQ added a comment. Thank you!! I think we're almost ready to commit but this concern is still hanging: > I see that the patch doesn't touch `handleFixableVariable()`. Do we still > attach fixits to the warning, or did we already change it to be attached to a > note associated with the

[PATCH] D142704: [C++20][Modules] Handle template declarations in header units.

rsmith added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:15265 FD->getFormalLinkage() == Linkage::ExternalLinkage && - !FD->isInvalidDecl() && BodyKind != FnBodyKind::Delete && + !FD->isInvalidDecl() && !IsFnTemplate && BodyKind !=

[PATCH] D141705: [HLSL] [Dirver] add dxv as a Driver Action Job

python3kgae marked an inline comment as done. python3kgae added inline comments. Comment at: clang/test/Driver/dxc_dxv_path.hlsl:7 +// RUN: echo "dxv" > %T/dxv && chmod 754 %T/dxv && %clang_dxc --dxv-path=%T %s -Tlib_6_3 -### 2>&1 | FileCheck %s --check-prefix=DXV_PATH +//

[PATCH] D123534: [dwarf] Emit a DIGlobalVariable for constant strings.

tra added a comment. This patch appears to break CUDA compilation: https://github.com/llvm/llvm-project/issues/58491 We apparently emit the symbol with a character (`.`) that can't be used on the target. Normally such characters get renamed/escaped, as you can see in the generated function

[PATCH] D141705: [HLSL] [Dirver] add dxv as a Driver Action Job

python3kgae updated this revision to Diff 492941. python3kgae marked 2 inline comments as done. python3kgae added a comment. Fix windows test fail. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141705/new/ https://reviews.llvm.org/D141705 Files:

[PATCH] D142584: [CodeGen] Add a boolean flag to `Address::getPointer` and `Lvalue::getPointer` that indicates whether the pointer is known not to be null

ahatanak updated this revision to Diff 492940. ahatanak added a comment. Pass a `KnownNonNull_t` flag to `Address::withPointer`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142584/new/ https://reviews.llvm.org/D142584 Files:

[PATCH] D141705: [HLSL] [Dirver] add dxv as a Driver Action Job

jhuber6 accepted this revision. jhuber6 added a comment. This revision is now accepted and ready to land. LGTM overall. Thanks for the patch. Others feel free to comment. Comment at: clang/lib/Driver/Driver.cpp:4214 } - + // Call validator for dxil when -Vd not in Args. +

[PATCH] D141705: [HLSL] [Dirver] add dxv as a Driver Action Job

python3kgae marked 2 inline comments as done. python3kgae added inline comments. Comment at: clang/lib/Driver/ToolChains/HLSL.cpp:170 + +Tool *clang::driver::toolchains::HLSLToolChain::getTool( +Action::ActionClass AC) const { jhuber6 wrote: > python3kgae

[PATCH] D141705: [HLSL] [Dirver] add dxv as a Driver Action Job

python3kgae updated this revision to Diff 492931. python3kgae marked an inline comment as done. python3kgae added a comment. rename to requiresValidation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141705/new/ https://reviews.llvm.org/D141705

[PATCH] D141705: [HLSL] [Dirver] add dxv as a Driver Action Job

jhuber6 added inline comments. Comment at: clang/lib/Driver/ToolChains/HLSL.cpp:170 + +Tool *clang::driver::toolchains::HLSLToolChain::getTool( +Action::ActionClass AC) const { python3kgae wrote: > jhuber6 wrote: > > I feel like this logic should go with the

[PATCH] D141705: [HLSL] [Dirver] add dxv as a Driver Action Job

python3kgae marked an inline comment as done. python3kgae added inline comments. Comment at: clang/lib/Driver/Driver.cpp:4226 +Args.ClaimAllArgs(options::OPT_cl_ignored_Group); + } jhuber6 wrote: > nit. remember to `clang-format` arc did find some

[PATCH] D141705: [HLSL] [Dirver] add dxv as a Driver Action Job

jhuber6 added a comment. Thanks for the changes. Comment at: clang/lib/Driver/Driver.cpp:4226 +Args.ClaimAllArgs(options::OPT_cl_ignored_Group); + } nit. remember to `clang-format` Comment at: clang/lib/Driver/ToolChains/HLSL.cpp:170

[PATCH] D141338: [-Wunsafe-buffer-usage] Filter out conflicting fix-its

ziqingluo-90 updated this revision to Diff 492918. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141338/new/ https://reviews.llvm.org/D141338 Files: clang/include/clang/Analysis/Analyses/UnsafeBufferUsage.h clang/lib/Analysis/UnsafeBufferUsage.cpp

[PATCH] D141338: [-Wunsafe-buffer-usage] Filter out conflicting fix-its

ziqingluo-90 updated this revision to Diff 492914. ziqingluo-90 added a comment. Rebase the change CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141338/new/ https://reviews.llvm.org/D141338 Files: clang/include/clang/Analysis/Analyses/UnsafeBufferUsage.h

[PATCH] D141705: [HLSL] [Dirver] add dxv as a Driver Action Job

python3kgae added inline comments. Comment at: clang/lib/Driver/Driver.cpp:4217-4218 +// Only add action when needValidation. +const auto = getToolChain(Args, C.getDefaultToolChain().getTriple()); +const auto *HLSLTC = static_cast(); +if

[PATCH] D141705: [HLSL] [Dirver] add dxv as a Driver Action Job

python3kgae updated this revision to Diff 492912. python3kgae marked 2 inline comments as done. python3kgae added a comment. switch to getDefaultToolChain. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141705/new/ https://reviews.llvm.org/D141705

[PATCH] D141705: [HLSL] [Dirver] add dxv as a Driver Action Job

jhuber6 added inline comments. Comment at: clang/lib/Driver/Driver.cpp:4217-4218 +// Only add action when needValidation. +const auto = getToolChain(Args, C.getDefaultToolChain().getTriple()); +const auto *HLSLTC = static_cast(); +if

[PATCH] D142584: [CodeGen] Add a boolean flag to `Address::getPointer` and `Lvalue::getPointer` that indicates whether the pointer is known not to be null

ahatanak added inline comments. Comment at: clang/lib/CodeGen/Address.h:146 +return Address(NewPointer, getElementType(), getAlignment(), + isKnownNonNull()); } This isn't safe. We cannot tell whether the new pointer is non-null or not

[PATCH] D142780: [clang] NFCI: Use FileEntryRef in FileManager's UID mapping

rmaz added a comment. In D142780#4087270 , @benlangmuir wrote: > If compiling a single pcm accesses multiple hard links with the same UID, > then it would not be possible to use the set of UIDs to get the "right path". > At best we could make it get

[PATCH] D142780: [clang] NFCI: Use FileEntryRef in FileManager's UID mapping

jansvoboda11 added a comment. Sounds like the easies way out is serializing all `FileEntryRef` objects we know in deterministic order. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142780/new/ https://reviews.llvm.org/D142780

[PATCH] D142780: [clang] NFCI: Use FileEntryRef in FileManager's UID mapping

benlangmuir added a comment. In D142780#4087250 , @rmaz wrote: > In that case we are seeing non-deterministic header paths serialized in pcm > files. IIUC the header files are serialized based in their unique ID, so it > wouldn't be possible to handle

[PATCH] D142733: Add _Optional as fast qualifier

rsmith added a comment. Including a link to the RFC (https://discourse.llvm.org/t/rfc-optional-a-type-qualifier-to-indicate-pointer-nullability/68004/2) in each of the patches in this series would be helpful. Assuming that we want to go in this direction, it seems quite expensive to model

[PATCH] D142780: [clang] NFCI: Use FileEntryRef in FileManager's UID mapping

rmaz added a comment. In D142780#4087236 , @benlangmuir wrote: > I think if we want to change this to FileEntryRef it needs to be > deterministic which ref you get. I think this might be the root of the problem we are seeing: depending on build

[PATCH] D142780: [clang] NFCI: Use FileEntryRef in FileManager's UID mapping

benlangmuir added a comment. Iterating over `SeenFileEntries` and skipping `VirtualFileEntries` looks good to me. I'm not sure about changing this to FileEntryRef though. The way this API works you only get one per unique file, which is well suited to `FileEntry *` which has the same uniquing

[PATCH] D141705: [HLSL] [Dirver] add dxv as a Driver Action Job

python3kgae updated this revision to Diff 492894. python3kgae marked 2 inline comments as done. python3kgae added a comment. cast ToolChain to HLSLToolChain. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141705/new/

[PATCH] D141705: [HLSL] [Dirver] add dxv as a Driver Action Job

python3kgae marked 6 inline comments as done. python3kgae added inline comments. Comment at: clang/include/clang/Driver/Types.def:110 TYPE("api-information", API_INFO, INVALID, "json", phases::Precompile) +TYPE("dx-container", DX_CONTAINER,

[PATCH] D141705: [HLSL] [Dirver] add dxv as a Driver Action Job

jhuber6 added inline comments. Comment at: clang/test/Driver/dxc_dxv_path.hlsl:19-23 +// PHASES:+- 0: input, "[[INPUT:.+]]", hlsl +// PHASES:+- 1: preprocessor, {0}, c++-cpp-output +// PHASES:+- 2: compiler, {1}, ir +// PHASES:3: backend, {2}, assembler +// PHASES:4:

[PATCH] D141705: [HLSL] [Dirver] add dxv as a Driver Action Job

jhuber6 added inline comments. Comment at: clang/lib/Driver/Driver.cpp:4218 +// Only add action when needValidation. +if (toolchains::HLSLToolChain::needValidation(Args, *this, + C.getDefaultToolChain())) {

[PATCH] D141705: [HLSL] [Dirver] add dxv as a Driver Action Job

python3kgae marked an inline comment as done. python3kgae added inline comments. Comment at: clang/lib/Driver/Driver.cpp:4218 +// Only add action when needValidation. +if (toolchains::HLSLToolChain::needValidation(Args, *this, +

[PATCH] D139737: [-Wunsafe-buffer-usage] Initiate Fix-it generation for local variable declarations

ziqingluo-90 updated this revision to Diff 492882. ziqingluo-90 added a comment. Addressing comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139737/new/ https://reviews.llvm.org/D139737 Files: clang/include/clang/Analysis/Analyses/UnsafeBufferUsage.h

[PATCH] D141705: [HLSL] [Dirver] add dxv as a Driver Action Job

jhuber6 added inline comments. Comment at: clang/lib/Driver/Driver.cpp:4214-4216 + // Call validator for dxil when -Vd not in Args. + llvm::Triple T(getTargetTriple()); + if (T.getArch() == llvm::Triple::dxil) { Comment at:

[PATCH] D138675: [flang] Add -ffast-math and -Ofast

mnadeem added inline comments. Herald added a subscriber: sunshaoce. Comment at: flang/test/Driver/fast_math.f90:59-62 +! Check that -ffast-math causes us to link to crtfastmath.o +! UNSUPPORTED: system-windows +! RUN: %flang -ffast-math -### %s -o %t 2>&1 \ +! RUN: |

[PATCH] D141705: [HLSL] [Dirver] add dxv as a Driver Action Job

beanz added inline comments. Comment at: clang/include/clang/Driver/Types.def:110 TYPE("api-information", API_INFO, INVALID, "json", phases::Precompile) +TYPE("dx-container", DX_CONTAINER, INVALID, "dxc", phases::Compile,

[PATCH] D139737: [-Wunsafe-buffer-usage] Initiate Fix-it generation for local variable declarations

ziqingluo-90 marked 8 inline comments as done. ziqingluo-90 added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:637 -static Strategy -getNaiveStrategy(const llvm::SmallVectorImpl ) { NoQ wrote: > Hmm, did this need to be moved? I don't

[PATCH] D142724: [clang] use FileEntryRef for SUBMODULE_TOPHEADER

rmaz added inline comments. Comment at: clang/lib/Lex/ModuleMap.cpp:663 Result->IsInferred = true; - Result->addTopHeader(File); + Result->addTopHeader(File->getLastRef()); jansvoboda11 wrote: > rmaz wrote: > > jansvoboda11 wrote: > > > How

[PATCH] D141705: [HLSL] [Dirver] add dxv as a Driver Action Job

python3kgae marked an inline comment as done. python3kgae added inline comments. Comment at: clang/lib/Driver/Driver.cpp:4216 + llvm::Triple T(getTargetTriple()); + if (T.getArch() == llvm::Triple::dxil && !Args.getLastArg(options::OPT_dxc_disable_validation)) { +// Only

[PATCH] D141705: [HLSL] [Dirver] add dxv as a Driver Action Job

python3kgae updated this revision to Diff 492878. python3kgae marked 9 inline comments as done. python3kgae added a comment. add DX_CONTAINER Driver type. Code cleanup. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141705/new/

[PATCH] D142724: [clang] use FileEntryRef for SUBMODULE_TOPHEADER

jansvoboda11 added inline comments. Comment at: clang/lib/Lex/ModuleMap.cpp:663 Result->IsInferred = true; - Result->addTopHeader(File); + Result->addTopHeader(File->getLastRef()); rmaz wrote: > jansvoboda11 wrote: > > How much work would be

[PATCH] D142780: [clang] NFCI: Use FileEntryRef in FileManager's UID mapping

jansvoboda11 created this revision. jansvoboda11 added reviewers: rmaz, benlangmuir, bnbarham. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Per the

[PATCH] D139737: [-Wunsafe-buffer-usage] Initiate Fix-it generation for local variable declarations

jkorous added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:127 +static auto isInUnspecifiedLvalueContext(internal::Matcher innerMatcher) { + auto isLvalueToRvalueCast = [](internal::Matcher M) { +return

[PATCH] D142430: [Clang] Treat `std::forward_like` as builtin

alexander-shaposhnikov added a comment. gentle ping ) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142430/new/ https://reviews.llvm.org/D142430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D142501: [clang][deps] Fix modulemap file path for implementation of module

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. benlangmuir marked an inline comment as done. Closed by commit rG73dba2f649a8: [clang][deps] Fix modulemap file path for implementation of module (authored by

[clang] 73dba2f - [clang][deps] Fix modulemap file path for implementation of module

Author: Ben Langmuir Date: 2023-01-27T11:37:35-08:00 New Revision: 73dba2f649a8e8c01e9c8b8df3bdc89cdf0fd7ee URL: https://github.com/llvm/llvm-project/commit/73dba2f649a8e8c01e9c8b8df3bdc89cdf0fd7ee DIFF: https://github.com/llvm/llvm-project/commit/73dba2f649a8e8c01e9c8b8df3bdc89cdf0fd7ee.diff

[PATCH] D142584: [CodeGen] Add a boolean flag to `Address::getPointer` and `Lvalue::getPointer` that indicates whether the pointer is known not to be null

ahatanak updated this revision to Diff 492860. ahatanak added a comment. Fix a few typos that were causing compile errors. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142584/new/ https://reviews.llvm.org/D142584 Files:

[PATCH] D141409: [SystemZ] Fix handling of vectors and their exposure of the vector ABI.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0eff46f87f16: [SystemZ] Fix handling of vectors and their exposure of the vector ABI. (authored by jonpa). Herald added a project: clang. Herald

[clang] 0eff46f - [SystemZ] Fix handling of vectors and their exposure of the vector ABI.

Author: Jonas Paulsson Date: 2023-01-27T20:24:09+01:00 New Revision: 0eff46f87f16772f93bdc584865e945162aff170 URL: https://github.com/llvm/llvm-project/commit/0eff46f87f16772f93bdc584865e945162aff170 DIFF:

[libclc] 8040e3a - libclc: Fix building against an llvm build directory

Author: Tom Stellard Date: 2023-01-27T11:16:03-08:00 New Revision: 8040e3a4deeb25edc34fb4f89e032ff58ad50572 URL: https://github.com/llvm/llvm-project/commit/8040e3a4deeb25edc34fb4f89e032ff58ad50572 DIFF: https://github.com/llvm/llvm-project/commit/8040e3a4deeb25edc34fb4f89e032ff58ad50572.diff

[clang] 4266756 - Fix recursive error for constraints depending on itself incorrectly

Author: Erich Keane Date: 2023-01-27T11:11:53-08:00 New Revision: 42667563721e139a93ab886119ea2780ebc3fecc URL: https://github.com/llvm/llvm-project/commit/42667563721e139a93ab886119ea2780ebc3fecc DIFF: https://github.com/llvm/llvm-project/commit/42667563721e139a93ab886119ea2780ebc3fecc.diff

[PATCH] D142565: [clang-tidy] Fix warning in portability-simd-intrinsics

This revision was automatically updated to reflect the committed changes. Closed by commit rG1d02dd241816: [clang-tidy] Fix warning in portability-simd-intrinsics (authored by ClockMan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142565/new/

[clang-tools-extra] 1d02dd2 - [clang-tidy] Fix warning in portability-simd-intrinsics

Author: Piotr Zegar Date: 2023-01-27T18:50:51Z New Revision: 1d02dd241816e3d5865e7d395ee7310167198b09 URL: https://github.com/llvm/llvm-project/commit/1d02dd241816e3d5865e7d395ee7310167198b09 DIFF: https://github.com/llvm/llvm-project/commit/1d02dd241816e3d5865e7d395ee7310167198b09.diff LOG:

[libclc] 409f42b - libclc: Set CMAKE_CXX_STANDARD to 17 to match llvm

Author: Tom Stellard Date: 2023-01-27T10:50:29-08:00 New Revision: 409f42b10ac6dc1c6a4e68d20ccd3adf6770e238 URL: https://github.com/llvm/llvm-project/commit/409f42b10ac6dc1c6a4e68d20ccd3adf6770e238 DIFF: https://github.com/llvm/llvm-project/commit/409f42b10ac6dc1c6a4e68d20ccd3adf6770e238.diff

[clang] 131b955 - [CMake] Include clang-bolt bootstrap target in BOLT-PGO.cmake

Author: Amir Ayupov Date: 2023-01-27T10:46:34-08:00 New Revision: 131b955a4f7015c718c1780d0320353d488f85be URL: https://github.com/llvm/llvm-project/commit/131b955a4f7015c718c1780d0320353d488f85be DIFF: https://github.com/llvm/llvm-project/commit/131b955a4f7015c718c1780d0320353d488f85be.diff

[PATCH] D142584: [CodeGen] Add a boolean flag to `Address::getPointer` and `Lvalue::getPointer` that indicates whether the pointer is known not to be null

ahatanak added a comment. There are more places where we know contextually the pointer can't be null and can set the bit to `KnownNonNull` or set the bit of an `LValue` or `Address` using an existing `Address`'s KnownNonNull bit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D142584: [CodeGen] Add a boolean flag to `Address::getPointer` and `Lvalue::getPointer` that indicates whether the pointer is known not to be null

ahatanak updated this revision to Diff 492843. ahatanak added a comment. Add a bit to `Address` and `LValue` that tracks whether the pointer is known not to be null. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142584/new/

[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

kadircet added inline comments. Comment at: clang/tools/include-mapping/cppreference_parser.py:196 + "std::remove$": "algorithm", + "std::atomic.*": "atomic", + there's no variant of "std::atomic.*" called "atomic", in

[PATCH] D142733: Add _Optional as fast qualifier

rriddle added a comment. I don't understand the MLIR changes here, how are they relevant to the patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142733/new/ https://reviews.llvm.org/D142733 ___

[PATCH] D142724: [clang] use FileEntryRef for SUBMODULE_TOPHEADER

rmaz marked an inline comment as done. rmaz added inline comments. Comment at: clang/lib/Lex/ModuleMap.cpp:663 Result->IsInferred = true; - Result->addTopHeader(File); + Result->addTopHeader(File->getLastRef()); jansvoboda11 wrote: > How much

[PATCH] D142690: [DRAFT][libc++] Fixes the Clang modular build.

Mordante updated this revision to Diff 492834. Mordante added a comment. Removes uninteded include. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142690/new/ https://reviews.llvm.org/D142690 Files: libcxx/include/module.modulemap.in

[PATCH] D142723: [C2x] Stop diagnosing member and array access in offsetof as an extension

stilor added inline comments. Comment at: clang/docs/LanguageExtensions.rst:2389 const int ext1 = __builtin_offsetof(struct U { int i; }, i); // C extension - const int ext2 = __builtin_offsetof(struct S, t.f[1]); // C & C++ extension + const int ext2 =

[PATCH] D142724: [clang] use FileEntryRef for SUBMODULE_TOPHEADER

rmaz updated this revision to Diff 492829. rmaz added a comment. Use FileEntryRef for AddTopHeader() Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142724/new/ https://reviews.llvm.org/D142724 Files: clang/include/clang/Basic/Module.h

[PATCH] D142690: [DRAFT][libc++] Fixes the Clang modular build.

Mordante updated this revision to Diff 492828. Mordante added a comment. Finalized patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142690/new/ https://reviews.llvm.org/D142690 Files: clang/lib/run_the_clang_CI

[PATCH] D142440: [clangd] Don't show 'auto' type hint when type deduction fails

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks! Comment at: clang-tools-extra/clangd/InlayHints.cpp:307 +if (auto *AT = D->getType()->getContainedAutoType()) { + if (!AT->getDeducedType().isNull() &&

[PATCH] D133574: [C2x] reject type definitions in offsetof

aaron.ballman added a comment. In D133574#4086450 , @stilor wrote: >>> I posted https://reviews.llvm.org/D142723 to address this. >> >> and 63d6b8be6cf248a1a8800d85a11be469c6e2 >>

[PATCH] D133574: [C2x] reject type definitions in offsetof

stilor added a comment. >> I posted https://reviews.llvm.org/D142723 to address this. > > and 63d6b8be6cf248a1a8800d85a11be469c6e2 > should > hopefully resolve it. Thank you for sorting this out so quickly! Repository:

[PATCH] D142757: [clang][driver] Do not warn about position of `/clang:-xc` in cl mode

Fznamznon created this revision. Herald added a project: All. Fznamznon requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. In CL mode values of `/clang:` arguments end up at the end of arguments list which makes the warning always

[PATCH] D142596: [RISCV] Bump Zca, Zcd, Zcf version to 1.0.

craig.topper updated this revision to Diff 492810. craig.topper added a comment. Add Zcb Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142596/new/ https://reviews.llvm.org/D142596 Files: clang/test/Driver/riscv-arch.c

[clang] 4f99647 - [LinkerWrapper] Add support for --[no-]whole-archive into the linker wrapper

Author: Joseph Huber Date: 2023-01-27T11:30:50-06:00 New Revision: 4f9964738b9c01f16bc962aac68e441377c8c842 URL: https://github.com/llvm/llvm-project/commit/4f9964738b9c01f16bc962aac68e441377c8c842 DIFF: https://github.com/llvm/llvm-project/commit/4f9964738b9c01f16bc962aac68e441377c8c842.diff

[PATCH] D142578: [Clang][Doc] Edit the Clang release notes

aaron.ballman added inline comments. Comment at: clang/docs/ReleaseNotes.rst:452-454 + - Now diagnoses use of a member access expression or array subscript expression within ``__builtin_offsetof`` and ``offsetof`` as being a Clang extension. Assuming

[PATCH] D142724: [clang] use FileEntryRef for SUBMODULE_TOPHEADER

jansvoboda11 added inline comments. Comment at: clang/lib/Basic/Module.cpp:273 +void Module::addTopHeader(OptionalFileEntryRef File) { assert(File); + TopHeaders.insert(*File); If we assert that `File` is not empty right away, why take

[PATCH] D142744: Re-analyze functions as top-level

chrisbazley added a comment. This change is admittedly a hack. It might be better to check the function parameter types, or maybe the list of exceptions in this function is now so long that it no longer serves any purpose. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D138122: Lift EHPersonalities from Analysis to IR (NFC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3b387d10707d: Lift EHPersonalities from Analysis to IR (NFC) (authored by sgraenitz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 3b387d1 - Lift EHPersonalities from Analysis to IR (NFC)

Author: Stefan Gränitz Date: 2023-01-27T18:05:13+01:00 New Revision: 3b387d10707d3ec5f4786812cc055c89c3eaa161 URL: https://github.com/llvm/llvm-project/commit/3b387d10707d3ec5f4786812cc055c89c3eaa161 DIFF:

[PATCH] D142744: Re-analyze functions as top-level

chrisbazley created this revision. Herald added subscribers: steakhal, martong. Herald added a reviewer: NoQ. Herald added a project: All. chrisbazley requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. If a function with a _Nullable parameter

[PATCH] D142743: Fix nullability checking of top-level functions

chrisbazley created this revision. Herald added subscribers: steakhal, martong. Herald added a reviewer: NoQ. Herald added a project: All. chrisbazley requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The existing nullability checker is so

[PATCH] D142673: [clang-tidy] Refactor HeaderGuardCheck to add HeaderGuardStyle

KyleFromKitware added a comment. In D142673#4086018 , @carlosgalvezp wrote: > Note: I do not have possibility to add code comments - is there some too > strict permissions set for this patch? It has not happened to other patches. I accidentally set

[PATCH] D142742: Generate ImplicitNullDerefEvent from CallAndMessageChecker

chrisbazley created this revision. Herald added subscribers: steakhal, martong. Herald added a reviewer: NoQ. Herald added a project: All. chrisbazley requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Without this change, the following code

[PATCH] D142741: Fix ProgramState::isNull for non-region symbols

chrisbazley created this revision. Herald added subscribers: steakhal, martong. Herald added a reviewer: NoQ. Herald added a project: All. chrisbazley requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This method was good at telling that a

[PATCH] D142740: [WIP] [WebAssembly] Enable MemorySanitizer for emscripten

sbc100 created this revision. Herald added subscribers: Enna1, pmatos, asb, wingo, ecnelises, sunfish, hiraditya, jgravelle-google, dschuff. Herald added a project: All. sbc100 requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, MaskRay, aheejin. Herald added

[PATCH] D142739: Standalone checker for use of _Optional qualifier

chrisbazley created this revision. Herald added subscribers: steakhal, martong. Herald added a reviewer: NoQ. Herald added a project: All. chrisbazley requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This checker tries to

[PATCH] D142565: [clang-tidy] Fix warning in portability-simd-intrinsics

carlosgalvezp accepted this revision. carlosgalvezp added a comment. This revision is now accepted and ready to land. LGTM, thanks for the fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142565/new/ https://reviews.llvm.org/D142565

[PATCH] D142738: Warn if _Optional used at top-level of decl

chrisbazley created this revision. Herald added a project: All. chrisbazley requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Parameter declarations using [] syntax can be written more naturally using an _Optional qualifier than using

[PATCH] D136886: [clang] ASTImporter: Fix importing of va_list types and declarations

balazske added a comment. I have a fix for the AArch64 problems in test `ImportCorrectTemplatedDecl`, dcl-58-cpp, and the "Declaration not emitted!" assertion. I can not find at which tests the `error: reference to 'std' is ambiguous` appears. Probably the AArch64 (and Arm) tests could be run

[PATCH] D142673: [clang-tidy] Refactor HeaderGuardCheck to add HeaderGuardStyle

carlosgalvezp added a comment. Also, in general the design choice is that checks should be independent and authors should not need to care about whether they conflict with other checks. In this particular case, if both checks are providing different results, users should choose one and disable

[PATCH] D142737: Updated getNullabilityAnnotation for checkers

chrisbazley created this revision. Herald added subscribers: steakhal, martong, JDevlieghere. Herald added a reviewer: NoQ. Herald added a project: All. chrisbazley requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. NullabilityChecker and

[clang] 7d4ce70 - [LinkerWrapper][NFC] Remove unused options

Author: Joseph Huber Date: 2023-01-27T10:49:31-06:00 New Revision: 7d4ce7050505baadd0d40c30d0726a136a64c717 URL: https://github.com/llvm/llvm-project/commit/7d4ce7050505baadd0d40c30d0726a136a64c717 DIFF: https://github.com/llvm/llvm-project/commit/7d4ce7050505baadd0d40c30d0726a136a64c717.diff

[PATCH] D142673: [clang-tidy] Refactor HeaderGuardCheck to add HeaderGuardStyle

carlosgalvezp added a comment. Note: I do not have possibility to add code comments - is there some too strict permissions set for this patch? It has not happened to other patches. Review comment: I think the design choice in clang-tidy is that checks from different modules should not depend

[PATCH] D142736: Add QualType::getNullability for _Optional

chrisbazley created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. chrisbazley requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a subscriber: cfe-commits. The purpose of this change is to ensure that a

[PATCH] D142734: Updated CheckAddressOfOperand

chrisbazley created this revision. Herald added a project: All. chrisbazley requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The semantics of the unary & operator are modified so that if its operand has type "type" then its result has type

[PATCH] D142690: [DRAFT][libc++] Fixes the Clang modular build.

Mordante updated this revision to Diff 492779. Mordante added a comment. Rebased and improve fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142690/new/ https://reviews.llvm.org/D142690 Files: clang/lib/run_the_clang_CI

[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

VitaNuo marked an inline comment as done. VitaNuo added a comment. Thanks for the comments! AFAICS I've addressed all of them. Re tests, thanks for the reminder @hokein! I've fixed them now, everything is green. Comment at:

[PATCH] D142733: Add _Optional as fast qualifier

chrisbazley created this revision. Herald added subscribers: Moerafaat, zero9178, bzcheeseman, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, jdoerfert, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, mgester, arpith-jacob, antiagainst, shauheen,

  1   2   >