[PATCH] D141907: [CMake] Ensure `CLANG_RESOURCE_DIR` is respected

2023-01-28 Thread Michał Górny via Phabricator via cfe-commits
mgorny added a comment. While the general direction seems sound, I suspect this may be a real PITA given that for us: -DCLANG_RESOURCE_DIR="../../../../lib/clang/${LLVM_MAJOR}" I'm going to try and see later throughout the week if it's possible to keep that working with this patch.

[PATCH] D142804: [clang-format] Support clang-format on/off line comments as prefixes

2023-01-28 Thread Owen Pan via Phabricator via cfe-commits
owenpan updated this revision to Diff 493069. owenpan added a comment. Only allows `:` as the first character after `// clang-format on` or `// clang-format off`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142804/new/ https://reviews.llvm.org/D142804 Files:

[clang] d6d29dc - Revert commit 01adf96ebc86 because it caused "Unhandled DeclRefExpr" errors.

2023-01-28 Thread Liming Liu via cfe-commits
Author: Liming Liu Date: 2023-01-29T14:37:13+08:00 New Revision: d6d29dc4fa9cbb6d4d5622f9fea4697669edf214 URL: https://github.com/llvm/llvm-project/commit/d6d29dc4fa9cbb6d4d5622f9fea4697669edf214 DIFF: https://github.com/llvm/llvm-project/commit/d6d29dc4fa9cbb6d4d5622f9fea4697669edf214.diff

[PATCH] D142596: [RISCV] Bump Zca, Zcb, Zcd, Zcf version to 1.0.

2023-01-28 Thread Craig Topper via Phabricator via cfe-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3d7a59bdc085: [RISCV] Bump Zca, Zcb, Zcd, Zcf version to 1.0.

[clang] 3d7a59b - [RISCV] Bump Zca, Zcb, Zcd, Zcf version to 1.0.

2023-01-28 Thread Craig Topper via cfe-commits
Author: Craig Topper Date: 2023-01-28T22:04:34-08:00 New Revision: 3d7a59bdc0850fee0ad31686f038ae5abf88b7f2 URL: https://github.com/llvm/llvm-project/commit/3d7a59bdc0850fee0ad31686f038ae5abf88b7f2 DIFF: https://github.com/llvm/llvm-project/commit/3d7a59bdc0850fee0ad31686f038ae5abf88b7f2.diff

[PATCH] D142437: [clang] Add the check of membership in decltype for the issue #58674

2023-01-28 Thread Liming Liu via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG01adf96ebc86: [clang] Add the check of membership in decltype for the issue #58674 (authored by lime). Repository: rG LLVM Github Monorepo

[clang] 01adf96 - [clang] Add the check of membership in decltype for the issue #58674

2023-01-28 Thread Liming Liu via cfe-commits
Author: Liming Liu Date: 2023-01-29T13:44:19+08:00 New Revision: 01adf96ebc8608bcdda0cacc303035b2e60ccb46 URL: https://github.com/llvm/llvm-project/commit/01adf96ebc8608bcdda0cacc303035b2e60ccb46 DIFF: https://github.com/llvm/llvm-project/commit/01adf96ebc8608bcdda0cacc303035b2e60ccb46.diff

[PATCH] D142804: [clang-format] Support clang-format on/off line comments as prefixes

2023-01-28 Thread Owen Pan via Phabricator via cfe-commits
owenpan added inline comments. Comment at: clang/lib/Format/Format.cpp:3893 +bool isClangFormatOn(StringRef Comment) { + if (Comment == "/* clang-format on */") alexolog wrote: > alexolog wrote: > > Here's my attempt at something flexible: > > Disclaimer:

[PATCH] D142688: [Clang][Driver] Handle LoongArch multiarch tuples

2023-01-28 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Linux.cpp:116 + +return std::string("loongarch64-linux-") + Libc + FPFlavor; + } `return (... + ...).str();` if an operand of `+` is a `Twine` Repository: rG LLVM Github Monorepo

[PATCH] D142826: [Clang] Add -Wtype-limits to -Wextra for GCC compatibility

2023-01-28 Thread Shivam Gupta via Phabricator via cfe-commits
xgupta created this revision. xgupta added reviewers: aaron.ballman, dblaikie. Herald added a project: All. xgupta requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. GCC added the -Wtype-limits warning group to -Wextra around GCC 4.4 and the

[PATCH] D142437: [clang] Add the check of membership in decltype for the issue #58674

2023-01-28 Thread Liming Liu via Phabricator via cfe-commits
lime updated this revision to Diff 493058. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142437/new/ https://reviews.llvm.org/D142437 Files: clang/docs/ReleaseNotes.rst clang/include/clang/AST/DeclCXX.h clang/lib/AST/CXXInheritance.cpp clang/lib/Sema/SemaExpr.cpp

[PATCH] D142437: [clang] Add the check of membership in decltype for the issue #58674

2023-01-28 Thread Liming Liu via Phabricator via cfe-commits
lime updated this revision to Diff 493057. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142437/new/ https://reviews.llvm.org/D142437 Files: clang/docs/ReleaseNotes.rst clang/include/clang/AST/DeclCXX.h clang/lib/AST/CXXInheritance.cpp clang/lib/Sema/SemaExpr.cpp

[PATCH] D142596: [RISCV] Bump Zca, Zcb, Zcd, Zcf version to 1.0.

2023-01-28 Thread Xinlong Wu via Phabricator via cfe-commits
VincentWu added a comment. LGTM for now ) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142596/new/ https://reviews.llvm.org/D142596 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D142437: [clang] Add the check of membership in decltype for the issue #58674

2023-01-28 Thread Liming Liu via Phabricator via cfe-commits
lime updated this revision to Diff 493055. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142437/new/ https://reviews.llvm.org/D142437 Files: clang/docs/ReleaseNotes.rst clang/include/clang/AST/DeclCXX.h clang/lib/AST/CXXInheritance.cpp clang/lib/Sema/SemaExpr.cpp

[PATCH] D137753: [Clang][AIX][p]Enable -p Functionality

2023-01-28 Thread Michael Francis via Phabricator via cfe-commits
francii updated this revision to Diff 493054. francii added a comment. Update based on review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137753/new/ https://reviews.llvm.org/D137753 Files: clang/include/clang/Driver/Options.td

[PATCH] D142595: [Driver][AVR] Don't emit default '-Tdata' when a linker script is specified

2023-01-28 Thread Ben Shi via Phabricator via cfe-commits
benshi001 added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:500 - if (SectionAddressData) { -CmdArgs.push_back(Args.MakeArgString( -"-Tdata=0x" + Twine::utohexstr(*SectionAddressData))); - } else { -// We do not have an entry for this CPU

[PATCH] D142595: [Driver][AVR] Don't emit default '-Tdata' when a linker script is specified

2023-01-28 Thread Ben Shi via Phabricator via cfe-commits
benshi001 updated this revision to Diff 493053. benshi001 edited the summary of this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142595/new/ https://reviews.llvm.org/D142595 Files: clang/lib/Driver/ToolChains/AVR.cpp

[PATCH] D142595: [Driver][AVR] Don't emit default '-Tdata' when a linker script is specified

2023-01-28 Thread Ben Shi via Phabricator via cfe-commits
benshi001 added a comment. In D142595#4088364 , @MaskRay wrote: > This is probably not a good idea. See > https://github.com/llvm/llvm-project/issues/60203#issuecomment-1407532083 I agree with your comment in

[PATCH] D141892: Implement modernize-use-constraints

2023-01-28 Thread Chris Cotter via Phabricator via cfe-commits
ccotter updated this revision to Diff 493050. ccotter added a comment. Rebase + Simplify match logic Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141892/new/ https://reviews.llvm.org/D141892 Files:

[PATCH] D142688: [Clang][Driver] Handle LoongArch multiarch tuples

2023-01-28 Thread Lu Weining via Phabricator via cfe-commits
SixWeining added inline comments. Comment at: clang/lib/Driver/ToolChains/Linux.cpp:41 /// so we provide a rough mapping here. std::string Linux::getMultiarchTriple(const Driver , const llvm::Triple , Missing test.

[PATCH] D142823: Intrinsics: Allow tablegen to mark parameters with dereferenceable

2023-01-28 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm created this revision. arsenm added reviewers: sstefan1, jdoerfert, yaxunl, AMDGPU, nikic, alexander-shaposhnikov. Herald added subscribers: kosarev, StephenFan, kerbowa, jvesely. Herald added a project: All. arsenm requested review of this revision. Herald added a subscriber: wdng. Herald

[PATCH] D142595: [Driver][AVR] Don't emit default '-Tdata' when a linker script is specified

2023-01-28 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay requested changes to this revision. MaskRay added a comment. This revision now requires changes to proceed. This is probably not a good idea. See https://github.com/llvm/llvm-project/issues/60203#issuecomment-1407532083 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D142757: [clang][driver] Do not warn about position of `/clang:-xc` in cl mode

2023-01-28 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. See https://github.com/llvm/llvm-project/issues/59307#issuecomment-1407529807 I think we should just report an error for `/clang:-xc` Comment at: clang/lib/Driver/Driver.cpp:2571 // No driver mode exposes -x and /TC or /TP; we don't support

[PATCH] D142822: [clang] ASTImporter: Fix importing of va_list types and declarations

2023-01-28 Thread Vince Bridgers via Phabricator via cfe-commits
vabridgers created this revision. vabridgers added reviewers: aaron.ballman, mizvekov. Herald added subscribers: carlosgalvezp, martong, kristof.beyls. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a reviewer: njames93. Herald added a project: All. vabridgers

[PATCH] D142569: [WIP][OpenMP] Introduce kernel argument

2023-01-28 Thread Shilei Tian via Phabricator via cfe-commits
tianshilei1992 added inline comments. Comment at: openmp/libomptarget/plugins/cuda/src/rtl.cpp:26 #include "Debug.h" -#include "DeviceEnvironment.h" +#include "Environment.h" #include "omptarget.h" These changes in old plugins will be gone because the old

[PATCH] D142569: [WIP][OpenMP] Introduce kernel argument

2023-01-28 Thread Shilei Tian via Phabricator via cfe-commits
tianshilei1992 updated this revision to Diff 493043. tianshilei1992 added a comment. rebase and fix bugs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142569/new/ https://reviews.llvm.org/D142569 Files: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp

[PATCH] D142430: [Clang] Treat `std::forward_like` as builtin

2023-01-28 Thread Alexander Shaposhnikov via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0fd9c37d8cf2: [Clang] Treat `std::forward_like` as builtin (authored by alexander-shaposhnikov). Changed prior to commit:

[clang] 0fd9c37 - [Clang] Treat `std::forward_like` as builtin

2023-01-28 Thread Alexander Shaposhnikov via cfe-commits
Author: Alexander Shaposhnikov Date: 2023-01-29T00:13:46Z New Revision: 0fd9c37d8cf20d1ee42263872ab2135265c3ac3d URL: https://github.com/llvm/llvm-project/commit/0fd9c37d8cf20d1ee42263872ab2135265c3ac3d DIFF:

[clang] 526966d - Use llvm::bit_ceil (NFC)

2023-01-28 Thread Kazu Hirata via cfe-commits
Author: Kazu Hirata Date: 2023-01-28T16:13:09-08:00 New Revision: 526966d07dc89ad69940259020d97d25f26b1306 URL: https://github.com/llvm/llvm-project/commit/526966d07dc89ad69940259020d97d25f26b1306 DIFF: https://github.com/llvm/llvm-project/commit/526966d07dc89ad69940259020d97d25f26b1306.diff

[clang] f6b8f05 - Use llvm::byteswap instead of ByteSwap_{16, 32, 64} (NFC)

2023-01-28 Thread Kazu Hirata via cfe-commits
Author: Kazu Hirata Date: 2023-01-28T15:22:37-08:00 New Revision: f6b8f05bb399e8f5fd176b2c9dd383cd029467f1 URL: https://github.com/llvm/llvm-project/commit/f6b8f05bb399e8f5fd176b2c9dd383cd029467f1 DIFF: https://github.com/llvm/llvm-project/commit/f6b8f05bb399e8f5fd176b2c9dd383cd029467f1.diff

[PATCH] D142804: [clang-format] Support clang-format on/off line comments as prefixes

2023-01-28 Thread Alex via Phabricator via cfe-commits
alexolog added inline comments. Comment at: clang/lib/Format/Format.cpp:3893 +bool isClangFormatOn(StringRef Comment) { + if (Comment == "/* clang-format on */") alexolog wrote: > Here's my attempt at something flexible: > Disclaimer: this is my first time

[PATCH] D142804: [clang-format] Support clang-format on/off line comments as prefixes

2023-01-28 Thread Alex via Phabricator via cfe-commits
alexolog added inline comments. Comment at: clang/lib/Format/Format.cpp:3893 +bool isClangFormatOn(StringRef Comment) { + if (Comment == "/* clang-format on */") Here's my attempt at something flexible: Disclaimer: this is my first time looking at the LLVM

[clang-tools-extra] 55e2cd1 - Use llvm::count{lr}_{zero,one} (NFC)

2023-01-28 Thread Kazu Hirata via cfe-commits
Author: Kazu Hirata Date: 2023-01-28T12:41:20-08:00 New Revision: 55e2cd16095d64e9afca6e109e40ed95d735dc7f URL: https://github.com/llvm/llvm-project/commit/55e2cd16095d64e9afca6e109e40ed95d735dc7f DIFF: https://github.com/llvm/llvm-project/commit/55e2cd16095d64e9afca6e109e40ed95d735dc7f.diff

[clang] 55e2cd1 - Use llvm::count{lr}_{zero,one} (NFC)

2023-01-28 Thread Kazu Hirata via cfe-commits
Author: Kazu Hirata Date: 2023-01-28T12:41:20-08:00 New Revision: 55e2cd16095d64e9afca6e109e40ed95d735dc7f URL: https://github.com/llvm/llvm-project/commit/55e2cd16095d64e9afca6e109e40ed95d735dc7f DIFF: https://github.com/llvm/llvm-project/commit/55e2cd16095d64e9afca6e109e40ed95d735dc7f.diff

[PATCH] D142704: [C++20][Modules] Handle template declarations in header units.

2023-01-28 Thread Iain Sandoe via Phabricator via cfe-commits
iains marked an inline comment as done. iains added a comment. In D142704#4088217 , @Arthapz wrote: > tried the patch and it seems to work with libstdc++ but not with libc++ > > > > rm -rf .xmake build; xmake f --toolchain=clang >

[PATCH] D142704: [C++20][Modules] Handle template declarations in header units.

2023-01-28 Thread Arthur Laurent via Phabricator via cfe-commits
Arthapz added a comment. tried the patch and it seems to work with libstdc++ but not with libc++ > rm -rf .xmake build; xmake f --toolchain=clang; xmake b checking for platform ... linux checking for architecture ... x86_64 [ 0%]: generating.module.deps src/main.cpp [ 4%]:

[PATCH] D139454: [CMake] Replace clang binary if using clang-bolt target

2023-01-28 Thread Amir Ayupov via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGe67f849001bb: [CMake] Replace clang binary if using clang-bolt target (authored by Amir). Changed prior to commit: https://reviews.llvm.org/D139454?vs=492638=493025#toc Repository: rG LLVM Github

[clang] e67f849 - [CMake] Replace clang binary if using clang-bolt target

2023-01-28 Thread Amir Aupov via cfe-commits
Author: Amir Ayupov Date: 2023-01-28T11:54:09-08:00 New Revision: e67f849001bb890f86831ab31c1bb25e0882e711 URL: https://github.com/llvm/llvm-project/commit/e67f849001bb890f86831ab31c1bb25e0882e711 DIFF: https://github.com/llvm/llvm-project/commit/e67f849001bb890f86831ab31c1bb25e0882e711.diff

[PATCH] D142816: [clang-tidy] Add --list-unique-checks command

2023-01-28 Thread Piotr Zegar via Phabricator via cfe-commits
ClockMan created this revision. Herald added subscribers: carlosgalvezp, arphaman, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. ClockMan updated this revision to Diff 493024. ClockMan added a comment. ClockMan published this revision for review. Herald added a

[PATCH] D141144: [clang-tidy][doc] Improve clang-tidy documentation

2023-01-28 Thread Piotr Zegar via Phabricator via cfe-commits
ClockMan added inline comments. Comment at: clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp:34 +static StringRef TrimFirstChar(StringRef x) { return x.substr(1); } + Looks like usecase of this is more like rtrim, then probably rtrim should be used instead

[PATCH] D142569: [WIP][OpenMP] Introduce kernel argument

2023-01-28 Thread Shilei Tian via Phabricator via cfe-commits
tianshilei1992 updated this revision to Diff 493019. tianshilei1992 added a comment. rebase and fix bugs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142569/new/ https://reviews.llvm.org/D142569 Files: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp

[PATCH] D142704: [C++20][Modules] Handle template declarations in header units.

2023-01-28 Thread Iain Sandoe via Phabricator via cfe-commits
iains marked an inline comment as done. iains added a comment. in my local testing, I was able to consume all libc++ headers individually. Comment at: clang/lib/Sema/SemaDecl.cpp:15265 FD->getFormalLinkage() == Linkage::ExternalLinkage && - !FD->isInvalidDecl() &&

[PATCH] D142704: [C++20][Modules] Handle template declarations in header units.

2023-01-28 Thread Iain Sandoe via Phabricator via cfe-commits
iains updated this revision to Diff 493014. iains added a comment. rebased, and revised to handle variable templates and instantiations. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142704/new/ https://reviews.llvm.org/D142704 Files:

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

2023-01-28 Thread Chris Cotter via Phabricator via cfe-commits
ccotter added a comment. In https://github.com/isocpp/CppCoreGuidelines/issues/2026, it looks like the core guideline will not permit exceptions for code that accepts an rvalue ref parameter, and the function body `moves` members of the parameter. So, my `moves_member_of_parameter` test case

[PATCH] D142578: [Clang][Doc] Edit the Clang release notes

2023-01-28 Thread Roy Jacobson via Phabricator via cfe-commits
royjacobson marked 5 inline comments as done. royjacobson added inline comments. Comment at: clang/docs/ReleaseNotes.rst:452-454 + - Now diagnoses use of a member access expression or array subscript expression within ``__builtin_offsetof`` and ``offsetof`` as being a Clang

[PATCH] D142578: [Clang][Doc] Edit the Clang release notes

2023-01-28 Thread Roy Jacobson via Phabricator via cfe-commits
royjacobson updated this revision to Diff 493008. royjacobson added a comment. - Remove redundant paragraph from the intro - Remove outdated bug fix bullet Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142578/new/ https://reviews.llvm.org/D142578

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

2023-01-28 Thread Chris Cotter via Phabricator via cfe-commits
ccotter updated this revision to Diff 493004. ccotter marked an inline comment as done. ccotter added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141569/new/ https://reviews.llvm.org/D141569 Files:

[PATCH] D142690: [libc++] Fixes the Clang modular build.

2023-01-28 Thread Mark de Wever via Phabricator via cfe-commits
Mordante added a comment. https://buildkite.com/llvm-project/libcxx-ci/builds/18148 shows this patch fixes the Clang modular build. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142690/new/ https://reviews.llvm.org/D142690

[PATCH] D142690: [DRAFT][libc++] Fixes the Clang modular build.

2023-01-28 Thread Mark de Wever via Phabricator via cfe-commits
Mordante updated this revision to Diff 492999. Mordante added a comment. Undo CI changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142690/new/ https://reviews.llvm.org/D142690 Files: libcxx/include/module.modulemap.in Index:

[PATCH] D142578: [Clang][Doc] Edit the Clang release notes

2023-01-28 Thread Thorsten via Phabricator via cfe-commits
tschuett added a comment. IDK. Clang 16 is fully is a fully conformant C++20 except for some DRs. Or beginning with Clang 16, we start a long-term project to overhaul the diagnostics. I agree that breaking changes are important. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D142578: [Clang][Doc] Edit the Clang release notes

2023-01-28 Thread Roy Jacobson via Phabricator via cfe-commits
royjacobson added a comment. In D142578#4087974 , @tschuett wrote: > I am not the only one who has a different background. If the introduction > says this is the introduction of the release notes, I am not super motivated > to read on. I would prefer

[clang] 3821391 - Fix Clang sphinx build

2023-01-28 Thread Aaron Ballman via cfe-commits
Author: Aaron Ballman Date: 2023-01-28T08:56:22-05:00 New Revision: 3821391847c4613d21295a53dcab30e6f92fe94c URL: https://github.com/llvm/llvm-project/commit/3821391847c4613d21295a53dcab30e6f92fe94c DIFF: https://github.com/llvm/llvm-project/commit/3821391847c4613d21295a53dcab30e6f92fe94c.diff

[PATCH] D138675: [flang] Add -ffast-math and -Ofast

2023-01-28 Thread Tom Eccles via Phabricator via cfe-commits
tblah marked an inline comment as done. tblah added inline comments. Comment at: flang/test/Driver/fast_math.f90:59-62 +! Check that -ffast-math causes us to link to crtfastmath.o +! UNSUPPORTED: system-windows +! RUN: %flang -ffast-math -### %s -o %t 2>&1 \ +! RUN: |

[PATCH] D142609: [Clang] Fix -Wconstant-logical-operand when LHS is a constant

2023-01-28 Thread Shivam Gupta via Phabricator via cfe-commits
xgupta updated this revision to Diff 492995. xgupta added a comment. update test cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142609/new/ https://reviews.llvm.org/D142609 Files: clang/lib/Sema/SemaExpr.cpp clang/test/C/drs/dr4xx.c

[PATCH] D142578: [Clang][Doc] Edit the Clang release notes

2023-01-28 Thread Thorsten via Phabricator via cfe-commits
tschuett added a comment. I am not the only who has a different background. If the introduction says this is the introduction of the release notes, I am not super motivated to read on. I would prefer to see some highlights to motivate the readers to continue reading. Repository: rG LLVM

[PATCH] D142578: [Clang][Doc] Edit the Clang release notes

2023-01-28 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang/docs/ReleaseNotes.rst:452-454 + - Now diagnoses use of a member access expression or array subscript expression within ``__builtin_offsetof`` and ``offsetof`` as being a Clang extension. aaron.ballman

[PATCH] D136886: [clang] ASTImporter: Fix importing of va_list types and declarations

2023-01-28 Thread Vince Bridgers via Phabricator via cfe-commits
vabridgers added a comment. @mizvekov, will you be picking this change up and finishing this, or do you mind if I have a go at finishing this patch? Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136886/new/ https://reviews.llvm.org/D136886

[PATCH] D142804: [clang-format] Support clang-format on/off line comments as prefixes

2023-01-28 Thread Björn Schäpers via Phabricator via cfe-commits
HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/Format.cpp:3901 + return Comment.startswith(Prefix) && + (Comment.size() == Size || isblank(Comment[Size])); +} rymiel wrote: > Should the space be required? What about `//

[PATCH] D134351: AArch64: add definitions for recent Apple CPUs

2023-01-28 Thread Valerii Zapodovnikov via Phabricator via cfe-commits
ValZapod added a comment. What do you mean by we do not have SM4? Apple CPU or clang? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134351/new/ https://reviews.llvm.org/D134351 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D142016: [Clang][RISCV] Simplify RVV intrinsic policy suffix

2023-01-28 Thread Yueh-Ting (eop) Chen via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd94a315ee3ec: [Clang][RISCV] Simplify RVV intrinsic policy suffix (authored by eopXD). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D142804: [clang-format] Support clang-format on/off line comments as prefixes

2023-01-28 Thread Emilia Dreamer via Phabricator via cfe-commits
rymiel added inline comments. Comment at: clang/lib/Format/Format.cpp:3901 + return Comment.startswith(Prefix) && + (Comment.size() == Size || isblank(Comment[Size])); +} Should the space be required? What about `// clang-format off: reasoning` or

[PATCH] D142804: [clang-format] Support clang-format on/off line comments as prefixes

2023-01-28 Thread Owen Pan via Phabricator via cfe-commits
owenpan created this revision. owenpan added reviewers: MyDeveloperDay, HazardyKnusperkeks, rymiel. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Closes

[PATCH] D14484: [clang-format] Formatting constructor initializer lists by putting them always on different lines

2023-01-28 Thread Owen Pan via Phabricator via cfe-commits
owenpan added a comment. In D14484#4087879 , @HantaoPan wrote: > Thank you! Is there a similar flag wrt function parameter? (say a "Never" > other than "false", which can always put each function parameter on its own > line.) Nope. Repository: rL

[PATCH] D14484: [clang-format] Formatting constructor initializer lists by putting them always on different lines

2023-01-28 Thread Hantao Pan via Phabricator via cfe-commits
HantaoPan added a comment. In D14484#4087827 , @owenpan wrote: > In D14484#4079711 , @HantaoPan wrote: > >> Hi, >> I am interesting in this feature too. You know, consistency is crucial to a >> large program... >>

[PATCH] D142800: [Clang][Diagnostic] Add `-Wcomparison-op-parentheses` to warn on chained comparisons

2023-01-28 Thread Takuya Shimizu via Phabricator via cfe-commits
hazohelet updated this revision to Diff 492986. hazohelet added a comment. Fix the new warning issued against libcxx test code. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142800/new/ https://reviews.llvm.org/D142800 Files: clang/docs/ReleaseNotes.rst

[clang] 5c9013e - Use std::optional instead of llvm::Optional (NFC)

2023-01-28 Thread Kazu Hirata via cfe-commits
Author: Kazu Hirata Date: 2023-01-28T00:45:19-08:00 New Revision: 5c9013e2664141d3b4071c37b3cbb8cd09a008d8 URL: https://github.com/llvm/llvm-project/commit/5c9013e2664141d3b4071c37b3cbb8cd09a008d8 DIFF: https://github.com/llvm/llvm-project/commit/5c9013e2664141d3b4071c37b3cbb8cd09a008d8.diff