[PATCH] D143546: [clang-format] Insert a space between a numeric UDL and a dot

owenpan added a comment. In D143546#4111827 , @rymiel wrote: > I've been sniped! (but only because i spent hours discussing with people if > the error is pedantically valid, which it turns out it is) I was wondering why you didn't assign yourself. :)

[PATCH] D143439: [RISCV] Add vendor-defined XTheadBb (basic bit-manipulation) extension

philipp.tomsich reopened this revision. philipp.tomsich added a comment. Reopening as this was accidentially pushed and reverted when doing 'arc patch on D143534 '. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D143553: [Clang][CMake] Add BOLT perf-training (WIP)

Amir created this revision. Amir added a reviewer: phosek. Herald added a subscriber: wenlei. Herald added a project: All. Amir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Remove the bootstrapped build for BOLT profile collection.

[PATCH] D143197: [clangd] Patch includes even without any changes

sammccall added a comment. Code looks reasonable, but I don't understand why the changes are being made - can you explain/link to a bug in the commit message? Comment at: clang-tools-extra/clangd/Preamble.cpp:688 if (It != ExistingIncludes.end()) { -

[PATCH] D142890: [clangd] Add config option for fast diagnostics mode

sammccall added a comment. The code looks good, but I have a very hard time following the tests. Comment at: clang-tools-extra/clangd/unittests/PreambleTests.cpp:225 auto TU = TestTU::withCode(Modified); + TU.AdditionalFiles = std::move(AdditionalFiles); auto CI =

[PATCH] D143418: [libclang] Add API to set preferred temp dir path

vedgy added a comment. I hoped to avoid applying an unrelated `git clang-format`'s include reordering, but the CI fails because of that. Will apply it along with changes requested during code review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D137980: [ARM] Pretend atomics are always lock-free for small widths.

efriedma added a comment. Herald added a subscriber: StephenFan. Any further comment on this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137980/new/ https://reviews.llvm.org/D137980 ___ cfe-commits

[PATCH] D142932: [NFC] Multilib YAML parsing

phosek added a comment. Do you know if regular expressions are necessary to cover the existing use cases? In our experience, while regular expressions are powerful, they also tend to be error prone and more difficult to reason about. Would glob patterns that are implemented by

[PATCH] D143549: [clang][AIX] Remove test for the default OpenMP runtime

pcwang-thead created this revision. pcwang-thead added reviewers: xingxue, daltenty, jdoerfert. Herald added subscribers: guansong, yaxunl. Herald added a project: All. pcwang-thead requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang.

[PATCH] D139395: Add CFI integer types normalization

rcvalle updated this revision to Diff 495718. rcvalle added a comment. Fixed use of uninitialized value Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139395/new/ https://reviews.llvm.org/D139395 Files: clang/docs/ControlFlowIntegrity.rst

[clang] d768b97 - [Support] change StringMap hash function from djbHash to xxHash

Author: Erik Desjardins Date: 2023-02-07T22:55:41-05:00 New Revision: d768b97424f9e1a0aae45440a18b99f21c4027ce URL: https://github.com/llvm/llvm-project/commit/d768b97424f9e1a0aae45440a18b99f21c4027ce DIFF:

[PATCH] D142862: [Support] change StringMap hash function from djbHash to xxHash

This revision was automatically updated to reflect the committed changes. Closed by commit rGd768b97424f9: [Support] change StringMap hash function from djbHash to xxHash (authored by erikdesjardins). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D141098: [clang-format][NFC] Set LineEnding to LF in config files

sunho added a comment. I think it makes more sense to use stable version of clang-format for that purpose but I'm not in a postion to decide as I don't work with format. Can you change the script to use latest clang-format for format codebase and revert this patch in the meantime? Currently,

[PATCH] D135341: [clang] adds `__reference_constructs_from_temporary`

cjdb added a comment. In D135341#4111673 , @ldionne wrote: > I've been looking at implementing `reference_constructs_from_temporary` & > friends and this would be sweet to have. Is this blocked on something > specific? This trait should be ready to

[PATCH] D142893: [NFC] Class for building MultilibSet

phosek added inline comments. Comment at: clang/include/clang/Driver/Multilib.h:35-39 std::string GCCSuffix; std::string OSSuffix; std::string IncludeSuffix; flags_list Flags; int Priority; Since this class is intended to be immutable, we should

[PATCH] D141098: [clang-format][NFC] Set LineEnding to LF in config files

owenpan added a comment. In D141098#4111830 , @sunho wrote: > Wouldn't that mean llvm contributors have to format their code using > clang-format built from top-of-tree source code before submitting the patch? Only if the patch is to clang-format

[clang] 472393e - [Clang] Disable building tools for 32-bit hosts as well

Author: Joseph Huber Date: 2023-02-07T21:18:50-06:00 New Revision: 472393eff45002f60826f04fcc9261eeaa9f8691 URL: https://github.com/llvm/llvm-project/commit/472393eff45002f60826f04fcc9261eeaa9f8691 DIFF: https://github.com/llvm/llvm-project/commit/472393eff45002f60826f04fcc9261eeaa9f8691.diff

[PATCH] D139741: [clang][CodeGen] Use base subobject type layout for potentially-overlapping fields

efriedma added inline comments. Comment at: clang/lib/CodeGen/CGRecordLayoutBuilder.cpp:370 + const auto StorageAlignment = getAlignment(StorageType); + if (LayoutSize % StorageAlignment || Layout.getDataSize() % StorageAlignment) Packed = true;

[PATCH] D141098: [clang-format][NFC] Set LineEnding to LF in config files

sunho added a comment. Wouldn't that mean llvm contributors have to format their code using clang-format built from top-of-tree source code before submitting the patch? Technically that script is for checking if the code has been formatted correctly. Repository: rG LLVM Github Monorepo

[PATCH] D143546: [clang-format] Insert a space between a numeric UDL and a dot

rymiel accepted this revision. rymiel added a comment. This revision is now accepted and ready to land. I've been sniped! (but only because i spent hours discussing with people if the error is pedantically valid, which it turns out it is) Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D143546: [clang-format] Insert a space between a numeric UDL and a dot

owenpan created this revision. owenpan added reviewers: MyDeveloperDay, HazardyKnusperkeks, rymiel. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes

[PATCH] D141098: [clang-format][NFC] Set LineEnding to LF in config files

owenpan added a comment. In D141098#4108286 , @sunho wrote: > I think buildbot is "formatting" the patch using clang-format-15. The tests > of clang-format would be done with latest code. Can we just fix the buildbot so that it runs git-clang-format

[PATCH] D143319: [clangd] Support iwyu pragma: no_include

zyounan added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143319/new/ https://reviews.llvm.org/D143319 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D135341: [clang] adds `__reference_constructs_from_temporary`

ldionne added a comment. I've been looking at implementing `reference_constructs_from_temporary` & friends and this would be sweet to have. Is this blocked on something specific? Comment at: clang/include/clang/Basic/DiagnosticCommonKinds.td:397 +def

[PATCH] D131230: [RISCV] Allow mismatched SmallDataLimit and use Min for conflicting values

MaskRay added a comment. I updated more `i32 1, !"SmallDataLimit"` and re-landed this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131230/new/ https://reviews.llvm.org/D131230 ___ cfe-commits

[PATCH] D131230: [RISCV] Allow mismatched SmallDataLimit and use Min for conflicting values

This revision was automatically updated to reflect the committed changes. Closed by commit rGaf1287914648: [RISCV] Allow mismatched SmallDataLimit and use Min for conflicting values (authored by MaskRay). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[clang] af12879 - [RISCV] Allow mismatched SmallDataLimit and use Min for conflicting values

Author: Fangrui Song Date: 2023-02-07T17:13:21-08:00 New Revision: af128791464810123bcd60a6d9d0902b5c550aef URL: https://github.com/llvm/llvm-project/commit/af128791464810123bcd60a6d9d0902b5c550aef DIFF: https://github.com/llvm/llvm-project/commit/af128791464810123bcd60a6d9d0902b5c550aef.diff

[clang] 9aa00c8 - Revert "[-Wunsafe-buffer-usage] Add unsafe buffer checking opt-out pragmas"

Author: Ziqing Luo Date: 2023-02-07T17:06:20-08:00 New Revision: 9aa00c8a306561c4e3ddb09058e66bae322a0769 URL: https://github.com/llvm/llvm-project/commit/9aa00c8a306561c4e3ddb09058e66bae322a0769 DIFF: https://github.com/llvm/llvm-project/commit/9aa00c8a306561c4e3ddb09058e66bae322a0769.diff

[clang] aef05b5 - [-Wunsafe-buffer-usage] Add unsafe buffer checking opt-out pragmas

Author: Ziqing Luo Date: 2023-02-07T16:54:39-08:00 New Revision: aef05b5dc5c566bcaa15b66c989ccb8d2841ac71 URL: https://github.com/llvm/llvm-project/commit/aef05b5dc5c566bcaa15b66c989ccb8d2841ac71 DIFF: https://github.com/llvm/llvm-project/commit/aef05b5dc5c566bcaa15b66c989ccb8d2841ac71.diff

[PATCH] D140179: [-Wunsafe-buffer-usage] Add unsafe buffer checking opt-out pragmas

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaef05b5dc5c5: [-Wunsafe-buffer-usage] Add unsafe buffer checking opt-out pragmas (authored by ziqingluo-90). Changed prior to commit:

[PATCH] D141338: [-Wunsafe-buffer-usage] Filter out conflicting fix-its

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG692da6245d71: [-Wunsafe-buffer-usage] Filter out conflicting fix-its (authored by ziqingluo-90). Changed prior to commit:

[clang] 692da62 - [-Wunsafe-buffer-usage] Filter out conflicting fix-its

Author: Ziqing Luo Date: 2023-02-07T16:15:28-08:00 New Revision: 692da6245d719fcee9d55936a021d9f9e301c557 URL: https://github.com/llvm/llvm-project/commit/692da6245d719fcee9d55936a021d9f9e301c557 DIFF: https://github.com/llvm/llvm-project/commit/692da6245d719fcee9d55936a021d9f9e301c557.diff

[PATCH] D143533: [clang] Allow gnu::aligned attribute to work with templated type alias declarations

leonardchan created this revision. leonardchan added reviewers: rsmith, rnk, echristo. leonardchan added a project: clang. Herald added a subscriber: jeroen.dobbelaere. Herald added a project: All. leonardchan requested review of this revision. Prior to this, the following would fail: template

[clang] bdf4f2b - [-Wunsafe-buffer-usage] Generate fix-it for local variable declarations

Author: Ziqing Luo Date: 2023-02-07T15:40:19-08:00 New Revision: bdf4f2bea50e87f5b9273e3bbc9a7753bca3a6bb URL: https://github.com/llvm/llvm-project/commit/bdf4f2bea50e87f5b9273e3bbc9a7753bca3a6bb DIFF: https://github.com/llvm/llvm-project/commit/bdf4f2bea50e87f5b9273e3bbc9a7753bca3a6bb.diff

[PATCH] D142933: Add -print-multi-selection-flags argument

michaelplatings added inline comments. Comment at: clang/include/clang/Driver/Options.td:4162 def print_multi_lib : Flag<["-", "--"], "print-multi-lib">; +def print_multi_selection_flags : Flag<["-", "--"], "print-multi-selection-flags-experimental">, + HelpText<"Print the

[PATCH] D142986: Enable multilib.yaml in the BareMetal ToolChain

michaelplatings updated this revision to Diff 495658. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142986/new/ https://reviews.llvm.org/D142986 Files: clang/lib/Driver/ToolChain.cpp

[PATCH] D142933: Add -print-multi-selection-flags argument

michaelplatings updated this revision to Diff 495656. michaelplatings marked 6 inline comments as done. michaelplatings added a comment. Apply improvements suggested by @peter.smith Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142933/new/

[PATCH] D140565: [Clang][CMake] Set up distribution target for Clang-BOLT

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG42129deaa67b: [Clang][CMake] Set up distribution target for Clang-BOLT (authored by Amir). Changed prior to commit:

[clang] 42129de - [Clang][CMake] Set up distribution target for Clang-BOLT

Author: Amir Ayupov Date: 2023-02-07T15:06:15-08:00 New Revision: 42129deaa67b6c4b8fc82feb74b7e9fe25c99073 URL: https://github.com/llvm/llvm-project/commit/42129deaa67b6c4b8fc82feb74b7e9fe25c99073 DIFF: https://github.com/llvm/llvm-project/commit/42129deaa67b6c4b8fc82feb74b7e9fe25c99073.diff

[PATCH] D143109: [Sema] Push a LambdaScopeInfo before calling SubstDefaultArgument

tahonermann added a comment. Thanks for the update, @ahatanak. Please note that myself and Corentin are both preoccupied with the WG21 meeting this week, so it might be a while before either of us is able to take a good look at your update. Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 622be09 - Revert "[-Wunsafe-buffer-usage] Generate fix-it for local variable declarations"

Author: Ziqing Luo Date: 2023-02-07T14:47:43-08:00 New Revision: 622be09c815266632e204eaf1c7a35f050220459 URL: https://github.com/llvm/llvm-project/commit/622be09c815266632e204eaf1c7a35f050220459 DIFF: https://github.com/llvm/llvm-project/commit/622be09c815266632e204eaf1c7a35f050220459.diff

[PATCH] D143233: [Clang][CodeGen] Fix this argument type for certain destructors

jacobly updated this revision to Diff 495648. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143233/new/ https://reviews.llvm.org/D143233 Files: clang/lib/CodeGen/CGCXXABI.h clang/lib/CodeGen/CGCall.cpp clang/lib/CodeGen/CGExprCXX.cpp

[PATCH] D143529: [M68k] Add support for basic memory constraints in inline asm

myhsu created this revision. myhsu added reviewers: 0x59616e, RKSimon, nickdesaulniers. Herald added a subscriber: hiraditya. Herald added a project: All. myhsu requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This patch

[PATCH] D142826: [Clang] Add -Wtype-limits to -Wextra for GCC compatibility

haowei added a comment. There are also cases that this clang type-limit check will warn when checking if a enum type is larger than 0. For example, we are seeing warnings on ICU source code

[PATCH] D143233: [Clang][CodeGen] Fix this argument type for certain destructors

jacobly updated this revision to Diff 495645. jacobly added a comment. Cleanup and minor fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143233/new/ https://reviews.llvm.org/D143233 Files: clang/lib/CodeGen/CGCXXABI.h

[PATCH] D142584: [CodeGen] Add a boolean flag to `Address::getPointer` and `Lvalue::getPointer` that indicates whether the pointer is known not to be null

efriedma added a comment. The approach here makes sense. Comment at: clang/lib/CodeGen/Address.h:65 : Pointer(Pointer), ElementType(ElementType) { if (Alignment.isZero()) return; Do you need to do something with IsKnownNonNull in the

[PATCH] D143399: [Tooling/Inclusion] Move the generated mapping .inc file to private places.

hokein added a comment. In D143399#4111235 , @hokein wrote: > In D143399#4110806 , @augusto2112 > wrote: > >> Hi @hokein, this broke the LLDB incremental build >>

[PATCH] D143399: [Tooling/Inclusion] Move the generated mapping .inc file to private places.

hokein added a comment. In D143399#4110806 , @augusto2112 wrote: > Hi @hokein, this broke the LLDB incremental build > (https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/50629/console). > How do we fix it? sorry for the breakage. Could you

[PATCH] D131230: [RISCV] Allow mismatched SmallDataLimit and use Min for conflicting values

hiraditya updated this revision to Diff 495641. hiraditya added a comment. Updated the failing testcase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131230/new/ https://reviews.llvm.org/D131230 Files: clang/lib/CodeGen/CodeGenModule.cpp

[PATCH] D131230: [RISCV] Allow mismatched SmallDataLimit and use Min for conflicting values

hiraditya reopened this revision. hiraditya added a comment. This revision is now accepted and ready to land. Herald added a subscriber: jobnoorman. reopening to update the failing testcase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131230/new/

[clang] 4cbf4bb - Remove textual headers from module map

Author: Adrian Prantl Date: 2023-02-07T13:24:47-08:00 New Revision: 4cbf4bb4dd17b813179467396c692180681cb003 URL: https://github.com/llvm/llvm-project/commit/4cbf4bb4dd17b813179467396c692180681cb003 DIFF: https://github.com/llvm/llvm-project/commit/4cbf4bb4dd17b813179467396c692180681cb003.diff

[PATCH] D139737: [-Wunsafe-buffer-usage] Initiate Fix-it generation for local variable declarations

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa29e67614c3b: [-Wunsafe-buffer-usage] Generate fix-it for local variable declarations (authored by ziqingluo-90). Changed prior to commit:

[clang] a29e676 - [-Wunsafe-buffer-usage] Generate fix-it for local variable declarations

Author: Ziqing Luo Date: 2023-02-07T13:17:44-08:00 New Revision: a29e67614c3b7018287e5f68c57bba7618aa880e URL: https://github.com/llvm/llvm-project/commit/a29e67614c3b7018287e5f68c57bba7618aa880e DIFF: https://github.com/llvm/llvm-project/commit/a29e67614c3b7018287e5f68c57bba7618aa880e.diff

[PATCH] D143524: Make the -Wunused-template default.

v.g.vassilev created this revision. v.g.vassilev added reviewers: aaron.ballman, ldionne. Herald added a project: All. v.g.vassilev requested review of this revision. https://reviews.llvm.org/D29877 implements a useful -Wunused-template diagnostic detects unused internal linkage templates. This

[PATCH] D141910: [OpenMP][OMPIRBuilder]Move SIMD alignment calculation to LLVM Frontend

akyrtzi added a comment. In D141910#4111048 , @domada wrote: > Added changes in `clang/lib/AST/CMakeLists.txt` to address build issue > reported by @akyrtzi . > > I modified CMakeLists.txt so that it requires generation of missing > `Attributes.inc`. >

[PATCH] D143109: [Sema] Push a LambdaScopeInfo before calling SubstDefaultArgument

ahatanak added a comment. I agree that pushing an empty scope without initializing any of its members seems wrong. Instead of doing that, the updated patch changes the decl context instead if we are trying to capture a variable in a default argument expression of a lambda call operator. I

[PATCH] D141910: [OpenMP][OMPIRBuilder]Move SIMD alignment calculation to LLVM Frontend

domada updated this revision to Diff 495627. domada added a comment. Patch rebased CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141910/new/ https://reviews.llvm.org/D141910 Files: clang/include/clang/Basic/TargetInfo.h clang/lib/AST/ASTContext.cpp clang/lib/AST/CMakeLists.txt

[PATCH] D140584: [Clang] Refactor "Designators" into a unified implementation [NFC]

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG3c07db5f58e9: [Clang] Refactor Designators into a unified implementation [NFC] (authored by void). Repository: rG LLVM

[clang-tools-extra] 3c07db5 - [Clang] Refactor "Designators" into a unified implementation [NFC]

Author: Bill Wendling Date: 2023-02-07T12:59:17-08:00 New Revision: 3c07db5f58e9852f35202f0fffed50fc7506f37b URL: https://github.com/llvm/llvm-project/commit/3c07db5f58e9852f35202f0fffed50fc7506f37b DIFF: https://github.com/llvm/llvm-project/commit/3c07db5f58e9852f35202f0fffed50fc7506f37b.diff

[PATCH] D141910: [OpenMP][OMPIRBuilder]Move SIMD alignment calculation to LLVM Frontend

domada updated this revision to Diff 495609. domada added a reviewer: akyrtzi. domada added a comment. Added changes in `clang/lib/AST/CMakeLists.txt` to address build issue reported by @akyrtzi . I modified CMakeLists.txt so that it requires generation of missing `Attributes.inc`. @akyrtzi

[PATCH] D143109: [Sema] Push a LambdaScopeInfo before calling SubstDefaultArgument

ahatanak updated this revision to Diff 495619. ahatanak added a comment. Fix indentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143109/new/ https://reviews.llvm.org/D143109 Files: clang/lib/Sema/SemaExpr.cpp

[PATCH] D143386: Add function pointer alignment to DataLayout

efriedma added a comment. In D143386#4110398 , @gchatelet wrote: >> And the x86 doesn't specify 4-byte alignment. > > I thought that specifying it in the `DataLayout` would help getting rid of > the special handling in ConstantFold >

[PATCH] D143109: [Sema] Push a LambdaScopeInfo before calling SubstDefaultArgument

ahatanak updated this revision to Diff 495615. ahatanak marked an inline comment as done. ahatanak added a comment. Instead of pushing an empty lambda scope, switch to the enclosing context if the variable is used in a default argument expression of a lambda call operator. Repository: rG

[PATCH] D142630: [clang][Interp] Implement virtual function calls

aaron.ballman added a comment. In D142630#4110839 , @tbaeder wrote: > Hmm, this doesn't work if the callee is somewhere in between the path from > the dynamic to the static type, e.g. > > struct A { > virtual constexpr int foo() const { return 1;

[PATCH] D143207: Add codegen for llvm log2/log10 elementwise builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rG836249b1c2f0: Add codegen for llvm log2/log10 elementwise builtins (authored by bob80905). Changed prior to commit: https://reviews.llvm.org/D143207?vs=494477=495612#toc Repository: rG LLVM Github

[clang] 836249b - Add codegen for llvm log2/log10 elementwise builtins

Author: Joshua Batista Date: 2023-02-07T12:23:48-08:00 New Revision: 836249b1c2f0540ed0c886d6c3558b2f4f179249 URL: https://github.com/llvm/llvm-project/commit/836249b1c2f0540ed0c886d6c3558b2f4f179249 DIFF:

[PATCH] D143287: [Clang][x86] Change x86 cast intrinsics to use __builtin_nondeterministic_value

ManuelJBrito updated this revision to Diff 495611. ManuelJBrito added a comment. Add end to end tests Currrently these expect a mov that will be removed when the instcombine bug is fixed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143287/new/

[PATCH] D143287: [Clang][x86] Change x86 cast intrinsics to use __builtin_nondeterministic_value

ManuelJBrito added a comment. In D143287#4108165 , @craig.topper wrote: > In D143287#4107439 , @ManuelJBrito > wrote: > >> In D143287#4103597 , @craig.topper >> wrote:

[PATCH] D143021: [OpenMP 5.2] Deprecate 'destroy' clause without argument for 'depobj' construct

This revision was automatically updated to reflect the committed changes. Closed by commit rGe716b0204a5a: [OpenMP 5.2] Deprecate destroy clause without argument for depobj construct (authored by mdfazlay, committed by mikerice). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] e716b02 - [OpenMP 5.2] Deprecate 'destroy' clause without argument for 'depobj' construct

Author: Fazlay Rabbi Date: 2023-02-07T12:09:52-08:00 New Revision: e716b0204a5ae2a96289a335b2ab30a6c3fb09cf URL: https://github.com/llvm/llvm-project/commit/e716b0204a5ae2a96289a335b2ab30a6c3fb09cf DIFF: https://github.com/llvm/llvm-project/commit/e716b0204a5ae2a96289a335b2ab30a6c3fb09cf.diff

[clang] d27fb5e - [Serialization] Add support for (de)serializing #pragma pack

Author: Dustin Howett Date: 2023-02-07T11:37:02-08:00 New Revision: d27fb5efc5f2086fa157e7d836b61bae4d5f3734 URL: https://github.com/llvm/llvm-project/commit/d27fb5efc5f2086fa157e7d836b61bae4d5f3734 DIFF: https://github.com/llvm/llvm-project/commit/d27fb5efc5f2086fa157e7d836b61bae4d5f3734.diff

[PATCH] D143410: [Serialization] Add support for (de)serializing #pragma pack

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd27fb5efc5f2: [Serialization] Add support for (de)serializing #pragma pack (authored by DHowett-MSFT, committed by mikerice). Changed prior to

[PATCH] D143410: [Serialization] Add support for (de)serializing #pragma pack

DHowett-MSFT added a comment. Thanks for the review! I’ll need somebody to help land this, as I don’t have write access to the project. :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143410/new/ https://reviews.llvm.org/D143410

[PATCH] D142630: [clang][Interp] Implement virtual function calls

tbaeder added a comment. Hmm, this doesn't work if the callee is somewhere in between the path from the dynamic to the static type, e.g. struct A { virtual constexpr int foo() const { return 1; } }; struct B : A { virtual constexpr int foo() const { return A::foo(); } };

[PATCH] D143399: [Tooling/Inclusion] Move the generated mapping .inc file to private places.

augusto2112 added a comment. Hi @hokein, this broke the LLDB incremental build (https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/50629/console). How do we fix it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143399/new/

[PATCH] D127910: [Clang][AArch64][SME] Add vector load/store (ld1/st1) intrinsics

bryanpkc updated this revision to Diff 495592. bryanpkc marked 4 inline comments as done. bryanpkc added a comment. Rebased on trunk and addressed review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127910/new/

[PATCH] D143439: [RISCV] Add vendor-defined XTheadBb (basic bit-manipulation) extension

philipp.tomsich added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:318 +if (Subtarget.is64Bit()) + setOperationAction({ISD::CTLZ, ISD::CTLZ_ZERO_UNDEF}, MVT::i32, Custom); + } craig.topper wrote: > without these two lines to

[PATCH] D127910: [Clang][AArch64][SME] Add vector load/store (ld1/st1) intrinsics

bryanpkc marked 9 inline comments as done. bryanpkc added inline comments. Comment at: clang/include/clang/Basic/TargetBuiltins.h:312 + /// Flags to identify the types for overloaded SME builtins. + class SMETypeFlags { +uint64_t Flags; david-arm wrote: >

[PATCH] D137753: [Clang][AIX][p]Enable -p Functionality

francii updated this revision to Diff 495588. francii added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137753/new/ https://reviews.llvm.org/D137753 Files: clang/include/clang/Driver/Options.td

[PATCH] D143439: [RISCV] Add vendor-defined XTheadBb (basic bit-manipulation) extension

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:318 +if (Subtarget.is64Bit()) + setOperationAction({ISD::CTLZ, ISD::CTLZ_ZERO_UNDEF}, MVT::i32, Custom); + } without these two lines to promote i32, I suppose

[PATCH] D143410: [Serialization] Add support for (de)serializing #pragma pack

mikerice accepted this revision. mikerice added a comment. This revision is now accepted and ready to land. LGTM. Thanks for taking care of this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143410/new/ https://reviews.llvm.org/D143410

[PATCH] D143427: [clang] NFC: Remove GCC 5.1 workaround in FileEntry

This revision was automatically updated to reflect the committed changes. Closed by commit rG5e14a48463b4: [clang] NFC: Remove GCC 5.1 workaround in FileEntry (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143427/new/

[clang] 5e14a48 - [clang] NFC: Remove GCC 5.1 workaround in FileEntry

Author: Jan Svoboda Date: 2023-02-07T09:27:24-08:00 New Revision: 5e14a48463b4c3eb3f36eeef30dee7312f9127da URL: https://github.com/llvm/llvm-project/commit/5e14a48463b4c3eb3f36eeef30dee7312f9127da DIFF: https://github.com/llvm/llvm-project/commit/5e14a48463b4c3eb3f36eeef30dee7312f9127da.diff

[PATCH] D143428: [clang][deps] Fix race condition

This revision was automatically updated to reflect the committed changes. Closed by commit rG152f2914607f: [clang][deps] Fix race condition (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143428/new/

[clang] 152f291 - [clang][deps] Fix race condition

Author: Jan Svoboda Date: 2023-02-07T09:26:56-08:00 New Revision: 152f2914607ffe632202ee660208d6dfba6c8870 URL: https://github.com/llvm/llvm-project/commit/152f2914607ffe632202ee660208d6dfba6c8870 DIFF: https://github.com/llvm/llvm-project/commit/152f2914607ffe632202ee660208d6dfba6c8870.diff

[PATCH] D143495: [AMDGPU ASAN] Remove reference to asan bitcode library

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143495/new/ https://reviews.llvm.org/D143495

[PATCH] D143446: [clang][deps] Ensure module invocation can be serialized

benlangmuir updated this revision to Diff 495573. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143446/new/ https://reviews.llvm.org/D143446 Files: clang/include/clang/Frontend/CompilerInvocation.h clang/lib/Basic/LangOptions.cpp clang/lib/Frontend/CompilerInvocation.cpp

[PATCH] D137756: [z/OS][pg] Throw error when using -pg on z/OS

francii updated this revision to Diff 495570. francii added a comment. Update test case verbosity Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137756/new/ https://reviews.llvm.org/D137756 Files: clang/lib/Driver/ToolChains/Clang.cpp

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

jdoerfert added a comment. Please avoid the MLIR style in any other subproject. I know some of the OpenMP Builder stuff already uses `llvm::` and MLIR style names, but that is in itself bad, not something we should extend. Comment at:

[PATCH] D143509: Move the BySpelling map to IncludeStructure.

VitaNuo created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. VitaNuo requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D143461: [ClangScanDeps] Fix data race in `clang-scan-deps` tool

akyrtzi abandoned this revision. akyrtzi added a comment. In D143461#4110405 , @benlangmuir wrote: > Dupe of https://reviews.llvm.org/D143428 ? Indeed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D143507: [RISCV][MC] Mark Zawrs extension as non-experimental

asb created this revision. asb added reviewers: reames, craig.topper. Herald added subscribers: jobnoorman, luke, wingo, pmatos, VincentWu, vkmr, frasercrmck, jdoerfert, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck,

[PATCH] D143414: [clang] refactor FileManager::GetUniqueIDMapping

benlangmuir added a comment. > This should allow the path serialization of input files to use the paths used > when looking up a file entry, instead of the last reference. Isn't this at odds with not having the VFS-mapped paths? It's not obvious to me why we want these specific semantics.

[PATCH] D143075: BareMetal ToolChain multilib layering

michaelplatings updated this revision to Diff 495559. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143075/new/ https://reviews.llvm.org/D143075 Files: clang/lib/Driver/ToolChains/BareMetal.cpp

[PATCH] D143059: [NFC] Enable selecting multiple multilibs

michaelplatings updated this revision to Diff 495558. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143059/new/ https://reviews.llvm.org/D143059 Files: clang/include/clang/Driver/Multilib.h

[PATCH] D143461: [ClangScanDeps] Fix data race in `clang-scan-deps` tool

benlangmuir added a comment. Dupe of https://reviews.llvm.org/D143428 ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143461/new/ https://reviews.llvm.org/D143461 ___ cfe-commits mailing list

[PATCH] D142986: Enable multilib.yaml in the BareMetal ToolChain

michaelplatings updated this revision to Diff 495557. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142986/new/ https://reviews.llvm.org/D142986 Files: clang/lib/Driver/ToolChain.cpp

[PATCH] D143386: Add function pointer alignment to DataLayout

gchatelet added a comment. Herald added a subscriber: jobnoorman. In D143386#4107144 , @efriedma wrote: > Almost all the specifications you're specifying are wrong. Very few targets > should be using "i". Off the top of my head, 32-bit ARM, MIPS

[PATCH] D143493: [flang][driver] Add support for -include flag in flang -fc1

skatrak added a comment. In D143493#4110323 , @awarzynski wrote: > In D143493#4110272 , @skatrak wrote: > >> It is introduced to the arguments list in `Clang::AddPreprocessingOptions` >> in certain cases to add

[PATCH] D142933: Add -print-multi-selection-flags argument

michaelplatings updated this revision to Diff 49. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142933/new/ https://reviews.llvm.org/D142933 Files: clang/include/clang/Driver/Options.td

  1   2   >