[PATCH] D142316: [clang] Add test for CWG2396

Endill updated this revision to Diff 496849. Endill added a comment. Remove two examples with `identity` for reasons explained in D142316#4121079 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142316/new/

[PATCH] D143867: [analyzer] Fix SARIF column location assertion crash

steakhal added a comment. In D143867#4121874 , @Scarlet1ssimo wrote: >> The test passes on main. Are you sure about the reproducer? > > This happens on versions from release/10.x to release/15.x. Since 16.x, this > file gets refactored and no such

[PATCH] D138037: [analyzer] Remove unjustified assertion from EQClass::simplify

steakhal added a comment. I would also suggest backporting this to the `release/16.x` branch as that has already branched off. WDYT? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138037/new/ https://reviews.llvm.org/D138037

[PATCH] D143867: [analyzer] Fix SARIF column location assertion crash

Scarlet1ssimo added a comment. > The test passes on main. Are you sure about the reproducer? This happens on versions from release/10.x to release/15.x Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143867/new/ https://reviews.llvm.org/D143867

[PATCH] D138037: [analyzer] Remove unjustified assertion from EQClass::simplify

steakhal added a comment. @NoQ @xazax.hun I plan to merge this by the end of the week if you have no objection. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138037/new/ https://reviews.llvm.org/D138037

[PATCH] D143867: [analyzer] Fix SARIF column location assertion crash

steakhal added a comment. In D143867#4121841 , @Scarlet1ssimo wrote: > In D143867#4121835 , @steakhal > wrote: > >> Looks sensible to me. >> Do you have a test for triggering the previous assertion? > > I do

[PATCH] D143867: [analyzer] Fix SARIF column location assertion crash

Scarlet1ssimo added a comment. In D143867#4121835 , @steakhal wrote: > Looks sensible to me. > Do you have a test for triggering the previous assertion? I do have prepared a test case like: int testA(void) { return 0/0; } // RUN: %clang_analyze_cc1

[PATCH] D143867: [analyzer] Fix SARIF column location assertion crash

steakhal added a comment. Looks sensible to me. Do you have a test for triggering the previous assertion? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143867/new/ https://reviews.llvm.org/D143867 ___

[PATCH] D143851: [clang-tidy] Tweak 'rule of 3/5' checks to allow defaulting a destructor outside the class.

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/cppcoreguidelines/special-member-functions.rst:28 - When set to `true` (default is `false`), this check doesn't flag classes with a sole, explicitly - defaulted destructor. An

[PATCH] D142592: [clang-tidy][libc] Add an inline function checker for the libc project.

This revision was automatically updated to reflect the committed changes. Closed by commit rGb7b28c6cfe04: [clang-tidy][libc] Add an inline function checker for the libc project. (authored by sivachandra). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] b7b28c6 - [clang-tidy][libc] Add an inline function checker for the libc project.

Author: Siva Chandra Reddy Date: 2023-02-13T06:03:36Z New Revision: b7b28c6cfe04b8ca59dec0f2e2b9b7493c1c71d3 URL: https://github.com/llvm/llvm-project/commit/b7b28c6cfe04b8ca59dec0f2e2b9b7493c1c71d3 DIFF: https://github.com/llvm/llvm-project/commit/b7b28c6cfe04b8ca59dec0f2e2b9b7493c1c71d3.diff

[PATCH] D143877: [NFC] [clang] Forward forwarding reference

ccotter created this revision. Herald added a project: All. ccotter requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Update function bodies to forward forwarding references. I spotted this while authoring a clang-tidy tool for

[clang] 64287d6 - Recommit [C++20] [Modules] [ClangScanDeps] Enable to print make-style dependency file within P1689 format (4/4)

Author: Chuanqi Xu Date: 2023-02-13T11:26:34+08:00 New Revision: 64287d69827c1d05edf8142742f6beb293d031fc URL: https://github.com/llvm/llvm-project/commit/64287d69827c1d05edf8142742f6beb293d031fc DIFF: https://github.com/llvm/llvm-project/commit/64287d69827c1d05edf8142742f6beb293d031fc.diff

[clang] 212d905 - Recommit [C++20] [Modules] [ClangScanDeps] Allow clang-scan-deps to without specified compilation database in P1689 (3/4)

Author: Chuanqi Xu Date: 2023-02-13T11:01:24+08:00 New Revision: 212d905643bd9cf6f80175c774ba7ab831c89e46 URL: https://github.com/llvm/llvm-project/commit/212d905643bd9cf6f80175c774ba7ab831c89e46 DIFF: https://github.com/llvm/llvm-project/commit/212d905643bd9cf6f80175c774ba7ab831c89e46.diff

[PATCH] D127910: [Clang][AArch64][SME] Add vector load/store (ld1/st1) intrinsics

bryanpkc added inline comments. Comment at: clang/lib/Headers/CMakeLists.txt:332 + # Generate arm_sme.h + clang_generate_header(-gen-arm-sme-header arm_sme.td arm_sme.h) # Generate arm_bf16.h sdesmalen wrote: > The ACLE specification is still in a draft

[clang] eb70b38 - Recommit [C++20] [Modules] [ClangScanDeps] Add ClangScanDeps support for C++20 Named Modules in P1689 format (2/4)

Author: Chuanqi Xu Date: 2023-02-13T10:42:35+08:00 New Revision: eb70b38f838f6a3511dcbbc33f3ee81a4d05ede1 URL: https://github.com/llvm/llvm-project/commit/eb70b38f838f6a3511dcbbc33f3ee81a4d05ede1 DIFF: https://github.com/llvm/llvm-project/commit/eb70b38f838f6a3511dcbbc33f3ee81a4d05ede1.diff

[PATCH] D137527: [C++20] [Modules] [ClangScanDeps] Add ClangScanDeps support for C++20 Named Modules in P1689 format (2/4)

ChuanqiXu updated this revision to Diff 496823. ChuanqiXu added a comment. Add `unsupported: windows`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137527/new/ https://reviews.llvm.org/D137527 Files: clang/include/clang/Tooling/DependencyScanning/DependencyScanningService.h

[PATCH] D137527: [C++20] [Modules] [ClangScanDeps] Add ClangScanDeps support for C++20 Named Modules in P1689 format (2/4)

ChuanqiXu updated this revision to Diff 496821. ChuanqiXu added a comment. While I failed to reproduce the failure in my local environment, I found a thread-safe defect in my code. I forgot to add a Lock for `P1689::addRules`. I'd like to recommit this one and see if the bot would still

[PATCH] D143870: [clang-format] Remove all include duplicates not only those in the same block

Febbe created this revision. Herald added a project: All. Febbe requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change aims to remove all duplicate include directives, instead of only those, which are in the same block. This change

[PATCH] D143439: [RISCV] Add vendor-defined XTheadBb (basic bit-manipulation) extension

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143439/new/ https://reviews.llvm.org/D143439

[PATCH] D143849: [Clang][OpenCL] Allow pointers in structs as kernel arguments from 2.0

Ayal added a comment. In D143849#4121348 , @Anastasia wrote: > I feel that originally pointers were disallowed because they create the same > issue as `size_t` and etc as their size is implementation depended but the > same logic applies to images and

[PATCH] D143867: [analyzer] Fix SARIF column location assertion crash

Scarlet1ssimo created this revision. Herald added subscribers: steakhal, manas, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. Scarlet1ssimo requested review of

[PATCH] D138037: [analyzer] Remove unjustified assertion from EQClass::simplify

vabridgers accepted this revision. vabridgers added a comment. This revision is now accepted and ready to land. I got back to testing this through a large, internal set of builds, and do not see anymore problems. If everyone is ok with that, could this be merged? Repository: rG LLVM Github

[PATCH] D143348: [Clang][Doc][OpenCL] Release 16 notes

Anastasia added inline comments. Comment at: clang/docs/ReleaseNotes.rst:840 + * Fixed conditional definition of the depth image and read_write image3d builtins. + * Added ``nounwind`` attribute to all builtin functions. + svenvh wrote: > It's slightly more

[PATCH] D143348: [Clang][Doc][OpenCL] Release 16 notes

Anastasia updated this revision to Diff 496790. Anastasia added a comment. Updated bullet about nounwind attr CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143348/new/ https://reviews.llvm.org/D143348 Files: clang/docs/ReleaseNotes.rst Index: clang/docs/ReleaseNotes.rst

[PATCH] D143849: [Clang][OpenCL] Allow pointers in structs as kernel arguments from 2.0

Anastasia added a comment. I feel that originally pointers were disallowed because they create the same issue as `size_t` and etc as their size is implementation depended but the same logic applies to images and other types that are even more implementation depended. Overall this bit of the

[PATCH] D143472: [clang] Cast the pointer to right type with different address space

Anastasia added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:12412 // Cast the pointer to right type. - Value *Ptr = CGF.Builder.CreateBitCast(Ops[0], - llvm::PointerType::getUnqual(Ops[1]->getType())); + Value *Ptr =

[PATCH] D137302: [clang-tidy] Add modernize-type-traits check

ccotter added a comment. Looks good to me - looking forward to this check! Comment at: clang-tools-extra/clang-tidy/modernize/TypeTraitsCheck.cpp:170 + +static constexpr char Bind[] = ""; + NIT: should the bound node have some meaningful non-empty name?

[PATCH] D143851: [clang-tidy] Tweak 'rule of 3/5' checks to allow defaulting a destructor outside the class.

ccotter added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/cppcoreguidelines/special-member-functions.rst:40 + + struct C { // This is not checked, because the destuctor might be defaulted in another translation unit. + ~C();

[PATCH] D141008: [Clang][SPIR-V] Emit target extension types for OpenCL types on SPIR-V.

Anastasia added inline comments. Comment at: clang/lib/CodeGen/CGOpenCLRuntime.cpp:40 switch (cast(T)->getKind()) { default: I am not sure if this can be called a generic implementation as it has always been a workaround to compensate for absence of

[PATCH] D143851: [clang-tidy] Tweak 'rule of 3/5' checks to allow defaulting a destructor outside the class.

royjacobson created this revision. royjacobson added reviewers: carlosgalvezp, njames93, aaron.ballman. Herald added subscribers: kbarton, xazax.hun, nemanjai. Herald added a project: All. royjacobson requested review of this revision. Herald added a project: clang-tools-extra. Herald added a

[PATCH] D142578: [Clang][Doc] Edit the Clang release notes

royjacobson added a subscriber: clang-language-wg. royjacobson marked 2 inline comments as done. royjacobson added a comment. friendly ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142578/new/ https://reviews.llvm.org/D142578

[PATCH] D142578: [Clang][Doc] Edit the Clang release notes

royjacobson updated this revision to Diff 496771. royjacobson added a comment. Rebase to include the RISC-V changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142578/new/ https://reviews.llvm.org/D142578 Files: clang/docs/ReleaseNotes.rst

[PATCH] D49723: [OpenCL] Check for invalid kernel arguments in array types

Ayal added a comment. In D49723#4116783 , @asavonic wrote: > In D49723#4116435 , @Ayal wrote: > >> This is admittedly a couple of years old by now, but wonder about that other >> intended patch - Clang still seems

[PATCH] D143849: [Clang][OpenCL] Allow pointers in structs as kernel arguments from 2.0

Ayal created this revision. Ayal added reviewers: asavonic, Anastasia, yaxunl. Herald added subscribers: Naghasan, ldrumm. Herald added a project: All. Ayal requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Structs that contain global or

[PATCH] D143736: [PowerPC] Specify the dynamic loader prefix in ppc-float-abi-warning

qiucf accepted this revision. qiucf added a comment. This revision is now accepted and ready to land. LGTM, thanks for catching this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143736/new/ https://reviews.llvm.org/D143736

[PATCH] D143843: [clang-tidy][NFC] Remove ModernizeTidyModule::getModuleOptions

Eugene.Zelenko accepted this revision. Eugene.Zelenko added a comment. This revision is now accepted and ready to land. But will be good idea to notify authors of checks if they are still active. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D143342: [clang-tidy] Support std::format and std::print in readability-redundant-string-cstr

mikecrowe updated this revision to Diff 496758. mikecrowe added a comment. Incorporate feedback from Nathan James: - Simplify callExpr pattern in matcher. - Use `forEachArgumentWithParam` so that check works on all arguments and remove mentions of previous limitation in commit message and

[clang] 8bb98b5 - [Clang] Add the list of approved (Issaquah) C++ papers to the status page

Author: Corentin Jabot Date: 2023-02-12T07:04:31-08:00 New Revision: 8bb98b5715479210d2eec4d72344c21cb82bf78a URL: https://github.com/llvm/llvm-project/commit/8bb98b5715479210d2eec4d72344c21cb82bf78a DIFF:

[PATCH] D140614: [C++20] Mark lambdas in lambda specifiers as dependent if necessary

lime added a comment. Crashes were gone although via avoiding diagnostics directly in D140838 . Considering this does not fix the acceptance of the ill code here , should I abandon

[PATCH] D143342: [clang-tidy] Support std::format and std::print in readability-redundant-string-cstr

mikecrowe added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/RedundantStringCStrCheck.cpp:188 + callee(functionDecl(hasName("::std::format", +hasAnyArgument(materializeTemporaryExpr( +

[PATCH] D142316: [clang] Add test for CWG2396

Endill marked an inline comment as not done. Endill added inline comments. Comment at: clang/test/CXX/drs/dr23xx.cpp:202 + // void g2(A a) { a.operator B decltype(B())::*(); } + // void h(A a) { a.operator identity::type B::*(); } + // void h2(A a) { a.operator B

[PATCH] D143843: [clang-tidy][NFC] Remove ModernizeTidyModule::getModuleOptions

carlosgalvezp created this revision. Herald added a subscriber: xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. carlosgalvezp requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Most of the options stated

[PATCH] D142655: [clang-tidy] Introduce HeaderFileExtensions and ImplementationFileExtensions options

carlosgalvezp added a comment. Friendly ping @njames93 . Since there are more checks coming up introducing more debt and duplication, I believe we should land this rather soon. I intend to land this by Feb 19th if I don't receive any more feedback. Repository: rG LLVM Github Monorepo

[PATCH] D137527: [C++20] [Modules] [ClangScanDeps] Add ClangScanDeps support for C++20 Named Modules in P1689 format (2/4)

chapuni added a comment. Excuse me, I have reverted 79a3803bb2cc , D137534 and this. See also https://lab.llvm.org/buildbot/#/builders/239/builds/922 I guess `P1689Deps` would not be

[clang] 069dd87 - Revert "[C++20] [Modules] [ClangScanDeps] Add ClangScanDeps support for C++20 Named Modules in P1689 format (2/4)"

Author: NAKAMURA Takumi Date: 2023-02-12T18:38:25+09:00 New Revision: 069dd8768a6a00df0a7c4573d415744b06f98955 URL: https://github.com/llvm/llvm-project/commit/069dd8768a6a00df0a7c4573d415744b06f98955 DIFF:

[clang] f8b5003 - Revert "[C++20] [Modules] [ClangScanDeps] Allow clang-scan-deps to without specified compilation database in P1689 (3/4)"

Author: NAKAMURA Takumi Date: 2023-02-12T18:38:17+09:00 New Revision: f8b5003cb3f90b9ec21c3472110b0a9a9f245cda URL: https://github.com/llvm/llvm-project/commit/f8b5003cb3f90b9ec21c3472110b0a9a9f245cda DIFF:

[clang] 502e357 - Revert "[ClangScanDeps] Add UNSUPPORTED: system-windows to test P1689.cppm"

Author: NAKAMURA Takumi Date: 2023-02-12T18:37:34+09:00 New Revision: 502e357dc77cde6cc3a11714d37468d5d4c747c3 URL: https://github.com/llvm/llvm-project/commit/502e357dc77cde6cc3a11714d37468d5d4c747c3 DIFF: