[clang] a28b252 - Use APInt::getSignificantBits instead of APInt::getMinSignedBits (NFC)

2023-02-19 Thread Kazu Hirata via cfe-commits
Author: Kazu Hirata Date: 2023-02-19T23:56:52-08:00 New Revision: a28b252d852c31fb7228e095a213347e6926bb0f URL: https://github.com/llvm/llvm-project/commit/a28b252d852c31fb7228e095a213347e6926bb0f DIFF: https://github.com/llvm/llvm-project/commit/a28b252d852c31fb7228e095a213347e6926bb0f.diff

[clang] 2dfa957 - [NFC] Remove the unused parameter in Sema::PushGlobalModuleFragment

2023-02-19 Thread Chuanqi Xu via cfe-commits
Author: Chuanqi Xu Date: 2023-02-20T15:37:55+08:00 New Revision: 2dfa957f120244ddc0238b548282f67d89f1a832 URL: https://github.com/llvm/llvm-project/commit/2dfa957f120244ddc0238b548282f67d89f1a832 DIFF: https://github.com/llvm/llvm-project/commit/2dfa957f120244ddc0238b548282f67d89f1a832.diff

[clang] 70d78e0 - [NFC] Remove unused Sema::DirectModuleImports

2023-02-19 Thread Chuanqi Xu via cfe-commits
Author: Chuanqi Xu Date: 2023-02-20T15:07:49+08:00 New Revision: 70d78e035801a35c95c55384621724b0ef8ecb35 URL: https://github.com/llvm/llvm-project/commit/70d78e035801a35c95c55384621724b0ef8ecb35 DIFF: https://github.com/llvm/llvm-project/commit/70d78e035801a35c95c55384621724b0ef8ecb35.diff

[PATCH] D143767: [SVE][Builtins] Lower X forms of fp binop/mla arithmetic builtins to dedicated intrinsics

2023-02-19 Thread dewen via Phabricator via cfe-commits
dewen added a comment. Hi, thank you. When will this patch be pushed to the master?@paulwalker-arm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143767/new/ https://reviews.llvm.org/D143767 ___

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

2023-02-19 Thread Chris Cotter via Phabricator via cfe-commits
ccotter updated this revision to Diff 498730. ccotter added a comment. - Add back -fno-delayed-template-parsing to test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141569/new/ https://reviews.llvm.org/D141569 Files:

[clang] c5cb111 - [Modules] Handle the visibility of GMF during the template instantiation

2023-02-19 Thread Chuanqi Xu via cfe-commits
Author: Chuanqi Xu Date: 2023-02-20T14:19:50+08:00 New Revision: c5cb1117e19273a26499a1e18770b74bdf3b9ade URL: https://github.com/llvm/llvm-project/commit/c5cb1117e19273a26499a1e18770b74bdf3b9ade DIFF: https://github.com/llvm/llvm-project/commit/c5cb1117e19273a26499a1e18770b74bdf3b9ade.diff

[PATCH] D143306: [Driver] Default to -fno-openmp-implicit-rpath

2023-02-19 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. Ping for feedback from others Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143306/new/ https://reviews.llvm.org/D143306 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] a489e11 - [Fuchsia] Use cleaner method of adding driver binary

2023-02-19 Thread Alex Brachet via cfe-commits
Author: Alex Brachet Date: 2023-02-20T03:57:23Z New Revision: a489e11439e36c7e0ec83b28a6fb1596a5c21faa URL: https://github.com/llvm/llvm-project/commit/a489e11439e36c7e0ec83b28a6fb1596a5c21faa DIFF: https://github.com/llvm/llvm-project/commit/a489e11439e36c7e0ec83b28a6fb1596a5c21faa.diff LOG:

[clang] 6bb8668 - [Fuchsia] Fix driver build on Windows

2023-02-19 Thread Alex Brachet via cfe-commits
Author: Alex Brachet Date: 2023-02-20T03:34:26Z New Revision: 6bb86689af7e31b23b432f3941d5ce447819ef3b URL: https://github.com/llvm/llvm-project/commit/6bb86689af7e31b23b432f3941d5ce447819ef3b DIFF: https://github.com/llvm/llvm-project/commit/6bb86689af7e31b23b432f3941d5ce447819ef3b.diff LOG:

[clang] 6e473ae - [clang-format] Put ports on separate lines in Verilog module headers

2023-02-19 Thread via cfe-commits
Author: sstwcw Date: 2023-02-20T03:24:13Z New Revision: 6e473aeffdc1c26307e19f68252767a32e0047ad URL: https://github.com/llvm/llvm-project/commit/6e473aeffdc1c26307e19f68252767a32e0047ad DIFF: https://github.com/llvm/llvm-project/commit/6e473aeffdc1c26307e19f68252767a32e0047ad.diff LOG:

[PATCH] D143825: [clang-format] Put ports on separate lines in Verilog module headers

2023-02-19 Thread sstwcw via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6e473aeffdc1: [clang-format] Put ports on separate lines in Verilog module headers (authored by sstwcw). Changed prior to commit:

[PATCH] D144355: [clang-format][NFC] Clean up nullptr comparison style

2023-02-19 Thread sstwcw via Phabricator via cfe-commits
sstwcw added a comment. @MyDeveloperDay Looking at the return lines in the functions in `FormatToken.h` got me to check the similar functions not changed by this patch. And I noticed that the final `==` in `isCSharpKeyword` seems to return true when the token is not a keyword. Repository:

[PATCH] D144296: [clang-format] Rewrite how indent is reduced for compacted namespaces

2023-02-19 Thread Owen Pan via Phabricator via cfe-commits
owenpan added a comment. In D144296#4137508 , @HazardyKnusperkeks wrote: > And I see the style was bogus before, but shouldn't all variables start with > a capital letter? Please fix that in the code you touch. +1. Repository: rG LLVM Github

[PATCH] D144296: [clang-format] Rewrite how indent is reduced for compacted namespaces

2023-02-19 Thread Owen Pan via Phabricator via cfe-commits
owenpan added a comment. In D144296#4136133 , @rymiel wrote: > Note: this patch also makes `LevelIndentTracker::skipLine` obsolete. I > suppose I could clean that up in a following patch I'd delete it in this patch. Comment at:

[clang] 55ab77d - Reland "[Fuchsia] Enable llvm-driver build".

2023-02-19 Thread Alex Brachet via cfe-commits
Author: Alex Brachet Date: 2023-02-20T01:57:40Z New Revision: 55ab77d279a1b77ff85d0d040f867d4e764aba3b URL: https://github.com/llvm/llvm-project/commit/55ab77d279a1b77ff85d0d040f867d4e764aba3b DIFF: https://github.com/llvm/llvm-project/commit/55ab77d279a1b77ff85d0d040f867d4e764aba3b.diff LOG:

[PATCH] D144321: [PowerPC] Correctly use ELFv2 ABI on all OS's that use the ELFv2 ABI

2023-02-19 Thread Brad Smith via Phabricator via cfe-commits
brad marked an inline comment as done. brad added inline comments. Comment at: clang/lib/Basic/Targets/PPC.h:430-432 + if ((Triple.isOSFreeBSD() && (Triple.getOSVersion().empty() || +Triple.getOSMajorVersion() >= 13)) || +

[PATCH] D144321: [PowerPC] Correctly use ELFv2 ABI on all OS's that use the ELFv2 ABI

2023-02-19 Thread Nemanja Ivanovic via Phabricator via cfe-commits
nemanjai added inline comments. Comment at: clang/lib/Basic/Targets/PPC.h:430-432 + if ((Triple.isOSFreeBSD() && (Triple.getOSVersion().empty() || +Triple.getOSMajorVersion() >= 13)) || + Triple.isOSOpenBSD() || Triple.isMusl())

[PATCH] D143825: [clang-format] Put ports on separate lines in Verilog module headers

2023-02-19 Thread Owen Pan via Phabricator via cfe-commits
owenpan added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:2665 +if (Style.isVerilog() && Precedence == prec::Comma && +VerilogFirstOfType != nullptr) { + addFakeParenthesis(VerilogFirstOfType, prec::Comma); sstwcw wrote: >

[PATCH] D127910: [Clang][AArch64][SME] Add vector load/store (ld1/st1) intrinsics

2023-02-19 Thread Bryan Chan via Phabricator via cfe-commits
bryanpkc marked an inline comment as done. bryanpkc added inline comments. Comment at: clang/lib/Headers/CMakeLists.txt:332 + # Generate arm_sme.h + clang_generate_header(-gen-arm-sme-header arm_sme.td arm_sme.h) # Generate arm_bf16.h sdesmalen wrote: >

[PATCH] D144355: [clang-format][NFC] Clean up nullptr comparison style

2023-02-19 Thread Owen Pan via Phabricator via cfe-commits
owenpan created this revision. owenpan added reviewers: MyDeveloperDay, HazardyKnusperkeks, rymiel. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. For example,

[PATCH] D127910: [Clang][AArch64][SME] Add vector load/store (ld1/st1) intrinsics

2023-02-19 Thread Bryan Chan via Phabricator via cfe-commits
bryanpkc updated this revision to Diff 498700. bryanpkc marked 2 inline comments as done and an inline comment as not done. bryanpkc added a comment. Addressed review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127910/new/

[clang] a98cafd - [CMake] Fix driver build on MacOS

2023-02-19 Thread Alex Brachet via cfe-commits
Author: Alex Brachet Date: 2023-02-19T23:42:11Z New Revision: a98cafd1d0f1144bc9149f7781de41c1abf7c960 URL: https://github.com/llvm/llvm-project/commit/a98cafd1d0f1144bc9149f7781de41c1abf7c960 DIFF: https://github.com/llvm/llvm-project/commit/a98cafd1d0f1144bc9149f7781de41c1abf7c960.diff LOG:

[PATCH] D143825: [clang-format] Put ports on separate lines in Verilog module headers

2023-02-19 Thread sstwcw via Phabricator via cfe-commits
sstwcw added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:2665 +if (Style.isVerilog() && Precedence == prec::Comma && +VerilogFirstOfType != nullptr) { + addFakeParenthesis(VerilogFirstOfType, prec::Comma); owenpan wrote: >

[clang] 87d02e0 - Recommit "[Support] change StringMap hash function from djbHash to xxHash"

2023-02-19 Thread Erik Desjardins via cfe-commits
Author: Erik Desjardins Date: 2023-02-19T16:52:26-05:00 New Revision: 87d02e0dfd760de38d092ef69f8a9164f28f2221 URL: https://github.com/llvm/llvm-project/commit/87d02e0dfd760de38d092ef69f8a9164f28f2221 DIFF:

[clang-tools-extra] 87d02e0 - Recommit "[Support] change StringMap hash function from djbHash to xxHash"

2023-02-19 Thread Erik Desjardins via cfe-commits
Author: Erik Desjardins Date: 2023-02-19T16:52:26-05:00 New Revision: 87d02e0dfd760de38d092ef69f8a9164f28f2221 URL: https://github.com/llvm/llvm-project/commit/87d02e0dfd760de38d092ef69f8a9164f28f2221 DIFF:

[PATCH] D144352: Do not emit exception diagnostics from coroutines and coroutine lambdas

2023-02-19 Thread Deniz Evrenci via Phabricator via cfe-commits
denizevrenci updated this revision to Diff 498695. denizevrenci added a comment. Added some throws that should be ignored. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144352/new/ https://reviews.llvm.org/D144352 Files:

[PATCH] D143348: [Clang][Doc][OpenCL] Release 16 notes

2023-02-19 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia closed this revision. Anastasia added a comment. Committed in https://github.com/llvm/llvm-project/commit/639db8a90d2adf7789b9d3cec3a7c26502bf819b CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143348/new/ https://reviews.llvm.org/D143348

[PATCH] D144317: [clang-format] Fix handling of TypeScript tuples with optional last member

2023-02-19 Thread Taymon A. Beal via Phabricator via cfe-commits
taymonbeal updated this revision to Diff 498692. taymonbeal added a comment. Merge unit test into existing test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144317/new/ https://reviews.llvm.org/D144317 Files:

[PATCH] D143507: [RISCV][MC] Mark Zawrs extension as non-experimental

2023-02-19 Thread Alex Bradbury via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGd41a73aa94cb: [RISCV][MC] Mark Zawrs extension as non-experimental (authored by asb). Changed prior to commit: https://reviews.llvm.org/D143507?vs=495562=498691#toc Repository: rG LLVM Github

[clang] d41a73a - [RISCV][MC] Mark Zawrs extension as non-experimental

2023-02-19 Thread Alex Bradbury via cfe-commits
Author: Alex Bradbury Date: 2023-02-19T20:43:03Z New Revision: d41a73aa94cb8945dcd0f2906992c2fcea6ed001 URL: https://github.com/llvm/llvm-project/commit/d41a73aa94cb8945dcd0f2906992c2fcea6ed001 DIFF: https://github.com/llvm/llvm-project/commit/d41a73aa94cb8945dcd0f2906992c2fcea6ed001.diff

[PATCH] D143849: [Clang][OpenCL] Allow pointers in structs as kernel arguments from 2.0

2023-02-19 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:9494 + // of SVM. + if (S.getLangOpts().getOpenCLCompatibleVersion() > 120 && + (ParamType == PtrKernelParam || ParamType == PtrPtrKernelParam)) Ayal wrote: > Anastasia

[clang] cbde212 - Use APInt::popcount instead of APInt::countPopulation (NFC)

2023-02-19 Thread Kazu Hirata via cfe-commits
Author: Kazu Hirata Date: 2023-02-19T11:29:12-08:00 New Revision: cbde2124f153f8fd084e8ff1221c0357442ea707 URL: https://github.com/llvm/llvm-project/commit/cbde2124f153f8fd084e8ff1221c0357442ea707 DIFF: https://github.com/llvm/llvm-project/commit/cbde2124f153f8fd084e8ff1221c0357442ea707.diff

[PATCH] D144347: [clang-tidy] Add readability-forward-usage check

2023-02-19 Thread Piotr Zegar via Phabricator via cfe-commits
PiotrZSL created this revision. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. PiotrZSL updated this revision to Diff 498666. PiotrZSL added a comment. Eugene.Zelenko added reviewers: aaron.ballman, carlosgalvezp. PiotrZSL marked

[PATCH] D135495: [clang-tidy] handle exceptions properly `ExceptionAnalyzer`

2023-02-19 Thread Domján Dániel via Phabricator via cfe-commits
isuckatcs added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135495/new/ https://reviews.llvm.org/D135495 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D144352: Do not emit exception diagnostics from coroutines and coroutine lambdas

2023-02-19 Thread Deniz Evrenci via Phabricator via cfe-commits
denizevrenci created this revision. denizevrenci added reviewers: NoQ, gribozavr. Herald added a subscriber: ChuanqiXu. Herald added a project: All. denizevrenci requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes #48797 All exceptions

[PATCH] D143840: [clang] Add the check of membership for the issue #58674 and improve the lookup process

2023-02-19 Thread Liming Liu via Phabricator via cfe-commits
lime added a comment. Ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143840/new/ https://reviews.llvm.org/D143840 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] 14fee3d - Fix clang-tools-extra docs build

2023-02-19 Thread Carlos Galvez via cfe-commits
Author: Carlos Galvez Date: 2023-02-19T13:58:31Z New Revision: 14fee3d7d36927d3e8940cbcaab70fa4e99e2ec2 URL: https://github.com/llvm/llvm-project/commit/14fee3d7d36927d3e8940cbcaab70fa4e99e2ec2 DIFF: https://github.com/llvm/llvm-project/commit/14fee3d7d36927d3e8940cbcaab70fa4e99e2ec2.diff

[clang-tools-extra] 5b37cdd - [clang-tidy] Introduce HeaderFileExtensions and ImplementationFileExtensions options

2023-02-19 Thread Carlos Galvez via cfe-commits
Author: Carlos Galvez Date: 2023-02-19T13:44:11Z New Revision: 5b37cddff8e0140420ad776066529cf8f41d64d2 URL: https://github.com/llvm/llvm-project/commit/5b37cddff8e0140420ad776066529cf8f41d64d2 DIFF: https://github.com/llvm/llvm-project/commit/5b37cddff8e0140420ad776066529cf8f41d64d2.diff

[PATCH] D142655: [clang-tidy] Introduce HeaderFileExtensions and ImplementationFileExtensions options

2023-02-19 Thread Carlos Galvez via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG5b37cddff8e0: [clang-tidy] Introduce HeaderFileExtensions and ImplementationFileExtensions… (authored by carlosgalvezp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D144296: [clang-format] Rewrite how indent is reduced for compacted namespaces

2023-02-19 Thread Björn Schäpers via Phabricator via cfe-commits
HazardyKnusperkeks added a comment. There is no PP stuff in the new tests. And I see the style was bogus before, but shouldn't all variables start with a capital letter? Please fix that in the code you touch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION