[PATCH] D144603: Add option to disable compiler launcher on external projects

phosek added a comment. In D144603#4162974 , @haowei wrote: > I think remove the compiler launcher from default pass through flags are > fine. What about the using compiler launcher in runtime builds? I don't think > we should read

[PATCH] D145141: [Driver] Reject -march= for ppc

MaskRay created this revision. MaskRay added reviewers: PowerPC, nemanjai. Herald added subscribers: shchenz, fedor.sergeev, kbarton, jyknight. Herald added a project: All. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Clang

[PATCH] D140776: [clang][Interp] Handle defined functions without a body

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbf6c1344ec18: [clang][Interp] Handle defined functions without a body (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] bf6c134 - [clang][Interp] Handle defined functions without a body

Author: Timm Bäder Date: 2023-03-02T08:17:48+01:00 New Revision: bf6c1344ec1898d27760e135b77ad2676f88a697 URL: https://github.com/llvm/llvm-project/commit/bf6c1344ec1898d27760e135b77ad2676f88a697 DIFF: https://github.com/llvm/llvm-project/commit/bf6c1344ec1898d27760e135b77ad2676f88a697.diff

[PATCH] D140668: [clang][Interp] Implement remaining bits for MaterializeTemporaryExprs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf18b71d14f7e: [clang][Interp] Implement remaining MaterializeTemporaryExpr bits (authored by tbaeder). Changed prior to commit:

[clang] f18b71d - [clang][Interp] Implement remaining MaterializeTemporaryExpr bits

Author: Timm Bäder Date: 2023-03-02T07:51:54+01:00 New Revision: f18b71d14f7efdbc76aba888fdfe233bf0de7841 URL: https://github.com/llvm/llvm-project/commit/f18b71d14f7efdbc76aba888fdfe233bf0de7841 DIFF: https://github.com/llvm/llvm-project/commit/f18b71d14f7efdbc76aba888fdfe233bf0de7841.diff

[PATCH] D144454: Add builtin for llvm set rounding

rjmccall added a comment. I see. If we're going to take the target-independent values specified by `FLT_ROUNDS`, then the original builtin name is more appropriate. Of course, this has the disadvantage of not allowing target-specific values that might exist beyond those specified in the

[PATCH] D144454: Add builtin for llvm set rounding

xiongji90 added a comment. In D144454#4163658 , @sepavloff wrote: > C standard function `fesetround` accepts rounding mode in the form of > target-specific values like `FE_TONEAREST`. They usually represent > corresponding bits in control register, so

[PATCH] D145021: [Clang][AIX][p] Claim -p in front end

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:6342 +A->claim(); +if (TC.getTriple().isOSAIX()) { + if (!Args.hasArgNoClaim(options::OPT_pg)) Use `&&` Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D145021: [Clang][AIX][p] Claim -p in front end

MaskRay added inline comments. Comment at: clang/test/Driver/ibm-profiling.c:1 +// RUN: %clang -### 2>&1 \ +// RUN:--target=s390x-none-zos \ This is too verbose. Driver tests prefer packing many options on one line. The decreased number of lines

[PATCH] D141591: [clang][Interp] Properly identify not-yet-defined functions

shafik accepted this revision. shafik added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141591/new/ https://reviews.llvm.org/D141591 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D144454: Add builtin for llvm set rounding

sepavloff added a comment. C standard function `fesetround` accepts rounding mode in the form of target-specific values like `FE_TONEAREST`. They usually represent corresponding bits in control register, so are different for different targets. `llvm.set_rounding` in contrast accepts rounding

[PATCH] D144454: Add builtin for llvm set rounding

xiongji90 added a comment. In D144454#4162129 , @rjmccall wrote: > In D144454#4157717 , @xiongji90 > wrote: > >> In D144454#4142253 , @rjmccall >> wrote: >> >>> New

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

ccotter added a comment. bump. I never heard back on the case where using an rvalue reference for a big pod type as opposed to const ref. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141569/new/ https://reviews.llvm.org/D141569

[PATCH] D140760: [clang-tidy] Support begin/end free functions in modernize-loop-convert

ccotter updated this revision to Diff 501734. ccotter added a comment. - Add another test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140760/new/ https://reviews.llvm.org/D140760 Files:

[PATCH] D145138: [clang-tidy] Implement FixIts for C arrays

ccotter updated this revision to Diff 501733. ccotter added a comment. - Add more tests for whitespace Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145138/new/ https://reviews.llvm.org/D145138 Files:

[PATCH] D144454: Add builtin for llvm set rounding

xiongji90 updated this revision to Diff 501732. xiongji90 added a comment. Change the builtin name to __builtin_fesetround Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144454/new/ https://reviews.llvm.org/D144454 Files:

[PATCH] D145138: [clang-tidy] Implement FixIts for C arrays

ccotter added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/AvoidCArraysCheck.cpp:532 + // TODO: How can I get FileCheck to accept '{{}}' as a non-regex match? + FixIts.push_back(FixItHint::CreateInsertion(InitRange.getBegin(), "{ ")); +

[PATCH] D145138: Implement FixIts for C arrays

ccotter created this revision. Herald added a subscriber: carlosgalvezp. Herald added a reviewer: njames93. Herald added a project: All. ccotter requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Add FixIts for C arrays declared

[PATCH] D143704: [Flang] Part one of Feature List action

elmcdonough updated this revision to Diff 501720. elmcdonough edited the summary of this revision. elmcdonough removed reviewers: klausler, clementval. elmcdonough added a comment. Herald added a subscriber: sstefan1. Tests + total coverage of elements inside dump-parse-tree.h Repository: rG

[PATCH] D145034: [Clang][Sema] Preparations to fix handling of out-of-line definitions of constrained templates

shafik added inline comments. Comment at: clang/include/clang/Sema/DeclSpec.h:68 NestedNameSpecifierLocBuilder Builder; + ArrayRef TemplateParamLists; Does this really represent a `nested-name-specifier` with a `template-param-list`? Maybe I am

[PATCH] D144672: [Sanitizers] Error when attempting to use `static-lsan` with `TSan` or `Asan` on darwin

dmaclach added a comment. Yep. Apologies. Been a long time since I committed anything to LLVM. I'll try and take a look tonight/first thing tomorrow. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144672/new/ https://reviews.llvm.org/D144672

[PATCH] D145021: [Clang][AIX][p] Claim -p in front end

francii updated this revision to Diff 501711. francii added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145021/new/ https://reviews.llvm.org/D145021 Files: clang/lib/Driver/ToolChains/AIX.cpp

[PATCH] D144981: [Driver] Allow to collect `-save-stats` data to a file specified in the environment variable.

vsapsai updated this revision to Diff 501709. vsapsai added a comment. Append to stats file when using `CC_PRINT_INTERNAL_STAT` and for LTO when reusing the same stats file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144981/new/

[PATCH] D145021: [Clang][AIX][p] Claim -p in front end

francii updated this revision to Diff 501698. francii added a comment. Add more test cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145021/new/ https://reviews.llvm.org/D145021 Files: clang/lib/Driver/ToolChains/AIX.cpp

[PATCH] D144672: [Sanitizers] Error when attempting to use `static-lsan` with `TSan` or `Asan` on darwin

usama54321 reopened this revision. usama54321 added a comment. This revision is now accepted and ready to land. @dmaclach Can you please take a look and fix this? Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144672/new/

[PATCH] D145093: Add map info for dereference pointer.

ABataev added inline comments. Comment at: clang/test/OpenMP/target_map_deref_array_codegen.cpp:17 +(*t1d)[j] = 1; + #pragma omp target map(to: (*t1d)[0:3]) +(*t1d)[2] = 2; jyu2 wrote: > ABataev wrote: > > Is this correct at all? This is not a pointer

[PATCH] D145093: Add map info for dereference pointer.

jyu2 added inline comments. Comment at: clang/test/OpenMP/target_map_deref_array_codegen.cpp:17 +(*t1d)[j] = 1; + #pragma omp target map(to: (*t1d)[0:3]) +(*t1d)[2] = 2; ABataev wrote: > Is this correct at all? This is not a pointer to the array, it is

[PATCH] D145021: [Clang][AIX][p] Claim -p in front end

francii updated this revision to Diff 501692. francii added a comment. Always throw error when `-p` is in command. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145021/new/ https://reviews.llvm.org/D145021 Files:

[PATCH] D144634: [Clang][OpenMP] Support for Code Generation of loop bind clause

carlo.bertolli added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:7791 +OpenMPBindClauseKind bindParam = C->getBindKind(); +switch (bindParam) { +case OMPC_BIND_parallel: { What if you have something like this: void foo(..) {

[PATCH] D143675: Discussion: Darwin Sanitizers Stable ABI

thetruestblue added a comment. Currently & ideally asabi_shim.h is unnecessary -- but we hope to use only headers from ../asan/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143675/new/ https://reviews.llvm.org/D143675

[PATCH] D144634: [Clang][OpenMP] Support for Code Generation of loop bind clause

ddpagan added a comment. How is bind(thread) not working? Runtime issue? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144634/new/ https://reviews.llvm.org/D144634 ___ cfe-commits mailing list

[PATCH] D144672: [Sanitizers] Error when attempting to use `static-lsan` with `TSan` or `Asan` on darwin

zixuw added a comment. Hi! This broke the asan replaceable_new_delete.cpp test on Darwin because it has a run line using `-static-libsan`. Could you take a look? Probably need to separate that check out and mark as unsupported on Darwin Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D145125: [RISCV] Make D extension imply F extension.

craig.topper created this revision. craig.topper added reviewers: reames, asb, luismarques, kito-cheng. Herald added subscribers: luke, VincentWu, vkmr, frasercrmck, evandro, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01,

[PATCH] D145123: Call MarkVirtualMembersReferenced on an actual class definition

sberg added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:17940 LoadExternalVTableUses(); Class = Class->getCanonicalDecl(); std::pair::iterator, bool> That call of `getCanonicalDecl` originated with

[PATCH] D145123: Call MarkVirtualMembersReferenced on an actual class definition

sberg created this revision. sberg added reviewers: doug.gregor, aaron.ballman. sberg added a project: clang. Herald added a project: All. sberg requested review of this revision. ...rather than on potentially just a declaration. Without the fix, the newly added

[PATCH] D145034: [Clang][Sema] Preparations to fix handling of out-of-line definitions of constrained templates

rsmith added a comment. This direction looks promising to me. Comment at: clang/lib/Parse/ParseDeclCXX.cpp:1677-1678 CXXScopeSpec Spec; +if (TemplateInfo.TemplateParams) + Spec.setTemplateParamLists(*TemplateInfo.TemplateParams); + I think we'll

[PATCH] D144603: Add option to disable compiler launcher on external projects

haowei updated this revision to Diff 501670. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144603/new/ https://reviews.llvm.org/D144603 Files: clang/CMakeLists.txt clang/cmake/caches/Fuchsia-stage2.cmake clang/cmake/caches/Fuchsia.cmake

Re: [clang] 6ed67cc - [Coroutines] Remove -fcoroutines-ts

Makes total sense, thank you for the clarification. On Mon, Feb 27, 2023 at 6:24 PM chuanqi.xcq wrote: > > Hi Bruno, > > We talked about removing `-fcoroutines-ts` in > https://github.com/llvm/llvm-project/issues/59110 > and https://reviews.llvm.org/D108697. I raised the example you used

[PATCH] D145021: [Clang][AIX][p] Claim -p in front end

francii updated this revision to Diff 501668. francii added a comment. Cleanup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145021/new/ https://reviews.llvm.org/D145021 Files: clang/lib/Driver/ToolChains/AIX.cpp

[PATCH] D145021: [Clang][AIX][p] Claim -p in front end

francii updated this revision to Diff 501666. francii added a comment. Update to claiming logic: if `-pg` is passed, only claim `-p` if `-p` is passed afterwards. Otherwise, always claim `-p`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D141389: [DFSAN] Add support for strnlen, strncat, strsep, sscanf and _tolower

tkuchta added inline comments. Comment at: compiler-rt/lib/dfsan/dfsan_custom.cpp:221 + if (flags().strict_data_dependencies) { +*ret_label = res ? s_label : 0; + } else { browneee wrote: > When `res != NULL`, then `res` is derived from `*s`, not from `s`.

[PATCH] D144285: [Clang] Implement CWG2518 - static_assert(false)

cor3ntin added a comment. @rupprecht This expands to template class MyMock { static_assert( static_assert( ::testing::tuple_size >::ArgumentTuple>::value == 2, "This method does not take " "2" " arguments. Parenthesize all types with unprotected commas."); }; (some stuff omitted)

[PATCH] D144603: Add option to disable compiler launcher on external projects

haowei added a comment. In D144603#4162223 , @phosek wrote: > I agree, in that case let's remove > `C_COMPILER_LAUNCHER;CXX_COMPILER_LAUNCHER` from the list of default > passthrough variables which seems like a reasonable default, and provide >

[PATCH] D144866: [clang] Fix aggregate initialization inside lambda constexpr

shafik added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:8763 if (isLambdaCallOperator(Info.CurrentCall->Callee)) { - // Ensure we actually have captured 'this'. (an error will have - // been previously reported if not). + // Ensure we

[PATCH] D144634: [Clang][OpenMP] Support for Code Generation of loop bind clause

ronlieb added a comment. LIT Test ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144634/new/ https://reviews.llvm.org/D144634 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D144981: [Driver] Allow to collect `-save-stats` data to a file specified in the environment variable.

vsapsai planned changes to this revision. vsapsai added inline comments. Comment at: clang/lib/Frontend/CompilerInstance.cpp:1093 +StatsFile, EC, +llvm::sys::fs::OF_Append | llvm::sys::fs::OF_TextWithCRLF); if (EC) { ahatanak wrote: >

[PATCH] D145101: [clang][deps] NFC: Simplify worker loop

benlangmuir accepted this revision. benlangmuir added a comment. This revision is now accepted and ready to land. > I guess it was originally done this way because we have a number of > DependencyScanning{Tool,Worker} instances Oh of course, this makes sense. Yeah we could maybe find a

[PATCH] D144285: [Clang] Implement CWG2518 - static_assert(false)

rupprecht added a comment. Here's one change this patch causes on "real" code (invalid code, but something a user might try to compile): we see is a static_assert in gmock that now fails to report a useful error message: https://godbolt.org/z/sPr1PYT9d Previously we saw `error: static

[PATCH] D144864: [Flang][Driver][MLIR] Add -fopenmp-is-device to Flang and link to an omp.is_device attribute

agozillon added a comment. After asking @jsjodin and @skatrak for some input on additional tests that could be added and having a look around the existing tests we couldn't really come up with any additional tests to add to the ones that are in the patch at the moment (inside of

[PATCH] D144864: [Flang][Driver][MLIR] Add -fopenmp-is-device to Flang and link to an omp.is_device attribute

agozillon updated this revision to Diff 501645. agozillon added a comment. - [Flang][mlir] Adding space at the end of the omp-is-device test file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144864/new/ https://reviews.llvm.org/D144864 Files:

[PATCH] D145093: Add map info for dereference pointer.

ABataev added inline comments. Comment at: clang/test/OpenMP/target_map_deref_array_codegen.cpp:17 +(*t1d)[j] = 1; + #pragma omp target map(to: (*t1d)[0:3]) +(*t1d)[2] = 2; Is this correct at all? This is not a pointer to the array, it is an array of

[PATCH] D145101: [clang][deps] NFC: Simplify worker loop

jansvoboda11 added inline comments. Comment at: clang/tools/clang-scan-deps/ClangScanDeps.cpp:802 for (unsigned I = 0; I < Pool.getThreadCount(); ++I) { -Pool.async([I, , , , , , , , -, ]() { +Pool.async([&, I]() { llvm::StringSet<>

[PATCH] D144977: [analyzer] Fix of the initialization list parsing.

NoQ added a comment. Hi, looks very interesting! We definitely have troubles with some initializer lists. It looks like you're primarily interested in the alpha/unsupported checker, but your patch probably affects behavior of the default setup as well. If you've found any difference in

[PATCH] D138275: [clang][Interp] Avoid leaking init maps of local primitive arrays

aaron.ballman added a comment. Generally LGTM though I had a suggestion that might help some of Erich's concerns. FWIW, I share his concerns about memory ownership in the interpreter becoming convoluted Comment at: clang/lib/AST/Interp/InterpFrame.h:51-53 + /// InterpFrame

[PATCH] D143334: [clang][Interp] Fix diagnosing uninitialized ctor record arrays

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/Interp.cpp:390 - if (isa(ElemType.getTypePtr())) { + if (ElemType->isRecordType()) { const Record *R = BasePtr.getElemRecord(); The difference between these two is that

[PATCH] D145101: [clang][deps] NFC: Simplify worker loop

benlangmuir added inline comments. Comment at: clang/tools/clang-scan-deps/ClangScanDeps.cpp:802 for (unsigned I = 0; I < Pool.getThreadCount(); ++I) { -Pool.async([I, , , , , , , , -, ]() { +Pool.async([&, I]() { llvm::StringSet<>

[PATCH] D145098: [clang][deps] Preserve input ordering in the full output

jansvoboda11 marked 2 inline comments as done. jansvoboda11 added inline comments. Comment at: clang/tools/clang-scan-deps/ClangScanDeps.cpp:788 + if (Format == ScanningOutputFormat::Full && ModuleName.empty()) +FD.resize(Inputs.size()); + benlangmuir

[PATCH] D143418: [libclang] Add API to override preamble storage path

aaron.ballman added inline comments. Comment at: clang/include/clang-c/Index.h:329 + * CXIndexOptions Opts = { sizeof(CXIndexOptions), + * clang_getDefaultGlobalOptions() }; + * \endcode vedgy wrote: > When I almost finished the requested

[PATCH] D145098: [clang][deps] Preserve input ordering in the full output

jansvoboda11 updated this revision to Diff 501619. jansvoboda11 added a comment. Add asserts, make `FullDeps` take `NumInputs` in the constructor. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145098/new/ https://reviews.llvm.org/D145098 Files:

[PATCH] D145098: [clang][deps] Preserve input ordering in the full output

benlangmuir added inline comments. Comment at: clang/tools/clang-scan-deps/ClangScanDeps.cpp:291 -std::unique_lock ul(Lock); -Inputs.push_back(std::move(ID)); +Inputs[InputIndex] = std::move(ID); } Since the input index is coming from "outside":

[PATCH] D145101: [clang][deps] NFC: Simplify worker loop

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, benlangmuir. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch simplifies

[PATCH] D144866: [clang] Fix aggregate initialization inside lambda constexpr

shafik added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:8763 if (isLambdaCallOperator(Info.CurrentCall->Callee)) { - // Ensure we actually have captured 'this'. (an error will have - // been previously reported if not). + // Ensure we

[PATCH] D144709: [clang-format] Improve QualifierAlignment

HazardyKnusperkeks added a comment. In D144709#4160940 , @AlexanderHederstaf wrote: > In D144709#4160820 , > @MyDeveloperDay wrote: > >> As tests currently fail can you set it to "planned changes" until they

[PATCH] D145098: [clang][deps] Preserve input ordering in the full output

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, benlangmuir. Herald added subscribers: ributzka, mgrang. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch

[PATCH] D145093: Add map info for dereference pointer.

jyu2 created this revision. jyu2 added reviewers: ABataev, mikerice, jdoerfert. jyu2 added a project: OpenMP. Herald added a project: All. jyu2 requested review of this revision. Herald added subscribers: openmp-commits, cfe-commits, sstefan1. Herald added a project: clang. This is to fix run

[PATCH] D141008: [Clang][SPIR-V] Emit target extension types for OpenCL types on SPIR-V.

jcranmer-intel added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:10986 + // for more details). + SmallVector IntParams = {0, 0, 0, 0, 0, 0}; + Anastasia wrote: > I think the list initialization doesn't do what you are trying to achieve >

[PATCH] D141008: [Clang][SPIR-V] Emit target extension types for OpenCL types on SPIR-V.

jcranmer-intel updated this revision to Diff 501594. jcranmer-intel added a comment. Documentation tweaks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141008/new/ https://reviews.llvm.org/D141008 Files: clang/include/clang-c/Index.h

[PATCH] D144672: [Sanitizers] Error when attempting to use `static-lsan` with `TSan` or `Asan` on darwin

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4e7d40e0928c: [Sanitizers] Error out for -static-libsan on darwin (authored by usama54321). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 4e7d40e - [Sanitizers] Error out for -static-libsan on darwin

Author: usama hameed Date: 2023-03-02T00:07:03+05:00 New Revision: 4e7d40e0928cfe448ba947d2a67895fccaa3535f URL: https://github.com/llvm/llvm-project/commit/4e7d40e0928cfe448ba947d2a67895fccaa3535f DIFF: https://github.com/llvm/llvm-project/commit/4e7d40e0928cfe448ba947d2a67895fccaa3535f.diff

[PATCH] D124351: [Clang] Implement Change scope of lambda trailing-return-type

shafik accepted this revision. shafik added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124351/new/ https://reviews.llvm.org/D124351 ___ cfe-commits mailing list

[PATCH] D144603: Add option to disable compiler launcher on external projects

phosek added a comment. I agree, in that case let's remove `C_COMPILER_LAUNCHER;CXX_COMPILER_LAUNCHER` from the list of default passthrough variables which seems like a reasonable default, and provide `CLANG_BOOTSTRAP_EXTRA_PASSTHROUGH` so developers have a way to pass these through to the

[PATCH] D144934: [clang] drop buggy use of `-serialize-diagnostics` flag

ashay-github added a comment. > For pure test updates, best to include `[test] `in the subject :) Ah, sorry! Thanks for letting me know, I'll keep that in mind for the future. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144934/new/

[PATCH] D144603: Add option to disable compiler launcher on external projects

smeenai added a comment. In D144603#4162192 , @haowei wrote: > In D144603#4162048 , @smeenai wrote: > >> Hmm, what cache key does ccache use for compilers? Is it the `--version` >> output string, the path, or

[PATCH] D144934: [clang] drop buggy use of `-serialize-diagnostics` flag

MaskRay added a comment. For pure test updates, best to include `[test] `in the subject :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144934/new/ https://reviews.llvm.org/D144934 ___ cfe-commits

[PATCH] D144603: Add option to disable compiler launcher on external projects

haowei added a comment. In D144603#4162048 , @smeenai wrote: > Hmm, what cache key does ccache use for compilers? Is it the `--version` > output string, the path, or some combination? If the path is involved then I > don't see any value in using ccache

[PATCH] D145077: [clang][DebugInfo] Support DW_AT_LLVM_preferred_name attribute

Michael137 updated this revision to Diff 501569. Michael137 added a comment. - Update test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145077/new/ https://reviews.llvm.org/D145077 Files: clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D145077: [clang][DebugInfo] Support DW_AT_LLVM_preferred_name attribute

Michael137 updated this revision to Diff 501568. Michael137 added a comment. - Add test case for multiple alias templates Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145077/new/ https://reviews.llvm.org/D145077 Files:

[PATCH] D144454: Add builtin for llvm set rounding

rjmccall added a comment. In D144454#4157717 , @xiongji90 wrote: > In D144454#4142253 , @rjmccall > wrote: > >> New builtins should be documented in the user manual. >> >> There are standard pragmas for changing

[PATCH] D144672: [Sanitizers] Error when attempting to use `static-lsan` with `TSan` or `Asan` on darwin

dmaclach added a comment. @usama54321 or @yln are you able to commit for me? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144672/new/ https://reviews.llvm.org/D144672 ___ cfe-commits mailing list

[PATCH] D145077: [clang][DebugInfo] Support DW_AT_LLVM_preferred_name attribute

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. I originally was hoping we wouldn't have to introduce a new attribute for this, but it looks like there are legitimate concerns about the alternatives, so in that sense this looks good!

[PATCH] D143418: [libclang] Add API to override preamble storage path

vedgy marked 2 inline comments as done. vedgy added inline comments. Comment at: clang/include/clang-c/Index.h:329 + * CXIndexOptions Opts = { sizeof(CXIndexOptions), + * clang_getDefaultGlobalOptions() }; + * \endcode When I almost

[PATCH] D144603: Add option to disable compiler launcher on external projects

smeenai added a comment. Hmm, what cache key does ccache use for compilers? Is it the `--version` output string, the path, or some combination? If the path is involved then I don't see any value in using ccache for configuring anything past stage1, since the compiler will (presumably) be

[PATCH] D143418: [libclang] Add API to override preamble storage path

vedgy updated this revision to Diff 501559. vedgy added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143418/new/ https://reviews.llvm.org/D143418 Files: clang-tools-extra/clangd/Preamble.cpp

[PATCH] D128648: [Clang][AArch64][SME] Add vector read/write (mova) intrinsics

bryanpkc added inline comments. Comment at: clang/include/clang/Basic/arm_sme.td:103 +def NAME # _H : SInst<"svwrite_hor_" # n_suffix # "[_{d}]", "vimiPd", t, MergeOp1, + "aarch64_sme_write" # !cond(!eq(n_suffix, "za128") : "q", true: "") #

[PATCH] D144878: __builtin_FILE_NAME()

karapsinie marked an inline comment as done. karapsinie added a comment. If all is well, approve and merge the commit. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144878/new/ https://reviews.llvm.org/D144878 ___ cfe-commits mailing list

[PATCH] D145077: [clang][DebugInfo] Support DW_AT_LLVM_preferred_name attribute

Michael137 added a comment. Since the new attribute only gets attached to a structure definition, and the preferred_name attribute is currently only really used in a handful of places in libcxx, this practically doesn't affect debug-info size Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D145077: [clang][DebugInfo] Support DW_AT_LLVM_preferred_name attribute

Michael137 updated this revision to Diff 501544. Michael137 added a comment. - clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145077/new/ https://reviews.llvm.org/D145077 Files: clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D143233: [Clang][CodeGen] Fix this argument type for certain destructors

aaron.ballman added a comment. In D143233#4160206 , @efriedma wrote: > Maybe worth cherry-picking to 16 branch? I think someone will need to rebase > onto the branch for that, though; there was merge conflict on the > microsoft-abi-eh-cleanups.cpp

[PATCH] D145021: [Clang][AIX][p] Claim -p in front end

daltenty added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:6327 } - if (Arg *A = Args.getLastArgNoClaim(options::OPT_p)) { + if (Arg *A = Args.getLastArg(options::OPT_p)) { if (TC.getTriple().isOSAIX()) { Actually, a question

[PATCH] D145077: [clang][DebugInfo] Support DW_AT_LLVM_preferred_name attribute

Michael137 updated this revision to Diff 501540. Michael137 added a comment. - Remove redundant TODO Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145077/new/ https://reviews.llvm.org/D145077 Files: clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D145021: [Clang][AIX][p] Claim -p in front end

daltenty accepted this revision. daltenty added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145021/new/ https://reviews.llvm.org/D145021

[PATCH] D144622: [clang][ASTImporter] Import TemplateName correctly

balazske updated this revision to Diff 501539. balazske added a comment. Updated the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144622/new/ https://reviews.llvm.org/D144622 Files: clang/lib/AST/ASTImporter.cpp

[PATCH] D145077: [clang][DebugInfo] Support DW_AT_LLVM_preferred_name attribute

Michael137 created this revision. Michael137 added reviewers: aprantl, dblaikie. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. With this patch, we now emit a `DW_AT_LLVM_preferred_name` for the

[PATCH] D144934: [clang] drop buggy use of `-serialize-diagnostics` flag

This revision was automatically updated to reflect the committed changes. Closed by commit rG969ab7134f4d: [clang] drop buggy use of `-serialize-diagnostics` flag (authored by ashay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144934/new/

[clang] 969ab71 - [clang] drop buggy use of `-serialize-diagnostics` flag

Author: Ashay Rane Date: 2023-03-01T10:53:39-06:00 New Revision: 969ab7134f4df52a5887a49006c703515163ee22 URL: https://github.com/llvm/llvm-project/commit/969ab7134f4df52a5887a49006c703515163ee22 DIFF: https://github.com/llvm/llvm-project/commit/969ab7134f4df52a5887a49006c703515163ee22.diff

[PATCH] D140794: [ASTMatcher] Add coroutineBodyStmt matcher

aaron.ballman added a comment. In D140794#4160358 , @ccotter wrote: > Thanks both! Assuming this passes build, would one of you mind committing > this for me? `Chris Cotter ` Happy to do so! I've landed it on your behalf in

[clang] dcf5ad8 - [ASTMatcher] Add coroutineBodyStmt matcher

Author: Chris Cotter Date: 2023-03-01T11:51:46-05:00 New Revision: dcf5ad89dcc5cc69b9df3e5dd9be71c65642f519 URL: https://github.com/llvm/llvm-project/commit/dcf5ad89dcc5cc69b9df3e5dd9be71c65642f519 DIFF: https://github.com/llvm/llvm-project/commit/dcf5ad89dcc5cc69b9df3e5dd9be71c65642f519.diff

[PATCH] D140794: [ASTMatcher] Add coroutineBodyStmt matcher

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdcf5ad89dcc5: [ASTMatcher] Add coroutineBodyStmt matcher (authored by ccotter, committed by aaron.ballman). Repository: rG LLVM Github Monorepo

[PATCH] D145075: [clangd] Show used symbol on include hover.

VitaNuo created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. VitaNuo requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Monorepo

  1   2   >