[PATCH] D143418: [libclang] Add API to override preamble storage path

vedgy added inline comments. Comment at: clang/include/clang-c/Index.h:329 + * CXIndexOptions Opts = { sizeof(CXIndexOptions), + * clang_getDefaultGlobalOptions() }; + * \endcode aaron.ballman wrote: > vedgy wrote: > > vedgy wrote: > > >

[PATCH] D144709: [clang-format] Improve QualifierAlignment

AlexanderHederstaf added a comment. Thanks for the comments and help on this review. There are a lot of special cases I had not considered before, and while it works on the clang/ and llvm/ subfolders as well as tests and the other repository I tested on, I suppose there could still be some

[PATCH] D144707: [C++20] [Modules] Deprecate to load C++20 Named Modules eagerly

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG57833636816a: [C++20] [Modules] Deprecate to load C++20 Modules eagerly (authored by ChuanqiXu). Repository: rG LLVM Github Monorepo CHANGES

[clang] 5783363 - [C++20] [Modules] Deprecate to load C++20 Modules eagerly

Author: Chuanqi Xu Date: 2023-03-03T14:25:33+08:00 New Revision: 57833636816a13ccda53714413c532dc81e3b5ff URL: https://github.com/llvm/llvm-project/commit/57833636816a13ccda53714413c532dc81e3b5ff DIFF: https://github.com/llvm/llvm-project/commit/57833636816a13ccda53714413c532dc81e3b5ff.diff

[PATCH] D144454: Add builtin for llvm set rounding

sepavloff added a comment. In D144454#4163688 , @rjmccall wrote: > I see. If we're going to take the target-independent values specified by > `FLT_ROUNDS`, then the original builtin name is more appropriate. Of course, > this has the disadvantage of

[PATCH] D145138: [clang-tidy] Implement FixIts for C arrays

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/AvoidCArraysCheck.cpp:588 +: ClangTidyCheck(Name, Context), + IncludeInserter(Options.getLocalOrGlobal("IncludeStyle", +

[PATCH] D145138: [clang-tidy] Implement FixIts for C arrays

ccotter marked 2 inline comments as done. ccotter added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/AvoidCArraysCheck.cpp:588 +: ClangTidyCheck(Name, Context), + IncludeInserter(Options.getLocalOrGlobal("IncludeStyle", +

[PATCH] D145138: [clang-tidy] Implement FixIts for C arrays

ccotter updated this revision to Diff 502040. ccotter added a comment. - Add option doc, remove auto Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145138/new/ https://reviews.llvm.org/D145138 Files:

[clang] 5828692 - [C++20] [Modules] Make TheImplicitGlobalModuleFragment and TheExportedImplicitGlobalModuleFragment to be useable modules

Author: Chuanqi Xu Date: 2023-03-03T11:15:29+08:00 New Revision: 5828692f70bc5f92fad9ed21a1844044924680aa URL: https://github.com/llvm/llvm-project/commit/5828692f70bc5f92fad9ed21a1844044924680aa DIFF: https://github.com/llvm/llvm-project/commit/5828692f70bc5f92fad9ed21a1844044924680aa.diff

[PATCH] D144367: [C++20] [Modules] Support to export declarations in the language linkage

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbf52ead24ca4: [C++20] [Modules] Support to export declarations in language linkage (authored by ChuanqiXu). Herald added a project: clang. Herald

[clang] bf52ead - [C++20] [Modules] Support to export declarations in language linkage

Author: Chuanqi Xu Date: 2023-03-03T10:31:48+08:00 New Revision: bf52ead24ca4fe1b73bceec7bba3abfe15541649 URL: https://github.com/llvm/llvm-project/commit/bf52ead24ca4fe1b73bceec7bba3abfe15541649 DIFF: https://github.com/llvm/llvm-project/commit/bf52ead24ca4fe1b73bceec7bba3abfe15541649.diff

[PATCH] D143128: [-Wunsafe-buffer-usage] Fix-Its transforming `[any]` to `(DRE.data() + any)`

NoQ added a comment. In D143128#4108502 , @ziqingluo-90 wrote: > In D143128#4108375 , @NoQ wrote: > >> Why do we prefer `DRE.data() + any` to `()[any]`? It could be much >> less intrusive this way, and the

[PATCH] D144977: [analyzer] Fix of the initialization list parsing.

isuckatcs added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/CStringChecker.cpp:432 + const LocationContext *LCtx = C.getLocationContext(); + SVal SrcVal = State->getSVal(Buffer.Expression, LCtx); + QualType SourceValType =

[PATCH] D145047: Fix broken link on Clang documentation page

tupaschoal added a comment. In D145047#4164976 , @royjacobson wrote: > Thanks! Do you need me to land this for you? If so, could you please provide > name + email to sign the commit with? Yes, please! Tulio Leao Repository: rG LLVM Github

[PATCH] D145201: [clang] fixes header processing for `-fdiagnostics-format=sarif`

cjdb updated this revision to Diff 502021. cjdb added a comment. fixes something that wasn't supposed to be changed in the rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145201/new/ https://reviews.llvm.org/D145201 Files:

[PATCH] D145201: [clang] fixes header processing for `-fdiagnostics-format=sarif`

cjdb updated this revision to Diff 502020. cjdb added a comment. actually commits the files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145201/new/ https://reviews.llvm.org/D145201 Files: clang/include/clang/Frontend/SARIFDiagnostic.h

[PATCH] D145178: [clang][NFC] reformats the SARIF diagnostic test so it's human readable

cjdb updated this revision to Diff 502019. cjdb added a comment. removes something from a future commit This should be the final alteration pre-review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145178/new/ https://reviews.llvm.org/D145178

[PATCH] D144672: [Sanitizers] Error when attempting to use `static-lsan` with `TSan` or `Asan` on darwin

yln added inline comments. Comment at: compiler-rt/test/asan/TestCases/replaceable_new_delete_static.cpp:10-11 + +// darwin only supports shared-libsan, so this should fail. +// XFAIL: darwin + zixuw wrote: > dmaclach wrote: > > yln wrote: > > > This should

[PATCH] D144672: [Sanitizers] Error when attempting to use `static-lsan` with `TSan` or `Asan` on darwin

zixuw added inline comments. Comment at: compiler-rt/test/asan/TestCases/replaceable_new_delete_static.cpp:10-11 + +// darwin only supports shared-libsan, so this should fail. +// XFAIL: darwin + dmaclach wrote: > yln wrote: > > This should work, right? > No..

[PATCH] D145150: clang: Emit nofpclass(nan inf) for -ffinite-math-only

arsenm updated this revision to Diff 502015. arsenm added a comment. Drop todo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145150/new/ https://reviews.llvm.org/D145150 Files: clang/lib/CodeGen/CGCall.cpp clang/test/CodeGen/complex-math.c

[PATCH] D144672: [Sanitizers] Error when attempting to use `static-lsan` with `TSan` or `Asan` on darwin

dmaclach added inline comments. Comment at: compiler-rt/test/asan/TestCases/replaceable_new_delete_static.cpp:10-11 + +// darwin only supports shared-libsan, so this should fail. +// XFAIL: darwin + yln wrote: > This should work, right? No.. darwin should fail

[PATCH] D144709: [clang-format] Improve QualifierAlignment

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. Firstly let me say thank you for this review, your perseverance demonstrates to me that there is a desire to make this capability better, which tells me that a feature that

[PATCH] D145201: [clang] fixes header processing for `-fdiagnostics-format=sarif`

cjdb created this revision. cjdb added reviewers: aaron.ballman, shafik, erichkeane. Herald added a project: All. cjdb requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Including headers used to fire an assertion; now they report a

[PATCH] D144309: [HLSL] add max/min library functions

bob80905 updated this revision to Diff 502009. bob80905 added a comment. - only run tests if 16 bit is enabled Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144309/new/ https://reviews.llvm.org/D144309 Files:

[PATCH] D145021: [Clang][AIX][p] Claim -p in front end

francii updated this revision to Diff 502006. francii added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145021/new/ https://reviews.llvm.org/D145021 Files: clang/lib/Driver/ToolChains/AIX.cpp

[PATCH] D144672: [Sanitizers] Error when attempting to use `static-lsan` with `TSan` or `Asan` on darwin

yln added inline comments. Comment at: compiler-rt/test/asan/TestCases/replaceable_new_delete_static.cpp:10-11 + +// darwin only supports shared-libsan, so this should fail. +// XFAIL: darwin + This should work, right? Repository: rG LLVM Github Monorepo

[PATCH] D145197: [clang][deps] NFC: Refactor and comment ModuleDeps sorting

jansvoboda11 created this revision. jansvoboda11 added a reviewer: Bigcheese. Herald added subscribers: ributzka, mgrang. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. I once again stumbled

[PATCH] D144977: [analyzer] Fix of the initialization list parsing.

earnol requested review of this revision. earnol added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RegionStore.cpp:1787 + if (V && + (!targetType->isStructureOrClassType() && !targetType->isUnionType())) return *V; isuckatcs wrote: > I

[PATCH] D145178: [clang][NFC] reformats the SARIF diagnostic test so it's human readable

cjdb updated this revision to Diff 501982. cjdb added a comment. removes redundant line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145178/new/ https://reviews.llvm.org/D145178 Files: clang/test/Frontend/sarif-diagnostics.cpp Index:

[PATCH] D145187: [Fuchsia] Add other necessary components to LLDB install.

mysterymath created this revision. mysterymath added reviewers: phosek, haowei. Herald added a subscriber: abrachet. Herald added a project: All. mysterymath requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github

[PATCH] D145101: [clang][deps] NFC: Simplify worker loop

This revision was automatically updated to reflect the committed changes. Closed by commit rG9679075a1ae6: [clang][deps] NFC: Simplify worker loop (authored by jansvoboda11). Changed prior to commit: https://reviews.llvm.org/D145101?vs=501616=501969#toc Repository: rG LLVM Github Monorepo

[PATCH] D144603: Add option to disable compiler launcher on external projects

fangism added a comment. In D144603#4163751 , @phosek wrote: > In D144603#4162974 , @haowei wrote: > >> I think remove the compiler launcher from default pass through flags are >> fine. What about the using

[clang] 9679075 - [clang][deps] NFC: Simplify worker loop

Author: Jan Svoboda Date: 2023-03-02T13:50:08-08:00 New Revision: 9679075a1ae6a20ed102597bf166b3f3adc95499 URL: https://github.com/llvm/llvm-project/commit/9679075a1ae6a20ed102597bf166b3f3adc95499 DIFF: https://github.com/llvm/llvm-project/commit/9679075a1ae6a20ed102597bf166b3f3adc95499.diff

[PATCH] D144977: [analyzer] Fix of the initialization list parsing.

earnol planned changes to this revision. earnol added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RegionStore.cpp:564-565 - SVal getBindingForElement(RegionBindingsConstRef B, const ElementRegion *R); + SVal getBindingForElement(RegionBindingsConstRef B, const

[PATCH] D145098: [clang][deps] Preserve input ordering in the full output

This revision was automatically updated to reflect the committed changes. Closed by commit rG864054500830: [clang][deps] Preserve input ordering in the full output (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145098/new/

[clang] 8640545 - [clang][deps] Preserve input ordering in the full output

Author: Jan Svoboda Date: 2023-03-02T13:42:11-08:00 New Revision: 864054500830d708cc9f7d8a53195a95488e4e0b URL: https://github.com/llvm/llvm-project/commit/864054500830d708cc9f7d8a53195a95488e4e0b DIFF: https://github.com/llvm/llvm-project/commit/864054500830d708cc9f7d8a53195a95488e4e0b.diff

[PATCH] D144309: [HLSL] add max/min library functions

python3kgae added inline comments. Comment at: clang/test/CodeGenHLSL/builtins/max.hlsl:12 +// NO_HALF: call i16 @llvm.smax.i16( +int16_t test_max_short ( int16_t p0, int16_t p1 ) { + return max ( p0, p1 ); Just guard 16bit integer tests with #ifdef

[PATCH] D144309: [HLSL] add max/min library functions

bob80905 updated this revision to Diff 501963. bob80905 added a comment. - use already defined hlsl types Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144309/new/ https://reviews.llvm.org/D144309 Files: clang/lib/Headers/hlsl/hlsl_intrinsics.h

[PATCH] D144454: Add builtin for llvm set rounding

rjmccall added a comment. `__builtin_set_flt_rounds` seems better. We should add the portability checking, yeah. Look at the checking we do for certain builtins with `CheckBuiltinTargetInSupported` in `SemaChecking.cpp`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D145178: [clang][NFC] reformats the SARIF diagnostic test so it's human readable

cjdb updated this revision to Diff 501955. cjdb added a comment. renames check identifiers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145178/new/ https://reviews.llvm.org/D145178 Files: clang/test/Frontend/sarif-diagnostics.cpp Index:

[PATCH] D145178: [clang][NFC] reformats the SARIF diagnostic test so it's human readable

cjdb added inline comments. Comment at: clang/test/Frontend/sarif-diagnostics.cpp:31 +// RUN: %clang -fsyntax-only -Wall -Wextra -fdiagnostics-format=sarif-stderr %s > %t.txt 2>&1 || true +// RUN: FileCheck -dump-input=always %s --input-file=%t.txt

[PATCH] D145178: [clang][NFC] reformats the SARIF diagnostic test so it's human readable

cjdb added inline comments. Comment at: clang/test/Frontend/sarif-diagnostics.cpp:31 +// RUN: %clang -fsyntax-only -Wall -Wextra -fdiagnostics-format=sarif-stderr %s > %t.txt 2>&1 || true +// RUN: FileCheck -dump-input=always %s --input-file=%t.txt

[PATCH] D145178: [clang][NFC] reformats the SARIF diagnostic test so it's human readable

cjdb created this revision. cjdb added reviewers: aaron.ballman, shafik, erichkeane. Herald added a project: All. cjdb requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The current FileCheck test output is very difficult to read, which makes

[PATCH] D145093: Add map info for dereference pointer.

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:7487-7497 + auto TNext = Next; + bool IsVarDerefAssoWithArray = false; + if (UO && UO->getOpcode() == UO_Deref) +for (; TNext != CE; TNext = std::next(TNext)) + if

[PATCH] D145093: Add map info for dereference pointer.

jyu2 added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:7487-7497 + auto TNext = Next; + bool IsVarDerefAssoWithArray = false; + if (UO && UO->getOpcode() == UO_Deref) +for (; TNext != CE; TNext = std::next(TNext)) + if

[PATCH] D138539: Use std::nullopt_t instead of NoneType (NFC)

MaskRay added a comment. In D138539#4164313 , @steakhal wrote: > Oh, I forgot to mention why this change breaks the equality operator of > `llvm::StringSet`. It's because the `StringMap::operator==` will try to > compare the `value` as well, which is

[clang] 554ba99 - Revert "[Clang] Refactor "Designators" into a unified implementation [NFC]"

Author: Bill Wendling Date: 2023-03-02T12:09:29-08:00 New Revision: 554ba996956559acdab777d18999b9985d95be4c URL: https://github.com/llvm/llvm-project/commit/554ba996956559acdab777d18999b9985d95be4c DIFF: https://github.com/llvm/llvm-project/commit/554ba996956559acdab777d18999b9985d95be4c.diff

[PATCH] D141230: [clang-format-diff.py] give clang-format-diff a job pool (10x speed)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd14e7ee3d17c: [clang-format] Add -j to clang-format-diff to speed up formatting (authored by seanptmaher, committed by owenpan). Repository: rG

[clang] d14e7ee - [clang-format] Add -j to clang-format-diff to speed up formatting

Author: Sean Maher Date: 2023-03-02T11:59:11-08:00 New Revision: d14e7ee3d17cfa60d44256d742c10e9949a6048f URL: https://github.com/llvm/llvm-project/commit/d14e7ee3d17cfa60d44256d742c10e9949a6048f DIFF: https://github.com/llvm/llvm-project/commit/d14e7ee3d17cfa60d44256d742c10e9949a6048f.diff

[PATCH] D145093: Add map info for dereference pointer.

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:7487-7497 + auto TNext = Next; + bool IsVarDerefAssoWithArray = false; + if (UO && UO->getOpcode() == UO_Deref) +for (; TNext != CE; TNext = std::next(TNext)) + if

[PATCH] D143418: [libclang] Add API to override preamble storage path

aaron.ballman added inline comments. Comment at: clang/include/clang-c/Index.h:329 + * CXIndexOptions Opts = { sizeof(CXIndexOptions), + * clang_getDefaultGlobalOptions() }; + * \endcode vedgy wrote: > vedgy wrote: > > aaron.ballman

[PATCH] D144309: [HLSL] add max/min library functions

python3kgae added a comment. In D144309#4159431 , @bob80905 wrote: > - ushort is now unsigned Use uint16_t/int16_t/uint64_t/int64_t for 16/64 bit integers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 5680b75 - [C2x] Add tests for WG14 N3035 and update the C status page

Author: Aaron Ballman Date: 2023-03-02T14:36:50-05:00 New Revision: 5680b7570342c3457b80d3129fe60e53ef7ddfd5 URL: https://github.com/llvm/llvm-project/commit/5680b7570342c3457b80d3129fe60e53ef7ddfd5 DIFF: https://github.com/llvm/llvm-project/commit/5680b7570342c3457b80d3129fe60e53ef7ddfd5.diff

[PATCH] D145093: Add map info for dereference pointer.

jyu2 added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:7487-7497 + auto TNext = Next; + bool IsVarDerefAssoWithArray = false; + if (UO && UO->getOpcode() == UO_Deref) +for (; TNext != CE; TNext = std::next(TNext)) + if

[PATCH] D144967: [PowerPC] Recognize long CPU name for -mtune in Clang

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG59cd692454c9: [PowerPC] Recognize long CPU name for -mtune in Clang (authored by nemanjai). Changed prior to commit:

[clang] 59cd692 - [PowerPC] Recognize long CPU name for -mtune in Clang

Author: Nemanja Ivanovic Date: 2023-03-02T14:29:40-05:00 New Revision: 59cd692454c9430f0fb77ca14b65cb9afcfe2776 URL: https://github.com/llvm/llvm-project/commit/59cd692454c9430f0fb77ca14b65cb9afcfe2776 DIFF:

[PATCH] D144309: [HLSL] add max/min library functions

bob80905 updated this revision to Diff 501933. bob80905 added a comment. - format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144309/new/ https://reviews.llvm.org/D144309 Files: clang/lib/Headers/hlsl/hlsl_intrinsics.h

[PATCH] D144884: [clang-format] Only add pragma continuation indentation for 'omp' clauses

jhuber6 added a comment. In D144884#4165192 , @MyDeveloperDay wrote: > without this change what does this look like? > > EXPECT_EQ( > "#pragma omp target \\\n" > "reduction(+ : var) \\\n" > "map(to : A[0 : N]) \\\n"

[PATCH] D145164: [clang][RISCV] Enable -fasynchronous-unwind-tables by default on Linux

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. LG since GCC made a similar change and this matches several major architectures on Linux/other ELF based operating systems. (At heart I think `-fasynchronous-unwind-tables` is not a good

[PATCH] D145088: [RISCV] Add attribute(riscv_rvv_vector_bits(N)) based on AArch64 arm_sve_vector_bits.

craig.topper added a comment. In D145088#4165180 , @tschuett wrote: > Any binary that uses this feature is not forward portable to hardware > with a larger vector size. That's true for SVE as well. > > I did not understood this sentence. AFAIK, SVE

[PATCH] D144884: [clang-format] Only add pragma continuation indentation for 'omp' clauses

MyDeveloperDay added a comment. without this change what does this look like? EXPECT_EQ( "#pragma omp target \\\n" "reduction(+ : var) \\\n" "map(to : A[0 : N]) \\\n" "map(to : B[0 : N]) \\\n" "map(from : C[0 : N]) \\\n" "

[PATCH] D145021: [Clang][AIX][p] Claim -p in front end

francii updated this revision to Diff 501929. francii added a comment. Update based on review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145021/new/ https://reviews.llvm.org/D145021 Files: clang/lib/Driver/ToolChains/AIX.cpp

[PATCH] D145088: [RISCV] Add attribute(riscv_rvv_vector_bits(N)) based on AArch64 arm_sve_vector_bits.

tschuett added a comment. Any binary that uses this feature is not forward portable to hardware with a larger vector size. That's true for SVE as well. I did not understood this sentence. AFAIK, SVE uses the ptrue instruction to generate a mask to only activate the necessary lanes. If I do

[PATCH] D145093: Add map info for dereference pointer.

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:7487-7497 + auto TNext = Next; + bool IsVarDerefAssoWithArray = false; + if (UO && UO->getOpcode() == UO_Deref) +for (; TNext != CE; TNext = std::next(TNext)) + if

[PATCH] D145173: Make section attribute and -ffunction-sections play nicely

probinson created this revision. probinson added a reviewer: MaskRay. Herald added a project: All. probinson requested review of this revision. People use -ffunction-sections to put each function into its own object-file section; this makes linker garbage-collection simpler. However, if there's

[PATCH] D122258: [MC] Omit DWARF unwind info if compact unwind is present where eligible

jyknight added a comment. > no-compact-unwind is particularly useful for newer x86_64 platforms: we don't > want to omit DWARF unwind for x86_64 in general due to possible backwards > compat issues, but we should make it possible for people to opt into this > behavior if they are only

[PATCH] D144967: [PowerPC] Recognize long CPU name for -mtune in Clang

nemanjai added a comment. In D144967#4165140 , @nemanjai wrote: > I'll provide an updated patch in a few min... Ah, what I mean is I will update the patch and push in a few min. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D144967: [PowerPC] Recognize long CPU name for -mtune in Clang

nemanjai added a comment. I'll provide an updated patch in a few min... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144967/new/ https://reviews.llvm.org/D144967 ___ cfe-commits mailing list

[PATCH] D144967: [PowerPC] Recognize long CPU name for -mtune in Clang

MaskRay added a comment. In D144967#4164858 , @nathanchance wrote: > Could this be merged into `main` and backported to `release/16.x`? If this > makes 16.0.0 final, I think the kernel can avoid working around this issue > altogether, as `-mtune` was

[PATCH] D145093: Add map info for dereference pointer.

jyu2 added a comment. > Yes, I understand. And did not ask for it. I just mean that a[0][:3] emits > different mapping data - TARGET_PAPARM|TO|FROM, PTR_AND_OBJ|TO|FROM Oh I see. I was think alloc for adding pointer. But I now think I should just orignal maptype. Changed thanks.

[PATCH] D145093: Add map info for dereference pointer.

jyu2 updated this revision to Diff 501921. jyu2 added a comment. Thanks Alexey for the review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145093/new/ https://reviews.llvm.org/D145093 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D144884: [clang-format] Only add pragma continuation indentation for 'omp' clauses

jhuber6 added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:1280 +FormatToken *PragmaType = State.Line->First->Next->Next; +if (PragmaType && PragmaType->TokenText.equals("omp")) + return CurrentState.Indent + Style.ContinuationIndentWidth;

[PATCH] D144884: [clang-format] Only add pragma continuation indentation for 'omp' clauses

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:1280 +FormatToken *PragmaType = State.Line->First->Next->Next; +if (PragmaType && PragmaType->TokenText.equals("omp")) + return CurrentState.Indent +

[PATCH] D143704: [Flang] Part one of Feature List action

elmcdonough updated this revision to Diff 501919. elmcdonough added a comment. Clang format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143704/new/ https://reviews.llvm.org/D143704 Files: flang/examples/CMakeLists.txt

[PATCH] D142800: [Clang][Diagnostic] Add `-Wcomparison-op-parentheses` to warn on chained comparisons

aaron.ballman added a comment. In D142800#4104241 , @hazohelet wrote: >> Also, why are these diagnostics off by default? Do we have some idea as to >> the false positive rate? > > As for the false positive rate, I have checked for instances of this

[PATCH] D144903: [X86] Drop single use check for freeze(undef) in LowerAVXCONCAT_VECTORS

ManuelJBrito added a comment. I originally reverted it because of the wrong tag, but there were also some buildbot failures (see https://lab.llvm.org/buildbot/#/builders/139/builds/36736). It appears to be failing an assert in DiagnosticsEngine::DiagStateMap::append, but i'm not very familiar

[PATCH] D144622: [clang][ASTImporter] Import TemplateName correctly

donat.nagy accepted this revision. donat.nagy added a comment. LGTM as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144622/new/ https://reviews.llvm.org/D144622 ___ cfe-commits mailing list

[PATCH] D144273: [clang][ASTImporter] Add VaList declaration to lookup table.

donat.nagy added a comment. @balazske > I tried to find out how to add a correct test but could not check if this > fails or not on AArch64 platform. [...] I want to touch ASTContext only if a > test failure is found on AArch64 that makes it necessary. It's possible to "simulate" the AArch64

[PATCH] D145148: [Clang][CodeGen] Fix this argument type for certain destructors

jacobly abandoned this revision. jacobly added a comment. Following release cherry-pick workflow. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145148/new/ https://reviews.llvm.org/D145148 ___

[PATCH] D144672: [Sanitizers] Error when attempting to use `static-lsan` with `TSan` or `Asan` on darwin

dmaclach updated this revision to Diff 501899. dmaclach added a comment. Herald added subscribers: Sanitizers, Enna1. Updated with fixed tests for `replaceable_new_delete.cpp`. Split `replaceable_new_delete.cpp` into `replaceable_new_delete_shared.cpp` and `replaceable_new_delete_static.cpp`.

[PATCH] D145047: Fix broken link on Clang documentation page

royjacobson accepted this revision. royjacobson added a comment. Thanks! Do you need me to land this for you? If so, could you please provide name + email to sign the commit with? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145047/new/

[PATCH] D136864: [Clang] Create opaque type for AArch64 SVE2p1/SME2 svcount_t.

paulwalker-arm added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:730 ASTContext::BuiltinVectorTypeInfo Info = - CGM.getContext().getBuiltinVectorTypeInfo(BT); - unsigned NumElemsPerVG = (Info.EC.getKnownMinValue() * Info.NumVectors) / 2;

[PATCH] D141389: [DFSAN] Add support for strnlen, strncat, strsep, sscanf and _tolower

browneee added inline comments. Comment at: compiler-rt/lib/dfsan/dfsan_custom.cpp:221 + if (flags().strict_data_dependencies) { +*ret_label = res ? s_label : 0; + } else { tkuchta wrote: > browneee wrote: > > When `res != NULL`, then `res` is derived from

[PATCH] D145093: Add map info for dereference pointer.

ABataev added a comment. In D145093#4164877 , @jyu2 wrote: >> I mean we shall emit the same mapping for `(*a)[:3]` and for `a[0][:3]` > > Yes I mean emit (*a)[:3] as a[0][:3] > > The difficulty is during the process array section of >

[PATCH] D144638: [lit] Detect Inconsistent File Access Times

michaelplatings accepted this revision. michaelplatings added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144638/new/ https://reviews.llvm.org/D144638

[PATCH] D145072: [AMDGPU] Mark mbcnt as convergent

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG37114036aa57: [AMDGPU] Mark mbcnt as convergent (authored by yaxunl). Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D145093: Add map info for dereference pointer.

jyu2 added a comment. > I mean we shall emit the same mapping for `(*a)[:3]` and for `a[0][:3]` Yes I mean emit (*a)[:3] as a[0][:3] The difficulty is during the process array section of OMPArraySectionExpr 0x12aa37e0 '' lvalue | -ImplicitCastExpr 0x12a8a918 'int *' | | `-ArraySubscriptExpr

[clang] 3711403 - [AMDGPU] Mark mbcnt as convergent

Author: Yaxun (Sam) Liu Date: 2023-03-02T11:56:32-05:00 New Revision: 37114036aa57e53217a57afacd7f47b36114edfb URL: https://github.com/llvm/llvm-project/commit/37114036aa57e53217a57afacd7f47b36114edfb DIFF:

[PATCH] D145093: Add map info for dereference pointer.

ABataev added a comment. In D145093#4164854 , @jyu2 wrote: > In D145093#4164528 , @ABataev wrote: > >> What result produces `map(a[0][:3]`? > > Yes, that would be another way to fix the runtime problem. However

[PATCH] D144967: [PowerPC] Recognize long CPU name for -mtune in Clang

nathanchance added a comment. Could this be merged into `main` and backported to `release/16.x`? If this makes 16.0.0 final, I think the kernel can avoid working around this issue altogether, as `-mtune` was only wired up to do something on PowerPC in during the 16 development cycle; in prior

[PATCH] D145093: Add map info for dereference pointer.

jyu2 added a comment. In D145093#4164528 , @ABataev wrote: > What result produces `map(a[0][:3]`? Yes, that would be another way to fix the runtime problem. However the difficulty is when process array section, section base is different. with a[0][:3]

[PATCH] D141307: [WIP] Add -f[no-]loop-versioning option

Leporacanthicus updated this revision to Diff 501881. Leporacanthicus added a comment. Update for rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141307/new/ https://reviews.llvm.org/D141307 Files: clang/include/clang/Driver/Options.td

[PATCH] D145158: Make clang/test/C/C2x/n2934.c compatible with targets that do not support thread_local storage.

This revision was automatically updated to reflect the committed changes. Closed by commit rGbe646ef39298: Make clang/test/C/C2x/n2934.c compatible with targets that do not support… (authored by fanbo-meng). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] be646ef - Make clang/test/C/C2x/n2934.c compatible with targets that do not support thread_local storage.

Author: Fanbo Meng Date: 2023-03-02T11:18:19-05:00 New Revision: be646ef39298503592407fd7eac9ce7fc2ee5f7c URL: https://github.com/llvm/llvm-project/commit/be646ef39298503592407fd7eac9ce7fc2ee5f7c DIFF: https://github.com/llvm/llvm-project/commit/be646ef39298503592407fd7eac9ce7fc2ee5f7c.diff

[PATCH] D145164: [clang][RISCV] Enable -fasynchronous-unwind-tables by default on Linux

luismarques added a comment. From Kito's comment in D144174 : https://github.com/gcc-mirror/gcc/commit/3cd08f7168c196d7a481b9ed9f4289fd1f14eea8 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145164/new/

[PATCH] D143984: [DebugMetadata] Simplify handling subprogram's retainedNodes field. NFCI (1/7)

krisb added a comment. Friendly ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143984/new/ https://reviews.llvm.org/D143984 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D144940: [clang][ExtractAPI] Handle platform specific unavailability correctly

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG65f7a84cf38b: [clang][ExtractAPI] Handle platform specific unavailability correctly (authored by Arsenic, committed by dang). Repository: rG LLVM

[clang] 65f7a84 - [clang][ExtractAPI] Handle platform specific unavailability correctly

Author: Ankur Date: 2023-03-02T15:49:46Z New Revision: 65f7a84cf38b9839de0f29877d5ba4895848ea73 URL: https://github.com/llvm/llvm-project/commit/65f7a84cf38b9839de0f29877d5ba4895848ea73 DIFF: https://github.com/llvm/llvm-project/commit/65f7a84cf38b9839de0f29877d5ba4895848ea73.diff LOG:

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 updated this revision to Diff 501871. qiongsiwu1 added a comment. Updating `-fdata-sections` related comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144190/new/ https://reviews.llvm.org/D144190 Files:

[PATCH] D145150: clang: Emit nofpclass(nan inf) for -ffinite-math-only

jcranmer-intel added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2212 +static llvm::FPClassTest getNoFPClassTestMask(const LangOptions ) { + // TODO: Handle -fno-signaling-nans + llvm::FPClassTest Mask = llvm::fcNone; Clang doesn't have support

  1   2   >