[PATCH] D141215: [clang-repl] Introduce Value and implement pretty printing

junaire updated this revision to Diff 504038. junaire added a comment. Update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/include/clang/Basic/TokenKinds.def

[PATCH] D144878: __builtin_FILE_NAME()

karapsinie marked an inline comment as done. karapsinie added a comment. In D144878#4172639 , @aaron.ballman wrote: > In D144878#4171234 , @karapsinie > wrote: > >> PTAL. > > Have you seen the comments on the

[PATCH] D143306: [Driver] Default to -fno-openmp-implicit-rpath

MaskRay added a comment. In D143306#4183759 , @tstellar wrote: > Should we apply this patch to the release/16.x branch to create a more smooth > transition since the option has been removed in main? Yes, it will be a good idea to apply this to

[PATCH] D141672: [RISCV] Support vector crypto extension ISA string and assembly

4vtomat updated this revision to Diff 504034. 4vtomat added a comment. Resolved Craig's comments and rename *zvkns* files to *zvkned*. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141672/new/ https://reviews.llvm.org/D141672 Files:

[clang] 8592b3e - Revert "[NFC] Don't recompute Linkage for Decl in Release Modes"

Author: Chuanqi Xu Date: 2023-03-10T15:25:26+08:00 New Revision: 8592b3e1d2080d9f6b3102dfb5895ca390da44a0 URL: https://github.com/llvm/llvm-project/commit/8592b3e1d2080d9f6b3102dfb5895ca390da44a0 DIFF: https://github.com/llvm/llvm-project/commit/8592b3e1d2080d9f6b3102dfb5895ca390da44a0.diff

[clang] 87ba95a - [NFC] Don't recompute Linkage for Decl in Release Modes

Author: Chuanqi Xu Date: 2023-03-10T15:23:38+08:00 New Revision: 87ba95aa212a4fd363a4dd52677e9eea5224a4e7 URL: https://github.com/llvm/llvm-project/commit/87ba95aa212a4fd363a4dd52677e9eea5224a4e7 DIFF: https://github.com/llvm/llvm-project/commit/87ba95aa212a4fd363a4dd52677e9eea5224a4e7.diff

[PATCH] D125095: [Clang][AIX] Add .ref in frontend for AIX XCOFF to support `-bcdtors:csect` linker option

tingwang updated this revision to Diff 504031. tingwang added a comment. Herald added a subscriber: hiraditya. Rebase and update patch (1) Update verifier check on associated metadata to allow multiple operands for AIX. (2) Update test cases to use opaque pointer. Repository: rG LLVM Github

[clang] af86957 - [C++20] [Modules] Don't load declaration eagerly for named modules

Author: Chuanqi Xu Date: 2023-03-10T14:57:21+08:00 New Revision: af86957cbbffd3dfff3c6750ebddf118aebd0069 URL: https://github.com/llvm/llvm-project/commit/af86957cbbffd3dfff3c6750ebddf118aebd0069 DIFF: https://github.com/llvm/llvm-project/commit/af86957cbbffd3dfff3c6750ebddf118aebd0069.diff

[PATCH] D145034: [Clang][Sema] Start fixing handling of out-of-line definitions of constrained templates

alexander-shaposhnikov updated this revision to Diff 504025. alexander-shaposhnikov added a comment. Release notes. P.S. To the best of my knowledge the current status is the following: with this patch the examples reported in the comments on https://github.com/llvm/llvm-project/issues/49620

[PATCH] D145034: [Clang][Sema] Start fixing handling of out-of-line definitions of constrained templates

alexander-shaposhnikov added inline comments. Comment at: clang/lib/Sema/SemaCXXScopeSpec.cpp:141 + ClassTemplate->getInjectedClassNameSpecialization(); + if (Context.hasSameType(Injected, ContextType)) +return ClassTemplate->getTemplatedDecl();

[PATCH] D143306: [Driver] Default to -fno-openmp-implicit-rpath

tstellar added a comment. Should we apply this patch to the release/16.x branch to create a more smooth transition since the option has been removed in main? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143306/new/

[PATCH] D142174: [OpenMP] Don't set rpath for system paths

tstellar abandoned this revision. tstellar added a comment. -fopenmp-add-rpath has been removed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142174/new/ https://reviews.llvm.org/D142174 ___

[PATCH] D145765: Add __builtin_set_flt_rounds

xiongji90 added a comment. Hi, @andrew.w.kaylor @rjmccall @sepavloff @aaron.ballman This patch re-lands previous patch to add __builtin_set_flt_rounds, previous patch broke PPC64 buildbot due to test case bug. Previously, tests for __builtin_set_flt_rounds was located in CodeGen/builtin.c

[PATCH] D143480: [clang][Interp] Fix derived-to-base casts for >1 levels

tbaeder added inline comments. Comment at: clang/test/AST/Interp/records.cpp:266 }; #endif aaron.ballman wrote: > I think it'd be good to add test coverage for cases like: > https://godbolt.org/z/GnPnP4z76 That even worked :) CHANGES SINCE LAST ACTION

[PATCH] D143480: [clang][Interp] Fix derived-to-base casts for >1 levels

tbaeder updated this revision to Diff 504022. tbaeder marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143480/new/ https://reviews.llvm.org/D143480 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h

[PATCH] D145765: Add __builtin_set_flt_rounds

xiongji90 created this revision. xiongji90 added reviewers: andrew.w.kaylor, rjmccall, sepavloff, aaron.ballman. Herald added subscribers: pengfei, kristof.beyls. Herald added a project: All. xiongji90 requested review of this revision. Herald added a project: clang. Herald added a subscriber:

[PATCH] D145704: Revert "Set FLT_EVAL_METHOD to -1 when fast-math is enabled."

tstellar added a comment. We're holding -rc4 until this is merged, so it would be great if we could merge it on Friday. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145704/new/ https://reviews.llvm.org/D145704 ___ cfe-commits mailing list

[PATCH] D145591: [clang][HIP][OpenMP] Add warning if mixed HIP / OpenMP offloading

yaxunl added a comment. HIP toolchain does not pass -fopenmp-targets=amdgcn-amd-amdhsa to clang -cc1 in host compilation. It does not pass -fopenmp-is-device to clang -cc1 in device compilation. Without these options clang will not generate OpenMP offloading code for amdgpu in device and host

[PATCH] D145146: [Driver][NFC] Remove some redundant code in Driver.cpp.

Jimerlife added a comment. ping... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145146/new/ https://reviews.llvm.org/D145146 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D145509: [HIP] Fix temporary files

This revision was automatically updated to reflect the committed changes. Closed by commit rG1f8a3ce325be: [HIP] Fix temporary files (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145509/new/

[clang] 1f8a3ce - [HIP] Fix temporary files

Author: Yaxun (Sam) Liu Date: 2023-03-09T21:41:58-05:00 New Revision: 1f8a3ce325be51a1004657b08a607825447fee1b URL: https://github.com/llvm/llvm-project/commit/1f8a3ce325be51a1004657b08a607825447fee1b DIFF:

[PATCH] D145720: [clang-tidy] Finish cppcoreguidelines-avoid-capturing-lambda-coroutines check

ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145720/new/ https://reviews.llvm.org/D145720

[PATCH] D137514: [clang-tidy] add check for capturing lambda coroutines

ChuanqiXu accepted this revision. ChuanqiXu added a comment. LGTM. Thanks! BTW, in such cases, you can commandeer the revision generally. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137514/new/ https://reviews.llvm.org/D137514

[PATCH] D145642: [clang-format] Annotate lambdas with requires clauses.

owenpan added a comment. Would this patch make the end result look worse without "making the requires clause formatting of lambdas match the formatting for functions"? If yes, then we should not land it just yet. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D125095: [Clang][AIX] Add .ref in frontend for AIX XCOFF to support `-bcdtors:csect` linker option

tingwang added a comment. Currently this patch does not work due to limit set on associated metadata operand count (forced to be single operand). commit 87f2e9448e82bbed4ac59bb61bea03256aa5f4de Author: Matt Arsenault Date: Mon Jan 9 12:17:38 2023 -0500 Verifier: Add checks for

[PATCH] D145319: [clangd] Refine logic on $0 in completion snippets

zyounan added a comment. Ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145319/new/ https://reviews.llvm.org/D145319 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D145435: Choose style (file) from within code for use in IDEs

owenpan added a comment. In D145435#4181215 , @HazardyKnusperkeks wrote: > Although I don't think I will use that feature, I still think it might be > useful and doesn't really hurt anyone. It would add extra runtime (especially for large files). We

[PATCH] D83906: [CodeGen] Emit a call instruction instead of an invoke if the called llvm function is marked nounwind

hoy added a comment. In D83906#4182904 , @dexonsmith wrote: > In D83906#4182847 , @hoy wrote: > >> As far as I know, the optimizer IPO pass that infers function attributes >> (i..e `InferFunctionAttrsPass`) is

[clang] 25ba9dc - [HWASAN][LSAN] Fix buildbot failure.

Author: Kirill Stoimenov Date: 2023-03-10T01:07:43Z New Revision: 25ba9dcf1807e9eadade24833da60133beadfe3f URL: https://github.com/llvm/llvm-project/commit/25ba9dcf1807e9eadade24833da60133beadfe3f DIFF: https://github.com/llvm/llvm-project/commit/25ba9dcf1807e9eadade24833da60133beadfe3f.diff

[PATCH] D145727: [HWASAN][LSAN] Disable tests which don't pass in HWASAN+LSAN mode

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG011b4d4706ee: [HWASAN][LSAN] Disable tests which dont pass in HWASAN+LSAN mode (authored by kstoimenov). Repository: rG LLVM Github Monorepo

[clang] 011b4d4 - [HWASAN][LSAN] Disable tests which don't pass in HWASAN+LSAN mode

Author: Kirill Stoimenov Date: 2023-03-10T00:51:55Z New Revision: 011b4d4706eea722d63438892afefdb8152b7b62 URL: https://github.com/llvm/llvm-project/commit/011b4d4706eea722d63438892afefdb8152b7b62 DIFF: https://github.com/llvm/llvm-project/commit/011b4d4706eea722d63438892afefdb8152b7b62.diff

[PATCH] D145737: PR60985: Fix merging of lambda closure types across modules.

rsmith created this revision. Herald added a subscriber: martong. Herald added a reviewer: shafik. Herald added a project: All. rsmith requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previously, distinct lambdas would get merged, and

[PATCH] D130303: Fix include order in CXType.cpp

collinbaker added a comment. All done. Again, I don't have commit access so someone else will need to land this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130303/new/ https://reviews.llvm.org/D130303

[PATCH] D130303: Fix include order in CXType.cpp

collinbaker updated this revision to Diff 503954. collinbaker added a comment. Rebase w/ conflict in libclang.map Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130303/new/ https://reviews.llvm.org/D130303 Files: clang/docs/ReleaseNotes.rst

[PATCH] D130303: Fix include order in CXType.cpp

collinbaker marked 5 inline comments as done. collinbaker added a comment. I am very bad at using differential Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130303/new/ https://reviews.llvm.org/D130303

[PATCH] D130303: Fix include order in CXType.cpp

collinbaker updated this revision to Diff 503953. collinbaker retitled this revision from "Handle template parameter-dependent bit field widths in libclang" to "Fix include order in CXType.cpp". collinbaker edited the summary of this revision. collinbaker added a comment. Re-add "Fixes" commit

[PATCH] D130303: Handle template parameter-dependent bit field widths in libclang

collinbaker updated this revision to Diff 503952. collinbaker added a comment. Missed commit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130303/new/ https://reviews.llvm.org/D130303 Files: clang/docs/ReleaseNotes.rst

[PATCH] D145727: [HWASAN][LSAN] Disable tests which don't pass in HWASAN+LSAN mode

vitalybuka accepted this revision. vitalybuka added a comment. This revision is now accepted and ready to land. non-crash ones are probable worth of investigating later Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145727/new/

[PATCH] D130303: Handle template parameter-dependent bit field widths in libclang

collinbaker updated this revision to Diff 503950. collinbaker marked 3 inline comments as done. collinbaker edited the summary of this revision. collinbaker added a comment. Cleanups and split header order change to separate commit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D83906: [CodeGen] Emit a call instruction instead of an invoke if the called llvm function is marked nounwind

sanjoy added a comment. > I just assume there are more devices out there that we don't know about or > understand. I don't totally understand the broader discussion, but `malloc(4) == nullptr` is another gadget. This is optimized to `false` by LLVM even though at runtime it can be false or

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 updated this revision to Diff 503946. qiongsiwu1 added a comment. Adding LTO error check tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144190/new/ https://reviews.llvm.org/D144190 Files: clang/docs/ReleaseNotes.rst

[PATCH] D145726: Fix assembler error when -g and -gdwarf-* is passed with -fno-integrated-as.

efriedma added a comment. Following reproduces for me (clang from main, Ubuntu 16.04). $ cat test.cpp int foo() { int i=6; do --i; while (!(i%3)); do {} while (!(i%5)); return 0; } $ clang++ test.cpp -c -fno-integrated-as -gdwarf-4 -O2

[PATCH] D145190: [memprof] Record BuildIDs in the raw profile.

snehasish updated this revision to Diff 503945. snehasish added a comment. Update test regex. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145190/new/ https://reviews.llvm.org/D145190 Files: clang/test/CodeGen/Inputs/memprof.exe

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 updated this revision to Diff 503944. qiongsiwu1 added a comment. Adding tests to check that the default behaviour is identical with `-mno-roptr`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144190/new/

[PATCH] D145034: [Clang][Sema] Start fixing handling of out-of-line definitions of constrained templates

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Looks good to me. This is fixing an important bug, and while there's more cleanup I'd like for us to do, it seems important to get this fix landed first. My understanding is that the release

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 updated this revision to Diff 503941. qiongsiwu1 added a comment. Fixing release note. Adding pure linking tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144190/new/ https://reviews.llvm.org/D144190 Files:

[PATCH] D145720: [clang-tidy] Finish cppcoreguidelines-avoid-capturing-lambda-coroutines check

PiotrZSL updated this revision to Diff 503940. PiotrZSL added a comment. Change baseline Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145720/new/ https://reviews.llvm.org/D145720 Files:

[PATCH] D137514: [clang-tidy] add check for capturing lambda coroutines

PiotrZSL updated this revision to Diff 503939. PiotrZSL added a comment. Making tests passing on this diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137514/new/ https://reviews.llvm.org/D137514 Files:

[PATCH] D83906: [CodeGen] Emit a call instruction instead of an invoke if the called llvm function is marked nounwind

dexonsmith added a subscriber: sanjoy. dexonsmith added a comment. In D83906#4182902 , @rjmccall wrote: > So your argument is that it would not be possible to recognize that we're > doing such an optimization and mark the function as having had a

[PATCH] D145730: [clang-tidy] readability-redundant-string-cstr for smart pointer #576705

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. Also consider reducing commit message, instead just copying issue description. Simple description about issue would be sufficient. No functional issues, so LGTM.

[PATCH] D145190: [memprof] Record BuildIDs in the raw profile.

snehasish added a comment. In D145190#4181789 , @snehasish wrote: > In D145190#4181608 , @tejohnson > wrote: > >> lgtm - but does this depend on D145644 >> and require some

[PATCH] D145591: [clang][HIP][OpenMP] Add warning if mixed HIP / OpenMP offloading

jdoerfert added a comment. I would emit an error. A warning only if we can ensure the code does something sensible. Right now, I doubt that is the case, similarly I doubt we actually ignore things. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D145190: [memprof] Record BuildIDs in the raw profile.

snehasish updated this revision to Diff 503938. snehasish added a comment. Herald added subscribers: cfe-commits, wenlei. Herald added a project: clang. Update raw profiles, add another test for buildids only. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D145639: [Coroutines] Fix premature conversion of return object

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG54225c457a33: [Coroutines] Fix premature conversion of return object (authored by bruno). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 54225c4 - [Coroutines] Fix premature conversion of return object

Author: Bruno Cardoso Lopes Date: 2023-03-09T14:18:26-08:00 New Revision: 54225c457a336b1609c6d064b2b606a9238a28b9 URL: https://github.com/llvm/llvm-project/commit/54225c457a336b1609c6d064b2b606a9238a28b9 DIFF:

[PATCH] D145639: [Coroutines] Fix premature conversion of return object

bruno added a comment. Test failures are unrelated, thanks for the review @ChuanqiXu Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145639/new/ https://reviews.llvm.org/D145639 ___ cfe-commits mailing

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 updated this revision to Diff 503934. qiongsiwu1 added a comment. Adding logic to pass `mroptr` to the backend during LTO codegen. Error check is not ideal. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144190/new/

[PATCH] D83906: [CodeGen] Emit a call instruction instead of an invoke if the called llvm function is marked nounwind

dexonsmith added a comment. In D83906#4182847 , @hoy wrote: > As far as I know, the optimizer IPO pass that infers function attributes > (i..e `InferFunctionAttrsPass`) is placed at the very beginning of the > optimization pipeline. Does this sound to

[PATCH] D83906: [CodeGen] Emit a call instruction instead of an invoke if the called llvm function is marked nounwind

rjmccall added a comment. So your argument is that it would not be possible to recognize that we're doing such an optimization and mark the function as having had a possible semantics change? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D144304: [-Wunsafe-buffer-usage] Add a Fixable for pointer pre-increment

ziqingluo-90 updated this revision to Diff 503928. ziqingluo-90 added a comment. Rebased and addressed comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144304/new/ https://reviews.llvm.org/D144304 Files: clang/include/clang/Analysis/Analyses/UnsafeBufferUsageGadgets.def

[PATCH] D83906: [CodeGen] Emit a call instruction instead of an invoke if the called llvm function is marked nounwind

dexonsmith added a comment. In D83906#4182777 , @rjmccall wrote: > In D83906#4182287 , @dexonsmith > wrote: > >> - At IRGen time, you know the LLVM attributes have not been adjusted after >> the optimized refined

[PATCH] D145591: [clang][HIP][OpenMP] Add warning if mixed HIP / OpenMP offloading

tra added a comment. In D145591#4182737 , @yaxunl wrote: > OpenMP offloading directives (e.g. "omp target") create implicit GPU kernels > which require OpenMP toolchain to create offloading actions to support them. > For C/C++ programs, OpenMP

[PATCH] D83906: [CodeGen] Emit a call instruction instead of an invoke if the called llvm function is marked nounwind

hoy added a comment. In D83906#4182476 , @dexonsmith wrote: > In D83906#4182428 , @hoy wrote: > >> In D83906#4182287 , @dexonsmith >> wrote: >> >>> In C++, you get

[PATCH] D118493: Set rpath on openmp executables

JonChesterfield added a comment. That is great news, phabricator's list of branches has mislead me. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118493/new/ https://reviews.llvm.org/D118493 ___

[PATCH] D145726: Fix assembler error when -g and -gdwarf-* is passed with -fno-integrated-as.

MaskRay added a comment. > Due to this we started seeing assembler errors with certain .c and .cpp files > - > "Error: file number 1 already allocated" What are the certain `.c` and `.cpp` files? The behavior is correct for the following two commands. clang --target=arm-linux-gnueabihf

[PATCH] D145721: [HIP] clang should pass `-mno-amdgpu-ieee` to -cc1

tra added a comment. > clang should pass `-mno-amdgpu-ieee` to -cc1 It would be useful to have some details on why we should pass that option. Comment at: clang/test/Driver/hip-options.hip:133 +// IEEE-ON-NOT: clang{{.*}} "-triple" "amdgcn-amd-amdhsa" {{.*}} "-mamdgpu-ieee"

[PATCH] D145715: Remove -lower-global-dtors-via-cxa-atexit flag

yln added inline comments. Comment at: llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp:1205 unsigned Priority, const MCSymbol *KeySym) const { - // TODO(yln): Remove -lower-global-dtors-via-cxa-atexit fallback flag - // (LowerGlobalDtorsViaCxaAtExit) and always issue a

[PATCH] D118493: Set rpath on openmp executables

MaskRay added a comment. In D118493#4182583 , @JonChesterfield wrote: > Duplicating a comment from the commit thread so it's easier for me to find > later. > > You've applied this to the release branches going back as far as 14. It's a > user facing

[PATCH] D145730: [clang-tidy] readability-redundant-string-cstr for smart pointer #576705

mikecrowe created this revision. mikecrowe added a reviewer: njames93. Herald added subscribers: PiotrZSL, carlosgalvezp, xazax.hun. Herald added a project: All. mikecrowe requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. The

[PATCH] D145591: [clang][HIP][OpenMP] Add warning if mixed HIP / OpenMP offloading

yaxunl added a comment. In D145591#4182788 , @jhuber6 wrote: > In D145591#4182748 , @yaxunl wrote: > >> In D145591#4182360 , @jhuber6 >> wrote: >> >>> I'm not a fan of

[PATCH] D145591: [clang][HIP][OpenMP] Add warning if mixed HIP / OpenMP offloading

jhuber6 added a comment. In D145591#4182748 , @yaxunl wrote: > In D145591#4182360 , @jhuber6 wrote: > >> I'm not a fan of the same warning being copied in 24 places. Why do we set >> `LangOpts.IsOpenMP` on the

[PATCH] D142420: [Flang] Add support to use LTO specific pipelines

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0fdfb65e2624: [Flang] Add support to use LTO specific pipelines (authored by mnadeem). Herald added a project: clang. Herald added a subscriber:

[clang] 0fdfb65 - [Flang] Add support to use LTO specific pipelines

Author: Nadeem, Usman Date: 2023-03-09T13:27:43-08:00 New Revision: 0fdfb65e2624aa151cb07a9c842331f7af9a21ca URL: https://github.com/llvm/llvm-project/commit/0fdfb65e2624aa151cb07a9c842331f7af9a21ca DIFF: https://github.com/llvm/llvm-project/commit/0fdfb65e2624aa151cb07a9c842331f7af9a21ca.diff

[PATCH] D83906: [CodeGen] Emit a call instruction instead of an invoke if the called llvm function is marked nounwind

rjmccall added a comment. In D83906#4182287 , @dexonsmith wrote: > - At IRGen time, you know the LLVM attributes have not been adjusted after > the optimized refined the function's behaviour. It should be safe to have IPA > peepholes, as long as IRGen's

[PATCH] D144730: [FlowSensitive][WIP] log analysis progress for debugging purposes

gribozavr2 added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/Logger.h:22 + +// A logger is notified as the analysis progresses. +// It can produce a report of the analysis's findings and how it came to them. Elsewhere under

[PATCH] D145727: [HWASAN][LSAN] Disable tests which don't pass in HWASAN+LSAN mode

kstoimenov updated this revision to Diff 503915. kstoimenov added a comment. Removed debug print. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145727/new/ https://reviews.llvm.org/D145727 Files: clang/test/Driver/crash-diagnostics-dir-3.c

[PATCH] D145591: [clang][HIP][OpenMP] Add warning if mixed HIP / OpenMP offloading

yaxunl added a comment. In D145591#4182360 , @jhuber6 wrote: > I'm not a fan of the same warning being copied in 24 places. Why do we set > `LangOpts.IsOpenMP` on the GPU compilation side, couldn't we just filter out > the `-fopenmp` or whatever it is

[PATCH] D145567: [Driver] Rename multilib flags to tags

michaelplatings updated this revision to Diff 503913. michaelplatings added a comment. Tiny tweak: undo an unnecessary change to a test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145567/new/ https://reviews.llvm.org/D145567 Files:

[PATCH] D145727: [HWASAN][LSAN] Disable tests which don't pass in HWASAN+LSAN mode

kstoimenov created this revision. Herald added subscribers: arphaman, emaste. Herald added a project: All. kstoimenov requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, MaskRay. Herald added projects: clang, LLVM. Repository: rG LLVM Github Monorepo

[PATCH] D145591: [clang][HIP][OpenMP] Add warning if mixed HIP / OpenMP offloading

yaxunl added a comment. In D145591#4182351 , @tra wrote: > In D145591#4182168 , @yaxunl wrote: > >> -x hip and -fopenmp has been a valid combination. -fopenmp with -x hip >> allows non-offloading OpenMP

[PATCH] D145726: Fix assembler error when -g and -gdwarf-* is passed with -fno-integrated-as.

garvitgupta08 created this revision. garvitgupta08 added reviewers: apazos, efriedma, MaskRay, nickdesaulniers. Herald added a project: All. garvitgupta08 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. D136309

[PATCH] D145393: [HIP] Make `--offload-add-rpath` alias of `-frtlib-add-rpath`

yaxunl added a comment. In D145393#4172429 , @MaskRay wrote: > Seems fine. Should we eventually remove `--offload-add-rpath` and > `-fopenmp-implicit-rpath`? I agree we should eventually remove them and keep -frtlib-add-rpath only.

[PATCH] D145720: [clang-tidy] Finish cppcoreguidelines-avoid-capturing-lambda-coroutines check

PiotrZSL updated this revision to Diff 503907. PiotrZSL added a comment. Improve documentation (review comments) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145720/new/ https://reviews.llvm.org/D145720 Files:

[PATCH] D143587: [Docs] Multilib design

michaelplatings updated this revision to Diff 503906. michaelplatings added a comment. flags -> tags Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143587/new/ https://reviews.llvm.org/D143587 Files: clang/docs/Multilib.rst

[PATCH] D143075: BareMetal ToolChain multilib layering

michaelplatings updated this revision to Diff 503905. michaelplatings added a comment. flags -> tags Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143075/new/ https://reviews.llvm.org/D143075 Files: clang/lib/Driver/ToolChains/BareMetal.cpp

[PATCH] D143059: [Driver] Enable selecting multiple multilibs

michaelplatings updated this revision to Diff 503904. michaelplatings added a comment. flags -> tags Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143059/new/ https://reviews.llvm.org/D143059 Files: clang/include/clang/Driver/Multilib.h

[PATCH] D142986: Enable multilib.yaml in the BareMetal ToolChain

michaelplatings updated this revision to Diff 503903. michaelplatings added a comment. flags -> tags Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142986/new/ https://reviews.llvm.org/D142986 Files: clang/lib/Driver/ToolChain.cpp

[PATCH] D142933: Add -print-multi-selection-flags-experimental option

michaelplatings updated this revision to Diff 503902. michaelplatings added a comment. flags -> tags Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142933/new/ https://reviews.llvm.org/D142933 Files: clang/include/clang/Driver/Options.td

[PATCH] D145720: [clang-tidy] Finish cppcoreguidelines-avoid-capturing-lambda-coroutines check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:126 - Adds check for cpp core guideline: "CP.51: Do not use capturing lambdas that - are coroutines." - + Check flags C++20 coroutine lambdas with non-empty capture lists that may +

[PATCH] D142932: Multilib YAML parsing

michaelplatings updated this revision to Diff 503900. michaelplatings added a comment. flags -> tags Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142932/new/ https://reviews.llvm.org/D142932 Files: clang/include/clang/Driver/Multilib.h

[PATCH] D145567: [Driver] Rename multilib flags to tags

michaelplatings updated this revision to Diff 503899. michaelplatings added a comment. Rebase on top of D142905 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145567/new/ https://reviews.llvm.org/D145567 Files:

[PATCH] D145313: [clang-tidy] Make readability-container-size-empty check using header

mikecrowe added a comment. In D145313#4182637 , @mikecrowe wrote: > Now a descendent of D145724 . Oh. The commit message update didn't make it through. :( Never mind, this doesn't really depend on D145724

[PATCH] D145313: [clang-tidy] Make readability-container-size-empty check using header

mikecrowe updated this revision to Diff 503896. mikecrowe added a comment. Herald added a subscriber: PiotrZSL. Upload using arc diff so more context is available. Now a descendent of D145724 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D145150: clang: Emit nofpclass(nan inf) for -ffinite-math-only

jcranmer-intel added a comment. I'm generally okay with the approach of this patch. I'm not sufficiently well-versed in the clang codegen side of things to know if this covers all of the bases, and I'd appreciate someone who is familiar with that side of things to approve this patch. CHANGES

[PATCH] D145509: [HIP] Fix temporary files

yaxunl updated this revision to Diff 503892. yaxunl added a comment. fix tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145509/new/ https://reviews.llvm.org/D145509 Files: clang/include/clang/Driver/Driver.h clang/lib/Driver/Driver.cpp

[PATCH] D145312: [clang-tidy] Make readability-string-compare check use header

mikecrowe marked an inline comment as done. mikecrowe added inline comments. Herald added a subscriber: PiotrZSL. Comment at: clang-tools-extra/test/clang-tidy/checkers/readability/string-compare.cpp:4-8 -template -class allocator {}; -template -class char_traits {};

[PATCH] D118493: Set rpath on openmp executables

tstellar added a comment. In D118493#4182583 , @JonChesterfield wrote: > Duplicating a comment from the commit thread so it's easier for me to find > later. > > You've applied this to the release branches going back as far as 14. It's a > user facing

[PATCH] D145724: [clang-tidy] Provide default template arguments in

mikecrowe created this revision. mikecrowe added a reviewer: carlosgalvezp. Herald added subscribers: PiotrZSL, xazax.hun. Herald added a project: All. mikecrowe requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Simplify the use

[PATCH] D118493: Set rpath on openmp executables

JonChesterfield added a comment. Duplicating a comment from the commit thread so it's easier for me to find later. You've applied this to the release branches going back as far as 14. It's a user facing breaking change. As in people who have a working openmp toolchain and update to the point

[PATCH] D145720: [clang-tidy] Finish cppcoreguidelines-avoid-capturing-lambda-coroutines check

PiotrZSL updated this revision to Diff 503889. PiotrZSL added a comment. Change base-line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145720/new/ https://reviews.llvm.org/D145720 Files:

  1   2   3   >