[PATCH] D146603: [docs] Document -fomit-frame-pointer

vitalybuka accepted this revision. vitalybuka added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Driver/Options.td:2643 + HelpText<"Omit the frame pointer from functions that don't need it. " + "Some stack unwinding cases

[PATCH] D146503: Fix highlighting issue with _complex and initialization list with more than 2 items

chaitanyav marked an inline comment as done. chaitanyav added a comment. I reported the flang failures https://github.com/llvm/llvm-project/issues/61634 and it was reverted. How can i trigger a new build with TOT? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D146686: [Driver] Fix rpath for compiler-rt

yaxunl created this revision. yaxunl added reviewers: MaskRay, tra. Herald added a subscriber: dberris. Herald added a project: All. yaxunl requested review of this revision. The compiler-rt library path has changed to {resource_dir}/lib/{triple} from {resource_dir}/lib/{OS}/{arch} but the rpath

[clang] 45a0433 - [-Wunsafe-buffer-usage] Add [[fallthrough]] after D143206

Author: Fangrui Song Date: 2023-03-22T21:02:00-07:00 New Revision: 45a0433b39ffbd7cee9cc8a92f2300324b3548e0 URL: https://github.com/llvm/llvm-project/commit/45a0433b39ffbd7cee9cc8a92f2300324b3548e0 DIFF: https://github.com/llvm/llvm-project/commit/45a0433b39ffbd7cee9cc8a92f2300324b3548e0.diff

[PATCH] D146401: [clang-format] Don't squash Verilog escaped identifiers

sstwcw marked an inline comment as done. sstwcw added inline comments. Comment at: clang/unittests/Format/FormatTestVerilog.cpp:897 } +} // namespace +} // namespace test MyDeveloperDay wrote: > is this correct? do you have an anonymous namespace? It is

[clang] 25557aa - Recommit [Modules] Remove unnecessary check when generating name lookup table in ASTWriter

Author: Chuanqi Xu Date: 2023-03-23T11:21:35+08:00 New Revision: 25557aa38a0dab76f5b7a4518942f69d879693c0 URL: https://github.com/llvm/llvm-project/commit/25557aa38a0dab76f5b7a4518942f69d879693c0 DIFF: https://github.com/llvm/llvm-project/commit/25557aa38a0dab76f5b7a4518942f69d879693c0.diff

[PATCH] D133375: [CMake] Remove CLANG_DEFAULT_STD_C/CLANG_DEFAULT_STD_CXX

thesamesam added a comment. In D133375#4214214 , @tambre wrote: > I've now run into a snag with this. Having `clang++.cfg` with `-std=c++2b` > makes `/usr/bin/clang++ -E -dM -` fail with `error: invalid argument > '-std=c++2b' not allowed with 'C'`. >

[PATCH] D126959: [C++20][Modules] Introduce an implementation module.

ChuanqiXu added a comment. LGTM. Thanks. Comment at: clang/include/clang/Sema/Sema.h:2278 + + /// For an interface unit, this is the implicitly imported interface unit. + clang::Module *ThePrimaryInterface = nullptr; Comment at:

[PATCH] D146669: [-Wunsafe-buffer-usage] Hide fixits/suggestions behind an extra flag, -fsafe-buffer-usage-suggestions.

jkorous accepted this revision. jkorous added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:11792 "change type of '%0' to '%select{std::span|std::array|std::span::iterator}1' to preserve

[PATCH] D145646: [clang][driver] Enable '-flto' on AVR

benshi001 added a comment. In D145646#4213975 , @MaskRay wrote: > In D145646#4213547 , @gulfem wrote: > >> We started seeing a test failure in `avr-ld.c`. >> >>

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5250 + if (Args.hasArg(options::OPT_mroptr) || Args.hasArg(options::OPT_mno_roptr)) { +bool HasRoptr = qiongsiwu1 wrote: > hubert.reinterpretcast wrote: > >

[PATCH] D143704: [flang] Feature list plugin

elmcdonough updated this revision to Diff 507572. Herald added a subscriber: mgrang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143704/new/ https://reviews.llvm.org/D143704 Files: flang/examples/CMakeLists.txt

[PATCH] D146680: Fix unexpected nullptr in ConceptSpecializationExpr's ArgsAsWritten field

yeswalrus added a comment. Hoping this can make it into clang-16.0.1, since the crash this causes makes clangd unusable in codebases using concepts in template arguments in this manner. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146680/new/

[PATCH] D146680: Fix unexpected nullptr in ConceptSpecializationExpr's ArgsAsWritten field

yeswalrus added a comment. Resolves https://github.com/llvm/llvm-project/issues/61486, Similar to https://reviews.llvm.org/D146678 but targeting the llvm-16 series. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146680/new/

[PATCH] D146680: Add test for AST Writer crash

yeswalrus created this revision. Herald added a project: All. yeswalrus requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix ArgsAsWritten being null in certain circumstances when parsing ASTs Repository: rG LLVM Github Monorepo

[PATCH] D146654: [clang] replaces numeric SARIF ids with heirarchical names

cjdb added inline comments. Comment at: clang/lib/Frontend/SARIFDiagnostic.cpp:51-52 + Diag->getDiags()->getDiagnosticIDs()->getStableName(Diag->getID()).str(); + std::replace(StableName.begin(), StableName.end(), '_', '.'); + SarifRule Rule =

[PATCH] D146678: Summary: Fix ArgsAsWritten being null for ConceptSpecializationExpr in certain circumstances when parsing ASTs

yeswalrus added a comment. Solves issue: https://github.com/llvm/llvm-project/issues/61486 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146678/new/ https://reviews.llvm.org/D146678 ___ cfe-commits

[PATCH] D146678: Summary: Fix ArgsAsWritten being null for ConceptSpecializationExpr in certain circumstances when parsing ASTs

yeswalrus created this revision. Herald added a project: All. yeswalrus requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D146678 Files:

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

alexander-shaposhnikov updated this revision to Diff 507560. alexander-shaposhnikov added a comment. Add more tests. P.S. we already have tests with self-friends (in concepts.cpp), the test from Richard's comment is also included (struct S12) (in a slightly simplified form) Repository: rG

[PATCH] D130181: [clang-tidy] Add readability-use-early-exits check

njames93 added a comment. In D130181#4213779 , @LegalizeAdulthood wrote: > I'm not certain that the result of the transformation is more "readable"; is > this check intended to aid conformance to a style guide? One of the driving factors of this is

[PATCH] D145591: [clang][HIP][OpenMP] Add warning if mixed HIP / OpenMP offloading

jdoerfert resigned from this revision. jdoerfert added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8635 + "HIP does not support OpenMP target directives; directive has been ignored">, + InGroup; + yaxunl wrote: > mhalk wrote:

[PATCH] D140722: [OpenMP] Prefix outlined and reduction func names with original func's name

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. Assuming this passes all tests, incl. runtime tests in openmp/libomptarget/tests, LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140722/new/

[PATCH] D146669: [-Wunsafe-buffer-usage] Hide fixits/suggestions behind an extra flag, -fsafe-buffer-usage-suggestions.

NoQ updated this revision to Diff 507549. NoQ added a comment. Add some nice assertions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146669/new/ https://reviews.llvm.org/D146669 Files: clang/include/clang/Analysis/Analyses/UnsafeBufferUsage.h

[PATCH] D146671: Fix Declaration fragments for instancetype in the type position degrade to id

chaitanyav created this revision. chaitanyav added a reviewer: dang. Herald added a reviewer: ributzka. Herald added a project: All. chaitanyav requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes

[PATCH] D146595: [clang] Add clang trampoline attribute

aprantl added a comment. > If it's the latter, then, yeah, some "transparent to debugger" source > attribute might be appropriate - that lowers to a bit on the DISubprogram and > instructs LLVM to, if the function definition ends up lowering to a > trampoline, mark that for the debugger so

[PATCH] D146669: [-Wunsafe-buffer-usage] Hide fixits/suggestions behind an extra flag, -fsafe-buffer-usage-suggestions.

NoQ created this revision. NoQ added reviewers: jkorous, t-rasmud, ziqingluo-90, malavikasamak, aaron.ballman, gribozavr, ymandel, sgatev. Herald added subscribers: steakhal, martong. Herald added a project: All. NoQ requested review of this revision. Herald added a subscriber: MaskRay. This

[PATCH] D146656: [clang][ExtractAPI] Refactor ExtractAPIVisitor to make it more extensible

dang updated this revision to Diff 507544. dang added a comment. Adding back missing diffs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146656/new/ https://reviews.llvm.org/D146656 Files: clang/include/clang/ExtractAPI/ExtractAPIVisitor.h

[PATCH] D146656: [clang][ExtractAPI] Refactor ExtractAPIVisitor to make it more extensible

dang updated this revision to Diff 507543. dang added a comment. Addressing code review feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146656/new/ https://reviews.llvm.org/D146656 Files:

[PATCH] D125171: Add a new clang-format option AlwaysBreakBeforeFunctionParameters

jrmolin marked 4 inline comments as done. jrmolin added a comment. I still don't know what `Please write it out long form` means for the unit test. Comment at: clang/docs/ClangFormatStyleOptions.rst:3663 +.. _Macros: + I didn't modify this section in the

[PATCH] D125171: Add a new clang-format option AlwaysBreakBeforeFunctionParameters

jrmolin updated this revision to Diff 507539. jrmolin added a comment. I updated the code comment in Format.h and ran the docs generator. I didn't modify the Macros section, but that got updated when I ran the docs generator. We don't have a published style guide, unfortunately. I can work

[PATCH] D146466: [clang] diagnose function fallthrough

efriedma added a comment. > Yes, but kernel developers would prefer to diagnose issues at compile time > when possible, rather that at runtime. Function fallthough is diagnosable at > compile time, as this patch demonstrates. I'm not saying the diagnostic is useless. I'm saying users are

[PATCH] D126959: [C++20][Modules] Introduce an implementation module.

iains marked an inline comment as done. iains added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:1672-1677 + // A module implementation unit has visibility of the decls in its implicitly + // imported interface. + if (getLangOpts().CPlusPlusModules && NewM && OldM

[PATCH] D146644: [documentation]Fixed Random Typos

ayushi-8102 added a comment. Hi @ipriyanshi1708 , I am also an Outreachy applicant and I have also resolved various typos related to this issue. I will be submitting my patch very soon. We can collaborate for this issue! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D146595: [clang] Add clang trampoline attribute

augusto2112 added a comment. > This is quite fragile, for a few reasons. > It's too easy for the user to get undiagnosed typos. e.g., they want to > dispatch to bar but accidentally dispatch to barf or bar() instead. > How does this work with overloaded functions? Templated functions with >

[PATCH] D146591: [dataflow] add HTML logger: browse code/cfg/analysis timeline/state

gribozavr2 added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/Logger.h:34 static std::unique_ptr textual(llvm::raw_ostream &); + // A logger that builds an HTML UI to inspect the analysis results. + // One file is written under the specified dir

[PATCH] D140722: [OpenMP] Prefix outlined and reduction func names with original func's name

nextsilicon-itay-bookstein updated this revision to Diff 507532. nextsilicon-itay-bookstein added a comment. Herald added subscribers: kosarev, kerbowa, jvesely. Removed the empty string in the `getName()` invocation for the outlined helper's name. CHANGES SINCE LAST ACTION

[PATCH] D126959: [C++20][Modules] Introduce an implementation module.

iains updated this revision to Diff 507535. iains marked 12 inline comments as done. iains edited the summary of this revision. iains added a comment. rebased, addressed review comments, and amended the description. the patch has been repurposed to provide a mechanism to track implementation TUs

[PATCH] D146656: [clang][ExtractAPI] Refactor ExtractAPIVisitor to make it more extensible

dang added inline comments. Comment at: clang/include/clang/ExtractAPI/ExtractAPIVisitor.h:32 +template +class ExtractAPIVisitorBase : public RecursiveASTVisitor { public: zixuw wrote: > zixuw wrote: > > Would it be better to call this `ExtractAPIVisitorImpl`

[PATCH] D146665: [Fuchsia] Add FUCHSIA_USE_MULTIPLE_DISTRIBUTIONS.

mysterymath created this revision. mysterymath added reviewers: haowei, phosek. Herald added a subscriber: abrachet. Herald added a project: All. mysterymath requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This flag causes the toolchain

[PATCH] D143206: [-Wunsafe-buffer-usage] Add Fixable for simple pointer dereference

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe7596a99fca6: [-Wunsafe-buffer-usage] Add Fixable for simple pointer dereference (authored by malavikasamak). Herald added a project: clang. Herald

[clang] e7596a9 - [-Wunsafe-buffer-usage] Add Fixable for simple pointer dereference

Author: MalavikaSamak Date: 2023-03-22T15:32:51-07:00 New Revision: e7596a99fca6d1df14275f5293e447a4d87af06a URL: https://github.com/llvm/llvm-project/commit/e7596a99fca6d1df14275f5293e447a4d87af06a DIFF: https://github.com/llvm/llvm-project/commit/e7596a99fca6d1df14275f5293e447a4d87af06a.diff

[PATCH] D142905: [Driver] Change multilib selection algorithm

michaelplatings updated this revision to Diff 507527. michaelplatings marked an inline comment as done. michaelplatings added a comment. Add enum to Multilib class for how print options should be calculated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D146497: libclang: Pass Clang install directory to driver via argv[0].

This revision was automatically updated to reflect the committed changes. Closed by commit rG201fdef40dd6: libclang: Pass Clang install directory to driver via argv[0]. (authored by pcc). Changed prior to commit: https://reviews.llvm.org/D146497?vs=506832=507525#toc Repository: rG LLVM

[clang] 201fdef - libclang: Pass Clang install directory to driver via argv[0].

Author: Peter Collingbourne Date: 2023-03-22T15:28:21-07:00 New Revision: 201fdef40dd6ec193d18d39638454a3c972f1fec URL: https://github.com/llvm/llvm-project/commit/201fdef40dd6ec193d18d39638454a3c972f1fec DIFF:

[PATCH] D146654: [clang] replaces numeric SARIF ids with heirarchical names

denik added inline comments. Comment at: clang/lib/Basic/DiagnosticIDs.cpp:103 +// Stable names +const char *const StaticDiagInfoStableNames[] = { +#define DIAG(ENUM, CLASS, DEFAULT_SEVERITY, DESC, GROUP, SFINAE, NOWERROR, \ As of now it's 4600 strings,

[PATCH] D146503: Fix highlighting issue with _complex and initialization list with more than 2 items

chaitanyav marked an inline comment as done. chaitanyav added a comment. @aaron.ballman Please review. Comment at: clang/test/Sema/complex-init-list.c:37 struct teststruct invalid1 = { 1, 2 }; // expected-warning {{excess elements}} -_Complex float invalid2 = { 1, 2, 3 }; //

[PATCH] D146655: [clang-tidy] Ignore DISABLED_ in test suite name in google-avoid-underscore-in-googletest-name

LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/google/avoid-underscore-in-googletest-name.cpp:90 // Underscores are allowed to disable a test with the DISABLED_ prefix. -//

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

MaskRay added inline comments. Comment at: clang/test/Driver/ppc-roptr.c:1 +// RUN: %clang -### -target powerpc-ibm-aix-xcoff -mroptr %s 2>&1 | \ +// RUN: FileCheck %s --check-prefixes=ROPTR,LINK Prefer `--target=` to `-target ` for new tests.

[PATCH] D146497: libclang: Pass Clang install directory to driver via argv[0].

pcc added inline comments. Comment at: clang/tools/libclang/CIndex.cpp:4022 + llvm::sys::path::append(ClangPath, "bin"); + llvm::sys::path::append(ClangPath, "clang"); + pcc wrote: > aaron.ballman wrote: > > I suspect this doesn't matter *too* much, but... on

[PATCH] D146664: Apply the same fallbacks as runtimes search for stdlib search

glandium created this revision. glandium added a reviewer: thakis. Herald added a project: All. glandium requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. When building clang with e.g. LLVM_ENABLE_RUNTIMES=libcxx;libunwind, those

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:125 + // `-mroptr` implies the `-bforceimprw` linker option. + // The `-mroptr` option places constants in RO sections as much as possible. Delete `// `-mroptr` implies the

[PATCH] D146497: libclang: Pass Clang install directory to driver via argv[0].

pcc added inline comments. Comment at: clang/tools/libclang/CIndex.cpp:4022 + llvm::sys::path::append(ClangPath, "bin"); + llvm::sys::path::append(ClangPath, "clang"); + aaron.ballman wrote: > I suspect this doesn't matter *too* much, but... on Windows,

[PATCH] D146466: [clang] diagnose function fallthrough

nickdesaulniers added a comment. In D146466#4214148 , @dblaikie wrote: > In D146466#4213814 , > @nickdesaulniers wrote: > >> In D146466#4207915 , @efriedma >> wrote: >>

[PATCH] D143704: [flang] Feature list plugin

AlexisPerry added a comment. In D143704#4214279 , @elmcdonough wrote: > Could you post a link to the failed build please @Renaud-K? I'd like to see > if I can diagnose what's going wrong. Here is another helpful issue link regarding the failed build:

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to S11

MaskRay added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVFrameLowering.cpp:58 const auto *RVFI = MF.getInfo(); if (RVFI->useSaveRestoreLibCalls(MF)) { paulkirth wrote: > craig.topper wrote: > > paulkirth wrote: > > > craig.topper wrote: > >

[PATCH] D146557: [MLIR][OpenMP] Refactoring how map clause is processed

jdoerfert added inline comments. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:4261 + bool Temp; + return Val->getPointerDereferenceableBytes(M.getDataLayout(), Temp, Temp); } TIFitis wrote: > `getPointerDereferenceableBytes` doesn't fully support

[PATCH] D146655: [clang-tidy] Ignore DISABLED_ in test suite name in google-avoid-underscore-in-googletest-name

PiotrZSL added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/google/avoid-underscore-in-googletest-name.cpp:90 // Underscores are allowed to disable a test with the DISABLED_ prefix. -//

[PATCH] D146552: [Clang][OpenMP] Enable device-mapped constexpr class members to not be optimized out

jhuber6 accepted this revision. jhuber6 added a comment. LG, thanks. If you include `Fixes: ` in the commit message it'll automatically close it by the way. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146552/new/ https://reviews.llvm.org/D146552

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to S11

hiraditya added a comment. https://lists.riscv.org/g/sig-toolchains/message/548 has a proposal where X27 is one of the registers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146463/new/ https://reviews.llvm.org/D146463

[PATCH] D145201: [clang] fixes header processing for `-fdiagnostics-format=sarif`

cjdb updated this revision to Diff 507511. cjdb edited the summary of this revision. cjdb added a comment. And on this CL's side too Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145201/new/ https://reviews.llvm.org/D145201 Files:

[PATCH] D146654: [clang] replaces numeric SARIF ids with heirarchical names

cjdb updated this revision to Diff 507510. cjdb added a comment. I think this corrects everything. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146654/new/ https://reviews.llvm.org/D146654 Files: clang/include/clang/Basic/Diagnostic.h

[PATCH] D146155: [clang][NFC] Fix location of 2>&1 in a few -print tests

MaskRay added a comment. Thank you! (A somewhat common practice is to prefer `[test]` over `[NFC]` for pure-test changes (no code change) :) I see that " in a few -print tests" in the subject may render `[test]` unneeded.. perhaps what tag is used isn't really important.) Repository: rG

[PATCH] D146654: [clang] replaces numeric SARIF ids with heirarchical names

cjdb updated this revision to Diff 507503. cjdb edited the summary of this revision. cjdb added a comment. rebasing continues Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146654/new/ https://reviews.llvm.org/D146654 Files:

[PATCH] D145201: [clang] fixes header processing for `-fdiagnostics-format=sarif`

cjdb updated this revision to Diff 507497. cjdb edited the summary of this revision. cjdb added a comment. swaps commits to see if that fixes CI (part 1) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145201/new/ https://reviews.llvm.org/D145201

[PATCH] D146654: [clang] replaces numeric SARIF ids with heirarchical names

cjdb updated this revision to Diff 507494. cjdb edited the summary of this revision. cjdb added a comment. swaps commits to see if that fixes CI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146654/new/ https://reviews.llvm.org/D146654 Files:

[PATCH] D145646: [clang][driver] Enable '-flto' on AVR

gulfem added a comment. In D145646#4213975 , @MaskRay wrote: > In D145646#4213547 , @gulfem wrote: > >> We started seeing a test failure in `avr-ld.c`. >> >>

[PATCH] D138247: PR58819: Correct linkage and mangling of lambdas in inline static member initializers

dblaikie added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138247/new/ https://reviews.llvm.org/D138247 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D143704: [flang] Feature list plugin

clementval added a comment. The pre-commit was failing. Please do not commit without at least checking that the pre-commit is fine. https://buildkite.com/llvm-project/premerge-checks/builds/142487#018707c0-3ec0-4daa-a3a4-ffc815807994 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D143704: [flang] Feature list plugin

elmcdonough updated this revision to Diff 507486. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143704/new/ https://reviews.llvm.org/D143704 Files: flang/examples/CMakeLists.txt flang/examples/FeatureList/CMakeLists.txt

[PATCH] D146041: Fix weirdly apologetic diagnostic messages

manas added a comment. Hi, I came across this due to changes in Static Analyzer. One of the changes is not related to the Github issue mentioned above. Maybe we can drop that file? Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:1214-1215

[PATCH] D146552: [Clang][OpenMP] Enable device-mapped constexpr class members to not be optimized out

doru1004 updated this revision to Diff 507485. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146552/new/ https://reviews.llvm.org/D146552 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/test/OpenMP/declare_target_constexpr_codegen.cpp

[PATCH] D143704: [flang] Feature list plugin

elmcdonough added a comment. Could you post a link to the failed build please @Renaud-K? I'd like to see if I can diagnose what's going wrong. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143704/new/ https://reviews.llvm.org/D143704 ___

[PATCH] D146552: [Clang][OpenMP] Enable device-mapped constexpr class members to not be optimized out

doru1004 updated this revision to Diff 507483. doru1004 added a comment. Updated lit test to show variable added to compiler used vars. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146552/new/ https://reviews.llvm.org/D146552 Files:

[PATCH] D143704: [flang] Feature list plugin

Renaud-K reopened this revision. Renaud-K added a comment. This revision is now accepted and ready to land. Buildbot is failing with Failed Tests (2): Flang :: Examples/feature-list-class.f90 Flang :: Examples/feature-list-functions.f90 CHANGES SINCE LAST ACTION

[PATCH] D146656: [clang][ExtractAPI] Refactor ExtractAPIVisitor to make it more extensible

zixuw added inline comments. Comment at: clang/include/clang/ExtractAPI/ExtractAPIVisitor.h:628 +public: + ExtractAPIVisitor(ASTContext , APISet ) : Base(Context, API) {} + Same as above, should the constructor be `protected`? I guess it depends if we want

[PATCH] D146656: [clang][ExtractAPI] Refactor ExtractAPIVisitor to make it more extensible

zixuw added a comment. Good to see refactoring to make ExtractAPI easier to extend and use. Thanks Daniel! Some comments on the ExtractAPIVisitor part. I'll leave the libclang part to the experts. Comment at: clang/include/clang/ExtractAPI/ExtractAPIVisitor.h:32 +template

[PATCH] D145265: [Pipeline] Remove GlobalCleanupPM

aeubanks added inline comments. Comment at: llvm/test/Transforms/PhaseOrdering/X86/pr52289.ll:9 ; CHECK-NEXT: if.end: +; CHECK-NEXT:[[TMP0:%.*]] = add i32 [[A:%.*]], 1 +; CHECK-NEXT:[[CONV:%.*]] = and i32 [[TMP0]], 8 aeubanks wrote: > this is an

[PATCH] D146656: [clang][ExtractAPI] Refactor ExtractAPIVisitor to make it more extensible

bnbarham added inline comments. Comment at: clang/lib/ExtractAPI/ExtractAPIConsumer.cpp:170 bool operator()(SourceLocation Loc) { -// If the loc refers to a macro expansion we need to first get the file +// If the loc refersSourceLocationxpansion we need to first get

[PATCH] D146503: Fix highlighting issue with _complex and initialization list with more than 2 items

chaitanyav updated this revision to Diff 507479. chaitanyav added a comment. Added tests to check for the right diagnostic messages and highlighting at correct place Update the release docs about the fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D133375: [CMake] Remove CLANG_DEFAULT_STD_C/CLANG_DEFAULT_STD_CXX

tambre added a comment. I've now run into a snag with this. Having `clang++.cfg` with `-std=c++2b` makes `/usr/bin/clang++ -E -dM -` fail with `error: invalid argument '-std=c++2b' not allowed with 'C'`. This is invoked by Meson during its configuration process and causes it to fail. Am I

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

alexander-shaposhnikov planned changes to this revision. alexander-shaposhnikov added a comment. will add more tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146178/new/ https://reviews.llvm.org/D146178

[PATCH] D146342: [WIP][-Wunsafe-buffer-usage] Move the whole analysis to the end of a translation unit

ziqingluo-90 added a comment. The template specialization information is still available but we may need to print it by ourselves. I will add a FIXME there and we will deal with it in a follow-up patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D143592: [flang][driver] Rename `flang-new -flang-experimental-exec` to `flang`

everythingfunctional updated this revision to Diff 507472. everythingfunctional added a comment. Herald added subscribers: jplehr, ormris, steven_wu, hiraditya. Address conflicts with main branch and fix new tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143592/new/

[PATCH] D146604: [NFC] Fix uninitalized member variable use in ASTReader::ParseTargetOptions()

tahonermann added inline comments. Comment at: clang/include/clang/Basic/TargetOptions.h:48 /// The EABI version to use - llvm::EABI EABIVersion; + llvm::EABI EABIVersion = llvm::EABI::Default; Looks good; this is consistent with the default

[PATCH] D146656: [clang][ExtractAPI] Refactor ExtractAPIVisitor to make it more extensible

dang created this revision. dang added reviewers: zixuw, ributzka, bnbarham. Herald added subscribers: ChuanqiXu, arphaman. Herald added a project: All. dang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Use CRTP to enable creating

[PATCH] D146535: [Clang] Fix evaluation of parameters of lambda call operator attributes

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146535/new/ https://reviews.llvm.org/D146535 ___ cfe-commits mailing list

[PATCH] D146466: [clang] diagnose function fallthrough

dblaikie added a comment. In D146466#4213814 , @nickdesaulniers wrote: > In D146466#4207915 , @efriedma > wrote: > >> I'm concerned about the potential for false positives: >> >> - If a user doesn't mark a

[PATCH] D144730: [FlowSensitive] Log analysis progress for debugging purposes

ymandel accepted this revision. ymandel added a comment. Awesome, thanks! Comment at: clang/include/clang/Analysis/FlowSensitive/Logger.h:18 + +class ControlFlowContext; +class TypeErasedDataflowAnalysis; Maybe comment on the need for these vs including the

[PATCH] D146655: [clang-tidy] Ignore DISABLED_ in test suite name in google-avoid-underscore-in-googletest-name

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:237 +- Fixed an issue in :doc:`google-avoid-underscore-in-googletest-name + ` when using Please keep alphabetical order (by check name) in this section. Repository:

[PATCH] D146655: [clang-tidy] Ignore DISABLED_ in test suite name in google-avoid-underscore-in-googletest-name

carlosgalvezp updated this revision to Diff 507467. carlosgalvezp added a comment. Remove excessive newline Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146655/new/ https://reviews.llvm.org/D146655 Files:

[PATCH] D146655: [clang-tidy] Ignore DISABLED_ in test suite name in google-avoid-underscore-in-googletest-name

carlosgalvezp updated this revision to Diff 507465. carlosgalvezp retitled this revision from "[clang-tidy] Ignore more DISABLED_ in google-avoid-underscore-in-googletest-name" to "[clang-tidy] Ignore DISABLED_ in test suite name in google-avoid-underscore-in-googletest-name". carlosgalvezp

[PATCH] D146655: [clang-tidy] Ignore more DISABLED_ in google-avoid-underscore-in-googletest-name

carlosgalvezp updated this revision to Diff 507464. carlosgalvezp added a comment. Add to release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146655/new/ https://reviews.llvm.org/D146655 Files:

[PATCH] D146655: [clang-tidy] Ignore more DISABLED_ in google-avoid-underscore-in-googletest-name

carlosgalvezp updated this revision to Diff 507458. carlosgalvezp added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146655/new/ https://reviews.llvm.org/D146655 Files:

[PATCH] D146653: [clang-tidy][NFC] Move avoid-underscore-in-googletest-name to google folder

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7e5c48b8bd9f: [clang-tidy][NFC] Move avoid-underscore-in-googletest-name to google folder (authored by carlosgalvezp). Changed prior to commit:

[clang-tools-extra] 7e5c48b - [clang-tidy][NFC] Move avoid-underscore-in-googletest-name to google folder

Author: Carlos Galvez Date: 2023-03-22T18:51:51Z New Revision: 7e5c48b8bd9ff0ee5de3ba28c833f1225f14e44d URL: https://github.com/llvm/llvm-project/commit/7e5c48b8bd9ff0ee5de3ba28c833f1225f14e44d DIFF: https://github.com/llvm/llvm-project/commit/7e5c48b8bd9ff0ee5de3ba28c833f1225f14e44d.diff

[PATCH] D146655: [clang-tidy] Ignore more DISABLED_ in google-avoid-underscore-in-googletest-name

carlosgalvezp created this revision. Herald added subscribers: PiotrZSL, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. carlosgalvezp requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Test suite name

[PATCH] D145726: Fix assembler error when -g and -gdwarf-* is passed with -fno-integrated-as.

nickdesaulniers added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:976-985 + bool IsInputTyAsm = false; + for (const auto : Inputs) { +CmdArgs.push_back(II.getFilename()); +StringRef BaseInput = StringRef(II.getBaseInput()); +types::ID

[PATCH] D146654: [clang] replaces numeric SARIF ids with heirarchical names

cjdb created this revision. cjdb added reviewers: aaron.ballman, vaibhav.y, denik. Herald added a project: All. cjdb requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Per §3.27.5 and §3.27.7, the `rule.id` and `ruleId` properties need to be

[PATCH] D146557: [MLIR][OpenMP] Refactoring how map clause is processed

TIFitis marked 3 inline comments as done. TIFitis added inline comments. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:4181-4191 +for (auto : UseDeviceInfos) { + auto *UseDeviceVal = UseDeviceOp.first; + auto = UseDeviceOp.second; + SmallDenseSet

[PATCH] D141811: [clang-format] Allow trailing return types in macros

rymiel updated this revision to Diff 507451. rymiel added a comment. Reduce column limit for macro test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141811/new/ https://reviews.llvm.org/D141811 Files: clang/lib/Format/TokenAnnotator.cpp

  1   2   3   >