[PATCH] D146844: [clang-format] Handle '_' in ud-suffix for IntegerLiteralSeparator

owenpan added a comment. In D146844#4220894 , @rymiel wrote: > Could this possibly be an issue for more esoteric underscore-less UDLs, like > `i`? > Does the code need to search for a suffix, could it not detect the absence of > a digit? Sorry if the

[PATCH] D146864: [dataflow] Delete legacy aliases

sammccall created this revision. sammccall added a reviewer: ymandel. Herald added subscribers: martong, jeroen.dobbelaere, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. sammccall requested review of this revision. Herald added a project: clang. Herald added a subscriber:

[PATCH] D146802: [Documentation] improved documentation of diagnostic messages by explaining thier syntax and test of clang by telling which subobject is uninitialized

simideveloper added a comment. Oh sorry, I was unaware of the existing documentation. thank you for your time, sir. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146802/new/ https://reviews.llvm.org/D146802

[clang] cc4e774 - [Analysis] Fix use-after-scope in CFGElement dump

Author: Sam McCall Date: 2023-03-25T04:32:57+01:00 New Revision: cc4e774d5b4539d62f1fed97d3844b403ea43229 URL: https://github.com/llvm/llvm-project/commit/cc4e774d5b4539d62f1fed97d3844b403ea43229 DIFF: https://github.com/llvm/llvm-project/commit/cc4e774d5b4539d62f1fed97d3844b403ea43229.diff

[PATCH] D146625: [dataflow] handle missing case in value debug strings

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd630134f1f1f: [dataflow] handle missing case in value debug strings (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] d630134 - [dataflow] handle missing case in value debug strings

Author: Sam McCall Date: 2023-03-25T04:20:06+01:00 New Revision: d630134f1f1f83291177310c6fcf0dc7274f6494 URL: https://github.com/llvm/llvm-project/commit/d630134f1f1f83291177310c6fcf0dc7274f6494 DIFF: https://github.com/llvm/llvm-project/commit/d630134f1f1f83291177310c6fcf0dc7274f6494.diff

[PATCH] D146591: [dataflow] add HTML logger: browse code/cfg/analysis timeline/state

sammccall updated this revision to Diff 508273. sammccall added a comment. revert accidental edit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146591/new/ https://reviews.llvm.org/D146591 Files:

[PATCH] D146591: [dataflow] add HTML logger: browse code/cfg/analysis timeline/state

sammccall updated this revision to Diff 508272. sammccall added a comment. Move data into JSON object, render into DOM with templates. This is cleaner in a few ways: less ugly C++ string manipulation, data is in principle reusable, HTML layout is extracted and easier to inspect and edit.

[PATCH] D145737: PR60985: Fix merging of lambda closure types across modules.

rsmith added a comment. In D145737#4202945 , @rsmith wrote: > In D145737#4202351 , @aaron.ballman > wrote: > >> Checking: are the libc++ precommit CI failures related to these changes? >> It's a

[PATCH] D143128: [-Wunsafe-buffer-usage] Fix-Its transforming `[any]` to `(DRE.data() + any)`

malavikasamak added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:1096 + } else { +SS << "&" << getExprText(DRE, SM, LangOpts).str() << ".data()" + << "[" << getExprText(Idx, SM, LangOpts).str() << "]"; The title

[PATCH] D146342: [WIP][-Wunsafe-buffer-usage] Move the whole analysis to the end of a translation unit

ziqingluo-90 updated this revision to Diff 508249. ziqingluo-90 added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146342/new/ https://reviews.llvm.org/D146342 Files: clang/include/clang/Analysis/Analyses/UnsafeBufferUsage.h

[PATCH] D146844: [clang-format] Handle '_' in ud-suffix for IntegerLiteralSeparator

rymiel accepted this revision. rymiel added a comment. This revision is now accepted and ready to land. Could this possibly be an issue for more esoteric underscore-less UDLs, like `i`? Does the code need to search for a suffix, could it not detect the absence of a digit? Sorry if the questions

[PATCH] D146595: [clang] Add clang trampoline_mangled_target attribute

bulbazord added a comment. I had one question about this: I think through the comments you've made it quite clear that the intent is for this to be used by compiler-generated code (i.e. "tooling"). Given that even tools have bugs, what does the debugging/remediation story look like when a

[PATCH] D146665: [Fuchsia] Add FUCHSIA_USE_MULTIPLE_DISTRIBUTIONS.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. mysterymath marked an inline comment as done. Closed by commit rG0430324289f2: [Fuchsia] Add FUCHSIA_USE_MULTIPLE_DISTRIBUTIONS. (authored by mysterymath).

[clang] 0430324 - [Fuchsia] Add FUCHSIA_USE_MULTIPLE_DISTRIBUTIONS.

Author: Daniel Thornburgh Date: 2023-03-24T16:04:59-07:00 New Revision: 0430324289f2f0206a03a124b86eece8d007b09e URL: https://github.com/llvm/llvm-project/commit/0430324289f2f0206a03a124b86eece8d007b09e DIFF:

[PATCH] D146595: [clang] Add clang trampoline_mangled_target attribute

augusto2112 added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:6775 +static void handleTrampolineMangledTarget(Sema , Decl *D, + const ParsedAttr ) { augusto2112 wrote: > erichkeane wrote: > > I don't

[PATCH] D145265: [Pipeline] Remove GlobalCleanupPM

aeubanks added a comment. got IR diffs for llvm-test-suite by dumping the IR in clang after running the optimization pipeline (-O3), IR file name is md5 of the module identifier @@@ -1093,6 -1093,6 +1096,16 @@@ void EmitAssemblyHelper::EmitAssembly(B std::unique_ptr ThinLinkOS,

[PATCH] D146764: [clang] Make predefined expressions string literals under -fms-extensions

rsmith added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:3586-3591 + // MSVC treats all predefined expressions as string literals rather than char + // arrays. + if (LangOpts.MicrosoftExt) +return SL; + return PredefinedExpr::Create(Context, Loc, ResTy,

[PATCH] D146847: [NFC] Fix uninitialized member variable use in RVVEmitter::createRVVIntrinsics()

schittir updated this revision to Diff 508221. schittir added a comment. Deleting the member PolicyBitMask CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146847/new/ https://reviews.llvm.org/D146847 Files: clang/utils/TableGen/RISCVVEmitter.cpp Index:

[PATCH] D146847: [NFC] Fix uninitialized member variable use in RVVEmitter::createRVVIntrinsics()

jrtc27 added a comment. In D146847#4220721 , @schittir wrote: > In D146847#4220697 , @jrtc27 wrote: > >> None of the other fields are initialised, so blindly initialising it alone >> to 0 here seems highly

[PATCH] D146847: [NFC] Fix uninitialized member variable use in RVVEmitter::createRVVIntrinsics()

schittir added a comment. In D146847#4220717 , @jrtc27 wrote: > The field should just be deleted. D126742 > added it without any uses, and I don't know what the original intent was. > Maybe it was used before the

[PATCH] D146847: [NFC] Fix uninitialized member variable use in RVVEmitter::createRVVIntrinsics()

schittir added a comment. In D146847#4220697 , @jrtc27 wrote: > None of the other fields are initialised, so blindly initialising it alone to > 0 here seems highly suspect. What's the actual case in which it's used whilst > uninitialised? Coverity

[PATCH] D146847: [NFC] Fix uninitialized member variable use in RVVEmitter::createRVVIntrinsics()

jrtc27 added a comment. The field should just be deleted. D126742 added it without any uses, and I don't know what the original intent was. Maybe it was used before the bitfields were added and it stuck around rather than being GC'ed. I don't know why

[PATCH] D146847: [NFC] Fix uninitialized member variable use in RVVEmitter::createRVVIntrinsics()

schittir updated this revision to Diff 508215. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146847/new/ https://reviews.llvm.org/D146847 Files: clang/utils/TableGen/RISCVVEmitter.cpp Index: clang/utils/TableGen/RISCVVEmitter.cpp

[PATCH] D146847: [NFC] Fix uninitialized member variable use in RVVEmitter::createRVVIntrinsics()

jrtc27 added a comment. None of the other fields are initialised, so blindly initialising it alone to 0 here seems highly suspect. What's the actual case in which it's used whilst uninitialised? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D146847: [NFC] Fix uninitialized member variable use in RVVEmitter::createRVVIntrinsics()

schittir created this revision. schittir added reviewers: tahonermann, shafik, aaron.ballman. Herald added subscribers: luke, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, niosHD,

[PATCH] D146665: [Fuchsia] Add FUCHSIA_USE_MULTIPLE_DISTRIBUTIONS.

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146665/new/ https://reviews.llvm.org/D146665

[PATCH] D144590: [Clang][OpenMP] Fix shared memory allocation on AMDGPU

arsenm added a comment. In D144590#4220648 , @ZwFink wrote: > I wanted to follow up on this. Is anything additional needed from me? This needs a test (I would hope there is already one that needs updating), and also should switch to using PoisonValue

[PATCH] D144590: [Clang][OpenMP] Fix shared memory allocation on AMDGPU

ZwFink added a comment. Herald added subscribers: jplehr, sunshaoce. I wanted to follow up on this. Is anything additional needed from me? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144590/new/ https://reviews.llvm.org/D144590

[PATCH] D146844: [clang-format] Handle '_' in ud-suffix for IntegerLiteralSeparator

owenpan created this revision. owenpan added reviewers: MyDeveloperDay, HazardyKnusperkeks, rymiel. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes

[PATCH] D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method

zahiraam added a comment. In D146148#4220495 , @aaron.ballman wrote: > In D146148#4220433 , @zahiraam > wrote: > >> In D146148#4220268 , @rjmccall >> wrote: >> >>>

[clang] 2f086f2 - [APFloat] Add E4M3B11FNUZ

Author: David Majnemer Date: 2023-03-24T20:06:40Z New Revision: 2f086f265bf97fe6543fb199f4ef874ca3522479 URL: https://github.com/llvm/llvm-project/commit/2f086f265bf97fe6543fb199f4ef874ca3522479 DIFF: https://github.com/llvm/llvm-project/commit/2f086f265bf97fe6543fb199f4ef874ca3522479.diff

[PATCH] D146441: [APFloat] Add E4M3B11FNUZ

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2f086f265bf9: [APFloat] Add E4M3B11FNUZ (authored by majnemer). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D146595: [clang] Add clang trampoline_mangled_target attribute

augusto2112 added a subscriber: DavidSpickett. augusto2112 added a comment. > I'm coming around to maybe this is the best tradeoff, though not /super/ > enthusiastic - if there was some way to annotate in a way that's easier for > users (like a bit on the function - "transparent" or something -

[PATCH] D146842: [clang-tidy] Fix crash when handling invalid config values

PiotrZSL created this revision. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. PiotrZSL requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Currently due to

[PATCH] D125171: Add a new clang-format option AlwaysBreakBeforeFunctionParameters

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:4742-4748 + if (Left.is(tok::l_paren) && Style.AlwaysBreakBeforeFunctionParameters && + !Right.is(tok::r_paren) && Left.Previous) { + const FormatToken = *Left.Previous; +

[PATCH] D146042: [clang-format] Fix numerous issues with "LambdaBodyIndentation: OuterScope" option

HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:21916 // Lambdas with different indentation styles. + Style = getLLVMStyleWithColumns(60); jp4a50 wrote: > MyDeveloperDay wrote: > > jp4a50 wrote: > > >

[PATCH] D144709: [clang-format] Improve QualifierAlignment

HazardyKnusperkeks added a comment. In D144709#4196738 , @AlexanderHederstaf wrote: > In D144709#4193603 , > @MyDeveloperDay wrote: > >> In D144709#4188921 , >>

[PATCH] D140226: [NVPTX] Introduce attribute to mark kernels without a language mode

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG29a5c3c8fe30: [NVPTX] Introduce attribute to mark kernels without a language mode (authored by jhuber6). Changed prior to commit:

[clang] 29a5c3c - [NVPTX] Introduce attribute to mark kernels without a language mode

Author: Joseph Huber Date: 2023-03-24T14:42:25-05:00 New Revision: 29a5c3c8fe30dcfb19dd86dd5f3f201435311997 URL: https://github.com/llvm/llvm-project/commit/29a5c3c8fe30dcfb19dd86dd5f3f201435311997 DIFF: https://github.com/llvm/llvm-project/commit/29a5c3c8fe30dcfb19dd86dd5f3f201435311997.diff

[PATCH] D146427: [clang-tools-extra] Fix linking ClangdTests when using libclang-cpp

mgorny added a comment. Thank you. 16.x isn't affected. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146427/new/ https://reviews.llvm.org/D146427 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D146427: [clang-tools-extra] Fix linking ClangdTests when using libclang-cpp

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3bff90e7e84a: [clang-tools-extra] Fix linking ClangdTests when using libclang-cpp (authored by mgorny). Repository: rG LLVM Github Monorepo

[clang-tools-extra] 3bff90e - [clang-tools-extra] Fix linking ClangdTests when using libclang-cpp

Author: Michał Górny Date: 2023-03-24T20:25:31+01:00 New Revision: 3bff90e7e84aad6f0fddaf1d17a7db011052b95d URL: https://github.com/llvm/llvm-project/commit/3bff90e7e84aad6f0fddaf1d17a7db011052b95d DIFF: https://github.com/llvm/llvm-project/commit/3bff90e7e84aad6f0fddaf1d17a7db011052b95d.diff

[PATCH] D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method

aaron.ballman added a comment. In D146148#4220433 , @zahiraam wrote: > In D146148#4220268 , @rjmccall > wrote: > >> Okay, so modifying `math.h` to use this attribute is acceptable? That's >> great, that's

[PATCH] D146840: [AMDGPU] Replace target feature for global fadd32

gandhi21299 created this revision. gandhi21299 added reviewers: foad, arsenm, rampitec, Joe_Nash. Herald added subscribers: kosarev, StephenFan, kerbowa, tpr, dstuttard, yaxunl, jvesely, kzhuravl. Herald added a project: All. gandhi21299 requested review of this revision. Herald added

[PATCH] D145584: [libc] Add support for setjmp and longjmp in riscv

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0f6fd1b704c0: [libc] Add support for setjmp and longjmp in riscv (authored by Mikhail R. Gadelha mikh...@igalia.com). Repository: rG LLVM Github

[clang] 0f6fd1b - [libc] Add support for setjmp and longjmp in riscv

Author: Mikhail R. Gadelha Date: 2023-03-24T16:16:31-03:00 New Revision: 0f6fd1b704c014089f94271e08417a8179ee2b1c URL: https://github.com/llvm/llvm-project/commit/0f6fd1b704c014089f94271e08417a8179ee2b1c DIFF:

[PATCH] D145584: [libc] Add support for setjmp and longjmp in riscv

mikhail.ramalho updated this revision to Diff 508187. mikhail.ramalho added a comment. Update return Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145584/new/ https://reviews.llvm.org/D145584 Files: clang/docs/tools/clang-formatted-files.txt

[PATCH] D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method

zahiraam added a comment. In D146148#4220268 , @rjmccall wrote: > Okay, so modifying `math.h` to use this attribute is acceptable? That's > great, that's definitely the best outcome for the compiler. > > Just a minor request about the diagnostic name,

[clang-tools-extra] d820772 - Revert "[Serialization] Place command line defines in the correct file"

Author: Felipe de Azevedo Piovezan Date: 2023-03-24T14:49:47-04:00 New Revision: d820772ce17215c3e2c0f72d16b2d3f14a8745fb URL: https://github.com/llvm/llvm-project/commit/d820772ce17215c3e2c0f72d16b2d3f14a8745fb DIFF:

[PATCH] D146678: Fix unexpected nullptr in ConceptSpecializationExpr's ArgsAsWritten field

erichkeane added a comment. In D146678#4220360 , @yeswalrus wrote: > -I can handle it. - > Edit: I cannot handle it, I don't have commit access. If you could commit to > both main and the 16.x lines with the attribution to Walter Gray > that would be

[PATCH] D144651: [Serialization] Place command line defines in the correct file

fdeazeve added a comment. I think given Michael's investigation, we'll go ahead and revert. That said, some feedback on his suggestion for: > I wonder if we should just not add the root paths to filenames. Would allows us to make progress in restoring this patch Repository: rG LLVM Github

[PATCH] D146678: Fix unexpected nullptr in ConceptSpecializationExpr's ArgsAsWritten field

yeswalrus added a comment. I can handle it. The instructions here: https://llvm.org/docs/Contributing.html#how-to-submit-a-patch only talk about merging to main, but I was rather hoping to get this also merged into the eventual 16.0.1. Is there a feature branch for that already? Repository:

[PATCH] D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method

zahiraam updated this revision to Diff 508176. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146148/new/ https://reviews.llvm.org/D146148 Files: clang/docs/LanguageExtensions.rst clang/include/clang/Basic/Attr.td clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D145265: [Pipeline] Remove GlobalCleanupPM

nikic added a comment. I think this (removing GlobalCleanupPM) makes sense at a high level, but this is a pretty substantial pipeline change and will need more thorough evaluation (e.g. looking at IR diffs on test suite). For example, it is not at all obvious to me that moving InstCombine

[PATCH] D146665: [Fuchsia] Add FUCHSIA_USE_MULTIPLE_DISTRIBUTIONS.

mysterymath marked an inline comment as done. mysterymath added inline comments. Comment at: clang/cmake/caches/Fuchsia-stage2.cmake:3 +option(FUCHSIA_USE_MULTIPLE_DISTRIBUTIONS "Use multiple distributions") +option(FUCHSIA_ENABLE_LLDB "Enable LLDB") phosek

[PATCH] D140226: [NVPTX] Introduce attribute to mark kernels without a language mode

jhuber6 updated this revision to Diff 508170. jhuber6 added a comment. Updating to simply add an entirely new attribute again. The existing `CUDAGlobal` attribute does what we want, but it's also highly coupled with the CUDA language. This made it pretty much impossible to find a way to re-use it

[PATCH] D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method

rjmccall added a comment. Okay, so modifying `math.h` to use this attribute is acceptable? That's great, that's definitely the best outcome for the compiler. Just a minor request about the diagnostic name, but otherwise LGTM. Comment at:

[PATCH] D145265: [Pipeline] Remove GlobalCleanupPM

aeubanks updated this revision to Diff 508167. aeubanks added a comment. add FIXME to phase ordering test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145265/new/ https://reviews.llvm.org/D145265 Files:

[PATCH] D146814: [Flang] Add debug flag to enable current debug information pass

SBallantyne updated this revision to Diff 508165. SBallantyne added a comment. Add depending on D142347 and update references to clang::codegenoptions to llvm::codegenoptions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D144870: [Clang][DebugInfo] Emit zero size bitfields in the debug info to delimit bitfields in different allocation units.

probinson added a comment. Still one question, and haven't dug into the test in detail yet. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:1552 + + auto *PreviousMDEntry = + PreviousFieldsDI.empty() ? nullptr : PreviousFieldsDI.back(); Maybe a comment

[PATCH] D145770: [clang-offload-bundler] Standardize TargetID field for bundler

mdtoguchi added a comment. @lamb-j - is it expected for any bundled objects created before your change without the explicit env field to be able to be unbundled? Newly generated bundles work as expected given similar `-target` values, but older generated binaries fail to unbundle the target

Re: [PATCH] D143967: [DebugInfo][BPF] Add 'btf:type_tag' annotation in DWARF

> eddyz87 added a comment. > > In D143967#4200331 , @dfaust wrote: > >> In D143967#4197288 , @eddyz87 >> wrote: >> >>> ... >>> I think there are two sides to this: >>> >>> - conceptual: is it ok to allow

[PATCH] D146764: [clang] Make predefined expressions string literals under -fms-extensions

aeubanks added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:3586-3591 + // MSVC treats all predefined expressions as string literals rather than char + // arrays. + if (LangOpts.MicrosoftExt) +return SL; + return PredefinedExpr::Create(Context, Loc, ResTy,

[PATCH] D146656: [clang][ExtractAPI] Refactor ExtractAPIVisitor to make it more extensible

bnbarham added a comment. > I have decided against doing that, because we can't specify @LINE in the > c-index-test command line. FWIW you can do: // RUN: -pos=%(line+1):7 let bar = Bar() // CHECK ... [[@LINE-1]]:7 But I don't think this is particularly common, it's just how I

[PATCH] D145803: [clang][DebugInfo] Emit DW_AT_type of preferred name if available

wolfgangp added a comment. In D145803#4219894 , @probinson wrote: > This is pretty different from the "always desugar to the canonical type" > habit that has always been in place. Sony has done some downstream things to > try to work around that in the

[PATCH] D146427: [clang-tools-extra] Fix linking ClangdTests when using libclang-cpp

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. (back from a long vacation with little time spending on reviews.llvm.org ) I have verified that `tools/clang/tools/extra/clangd/unittests/ClangdTests` does not link in

[PATCH] D146656: [clang][ExtractAPI] Refactor ExtractAPIVisitor to make it more extensible

dang added a comment. In D146656#4220022 , @zixuw wrote: > LGTM for the `ExtractAPIVisitor` part. > Remaining: > > - update test with `@LINE` > - the libclang side I have decided against doing that, because we can't specify `@LINE` in the

[PATCH] D146715: [NVPTX] Enforce half type support is present for builtins

tra accepted this revision. tra added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:18313 // of its member: n*alignof(t)." -return MakeLdgLdu(Intrinsic::nvvm_ldg_global_i); - case NVPTX::BI__nvvm_ldg_h: -

[PATCH] D146827: [diagtool] explain that yellow is used to denote disabled-by-default warnings

nickdesaulniers added inline comments. Comment at: clang/tools/diagtool/TreeView.cpp:130-131 << " = enabled by default"; +out << '\n' +<< Colors::YELLOW << "YELLOW" << Colors::RESET +<< " = disabled by default"; it was clang-format,

[PATCH] D146827: [diagtool] explain that yellow is used to denote disabled-by-default warnings

nickdesaulniers created this revision. Herald added a project: All. nickdesaulniers requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is already implied, but let's just be explicit about it. Repository: rG LLVM Github Monorepo

[PATCH] D142347: [NFC][Clang] Move DebugOptions to llvm/Frontend for reuse in Flang

SBallantyne updated this revision to Diff 508150. SBallantyne added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142347/new/ https://reviews.llvm.org/D142347 Files: clang/include/clang/Basic/CodeGenOptions.def

[PATCH] D142347: [NFC][Clang] Move DebugOptions to llvm/Frontend for reuse in Flang

SBallantyne commandeered this revision. SBallantyne added a reviewer: kiranchandramohan. SBallantyne added a comment. Setting this revision as base for adding debug flag to avoid adding additional dependencies on clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D144651: [Serialization] Place command line defines in the correct file

Michael137 added a comment. FWIW here's some info on how we get to the assert. Maybe someone with more understanding of the `clang::SourceManager` and how it interacts with `.pcm`s will be able to spot something. Here's a bit more of the stack trace: frame #41: 0x00013844c7e0

[PATCH] D146656: [clang][ExtractAPI] Refactor ExtractAPIVisitor to make it more extensible

zixuw added a comment. LGTM for the `ExtractAPIVisitor` part. Remaining: - update test with `@LINE` - the libclang side Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146656/new/ https://reviews.llvm.org/D146656

[PATCH] D146412: [NFC] Fix potential use-after-free in DumpModuleInfoAction::ExecuteAction()

kastiglione added a comment. I understand the potential for a use after free, since `OutputStream` is a raw pointer, but I don't understand the fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146412/new/ https://reviews.llvm.org/D146412

[clang] 33be834 - [flang][driver][openmp] Write MLIR for -save-temps

Author: Sergio Afonso Date: 2023-03-24T17:13:40Z New Revision: 33be83415c9b5e9a874fcbddee8e64ecf464c203 URL: https://github.com/llvm/llvm-project/commit/33be83415c9b5e9a874fcbddee8e64ecf464c203 DIFF: https://github.com/llvm/llvm-project/commit/33be83415c9b5e9a874fcbddee8e64ecf464c203.diff

[PATCH] D146075: [flang][driver][openmp] Write MLIR for -save-temps

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. skatrak marked an inline comment as done. Closed by commit rG33be83415c9b: [flang][driver][openmp] Write MLIR for -save-temps (authored by skatrak). Repository: rG

[PATCH] D143436: [clangd] Move standard options adaptor to CommandMangler

mgorny added a comment. This commit broke building against `libclang-cpp.so` dylib. I've submitted a fix as D146427 but it haven't received any attention so far. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D146427: [clang-tools-extra] Fix linking ClangdTests when using libclang-cpp

mgorny added a reviewer: thesamesam. mgorny added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146427/new/ https://reviews.llvm.org/D146427 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] 7370e45 - Fix warnings

Author: Kazu Hirata Date: 2023-03-24T09:52:17-07:00 New Revision: 7370e45fb480672bea6483876090c33df5f66228 URL: https://github.com/llvm/llvm-project/commit/7370e45fb480672bea6483876090c33df5f66228 DIFF: https://github.com/llvm/llvm-project/commit/7370e45fb480672bea6483876090c33df5f66228.diff

[clang] 7370e45 - Fix warnings

Author: Kazu Hirata Date: 2023-03-24T09:52:17-07:00 New Revision: 7370e45fb480672bea6483876090c33df5f66228 URL: https://github.com/llvm/llvm-project/commit/7370e45fb480672bea6483876090c33df5f66228 DIFF: https://github.com/llvm/llvm-project/commit/7370e45fb480672bea6483876090c33df5f66228.diff

[PATCH] D146678: Fix unexpected nullptr in ConceptSpecializationExpr's ArgsAsWritten field

erichkeane added a comment. While I'd definitely like to see the pre-commit bots finish before committing this, Aaron tells me there seems to be a series of problems (we had an outage earlier this week, we might be seeing more from it!). Feel free to commit without waiting, post-commit works,

[PATCH] D145803: [clang][DebugInfo] Emit DW_AT_type of preferred name if available

probinson added subscribers: wolfgangp, probinson. probinson added a comment. This is pretty different from the "always desugar to the canonical type" habit that has always been in place. Sony has done some downstream things to try to work around that in the past. @wolfgangp will remember it

[PATCH] D146678: Fix unexpected nullptr in ConceptSpecializationExpr's ArgsAsWritten field

yeswalrus added a comment. @erichkeane What are the next steps to make this land? Looks like the build servers have been stuck waiting for an agent for over 24h Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146678/new/

[PATCH] D141472: [clang][Interp] Add function pointers

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141472/new/ https://reviews.llvm.org/D141472 ___ cfe-commits mailing

[PATCH] D146814: [Flang] Add debug flag to enable current debug information pass

awarzynski added a comment. Thanks for submitting this! Please add tests for `-g` and all variants of `-gline-tables-only`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146814/new/ https://reviews.llvm.org/D146814

[PATCH] D146719: [Clang] Improve diagnostics when using a concept as template argument

aaron.ballman added a comment. Want to add a release note for this as well? Comment at: clang/lib/Parse/Parser.cpp:1886-1889 + case Sema::NC_Concept: case Sema::NC_VarTemplate: case Sema::NC_FunctionTemplate: case Sema::NC_UndeclaredTemplate: { Would

[PATCH] D146075: [flang][driver][openmp] Write MLIR for -save-temps

awarzynski accepted this revision. awarzynski added a comment. LGTM! Comment at: flang/test/Driver/save-temps.f90:14 ! CHECK-NEXT: "-o" "save-temps.o" ! CHECK-NEXT: "-o" "a.out" skatrak wrote: > awarzynski wrote: > > skatrak wrote: > > > awarzynski wrote:

[PATCH] D140722: [OpenMP] Prefix outlined and reduction func names with original func's name

nextsilicon-itay-bookstein updated this revision to Diff 508116. nextsilicon-itay-bookstein added a comment. Another minor tweak to clang/test/CodeGen/PowerPC/ppc64le-varargs-f128.c. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140722/new/ https://reviews.llvm.org/D140722 Files:

[PATCH] D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method

zahiraam updated this revision to Diff 508114. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146148/new/ https://reviews.llvm.org/D146148 Files: clang/docs/LanguageExtensions.rst clang/include/clang/Basic/Attr.td clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D146376: Update static_assert message for redundant cases

tbaeder added inline comments. Comment at: clang/test/SemaCXX/static-assert.cpp:262 static_assert(invert(true) == invert(false), ""); // expected-error {{failed}} \ -// expected-note {{evaluates to 'false == true'}}

[PATCH] D146733: [clang] source range of variable template specialization should include initializer

tomasz-kaminski-sonarsource added a comment. In D146733#4219448 , @erichkeane wrote: > LGTM! Let me know if you need someone to commit this for you, and include > "Name To Use " I have commit rights, but I will not be able to commit this before

[PATCH] D146814: [Flang] Add debug flag to enable current debug information pass

tblah added a comment. Thanks for adding this flang. Please could you add a test checking that the pass is actually run when the flag is given. For example, see the tests on this patch https://reviews.llvm.org/D146278 Comment at: flang/include/flang/Tools/CLOptions.inc:21

[PATCH] D146764: [clang] Make predefined expressions string literals under -fms-extensions

cor3ntin added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:3586-3591 + // MSVC treats all predefined expressions as string literals rather than char + // arrays. + if (LangOpts.MicrosoftExt) +return SL; + return PredefinedExpr::Create(Context, Loc, ResTy,

[clang] 69061f9 - [AMDGPU] Add clang builtin for __builtin_amdgcn_ds_atomic_fadd_v2f16

Author: Mariusz Sikora Date: 2023-03-24T16:27:44+01:00 New Revision: 69061f96275c3053623a8699ce641c0f0ac61aed URL: https://github.com/llvm/llvm-project/commit/69061f96275c3053623a8699ce641c0f0ac61aed DIFF:

[PATCH] D146808: [AMDGPU] Add clang builtin for __builtin_amdgcn_ds_atomic_fadd_v2f16

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG69061f96275c: [AMDGPU] Add clang builtin for __builtin_amdgcn_ds_atomic_fadd_v2f16 (authored by mariusz-sikora-at-amd). Repository: rG LLVM

[PATCH] D144651: [Serialization] Place command line defines in the correct file

aaron.ballman added a comment. In D144651#4219633 , @fdeazeve wrote: > In D144651#4219340 , @aaron.ballman > wrote: > >> The build lab's lldb builders are all green, and greendragon's standalone >> build is

[PATCH] D146764: [clang] Make predefined expressions string literals under -fms-extensions

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:3586-3591 + // MSVC treats all predefined expressions as string literals rather than char + // arrays. + if (LangOpts.MicrosoftExt) +return SL; + return PredefinedExpr::Create(Context, Loc,

[PATCH] D146244: [clangd] Show used symbols on #include line hover.

kadircet added a comment. (pardon the interruption, some drive-by comments :)) Comment at: clang-tools-extra/clangd/Hover.cpp:1174 + return; + +for (const include_cleaner::Header : Providers) { note that we don't care about each reference of

  1   2   3   >