[PATCH] D147395: [Clangd] Make the type hint length limit configurable

zhangyi1357 updated this revision to Diff 511955. zhangyi1357 marked an inline comment as done. zhangyi1357 added a comment. Combine mutiple commits into single one Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147395/new/

[PATCH] D147395: [Clangd] Make the type hint length limit configurable

zhangyi1357 updated this revision to Diff 511950. zhangyi1357 marked 2 inline comments as done. zhangyi1357 added a comment. - [Clangd] Remove unneccessary modification Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147395/new/

[PATCH] D147867: [Windows SEH] Fix ehcleanup crash for Windows -EHa

pengfei created this revision. pengfei added reviewers: tentzen, efriedma, LuoYuanke, jyu2. Herald added subscribers: kbarton, nemanjai. Herald added a project: All. pengfei requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D147857: [clang-tidy] fix false positve for namespace with attrs in modernize-concat-nested-namespaces

HerrCai0907 added a comment. It should fix https://github.com/llvm/llvm-project/issues/57530 due to side effect instead of root cause.\ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147857/new/ https://reviews.llvm.org/D147857

[PATCH] D147857: [clang-tidy] fix false positve for namespace with attrs in modernize-concat-nested-namespaces

HerrCai0907 created this revision. HerrCai0907 added a reviewer: PiotrZSL. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. HerrCai0907 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a

[PATCH] D147843: [clang-tidy] fix hint use correct range to replace last NamespaceDecl

This revision was automatically updated to reflect the committed changes. Closed by commit rG0f9b71d11b91: [clang-tidy] fix hint use correct range to replace last NamespaceDecl (authored by HerrCai0907). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 0f9b71d - [clang-tidy] fix hint use correct range to replace last NamespaceDecl

Author: Congcong Cai Date: 2023-04-08T21:03:59+02:00 New Revision: 0f9b71d11b91d6fb7fa678a12327bafbc43605b5 URL: https://github.com/llvm/llvm-project/commit/0f9b71d11b91d6fb7fa678a12327bafbc43605b5 DIFF: https://github.com/llvm/llvm-project/commit/0f9b71d11b91d6fb7fa678a12327bafbc43605b5.diff

[PATCH] D147175: [clang] Add __is_trivially_equality_comparable

Mordante added inline comments. Comment at: libcxx/include/__type_traits/is_equality_comparable.h:46 template -struct __is_trivially_equality_comparable +struct __libcpp_is_trivially_equality_comparable : integral_constant Mordante wrote: > > This does not magically use

[PATCH] D146904: [clang-tidy] Fix extern fixes in readability-redundant-declaration

This revision was automatically updated to reflect the committed changes. Closed by commit rGd8c948cfe4ef: [clang-tidy] Fix extern fixes in readability-redundant-declaration (authored by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] d8c948c - [clang-tidy] Fix extern fixes in readability-redundant-declaration

Author: Piotr Zegar Date: 2023-04-08T17:17:12Z New Revision: d8c948cfe4eff814a2be71e74cbd835e9be28865 URL: https://github.com/llvm/llvm-project/commit/d8c948cfe4eff814a2be71e74cbd835e9be28865 DIFF: https://github.com/llvm/llvm-project/commit/d8c948cfe4eff814a2be71e74cbd835e9be28865.diff LOG:

[PATCH] D144036: [clang-tidy] Add bugprone-non-zero-enum-to-bool-conversion check

PiotrZSL updated this revision to Diff 511904. PiotrZSL marked an inline comment as done. PiotrZSL retitled this revision from "[clang-tidy] Add bugprone-enum-to-bool-conversion check" to "[clang-tidy] Add bugprone-non-zero-enum-to-bool-conversion check". PiotrZSL added a comment. Review fixes

[PATCH] D144036: [clang-tidy] Add bugprone-enum-to-bool-conversion check

PiotrZSL marked 14 inline comments as done. PiotrZSL added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone/enum-to-bool-conversion.rst:12-13 + +The check produces false positives if the ``enum`` is used to store other values +(used as a bit-mask

[PATCH] D146904: [clang-tidy] Fix extern fixes in readability-redundant-declaration

carlosgalvezp accepted this revision. carlosgalvezp added a comment. This revision is now accepted and ready to land. Looks great, thanks! Comment at: clang-tools-extra/clang-tidy/readability/RedundantDeclarationCheck.cpp:86 + Result.Nodes.getNodeAs("extern"); +

[PATCH] D146904: [clang-tidy] Fix extern fixes in readability-redundant-declaration

PiotrZSL updated this revision to Diff 511901. PiotrZSL added a comment. Added release notes, fixed typo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146904/new/ https://reviews.llvm.org/D146904 Files:

[PATCH] D147714: [Attr] Introduce [[clang::nonportable_musttail]] as less strict version of [[clang::musttail]]

xbolva00 added a comment. >> I'm curious if folks have pursued @efriedma 's suggestion #2 from >> https://github.com/llvm/llvm-project/issues/54964#issuecomment-1101612886? This is something we mentioned here, perform target specific checks in Sema (but still it is not possible to catch

[PATCH] D146904: [clang-tidy] Fix extern fixes in readability-redundant-declaration

PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/RedundantDeclarationCheck.cpp:86 + Result.Nodes.getNodeAs("extern"); + Extern && !Extern->hasBraces()) +BeginLoc = Extern->getExternLoc();

[PATCH] D146904: [clang-tidy] Fix extern fixes in readability-redundant-declaration

PiotrZSL added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/readability/redundant-declaration.cpp:126 +extern "C" int externX; +int dumyBegin;extern "C" int externX;int dummyEnd; +// CHECK-MESSAGES: :[[@LINE-1]]:30: warning: redundant 'externX'

[PATCH] D144331: [libc++][format] Implements formatter thread::id.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG88622aabf107: [libc++][format] Implements formatter thread::id. (authored by Mordante). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

Re: [clang] e7f55bb - [clang][Interp][NFCI] Call* ops don't modify the PC

On 08.04.23 14:25, Aaron Ballman wrote: On Sat, Apr 8, 2023 at 2:50 AM Timm Bäder via cfe-commits wrote: Author: Timm Bäder Date: 2023-04-08T08:49:22+02:00 New Revision: e7f55bbdb880eb0c096b05d915ee920fe1f2fb98 URL:

[PATCH] D147774: [4/N][POC][Clang] Define tuple type variant of vsseg2e32

eopXD updated this revision to Diff 511891. eopXD added a comment. Minor code change: Separate `defm` of segment load and store under `riscv_vector.td`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147774/new/ https://reviews.llvm.org/D147774

[clang] f43adc4 - [clang][Interp] Add missing static_assert message

Author: Timm Bäder Date: 2023-04-08T15:44:11+02:00 New Revision: f43adc498065fdfa120bd1aeea02c64f7ecea8f9 URL: https://github.com/llvm/llvm-project/commit/f43adc498065fdfa120bd1aeea02c64f7ecea8f9 DIFF: https://github.com/llvm/llvm-project/commit/f43adc498065fdfa120bd1aeea02c64f7ecea8f9.diff

[PATCH] D147175: [clang] Add __is_trivially_equality_comparable

philnik marked an inline comment as done. philnik added inline comments. Comment at: libcxx/include/__type_traits/is_equality_comparable.h:46 template -struct __is_trivially_equality_comparable +struct __libcpp_is_trivially_equality_comparable : integral_constant This

[PATCH] D147845: [clang][Interp] Fix a crash when calling invalid constexpr functions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1c818b0a4f92: [clang][Interp] Fix a crash when calling invalid constexpr functions (authored by tbaeder). Repository: rG LLVM Github Monorepo

[clang] 0260ea3 - [clang][Interp][NFC] Add test for e7f55bb

Author: Timm Bäder Date: 2023-04-08T15:28:47+02:00 New Revision: 0260ea3a5b1cfa0b0dbb9852742da7480fda620c URL: https://github.com/llvm/llvm-project/commit/0260ea3a5b1cfa0b0dbb9852742da7480fda620c DIFF: https://github.com/llvm/llvm-project/commit/0260ea3a5b1cfa0b0dbb9852742da7480fda620c.diff

[clang] 1c818b0 - [clang][Interp] Fix a crash when calling invalid constexpr functions

Author: Timm Bäder Date: 2023-04-08T15:28:47+02:00 New Revision: 1c818b0a4f92abd6a450841ebca37f3ef5dac0bc URL: https://github.com/llvm/llvm-project/commit/1c818b0a4f92abd6a450841ebca37f3ef5dac0bc DIFF: https://github.com/llvm/llvm-project/commit/1c818b0a4f92abd6a450841ebca37f3ef5dac0bc.diff

[PATCH] D147175: [clang] Add __is_trivially_equality_comparable

Mordante added a comment. I mainly glossed over the patch and didn't do a real review. Comment at: clang/lib/AST/ASTContext.cpp:2672 +const RecordDecl *RD, +bool

[PATCH] D146986: Downgrade reserved module identifier error into a warning

Mordante added a comment. Sorry I was not available earlier. Thanks for working on this. LGTM but one remark. Comment at: clang/docs/ReleaseNotes.rst:92 + `_ and allows easier + building of precompiled modules. This

[PATCH] D147845: [clang][Interp] Fix a crash when calling invalid constexpr functions

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/test/AST/Interp/functions.cpp:210-212 + return 1 / 0; // expected-note 2{{division by zero}} \ +//

[PATCH] D147534: [clang][Interp] Make sure we have a variable scope for initializers

aaron.ballman added inline comments. Comment at: clang/test/AST/Interp/records.cpp:315 + auto T = Test(Arr, Pos); + // End of scope, should destroy Test. +} tbaeder wrote: > aaron.ballman wrote: > > Would it make sense to give `Test` a constexpr

Re: [clang] e7f55bb - [clang][Interp][NFCI] Call* ops don't modify the PC

On Sat, Apr 8, 2023 at 2:50 AM Timm Bäder via cfe-commits wrote: > > > Author: Timm Bäder > Date: 2023-04-08T08:49:22+02:00 > New Revision: e7f55bbdb880eb0c096b05d915ee920fe1f2fb98 > > URL: > https://github.com/llvm/llvm-project/commit/e7f55bbdb880eb0c096b05d915ee920fe1f2fb98 > DIFF: >

[PATCH] D147848: [clang] Add test for CWG2370

Endill created this revision. Endill added a reviewer: clang-language-wg. Herald added a project: All. Endill requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. P1787 : CWG2370 is resolved by performing a search in

[PATCH] D147847: [clangd] Hover: Add CalleeArgInfo for constructor expressions

tom-anders added a comment. (Note that this diff is stacked on D147846 ) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147847/new/ https://reviews.llvm.org/D147847 ___

[PATCH] D147847: [clangd] Hover: Add CalleeArgInfo for constructor expressions

tom-anders added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:986 + const FunctionDecl *FD = nullptr; + llvm::SmallVector Args; + Unfortunately, while CallExpr and CXXConstructExpr basically have the same API for getting Args, they're not

[PATCH] D147847: [clangd] Hover: Add CalleeArgInfo for constructor expressions

tom-anders created this revision. tom-anders added reviewers: nridge, sammccall. Herald added subscribers: kadircet, arphaman. Herald added a project: All. tom-anders requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project:

[PATCH] D144331: [libc++][format] Implements formatter thread::id.

Mordante updated this revision to Diff 511875. Mordante added a comment. CI fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144331/new/ https://reviews.llvm.org/D144331 Files: libcxx/docs/FeatureTestMacroTable.rst

[PATCH] D146904: [clang-tidy] Fix extern fixes in readability-redundant-declaration

carlosgalvezp added a comment. Looks good, thanks for the fix! Do we think it's worth documenting in the Release Notes? Comment at: clang-tools-extra/clang-tidy/readability/RedundantDeclarationCheck.cpp:86 + Result.Nodes.getNodeAs("extern"); + Extern &&

[PATCH] D147834: [clang][driver] Pass `-femulated-tls` through to the linker in LTO mode

vit9696 accepted this revision. vit9696 added a comment. This revision is now accepted and ready to land. Looks good to me, thank you! Comment at: clang/test/Driver/emulated-tls.cpp:57 +// LTO related checks +//LTO_NOEMUTLS: plugin-opt=-emulated-tls=0 +//LTO_NOEMUTLS-NOT:

[PATCH] D146520: [clang-tidy] Fix checks filter with warnings-as-errors

carlosgalvezp accepted this revision. carlosgalvezp added a comment. Having another look and reading your comments I got a better understanding of the situation: - YAML output did not have correct warnings as errors. - Thus a fix was introduced in ClangTidyDiagnosticConsumer, however this was a

[PATCH] D147846: [clangd] Hover: resolve forwarding parameters for CalleeArgInfo

tom-anders created this revision. tom-anders added reviewers: nridge, upsj. Herald added subscribers: kadircet, arphaman. Herald added a project: All. tom-anders requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project:

[PATCH] D146809: [WIP][clang-repl] Implement Value pretty printing

junaire updated this revision to Diff 511871. junaire added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146809/new/ https://reviews.llvm.org/D146809 Files: clang/include/clang/Interpreter/Interpreter.h

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire updated this revision to Diff 511870. junaire added a comment. Remove some unnecessary code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/include/clang/AST/Decl.h

[PATCH] D147845: [clang][Interp] Fix a crash when calling invalid constexpr functions

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, shafik, erichkeane, tahonermann. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire updated this revision to Diff 511867. junaire added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/include/clang/AST/Decl.h

[PATCH] D144331: [libc++][format] Implements formatter thread::id.

Mordante updated this revision to Diff 511865. Mordante added a comment. Herald added a subscriber: krytarowski. CI fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144331/new/ https://reviews.llvm.org/D144331 Files:

[PATCH] D147844: Emit warning when implicit cast to bool happens in an conditional operator expression when used inside an overloaded shift operator expression

chaitanyav added a comment. output for testcases mentioned in https://github.com/llvm/llvm-project/issues/61943 test.cpp:6:30: warning: overloaded operator << has higher precedence than comparison operator [-Woverloaded-shift-op-parentheses] std::cout << "Test" << a == 5 ? 1 : 0;

[PATCH] D147844: Emit warning when implicit cast to bool happens in an conditional operator expression when used inside an overloaded shift operator expression

chaitanyav created this revision. Herald added a project: All. chaitanyav requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes issue https://github.com/llvm/llvm-project/issues/61943 Repository: rG LLVM Github Monorepo

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

v.g.vassilev added inline comments. Comment at: clang/include/clang/Interpreter/Interpreter.h:39 +class Parser; +class CodeGenerator; class CompilerInstance; v.g.vassilev wrote: > We probably do not need these forward declarations. Looks like they came back.

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire updated this revision to Diff 511862. junaire added a comment. Clean up the patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/include/clang/AST/Decl.h

[PATCH] D147843: [clang-tidy] fix hint use correct range to replace last NamespaceDecl

HerrCai0907 created this revision. HerrCai0907 added a reviewer: PiotrZSL. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. HerrCai0907 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire updated this revision to Diff 511857. junaire added a comment. Update... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/include/clang/AST/Decl.h

[PATCH] D147615: [clang][Sema][NFC] Save token name instead of the full token

This revision was automatically updated to reflect the committed changes. Closed by commit rG11ad7d2935af: [clang][Sema][NFC] Save token name instead of the full token (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147615/new/

[clang] 11ad7d2 - [clang][Sema][NFC] Save token name instead of the full token

Author: Timm Bäder Date: 2023-04-08T09:02:19+02:00 New Revision: 11ad7d2935afe965c9e8c7ba4732215b404ff57f URL: https://github.com/llvm/llvm-project/commit/11ad7d2935afe965c9e8c7ba4732215b404ff57f DIFF: https://github.com/llvm/llvm-project/commit/11ad7d2935afe965c9e8c7ba4732215b404ff57f.diff

[PATCH] D147534: [clang][Interp] Make sure we have a variable scope for initializers

tbaeder added inline comments. Comment at: clang/test/AST/Interp/records.cpp:315 + auto T = Test(Arr, Pos); + // End of scope, should destroy Test. +} aaron.ballman wrote: > Would it make sense to give `Test` a constexpr destructor so that we can

[clang] e7f55bb - [clang][Interp][NFCI] Call* ops don't modify the PC

Author: Timm Bäder Date: 2023-04-08T08:49:22+02:00 New Revision: e7f55bbdb880eb0c096b05d915ee920fe1f2fb98 URL: https://github.com/llvm/llvm-project/commit/e7f55bbdb880eb0c096b05d915ee920fe1f2fb98 DIFF: https://github.com/llvm/llvm-project/commit/e7f55bbdb880eb0c096b05d915ee920fe1f2fb98.diff

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

alexander-shaposhnikov updated this revision to Diff 511854. alexander-shaposhnikov added a comment. This version is partially based on https://reviews.llvm.org/D147722. The case with self-friendship is problematic (had to add a workaround, any suggestions would be greatly appreciated). Added