[PATCH] D147121: [hwasan] remove requirment for PIE

Enna1 added a comment. gentle ping, @eugenis PTAL, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147121/new/ https://reviews.llvm.org/D147121 ___ cfe-commits mailing list

[PATCH] D147905: [clangd] Avoid passing -xobjective-c++-header to the system include extractor

nridge added a comment. Note: I did not rebase this on top of D146941 , because I'd like to suggest that this fix be backported to the 16.x branch (and presumably that's not the case for D146941 ); however, I'm happy to rebase

[PATCH] D147905: [clangd] Avoid passing -xobjective-c++-header to the system include extractor

nridge created this revision. nridge added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a project: All. nridge requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Fixes

[PATCH] D147893: [clang-tidy] avoid colon in namespace cause false positve

PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/ConcatNestedNamespacesCheck.cpp:175 + llvm::errs() << Namespaces.size() << " " << ND.getName() << " clear\n"; Namespaces.clear(); debug log... Repository: rG LLVM

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire updated this revision to Diff 512073. junaire added a comment. fix some nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/include/clang/AST/Decl.h

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire updated this revision to Diff 512072. junaire added a comment. Address some comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/include/clang/AST/Decl.h

[PATCH] D147904: [Clang] Fix cast to BigIntType in hasUniqueObjectRepresentations

royjacobson created this revision. royjacobson added reviewers: shafik, cjdb. Herald added a subscriber: kristof.beyls. Herald added a project: All. royjacobson requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. A bad QualType cast caused us

[PATCH] D146520: [clang-tidy] Fix checks filter with warnings-as-errors

kiwixz added a comment. I'm not sure how to test this, is there any check dependency we can rely on with hardcoded tests ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146520/new/ https://reviews.llvm.org/D146520

[PATCH] D147901: [NFC][CLANG][API] Fix coverity remarks about large copies by values

Manna added a comment. x64 debian failures seem unrelated to my fix: https://lab.llvm.org/buildbot/#/builders/21/builds/67315/steps/6/logs/stdio Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147901/new/ https://reviews.llvm.org/D147901

[PATCH] D147901: [NFC][CLANG][API] Fix coverity remarks about large copies by values

Manna created this revision. Manna added reviewers: erichkeane, aaron.ballman. Herald added a reviewer: ributzka. Herald added a project: All. Manna requested review of this revision. Herald added a reviewer: dang. Herald added a project: clang. Reported by Coverity Static Analyzer Tool: Big

[PATCH] D147876: [clang-tidy] Support introducing checks as a list in the config file

njames93 requested changes to this revision. njames93 added a comment. This revision now requires changes to proceed. From an architectural point of view, is there any reason we don't change the backend to treat checks internally as a vector? `clang-tools-extra/docs/clang-tidy/index.rst` also

[PATCH] D93240: [clang-format] Add SpaceBeforeCaseColon option

sstwcw added a comment. Herald added a project: All. Herald added reviewers: rymiel, owenpan. A goto label isn't affected by this option. Is it intentional? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93240/new/ https://reviews.llvm.org/D93240

[PATCH] D147895: [clang-format] Handle Verilog assertions and loops

sstwcw created this revision. sstwcw added reviewers: HazardyKnusperkeks, MyDeveloperDay, owenpan, rymiel. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. sstwcw requested review of this revision. Assert statements in Verilog can optionally have an else

[PATCH] D147894: [clang-format] SortIncludes documentation: remove contradiction in its description

michael-g-matthews updated this revision to Diff 512042. michael-g-matthews added a comment. Amended commit to include change to `clang/include/clang/Format/Format.h` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147894/new/ https://reviews.llvm.org/D147894 Files:

[PATCH] D147894: [clang-format] SortIncludes documentation: remove contradiction in its description

michael-g-matthews created this revision. michael-g-matthews added reviewers: MyDeveloperDay, owenpan. michael-g-matthews added a project: clang-format. Herald added projects: All, clang. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks. Herald added a

[PATCH] D147876: [clang-tidy] Support introducing checks as a list in the config file

Eugene.Zelenko accepted this revision. Eugene.Zelenko added a comment. This revision is now accepted and ready to land. Looks OK for me but will be good idea to wait for other reviewers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147876/new/

[PATCH] D147893: [clang-tidy] avoid colon in namespace cause false positve

HerrCai0907 created this revision. HerrCai0907 added a reviewer: PiotrZSL. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. HerrCai0907 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a

[PATCH] D147876: [clang-tidy] Support introducing checks as a list in the config file Specifying checks as a string is convenient for quickly using clang-tidy to run a handful of checks. However it

carlosgalvezp updated this revision to Diff 512038. carlosgalvezp retitled this revision from "[clang-tidy] Support introducing checks as a list in the config file Specifying checks as a string is convenient for quickly using clang-tidy to run a handful of checks. However it is not suitable for

[PATCH] D147876: [clang-tidy] Support introducing checks as a list in the config file Specifying checks as a string is convenient for quickly using clang-tidy to run a handful of checks. However it i

carlosgalvezp updated this revision to Diff 512037. carlosgalvezp retitled this revision from "[WIP][clang-tidy] Support specifying Checks as a list in the config file" to "[clang-tidy] Support introducing checks as a list in the config file Specifying checks as a string is convenient for

[PATCH] D147876: [WIP][clang-tidy] Support specifying Checks as a list in the config file

carlosgalvezp updated this revision to Diff 512036. carlosgalvezp added a comment. Herald added a subscriber: arphaman. - Simplify code with llvm:join. - Add documentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147876/new/

[clang] 3c83480 - [clang][AST] Fix `-Wuninitialized`. NFC

Author: Michael Liao Date: 2023-04-09T15:58:10-04:00 New Revision: 3c83480ae95dde9b5d45b6fd7cdb1c64332531d7 URL: https://github.com/llvm/llvm-project/commit/3c83480ae95dde9b5d45b6fd7cdb1c64332531d7 DIFF: https://github.com/llvm/llvm-project/commit/3c83480ae95dde9b5d45b6fd7cdb1c64332531d7.diff

[PATCH] D147889: [clang-tidy] Improve bugprone-branch-clone with support for fallthrough attribute

PiotrZSL created this revision. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. PiotrZSL requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Ignore duplicated

[PATCH] D147888: Update declaration message of extern linkage

Krishna-13-cyber created this revision. Krishna-13-cyber added reviewers: tbaeder, cjdb, aaron.ballman. Herald added a project: All. Krishna-13-cyber requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch aims to improve the diagnostic

[PATCH] D144331: [libc++][format] Implements formatter thread::id.

Mordante marked an inline comment as done. Mordante added inline comments. Comment at: libcxx/test/std/thread/thread.threads/thread.thread.class/thread.thread.id/parse.pass.cpp:49 + std::same_as auto it = formatter.parse(parse_ctx); + assert(it == fmt.end() - (!fmt.empty()

[PATCH] D147875: [clang][Diagnostics] WIP: Show line numbers when printing code snippets

tbaeder updated this revision to Diff 512024. tbaeder edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147875/new/ https://reviews.llvm.org/D147875 Files: clang/include/clang/Frontend/TextDiagnostic.h clang/lib/Frontend/TextDiagnostic.cpp Index:

[PATCH] D140760: [clang-tidy] Support begin/end free functions in modernize-loop-convert

PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/LoopConvertCheck.cpp:74 +"rend","crend", "size"}; +static const std::set StdNames{ +"std::begin", "std::cbegin", "std::rbegin",

[PATCH] D147779: [clang-tidy] Fix hungarian notation failed to indicate the number of asterisks in check-clang-extra-clang-tidy-checkers-readability

dougpuob updated this revision to Diff 512021. dougpuob added a comment. - Improved suggestions in code review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147779/new/ https://reviews.llvm.org/D147779 Files:

[PATCH] D140760: [clang-tidy] Support begin/end free functions in modernize-loop-convert

ccotter added a comment. bump - any other feedback? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140760/new/ https://reviews.llvm.org/D140760 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

v.g.vassilev added inline comments. Comment at: clang/include/clang/Interpreter/Interpreter.h:97 + + enum InterfaceKind { NoAlloc, WithAlloc, CopyArray }; + junaire wrote: > v.g.vassilev wrote: > > junaire wrote: > > > v.g.vassilev wrote: > > > > This can

[PATCH] D147857: [clang-tidy] fix false positve for namespace with attrs in modernize-concat-nested-namespaces

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbdf7fd8297bc: [clang-tidy] fix false positve for namespace with attrs in modernize-concat… (authored by HerrCai0907). Repository: rG LLVM Github

[clang-tools-extra] bdf7fd8 - [clang-tidy] fix false positve for namespace with attrs in modernize-concat-nested-namespaces

Author: Congcong Cai Date: 2023-04-09T16:23:29+02:00 New Revision: bdf7fd8297bcbcddc9c184a40c954c1f1b0b8340 URL: https://github.com/llvm/llvm-project/commit/bdf7fd8297bcbcddc9c184a40c954c1f1b0b8340 DIFF: https://github.com/llvm/llvm-project/commit/bdf7fd8297bcbcddc9c184a40c954c1f1b0b8340.diff

[PATCH] D147857: [clang-tidy] fix false positve for namespace with attrs in modernize-concat-nested-namespaces

HerrCai0907 updated this revision to Diff 512004. HerrCai0907 edited the summary of this revision. HerrCai0907 added a comment. merge items in release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147857/new/ https://reviews.llvm.org/D147857

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire added inline comments. Comment at: clang/include/clang/Interpreter/Interpreter.h:97 + + enum InterfaceKind { NoAlloc, WithAlloc, CopyArray }; + v.g.vassilev wrote: > junaire wrote: > > v.g.vassilev wrote: > > > This can probably go in the

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

v.g.vassilev added inline comments. Comment at: clang/include/clang/Interpreter/Interpreter.h:97 + + enum InterfaceKind { NoAlloc, WithAlloc, CopyArray }; + junaire wrote: > v.g.vassilev wrote: > > This can probably go in the RuntimeInterfaceBuilder class. > We

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire updated this revision to Diff 511999. junaire added a comment. Address some comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/include/clang/AST/Decl.h

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire added inline comments. Comment at: clang/include/clang/Interpreter/Interpreter.h:97 + + enum InterfaceKind { NoAlloc, WithAlloc, CopyArray }; + v.g.vassilev wrote: > This can probably go in the RuntimeInterfaceBuilder class. We need it. See: ``` class

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

v.g.vassilev added inline comments. Comment at: clang/lib/Interpreter/Interpreter.cpp:383 + +static std::string MangleName(ASTContext , GlobalDecl GD) { + std::unique_ptr MangleC(C.createMangleContext()); I suspect we could use

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

v.g.vassilev added inline comments. Comment at: clang/include/clang/AST/Decl.h:4345 + } + bool isValuePrinting() const { return MissingSemi; } + void setValuePrinting(bool Missing = true) { MissingSemi = Missing; } We should rename these to `isMissingSemi` or

[PATCH] D144218: [Clang] [AVR] Fix USHRT_MAX for 16-bit int.

barannikov88 added a comment. There is something wrong with the `#if`s, isn't it? They all look no-op. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144218/new/ https://reviews.llvm.org/D144218 ___

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire updated this revision to Diff 511984. junaire added a comment. Refactor how we compile a destructor Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/include/clang/AST/Decl.h

[PATCH] D147779: [clang-tidy] Fix hungarian notation failed to indicate the number of asterisks in check-clang-extra-clang-tidy-checkers-readability

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. LGTM, except pointed out issues with order of fixes in release note and missing const. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D147779: [clang-tidy] Fix hungarian notation failed to indicate the number of asterisks in check-clang-extra-clang-tidy-checkers-readability

PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp:706 +size_t IdentifierNamingCheck::HungarianNotation::getAsteriskCount( +std::string , const NamedDecl *ND) const { + size_t PtrCount = 0; const

[clang] 4f1954e - Revert (3) "[Assignment Tracking] Enable by default"

Author: OCHyams Date: 2023-04-09T11:21:55+01:00 New Revision: 4f1954ed67c12aca3fd3e67151185c64dc941768 URL: https://github.com/llvm/llvm-project/commit/4f1954ed67c12aca3fd3e67151185c64dc941768 DIFF: https://github.com/llvm/llvm-project/commit/4f1954ed67c12aca3fd3e67151185c64dc941768.diff LOG:

[PATCH] D147876: [WIP][clang-tidy] Support specifying Checks as a list in the config file

carlosgalvezp updated this revision to Diff 511972. carlosgalvezp retitled this revision from "[WIP][clang-tidy] Support introducing checks as a list in the config file" to "[WIP][clang-tidy] Support specifying Checks as a list in the config file". carlosgalvezp added a comment. Update commit

[PATCH] D147876: [WIP][clang-tidy] Support introducing checks as a list in the config file

carlosgalvezp updated this revision to Diff 511970. carlosgalvezp added a comment. Add tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147876/new/ https://reviews.llvm.org/D147876 Files: clang-tools-extra/clang-tidy/ClangTidyOptions.cpp

[PATCH] D147779: [clang-tidy] Fix hungarian notation failed to indicate the number of asterisks in check-clang-extra-clang-tidy-checkers-readability

dougpuob updated this revision to Diff 511969. dougpuob marked 2 inline comments as done. dougpuob added a comment. - Extract method - Remove template parameters in the getDeclTypeName() function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D147779: [clang-tidy] Fix hungarian notation failed to indicate the number of asterisks in check-clang-extra-clang-tidy-checkers-readability

dougpuob marked 2 inline comments as done. dougpuob added a comment. In D147779#4251081 , @PiotrZSL wrote: > Missing release notes. Thank you for reminding me. Comment at:

[PATCH] D147876: [WIP][clang-tidy] Support introducing checks as a list in the config file

carlosgalvezp created this revision. Herald added subscribers: PiotrZSL, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. carlosgalvezp requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Fixes

[clang] f11e147 - Reapply (2) "[Assignment Tracking] Enable by default"

Author: OCHyams Date: 2023-04-09T09:59:26+01:00 New Revision: f11e1475c97c1ba6b418838f3592de930677c3d0 URL: https://github.com/llvm/llvm-project/commit/f11e1475c97c1ba6b418838f3592de930677c3d0 DIFF: https://github.com/llvm/llvm-project/commit/f11e1475c97c1ba6b418838f3592de930677c3d0.diff LOG:

[PATCH] D147874: [clang-tidy] Fix AST Library documentation link

This revision was automatically updated to reflect the committed changes. Closed by commit rG9f5951f11a0e: [clang-tidy] Fix AST Library documentation link (authored by sousajo, committed by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 9f5951f - [clang-tidy] Fix AST Library documentation link

Author: Jorge Pinto Sousa Date: 2023-04-09T08:47:54Z New Revision: 9f5951f11a0ef3227077d5a47b62e8842655fbd8 URL: https://github.com/llvm/llvm-project/commit/9f5951f11a0ef3227077d5a47b62e8842655fbd8 DIFF: https://github.com/llvm/llvm-project/commit/9f5951f11a0ef3227077d5a47b62e8842655fbd8.diff

[PATCH] D122573: [TBAA] Emit distinct TBAA tags for pointers with different depths,types.

xbolva00 added a comment. @fhahn do you plan to continue with this change? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122573/new/ https://reviews.llvm.org/D122573 ___ cfe-commits mailing list

[PATCH] D147874: [clang-tidy] Fix AST Library documentation link

sousajo added a comment. I dont have commit access, can someone land it for me? Name: Jorge Pinto Sousa Email: CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147874/new/ https://reviews.llvm.org/D147874 ___ cfe-commits mailing list

[PATCH] D147875: [clang][Diagnostics] WIP: Show line numbers when printing code snippets

tbaeder added inline comments. Comment at: clang/lib/Frontend/TextDiagnostic.cpp:1141 +} + /// Emit a code snippet and caret line. Wrote this just to get things going but I hope there's something better than this...? Repository: rG LLVM Github Monorepo

[PATCH] D147875: [clang][Diagnostics] WIP: Show line numbers when printing code snippets

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, cjdb. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Just putting this here because it's a pretty simple patch as it turns out.

[PATCH] D145803: [clang][DebugInfo] Emit DW_AT_type of preferred name if available

chapuni added inline comments. Comment at: clang/test/Modules/gmodules-preferred-name-alias.cpp:6 +// RUN: -fmodules -mllvm -debug-only=pchcontainer -x c++ \ +// RUN: -I %S/Inputs %s &> %t.ll +// RUN: cat %t.ll | FileCheck %s I guess it made difficult to

[PATCH] D147874: [clang-tidy] Fix AST Library documentation link

sousajo created this revision. sousajo added reviewers: LegalizeAdulthood, vtjnash. Herald added subscribers: PiotrZSL, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. sousajo requested review of this revision. Herald added a project: clang-tools-extra. Herald added a

[PATCH] D146520: [clang-tidy] Fix checks filter with warnings-as-errors

carlosgalvezp added a comment. It would still be good to add some test that ensures this does not happen again in the future, though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146520/new/ https://reviews.llvm.org/D146520

[PATCH] D147857: [clang-tidy] fix false positve for namespace with attrs in modernize-concat-nested-namespaces

PiotrZSL added a comment. Reference issue in commit message, so it could auto-close, or close it manualy later. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147857/new/ https://reviews.llvm.org/D147857

[PATCH] D147857: [clang-tidy] fix false positve for namespace with attrs in modernize-concat-nested-namespaces

PiotrZSL accepted this revision. PiotrZSL added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:304-310 - Fixed an issue in :doc:`modernize-concat-nested-namespaces ` when using macro between namespace

[PATCH] D143974: [clangd] Inactive regions support via dedicated protocol

nridge marked an inline comment as done. nridge added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:977 + return CB(InpAST.takeError()); +// Include inactive regions in semantic highlighting tokens only if the +// client doesn't support a

[PATCH] D143974: [clangd] Inactive regions support via dedicated protocol

nridge updated this revision to Diff 511957. nridge marked 3 inline comments as done. nridge added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143974/new/ https://reviews.llvm.org/D143974 Files:

[PATCH] D147395: [Clangd] Make the type hint length limit configurable

zhangyi1357 added a comment. I dont have commit access. Could you help committing the change for me? @hokein Comment at: clang-tools-extra/clangd/Config.h:151 +// Limit the length of type names in inlay hints. +size_t TypeNameLimit = 32; } InlayHints;