[PATCH] D78644: [LSan] Enable for SystemZ

MaskRay added inline comments. Herald added a subscriber: Enna1. Herald added a project: All. Comment at: compiler-rt/lib/lsan/lsan_allocator.h:76 +#elif defined(__s390x__) +const uptr kAllocatorSpace = 0x400ULL; +const uptr kAllocatorSize = 0x400ULL; // 4T.

[PATCH] D148223: [SiFive] Support C intrinsics for xsfvcp extension.

craig.topper added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:2422 + // Log2LMUL to zero. Otherwise the RISCVVEmitter will expand + // lots of redunant intrinsic but have same names. + let Log2LMUL = [0] in

[PATCH] D146090: [Clang] Updating handling of defaulted comparison operators to reflect changes from P2448R2

shafik updated this revision to Diff 513412. shafik added a comment. Fix DiagnosticSemaKinds.td , was missing an opening quote CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146090/new/ https://reviews.llvm.org/D146090 Files: clang/docs/ReleaseNotes.rst

[PATCH] D148223: [SiFive] Support C intrinsics for xsfvcp extension.

craig.topper added a comment. We need SemaChecking.cpp code to check the range of the constant arguments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148223/new/ https://reviews.llvm.org/D148223 ___

[PATCH] D145088: [RISCV] Add attribute(riscv_rvv_vector_bits(N)) based on AArch64 arm_sve_vector_bits.

craig.topper added inline comments. Comment at: clang/test/SemaCXX/attr-riscv-rvv-vector-bits.cpp:12 + +template struct S { T var; }; + erichkeane wrote: > craig.topper wrote: > > aaron.ballman wrote: > > > craig.topper wrote: > > > > aaron.ballman wrote: > > >

[PATCH] D148284: [clangd] Add "readonly" token to const member expressions

t-troebst updated this revision to Diff 513406. t-troebst added a comment. Changed `isConstQualifed()` to the custom `isConst()` (though this `isConst()` behaves strangely for pointer types, we should fix this separately and keep them synced for now). Repository: rG LLVM Github Monorepo

[PATCH] D148260: [clang] Mark CWG2331 as N/A

shafik added a comment. The defect report has two examples even though the first one is commented incorrectly considering the final resolution. I am sure they are covered in the test suite in other places but why not add them? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D148284: [clangd] Add "readonly" token to const member expressions

t-troebst created this revision. t-troebst added a reviewer: nridge. t-troebst added a project: clang-tools-extra. Herald added subscribers: kadircet, arphaman. Herald added a project: All. t-troebst requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.

[PATCH] D148206: [clang] Do not crash after suggesting typo correction to constexpr if condition

shafik added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148206/new/ https://reviews.llvm.org/D148206 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D146090: [Clang] Updating handling of defaulted comparison operators to reflect changes from P2448R2

shafik added inline comments. Comment at: clang/test/CXX/class/class.compare/class.compare.default/p4.cpp:162 + +my_struct obj; // extension-note {{in instantiation of template class 'GH61238::my_struct' requested here}} +} aaron.ballman wrote: > Can you add

[PATCH] D146090: [Clang] Updating handling of defaulted comparison operators to reflect changes from P2448R2

shafik updated this revision to Diff 513397. shafik marked 8 inline comments as done. shafik added a comment. - Updating diagnostic wording, formatting and names - Updated release notes - Updated c++ status - Updates tests to comment that they will change once we fully support P2448R2 - Various

[PATCH] D147732: [AMDGPU] Add f32 permlane{16, x16} builtin variants

jrbyrnes updated this revision to Diff 513386. jrbyrnes marked an inline comment as done. jrbyrnes added a comment. Use type mangling Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147732/new/ https://reviews.llvm.org/D147732 Files:

[PATCH] D148274: [clang] Fix overly aggressive lifetime checks for parenthesized aggregate initialization

ayzhao added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:2130 + "initializer|a related result|a parameter of CF audited function|a " + "structured binding|a member subobject}0 " "%diff{of type $ with an %select{rvalue|lvalue}2 of type $|"

[PATCH] D148274: [clang] Fix overly aggressive lifetime checks for parenthesized aggregate initialization

ayzhao updated this revision to Diff 513377. ayzhao added a comment. fix missing EOF newline Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148274/new/ https://reviews.llvm.org/D148274 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D148274: [clang] Fix overly aggressive lifetime checks for parenthesized aggregate initialization

ayzhao created this revision. Herald added a project: All. ayzhao requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Before this patch, initialized class members would have the LifetimeKind LK_MemInitializer, which does not allow for binding

[PATCH] D147176: [clang-format] NFC ensure Style operator== remains sorted for ease of editing

owenpan added a comment. In D147176#4265130 , @MyDeveloperDay wrote: > we should be good now Thanks! I really like these new rules! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147176/new/

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

sgraenitz added a comment. This looks a lot better already than the implementation I know from Cling. Well done! OTOH it's a challenge to review since the patch is really big. Is there no way to break it up and test in isolation? Or strip away details that could be added in iterations? I had

[PATCH] D146329: [Clang] Fix defaulted equality operator so that it does not attempt to compare unnamed bit-fields

shafik updated this revision to Diff 513345. shafik marked an inline comment as done. shafik added a comment. - Update codegen test based on feedback CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146329/new/ https://reviews.llvm.org/D146329 Files: clang/lib/Sema/SemaDeclCXX.cpp

[PATCH] D146764: [clang] Make predefined expressions string literals under -fms-extensions

aeubanks added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:3586-3591 + // MSVC treats all predefined expressions as string literals rather than char + // arrays. + if (LangOpts.MicrosoftExt) +return SL; + return PredefinedExpr::Create(Context, Loc, ResTy,

[PATCH] D146764: [clang] Make predefined expressions string literals under -fms-extensions

aeubanks updated this revision to Diff 513337. aeubanks added a comment. add comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146764/new/ https://reviews.llvm.org/D146764 Files: clang/include/clang/AST/Expr.h

[PATCH] D148268: [clang] Make predefined expressions string literals under -fms-extensions

aeubanks created this revision. Herald added a subscriber: martong. Herald added a reviewer: shafik. Herald added a project: All. aeubanks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. MSVC makes these string literals [1][2]. [1]

[PATCH] D146764: [clang] Make predefined expressions string literals under -fms-extensions

aeubanks updated this revision to Diff 513335. aeubanks added a comment. Herald added a subscriber: martong. use IgnoreParens instead Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146764/new/ https://reviews.llvm.org/D146764 Files:

[PATCH] D141389: [DFSAN] Add support for strnlen, strncat, strsep, sscanf and _tolower

tkuchta updated this revision to Diff 51. tkuchta added a comment. Thank you, I have uploaded a new diff with "&" fixed in the test function. How should be proceed with the other functions once strsep is done? Should I open another review or add the code to the current patch? CHANGES

[PATCH] D148266: [clang][driver] Linking to just-built libc++.dylib when bootstrapping libc++ with clang

fahadnayyar created this revision. Herald added a project: All. fahadnayyar requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. When libc++ is bootstrapped with clang using the cmake options -DLLVM_ENABLE_PROJECTS="clang;llvm;lldb" and

[PATCH] D148034: [clang][driver] Disable GP relaxation with RISC-V ShadowCallStack

MaskRay added a comment. In D148034#4264996 , @asb wrote: > In D148034#4262991 , @MaskRay wrote: > >> In D148034#4260376 , @asb wrote: >> >>> Will `--[no-]relax-gp` make

[PATCH] D144331: [libc++][format] Implements formatter thread::id.

manojgupta added a comment. Thanks, sent a patch to gdb at https://sourceware.org/pipermail/gdb-patches/2023-April/198870.html Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144331/new/ https://reviews.llvm.org/D144331

[PATCH] D148124: [RISCV][Driver] Allow the use of CPUs with a different XLEN than the triple.

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148124/new/ https://reviews.llvm.org/D148124

[PATCH] D148181: [Demangle] make llvm::demangle take a StringRef; NFC

nickdesaulniers added inline comments. Comment at: llvm/lib/Demangle/Demangle.cpp:31 std::string Result; - const char *S = MangledName.c_str(); + std::string Copy = MangledName.str(); + const char *S = Copy.data(); erichkeane wrote: > nickdesaulniers

[PATCH] D144331: [libc++][format] Implements formatter thread::id.

tahonermann added a comment. > It adds an include of #include <__format/formatter_integral.h> which ends up > including which has internal definitions of isupper/islower causing > clang to complain. > > Any suggestions on what would be the right fix here? It sounds like `safe-ctype.h` should

[PATCH] D148181: [Demangle] make llvm::demangle take a StringRef; NFC

erichkeane added inline comments. Comment at: llvm/lib/Demangle/Demangle.cpp:31 std::string Result; - const char *S = MangledName.c_str(); + std::string Copy = MangledName.str(); + const char *S = Copy.data(); nickdesaulniers wrote: > nickdesaulniers

[PATCH] D148263: [clang] Mark CWG2009 as N/A

Endill created this revision. Endill added reviewers: clang-language-wg, shafik. Herald added a project: All. Endill requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. P1787 : CWG2331 is resolved by defining lookup

[PATCH] D148181: [Demangle] make llvm::demangle take a StringRef; NFC

nickdesaulniers added inline comments. Comment at: llvm/lib/Demangle/Demangle.cpp:31 std::string Result; - const char *S = MangledName.c_str(); + std::string Copy = MangledName.str(); + const char *S = Copy.data(); nickdesaulniers wrote: > erichkeane

[PATCH] D148177: [Clang][AIX] Remove error for -fprofile-instr-generate/use on AIX

qiongsiwu1 accepted this revision. qiongsiwu1 added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148177/new/ https://reviews.llvm.org/D148177

[PATCH] D144331: [libc++][format] Implements formatter thread::id.

manojgupta added a comment. Hmm, looking deeper, gdb (actually binutils), is doing something weird. https://github.com/bminor/binutils-gdb/blob/master/include/safe-ctype.h /* Prevent the users of safe-ctype.h from accidently using the routines from ctype.h. Initially, the approach was

[PATCH] D148262: [clang][cmake] Add options to pass in vcs repo and revision info

zhuhan0 created this revision. Herald added subscribers: ekilmer, hoy, wenlei. Herald added a project: All. zhuhan0 requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Clang may be built in an environment where Git is not

[clang] 6251b04 - [-Wunsafe-buffer-usage] A follow-up fix to 762af11d4c5d0bd1e76f23a07087773db09ef17d

Author: Ziqing Luo Date: 2023-04-13T11:24:46-07:00 New Revision: 6251b04fc76a45d5a9c00bfb5010b9bbbcefb9b0 URL: https://github.com/llvm/llvm-project/commit/6251b04fc76a45d5a9c00bfb5010b9bbbcefb9b0 DIFF: https://github.com/llvm/llvm-project/commit/6251b04fc76a45d5a9c00bfb5010b9bbbcefb9b0.diff

[clang] 363c98b - Revert "[Modules] Remove unnecessary check when generating name lookup table in ASTWriter"

Author: Fangrui Song Date: 2023-04-13T11:17:35-07:00 New Revision: 363c98b2d67986b9766bb1426739970ce6d9a6f3 URL: https://github.com/llvm/llvm-project/commit/363c98b2d67986b9766bb1426739970ce6d9a6f3 DIFF: https://github.com/llvm/llvm-project/commit/363c98b2d67986b9766bb1426739970ce6d9a6f3.diff

[PATCH] D145088: [RISCV] Add attribute(riscv_rvv_vector_bits(N)) based on AArch64 arm_sve_vector_bits.

erichkeane added inline comments. Comment at: clang/test/SemaCXX/attr-riscv-rvv-vector-bits.cpp:12 + +template struct S { T var; }; + craig.topper wrote: > aaron.ballman wrote: > > craig.topper wrote: > > > aaron.ballman wrote: > > > > erichkeane wrote: > > > >

[PATCH] D148260: [clang] Mark CWG2331 as N/A

Endill created this revision. Endill added reviewers: clang-language-wg, shafik. Herald added a project: All. Endill requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. P1787 : CWG2331 is resolved by defining lookup

[PATCH] D145088: [RISCV] Add attribute(riscv_rvv_vector_bits(N)) based on AArch64 arm_sve_vector_bits.

craig.topper added inline comments. Comment at: clang/test/SemaCXX/attr-riscv-rvv-vector-bits.cpp:12 + +template struct S { T var; }; + aaron.ballman wrote: > craig.topper wrote: > > aaron.ballman wrote: > > > erichkeane wrote: > > > > craig.topper wrote: > > >

[PATCH] D148181: [Demangle] make llvm::demangle take a StringRef; NFC

nickdesaulniers added inline comments. Comment at: llvm/lib/Demangle/Demangle.cpp:31 std::string Result; - const char *S = MangledName.c_str(); + std::string Copy = MangledName.str(); + const char *S = Copy.data(); erichkeane wrote: > `std::string` is

[PATCH] D147802: [clangd] Handle destructors in DefineOutline tweak

njames93 added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineOutline.cpp:186-194 + if (const auto *Destructor = llvm::dyn_cast(FD)) { +if (auto Err = DeclarationCleanups.add(tooling::Replacement( +SM, Destructor->getLocation(), 0, +

[PATCH] D148110: [clang-tidy] Ctor arguments are sequenced if ctor call is written as list-initialization.

njames93 added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone/use-after-move.cpp:1163 +namespace { + Whats with this namespace addition? looks unnecessary and should be removed Comment at:

[PATCH] D142410: [AArch64] ARMv8.5-A implies both FEAT_SB and FEAT_SSBS

philipp.tomsich abandoned this revision. philipp.tomsich added a comment. I just saw that the last response was "unsubmitted". Submitting and abandoning this revision (based on the discussion and the previously unsubmitted comment from my end). Comment at:

[PATCH] D147989: [clang] Fix Attribute Placement

jrtc27 added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:5041 case DeclSpec::TST_enum: return 4; default: Why not just always pass the full DeclSpec and handle the class case here, maybe with a bool to allow other users to not need to

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

alexander-shaposhnikov planned changes to this revision. alexander-shaposhnikov added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:773 + // ConstrExpr for the inner template will properly adjust the depths. + if (isa(ND) && isa(OtherND)) +

[PATCH] D148189: [NFC][Clang] Fix static analyzer tool remark about missing user-defined assignment operator

Manna added a comment. The lit test failure seem unrelated to my fix: https://buildkite.com/llvm-project/premerge-checks/builds/146438#0187786e-2f04-40a2-acf1-78eee9f00e7f Failed Tests (1): Clang :: SemaCXX/warn-unsafe-buffer-usage-fixits-pre-increment.cpp Repository: rG LLVM Github

[PATCH] D148206: [clang] Do not crash after suggesting typo correction to constexpr if condition

Fznamznon updated this revision to Diff 513290. Fznamznon added a comment. Use std::optional Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148206/new/ https://reviews.llvm.org/D148206 Files: clang/docs/ReleaseNotes.rst

[PATCH] D148189: [NFC][Clang] Fix static analyzer tool remark about missing user-defined assignment operator

Manna added a comment. Thank you @aaron.ballman for reviews and feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148189/new/ https://reviews.llvm.org/D148189 ___ cfe-commits mailing list

[PATCH] D147935: [RISCV] Add SiFive extension support

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147935/new/ https://reviews.llvm.org/D147935

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:773 + // ConstrExpr for the inner template will properly adjust the depths. + if (isa(ND) && isa(OtherND)) +ForConstraintInstantiation = true; erichkeane wrote: > erichkeane

[PATCH] D141389: [DFSAN] Add support for strnlen, strncat, strsep, sscanf and _tolower

browneee accepted this revision. browneee added a comment. This revision is now accepted and ready to land. Please fix the additional &. Do you need me to submit it for you? Comment at: compiler-rt/test/dfsan/custom.cpp:1645 + // taint the string pointer +

[clang] 3ac5509 - [clang][ExtractAPI] Complete declaration fragments for TagDecl types defined in a typedef

Author: ruturaj4 Date: 2023-04-13T17:55:45+01:00 New Revision: 3ac550984e83c2478772c800b1f1b5cffd63a10d URL: https://github.com/llvm/llvm-project/commit/3ac550984e83c2478772c800b1f1b5cffd63a10d DIFF: https://github.com/llvm/llvm-project/commit/3ac550984e83c2478772c800b1f1b5cffd63a10d.diff

[PATCH] D146385: [clang][ExtractAPI] Complete declaration fragments for TagDecl types defined in a typedef

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3ac550984e83: [clang][ExtractAPI] Complete declaration fragments for TagDecl types defined in… (authored by Ruturaj4, committed by dang). Changed

[PATCH] D148245: Model list initialization more directly; fixes an assert with coverage mapping

erichkeane added a comment. I think this makes sense. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148245/new/ https://reviews.llvm.org/D148245 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D148206: [clang] Do not crash after suggesting typo correction to constexpr if condition

Fznamznon added inline comments. Comment at: clang/include/clang/Sema/Sema.h:12855 +!Condition.get()->isValueDependent() && +Condition.get()->isIntegerConstantExpr(S.Context)), KnownValue(HasKnownValue &&

[PATCH] D148206: [clang] Do not crash after suggesting typo correction to constexpr if condition

Fznamznon updated this revision to Diff 513276. Fznamznon added a comment. Rebase, evaluate the expression only only time Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148206/new/ https://reviews.llvm.org/D148206 Files:

[PATCH] D148245: Model list initialization more directly; fixes an assert with coverage mapping

aaron.ballman created this revision. aaron.ballman added reviewers: erichkeane, rsmith, zequanwu. Herald added a subscriber: martong. Herald added a reviewer: shafik. Herald added a project: All. aaron.ballman requested review of this revision. Herald added a project: clang. Instead of using the

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:773 + // ConstrExpr for the inner template will properly adjust the depths. + if (isa(ND) && isa(OtherND)) +ForConstraintInstantiation = true; erichkeane wrote: >

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

alexander-shaposhnikov added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:773 + // ConstrExpr for the inner template will properly adjust the depths. + if (isa(ND) && isa(OtherND)) +ForConstraintInstantiation = true; erichkeane wrote: >

[PATCH] D144331: [libc++][format] Implements formatter thread::id.

tahonermann added subscribers: cor3ntin, tahonermann. tahonermann added a comment. Adding Corentin for awareness. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144331/new/ https://reviews.llvm.org/D144331

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:773 + // ConstrExpr for the inner template will properly adjust the depths. + if (isa(ND) && isa(OtherND)) +ForConstraintInstantiation = true; erichkeane wrote: >

[PATCH] D148021: [Headers][doc] Add FMA intrinsic descriptions

probinson added inline comments. Comment at: clang/lib/Headers/fmaintrin.h:22 +/// Computes a multiply-add of 128-bit vectors of [4 x float]. +///For each element, computes (__A * __B) + __C . +/// pengfei wrote: > We are using a special format to

[PATCH] D147256: [DebugInfo] Fix file path separator when targeting windows.

zequanwu updated this revision to Diff 513252. zequanwu added a comment. Herald added a subscriber: MaskRay. - Move remove_dots to clang driver. - Revert changes to llc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147256/new/

[PATCH] D146987: [Assignment Tracking] Enable by default

aeubanks added a comment. IR that passes the verifier generally shouldn't crash llvm, so an alternative would be to make a verifier check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146987/new/ https://reviews.llvm.org/D146987

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:773 + // ConstrExpr for the inner template will properly adjust the depths. + if (isa(ND) && isa(OtherND)) +ForConstraintInstantiation = true; alexander-shaposhnikov wrote: >

[PATCH] D148206: [clang] Do not crash after suggesting typo correction to constexpr if condition

aaron.ballman added inline comments. Comment at: clang/include/clang/Sema/Sema.h:12855 +!Condition.get()->isValueDependent() && +Condition.get()->isIntegerConstantExpr(S.Context)), KnownValue(HasKnownValue &&

[PATCH] D147073: [Coverage] Handle invalid end location of an expression/statement.

This revision was automatically updated to reflect the committed changes. Closed by commit rG0529da5b948c: [Coverage] Handle invalid end location of an expression/statement. (authored by zequanwu). Changed prior to commit: https://reviews.llvm.org/D147073?vs=512971=513236#toc Repository: rG

[clang] 0529da5 - [Coverage] Handle invalid end location of an expression/statement.

Author: Zequan Wu Date: 2023-04-13T10:53:02-04:00 New Revision: 0529da5b948cf168f65bec65b0559139f4f5a426 URL: https://github.com/llvm/llvm-project/commit/0529da5b948cf168f65bec65b0559139f4f5a426 DIFF: https://github.com/llvm/llvm-project/commit/0529da5b948cf168f65bec65b0559139f4f5a426.diff

[PATCH] D148213: [clangd] Use FileEntryRef for canonicalizing filepaths.

This revision was automatically updated to reflect the committed changes. Closed by commit rGed365f464a0a: [clangd] Use FileEntryRef for canonicalizing filepaths. (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148213/new/

[clang-tools-extra] ed365f4 - [clangd] Use FileEntryRef for canonicalizing filepaths.

Author: Utkarsh Saxena Date: 2023-04-13T16:49:30+02:00 New Revision: ed365f464a0a29da08d0a1011603c4cd337c9428 URL: https://github.com/llvm/llvm-project/commit/ed365f464a0a29da08d0a1011603c4cd337c9428 DIFF:

[PATCH] D148213: [clangd] Use FileEntryRef for canonicalizing filepaths.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148213/new/ https://reviews.llvm.org/D148213

[PATCH] D147935: [RISCV] Add SiFive extension support

4vtomat updated this revision to Diff 513223. 4vtomat added a comment. Resolved Alex's comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147935/new/ https://reviews.llvm.org/D147935 Files: clang/include/clang/Support/RISCVVIntrinsicUtils.h

[PATCH] D145868: [clang][ASTImporter] Fix import of typedef with unnamed structures

bjope added inline comments. Comment at: clang/unittests/AST/ASTImporterTest.cpp:8627 + )"; + Decl *ToTU = getToTuDecl("", Lang_CXX11); + Decl *FromTU = getTuDecl(Code, Lang_CXX11); balazske wrote: > bjope wrote: > > With Werror we get: > > > > ``` > >

[PATCH] D125171: [clang-format] Add a new clang-format option AlwaysBreakBeforeFunctionParameters

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/Format.cpp:876 Style.AlwaysBreakBeforeMultilineStrings); +IO.mapOptional("AlwaysBreakBeforeFunctionParameters", + Style.AlwaysBreakBeforeFunctionParameters);

[PATCH] D142630: [clang][Interp] Implement virtual function calls

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142630/new/ https://reviews.llvm.org/D142630 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] 4a6a4f8 - [clang][Interp] Add a failing test case

Author: Timm Bäder Date: 2023-04-13T15:55:57+02:00 New Revision: 4a6a4f84a7af7212d36aea9c34a1a8b9bb05d733 URL: https://github.com/llvm/llvm-project/commit/4a6a4f84a7af7212d36aea9c34a1a8b9bb05d733 DIFF: https://github.com/llvm/llvm-project/commit/4a6a4f84a7af7212d36aea9c34a1a8b9bb05d733.diff

[PATCH] D148213: [clangd] Use FileEntryRef for canonicalizing filepaths.

usaxena95 updated this revision to Diff 513219. usaxena95 marked 6 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148213/new/ https://reviews.llvm.org/D148213 Files:

[PATCH] D147176: [clang-format] NFC ensure Style operator== remains sorted for ease of editing

MyDeveloperDay added a comment. we should be good now F27132578: image.png Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147176/new/ https://reviews.llvm.org/D147176

[PATCH] D144943: [clang][Interp] Implement bitcasts (WIP)

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144943/new/ https://reviews.llvm.org/D144943 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D144457: [clang][Interp] Handle global composite temporaries

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144457/new/ https://reviews.llvm.org/D144457 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D143334: [clang][Interp] Fix diagnosing uninitialized ctor record arrays

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143334/new/ https://reviews.llvm.org/D143334 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D144164: [clang][Interp] Handle PtrMemOps

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144164/new/ https://reviews.llvm.org/D144164 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D147535: [clang][Interp] Don't create global variables more than once

This revision was automatically updated to reflect the committed changes. Closed by commit rGf508d9b1d4fa: [clang][Interp] Dont create global variables more than once (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147535/new/

[clang] f508d9b - [clang][Interp] Don't create global variables more than once

Author: Timm Bäder Date: 2023-04-13T15:41:43+02:00 New Revision: f508d9b1d4fa48e7586b9587a22be23c976297a7 URL: https://github.com/llvm/llvm-project/commit/f508d9b1d4fa48e7586b9587a22be23c976297a7 DIFF: https://github.com/llvm/llvm-project/commit/f508d9b1d4fa48e7586b9587a22be23c976297a7.diff

[PATCH] D147176: [clang-format] NFC ensure Style operator== remains sorted for ease of editing

MyDeveloperDay added a comment. In D147176#4263621 , @owenpan wrote: > @MyDeveloperDay We keep getting "spammed" by [libc++][format] patches. Can > you delete the rule in H987 : > > "field":

[PATCH] D148200: [clang-format] Correctly indent comment above PP Directive

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148200/new/ https://reviews.llvm.org/D148200

[PATCH] D147534: [clang][Interp] Make sure we have a variable scope for initializers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG25d6123854d1: [clang][Interp] Make sure we have a variable scope for initializers (authored by tbaeder). Repository: rG LLVM Github Monorepo

[clang] 25d6123 - [clang][Interp] Make sure we have a variable scope for initializers

Author: Timm Bäder Date: 2023-04-13T15:35:30+02:00 New Revision: 25d6123854d16370463ba884e750f303d09e9001 URL: https://github.com/llvm/llvm-project/commit/25d6123854d16370463ba884e750f303d09e9001 DIFF: https://github.com/llvm/llvm-project/commit/25d6123854d16370463ba884e750f303d09e9001.diff

[PATCH] D148213: [clangd] Use FileEntryRef for canonicalizing filepaths.

kadircet added a comment. we've got one more reference to `getCanonicalPath` in `clang-tools-extra/clangd/IncludeCleaner.cpp:320`, i guess the best way is just calling `getLastRef` on the FileEntry* Comment at: clang-tools-extra/clangd/SourceCode.cpp:518

[PATCH] D147935: [RISCV] Add SiFive extension support

4vtomat added a comment. In D147935#4259687 , @craig.topper wrote: > Is there a different patch with the .td for these intrinsics? Yes, it's in this patch: D148223 Comment at:

[PATCH] D148223: [SiFive] Support C intrinsics for xsfvcp extension.

4vtomat created this revision. Herald added subscribers: luke, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, niosHD, sabuasal, simoncook, johnrusso, rbar, asb. Herald added a project:

[PATCH] D148181: [Demangle] make llvm::demangle take a StringRef; NFC

erichkeane added a comment. We're C++17 compilation now, so we should be able to use `std::string_view` (and I think we're supposed to?). Comment at: llvm/lib/Demangle/Demangle.cpp:31 std::string Result; - const char *S = MangledName.c_str(); + std::string Copy =

[PATCH] D148034: [clang][driver] Disable GP relaxation with RISC-V ShadowCallStack

asb added a comment. In D148034#4262991 , @MaskRay wrote: > In D148034#4260376 , @asb wrote: > >> Will `--[no-]relax-gp` make its way into a minor gcc point release or do we >> need to wait for the next major

[PATCH] D146329: [Clang] Fix defaulted equality operator so that it does not attempt to compare unnamed bit-fields

erichkeane added inline comments. Comment at: clang/test/CodeGenCXX/defaulted_equality_ignore_unnamed_bitfields.cpp:23 + +// If it compares the unnamed bitfields it will first compare the named bit-field +// and then branch based on the result of that comparison.

[PATCH] D147073: [Coverage] Handle invalid end location of an expression/statement.

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147073/new/ https://reviews.llvm.org/D147073 ___ cfe-commits mailing list

[PATCH] D143347: [lldb][DWARF] Infer no_unique_address attribute

Michael137 added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:2212 m_ast.GetAsCXXRecordDecl(clang_type.GetOpaqueQualType()); -if (record_decl) +if (record_decl) { + bool is_empty = true;

[PATCH] D148189: [NFC][Clang] Fix static analyzer tool remark about missing user-defined assignment operator

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! It's not strictly needed (the move constructor causes the implicit assignment operator to be deleted: https://eel.is/c++draft/class.copy.assign#2.sentence-2), but I think

[PATCH] D142907: LangRef: Add "dynamic" option to "denormal-fp-math"

arsenm added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142907/new/ https://reviews.llvm.org/D142907 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D145868: [clang][ASTImporter] Fix import of typedef with unnamed structures

balazske marked an inline comment as done. balazske added inline comments. Comment at: clang/unittests/AST/ASTImporterTest.cpp:8627 + )"; + Decl *ToTU = getToTuDecl("", Lang_CXX11); + Decl *FromTU = getTuDecl(Code, Lang_CXX11); bjope wrote: > With Werror

  1   2   >