[PATCH] D148496: [compiler-rt] [test] Mark dfsan tests XFAIL on glibc-2.37

mgorny created this revision. mgorny added reviewers: browneee, vitalybuka, MaskRay, thesamesam, jianzhou.zh. Herald added subscribers: Enna1, dberris. Herald added a project: All. mgorny requested review of this revision. Mark the two dfsan tests that are known to be broken on glibc-2.37 as

[PATCH] D144634: [Clang][OpenMP] Support for Code Generation of loop bind clause

koops updated this revision to Diff 514096. koops added a comment. 1. Adding semantic test clang/test/OpenMP/loop_bind_messages.cpp. 2. Changes suggested by Alexey. 3. >Why need to drop bind clause here? The new Directives to which loop directive is being mapped to, do not contain the bind

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

alexander-shaposhnikov added a comment. https://github.com/llvm/llvm-project/issues/62110 is still a blocker for this diff though (haven't investigated it yet) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146178/new/

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

alexander-shaposhnikov updated this revision to Diff 514095. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146178/new/ https://reviews.llvm.org/D146178 Files: clang/include/clang/Sema/Template.h clang/lib/Sema/SemaConcept.cpp

[PATCH] D148439: [clang-rename] Exit gracefully when no input provided

xgupta added a comment. In D148439#4272813 , @dyung wrote: > This change is also causing 33 test failures on a build bot > https://lab.llvm.org/buildbot/#/builders/139/builds/39267 Yes, checking for the reason, and honestly I never tried to run

[PATCH] D148439: [clang-rename] Exit gracefully when no input provided

dyung added a comment. This change is also causing 33 test failures on a build bot https://lab.llvm.org/buildbot/#/builders/139/builds/39267 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148439/new/ https://reviews.llvm.org/D148439

[PATCH] D148439: [clang-rename] Exit gracefully when no input provided

xgupta added a comment. In D148439#4272810 , @dyung wrote: > Is there a reason a test was not added with this change? Sorry, I missed that. Adding. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 06387f9 - Revert "[clang-rename] Exit gracefully when no input provided"

Author: Shivam Gupta Date: 2023-04-17T10:31:40+05:30 New Revision: 06387f94cfdf6bbd37ac3b925a50410e11a1fc9d URL: https://github.com/llvm/llvm-project/commit/06387f94cfdf6bbd37ac3b925a50410e11a1fc9d DIFF: https://github.com/llvm/llvm-project/commit/06387f94cfdf6bbd37ac3b925a50410e11a1fc9d.diff

[PATCH] D148439: [clang-rename] Exit gracefully when no input provided

dyung added a comment. Is there a reason a test was not added with this change? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148439/new/ https://reviews.llvm.org/D148439 ___ cfe-commits mailing list

[PATCH] D148439: [clang-rename] Exit gracefully when no input provided

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. xgupta marked an inline comment as done. Closed by commit rG726199146a0b: [clang-rename] Exit gracefully when no input provided (authored by xgupta). Repository: rG

[clang] 7261991 - [clang-rename] Exit gracefully when no input provided

Author: Shivam Gupta Date: 2023-04-17T10:23:53+05:30 New Revision: 726199146a0bb53315ade042e759c65e6d96d556 URL: https://github.com/llvm/llvm-project/commit/726199146a0bb53315ade042e759c65e6d96d556 DIFF: https://github.com/llvm/llvm-project/commit/726199146a0bb53315ade042e759c65e6d96d556.diff

[PATCH] D148439: [clang-rename] Exit gracefully when no input provided

xgupta marked an inline comment as done. xgupta added inline comments. Comment at: clang/tools/clang-rename/ClangRename.cpp:130 + } else { +errs() << "clang-rename: No input provided.\n"; +return 1; kbobyrev wrote: > Probably something like "input must

[PATCH] D148439: [clang-rename] Exit gracefully when no input provided

xgupta updated this revision to Diff 514093. xgupta added a comment. address comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148439/new/ https://reviews.llvm.org/D148439 Files: clang/tools/clang-rename/ClangRename.cpp Index:

[PATCH] D148474: [Clang] Fix ResolveConstructorOverload to not select a conversion function if we are going use copy elision

shafik added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:746 + diag::note_template_class_instantiation_here) +<< CTD << Active->InstantiationRange; } else { rsmith wrote: > This diagnostic won't

[PATCH] D148474: [Clang] Fix ResolveConstructorOverload to not select a conversion function if we are going use copy elision

shafik updated this revision to Diff 514091. shafik marked 3 inline comments as done. shafik added a comment. - Fix up A3 test to be less malformed - Fix other test so we confirm we are attempting to call the right contructor CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148474/new/

[PATCH] D148489: [clangd] Implement configs to stop clangd produce a certain semantic tokens

daiyousei-qz added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:1281 } +std::optional +highlightingKindFromString(llvm::StringRef Name) { I'm not sure if we should parse the enums here or in parsing configs using `EnumSwitch`.

[PATCH] D148489: [clangd] Implement configs to stop clangd produce a certain semantic tokens

daiyousei-qz updated this revision to Diff 514088. daiyousei-qz added a comment. Fix an issue where the previous change is lost. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148489/new/ https://reviews.llvm.org/D148489 Files:

[PATCH] D148489: [clangd] Implement configs to stop clangd produce a certain semantic tokens

daiyousei-qz updated this revision to Diff 514087. daiyousei-qz added a comment. Add a test in SemanticHighlightingTests.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148489/new/ https://reviews.llvm.org/D148489 Files:

[PATCH] D148489: [clangd] Implement configs to stop clangd produce a certain semantic tokens

daiyousei-qz updated this revision to Diff 514086. daiyousei-qz added a comment. Fix unittest Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148489/new/ https://reviews.llvm.org/D148489 Files: clang-tools-extra/clangd/Config.h

[PATCH] D148490: [AIX] use system assembler for assembly files

shchenz created this revision. shchenz added reviewers: hubert.reinterpretcast, nemanjai, PowerPC. shchenz added a project: LLVM. Herald added a project: All. shchenz requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Change to system

[PATCH] D148489: [clangd] Implement configs to stop clangd produce a certain semantic tokens

daiyousei-qz added a comment. Please hold off from reviewing this. I have been figuring out how arc tools work and the unittest of the current version is broken. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148489/new/

[PATCH] D148489: Implement configs to stop clangd produce a certain semantic tokens

daiyousei-qz created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. daiyousei-qz requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Github

[PATCH] D148021: [Headers][doc] Add FMA intrinsic descriptions

pengfei accepted this revision. pengfei added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Headers/fmaintrin.h:22 +/// Computes a multiply-add of 128-bit vectors of [4 x float]. +///For each element, computes (__A * __B) + __C .

[PATCH] D148472: [clang-format] CSharp don't allow there not to be a space between `is` and `[`

owenpan accepted this revision. owenpan added inline comments. Comment at: clang/unittests/Format/FormatTestCSharp.cpp:1182-1186 + verifyFormat("return a is [1, 2, 3]", Style); + verifyFormat("return a is [..]", Style); + Style.SpaceBeforeSquareBrackets = false; +

[PATCH] D148447: [clang-format] Fix regression with AlignTrailingComments set to true

owenpan added a comment. In D148447#4271942 , @MyDeveloperDay wrote: > If this was the functionality pre 16 then LGTM Yep. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148447/new/

[PATCH] D148447: [clang-format] Fix regression with AlignTrailingComments set to true

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2bcfff6708d2: [clang-format] Fix regression with AlignTrailingComments set to true (authored by owenpan). Repository: rG LLVM Github Monorepo

[clang] 2bcfff6 - [clang-format] Fix regression with AlignTrailingComments set to true

Author: Owen Pan Date: 2023-04-16T18:52:17-07:00 New Revision: 2bcfff6708d293abab87a4d5a1dff25950d55d91 URL: https://github.com/llvm/llvm-project/commit/2bcfff6708d293abab87a4d5a1dff25950d55d91 DIFF: https://github.com/llvm/llvm-project/commit/2bcfff6708d293abab87a4d5a1dff25950d55d91.diff

[PATCH] D148457: [clangd] Support macro evaluation on hover

zyounan created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. zyounan updated this revision to Diff 513979. zyounan added a comment. zyounan updated this revision to Diff 514019. zyounan updated this revision to Diff 514028. zyounan added reviewers:

[PATCH] D148439: [clang-rename] Exit gracefully when no input provided

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/tools/clang-rename/ClangRename.cpp:130 + } else { +errs() << "clang-rename: No input provided.\n"; +return 1; Probably

[PATCH] D148482: [clang-format][NFC] Output tokens on test assert

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb6301a018d58: [clang-format][NFC] Output tokens on test assert (authored by sstwcw). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] b6301a0 - [clang-format][NFC] Output tokens on test assert

Author: sstwcw Date: 2023-04-16T23:48:07Z New Revision: b6301a018d585723610c9718b0a4d1bd9e696b17 URL: https://github.com/llvm/llvm-project/commit/b6301a018d585723610c9718b0a4d1bd9e696b17 DIFF: https://github.com/llvm/llvm-project/commit/b6301a018d585723610c9718b0a4d1bd9e696b17.diff LOG:

[PATCH] D148484: [clang-format] Correctly format goto labels followed by blocks

sstwcw added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:714 // are in a control flow statements as well as several style flags. -if (Line.First->is(tok::kw_case) || +if (Line.First->is(tok::kw_case) || Line.Last->is(TT_GotoLabelColon)

[PATCH] D148484: [clang-format] Correctly format goto labels followed by blocks

sstwcw created this revision. sstwcw added reviewers: HazardyKnusperkeks, MyDeveloperDay, owenpan, rymiel. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. sstwcw requested review of this revision. There doesn't seem to be an issue on GitHub. But

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

lhames added a comment. > OTOH it's a challenge to review since the patch is really big. Is there no > way to break it up and test in isolation? Or strip away details that could be > added in iterations? I had a short look and some comments, but I won't find > the time in the coming weeks to

[PATCH] D148372: [clang] add diagnose when member function contains invalid default argument

rsmith added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:7385 if (!ConsumeAndStoreInitializer(*DefArgToks, CIK_DefaultArgument)) { DefArgToks.reset(); +Diag(ArgStartLoc, diag::err_expected) << "initializer"; I

[PATCH] D148474: [Clang] Fix ResolveConstructorOverload to not select a conversion function if we are going use copy elision

rsmith added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:746 + diag::note_template_class_instantiation_here) +<< CTD << Active->InstantiationRange; } else { This diagnostic won't include the

[PATCH] D148482: [clang-format][NFC] Output tokens on test assert

sstwcw created this revision. sstwcw added reviewers: HazardyKnusperkeks, MyDeveloperDay, owenpan, rymiel. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. sstwcw requested review of this revision. Repository: rG LLVM Github Monorepo

[clang] 0571ba8 - [clang-format] Handle Verilog assertions and loops

Author: sstwcw Date: 2023-04-16T21:55:50Z New Revision: 0571ba8d1b4dbe72e0856f9b84146cc6e152a4d0 URL: https://github.com/llvm/llvm-project/commit/0571ba8d1b4dbe72e0856f9b84146cc6e152a4d0 DIFF: https://github.com/llvm/llvm-project/commit/0571ba8d1b4dbe72e0856f9b84146cc6e152a4d0.diff LOG:

[PATCH] D147895: [clang-format] Handle Verilog assertions and loops

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0571ba8d1b4d: [clang-format] Handle Verilog assertions and loops (authored by sstwcw). Changed prior to commit:

[clang] 872536f - [clang] Modernize ModuleDeclSeq (NFC)

Author: Kazu Hirata Date: 2023-04-16T14:48:18-07:00 New Revision: 872536f09d8c96e5734e2bcabfa384d7dc9b56ab URL: https://github.com/llvm/llvm-project/commit/872536f09d8c96e5734e2bcabfa384d7dc9b56ab DIFF: https://github.com/llvm/llvm-project/commit/872536f09d8c96e5734e2bcabfa384d7dc9b56ab.diff

[clang] 564ddf9 - [clang] Modernize ReturnAdjustment and ThisAdjustment (NFC)

Author: Kazu Hirata Date: 2023-04-16T14:48:16-07:00 New Revision: 564ddf986c97323bf35284cb2b404d21f42d563b URL: https://github.com/llvm/llvm-project/commit/564ddf986c97323bf35284cb2b404d21f42d563b DIFF: https://github.com/llvm/llvm-project/commit/564ddf986c97323bf35284cb2b404d21f42d563b.diff

[PATCH] D148462: [clang-tidy] Ignore declarations in bugprone-exception-escape

PiotrZSL added a comment. @isuckatcs No it were not fine, check function were executed, ExceptionAnalyzer created only to bail out due to nullptr getBody for functions with only declaration. For functions with separate declaration and definition entire analysis is executed twice. simply because

[clang] 79e106f - [clang] Modernize OptRemark (NFC)

Author: Kazu Hirata Date: 2023-04-16T14:24:22-07:00 New Revision: 79e106f6e7627aaf9bda62c05c3e7ac12cf11327 URL: https://github.com/llvm/llvm-project/commit/79e106f6e7627aaf9bda62c05c3e7ac12cf11327 DIFF: https://github.com/llvm/llvm-project/commit/79e106f6e7627aaf9bda62c05c3e7ac12cf11327.diff

[PATCH] D148461: [clang-tidy] Support C++17/20 in bugprone-exception-escape

PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/ExceptionAnalyzer.cpp:160-162 +// FIXME: Two function pointers can differ in 'noexcept', but they still +// should be considered to be same, now this triggers false-positive because +//

[clang] 3993de1 - [clang] Modernize EvalStatus (NFC)

Author: Kazu Hirata Date: 2023-04-16T14:02:34-07:00 New Revision: 3993de129182c3e98a3ab009ed99ad00bc8eff6e URL: https://github.com/llvm/llvm-project/commit/3993de129182c3e98a3ab009ed99ad00bc8eff6e DIFF: https://github.com/llvm/llvm-project/commit/3993de129182c3e98a3ab009ed99ad00bc8eff6e.diff

[PATCH] D148481: [clang-repl] Enable debugging of JIT-ed code.

lhames accepted this revision. lhames added a comment. This revision is now accepted and ready to land. Looks good to me! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148481/new/ https://reviews.llvm.org/D148481 ___ cfe-commits mailing list

[PATCH] D148481: [clang-repl] Enable debugging of JIT-ed code.

v.g.vassilev created this revision. v.g.vassilev added reviewers: lhames, sgraenitz, junaire. Herald added a subscriber: pengfei. Herald added a project: All. v.g.vassilev requested review of this revision. This change follows llvm/llvm-project@21b5ebd and makes use of the jitlink

[clang] 25c55d2 - [clang] Modernize ASTConsumer (NFC)

Author: Kazu Hirata Date: 2023-04-16T13:46:11-07:00 New Revision: 25c55d2c18b44e115069aba970ae684fbc2227f8 URL: https://github.com/llvm/llvm-project/commit/25c55d2c18b44e115069aba970ae684fbc2227f8 DIFF: https://github.com/llvm/llvm-project/commit/25c55d2c18b44e115069aba970ae684fbc2227f8.diff

[clang] e0f5031 - [clang] Modernize Vec (NFC)

Author: Kazu Hirata Date: 2023-04-16T13:46:09-07:00 New Revision: e0f5031caec31480208a694f26ac4d22243d41ab URL: https://github.com/llvm/llvm-project/commit/e0f5031caec31480208a694f26ac4d22243d41ab DIFF: https://github.com/llvm/llvm-project/commit/e0f5031caec31480208a694f26ac4d22243d41ab.diff

[PATCH] D133289: [C2X] N3007 Type inference for object definitions

to268 updated this revision to Diff 514051. to268 added a comment. I have improved some diagnostics and i am now testing `nullptr` with `auto`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133289/new/ https://reviews.llvm.org/D133289 Files:

[PATCH] D148462: [clang-tidy] Ignore declarations in bugprone-exception-escape

isuckatcs added a comment. I think the original behaviour was fine. The warning was emitted at every occurence of the function. It might be confusing if it's only emitted for the definition. Also what happens in the following scenario: int indirectly_recursive(int n) noexcept; int

[PATCH] D148461: [clang-tidy] Support C++17/20 in bugprone-exception-escape

isuckatcs added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/ExceptionAnalyzer.cpp:160-162 +// FIXME: Two function pointers can differ in 'noexcept', but they still +// should be considered to be same, now this triggers false-positive because +//

[PATCH] D148473: [clang-format] C# short ternary operator misinterpreted as a CSharpNullable

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Format/TokenAnnotator.cpp:1338-1342 +if (!Contexts.back().IsExpression && Line.MustBeDeclaration && +

[PATCH] D148474: [Clang] Fix ResolveConstructorOverload to not select a conversion function if we are going use copy elision

shafik added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:743 << FD << Active->InstantiationRange; + } else if (ClassTemplateDecl *CTD = dyn_cast(D)) { +Diags.Report(Active->PointOfInstantiation, I added this

[PATCH] D148467: [clang-format] Add a new AfterCSharpProperty to BraceWrapping

HazardyKnusperkeks added a comment. In D148467#4272173 , @MyDeveloperDay wrote: > I'm not convinced `AfterCSharpProperty` is a good name, open for suggestions I've not enough domain knowledge to name it. Comment at:

[PATCH] D148474: [Clang] Fix ResolveConstructorOverload to not select a conversion function if we are going use copy elision

shafik created this revision. shafik added reviewers: rsmith, aaron.ballman, erichkeane, dim. Herald added a project: All. shafik requested review of this revision. `ResolveConstructorOverload` needs to check properly if we are going to use copy elision we can't use a conversion function. This

[PATCH] D148266: [clang][driver] Linking to just-built libc++.dylib when bootstrapping libc++ with clang

fahadnayyar updated this revision to Diff 514037. fahadnayyar added a comment. Herald added a subscriber: ormris. Added test case. Now checking the existence of libc++ headers in the toolchain when including the libc++.dylib form toolchain and vice versa. Also checking the absence of -nostdinc,

[PATCH] D148439: [clang-rename] Exit gracefully when no input provided

vmiklos added subscribers: arphaman, klimek. vmiklos added a comment. Looks good to me, but probably you want an approval from @arphaman, @klimek or @kbobyrev before committing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148439/new/

[PATCH] D148473: [clang-format] C# short ternary operator misinterpreted as a CSharpNullable

MyDeveloperDay added a comment. @exv any thoughts on this one? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148473/new/ https://reviews.llvm.org/D148473 ___ cfe-commits mailing list

[PATCH] D148473: [clang-format] C# short ternary operator misinterpreted as a CSharpNullable

MyDeveloperDay added a comment. The exclusions are not complete for example `cond? foo() : "B";` would still fail. but this moves us a little closer Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148473/new/ https://reviews.llvm.org/D148473

[PATCH] D148473: [clang-format] C# short ternary operator misinterpreted as a CSharpNullable

MyDeveloperDay created this revision. MyDeveloperDay added a reviewer: owenpan. MyDeveloperDay added a project: clang-format. Herald added projects: All, clang. Herald added reviewers: rymiel, HazardyKnusperkeks. MyDeveloperDay requested review of this revision. Refactor the CSharpNullable

[PATCH] D148472: [clang-format] CSharp don't allow there not to be a space between `is` and `[`

MyDeveloperDay created this revision. MyDeveloperDay added a reviewer: owenpan. MyDeveloperDay added a project: clang-format. Herald added projects: All, clang. Herald added reviewers: rymiel, HazardyKnusperkeks. MyDeveloperDay requested review of this revision. as `is` is a keyword in C# ensure

[PATCH] D148467: [clang-format] Add a new AfterCSharpProperty to BraceWrapping

MyDeveloperDay updated this revision to Diff 514030. MyDeveloperDay added a comment. re clang-format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148467/new/ https://reviews.llvm.org/D148467 Files: clang/docs/ClangFormatStyleOptions.rst clang/docs/ReleaseNotes.rst

[PATCH] D148467: [clang-format] Add a new AfterCSharpProperty to BraceWrapping

MyDeveloperDay updated this revision to Diff 514029. MyDeveloperDay added a comment. for default `set;get` or `get;set` for when `AfterCSharpProperty` is true, public Foo { set; get; } CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148467/new/

[PATCH] D148444: [clang-tidy] Prevent `llvmlibc-inline-function-decl` triggering on lambdas

This revision was automatically updated to reflect the committed changes. Closed by commit rG1663016b41d7: [clang-tidy] Prevent `llvmlibc-inline-function-decl` triggering on lambdas (authored by jhuber6). Changed prior to commit: https://reviews.llvm.org/D148444?vs=514001=514026#toc

[clang-tools-extra] 1663016 - [clang-tidy] Prevent `llvmlibc-inline-function-decl` triggering on lambdas

Author: Joseph Huber Date: 2023-04-16T10:58:44-05:00 New Revision: 1663016b41d71a60f3d268607c6fbf16fcf85172 URL: https://github.com/llvm/llvm-project/commit/1663016b41d71a60f3d268607c6fbf16fcf85172 DIFF: https://github.com/llvm/llvm-project/commit/1663016b41d71a60f3d268607c6fbf16fcf85172.diff

[clang] 077a2a4 - [CMake] Cleanup deps

Author: NAKAMURA Takumi Date: 2023-04-17T00:38:49+09:00 New Revision: 077a2a4bcddf62fd002f80f150ef0e5c785ba89b URL: https://github.com/llvm/llvm-project/commit/077a2a4bcddf62fd002f80f150ef0e5c785ba89b DIFF:

[clang] 7d5d987 - [CMake] Reorder and reformat deps

Author: NAKAMURA Takumi Date: 2023-04-17T00:32:16+09:00 New Revision: 7d5d987e93bb4650d1dade41f0d5c5025ccb5b5c URL: https://github.com/llvm/llvm-project/commit/7d5d987e93bb4650d1dade41f0d5c5025ccb5b5c DIFF:

[clang-tools-extra] 7d5d987 - [CMake] Reorder and reformat deps

Author: NAKAMURA Takumi Date: 2023-04-17T00:32:16+09:00 New Revision: 7d5d987e93bb4650d1dade41f0d5c5025ccb5b5c URL: https://github.com/llvm/llvm-project/commit/7d5d987e93bb4650d1dade41f0d5c5025ccb5b5c DIFF:

[PATCH] D148467: [clang-format] Add a new AfterCSharpProperty to BraceWrapping

MyDeveloperDay added a comment. I'm not convinced `AfterCSharpProperty` is a good name, open for suggestions CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148467/new/ https://reviews.llvm.org/D148467 ___ cfe-commits mailing list

[PATCH] D148467: [clang-format] Add a new AfterCSharpProperty to BraceWrapping

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTestCSharp.cpp:1633 + "{\n" + "string Foo { set; get }\n" + "}\n", Hmm.. maybe this should be ``` string Foo { set;get } ```

[PATCH] D148467: [clang-format] Add a new AfterCSharpProperty to BraceWrapping

MyDeveloperDay updated this revision to Diff 514017. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148467/new/ https://reviews.llvm.org/D148467 Files: clang/docs/ClangFormatStyleOptions.rst clang/docs/ReleaseNotes.rst clang/include/clang/Format/Format.h

[PATCH] D148467: [clang-format] Add a new AfterCSharpProperty to BraceWrapping

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: owenpan, HazardyKnusperkeks, rymiel. MyDeveloperDay added a project: clang-format. Herald added projects: All, clang. MyDeveloperDay requested review of this revision. This change allows always breaking before braces on C#

[PATCH] D148460: [clang-tidy] Add alias cppcoreguidelines-use-default-member-init

Eugene.Zelenko accepted this revision. Eugene.Zelenko added a comment. Please create issue for deprecation after commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148460/new/ https://reviews.llvm.org/D148460

[PATCH] D147175: [clang] Add __is_trivially_equality_comparable

philnik added a comment. ping @aaron.ballman Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147175/new/ https://reviews.llvm.org/D147175 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D148460: [clang-tidy] Add alias cppcoreguidelines-use-default-member-init

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148460/new/ https://reviews.llvm.org/D148460

[PATCH] D148444: [clang-tidy] Prevent `llvmlibc-inline-function-decl` triggering on lambdas

jhuber6 updated this revision to Diff 514001. jhuber6 added a comment. Rebasing on main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148444/new/ https://reviews.llvm.org/D148444 Files:

[PATCH] D144748: [clang-tidy] Add bugprone-empty-catch check

PiotrZSL updated this revision to Diff 514000. PiotrZSL added a comment. Add getCheckTraversalKind, format tests, fix some review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144748/new/ https://reviews.llvm.org/D144748 Files:

[PATCH] D144748: [clang-tidy] Add bugprone-empty-catch check

PiotrZSL marked 4 inline comments as done. PiotrZSL added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone/empty-catch.rst:147-153 +.. option:: IgnoreCatchWithKeywords + +This option can be used to ignore specific catch statements containing +

[PATCH] D148444: [clang-tidy] Prevent `llvmlibc-inline-function-decl` triggering on lambdas

PiotrZSL added a comment. Rebase code, this will fix a build. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148444/new/ https://reviews.llvm.org/D148444 ___ cfe-commits mailing list

[PATCH] D148444: [clang-tidy] Prevent `llvmlibc-inline-function-decl` triggering on lambdas

PiotrZSL added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/llvmlibc/inline-function-decl.hpp:66 +// CHECK-MESSAGES-NOT: :[[@LINE+3]]:3: warning: 'operator void (*)()' must be tagged with the LIBC_INLINE macro; the macro should be placed at the

[PATCH] D148444: [clang-tidy] Prevent `llvmlibc-inline-function-decl` triggering on lambdas

jhuber6 added a comment. In D148444#4272036 , @PiotrZSL wrote: > Fix Linux build before committing & resolve all comments. The log says that it failed because of the CMake version. I don't think I can fix that. Comment at:

[PATCH] D144748: [clang-tidy] Add bugprone-empty-catch check

PiotrZSL marked an inline comment as done. PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/EmptyCatchCheck.cpp:100 +void EmptyCatchCheck::check(const MatchFinder::MatchResult ) { + const auto *MatchedCatchStmt = Result.Nodes.getNodeAs("catch");

[PATCH] D144748: [clang-tidy] Add bugprone-empty-catch check

PiotrZSL marked an inline comment as done. PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/EmptyCatchCheck.cpp:100 +void EmptyCatchCheck::check(const MatchFinder::MatchResult ) { + const auto *MatchedCatchStmt = Result.Nodes.getNodeAs("catch");

[PATCH] D148444: [clang-tidy] Prevent `llvmlibc-inline-function-decl` triggering on lambdas

PiotrZSL added a comment. Fix Linux build before committing & resolve all comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148444/new/ https://reviews.llvm.org/D148444 ___ cfe-commits mailing

[PATCH] D148444: [clang-tidy] Prevent `llvmlibc-inline-function-decl` triggering on lambdas

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. From functional point of view it's looking good. Comment at: clang-tools-extra/clang-tidy/llvmlibc/InlineFunctionDeclCheck.cpp:42 + // Consider only functions with an

[PATCH] D144748: [clang-tidy] Add bugprone-empty-catch check

carlosgalvezp added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone/empty-catch.rst:103 +{ +try +{ Use 2 spaces indentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D144748: [clang-tidy] Add bugprone-empty-catch check

carlosgalvezp added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/EmptyCatchCheck.cpp:100 +void EmptyCatchCheck::check(const MatchFinder::MatchResult ) { + const auto *MatchedCatchStmt = Result.Nodes.getNodeAs("catch"); + Assert that it's

[PATCH] D148444: [clang-tidy] Prevent `llvmlibc-inline-function-decl` triggering on lambdas

jhuber6 added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/llvmlibc/inline-function-decl.hpp:64-67 +// CHECK-MESSAGES-NOT: :[[@LINE+4]]:3: warning: '__invoke' must be tagged with the LIBC_INLINE macro; the macro should be placed at the beginning of

[PATCH] D148444: [clang-tidy] Prevent `llvmlibc-inline-function-decl` triggering on lambdas

jhuber6 updated this revision to Diff 513997. jhuber6 added a comment. Address nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148444/new/ https://reviews.llvm.org/D148444 Files:

[PATCH] D148444: [clang-tidy] Prevent `llvmlibc-inline-function-decl` triggering on lambdas

carlosgalvezp added inline comments. Comment at: clang-tools-extra/clang-tidy/llvmlibc/InlineFunctionDeclCheck.cpp:43 + // Consider only functions with an external and visible declaration. + if (const auto *MethodDecl = dyn_cast(FuncDecl)) +if

[PATCH] D148458: [clang-tidy][NFC] Split bugprone-exception-escape tests

PiotrZSL added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone/exception-escape.cpp:267 const derived *p = -throw p; } catch(base *) { carlosgalvezp wrote: > I run into this often as well. If you don't want to get

[PATCH] D148458: [clang-tidy][NFC] Split bugprone-exception-escape tests

carlosgalvezp added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone/exception-escape.cpp:267 const derived *p = -throw p; } catch(base *) { I run into this often as well. If you don't want to get push back during

[PATCH] D148460: [clang-tidy] Add alias cppcoreguidelines-use-default-member-init

carlosgalvezp updated this revision to Diff 513996. carlosgalvezp added a comment. Remove check from list of checks, since we do not add aliases there. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148460/new/ https://reviews.llvm.org/D148460

[PATCH] D148460: [clang-tidy] Add alias cppcoreguidelines-use-default-member-init

carlosgalvezp updated this revision to Diff 513995. carlosgalvezp added a comment. Add check to list of aliases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148460/new/ https://reviews.llvm.org/D148460 Files:

[PATCH] D148460: [clang-tidy] Add alias cppcoreguidelines-use-default-member-init

carlosgalvezp updated this revision to Diff 513994. carlosgalvezp added a comment. Rebase and fix conflicts. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148460/new/ https://reviews.llvm.org/D148460 Files:

[PATCH] D148460: [clang-tidy] Add alias cppcoreguidelines-use-default-member-init

carlosgalvezp updated this revision to Diff 513992. carlosgalvezp added a comment. Revert code removal, document deprecation notice instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148460/new/ https://reviews.llvm.org/D148460 Files:

[PATCH] D148444: [clang-tidy] Prevent `llvmlibc-inline-function-decl` triggering on lambdas

jhuber6 updated this revision to Diff 513990. jhuber6 added a comment. Add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148444/new/ https://reviews.llvm.org/D148444 Files: clang-tools-extra/clang-tidy/llvmlibc/InlineFunctionDeclCheck.cpp

[PATCH] D148410: [Parse] Remove TimeTraceScope for "ParseTemplate"

anton-afanasyev accepted this revision. anton-afanasyev added a comment. This revision is now accepted and ready to land. Ok, let's remove it for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148410/new/ https://reviews.llvm.org/D148410

[PATCH] D148462: [clang-tidy] Ignore declarations in bugprone-exception-escape

PiotrZSL created this revision. PiotrZSL added reviewers: njames93, carlosgalvezp. Herald added a subscriber: xazax.hun. Herald added a project: All. PiotrZSL requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Warnings will now

  1   2   >