[PATCH] D148124: [RISCV][Driver] Allow the use of CPUs with a different XLEN than the triple.

asb accepted this revision. asb added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148124/new/ https://reviews.llvm.org/D148124 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D148006: [clang][dataflow] Associate `FunctionToPointerDecay` nodes with a value.

mboehme updated this revision to Diff 514520. mboehme added a comment. Rebased to head Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148006/new/ https://reviews.llvm.org/D148006 Files:

[PATCH] D147935: [RISCV] Add SiFive extension support

asb accepted this revision. asb added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147935/new/ https://reviews.llvm.org/D147935 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D147698: [clang][dataflow] Add support for new expressions.

This revision was automatically updated to reflect the committed changes. mboehme marked 3 inline comments as done. Closed by commit rG6ab900f8746e: [clang][dataflow] Add support for new expressions. (authored by mboehme). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 6ab900f - [clang][dataflow] Add support for new expressions.

Author: Martin Braenne Date: 2023-04-18T04:11:43Z New Revision: 6ab900f8746e7d8e24afafb5886a40801f6799f4 URL: https://github.com/llvm/llvm-project/commit/6ab900f8746e7d8e24afafb5886a40801f6799f4 DIFF: https://github.com/llvm/llvm-project/commit/6ab900f8746e7d8e24afafb5886a40801f6799f4.diff

[PATCH] D141389: [DFSAN] Add support for strnlen, strncat, strsep, sscanf and _tolower

tkuchta added a comment. Got it, thank you. Please submit the patch for e-mail t.kuc...@samsung.com I will prepare next reviews for the other functions. Thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141389/new/ https://reviews.llvm.org/D141389

[PATCH] D147708: [NFC][clang] Fix static analyzer tool remarks about large copies by values

Manna added a comment. Thanks @erichkeane for the suggestion. I will follow it in future commits. In D147708#4255361 , @erichkeane wrote: > Note, in the future, if in your commit message you do: > > `Differential Revision: ` > > the review will

[PATCH] D148189: [NFC][Clang] Fix static analyzer tool remark about missing user-defined assignment operator

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7e1b62bd9ca8: [NFC][Clang] Fix static analyzer tool remark about missing user-defined… (authored by Manna). Repository: rG LLVM Github Monorepo

[clang] 7e1b62b - [NFC][Clang] Fix static analyzer tool remark about missing user-defined assignment operator

Author: Manna, Soumi Date: 2023-04-17T22:21:30-04:00 New Revision: 7e1b62bd9ca8ab3c3307e19abecdd482210f URL: https://github.com/llvm/llvm-project/commit/7e1b62bd9ca8ab3c3307e19abecdd482210f DIFF: https://github.com/llvm/llvm-project/commit/7e1b62bd9ca8ab3c3307e19abecdd482210f.diff

[PATCH] D148515: [Modules] Do not rewrite existing decls when deserializing class fields

ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. Thank you very much! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148515/new/ https://reviews.llvm.org/D148515

[PATCH] D148496: [compiler-rt] [test] Mark dfsan tests XFAIL on glibc-2.37

This revision was automatically updated to reflect the committed changes. Closed by commit rG488a4b24817a: [compiler-rt] [test] Mark dfsan tests XFAIL on glibc-2.37 (authored by mgorny). Herald added a project: Sanitizers. Herald added a subscriber: Sanitizers. Repository: rG LLVM Github

[clang] 18a3d9e - [NFC][clang] Fix coverity static analyzer concerns about AUTO_CAUSES_COPY

Author: Manna, Soumi Date: 2023-04-17T21:33:21-04:00 New Revision: 18a3d9e5b318133611ebc88bbe82ca9a2ca56f1d URL: https://github.com/llvm/llvm-project/commit/18a3d9e5b318133611ebc88bbe82ca9a2ca56f1d DIFF: https://github.com/llvm/llvm-project/commit/18a3d9e5b318133611ebc88bbe82ca9a2ca56f1d.diff

[PATCH] D148496: [compiler-rt] [test] Mark dfsan tests XFAIL on glibc-2.37

mgorny added a comment. In D148496#4274352 , @browneee wrote: > Issue appears to be with the program rather than the instrumentation. Did the > behavior of the the libc functions used in the test change? If the question was directed at me, then I'm

[PATCH] D148596: [KMSAN] Enable on SystemZ

iii created this revision. iii added reviewers: eugenis, vitalybuka, glider, uweigand, jonpa. Herald added subscribers: Enna1, pengfei, hiraditya. Herald added a project: All. iii requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, MaskRay. Herald added

[PATCH] D141714: Fix ast print of variables with attributes

giulianobelinassi updated this revision to Diff 514473. giulianobelinassi added a comment. Herald added a reviewer: jdoerfert. Herald added subscribers: jplehr, sstefan1. Update patch with the agreements of last discussion. This new version includes code to handle the cases presented by Aron,

[PATCH] D145088: [RISCV] Add attribute(riscv_rvv_vector_bits(N)) based on AArch64 arm_sve_vector_bits.

rjmccall added a comment. The CodeGen change looks fine. I'm surprised you didn't need any code in argument/parameter/call/return emission to do the actual fixed<->scalable coercion; do we already have that for other reasons? Comment at:

[PATCH] D148381: [WIP][Clang] Add element_count attribute

void updated this revision to Diff 514451. void added a comment. Herald added a subscriber: jdoerfert. Fix failing testcase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148381/new/ https://reviews.llvm.org/D148381 Files:

[PATCH] D148372: [clang] add diagnose when member function contains invalid default argument

HerrCai0907 marked an inline comment as done. HerrCai0907 added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:7385 if (!ConsumeAndStoreInitializer(*DefArgToks, CIK_DefaultArgument)) { DefArgToks.reset(); +Diag(ArgStartLoc,

[PATCH] D148372: [clang] add diagnose when member function contains invalid default argument

HerrCai0907 updated this revision to Diff 514447. HerrCai0907 added a comment. better fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148372/new/ https://reviews.llvm.org/D148372 Files: clang/docs/ReleaseNotes.rst

[PATCH] D148577: [CMake] Switch back to -fPIC for Fuchsia Toolchain

mysterymath created this revision. mysterymath added reviewers: abrachet, phosek. Herald added a subscriber: ekilmer. Herald added a project: All. mysterymath requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This reverts commit

[PATCH] D148467: [clang-format] Add a new AfterCSharpProperty to BraceWrapping

owenpan added inline comments. Comment at: clang/include/clang/Format/Format.h:1220 +/// \endcode +bool AfterCSharpProperty; }; MyDeveloperDay wrote: > HazardyKnusperkeks wrote: > > MyDeveloperDay wrote: > > > HazardyKnusperkeks wrote: > > > > Please

[PATCH] D148473: [clang-format] C# short ternary operator misinterpreted as a CSharpNullable

owenpan accepted this revision. owenpan added inline comments. Comment at: clang/unittests/Format/TokenAnnotatorTest.cpp:1730 + + auto Tokens = annotate("int? a;\n", Style); + EXPECT_EQ(Tokens.size(), 5u) << Tokens; Nit: no trailing newlines here and below.

[PATCH] D146777: [clang] Preliminary fat-lto-object support

paulkirth updated this revision to Diff 514432. paulkirth added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146777/new/ https://reviews.llvm.org/D146777 Files: clang/include/clang/Basic/CodeGenOptions.def

[PATCH] D146777: [clang] Preliminary fat-lto-object support

paulkirth updated this revision to Diff 514430. paulkirth added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146777/new/ https://reviews.llvm.org/D146777 Files: clang/include/clang/Basic/CodeGenOptions.def

[PATCH] D148574: Use the 'std::unique_ptr' instead of a raw pointers

Stoorx updated this revision to Diff 514429. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148574/new/ https://reviews.llvm.org/D148574 Files: clang/lib/Basic/Targets.cpp clang/lib/Basic/Targets.h clang/lib/Basic/Targets/NVPTX.cpp

[PATCH] D148574: Use the 'std::unique_ptr' instead of a raw pointers

Stoorx created this revision. Stoorx added a reviewer: DavidSpickett. Herald added subscribers: mattd, gchakrabarti, asavonic, abrachet, phosek, s.egerton, mstorsjo, simoncook, asb, fedor.sergeev, dschuff. Herald added a project: All. Stoorx requested review of this revision. Herald added

[PATCH] D148274: [clang] Fix overly aggressive lifetime checks for parenthesized aggregate initialization

ayzhao updated this revision to Diff 514425. ayzhao marked 3 inline comments as done. ayzhao added a comment. code review comments + rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148274/new/ https://reviews.llvm.org/D148274 Files:

[PATCH] D148385: [RISCV] Implement KCFI operand bundle lowering for RV64

craig.topper added inline comments. Comment at: llvm/utils/gn/secondary/llvm/lib/Target/RISCV/BUILD.gn:81 "RISCVInstrInfo.cpp", +"RISCVKCFI.cpp", "RISCVMCInstLower.cpp", Isn't this done automatically by the GN Syncbot when CMakeLists.txt is

[PATCH] D148385: [RISCV] Implement KCFI operand bundle lowering for RV64

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVAsmPrinter.cpp:310 +EmitToStreamer(*OutStreamer, MCInstBuilder(RISCV::ADDI) + .addReg(ScratchRegs[0]) + .addReg(RISCV::X0)

[PATCH] D148385: [RISCV] Implement KCFI operand bundle lowering for RV64

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVAsmPrinter.cpp:310 +EmitToStreamer(*OutStreamer, MCInstBuilder(RISCV::ADDI) + .addReg(ScratchRegs[0]) + .addReg(RISCV::X0)

[PATCH] D148573: Port -fsanitize=function to AArch64

MaskRay created this revision. MaskRay added reviewers: dmgreen, lenary, pcc, peter.smith. Herald added subscribers: Enna1, hiraditya, kristof.beyls, emaste. Herald added a project: All. MaskRay requested review of this revision. Herald added projects: clang, Sanitizers, LLVM. Herald added

[PATCH] D148381: [WIP][Clang] Add element_count attribute

void added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:951-952 +if (auto *ME = dyn_cast(CE->getSubExpr())) { + if (ME->isFlexibleArrayMemberLike(CGF.getContext(), +StrictFlexArraysLevel, true)) { +if (auto

[PATCH] D148556: [libcxxabi][demangle] create helper for std::string_view::starts_with

nickdesaulniers updated this revision to Diff 514410. nickdesaulniers added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. - add new file to clang/docs/tools/clang-formatted-files.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D148387: remove Demangle/StringView.h

nickdesaulniers updated this revision to Diff 514405. nickdesaulniers retitled this revision from "[RFC] remove Demangle/StringView.h" to "remove Demangle/StringView.h". nickdesaulniers edited the summary of this revision. nickdesaulniers added a comment. Herald added a project: clang. Herald

[PATCH] D148385: [RISCV] Implement KCFI operand bundle lowering for RV64

jrtc27 added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVAsmPrinter.cpp:277 +void RISCVAsmPrinter::LowerKCFI_CHECK(const MachineInstr ) { + assert(STI->is64Bit() && "KCFI_CHECK requires RV64"); + What about this code relies on it being 64-bit?

[PATCH] D148381: [WIP][Clang] Add element_count attribute

nickdesaulniers added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:951-952 +if (auto *ME = dyn_cast(CE->getSubExpr())) { + if (ME->isFlexibleArrayMemberLike(CGF.getContext(), +StrictFlexArraysLevel, true)) { +

[PATCH] D141307: Add -f[no-]loop-versioning option

Leporacanthicus updated this revision to Diff 514403. Leporacanthicus added a comment. Rebase only Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141307/new/ https://reviews.llvm.org/D141307 Files: clang/include/clang/Driver/Options.td

[PATCH] D148385: [RISCV] Implement KCFI operand bundle lowering for RV64

jrtc27 added a comment. I can't help but feel the core of this should be target-independent, with TLI or similar hooks to actually do the target-specific bits? Comment at: llvm/test/CodeGen/RISCV/kcfi.ll:1 +; RUN: llc -mtriple=riscv64 -verify-machineinstrs -riscv-no-aliases <

[PATCH] D148385: [RISCV] Implement KCFI operand bundle lowering for RV64

nickdesaulniers added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVAsmPrinter.cpp:299-300 + ++NextReg; +Reg = NextReg++; +if (Reg > RISCV::X31) + report_fatal_error("Unable to find scratch registers for KCFI_CHECK"); if (++NextReg >

[PATCH] D148381: [WIP][Clang] Add element_count attribute

void added a comment. In D148381#4274857 , @nickdesaulniers wrote: > Cool! > > How about some codegen tests? I'll add those to the next iteration. :-) > This looks a lot like the EuroLLVM keynote: > https://llvm.swoogo.com/2023eurollvm/agenda

[PATCH] D148385: [RISCV] Implement KCFI operand bundle lowering for RV64

nickdesaulniers added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVKCFI.cpp:106-107 + for (MachineBasicBlock : MF) { +for (MachineBasicBlock::instr_iterator MII = MBB.instr_begin(), + MIE = MBB.instr_end(); + MII

[PATCH] D148266: [clang][driver] Linking to just-built libc++.dylib when bootstrapping libc++ with clang

fahadnayyar updated this revision to Diff 514397. fahadnayyar added a comment. Herald added a subscriber: carlosgalvezp. Herald added a project: clang-tools-extra. Fixed regression error in clang-tidy test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D148274: [clang] Fix overly aggressive lifetime checks for parenthesized aggregate initialization

shafik added a comment. I am mostly done but others should also look at this. Comment at: clang/lib/Sema/SemaInit.cpp:5348 + }; + ExprResult ER = CreateExprResult(); + if (InitExpr) Why not just use a conditional expression here or alternatively

[PATCH] D147743: [Clang][NFC] Rename methods/vars to reflect their real usage

void updated this revision to Diff 514395. void added a comment. Reformat. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147743/new/ https://reviews.llvm.org/D147743 Files: clang-tools-extra/clangd/FindTarget.cpp

[PATCH] D147743: [Clang][NFC] Rename methods/vars to reflect their real usage

void added a comment. Friendly ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147743/new/ https://reviews.llvm.org/D147743 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D148274: [clang] Fix overly aggressive lifetime checks for parenthesized aggregate initialization

ayzhao updated this revision to Diff 514389. ayzhao marked an inline comment as done. ayzhao added a comment. remove unrelated formatting changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148274/new/ https://reviews.llvm.org/D148274 Files:

[PATCH] D147717: [C++20][NFC] Claim full support for consteval again

cjdb added a comment. I'm gonna get started on this today! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147717/new/ https://reviews.llvm.org/D147717 ___ cfe-commits mailing list

[PATCH] D148505: Allow `__attribute__((warn_unused))` on individual constructors

erichkeane added inline comments. Comment at: clang/include/clang/Basic/Attr.td:2996 let Spellings = [GCC<"warn_unused">]; - let Subjects = SubjectList<[Record]>; + let Subjects = SubjectList<[Record, CXXConstructor]>; let Documentation = [Undocumented];

[PATCH] D148505: Allow `__attribute__((warn_unused))` on individual constructors

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:2996 let Spellings = [GCC<"warn_unused">]; - let Subjects = SubjectList<[Record]>; + let Subjects = SubjectList<[Record, CXXConstructor]>; let Documentation = [Undocumented];

[PATCH] D148318: [clang-tidy] Add `performance-avoid-endl` check

AMS21 updated this revision to Diff 514367. AMS21 added a comment. Fix docs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148318/new/ https://reviews.llvm.org/D148318 Files: clang-tools-extra/clang-tidy/performance/AvoidEndlCheck.cpp

[PATCH] D148318: [clang-tidy] Add `performance-avoid-endl` check

AMS21 updated this revision to Diff 514366. AMS21 added a comment. Handle the function calling case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148318/new/ https://reviews.llvm.org/D148318 Files:

[PATCH] D148433: [clang] Add tests for DRs about complete-class context

Endill updated this revision to Diff 514353. Endill added a comment. Weaken the FIXME wording per Shafik's suggestion Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148433/new/ https://reviews.llvm.org/D148433 Files:

[PATCH] D148554: [dataflow] Extract arena for Value/StorageLocation out of DataflowAnalysisContext

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Analysis/FlowSensitive/Arena.h:15-16 + +// The Arena owns the objects that model data within an analysis. +// Currently this is

[PATCH] D148274: [clang] Fix overly aggressive lifetime checks for parenthesized aggregate initialization

shafik added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:9723 +// initialize this base/member. +CXXConstructorDecl *Constructor = +cast(S.CurContext); This and the changes below looks like unrelated formatting changes.

[PATCH] D148433: [clang] Add tests for DRs about complete-class context

shafik added inline comments. Comment at: clang/test/CXX/drs/dr23xx.cpp:42 +namespace dr2335 { // dr2335: no drafting +// FIXME: all of the examples are well-formed. Endill wrote: > aaron.ballman wrote: > > Endill wrote: > > > shafik wrote: > > > > My comment

[PATCH] D148473: [clang-format] C# short ternary operator misinterpreted as a CSharpNullable

MyDeveloperDay updated this revision to Diff 514343. MyDeveloperDay added a comment. simplify negative if CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148473/new/ https://reviews.llvm.org/D148473 Files: clang/lib/Format/TokenAnnotator.cpp

[PATCH] D148472: [clang-format] CSharp don't allow there not to be a space between `is` and `[`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. MyDeveloperDay marked an inline comment as done. Closed by commit rG63395cb0b69d: [clang-format] CSharp dont allow there not to be a space between `is` and `[`

[clang] 63395cb - [clang-format] CSharp don't allow there not to be a space between `is` and `[`

Author: mydeveloperday Date: 2023-04-17T19:38:53+01:00 New Revision: 63395cb0b69dee69ec5d5d0d552482c607861178 URL: https://github.com/llvm/llvm-project/commit/63395cb0b69dee69ec5d5d0d552482c607861178 DIFF:

[PATCH] D148554: [dataflow] Extract arena for Value/StorageLocation out of DataflowAnalysisContext

sammccall created this revision. sammccall added reviewers: ymandel, gribozavr2, xazax.hun. Herald added subscribers: martong, rnkovacs. Herald added a reviewer: NoQ. Herald added a project: All. sammccall requested review of this revision. Herald added a project: clang. Herald added a subscriber:

[PATCH] D148369: [DependencyScanning] Canonicalize `CodeGenOptions.RelaxAll`

akyrtzi added inline comments. Comment at: clang/tools/clang-scan-deps/ClangScanDeps.cpp:905 + if (BriefResult) { +llvm::outs() << "num modules: " << FD->getNumModules() << '\n'; +return HadErrors; jansvoboda11 wrote: > akyrtzi wrote: > > jansvoboda11

[PATCH] D148552: [include-cleaner] Unify behaviour for static & instance members

kadircet created this revision. kadircet added a reviewer: hokein. Herald added a project: All. kadircet requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Fixes https://github.com/llvm/llvm-project/issues/62185 Repository: rG

[PATCH] D146777: [clang] Preliminary fat-lto-object support

paulkirth updated this revision to Diff 514331. paulkirth added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146777/new/ https://reviews.llvm.org/D146777 Files: clang/include/clang/Basic/CodeGenOptions.def

[PATCH] D148381: [WIP][Clang] Add element_count attribute

nickdesaulniers added a comment. Cool! How about some codegen tests? This looks a lot like the EuroLLVM keynote: https://llvm.swoogo.com/2023eurollvm/agenda (Thursday `-fbounds-safety`). What's your plan for reconciling this with the authors of that? Have you reached out to them with this

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

alexander-shaposhnikov added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:263 + if (SubstitutedAtomicExpr.get()->isValueDependent()) +return SubstitutedAtomicExpr; alexander-shaposhnikov wrote: > erichkeane wrote: > > alexander-shaposhnikov

[PATCH] D148369: [DependencyScanning] Canonicalize `CodeGenOptions.RelaxAll`

jansvoboda11 added inline comments. Comment at: clang/tools/clang-scan-deps/ClangScanDeps.cpp:905 + if (BriefResult) { +llvm::outs() << "num modules: " << FD->getNumModules() << '\n'; +return HadErrors; akyrtzi wrote: > jansvoboda11 wrote: > > This

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

alexander-shaposhnikov added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:263 + if (SubstitutedAtomicExpr.get()->isValueDependent()) +return SubstitutedAtomicExpr; erichkeane wrote: > alexander-shaposhnikov wrote: > > erichkeane wrote: > >

[PATCH] D148377: [clang][dataflow] Drop optional model's dependency on libc++ internals.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG09b462ef8539: [clang][dataflow] Drop optional models dependency on libc++ internals. (authored by ymandel). Repository: rG LLVM Github Monorepo

[clang] 09b462e - [clang][dataflow] Drop optional model's dependency on libc++ internals.

Author: Yitzhak Mandelbaum Date: 2023-04-17T18:03:58Z New Revision: 09b462ef8539433f56d1a6d2cc807db9a56072e6 URL: https://github.com/llvm/llvm-project/commit/09b462ef8539433f56d1a6d2cc807db9a56072e6 DIFF: https://github.com/llvm/llvm-project/commit/09b462ef8539433f56d1a6d2cc807db9a56072e6.diff

[PATCH] D148344: [clang][dataflow] Refine matching of optional types to anchor at top level.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcd22e0dc9d0b: [clang][dataflow] Refine matching of optional types to anchor at top level. (authored by ymandel). Repository: rG LLVM Github

[clang] cd22e0d - [clang][dataflow] Refine matching of optional types to anchor at top level.

Author: Yitzhak Mandelbaum Date: 2023-04-17T18:02:51Z New Revision: cd22e0dc9d0b5487eb2d54dd028a2aa439627159 URL: https://github.com/llvm/llvm-project/commit/cd22e0dc9d0b5487eb2d54dd028a2aa439627159 DIFF: https://github.com/llvm/llvm-project/commit/cd22e0dc9d0b5487eb2d54dd028a2aa439627159.diff

[PATCH] D147888: Update declaration message of extern linkage

cjdb added a comment. I think we should fundamentally rethink this entire category of diagnostic. Rather than having a static diagnostic per offence stating //what// happened, we should instead have a single diagnostic that captures both what happened, why it's bad, and how to fix it.

[PATCH] D147520: Fix a time-trace issue of incorrect header hierarchy when a header contains a template function for its last symbol.

aras-p added a comment. This is probably obsolete now that D148410 has landed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147520/new/ https://reviews.llvm.org/D147520

[PATCH] D148262: [clang][cmake] Add options to pass in vcs repo and revision info

zhuhan0 added a comment. The patch failed a build bot which sets `LLVM_APPEND_VC_REV=OFF`. Fixed with https://reviews.llvm.org/rGee68f612ba682ddb911c5621e63df56039ec5824. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] ee68f61 - Second try: [clang][cmake] Add options to pass in vcs repo and revision info

Author: Han Zhu Date: 2023-04-17T10:54:28-07:00 New Revision: ee68f612ba682ddb911c5621e63df56039ec5824 URL: https://github.com/llvm/llvm-project/commit/ee68f612ba682ddb911c5621e63df56039ec5824 DIFF: https://github.com/llvm/llvm-project/commit/ee68f612ba682ddb911c5621e63df56039ec5824.diff LOG:

[PATCH] D146054: [RISCV] Add -print-supported-marchs and -march=help support

4vtomat updated this revision to Diff 514302. 4vtomat added a comment. Resolved MaskRay's comments. Should we use @Kito's approach to deal with -march=help? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146054/new/ https://reviews.llvm.org/D146054

[PATCH] D141389: [DFSAN] Add support for strnlen, strncat, strsep, sscanf and _tolower

browneee added a comment. Separate review. Keep patches as small as possible, do one review for each patch. If you'd like me to submit it for you, please provide your email to credit the patch to. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141389/new/

[PATCH] D148481: [clang-repl] Enable debugging of JIT-ed code.

sgraenitz accepted this revision. sgraenitz added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148481/new/ https://reviews.llvm.org/D148481 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D143364: [RISCV] Support scalar/fix-length vector NTLH intrinsic with different domain

craig.topper added inline comments. Comment at: clang/test/CodeGen/RISCV/ntlh-intrinsics/riscv32-zihintntl.c:19 +typedef signed short v8ss __attribute__((vector_size(16))); +typedef signed char v16sc __attribute__((vector_size(16))); +v4si v4si1, v4si2; BeMg

[PATCH] D148433: [clang] Add tests for DRs about complete-class context

Endill added inline comments. Comment at: clang/test/CXX/drs/dr23xx.cpp:42 +namespace dr2335 { // dr2335: no drafting +// FIXME: all of the examples are well-formed. aaron.ballman wrote: > Endill wrote: > > shafik wrote: > > > My comment on 1890 applies here

[PATCH] D147684: [clangd] Add batch fixes for include-cleaner diagnostics

kadircet added inline comments. Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:418 +Fix removeAllUnusedIncludes(llvm::ArrayRef UnusedIncludes) { + Fix RemoveAll; can we also derive these from an `llvm::ArrayRef` ? to make sure there can't be a

[PATCH] D148274: [clang] Fix overly aggressive lifetime checks for parenthesized aggregate initialization

ayzhao updated this revision to Diff 514291. ayzhao added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148274/new/ https://reviews.llvm.org/D148274 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td

[clang] c720c1d - Revert "[clang][cmake] Add options to pass in vcs repo and revision info"

Author: Han Zhu Date: 2023-04-17T10:09:27-07:00 New Revision: c720c1db11732e6e5ab60a6db41e155d4ab6f708 URL: https://github.com/llvm/llvm-project/commit/c720c1db11732e6e5ab60a6db41e155d4ab6f708 DIFF: https://github.com/llvm/llvm-project/commit/c720c1db11732e6e5ab60a6db41e155d4ab6f708.diff LOG:

[PATCH] D147256: [DebugInfo] Fix file path separator when targeting windows.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGab8f622c79b2: [DebugInfo] Fix file path separator when targeting windows. (authored by zequanwu). Repository: rG LLVM Github Monorepo CHANGES

[clang] ab8f622 - [DebugInfo] Fix file path separator when targeting windows.

Author: Zequan Wu Date: 2023-04-17T13:07:42-04:00 New Revision: ab8f622c79b27bc606da043e8dcbd417b8ade725 URL: https://github.com/llvm/llvm-project/commit/ab8f622c79b27bc606da043e8dcbd417b8ade725 DIFF: https://github.com/llvm/llvm-project/commit/ab8f622c79b27bc606da043e8dcbd417b8ade725.diff

[PATCH] D147256: [DebugInfo] Fix file path separator when targeting windows.

zequanwu added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:583 + llvm::sys::path::Style Style = + llvm::sys::path::is_absolute(ObjFileNameForDebug) + ? llvm::sys::path::Style::native hans wrote: > zequanwu wrote: > > hans

[PATCH] D147256: [DebugInfo] Fix file path separator when targeting windows.

zequanwu updated this revision to Diff 514287. zequanwu marked an inline comment as done. zequanwu added a comment. Add comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147256/new/ https://reviews.llvm.org/D147256 Files:

[PATCH] D148377: [clang][dataflow] Drop optional model's dependency on libc++ internals.

gribozavr2 accepted this revision. gribozavr2 added a comment. Nice deduplication and compatibility fixes! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148377/new/ https://reviews.llvm.org/D148377 ___

[PATCH] D148410: [Parse] Remove TimeTraceScope for "ParseTemplate"

This revision was automatically updated to reflect the committed changes. Closed by commit rG676a96f768e1: [Parse] Remove TimeTraceScope for ParseTemplate (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148410/new/

[clang] 676a96f - [Parse] Remove TimeTraceScope for "ParseTemplate"

Author: Fangrui Song Date: 2023-04-17T09:57:53-07:00 New Revision: 676a96f768e1101ed5187c7751e56e1e11ebe593 URL: https://github.com/llvm/llvm-project/commit/676a96f768e1101ed5187c7751e56e1e11ebe593 DIFF: https://github.com/llvm/llvm-project/commit/676a96f768e1101ed5187c7751e56e1e11ebe593.diff

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:263 + if (SubstitutedAtomicExpr.get()->isValueDependent()) +return SubstitutedAtomicExpr; alexander-shaposhnikov wrote: > erichkeane wrote: > > alexander-shaposhnikov wrote: > >

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

alexander-shaposhnikov added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:227 +(TSTy = Ty->getAs())) + Result.addOuterTemplateArguments(const_cast(FTD), + TSTy->template_arguments(),

[PATCH] D147256: [DebugInfo] Fix file path separator when targeting windows.

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm Comment at: clang/lib/Driver/ToolChains/Clang.cpp:583 + llvm::sys::path::Style Style = + llvm::sys::path::is_absolute(ObjFileNameForDebug) + ?

[PATCH] D141824: [clang-repl] Add a command to load dynamic libraries

argentite added a comment. We should probably also address the lack of linker issue as well. Should we go for a precompiled dynamic library file? There seems to be some "precedent" of this in other tests. Comment at: clang/test/Interpreter/dynamic-library.cpp:6 + +#include

[PATCH] D148262: [clang][cmake] Add options to pass in vcs repo and revision info

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1f5e737fc135: [clang][cmake] Add options to pass in vcs repo and revision info (authored by zhuhan0). Repository: rG LLVM Github Monorepo

[clang] 1f5e737 - [clang][cmake] Add options to pass in vcs repo and revision info

Author: Han Zhu Date: 2023-04-17T09:50:18-07:00 New Revision: 1f5e737fc135bf991889a1364b8f8c5edc3953d2 URL: https://github.com/llvm/llvm-project/commit/1f5e737fc135bf991889a1364b8f8c5edc3953d2 DIFF: https://github.com/llvm/llvm-project/commit/1f5e737fc135bf991889a1364b8f8c5edc3953d2.diff LOG:

[PATCH] D148433: [clang] Add tests for DRs about complete-class context

aaron.ballman added inline comments. Comment at: clang/test/CXX/drs/dr23xx.cpp:42 +namespace dr2335 { // dr2335: no drafting +// FIXME: all of the examples are well-formed. Endill wrote: > shafik wrote: > > My comment on 1890 applies here as well. > > > > CC

[clang] 836786a - [NFC][Assignment Tracking] Rename flag variable in Options.td

Author: OCHyams Date: 2023-04-17T17:43:52+01:00 New Revision: 836786ab7f6c5d94458fe4136807bfea6184e270 URL: https://github.com/llvm/llvm-project/commit/836786ab7f6c5d94458fe4136807bfea6184e270 DIFF: https://github.com/llvm/llvm-project/commit/836786ab7f6c5d94458fe4136807bfea6184e270.diff LOG:

[PATCH] D147928: [clang] Keep multiple-include optimization for null directives

aaron.ballman added inline comments. Comment at: clang/lib/Lex/PPDirectives.cpp:1183-1185 +if (!ReadAnyTokensBeforeDirective) { + CurPPLexer->MIOpt.ResetReadToken(); +} NFC but matches our style guide. One thing to consider: making the call a

[PATCH] D141824: [clang-repl] Add a command to load dynamic libraries

sgraenitz added inline comments. Comment at: clang/test/Interpreter/dynamic-library.cpp:6 + +#include + bcain wrote: > This test fails for me like below. > > > ``` > FAIL: Clang :: Interpreter/dynamic-library.cpp (1 of 17751) > TEST

[PATCH] D148496: [compiler-rt] [test] Mark dfsan tests XFAIL on glibc-2.37

browneee accepted this revision. browneee added a comment. LGTM `release_shadow_space.c:29: size_t get_rss_kb(): Assertion ```feof(f)' failed.` `custom.cpp:1858: void test_sprintf(): Assertion ```strcmp(buf, "Hello world!") == 0' failed.` Issue appears to be with the program rather than the

  1   2   >