[PATCH] D148634: [RISCV] Bump Zfa version to 0.2 and correct RISCVUsage description

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2a5661c84158: [RISCV] Bump Zfa version to 0.2 and correct RISCVUsage description (authored by asb). Herald added a project: clang. Herald added a

[clang] 2a5661c - [RISCV] Bump Zfa version to 0.2 and correct RISCVUsage description

Author: Alex Bradbury Date: 2023-04-19T06:27:35+01:00 New Revision: 2a5661c8415876be3fbd56ce90c2031e89ba0ef3 URL: https://github.com/llvm/llvm-project/commit/2a5661c8415876be3fbd56ce90c2031e89ba0ef3 DIFF: https://github.com/llvm/llvm-project/commit/2a5661c8415876be3fbd56ce90c2031e89ba0ef3.diff

[PATCH] D148223: [SiFive] Support C intrinsics for xsfvcp extension.

4vtomat updated this revision to Diff 514821. 4vtomat added a comment. Resolved Craig's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148223/new/ https://reviews.llvm.org/D148223 Files: clang/include/clang/Basic/riscv_sifive_vector.td

[PATCH] D148680: [RISCV] Split out part of riscv_vector.td to riscv_vector_common.td

4vtomat added a comment. In D148680#4279291 , @craig.topper wrote: > Are we running tablegen separately for each vendor extension? Yes, I guess the vendor extensions should be separated into different tablegen file so that they don't be in

[PATCH] D133863: [RISCV] Add MC support of RISCV zcmt Extension

craig.topper added inline comments. Comment at: llvm/lib/Support/RISCVISAInfo.cpp:903 +return createStringError(errc::invalid_argument, + "zcmt is not allowed when c is specified"); + Extension names should be in single quotes.

[PATCH] D148223: [SiFive] Support C intrinsics for xsfvcp extension.

craig.topper added inline comments. Comment at: clang/include/clang/Basic/riscv_sifive_vector.td:41 + if !find(prototype, "0") then { + def : VCIXBuiltinSet; + } Indent Comment at: clang/include/clang/Basic/riscv_sifive_vector.td:64 +

[PATCH] D147307: [clang] Do not require GNUInlineAttr for inline builtins

jyu2 added a comment. This change seems cause assert: https://godbolt.org/z/z9G87Wr37 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147307/new/ https://reviews.llvm.org/D147307 ___ cfe-commits mailing

[PATCH] D148601: [Clang] Handle Error message to output proper Prefix

tbaeder added inline comments. Comment at: clang/lib/Frontend/VerifyDiagnosticConsumer.cpp:1097 // source file(s) processed. +const auto = Diags.getDiagnosticOptions().VerifyPrefixes; if (Status == HasNoDirectives) { Can move this line inside the

[PATCH] D148601: [Clang] Handle Error message to output proper Prefix

tbaeder added a comment. I am not 100% sure about the semantics of passing multiple prefixes, i.e. if the error is emitted for all prefixes individually or if it's only emitted if no `expected` line for any of the prefixes is found. In the latter case we should probably add all the prefixes to

[PATCH] D148308: [RISCV] Split out SiFive VCIX C intrinsics from riscv_vector.td

4vtomat updated this revision to Diff 514817. 4vtomat added a comment. Resolved Kito's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148308/new/ https://reviews.llvm.org/D148308 Files: clang/include/clang/Basic/BuiltinsRISCVVector.def

[PATCH] D148680: [RISCV] Split out part of riscv_vector.td to riscv_vector_common.td

craig.topper added a comment. Are we running tablegen separately for each vendor extension? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148680/new/ https://reviews.llvm.org/D148680 ___ cfe-commits

[PATCH] D133863: [RISCV] Add MC support of RISCV zcmt Extension

kito-cheng added inline comments. Comment at: lld/ELF/InputSection.h:404 -static_assert(sizeof(InputSection) <= 152, "InputSection is too big"); +static_assert(sizeof(InputSection) <= 160, "InputSection is too big"); Why we need this change? Repository:

[PATCH] D148223: [SiFive] Support C intrinsics for xsfvcp extension.

4vtomat updated this revision to Diff 514812. 4vtomat added a comment. Rename riscv_sifive_vcix.td to riscv_sifive_vector.td Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148223/new/ https://reviews.llvm.org/D148223 Files:

[PATCH] D148223: [SiFive] Support C intrinsics for xsfvcp extension.

4vtomat updated this revision to Diff 514810. 4vtomat added a comment. Resolved Kito's comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148223/new/ https://reviews.llvm.org/D148223 Files: clang/include/clang/Basic/riscv_sifive_vcix.td

[PATCH] D148680: [RISCV] Split out part of riscv_vector.td to riscv_vector_common.td

4vtomat created this revision. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng,

[PATCH] D146269: MIPS: allow o32 abi with 64bit CPU and 64 abi with 32bit triple

MaskRay accepted this revision. MaskRay added inline comments. This revision is now accepted and ready to land. Comment at: llvm/lib/Target/Mips/MipsSubtarget.cpp:107 // Check if Architecture and ABI are compatible. - assert(((!isGP64bit() && isABI_O32()) || -

[PATCH] D146269: MIPS: allow o32 abi with 64bit CPU and 64 abi with 32bit triple

wzssyqa added a comment. ping... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146269/new/ https://reviews.llvm.org/D146269 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D145088: [RISCV] Add attribute(riscv_rvv_vector_bits(N)) based on AArch64 arm_sve_vector_bits.

craig.topper added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:2332 + + #if __RISCV_RVV_VLEN_BITS==512 + typedef vint8m1_t fixed_vint8m1_t __attribute__((riscv_rvv_vector_bits(512))); rjmccall wrote: > craig.topper wrote: > > rjmccall

[PATCH] D147175: [clang] Add __is_trivially_equality_comparable

cjdb added a comment. This patch is causing breakages downstream because it didn't have do the struct dance, so I've added D148677 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147175/new/

[PATCH] D148677: [clang] makes `__is_trivially_equality_comparable` available as a struct

cjdb updated this revision to Diff 514798. cjdb added a comment. uploads the right test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148677/new/ https://reviews.llvm.org/D148677 Files: clang/lib/Parse/ParseDeclCXX.cpp

[PATCH] D148677: [clang] makes `__is_trivially_equality_comparable` available as a struct

cjdb created this revision. cjdb added reviewers: aaron.ballman, erichkeane, shafik, dblaikie. Herald added a project: All. cjdb requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Since this was originally a name in library, it needs an

[PATCH] D147901: [NFC][CLANG][API] Fix coverity remarks about large copies by values

Manna added a comment. Thank you everyone for reviews and feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147901/new/ https://reviews.llvm.org/D147901 ___ cfe-commits mailing list

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

alexander-shaposhnikov added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:263 + if (SubstitutedAtomicExpr.get()->isValueDependent()) +return SubstitutedAtomicExpr; alexander-shaposhnikov wrote: > alexander-shaposhnikov wrote: > > erichkeane

[PATCH] D133289: [C2X] N3007 Type inference for object definitions

to268 updated this revision to Diff 514789. to268 added a comment. I have *hopefully* fixed my broken patch. This is all the things in need to address: auto str2[] = "string"; [[clang::overloadable]] auto test(auto x) { return x; } and maybe retry to support `auto` in compound literals,

[PATCH] D147916: [10/11][POC][Clang][RISCV] Define vget for tuple type

craig.topper added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:2723 + unsigned MaxIndex = cast(VTupleOperand->getType())->getNumElements(); + Index = std::min(Index, MaxIndex); + craig.topper wrote: > Does

[PATCH] D147917: [11/11][POC][Clang][RISCV] Define vset for tuple type

craig.topper added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:2763 + unsigned MaxIndex = cast(VTupleOperand->getType())->getNumElements(); + Index = std::min(Index, MaxIndex); + Does SemaChecking already guarantee

[PATCH] D147916: [10/11][POC][Clang][RISCV] Define vget for tuple type

craig.topper added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:2723 + unsigned MaxIndex = cast(VTupleOperand->getType())->getNumElements(); + Index = std::min(Index, MaxIndex); + Does SemaChecking.cpp already

[PATCH] D147914: [8/11][POC][Clang][RISCV] Define tuple type variant of vloxseg2ei32 vluxseg2ei32

craig.topper added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:2014 + + llvm::Value *MaskOperand = IsMasked ? Ops[0] : nullptr; + llvm::Value *PtrOperand = IsMasked ? Ops[1] : Ops[0]; Same comment as last review Repository:

[PATCH] D146242: [ARM] Fixing ABI mismatch for packed structs and fields

dblaikie added inline comments. Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:2118 + if (Packed) +UnadjustedAlignment = std::max(UnadjustedAlignment, UnpackedFieldAlign); UpdateAlignment(FieldAlign, UnpackedFieldAlign, PreferredAlign); rjmccall

[PATCH] D147913: [7/11][POC][Clang][RISCV] Define tuple type variant of vssseg2e32

craig.topper added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:1962 + // Intrinsic: (val0, val1, ..., ptr, stride, vl) + llvm::Value *MaskOperand = IsMasked ? Ops[0] : nullptr; + llvm::Value *PtrOperand = IsMasked ? Ops[1] : Ops[0];

[PATCH] D147912: [6/11][POC][Clang][RISCV] Define tuple type variant of vlsseg2e32

craig.topper added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:1914 + + llvm::Value *MaskOperand = IsMasked ? Ops[0] : nullptr; + llvm::Value *PtrOperand = IsMasked ? Ops[1] : Ops[0]; similar comment to what I left on the

[PATCH] D147911: [5/11][POC][Clang][RISCV] Define tuple type variant of vlseg2e32ff

craig.topper added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:1852 + llvm::Value *PtrOperand = IsMasked ? Ops[1] : Ops[0]; + unsigned NewVLOperandIdx = IsMasked ? 2 : 1; + llvm::Value *NewVLOperand = IsMasked ? Ops[2] : Ops[1];

[PATCH] D147731: [3/11][POC][Clang][RISCV] Add typedef of the tuple type and define tuple type variant of vlseg2e32

craig.topper added inline comments. Comment at: clang/include/clang/AST/ASTContext.h:1486 + QualType getScalableVectorTupleType(QualType EltTy, unsigned NumElts, + unsigned Tuple) const; + Use `NF` or `NumFields` instead of

[PATCH] D148439: [clang-rename] Exit gracefully when no input provided

kbobyrev requested changes to this revision. kbobyrev added a comment. This revision now requires changes to proceed. Yeah, this should be a right approach! Thanks! Comment at: clang/test/clang-rename/NonExistFile.cpp:1 +// RUN: not clang-rename -offset=0 -new-name=plop asdasd

[PATCH] D146873: [2/11][POC][Clang][RISCV] Define RVV tuple types

craig.topper added inline comments. Comment at: clang/lib/CodeGen/CodeGenTypes.cpp:632 +#define RVV_TYPE(Name, Id, SingletonId) \ + case BuiltinType::Id: { \ +

[PATCH] D143364: [RISCV] Support scalar/fix-length vector NTLH intrinsic with different domain

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143364/new/ https://reviews.llvm.org/D143364

[PATCH] D148671: [Driver] Make -fsanitize=kcfi,function incompatible

MaskRay created this revision. MaskRay added reviewers: nickdesaulniers, samitolvanen, peter.smith. Herald added subscribers: yaneury, supersymetrie, Chia-hungDuan, cryptoad. Herald added a project: All. MaskRay requested review of this revision. Herald added a project: clang. Herald added a

[PATCH] D148573: Port -fsanitize=function to AArch64

MaskRay updated this revision to Diff 514768. MaskRay edited the summary of this revision. MaskRay added a comment. Make -mbranch-protection=bti -fsanitize=function work. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148573/new/

[PATCH] D148665: Change -fsanitize=function to place two words before the function entry

MaskRay updated this revision to Diff 514761. MaskRay added a comment. fix clang/test/CodeGen Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148665/new/ https://reviews.llvm.org/D148665 Files: clang/lib/CodeGen/CGExpr.cpp

[PATCH] D148573: Port -fsanitize=function to AArch64

MaskRay added a comment. In D148573#4277573 , @peter.smith wrote: > As it stands I think this may have problems with -mbranch-protection. In that > case we'll need a `BTI c` to be the target of the indirect branch. I'm > guessing something like: > >

[PATCH] D148665: Change -fsanitize=function to place two words before the function entry

MaskRay created this revision. MaskRay added reviewers: dmgreen, lenary, pcc, peter.smith. Herald added subscribers: Enna1, hiraditya, kristof.beyls. Herald added a project: All. MaskRay requested review of this revision. Herald added projects: clang, Sanitizers, LLVM. Herald added subscribers:

[PATCH] D148658: [clang] Make access to submodules via `iterator_range`

Stoorx updated this revision to Diff 514749. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148658/new/ https://reviews.llvm.org/D148658 Files: clang/include/clang/Basic/Module.h clang/lib/Basic/Module.cpp clang/lib/CodeGen/CodeGenModule.cpp

[PATCH] D148663: [RFC][clangd] Use interpolation for CDB pushed via LSP protocol

DmitryPolukhin created this revision. DmitryPolukhin added reviewers: kadircet, nridge, sammccall, ilya-biryukov. DmitryPolukhin added a project: clang-tools-extra. Herald added a subscriber: arphaman. Herald added a project: All. DmitryPolukhin requested review of this revision. Herald added a

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

alexander-shaposhnikov added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:781 + /*ForConstraintInstantiation=*/true, /*SkipForSpecialization*/ false); + Sema::SFINAETrap SFINAE(S, /*AccessCheckingSFINAE=*/false); + std::optional ThisScope;

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

alexander-shaposhnikov added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:781 + /*ForConstraintInstantiation=*/true, /*SkipForSpecialization*/ false); + Sema::SFINAETrap SFINAE(S, /*AccessCheckingSFINAE=*/false); + std::optional ThisScope;

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

alexander-shaposhnikov updated this revision to Diff 514745. alexander-shaposhnikov added a comment. New version (address some comments) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146178/new/ https://reviews.llvm.org/D146178 Files:

[PATCH] D141451: [clang] report inlining decisions with -Wattribute-{warning|error}

nickdesaulniers added inline comments. Comment at: clang/include/clang/Basic/DiagnosticFrontendKinds.td:94 +def note_fe_backend_in : Note<"In function '%0'">; +def note_fe_backend_inlined : Note<"\twhich inlined function '%0'">; erichkeane wrote: > This tab in

[PATCH] D141451: [clang] report inlining decisions with -Wattribute-{warning|error}

nickdesaulniers updated this revision to Diff 514746. nickdesaulniers marked 3 inline comments as done. nickdesaulniers added a comment. - rebase, invert inlining reporting chain, update diagnostic text Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D148658: [clang] Make access to submodules via `iterator_range`

Stoorx updated this revision to Diff 514744. Stoorx added a comment. Fix unchanged usage of old functions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148658/new/ https://reviews.llvm.org/D148658 Files: clang/include/clang/Basic/Module.h

[PATCH] D148639: [NFC][clang] Fix static analyzer concerns about AUTO_CAUSES_COPY

tahonermann added a comment. After seeing this review, I filed a support case with Synopsys with a request to stop reporting `AUTO_CAUSES_COPY` issues for small objects of class types, at least in the absence of additional evidence that a reference would be preferred.

[PATCH] D148369: [DependencyScanning] Canonicalize `CodeGenOptions.RelaxAll`

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM. Note that I think we should consider renaming the `-format` flag in the future. Ideally, it should reflect the fact that the scanner is doing different work, not just

[PATCH] D148653: [Header][doc] Add/revise MONITOR/MWAIT[X] descriptions

goldstein.w.n added a comment. LGTM. I'm not a maintainer to please wait a day or so to push so that others can review. Comment at: clang/lib/Headers/pmmintrin.h:278 ///the monitor event pending state. Data stored in the monitored address ///range causes the

[PATCH] D148658: [clang] Make access to submodules via `iterator_range`

Stoorx created this revision. Stoorx added a reviewer: DavidSpickett. Stoorx added a project: clang. Herald added a project: All. Stoorx requested review of this revision. In file `clang/lib/Basic/Module.cpp` the `Module` class had `submodule_begin()` and `submodule_end()` functions to retrieve

[PATCH] D147743: [Clang][NFC] Rename methods/vars to reflect their real usage

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb51a03e1bbe7: [Clang][NFC] Rename methods/vars to reflect their real usage (authored by void). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang-tools-extra] b51a03e - [Clang][NFC] Rename methods/vars to reflect their real usage

Author: Bill Wendling Date: 2023-04-18T13:48:08-07:00 New Revision: b51a03e1bbe7ea8868ffb24472fc532d0c00943c URL: https://github.com/llvm/llvm-project/commit/b51a03e1bbe7ea8868ffb24472fc532d0c00943c DIFF: https://github.com/llvm/llvm-project/commit/b51a03e1bbe7ea8868ffb24472fc532d0c00943c.diff

[PATCH] D147743: [Clang][NFC] Rename methods/vars to reflect their real usage

void updated this revision to Diff 514730. void marked an inline comment as done. void added a comment. Add comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147743/new/ https://reviews.llvm.org/D147743 Files:

[PATCH] D147016: [PowerPC] Add function pointer alignment to DataLayout

thurston added a comment. Ah, I just noticed you had a follow-up commit (https://reviews.llvm.org/rG0236564771b432ebf050144eda4ef4b7424db8c3). I'm re-running the tests/build. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147016/new/

[PATCH] D147016: [PowerPC] Add function pointer alignment to DataLayout

thurston added a comment. This is causing buildbot failures e.g., https://lab.llvm.org/buildbot/#/builders/5/builds/33084: TEST 'lld :: ELF/lto/ppc.ll' FAILED ... ld.lld:

[PATCH] D140722: [OpenMP] Prefix outlined and reduction func names with original func's name

nextsilicon-itay-bookstein added a comment. Alright, cool, thanks! I'll land it tomorrow evening if there are no objections. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140722/new/ https://reviews.llvm.org/D140722 ___ cfe-commits mailing

[PATCH] D147844: Emit warning when implicit cast to bool happens in an conditional operator expression when used inside an overloaded shift operator expression

chaitanyav added a comment. @aaron.ballman am looking into this. If i change it back to `operation int();` and add `Stream& operator<<(bool)` I get ` - error: 'warning' diagnostics expected but not seen: File /usr/home/nvellanki/explore/llvm-project/clang/test/Sema/parentheses.cpp Line

[PATCH] D148653: [Header][doc] Add/revise MONITOR/MWAIT[X] descriptions

probinson created this revision. probinson added reviewers: RKSimon, pengfei, goldstein.w.n, craig.topper. Herald added a project: All. probinson requested review of this revision. https://reviews.llvm.org/D148653 Files: clang/lib/Headers/mwaitxintrin.h clang/lib/Headers/pmmintrin.h Index:

[PATCH] D146595: [clang] Add "debug_trampoline" attribute

dblaikie added a comment. In D146595#4235340 , @augusto2112 wrote: > In D146595#4235333 , @aprantl wrote: > >> I hope I'm not kicking off a long bike-shedding thread, but I would propose >> to either call the

[PATCH] D147928: [clang] Keep multiple-include optimization for null directives

IncludeGuardian added inline comments. Comment at: clang/lib/Lex/PPDirectives.cpp:1183-1185 +if (!ReadAnyTokensBeforeDirective) { + CurPPLexer->MIOpt.ResetReadToken(); +} aaron.ballman wrote: > NFC but matches our style guide. > > One thing to

[PATCH] D148639: [NFC][clang] Fix static analyzer concerns about AUTO_CAUSES_COPY

aaron.ballman added a comment. Thanks for the static analysis fixes, however, it looks like quite a few of them were false positives again. When fixing any static analysis diagnostics, please put in the effort to determine whether it's actually correct or not, as it seem the Coverity

[PATCH] D148467: [clang-format] Add a new AfterCSharpProperty to BraceWrapping

HazardyKnusperkeks added a comment. In D148467#4277960 , @MyDeveloperDay wrote: >>> public Foo { >>> set; >>> get; >>> } >> >> At least from my experience, the getter is specified before the setter, >> though I'm unsure how important

[PATCH] D147844: Emit warning when implicit cast to bool happens in an conditional operator expression when used inside an overloaded shift operator expression

aaron.ballman added inline comments. Comment at: clang/test/Sema/parentheses.cpp:34 public: - operator int(); + operator bool(); Stream <<(int); aaron.ballman wrote: > Is this change necessary? Alternatively, can we add this as an overload > instead of

[PATCH] D148385: [RISCV] Implement KCFI operand bundle lowering for RV64

samitolvanen updated this revision to Diff 514708. samitolvanen added a comment. Addressed most of the feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148385/new/ https://reviews.llvm.org/D148385 Files: clang/lib/CodeGen/BackendUtil.cpp

[PATCH] D145088: [RISCV] Add attribute(riscv_rvv_vector_bits(N)) based on AArch64 arm_sve_vector_bits.

rjmccall added a comment. > You mean RISC-V specific code or generic code? If generic, I assume we got it > from SVE's earlier implementation. Ah, if SVE has a similar feature then that makes sense. Comment at: clang/include/clang/Basic/AttrDocs.td:2332 + + #if

[clang] 310ee08 - Reland "[clang-repl] Enable debugging of JIT-ed code."

Author: Vassil Vassilev Date: 2023-04-18T18:33:52Z New Revision: 310ee08d5d45d9388333842a79bf4cef761afddf URL: https://github.com/llvm/llvm-project/commit/310ee08d5d45d9388333842a79bf4cef761afddf DIFF: https://github.com/llvm/llvm-project/commit/310ee08d5d45d9388333842a79bf4cef761afddf.diff

[PATCH] D147844: Emit warning when implicit cast to bool happens in an conditional operator expression when used inside an overloaded shift operator expression

chaitanyav updated this revision to Diff 514702. chaitanyav added a comment. Update release notes about the fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147844/new/ https://reviews.llvm.org/D147844 Files: clang/docs/ReleaseNotes.rst

[PATCH] D148385: [RISCV] Implement KCFI operand bundle lowering for RV64

samitolvanen marked 9 inline comments as done. samitolvanen added a comment. In D148385#4275617 , @jrtc27 wrote: > I can't help but feel the core of this should be target-independent, with TLI > or similar hooks to actually do the target-specific bits?

[PATCH] D148266: [clang][driver] Linking to just-built libc++.dylib when bootstrapping libc++ with clang

fahadnayyar updated this revision to Diff 514699. fahadnayyar added a comment. Fixing some more regression test errors. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148266/new/ https://reviews.llvm.org/D148266 Files:

[PATCH] D148554: [dataflow] Extract arena for Value/StorageLocation out of DataflowAnalysisContext

ymandel accepted this revision. ymandel added a comment. Love it! Thanks. Comment at: clang/include/clang/Analysis/FlowSensitive/Arena.h:129 +} // namespace clang::dataflow \ No newline at end of file add newline? Repository: rG LLVM Github Monorepo

[PATCH] D148596: [KMSAN] Enable on SystemZ

iii updated this revision to Diff 514692. iii added a comment. - Better explain the ABI situation. - Extend the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148596/new/ https://reviews.llvm.org/D148596 Files:

[PATCH] D148467: [clang-format] Add a new AfterCSharpProperty to BraceWrapping

StrangeRanger added a comment. In D148467#4277960 , @MyDeveloperDay wrote: > I'm trying to decide if I put that option in this change or in a separate > change (thoughts @HazardyKnusperkeks, @owenpan ) I'm not too privy to your workflow, but if by "in

[PATCH] D148422: [ClangFE] Handle statement expressions properly with CheckAtomicAlignment()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG790c9ac529c9: [ClangFE] Handle statement expressions properly with CheckAtomicAlignment(). (authored by jonpa). Herald added a project: clang.

[clang] 790c9ac - [ClangFE] Handle statement expressions properly with CheckAtomicAlignment().

Author: Jonas Paulsson Date: 2023-04-18T19:33:32+02:00 New Revision: 790c9ac529c9ad0d7e89e3de2041d85cfc411b40 URL: https://github.com/llvm/llvm-project/commit/790c9ac529c9ad0d7e89e3de2041d85cfc411b40 DIFF:

[PATCH] D148467: [clang-format] Add a new AfterCSharpProperty to BraceWrapping

MyDeveloperDay updated this revision to Diff 514684. MyDeveloperDay added a comment. upload the correct patch file CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148467/new/ https://reviews.llvm.org/D148467 Files: clang/docs/ClangFormatStyleOptions.rst clang/docs/ReleaseNotes.rst

[PATCH] D148467: [clang-format] Add a new AfterCSharpProperty to BraceWrapping

MyDeveloperDay updated this revision to Diff 514682. MyDeveloperDay added a comment. add init support and fix indentation issue when only one property is defined but the is an auto-property CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148467/new/ https://reviews.llvm.org/D148467

[PATCH] D146591: [dataflow] add HTML logger: browse code/cfg/analysis timeline/state

xazax.hun accepted this revision. xazax.hun added a comment. I am a bit overloaded at the moment, feel free to commit. I can still add comments later that could be addressed in a follow up. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146591/new/

[PATCH] D146591: [dataflow] add HTML logger: browse code/cfg/analysis timeline/state

sammccall added a comment. @xazax.hun do you still want to look at this again? I'm itching a little to get some use out of it :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146591/new/ https://reviews.llvm.org/D146591

[PATCH] D147016: [PowerPC] Add function pointer alignment to DataLayout

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8d2e9fc8553c: [PowerPC] Add function pointer alignment to DataLayout (authored by daltenty). Herald added a project: clang. Herald added a

[clang] 8d2e9fc - [PowerPC] Add function pointer alignment to DataLayout

Author: David Tenty Date: 2023-04-18T13:00:27-04:00 New Revision: 8d2e9fc8553c91b1f22e82ffc2c00020f40bb0a2 URL: https://github.com/llvm/llvm-project/commit/8d2e9fc8553c91b1f22e82ffc2c00020f40bb0a2 DIFF: https://github.com/llvm/llvm-project/commit/8d2e9fc8553c91b1f22e82ffc2c00020f40bb0a2.diff

[PATCH] D148467: [clang-format] Add a new AfterCSharpProperty to BraceWrapping

MyDeveloperDay added a comment. >> public Foo { >> set; >> get; >> } > > At least from my experience, the getter is specified before the setter, > though I'm unsure how important this is in your eyes. Lets hold off the idea of swapping `set;get` around from this patch, but

[PATCH] D148467: [clang-format] Add a new AfterCSharpProperty to BraceWrapping

StrangeRanger added a comment. In D148467#4272231 , @MyDeveloperDay wrote: > for default `set;get` or `get;set` for when `AfterCSharpProperty` is true, > > public Foo { > set; > get; > } At least from my experience, the getter is

[PATCH] D148021: [Headers][doc] Add FMA intrinsic descriptions

probinson added a comment. I chose to leave the "for each element" cases as-is, but I will keep your comments in mind as I go through other intrinsics. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148021/new/ https://reviews.llvm.org/D148021

[PATCH] D148021: [Headers][doc] Add FMA intrinsic descriptions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0905c567f0c7: [Headers][doc] Add FMA intrinsic descriptions (authored by probinson). Herald added a project: clang. Changed prior to commit:

[clang] 0905c56 - [Headers][doc] Add FMA intrinsic descriptions

Author: Paul Robinson Date: 2023-04-18T09:31:09-07:00 New Revision: 0905c567f0c7328780c727b470a92cda1ee54697 URL: https://github.com/llvm/llvm-project/commit/0905c567f0c7328780c727b470a92cda1ee54697 DIFF: https://github.com/llvm/llvm-project/commit/0905c567f0c7328780c727b470a92cda1ee54697.diff

[PATCH] D147626: [clang] Do not crash when initializing union with flexible array member

shafik added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:808 unsigned NumElems = numStructUnionElements(ILE->getType()); - if (RDecl->hasFlexibleArrayMember()) + if (!RDecl->isUnion() && RDecl->hasFlexibleArrayMember()) ++NumElems;

[PATCH] D147743: [Clang][NFC] Rename methods/vars to reflect their real usage

shafik added inline comments. Comment at: clang/lib/Index/IndexBody.cpp:426 +return IndexCtx.handleReference(FD, D.getFieldLoc(), Parent, +ParentDC, SymbolRoleSet(), {}, E); + } nit Repository:

[PATCH] D148639: [NFC][clang] Fix static analyzer concerns about AUTO_CAUSES_COPY

Manna created this revision. Manna added reviewers: tahonermann, aaron.ballman. Herald added subscribers: steakhal, manas, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware, kristof.beyls. Herald added a reviewer: NoQ. Herald added a project: All. Manna

[PATCH] D148583: [clang-scan-deps] Add clang-scan-deps to llvm-driver build

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc2423a334585: [clang-scan-deps] Add clang-scan-deps to llvm-driver build (authored by abrachet). Herald added a project: clang. Herald added a

[PATCH] D148355: [analyzer] Fix comparison logic in ArrayBoundCheckerV2

steakhal added a comment. This subject haunted us for quite some time now, and there is more behind what it seems at first. If I'm not mistaken, this patch is pretty much what is in D86874 except that it doesn't give up and still checks the upper-bound in

[clang] e64fbf2 - Revert "[clang-repl] Enable debugging of JIT-ed code."

Author: Vassil Vassilev Date: 2023-04-18T13:41:38Z New Revision: e64fbf2cca8c4763a058ba59a48ab8e4b8193028 URL: https://github.com/llvm/llvm-project/commit/e64fbf2cca8c4763a058ba59a48ab8e4b8193028 DIFF: https://github.com/llvm/llvm-project/commit/e64fbf2cca8c4763a058ba59a48ab8e4b8193028.diff

[PATCH] D141824: [clang-repl] Add a command to load dynamic libraries

sgraenitz added a comment. In D141824#4274461 , @argentite wrote: > We should probably also address the lack of linker issue as well. Should we > go for a precompiled dynamic library file? There seems to be some "precedent" > of this in other tests.

[PATCH] D147743: [Clang][NFC] Rename methods/vars to reflect their real usage

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147743/new/ https://reviews.llvm.org/D147743

[PATCH] D148573: Port -fsanitize=function to AArch64

peter.smith added a comment. One other small thing. The docs page https://clang.llvm.org/docs/UndefinedBehaviorSanitizer.html would need the supported architectures updating: -fsanitize=function: Indirect call of a function through a function pointer of the wrong type (Darwin/Linux, C++ and

[PATCH] D148094: [DRAFT][clang][CodeGen] Break up TargetInfo.cpp [6/6]

barannikov88 added a comment. Kindly ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148094/new/ https://reviews.llvm.org/D148094 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D147175: [clang] Add __is_trivially_equality_comparable

kadircet added a comment. Hi folks! We have a setup in which clang (more specifically clang-tools) is always built from a version close to HEAD and libcxx is fetched from user's checkout of the codebase (which can lag behind HEAD for ~a month). So the 1 week gap between

[PATCH] D148573: Port -fsanitize=function to AArch64

peter.smith added a comment. As it stands I think this may have problems with -mbranch-protection. In that case we'll need a `BTI c` to be the target of the indirect branch. I'm guessing something like: _Z3funv BTI C ; In hint space B . + 8 .word .L__llvm_rtti_proxy-_Z3funv Otherwise

  1   2   >