[PATCH] D147844: [clang][Sema]Print diagnostic warning about precedence when integer expression is used without parentheses in an conditional operator expression

chaitanyav updated this revision to Diff 521203. chaitanyav added a comment. Remove extra parens Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147844/new/ https://reviews.llvm.org/D147844 Files: clang/docs/ReleaseNotes.rst

[PATCH] D150013: [Clang] Respect `-L` options when compiling directly for AMDGPU

jhuber6 updated this revision to Diff 521202. jhuber6 added a comment. Updating, @yaxunl does this look good? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150013/new/ https://reviews.llvm.org/D150013 Files:

[PATCH] D148490: [AIX] use system assembler for assembly files

MaskRay added inline comments. Comment at: clang/test/Driver/aix-assembler.s:23 + +// RUN: %clang %s -### -c 2>&1 -fno-integrated-as \ +// RUN: --target=powerpc-ibm-aix7.1.0.0 \ I am not sure you need 6 RUN lines to test this. Whether a target uses

[PATCH] D149504: [clang][CodeGenPGO] Don't use an invalid index when region counts disagree

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG220e77a83af1: [clang][CodeGenPGO] Dont use an invalid index when region counts disagree (authored by lanza). Changed prior to commit:

[clang] 220e77a - [clang][CodeGenPGO] Don't use an invalid index when region counts disagree

Author: Nathan Lanza Date: 2023-05-10T22:53:53-04:00 New Revision: 220e77a83af19b3f6c47472596fdaaef8e305927 URL: https://github.com/llvm/llvm-project/commit/220e77a83af19b3f6c47472596fdaaef8e305927 DIFF: https://github.com/llvm/llvm-project/commit/220e77a83af19b3f6c47472596fdaaef8e305927.diff

[PATCH] D150340: [SEH]:Fix assertion when try is used inside catch(...) block with /EHa

jyu2 created this revision. jyu2 added reviewers: asmith, efriedma, tentzen, pengfei. jyu2 added a project: clang. Herald added subscribers: kbarton, nemanjai. Herald added a project: All. jyu2 requested review of this revision. Current assert wiht /EHa with A single unwind edge may only enter

[PATCH] D148490: [AIX] use system assembler for assembly files

shchenz added a comment. gentle ping... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148490/new/ https://reviews.llvm.org/D148490 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D148506: [C++] Don't filter using declaration when we perform qualified look up

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6e85d2708115: [C++] Dont filter using declaration when we perform qualified look up (authored by ChuanqiXu). Repository: rG LLVM Github Monorepo

[clang] 6e85d27 - [C++] Don't filter using declaration when we perform qualified look up

Author: Chuanqi Xu Date: 2023-05-11T10:21:52+08:00 New Revision: 6e85d2708115bc1c7cd1bf1674b64934a3cf6c25 URL: https://github.com/llvm/llvm-project/commit/6e85d2708115bc1c7cd1bf1674b64934a3cf6c25 DIFF: https://github.com/llvm/llvm-project/commit/6e85d2708115bc1c7cd1bf1674b64934a3cf6c25.diff

[PATCH] D146342: [-Wunsafe-buffer-usage] Move the whole analysis to the end of a translation unit

NoQ added inline comments. Comment at: clang/lib/Sema/AnalysisBasedWarnings.cpp:2340 + if (Node->doesThisDeclarationHaveABody()) +checkUnsafeBufferUsage(Node); + return true; This code will grow bigger when more warnings are added, and it's

[PATCH] D150326: [WPD] Update llvm.public.type.test after importing functions

aeubanks accepted this revision. aeubanks added inline comments. This revision is now accepted and ready to land. Comment at: llvm/test/ThinLTO/X86/public-type-test.ll:31 ; HIDDEN-NOT: call {{.*}}@llvm.public.type.test ; HIDDEN: call {{.*}}@llvm.type.test

[PATCH] D148506: [C++] Don't filter using declaration when we perform qualified look up

ChuanqiXu updated this revision to Diff 521196. ChuanqiXu added a comment. Address comments and thank you for reviewing this! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148506/new/ https://reviews.llvm.org/D148506 Files: clang/lib/Sema/SemaDecl.cpp

[PATCH] D150181: [XCOFF][DWARF] XCOFF64 should be able to select the dwarf version under intergrated-as mode.

shchenz accepted this revision as: shchenz. shchenz added a comment. This revision is now accepted and ready to land. I think this is correct. DWARF spec indicates that DWARF64 should not be set as default. So it is right to change to DWARF32 by default for integrated-as mode for XCOFF64. LGTM

[PATCH] D150338: [-Wunsafe-buffer-usage][WIP] Improving insertion of the [[clang::unsafe_buffer_usage]] attribute

ziqingluo-90 created this revision. ziqingluo-90 added reviewers: jkorous, NoQ, malavikasamak, t-rasmud. Herald added a subscriber: jdoerfert. Herald added a project: All. ziqingluo-90 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. For

[PATCH] D146342: [-Wunsafe-buffer-usage] Move the whole analysis to the end of a translation unit

ziqingluo-90 updated this revision to Diff 521184. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146342/new/ https://reviews.llvm.org/D146342 Files: clang/include/clang/Sema/AnalysisBasedWarnings.h clang/lib/Sema/AnalysisBasedWarnings.cpp clang/lib/Sema/Sema.cpp

[PATCH] D148654: Modify BoundsSan to improve debuggability

oskarwirga updated this revision to Diff 521180. oskarwirga added a comment. Rebase on trunk :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148654/new/ https://reviews.llvm.org/D148654 Files: clang/lib/CodeGen/CGExpr.cpp

[PATCH] D146342: [-Wunsafe-buffer-usage] Move the whole analysis to the end of a translation unit

ziqingluo-90 updated this revision to Diff 521177. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146342/new/ https://reviews.llvm.org/D146342 Files: clang/include/clang/Sema/AnalysisBasedWarnings.h clang/lib/Sema/AnalysisBasedWarnings.cpp clang/lib/Sema/Sema.cpp

[PATCH] D146342: [-Wunsafe-buffer-usage] Move the whole analysis to the end of a translation unit

ziqingluo-90 updated this revision to Diff 521176. ziqingluo-90 added a comment. Clean up the code for early return in case of ignoring `unsafe_buffer_usage` warnings. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146342/new/ https://reviews.llvm.org/D146342 Files:

[PATCH] D150291: [Clang] Rename internal type identifier(s) for __bf16 to BF16Ty

codemzs added a comment. Thank you for pointing that out and for reviewing my code. I appreciate your guidance. I was following the LLVM contribution guidelines to use git clang-format, but I understand the importance of maintaining existing code styles that may be altered by git-clang format.

[PATCH] D150291: [Clang] Rename internal type identifier(s) for __bf16 to BF16Ty

codemzs updated this revision to Diff 521163. codemzs marked 4 inline comments as done. codemzs retitled this revision from "[Clang] Rename internal type identifier(s) for `__bf16` to `BF16Ty`" to "[Clang] Rename internal type identifier(s) for __bf16 to BF16Ty". codemzs added a comment. PR

[PATCH] D150325: WIP: Prototype #ifdef-enforced DEPENDS on tablegen output

jroelofs added a comment. link back to the discourse thread: https://discourse.llvm.org/t/rfc-permanently-fixing-the-missing-tablegen-dependency-issue/70442/14?u=jroelofs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150325/new/

[PATCH] D150326: [WPD] Update llvm.public.type.test after importing functions

tejohnson created this revision. tejohnson added a reviewer: aeubanks. Herald added subscribers: ormris, steven_wu, hiraditya, emaste. Herald added a project: All. tejohnson requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added projects: clang, LLVM. I

[PATCH] D150325: WIP: Prototype #ifdef-enforced DEPENDS on tablegen output

jroelofs created this revision. Herald added subscribers: steakhal, wenlei, martong, arphaman, hiraditya. Herald added a reviewer: NoQ. Herald added a reviewer: ributzka. Herald added a project: All. jroelofs requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits,

[PATCH] D150291: [Clang] Rename internal type identifier(s) for `__bf16` to `BF16Ty`

tahonermann requested changes to this revision. tahonermann added a comment. This revision now requires changes to proceed. This looks great, thank you for doing this! Requested changes are just to undo some of the style changes. Comment at:

[PATCH] D150320: [clang][deps] Avoid relocatable modules checks

benlangmuir accepted this revision. benlangmuir added a comment. This revision is now accepted and ready to land. With my naming comment addressed, LGTM Comment at: clang/include/clang/Lex/PreprocessorOptions.h:73 + /// Perform extra checks for relocatable modules when

[PATCH] D150319: [clang][deps] Always use -fmodules-validate-once-per-build-session

benlangmuir added inline comments. Comment at: clang/lib/Tooling/DependencyScanning/DependencyScanningService.cpp:26 + ? BuildSessionTimestamp + : std::chrono::system_clock::now().time_since_epoch().count()) { // Initialize targets for object file

[PATCH] D150318: [clang][deps] NFC: Pass around the whole scanning service

benlangmuir added inline comments. Comment at: clang/include/clang/Tooling/DependencyScanning/DependencyScanningService.h:69 + /// The preprocessing mode used for scanning. + ScanningMode Mode; + /// The output format. Why drop `const`?

[PATCH] D150140: [NFC][CLANG] Fix Static Code Analysis Concerns

Manna marked an inline comment as done. Manna added a comment. In D150140#4333552 , @tahonermann wrote: > Looks good to me! Thank you @tahonermann for reviews! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150140/new/

[PATCH] D149718: [NFC][Clang] Fix Coverity issues of copy without assign

Manna added a comment. In D149718#4333563 , @tahonermann wrote: > Looks good. Thanks @Manna! Thank you @tahonermann for reviews! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149718/new/ https://reviews.llvm.org/D149718

[PATCH] D149718: [NFC][Clang] Fix Coverity issues of copy without assign

tahonermann accepted this revision. tahonermann added a comment. This revision is now accepted and ready to land. Looks good. Thanks @Manna! Comment at: clang/include/clang/Sema/Sema.h:1786 SemaDiagnosticBuilder(SemaDiagnosticBuilder &); +SemaDiagnosticBuilder

[PATCH] D150321: [clang] Document extensions from later standards

philnik created this revision. philnik added a reviewer: aaron.ballman. Herald added a project: All. philnik requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D150321 Files:

[PATCH] D150140: [NFC][CLANG] Fix Static Code Analysis Concerns

tahonermann accepted this revision. tahonermann added a comment. This revision is now accepted and ready to land. Looks good to me! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150140/new/ https://reviews.llvm.org/D150140 ___ cfe-commits

[PATCH] D150320: [clang][deps] Avoid relocatable modules checks

jansvoboda11 created this revision. jansvoboda11 added reviewers: benlangmuir, Bigcheese. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Currently, `ASTReader`

[PATCH] D150319: [clang][deps] Always use -fmodules-validate-once-per-build-session

jansvoboda11 created this revision. jansvoboda11 added reviewers: benlangmuir, Bigcheese. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The dependency scanner

[PATCH] D150318: [clang][deps] NFC: Pass around the whole scanning service

jansvoboda11 created this revision. jansvoboda11 added reviewers: benlangmuir, Bigcheese. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Adding new field into

[PATCH] D147266: [AArch64] Add IR intrinsics for vbsl* C intrinsics

pranavk updated this revision to Diff 521115. pranavk added a comment. [AArch64] Change shouldSinkOperand to allow bitselect instructions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147266/new/ https://reviews.llvm.org/D147266 Files:

[PATCH] D147266: [AArch64] Add IR intrinsics for vbsl* C intrinsics

pranavk updated this revision to Diff 521114. pranavk added a comment. [AArch64][InstCombine] Bail out for bitselect instructions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147266/new/ https://reviews.llvm.org/D147266 Files:

[PATCH] D150295: [MemProf] Update hot/cold information after importing

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9e280c47588b: [MemProf] Update hot/cold information after importing (authored by tejohnson). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 9e280c4 - [MemProf] Update hot/cold information after importing

Author: Teresa Johnson Date: 2023-05-10T14:58:35-07:00 New Revision: 9e280c47588bfaf008a5fb091cd47df92b9c4264 URL: https://github.com/llvm/llvm-project/commit/9e280c47588bfaf008a5fb091cd47df92b9c4264 DIFF:

[PATCH] D147844: [clang][Sema]Print diagnostic warning about precedence when integer expression is used without parentheses in an conditional operator expression

ldionne accepted this revision as: libc++abi. ldionne added a comment. This revision is now accepted and ready to land. Code changes in libc++ and libc++abi LGTM. I am neutral on whether the diagnostic is worth adding, but don't consider libc++ and libc++abi as blockers for this patch.

[PATCH] D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method

rjmccall added a comment. > Okay, so I did add that in TokenKinds.h. Isn't that the right place for it? > The same way it's done for the other builtins? And in TokenKinds.def I added > the lines for the interesting identifiers? What you're doing in `TokenKinds.{def,h}` seems fine. What I'm

[PATCH] D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method

zahiraam added a comment. In D146148#4330971 , @rjmccall wrote: > In D146148#4330611 , @zahiraam > wrote: > >> In D146148#4221651 , @rjmccall >> wrote: >> >>> In

[PATCH] D150295: [MemProf] Update hot/cold information after importing

davidxl accepted this revision. davidxl added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150295/new/ https://reviews.llvm.org/D150295

[PATCH] D150209: [clang][Interp] Add more shift error checking

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/AST/Interp/Interp.h:141-142 + + // C++2a [expr.shift]p2: E1 << E2 is the unique value congruent to + // E1 x 2^E2 module 2^N. +

[PATCH] D150140: [NFC][CLANG] Fix Static Code Analysis Concerns

Manna marked an inline comment as done. Manna added inline comments. Comment at: clang/utils/TableGen/SveEmitter.cpp:302 unsigned Shift = llvm::countr_zero(Mask); + assert(Shift >= 64 && "Shift is out of encodable range"); return (V << Shift) & Mask;

[PATCH] D150140: [NFC][CLANG] Fix Static Code Analysis Concerns

Manna updated this revision to Diff 521089. Manna added a comment. Fix Coverity complain about shift overflow issue CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150140/new/ https://reviews.llvm.org/D150140 Files: clang/utils/TableGen/SveEmitter.cpp Index:

[PATCH] D150295: [MemProf] Update hot/cold information after importing

tejohnson created this revision. tejohnson added a reviewer: davidxl. Herald added subscribers: ormris, steven_wu, hiraditya. Herald added a project: All. tejohnson requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: cfe-commits. The support added by

[clang] 642bd11 - [Headers][doc] Add "shift" intrinsic descriptions to avx2intrin.h

Author: Paul Robinson Date: 2023-05-10T13:14:41-07:00 New Revision: 642bd1123d05e594cd0ef1527516f421ac07c5a6 URL: https://github.com/llvm/llvm-project/commit/642bd1123d05e594cd0ef1527516f421ac07c5a6 DIFF: https://github.com/llvm/llvm-project/commit/642bd1123d05e594cd0ef1527516f421ac07c5a6.diff

[PATCH] D150278: [Headers][doc] Add "shift" intrinsic descriptions to avx2intrin.h

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG642bd1123d05: [Headers][doc] Add shift intrinsic descriptions to avx2intrin.h (authored by probinson). Herald added a project: clang. Repository:

[PATCH] D150209: [clang][Interp] Add more shift error checking

tbaeder updated this revision to Diff 521082. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150209/new/ https://reviews.llvm.org/D150209 Files: clang/lib/AST/Interp/Integral.h clang/lib/AST/Interp/Interp.h clang/test/AST/Interp/shifts.cpp Index: clang/test/AST/Interp/shifts.cpp

[PATCH] D150209: [clang][Interp] Add more shift error checking

tbaeder updated this revision to Diff 521078. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150209/new/ https://reviews.llvm.org/D150209 Files: clang/lib/AST/Interp/Integral.h clang/lib/AST/Interp/Interp.h clang/test/AST/Interp/shifts.cpp Index: clang/test/AST/Interp/shifts.cpp

[PATCH] D150292: [clang][modules] Serialize `Module::DefinitionLoc`

jansvoboda11 created this revision. jansvoboda11 added reviewers: benlangmuir, Bigcheese. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is a prep patch

[PATCH] D150291: [Clang] Rename internal type identifier(s) for `__bf16` to `BF16Ty`

codemzs created this revision. codemzs added reviewers: tahonermann, erichkeane, stuij. Herald added subscribers: mattd, gchakrabarti, asavonic, ctetreau, kerbowa, arphaman, kristof.beyls, jvesely. Herald added a project: All. codemzs requested review of this revision. Herald added subscribers:

[PATCH] D149718: [NFC][Clang] Fix Coverity issues of copy without assign

Manna added inline comments. Comment at: clang/include/clang/Sema/Sema.h:1786 SemaDiagnosticBuilder(SemaDiagnosticBuilder &); +SemaDiagnosticBuilder =(SemaDiagnosticBuilder &); SemaDiagnosticBuilder(const SemaDiagnosticBuilder &) = default;

[PATCH] D146520: [clang-tidy] Fix checks filter with warnings-as-errors

kiwixz added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146520/new/ https://reviews.llvm.org/D146520 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D149718: [NFC][Clang] Fix Coverity issues of copy without assign

Manna updated this revision to Diff 521073. Manna marked 2 inline comments as done. Manna added a comment. I have updated patch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149718/new/ https://reviews.llvm.org/D149718 Files: clang/include/clang/Analysis/BodyFarm.h

[PATCH] D144999: [Clang][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs.

oontvoo added a comment. @int3 @thakis, et al - friendly  :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144999/new/ https://reviews.llvm.org/D144999 ___ cfe-commits mailing list

[PATCH] D150285: Fix CRTP partial specialization instantiation crash.

alexander-shaposhnikov accepted this revision. alexander-shaposhnikov added a comment. This revision is now accepted and ready to land. LG CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150285/new/ https://reviews.llvm.org/D150285 ___

[PATCH] D150285: Fix CRTP partial specialization instantiation crash.

erichkeane created this revision. erichkeane added reviewers: alexander-shaposhnikov, clang-language-wg. Herald added a project: All. erichkeane requested review of this revision. Fixes #60778. When instantiating the body of a class template specialization that was instantiated from a partial

[PATCH] D150282: [Driver] -ftime-trace: derive trace file names from -o and -dumpdir

MaskRay created this revision. MaskRay added reviewers: clang, jamieschmeiser, Whitney, Maetveis, dblaikie, scott.linder. Herald added a project: All. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Inspired by D133662

[PATCH] D147266: [AArch64] Add IR intrinsics for vbsl* C intrinsics

pranavk planned changes to this revision. pranavk added a comment. I agree. I changed the implementation to not introduce the intrinsic. I will need another change in InstCombine to handle case #1 mentioned on github bug report. I will have separate patch for it changing InstCombine. Thanks

[PATCH] D147266: [AArch64] Add IR intrinsics for vbsl* C intrinsics

pranavk updated this revision to Diff 521040. pranavk edited the summary of this revision. pranavk added a comment. Change shouldSinkOperand to allow backend to generate bitselect instructions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D146764: [clang] Make predefined expressions string literals under -fms-extensions

This revision was automatically updated to reflect the committed changes. Closed by commit rG878e590503df: Reland [clang] Make predefined expressions string literals under -fms-extensions (authored by aeubanks). Changed prior to commit: https://reviews.llvm.org/D146764?vs=520204=521039#toc

[clang] 878e590 - Reland [clang] Make predefined expressions string literals under -fms-extensions

Author: Arthur Eubanks Date: 2023-05-10T10:54:58-07:00 New Revision: 878e590503dff0d9097e91c2bec4409f14503b82 URL: https://github.com/llvm/llvm-project/commit/878e590503dff0d9097e91c2bec4409f14503b82 DIFF:

[PATCH] D140275: [clangd] Tweak to add doxygen comment to the function declaration

dgoldman added a comment. In D140275#4203456 , @tupos wrote: > Could you please also advice me what else need to be done for the ObjC, since > there were many years since I wrote ObjC last time I'm not sure what else > need to be done there. > >

[PATCH] D143675: Discussion: Darwin Sanitizers Stable ABI

rsundahl added a comment. In D143675#4330599 , @thetruestblue wrote: > Small insignificant note from me: When this lands, please be sure to add me > as co-author. > https://github.blog/2018-01-29-commit-together-with-co-authors/ I've not seen this

[PATCH] D143675: Discussion: Darwin Sanitizers Stable ABI

rsundahl added a comment. In D143675#4310903 , @eugenis wrote: > I'm fine with it in general. Is asan_abi.cpp meant as a temporary stub? It's > not even link anywhere in the current version. Right, we should be using it... We will add a test that

[PATCH] D150278: [Headers][doc] Add "shift" intrinsic descriptions to avx2intrin.h

goldstein.w.n accepted this revision. goldstein.w.n added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150278/new/ https://reviews.llvm.org/D150278 ___ cfe-commits mailing

[PATCH] D149802: [clang][modules] Avoid unnecessary writes of .timestamp files

This revision was automatically updated to reflect the committed changes. Closed by commit rG63eb04a36839: [clang][modules] Avoid unnecessary writes of .timestamp files (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 63eb04a - [clang][modules] Avoid unnecessary writes of .timestamp files

Author: Jan Svoboda Date: 2023-05-10T10:41:33-07:00 New Revision: 63eb04a3683996db26dbf1534682c5696d93b080 URL: https://github.com/llvm/llvm-project/commit/63eb04a3683996db26dbf1534682c5696d93b080 DIFF: https://github.com/llvm/llvm-project/commit/63eb04a3683996db26dbf1534682c5696d93b080.diff

[PATCH] D150278: [Headers][doc] Add "shift" intrinsic descriptions to avx2intrin.h

probinson created this revision. probinson added reviewers: pengfei, RKSimon, goldstein.w.n, craig.topper. Herald added a project: All. probinson requested review of this revision. https://reviews.llvm.org/D150278 Files: clang/lib/Headers/avx2intrin.h Index: clang/lib/Headers/avx2intrin.h

[PATCH] D149573: [Clang][C++23] Implement core language changes from P1467R9 extended floating-point types and standard names and introduce Bfloat16 arithmetic type.

codemzs marked an inline comment as done. codemzs added a comment. In D149573#4332549 , @tahonermann wrote: > I reviewed about a third of this, but then stopped due to the `__bf16` vs > `std::bfloat16_t` naming issues. I think the existing names that

[PATCH] D149495: [RISCV] Add support for V extension in SiFive7

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1a855819a87f: [RISCV] Add support for V extenstion in SiFive7 (authored by michaelmaitland). Changed prior to commit:

[clang] d747f82 - libclang: add missing `struct` in the declaration

Author: Saleem Abdulrasool Date: 2023-05-10T10:31:53-07:00 New Revision: d747f8277b386059a74dee062295aa8d864398fc URL: https://github.com/llvm/llvm-project/commit/d747f8277b386059a74dee062295aa8d864398fc DIFF:

[PATCH] D103930: [clang][HeaderSearch] Fix implicit module when using header maps

iana added a comment. I wonder if clang should have better module interaction with the header maps produced by Xcode, or if Xcode should produce better header maps to work with clang. Or are you having problems with header maps outside of Xcode? Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D103930: [clang][HeaderSearch] Fix implicit module when using header maps

iana added inline comments. Comment at: clang/test/Modules/implicit-module-header-maps.cpp:52 +//header and trip a `#error`, or +// 2) header maps aren't usesd, as the header name doesn't exist and relies on +//the header map to remap it to the real header.

[PATCH] D149573: [Clang][C++23] Implement core language changes from P1467R9 extended floating-point types and standard names and introduce Bfloat16 arithmetic type.

tahonermann requested changes to this revision. tahonermann added a comment. This revision now requires changes to proceed. I reviewed about a third of this, but then stopped due to the `__bf16` vs `std::bfloat16_t` naming issues. I think the existing names that use "bfloat16" to support the

[PATCH] D149495: [RISCV] Add support for V extension in SiFive7

michaelmaitland added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVScheduleV.td:41 +// Helper function to get the largest LMUL from MxList +// Precondition: MxList is sorted in ascending LMUL order. pcwang-thead wrote: > So, are we going to discard

[PATCH] D149495: [RISCV] Add support for V extension in SiFive7

michaelmaitland updated this revision to Diff 521024. michaelmaitland marked 2 inline comments as done. michaelmaitland added a comment. Use defvar in subroutines. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149495/new/

[clang] ce5ad23 - libclang: declare blocks interfaces always

Author: Saleem Abdulrasool Date: 2023-05-10T10:00:25-07:00 New Revision: ce5ad23ac29bb70427dd22d9ee480d22e0aa6cf1 URL: https://github.com/llvm/llvm-project/commit/ce5ad23ac29bb70427dd22d9ee480d22e0aa6cf1 DIFF:

[PATCH] D150192: Allow clang to emit inrange metadata when generating code for array subscripts

efriedma added a comment. See D115274 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150192/new/ https://reviews.llvm.org/D150192 ___ cfe-commits mailing list

[PATCH] D149997: [clang] [test] Narrow down MSVC specific behaviours from "any windows" to only MSVC/clang-cl

mstorsjo added a comment. In D149997#4331937 , @thakis wrote: > This broke check-clang on windows: http://45.33.8.238/win/78359/step_7.txt > > (The Driver/split-debug.c failure is something else and since fixed, but the > other two tests are due to this

[PATCH] D146418: Support for OpenMP 5.0 sec 2.12.7 - Declare Target initializer expressions

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:23106-23107 + it != Ex->child_end(); ++it) { + if (isa(*it)) +VisitExpr(dyn_cast(*it)); + if (isa(*it)) Why just a regular Visit does not work here? Plus, isa +

[PATCH] D149986: AMDGPU: Force sc0 and sc1 on stores for gfx940 and gfx941

kzhuravl marked an inline comment as done. kzhuravl added inline comments. Comment at: llvm/lib/Target/AMDGPU/SIMemoryLegalizer.cpp:524 + SIAtomicAddrSpace::NONE) + return enableSC0Bit(MI) | enableSC1Bit(MI); +return false; jmmartinez wrote: >

[PATCH] D146418: Support for OpenMP 5.0 sec 2.12.7 - Declare Target initializer expressions

RitanyaB added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:23094-23095 +public: + SmallVector DeclVector; + Decl *TargetDecl; + void VisitDeclRefExpr(const DeclRefExpr *Node) { ABataev wrote: > Why public? As the data members are accessed from

[PATCH] D146418: Support for OpenMP 5.0 sec 2.12.7 - Declare Target initializer expressions

RitanyaB updated this revision to Diff 521014. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146418/new/ https://reviews.llvm.org/D146418 Files: clang/include/clang/Sema/Sema.h clang/lib/Sema/SemaDecl.cpp clang/lib/Sema/SemaOpenMP.cpp

[PATCH] D149983: AMDGPU: Add basic gfx942 target

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9d0572797233: AMDGPU: Add basic gfx942 target (authored by kzhuravl). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D149982: AMDGPU: Add basic gfx941 target

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1fc70210a6a5: AMDGPU: Add basic gfx941 target (authored by kzhuravl). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 9d05727 - AMDGPU: Add basic gfx942 target

Author: Konstantin Zhuravlyov Date: 2023-05-10T11:51:06-04:00 New Revision: 9d0572797233857397f3fdc35fffcfb490354f56 URL: https://github.com/llvm/llvm-project/commit/9d0572797233857397f3fdc35fffcfb490354f56 DIFF:

[clang] 1fc7021 - AMDGPU: Add basic gfx941 target

Author: Konstantin Zhuravlyov Date: 2023-05-10T11:51:06-04:00 New Revision: 1fc70210a6a585bad941f64bd3fca7909eeafdda URL: https://github.com/llvm/llvm-project/commit/1fc70210a6a585bad941f64bd3fca7909eeafdda DIFF:

[PATCH] D149158: [clang][analyzer] Cleanup tests of StdCLibraryFunctionsChecker (NFC)

balazske added inline comments. Comment at: clang/test/Analysis/Inputs/std-c-library-functions.h:1-2 +typedef typeof(sizeof(int)) size_t; +typedef signed long ssize_t; +typedef struct { steakhal wrote: > balazske wrote: > > steakhal wrote: > > > `ssize_t`'s size

[PATCH] D146809: [clang-repl] Implement Value pretty printing

junaire updated this revision to Diff 520998. junaire added a comment. Export symbols in Windows. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146809/new/ https://reviews.llvm.org/D146809 Files: clang/include/clang/Interpreter/Interpreter.h

[PATCH] D150221: Add option -fkeep-static-variables to emit all static variables

hubert.reinterpretcast added a comment. In D150221#4332142 , @erichkeane wrote: >> This is intended to prevent "excessive transformation" to enable migration >> of existing applications (using a non-Clang compiler) where users further >> manipulate

[PATCH] D127910: [Clang][AArch64][SME] Add vector load/store (ld1/st1) intrinsics

sdesmalen added inline comments. Comment at: clang/lib/Basic/Targets/AArch64.cpp:726 -if (Feature == "+sme") { - HasSME = true; Why did you remove this? Comment at: clang/test/CodeGen/aarch64-sme-intrinsics/acle_sme_ld1.c:16 +//

[PATCH] D149997: [clang] [test] Narrow down MSVC specific behaviours from "any windows" to only MSVC/clang-cl

thakis added a comment. Fails with cmake too: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket/8781510258907322449/+/u/package_clang/stdout?format=raw Reverted in 56bac6c87a2d9046dbac36aae4910b4b90edf643

[clang] 56bac6c - Revert "[clang] [test] Narrow down MSVC specific behaviours from "any windows" to only MSVC/clang-cl"

Author: Nico Weber Date: 2023-05-10T16:49:18+02:00 New Revision: 56bac6c87a2d9046dbac36aae4910b4b90edf643 URL: https://github.com/llvm/llvm-project/commit/56bac6c87a2d9046dbac36aae4910b4b90edf643 DIFF: https://github.com/llvm/llvm-project/commit/56bac6c87a2d9046dbac36aae4910b4b90edf643.diff

[clang] ddfb974 - Add support of the next Ubuntu (Ubuntu 23.10 - Mantic Minotaur)

Author: Sylvestre Ledru Date: 2023-05-10T16:31:53+02:00 New Revision: ddfb974d0fca62e3eaeb98b79b5e29738c9082d2 URL: https://github.com/llvm/llvm-project/commit/ddfb974d0fca62e3eaeb98b79b5e29738c9082d2 DIFF:

[PATCH] D149562: [clang-format] Stop comment disrupting indentation of Verilog ports

sstwcw added a comment. > IMO a trailing comment (empty or not) belongs to the code before it. There is only a parenthesis before it. It doesn't usually need a comment. It is like in 5a61139. One doesn't tend to comment a single brace. > A comment about the code below it should start on a

[PATCH] D149612: [Sema] avoid merge error type

erichkeane added a comment. @aaron.ballman : Can you comment, particularly on the 'x2' and 'x3' examples here? I think our hackery here to get the AST back in a reasonable position here is unfortunate, and leads to some pretty awkward errors. I'm not sure what else we could do? We can't

[PATCH] D150221: Add option -fkeep-static-variables to emit all static variables

erichkeane added a subscriber: aaron.ballman. erichkeane added a comment. In D150221#4330534 , @hubert.reinterpretcast wrote: > In D150221#4330504 , @MaskRay wrote: > >> Can you give a more compelling reason

  1   2   >