[PATCH] D150537: [Clang][LoongArch] Pass the -mabi and -target-abi options to as and cc1as respectively

SixWeining created this revision. SixWeining added reviewers: xen0n, xry111, MaskRay, hev, wangleiat. Herald added a project: All. SixWeining requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change is necessary to set correct EFlags

[PATCH] D150282: [Driver] -ftime-trace: derive trace file names from -o and -dumpdir

Jake-Egan added a comment. Hi, this fails on AIX. It looks like it still produces the `/tmp/lit-tmp-*/[ab]-*.json` format. Can you take a look please? https://lab.llvm.org/buildbot/#/builders/214/builds/7429/steps/6/logs/FAIL__Clang__ftime-trace_cpp Repository: rG LLVM Github Monorepo

[clang] 25dc215 - [AIX][tests] XFAIL -ftime-trace test for now

Author: Jake Egan Date: 2023-05-15T01:41:27-04:00 New Revision: 25dc215ddaa6cb3e206858008fe4bc6844ea0d9c URL: https://github.com/llvm/llvm-project/commit/25dc215ddaa6cb3e206858008fe4bc6844ea0d9c DIFF: https://github.com/llvm/llvm-project/commit/25dc215ddaa6cb3e206858008fe4bc6844ea0d9c.diff

[PATCH] D149718: [NFC][Clang] Fix Coverity issues of copy without assign

uabelho added a comment. Compiling with clang 15.0.5 I get the following warning/error with this patch: ../../clang/include/clang/Sema/ParsedAttr.h:705:18: error: explicitly defaulted move assignment operator is implicitly deleted [-Werror,-Wdefaulted-function-deleted] AttributePool

[PATCH] D146389: [clang-repl][CUDA] Initial interactive CUDA support for clang-repl

argentite updated this revision to Diff 522041. argentite added a comment. Remove the copy of CodeGenOpts in CodeGeneratorImpl Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146389/new/ https://reviews.llvm.org/D146389 Files:

[PATCH] D127910: [Clang][AArch64][SME] Add vector load/store (ld1/st1) intrinsics

bryanpkc updated this revision to Diff 522039. bryanpkc edited the summary of this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127910/new/ https://reviews.llvm.org/D127910 Files: clang/include/clang/Basic/BuiltinsNEON.def

[PATCH] D150352: [clang][dataflow] Don't analyze templated declarations.

mboehme updated this revision to Diff 522040. mboehme added a comment. Eliminate warnings for calling deprecated functions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150352/new/ https://reviews.llvm.org/D150352 Files:

[PATCH] D149946: [LoongArch] Define `ual` feature and override `allowsMisalignedMemoryAccesses`

xry111 added a comment. OTOH if the Linux kernel is expected to emulate UAL, -march=generic should be //allowed// to generate unaligned access instructions for Linux targets. Frankly I prefer this personally, But I'm not sure if it will be a good practice in general... Repository: rG LLVM

[PATCH] D149838: [clang][dataflow] Eliminate `SkipPast::ReferenceThenPointer`.

This revision was automatically updated to reflect the committed changes. mboehme marked an inline comment as done. Closed by commit rG48bc71505e03: [clang][dataflow] Eliminate `SkipPast::ReferenceThenPointer`. (authored by mboehme). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 48bc715 - [clang][dataflow] Eliminate `SkipPast::ReferenceThenPointer`.

Author: Martin Braenne Date: 2023-05-15T04:33:29Z New Revision: 48bc71505e03694caac6afb2431ff1157a2382a8 URL: https://github.com/llvm/llvm-project/commit/48bc71505e03694caac6afb2431ff1157a2382a8 DIFF: https://github.com/llvm/llvm-project/commit/48bc71505e03694caac6afb2431ff1157a2382a8.diff

[PATCH] D150352: [clang][dataflow] Don't analyze templated declarations.

mboehme updated this revision to Diff 522036. mboehme marked an inline comment as done. mboehme added a comment. Eliminate warning for use of deprecated function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150352/new/

[PATCH] D150524: [cmake] Disable GCC lifetime DSE

xry111 added a comment. Closing as https://reviews.llvm.org/rG626849c71e85d546a004cc91866beab610222194 is already landed and we just need to reopen D150505 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150524/new/ https://reviews.llvm.org/D150524

[clang] 62b5e55 - Revert "[Serialization] Don't try to complete the redeclaration chain in"

Author: Chuanqi Xu Date: 2023-05-15T11:19:17+08:00 New Revision: 62b5e55512d57b083ac07d40b41242c7116a3d20 URL: https://github.com/llvm/llvm-project/commit/62b5e55512d57b083ac07d40b41242c7116a3d20 DIFF: https://github.com/llvm/llvm-project/commit/62b5e55512d57b083ac07d40b41242c7116a3d20.diff

[clang] 245549c - [NFC][CLANG] Fix Static Code Analysis Concerns

Author: Manna, Soumi Date: 2023-05-14T20:07:24-07:00 New Revision: 245549c57517de3b8fa478512bb1ae4295215e31 URL: https://github.com/llvm/llvm-project/commit/245549c57517de3b8fa478512bb1ae4295215e31 DIFF: https://github.com/llvm/llvm-project/commit/245549c57517de3b8fa478512bb1ae4295215e31.diff

[PATCH] D150140: [NFC][CLANG] Fix Static Code Analysis Concerns

This revision was automatically updated to reflect the committed changes. Closed by commit rG245549c57517: [NFC][CLANG] Fix Static Code Analysis Concerns (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150140/new/

[PATCH] D150140: [NFC][CLANG] Fix Static Code Analysis Concerns

Manna added a comment. Thank you everyone for comments and reviews! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150140/new/ https://reviews.llvm.org/D150140 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D149718: [NFC][Clang] Fix Coverity issues of copy without assign

This revision was automatically updated to reflect the committed changes. Closed by commit rG5ebff1ac1b98: [NFC][Clang] Fix Coverity issues of copy without assign (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149718/new/

[clang] 5ebff1a - [NFC][Clang] Fix Coverity issues of copy without assign

Author: Manna, Soumi Date: 2023-05-14T19:49:28-07:00 New Revision: 5ebff1ac1b986c6b5317aaf5ab6c4830a711067a URL: https://github.com/llvm/llvm-project/commit/5ebff1ac1b986c6b5317aaf5ab6c4830a711067a DIFF: https://github.com/llvm/llvm-project/commit/5ebff1ac1b986c6b5317aaf5ab6c4830a711067a.diff

[clang-tools-extra] 626849c - [clang-tidy][test] Add trailing -- to suppress compile_commands.json read

Author: Fangrui Song Date: 2023-05-14T14:12:16-07:00 New Revision: 626849c71e85d546a004cc91866beab610222194 URL: https://github.com/llvm/llvm-project/commit/626849c71e85d546a004cc91866beab610222194 DIFF: https://github.com/llvm/llvm-project/commit/626849c71e85d546a004cc91866beab610222194.diff

[PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

bolshakov-a added inline comments. Comment at: clang/lib/AST/ItaniumMangle.cpp:4397 +// argument. +// As proposed in https://github.com/itanium-cxx-abi/cxx-abi/issues/111. +auto *SNTTPE = cast(E); efriedma wrote: > bolshakov-a wrote: > > erichkeane

[PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

bolshakov-a added inline comments. Comment at: clang/lib/AST/ItaniumMangle.cpp:4579 + if (CE->hasAPValueResult()) +mangleValueInTemplateArg(ParamType, CE->getResultAsAPValue(), false, + /*NeedExactType=*/true);

[PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

efriedma added inline comments. Comment at: clang/lib/AST/ItaniumMangle.cpp:4579 + if (CE->hasAPValueResult()) +mangleValueInTemplateArg(ParamType, CE->getResultAsAPValue(), false, + /*NeedExactType=*/true); I'm not

[PATCH] D150524: [cmake] Disable GCC lifetime DSE

MaskRay requested changes to this revision. MaskRay added a comment. This revision now requires changes to proceed. I think the correct fix for `trivially-destructible.cpp` is to append `--`. No `-p` or comment is needed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150524/new/

[PATCH] D150430: Implement BufferOverlap check for sprint/snprintf

ArnaudBienner updated this revision to Diff 522020. ArnaudBienner added a comment. Updating D150430 : Implement BufferOverlap check for sprint/snprintf Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150430/new/

[PATCH] D150430: Implement BufferOverlap check for sprint/snprintf

ArnaudBienner updated this revision to Diff 522019. ArnaudBienner added a comment. Updating D150430 : Implement BufferOverlap check for sprint/snprintf Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150430/new/

[PATCH] D150430: Implement BufferOverlap check for sprint/snprintf

ArnaudBienner updated this revision to Diff 522018. ArnaudBienner added a comment. Fix start index for sprintf ovlerap check + tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150430/new/ https://reviews.llvm.org/D150430 Files:

[PATCH] D150531: Fix start index for sprintf ovlerap check + tests

ArnaudBienner created this revision. Herald added subscribers: steakhal, martong, arphaman. Herald added a reviewer: NoQ. Herald added a project: All. ArnaudBienner requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM

[PATCH] D150530: [clang] Convert a few OpenMP tests to use opaque pointers

nikic accepted this revision. nikic added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/test/OpenMP/atomic_capture_codegen.cpp:868 -// CHECK: [[NEW_BF_VALUE:%.+]] = load i8, i8* [[BITCAST1]] -// CHECK: [[RES:%.+]] = cmpxchg i8*

[PATCH] D150530: [clang] Convert a few OpenMP tests to use opaque pointers

barannikov88 added inline comments. Comment at: clang/test/OpenMP/atomic_capture_codegen.cpp:868 -// CHECK: [[NEW_BF_VALUE:%.+]] = load i8, i8* [[BITCAST1]] -// CHECK: [[RES:%.+]] = cmpxchg i8* getelementptr inbounds (%struct.BitFields4_packed, %struct.BitFields4_packed*

[PATCH] D150528: [Clang] Fix the diagnoses when the argument to alignas is an incomplete type

yronglin updated this revision to Diff 522012. yronglin added a comment. Format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150528/new/ https://reviews.llvm.org/D150528 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Parse/Parser.h

[PATCH] D150083: [clang-format] ObjCPropertyAttributeOrder to sort ObjC property attributes

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/ObjCPropertyAttributeOrderFixerTest.cpp:156 + + for(auto const& Attribute: getAllObjCAttributes()) { +Style.ObjCPropertyAttributeOrder = { "FIRST", Attribute, "LAST" }; I'm not a

[PATCH] D150506: Migrate {starts,ends}with_insensitive to {starts,ends}_with_insensitive (NFC)

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. no concerns from the clang-format front. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150506/new/

[PATCH] D150528: [Clang] Fix the diagnoses when the argument to alignas is an incomplete type

yronglin updated this revision to Diff 522008. yronglin added a comment. Update ReleaseNotes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150528/new/ https://reviews.llvm.org/D150528 Files: clang/docs/ReleaseNotes.rst

[PATCH] D150528: [Clang] Fix the diagnoses when the argument to alignas is an incomplete type

yronglin created this revision. Herald added a project: All. yronglin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Signed-off-by: yronglin Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D150528 Files:

[PATCH] D149280: [clang-tidy] Add modernize-printf-to-std-print check

mikecrowe added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/FormatStringConverter.cpp:27 + using namespace clang; + if (const auto *BT = llvm::dyn_cast(Ty)) { +const bool result = (BT->getKind() == BuiltinType::Char_U || This apparently

[PATCH] D150520: [clang] Convert a few tests to opaque pointers

barannikov88 added a comment. Thanks. These were the lasts tests in these directories. The only one remaining is `clang/test/CodeGenOpenCL/opaque-ptr-spirv.cl`, I don't know what to do with it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D150520: [clang] Convert a few tests to opaque pointers

nikic accepted this revision. nikic added a comment. Still LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150520/new/ https://reviews.llvm.org/D150520 ___ cfe-commits mailing list

[PATCH] D150520: [clang] Convert a few tests to opaque pointers

barannikov88 added a comment. @nikic I converted a few more tests after approved the changes. Please take a look once more, or let me know if I should revert to the previous revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150520/new/

[PATCH] D150520: [clang] Convert a few tests to opaque pointers

nikic accepted this revision. nikic added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150520/new/ https://reviews.llvm.org/D150520 ___

[PATCH] D150524: [cmake] Disable GCC lifetime DSE

xry111 created this revision. Herald added subscribers: ekilmer, PiotrZSL, carlosgalvezp. Herald added a project: All. xry111 requested review of this revision. Herald added projects: LLVM, clang-tools-extra. Herald added subscribers: cfe-commits, llvm-commits. LLVM data structures like

[PATCH] D150520: [clang] Convert a few tests to opaque pointers

barannikov88 created this revision. Herald added subscribers: kerbowa, jvesely. Herald added a project: All. barannikov88 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D146809: [clang-repl] Implement Value pretty printing

junaire updated this revision to Diff 521985. junaire added a comment. Make and use our own std::void_t Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146809/new/ https://reviews.llvm.org/D146809 Files:

[PATCH] D147266: [AArch64] Sink operands to allow for bitselect instructions

dmgreen accepted this revision. dmgreen added a comment. This revision is now accepted and ready to land. Thanks. LGTM with a few extra suggestions. Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:14357 + // Non-mask operands of both Ands should also be in

[PATCH] D146809: [clang-repl] Implement Value pretty printing

junaire updated this revision to Diff 521981. junaire added a comment. - include to avoid incorrect lookup on Windows - Add `-Xcc -fno-delayed-template-parsing` to fix failure on Windows Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146809/new/

[PATCH] D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1

ychen updated this revision to Diff 521978. ychen added a comment. - Fix bitfield on Windows Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139837/new/ https://reviews.llvm.org/D139837 Files: clang/docs/ReleaseNotes.rst

[PATCH] D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1

cor3ntin added a comment. I think this is starting to look good, My biggest question is the remaining fixme, how much work would it be to do in this PR? Comment at: clang/include/clang/Sema/TemplateDeduction.h:237 + // C++ [over.match.class.deduct]p5.2: + // During

[PATCH] D148489: [clangd] Implement configs to stop clangd produce a certain semantic tokens

daiyousei-qz updated this revision to Diff 521977. daiyousei-qz added a comment. Fix format issue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148489/new/ https://reviews.llvm.org/D148489 Files: clang-tools-extra/clangd/Config.h