[PATCH] D150843: [clang][Diagnostics] Refactor printableTextForNextCharacter

tbaeder added inline comments. Comment at: clang/lib/Frontend/TextDiagnostic.cpp:120 - begin = reinterpret_cast(&*(SourceLine.begin() + *i)); - end = begin + (SourceLine.size() - *i); - I don't know what this computation of `end` means, but from the debug

[PATCH] D150843: [clang][Diagnostics] Refactor printableTextForNextCharacter

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, tahonermann. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Rename parameters and local variables to start with an uppercase

[PATCH] D150841: [IR] Make stack protector symbol dso_local according to -f[no-]direct-access-external-data

MaskRay created this revision. MaskRay added reviewers: ardb, nickdesaulniers, pengfei, xiangzhangllvm. Herald added subscribers: bd1976llvm, hiraditya, krytarowski, arichardson, nemanjai, emaste. Herald added a project: All. MaskRay requested review of this revision. Herald added projects:

[clang] 7bbe512 - [RISCV] Remove unneedded comment. NFC

Author: Craig Topper Date: 2023-05-17T22:49:28-07:00 New Revision: 7bbe512362edd1dbd3947ff71212f3ae815a0836 URL: https://github.com/llvm/llvm-project/commit/7bbe512362edd1dbd3947ff71212f3ae815a0836 DIFF: https://github.com/llvm/llvm-project/commit/7bbe512362edd1dbd3947ff71212f3ae815a0836.diff

[clang] 4acee5b - Revert "[clang][X86] Add __cpuidex function to cpuid.h"

Author: Aiden Grossman Date: 2023-05-18T05:37:48Z New Revision: 4acee5b5cfa462af66225acda7d3d9efe1036aa9 URL: https://github.com/llvm/llvm-project/commit/4acee5b5cfa462af66225acda7d3d9efe1036aa9 DIFF: https://github.com/llvm/llvm-project/commit/4acee5b5cfa462af66225acda7d3d9efe1036aa9.diff

[PATCH] D150840: [clang][NFC] Refactor emitSnippet()

tbaeder created this revision. tbaeder added a reviewer: aaron.ballman. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Rename parameters and local variables and reorder things a bit to be closer to

[PATCH] D150758: [AIX] make integrated-as as default on AIX.

shchenz added inline comments. Comment at: llvm/lib/MC/MCAsmInfoXCOFF.cpp:55 HasDotTypeDotSizeDirective = false; - UseIntegratedAssembler = false; + UseIntegratedAssembler = true; ParseInlineAsmUsingAsmParser = true; brad wrote: > Instead of setting the

[PATCH] D150645: [Driver] Support multi /guard: options

pengfei updated this revision to Diff 523256. pengfei added a comment. Sorry for the noise, I guess I missed a `A->claim()` here. Updated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150645/new/ https://reviews.llvm.org/D150645 Files:

[PATCH] D150690: [RISCV] Use IRBuilder::CreateInsertVector/CreateExtractVector to simplify code. NFC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG77f38e1325a2: [RISCV] Use IRBuilder::CreateInsertVector/CreateExtractVector to simplify code. (authored by craig.topper). Repository: rG LLVM

[clang] 77f38e1 - [RISCV] Use IRBuilder::CreateInsertVector/CreateExtractVector to simplify code. NFC

Author: Craig Topper Date: 2023-05-17T21:31:51-07:00 New Revision: 77f38e1325a251623ec39a0d9ffa718e80436f94 URL: https://github.com/llvm/llvm-project/commit/77f38e1325a251623ec39a0d9ffa718e80436f94 DIFF: https://github.com/llvm/llvm-project/commit/77f38e1325a251623ec39a0d9ffa718e80436f94.diff

[PATCH] D144829: [WIP][BPF] Add a few new insns under cpu=v4

yonghong-song updated this revision to Diff 523253. yonghong-song added a comment. - Fixed issues reported by Eduard - llvm-objdump issue (as stated in 'Summary') is not resolved yet. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144829/new/

[PATCH] D150646: [clang][X86] Add __cpuidex function to cpuid.h

glandium added a comment. Repro: $ echo '#include "cpuid.h"' | ./clang/bin/clang-cl -Tp - clang-cl: warning: unable to find a Visual Studio installation; try running Clang from a developer command prompt [-Wmsvc-not-found] In file included from :1:

[PATCH] D150730: [Clang][Sema] Substitute constraints only for declarations with different lexical contexts

shafik added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:783 return true; - if (Old && New && Old != New) { + if (Old && New && Old != New && + Old->getLexicalDeclContext() != New->getLexicalDeclContext()) { shafik wrote: > erichkeane

[PATCH] D150646: [clang][X86] Add __cpuidex function to cpuid.h

glandium added a comment. This causes errors like: /builds/worker/fetches/clang/lib/clang/17/include/cpuid.h(331,22): error: definition of builtin function '__cpuidex' static __inline void __cpuidex (int __cpu_info[4], int __leaf, int __subleaf) ^ 1 error

[PATCH] D150690: [RISCV] Use IRBuilder::CreateInsertVector/CreateExtractVector to simplify code. NFC

eopXD accepted this revision. eopXD added a comment. This revision is now accepted and ready to land. Looks good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150690/new/ https://reviews.llvm.org/D150690

[PATCH] D146358: [clang][AST] Print name instead of type when diagnosing uninitialized subobject in constexpr variables

hazohelet added a comment. In D146358#4350810 , @erichkeane wrote: > Our downstream discovered that this causes a regression when compiling > `utility` with `ast-dump`. I've put up a minimal reproducer: > https://godbolt.org/z/oaezas7Ws > >

[PATCH] D129824: [RISCV] Set triple based on -march flag which can be deduced in more generic way

zixuan-wu abandoned this revision. zixuan-wu added a comment. Herald added subscribers: jobnoorman, luke. As this issue is solved at https://reviews.llvm.org/D148124, abandon this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129824/new/ https://reviews.llvm.org/D129824

[PATCH] D148124: [RISCV][Driver] Allow the use of CPUs with a different XLEN than the triple.

zixuan-wu added a comment. Thx. It has solved the issue D129824 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148124/new/ https://reviews.llvm.org/D148124 ___

[PATCH] D150614: [clang-format] Ignore first token when finding MustBreak

This revision was automatically updated to reflect the committed changes. Closed by commit rG06763ea5d8f9: [clang-format] Ignore first token when finding MustBreak (authored by rymiel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150614/new/

[clang] 06763ea - [clang-format] Ignore first token when finding MustBreak

Author: Emilia Kond Date: 2023-05-18T05:50:26+03:00 New Revision: 06763ea5d8f96625545bb2c2445363aca9922bf1 URL: https://github.com/llvm/llvm-project/commit/06763ea5d8f96625545bb2c2445363aca9922bf1 DIFF: https://github.com/llvm/llvm-project/commit/06763ea5d8f96625545bb2c2445363aca9922bf1.diff

[PATCH] D143675: Discussion: Darwin Sanitizers Stable ABI

MaskRay added inline comments. Comment at: compiler-rt/docs/ASanABI.rst:29 + + Following are some examples of reasonable responses to such changes: + How does the 2-space indentation render in the built HTML? It may look good, I ask just in case.

[PATCH] D148094: [clang][CodeGen] Break up TargetInfo.cpp [8/8]

barannikov88 updated this revision to Diff 523240. barannikov88 added a comment. Undo remaining unintended formatting changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148094/new/ https://reviews.llvm.org/D148094 Files:

[PATCH] D150411: [NFC][Clang][Coverity] Fix Static Code Analysis Concerns with copy without assign

tahonermann added inline comments. Comment at: clang/include/clang/Sema/Sema.h:1790 SemaDiagnosticBuilder(const SemaDiagnosticBuilder &) = default; +SemaDiagnosticBuilder =(const SemaDiagnosticBuilder &) = delete; ~SemaDiagnosticBuilder();

[PATCH] D150758: [AIX] make integrated-as as default on AIX.

brad added inline comments. Comment at: llvm/lib/MC/MCAsmInfoXCOFF.cpp:55 HasDotTypeDotSizeDirective = false; - UseIntegratedAssembler = false; + UseIntegratedAssembler = true; ParseInlineAsmUsingAsmParser = true; Instead of setting the value to true you

[PATCH] D143675: Discussion: Darwin Sanitizers Stable ABI

rsundahl added a comment. Ping @kcc , @yln and @kubamracek Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143675/new/ https://reviews.llvm.org/D143675 ___ cfe-commits mailing list

[PATCH] D143675: Discussion: Darwin Sanitizers Stable ABI

rsundahl added a comment. @MaskRay, thank you for your approval. @eugenis, you were added as a blocking reviewer by @vitalybuka. If you are still without objection, can we get your approval and merge? Thank you all for your input. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D148785: -fsanitize=function: use type hashes instead of RTTI objects

MaskRay added inline comments. Comment at: llvm/test/CodeGen/AArch64/patchable-function-entry-bti.ll:92 ; CHECK-NEXT: .Ltmp{{.*}}: ; CHECK-NEXT: nop ; CHECK-NEXT: .word 3238382334 // 0xc105cafe MaskRay wrote: > peter.smith wrote: > > samitolvanen

[PATCH] D148094: [clang][CodeGen] Break up TargetInfo.cpp [8/8]

barannikov88 updated this revision to Diff 523236. barannikov88 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148094/new/ https://reviews.llvm.org/D148094 Files: clang/docs/UsersManual.rst

[PATCH] D148093: [clang][CodeGen] Break up TargetInfo.cpp [5/8]

barannikov88 updated this revision to Diff 523235. barannikov88 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148093/new/ https://reviews.llvm.org/D148093 Files: clang/lib/CodeGen/ABIInfo.h

[PATCH] D148785: -fsanitize=function: use type hashes instead of RTTI objects

MaskRay marked 2 inline comments as done. MaskRay added inline comments. Comment at: clang/test/CodeGenCXX/catch-undef-behavior.cpp:408 // RTTI pointer check + // CHECK: [[CalleeTypeHashPtr:%.+]] = getelementptr <{ i32, i32 }>, <{ i32, i32 }>* [[PTR]], i32 -1, i32 1

[clang] 7971d91 - [clang][CodeGen] Reformat ABIInfo.h (NFC)

Author: Sergei Barannikov Date: 2023-05-18T04:29:16+03:00 New Revision: 7971d91bbf903b894936e663e67e03ffc0c29004 URL: https://github.com/llvm/llvm-project/commit/7971d91bbf903b894936e663e67e03ffc0c29004 DIFF:

[PATCH] D148785: -fsanitize=function: use type hashes instead of RTTI objects

MaskRay added inline comments. Comment at: llvm/test/CodeGen/AArch64/patchable-function-entry-bti.ll:92 ; CHECK-NEXT: .Ltmp{{.*}}: ; CHECK-NEXT: nop ; CHECK-NEXT: .word 3238382334 // 0xc105cafe peter.smith wrote: > samitolvanen wrote: > > peter.smith

[PATCH] D143967: [DebugInfo][BPF] Add 'btf:type_tag' annotation in DWARF

eddyz87 updated this revision to Diff 523233. eddyz87 added a comment. Fix for case when CVR qualifier is behind type ignored by UnwrapTypeForDebugInfo(). E.g. for the following example: const int *foo; typeof(*foo) __attribute__((btf_type_tag("tag"))) buz; Repository: rG LLVM Github

[PATCH] D148094: [clang][CodeGen] Break up TargetInfo.cpp [8/8]

barannikov88 updated this revision to Diff 523232. barannikov88 added a comment. Update BUILD.gn Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148094/new/ https://reviews.llvm.org/D148094 Files: clang/docs/UsersManual.rst

[PATCH] D150221: Add option -fkeep-static-variables to emit all static variables

hubert.reinterpretcast added a comment. In D150221#4351249 , @rjmccall wrote: > Force-emitting every `static` in the translation unit can be very expensive; > there are a lot of headers that declare all their constants as `static > const`. And

[PATCH] D148094: [clang][CodeGen] Break up TargetInfo.cpp [8/8]

barannikov88 updated this revision to Diff 523230. barannikov88 added a comment. Add a virtual destructor to DefaultABIInfo to pin the vtable to a cpp file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148094/new/ https://reviews.llvm.org/D148094

[PATCH] D150549: Move SubtargetFeature.h from MC to TargetParser

MaskRay accepted this revision. MaskRay added a comment. In D150549#4349531 , @jobnoorman wrote: > In D150549#4347056 , @MaskRay wrote: > >> This seems fine, but please consider making `MC/SubtargetFeature.h` a

[PATCH] D150833: [WebAssembly] Add wasm_simd128.h intrinsics for relaxed SIMD

tlively created this revision. tlively added reviewers: aheejin, dschuff. Herald added subscribers: pmatos, asb, wingo, ecnelises, sunfish, jgravelle-google, sbc100. Herald added a project: All. tlively requested review of this revision. Herald added a project: clang. Herald added a subscriber:

[PATCH] D148094: [clang][CodeGen] Break up TargetInfo.cpp [8/8]

barannikov88 updated this revision to Diff 523227. barannikov88 added a comment. Move complexTempStructure to its only user (PPC.cpp) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148094/new/ https://reviews.llvm.org/D148094 Files:

[clang] 3948aed - [clang] NFC: Modernize Decl iteration via IdentifierResolver

Author: Jan Svoboda Date: 2023-05-17T16:45:46-07:00 New Revision: 3948aedb7ab9a0626faccbe14624dbafeb2e3931 URL: https://github.com/llvm/llvm-project/commit/3948aedb7ab9a0626faccbe14624dbafeb2e3931 DIFF: https://github.com/llvm/llvm-project/commit/3948aedb7ab9a0626faccbe14624dbafeb2e3931.diff

[PATCH] D150689: [clang][DependencyScanner] Remove all warning flags when suppressing warnings

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: clang/test/ClangScanDeps/optimize-system-warnings.m:19 +// CHECK:], +// CHECK-NEXT: "name": "A" +// CHECK-NEXT:

[PATCH] D150829: [clang] Convert several tests to opaque pointers

barannikov88 added a comment. These did require some intellectual work. I've noted changes that might be worth noticing. Comment at: clang/test/CodeGenCXX/2011-12-19-init-list-ctor.cpp:22 +// CHECK: store i32 0, ptr @arr +// CHECK: call void @_ZN1AC1EPKc(ptr {{[^,]*}}

[PATCH] D150820: [NVPTX, CUDA] added optional src_size argument to __nvvm_cp_async*

tra created this revision. Herald added subscribers: mattd, gchakrabarti, asavonic, bixia, hiraditya. Herald added a project: All. tra updated this revision to Diff 523216. tra added a comment. tra retitled this revision from "[NVPTX] added src_size argument to __nvvm_cp_async* intrinsics." to

[PATCH] D150394: [OpenMP 5.2] Deprecate MINUS (-) operator on reduction clauses

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:10487-10488 "a reduction list item with incomplete type %0">; +def err_omp_reduction_minus_type : Error<

[PATCH] D150829: [clang] Convert several tests to opaque pointers

barannikov88 created this revision. barannikov88 added a reviewer: nikic. Herald added a subscriber: StephenFan. Herald added a project: All. barannikov88 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github

[clang] 71a35f7 - [gcov] Simplify cc1 options and remove CodeGenOptions EmitCovNotes/EmitCovArcs

Author: Fangrui Song Date: 2023-05-17T16:09:12-07:00 New Revision: 71a35f7e3d6c78f8035f2eb7d58beba3b7208f9d URL: https://github.com/llvm/llvm-project/commit/71a35f7e3d6c78f8035f2eb7d58beba3b7208f9d DIFF: https://github.com/llvm/llvm-project/commit/71a35f7e3d6c78f8035f2eb7d58beba3b7208f9d.diff

[PATCH] D150807: [Clang] Remove direct linking of offloading runtimes from the arch tools

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG66da9ec073ff: [Clang] Remove direct linking of offloading runtimes from the arch tools (authored by jhuber6). Repository: rG LLVM Github Monorepo

[clang] 66da9ec - [Clang] Remove direct linking of offloading runtimes from the arch tools

Author: Joseph Huber Date: 2023-05-17T17:47:49-05:00 New Revision: 66da9ec073ff8dde54b70adcf3b62914769324bf URL: https://github.com/llvm/llvm-project/commit/66da9ec073ff8dde54b70adcf3b62914769324bf DIFF: https://github.com/llvm/llvm-project/commit/66da9ec073ff8dde54b70adcf3b62914769324bf.diff

[PATCH] D150043: [InferAddressSpaces] Handle vector of pointers type & Support intrinsic masked gather/scatter

arsenm closed this revision. arsenm added a comment. 44096e6904e10bb313fef2f6aaff25c25d1325f7 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150043/new/ https://reviews.llvm.org/D150043

[clang] 3d7903f - Revert "[Driver] Support multi /guard: options"

Author: Arthur Eubanks Date: 2023-05-17T15:34:14-07:00 New Revision: 3d7903f1008febc80cb104eedcbcd31d2690839f URL: https://github.com/llvm/llvm-project/commit/3d7903f1008febc80cb104eedcbcd31d2690839f DIFF:

[PATCH] D150645: [Driver] Support multi /guard: options

aeubanks added a comment. this causes `./build/rel/bin/clang-cl /c /tmp/a.cc /Fo/tmp/a /guard:cf,nochecks` to go from no warnings to clang-cl: warning: argument unused during compilation: '/guard:cf,nochecks' [-Wunused-command-line-argument] Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D150689: [clang][DependencyScanner] Remove all warning flags when suppressing warnings

Bigcheese added inline comments. Comment at: clang/test/ClangScanDeps/optimize-system-warnings.m:19 +// CHECK:], +// CHECK-NEXT: "name": "A" +// CHECK-NEXT: }, jansvoboda11 wrote: > I'd like to see a check line that would fail if the

[PATCH] D150221: Add option -fkeep-static-variables to emit all static variables

rjmccall added a comment. The hot-patch use case actually shouldn't care if the compiler/linker throws away unused things because it can't possibly affect how the patch interoperates with existing code. This does rely on the unanalyzable-use part of the semantics, though, to stop the compiler

[PATCH] D150340: [SEH]:Fix assertion when try is used inside catch(...) block with /EHa

This revision was automatically updated to reflect the committed changes. Closed by commit rG691927c904ed: Fix assertion when try is used inside catch(...) block (authored by jyu2). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150340/new/

[clang] 691927c - Fix assertion when try is used inside catch(...) block

Author: Jennifer Yu Date: 2023-05-17T14:42:39-07:00 New Revision: 691927c904ede183461610387402f5c19dbb3de0 URL: https://github.com/llvm/llvm-project/commit/691927c904ede183461610387402f5c19dbb3de0 DIFF: https://github.com/llvm/llvm-project/commit/691927c904ede183461610387402f5c19dbb3de0.diff

[PATCH] D147266: [AArch64] Sink operands to allow for bitselect instructions

pranavk closed this revision. pranavk added a comment. > I noticed there was another instance of vbsl being reported recently in > https://github.com/llvm/llvm-project/issues/62642. Hopefully it can be > addresses via extra optimizations too. This is another InstCombine problem -- as soon as

[PATCH] D145265: [Pipeline] Remove GlobalCleanupPM

aeubanks added inline comments. Comment at: llvm/lib/Passes/PassBuilderPipelines.cpp:476 + FPM.addPass(EarlyCSEPass()); + nikic wrote: > Why the extra EarlyCSE pass in the `O1` pipeline? forgot to update the commit message, see that Comment

[PATCH] D145265: [Pipeline] Remove GlobalCleanupPM

aeubanks updated this revision to Diff 523182. aeubanks edited the summary of this revision. aeubanks added a comment. update commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145265/new/ https://reviews.llvm.org/D145265 Files:

[PATCH] D145265: [Pipeline] Remove GlobalCleanupPM

nikic added inline comments. Comment at: llvm/lib/Passes/PassBuilderPipelines.cpp:476 + FPM.addPass(EarlyCSEPass()); + Why the extra EarlyCSE pass in the `O1` pipeline? Comment at: llvm/lib/Passes/PassBuilderPipelines.cpp:547 +

[PATCH] D150670: [WebAssembly] Disable generation of fshl/fshr for rotates

nikic requested changes to this revision. nikic added a comment. This revision now requires changes to proceed. This doesn't looks like a wasm specific problem. You get essentially the same issue on any target that has a rotate instruction but no funnel shift instruction. Here are just a couple

[PATCH] D150730: [Clang][Sema] Substitute constraints only for declarations with different lexical contexts

This revision was automatically updated to reflect the committed changes. Closed by commit rG122b938944ce: [Clang][Sema] Substitute constraints only for declarations with different… (authored by alexander-shaposhnikov). Changed prior to commit:

[clang] 122b938 - [Clang][Sema] Substitute constraints only for declarations with different lexical contexts

Author: Alexander Shaposhnikov Date: 2023-05-17T21:24:44Z New Revision: 122b938944ceb966e04d7a4d253f7f9ba27c477d URL: https://github.com/llvm/llvm-project/commit/122b938944ceb966e04d7a4d253f7f9ba27c477d DIFF:

[PATCH] D145265: [Pipeline] Remove GlobalCleanupPM

aeubanks updated this revision to Diff 523175. aeubanks added a comment. rebase keep the existing EarlyCSE/InstCombine ordering Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145265/new/ https://reviews.llvm.org/D145265 Files:

[PATCH] D147920: [clang] Add test for CWG399

shafik accepted this revision. shafik added a comment. LGTM, apologies, it fell off my radar Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147920/new/ https://reviews.llvm.org/D147920 ___ cfe-commits

[PATCH] D150817: Use windows baskslash on anonymous tag locations if using MSVCFormatting and it's not absolute path.

zequanwu created this revision. zequanwu added a reviewer: hans. Herald added a project: All. zequanwu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This fixes a nondeterminism on debug info when building on windows natively vs cross

[PATCH] D100394: [Clang][NVPTX] Add NVPTX intrinsics and builtins for CUDA PTX cp.async instructions

tra added a comment. Hi. It looks like CUDA-11+ headers need a variant of cm.async intrinsics which provides the optional src_size argument. I'm planning to add it to the existing intrinsics in NVPTX. It's just a heads-up in case you may have existing uses of them that may need to be updated.

[PATCH] D148094: [clang][CodeGen] Break up TargetInfo.cpp [8/8]

barannikov88 updated this revision to Diff 523163. barannikov88 added a comment. Rebase & ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148094/new/ https://reviews.llvm.org/D148094 Files: clang/docs/UsersManual.rst

[PATCH] D150215: [clang][CodeGen] Break up TargetInfo.cpp [7/8]

barannikov88 updated this revision to Diff 523161. barannikov88 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150215/new/ https://reviews.llvm.org/D150215 Files: clang/lib/CodeGen/TargetInfo.cpp

[PATCH] D150178: [clang][CodeGen] Break up TargetInfo.cpp [6/8]

barannikov88 updated this revision to Diff 523160. barannikov88 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150178/new/ https://reviews.llvm.org/D150178 Files: clang/lib/CodeGen/TargetInfo.cpp

[PATCH] D148093: [clang][CodeGen] Break up TargetInfo.cpp [5/8]

barannikov88 updated this revision to Diff 523159. barannikov88 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148093/new/ https://reviews.llvm.org/D148093 Files: clang/lib/CodeGen/ABIInfo.h

[PATCH] D148092: [clang][CodeGen] Break up TargetInfo.cpp [4/8]

barannikov88 updated this revision to Diff 523158. barannikov88 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148092/new/ https://reviews.llvm.org/D148092 Files: clang/lib/CodeGen/TargetInfo.cpp

[PATCH] D148091: [clang][CodeGen] Break up TargetInfo.cpp [3/8]

barannikov88 updated this revision to Diff 523157. barannikov88 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148091/new/ https://reviews.llvm.org/D148091 Files: clang/lib/CodeGen/TargetInfo.cpp Index:

[PATCH] D148090: [clang][CodeGen] Break up TargetInfo.cpp [2/8]

barannikov88 updated this revision to Diff 523155. barannikov88 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148090/new/ https://reviews.llvm.org/D148090 Files: clang/lib/CodeGen/TargetInfo.cpp Index:

[PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

glandium added a comment. In D144509#4349051 , @hans wrote: > In D144509#4347562 , @glandium > wrote: > >> FYI, 65429b9af6a2c99d340ab2dcddd41dab201f399c >>

[PATCH] D148089: [clang][CodeGen] Break up TargetInfo.cpp [1/8]

barannikov88 updated this revision to Diff 523153. barannikov88 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148089/new/ https://reviews.llvm.org/D148089 Files: clang/lib/CodeGen/TargetInfo.cpp Index:

[PATCH] D150733: [clang] Convert remaining OpenMP tests to opaque pointers

This revision was automatically updated to reflect the committed changes. Closed by commit rG8be4bd16ca41: [clang] Convert remaining OpenMP tests to opaque pointers (authored by barannikov88). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D150670: [WebAssembly] Disable generation of fshl/fshr for rotates

pmatos added a comment. Ready for review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150670/new/ https://reviews.llvm.org/D150670 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D150670: [WebAssembly] Disable generation of fshl/fshr for rotates

pmatos updated this revision to Diff 523149. pmatos added a comment. Generate rotates for 64bits as well. Add tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150670/new/ https://reviews.llvm.org/D150670 Files:

[PATCH] D144999: [Clang][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs.

oontvoo added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144999/new/ https://reviews.llvm.org/D144999 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D144999: [Clang][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs.

oontvoo updated this revision to Diff 523148. oontvoo added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144999/new/ https://reviews.llvm.org/D144999 Files: clang/include/clang/Basic/CodeGenOptions.def

[PATCH] D144999: [Clang][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs.

oontvoo updated this revision to Diff 523147. oontvoo marked an inline comment as done. oontvoo edited the summary of this revision. oontvoo added a comment. updated comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144999/new/

[PATCH] D150744: [NFC][CLANG] Fix uninitialized scalar field issues found by Coverity

tahonermann added a comment. I'm not opposed to these changes, but please note that these changes mean is will no longer be possible to use ubsan to discover when these data members are used before having been assigned an appropriate value. That is only a concern when an appropriate value

[PATCH] D150221: Add option -fkeep-static-variables to emit all static variables

hubert.reinterpretcast added a comment. In D150221#4350761 , @rjmccall wrote: > I'm not sure if it's better to represent that by using > `__attribute__((used))` on every global variable or by setting something more > globally in the module. The latter

[PATCH] D139010: [clang][WebAssembly] Implement support for table types and builtins

tlively added a comment. It looks like the LLVM-side changes are generally moving Wasm type classification functions to a more global location. Since no other backend should care about these things, it would be better if we could get away without these changes. Comment at:

[clang] a825f37 - [CUDA] Relax restrictions on GPU-side variadic functions

Author: Artem Belevich Date: 2023-05-17T12:51:01-07:00 New Revision: a825f3754b3ca1591068cf99bc224af30a311e63 URL: https://github.com/llvm/llvm-project/commit/a825f3754b3ca1591068cf99bc224af30a311e63 DIFF:

[PATCH] D150718: [CUDA] Relax restrictions on GPU-side variadic functions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa825f3754b3c: [CUDA] Relax restrictions on GPU-side variadic functions (authored by tra). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] a07b135 - [Driver][gcov] Derive .gcno .gcda file names from -o and -dumpdir

Author: Fangrui Song Date: 2023-05-17T12:43:49-07:00 New Revision: a07b135ce0c0111bd83450b5dc29ef0381cdbc39 URL: https://github.com/llvm/llvm-project/commit/a07b135ce0c0111bd83450b5dc29ef0381cdbc39 DIFF: https://github.com/llvm/llvm-project/commit/a07b135ce0c0111bd83450b5dc29ef0381cdbc39.diff

[PATCH] D146358: [clang][AST] Print name instead of type when diagnosing uninitialized subobject in constexpr variables

erichkeane added a comment. Slightly smaller reproducer: https://godbolt.org/z/W5zjrKaz9 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146358/new/ https://reviews.llvm.org/D146358 ___ cfe-commits

[PATCH] D146358: [clang][AST] Print name instead of type when diagnosing uninitialized subobject in constexpr variables

erichkeane added a comment. Our downstream discovered that this causes a regression when compiling `utility` with `ast-dump`. I've put up a minimal reproducer: https://godbolt.org/z/oaezas7Ws @hazohelet : Will you be able to look into this soon? Repository: rG LLVM Github Monorepo

[PATCH] D150646: [clang][X86] Add __cpuidex function to cpuid.h

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG286cefcf35d0: [clang][X86] Add __cpuidex function to cpuid.h (authored by aidengrossman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 286cefc - [clang][X86] Add __cpuidex function to cpuid.h

Author: Aiden Grossman Date: 2023-05-17T19:38:28Z New Revision: 286cefcf35d0f55c57184c4219b95e82c96f1420 URL: https://github.com/llvm/llvm-project/commit/286cefcf35d0f55c57184c4219b95e82c96f1420 DIFF: https://github.com/llvm/llvm-project/commit/286cefcf35d0f55c57184c4219b95e82c96f1420.diff

[PATCH] D150646: [clang][X86] Add __cpuidex function to cpuid.h

aidengrossman added a comment. Thanks for the review! Definitely a little bit odd and it probably would've been better if originally replicated in some other way, but definitely agree on the matching behavior. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D150733: [clang] Convert remaining OpenMP tests to opaque pointers

nikic accepted this revision. nikic added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150733/new/ https://reviews.llvm.org/D150733 ___

[PATCH] D150221: Add option -fkeep-static-variables to emit all static variables

rjmccall added a comment. Hmm. Preserving unused global variables in case a hot patch might use them doesn't seem very compelling to me — hot patches need to be able to introduce globals of their own anyway. What I find more convincing is related to the *other* meaning of

[PATCH] D150614: [clang-format] Ignore first token when finding MustBreak

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:20136 "#ifdef _DEBUG\n" - "void bar()\n" - " {\n" - " }\n" + "void

[PATCH] D150718: [CUDA] Relax restrictions on GPU-side variadic functions

jlebar accepted this revision. jlebar added a comment. This revision is now accepted and ready to land. OK, sgtm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150718/new/ https://reviews.llvm.org/D150718

[PATCH] D150746: [CodeGen]Translating pointer arguments can require an address space cast

AlexVlx added a comment. In D150746#4350716 , @rjmccall wrote: > Passing the VTT in the appropriate AS for global variables seems like the > right way to go — we do know that that argument will always be such a > pointer, so there's no point in

[PATCH] D150183: [Clang][clang-cl] Implement `__builtin_FUNCSIG`

aaron.ballman added a comment. Thank you! In general, this is looking pretty close to ready. Comment at: clang/lib/Parse/ParseExpr.cpp:807-809 +/// [C++11] simple-type-specifier braced-init-list[C++11 5.2.3] /// [C++] typename-specifier '('

[PATCH] D150746: [CodeGen]Translating pointer arguments can require an address space cast

rjmccall added a comment. Passing the VTT in the appropriate AS for global variables seems like the right way to go — we do know that that argument will always be such a pointer, so there's no point in converting to the generic address space. For that matter, v-table pointer slots within

[PATCH] D150221: Add option -fkeep-static-variables to emit all static variables

hubert.reinterpretcast added a comment. In D150221#4347840 , @efriedma wrote: >> This is an adaptation of the IBM XL compiler's -qstatsym option, which is >> meant to generate symbol table entries for static variables. An artifact of >> that compiler

  1   2   3   >