[clang] f63155a - [clang] Show line numbers in diagnostic code snippets

Author: Timm Bäder Date: 2023-05-31T07:26:03+02:00 New Revision: f63155aaa6467bd2610820dfd1996af3bb6029a7 URL: https://github.com/llvm/llvm-project/commit/f63155aaa6467bd2610820dfd1996af3bb6029a7 DIFF: https://github.com/llvm/llvm-project/commit/f63155aaa6467bd2610820dfd1996af3bb6029a7.diff

[clang-tools-extra] f63155a - [clang] Show line numbers in diagnostic code snippets

Author: Timm Bäder Date: 2023-05-31T07:26:03+02:00 New Revision: f63155aaa6467bd2610820dfd1996af3bb6029a7 URL: https://github.com/llvm/llvm-project/commit/f63155aaa6467bd2610820dfd1996af3bb6029a7 DIFF: https://github.com/llvm/llvm-project/commit/f63155aaa6467bd2610820dfd1996af3bb6029a7.diff

[PATCH] D151720: [clang][ExprConstant] Fix display of syntactically-invalid note for member function calls

hazohelet added a comment. In D151720#4383098 , @tbaeder wrote: > Can you show the output for an example where the `->` notation is correct, > e.h. https://godbolt.org/z/6a5oExjME ? > > I suppose the patch doesn't change this much, but the current way

[clang] e517c5a - [clang] Add test for -ftabstop diagnostics

Author: Jan Svoboda Date: 2023-05-30T21:58:29-07:00 New Revision: e517c5a897c3332ce12b584ff5e522395a0e0469 URL: https://github.com/llvm/llvm-project/commit/e517c5a897c3332ce12b584ff5e522395a0e0469 DIFF: https://github.com/llvm/llvm-project/commit/e517c5a897c3332ce12b584ff5e522395a0e0469.diff

[PATCH] D151429: print user provide value in tabstop diagnostic

This revision was automatically updated to reflect the committed changes. Closed by commit rGa5bf4860eaee: print user provide value in tabstop diagnostic (authored by csmoe, committed by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] a5bf486 - print user provide value in tabstop diagnostic

Author: csmoe Date: 2023-05-30T21:44:10-07:00 New Revision: a5bf4860eaee23c5bb7bd945516cd4d9f1873d5d URL: https://github.com/llvm/llvm-project/commit/a5bf4860eaee23c5bb7bd945516cd4d9f1873d5d DIFF: https://github.com/llvm/llvm-project/commit/a5bf4860eaee23c5bb7bd945516cd4d9f1873d5d.diff LOG:

[clang] 3473f72 - [clang][lex] NFCI: Use DirectoryEntryRef in HeaderSearch::LookupFile

Author: Jan Svoboda Date: 2023-05-30T21:42:01-07:00 New Revision: 3473f728b36e21d322f141e576377c20a02c9aad URL: https://github.com/llvm/llvm-project/commit/3473f728b36e21d322f141e576377c20a02c9aad DIFF: https://github.com/llvm/llvm-project/commit/3473f728b36e21d322f141e576377c20a02c9aad.diff

[PATCH] D127663: [clang][lex] NFCI: Use DirectoryEntryRef in HeaderSearch::LookupFile

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3473f728b36e: [clang][lex] NFCI: Use DirectoryEntryRef in HeaderSearch::LookupFile (authored by jansvoboda11). Changed prior to commit:

[PATCH] D151607: [AST] Remove unused function removeLocalCVRQualifiers

kazu added a comment. In D151607#4380757 , @erichkeane wrote: > Since this is part of the public API, do we need to publish/alert folks of > this? This could perhaps be in use by someone using libclang/etc, right? I don't think we guarantee the API

[PATCH] D148490: [AIX] use system assembler for assembly files

qiucf accepted this revision as: qiucf. qiucf added a comment. This revision is now accepted and ready to land. This looks reasonable to me, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148490/new/ https://reviews.llvm.org/D148490

[PATCH] D151720: [clang][ExprConstant] Fix display of syntactically-invalid note for member function calls

tbaeder added a comment. Can you show the output for an example where the `->` notation is correct, e.h. https://godbolt.org/z/6a5oExjME ? I suppose the patch doesn't change this much, but the current way that's displayed (`&{*new Foo#0}->zomg()`) is... questionable. Repository: rG LLVM

[PATCH] D151704: [clang] Add test for CWG873

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151704/new/ https://reviews.llvm.org/D151704

[PATCH] D151586: [clang][modules] NFCI: Extract optionality out of `Module::{Header,DirectoryName}`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe6830b6028ec: [clang][modules] NFCI: Extract optionality out of `Module::{Header… (authored by jansvoboda11). Repository: rG LLVM Github Monorepo

[clang] e6830b6 - [clang][modules] NFCI: Extract optionality out of `Module::{Header,DirectoryName}`

Author: Jan Svoboda Date: 2023-05-30T21:06:51-07:00 New Revision: e6830b6028ec5434ccf8dbebdd992918f67b1751 URL: https://github.com/llvm/llvm-project/commit/e6830b6028ec5434ccf8dbebdd992918f67b1751 DIFF: https://github.com/llvm/llvm-project/commit/e6830b6028ec5434ccf8dbebdd992918f67b1751.diff

[PATCH] D150843: [clang][Diagnostics] Refactor printableTextForNextCharacter

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150843/new/ https://reviews.llvm.org/D150843 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D151769: [NFC][CLANG] Fix nullptr dereference issue in HandleRISCVRVVVectorBitsTypeAttr()

Manna updated this revision to Diff 526882. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151769/new/ https://reviews.llvm.org/D151769 Files: clang/lib/Sema/SemaType.cpp Index: clang/lib/Sema/SemaType.cpp === ---

[PATCH] D150212: [clang][Sema] Improve diagnostics for auto return type

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0442d08fdb17: [clang][Sema] Improve diagnostics for auto return type (authored by yaxunl). Herald added a project: clang. Changed prior to commit:

[clang] 0442d08 - [clang][Sema] Improve diagnostics for auto return type

Author: Yaxun (Sam) Liu Date: 2023-05-30T23:35:59-04:00 New Revision: 0442d08fdb173d89b0779d32eb929957a344f5e6 URL: https://github.com/llvm/llvm-project/commit/0442d08fdb173d89b0779d32eb929957a344f5e6 DIFF:

[PATCH] D151769: [NFC][CLANG] Fix nullptr dereference issue in HandleRISCVRVVVectorBitsTypeAttr()

Manna updated this revision to Diff 526877. Manna added a comment. Rebase the patch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151769/new/ https://reviews.llvm.org/D151769 Files: clang/lib/Sema/SemaType.cpp Index: clang/lib/Sema/SemaType.cpp

[PATCH] D151770: [NFC][CLANG] Fix nullptr dereference issue in SetValueDataBasedOnQualType()

Manna abandoned this revision. Manna added a comment. Closing this PR. Codes give an assert for unknown type Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151770/new/ https://reviews.llvm.org/D151770

[PATCH] D150212: [clang][Sema] Improve diagnostics for auto return type

yaxunl added inline comments. Comment at: clang/test/SemaCXX/auto-type-from-cxx.cpp:31-43 +class Abstract{ + public: +void fun(); +virtual void vfun()=0; +void call(){getCaller()(*this);} // expected-note {{in instantiation of function template specialization

[PATCH] D151741: [Lex] Only warn on defining or undefining language-defined builtins

nathanchance added a comment. This patch cleared up all the warnings I reported, thank you for the fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151741/new/ https://reviews.llvm.org/D151741 ___

[PATCH] D151770: [NFC][CLANG] Fix nullptr dereference issue in SetValueDataBasedOnQualType()

Manna created this revision. Manna added a reviewer: erichkeane. Herald added a project: All. Manna requested review of this revision. Herald added a project: clang. This patch uses castAs instead of getAs which will assert if the type doesn't match in SetValueDataBasedOnQualType(clang::​Value

[PATCH] D150253: [RISCV] Add Zvfhmin extension for clang.

jacquesguan updated this revision to Diff 526872. jacquesguan added a comment. Address a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150253/new/ https://reviews.llvm.org/D150253 Files: clang/include/clang/Basic/riscv_vector.td

[PATCH] D150253: [RISCV] Add Zvfhmin extension for clang.

jacquesguan added a comment. In D150253#4382884 , @craig.topper wrote: > Do we need to enable these intrinsics for Zvfhmin? > > vfloat16mf4_t __riscv_vle16_v_f16mf4 (const float16_t *base, size_t vl); > vfloat16mf2_t __riscv_vle16_v_f16mf2 (const

[PATCH] D151769: [NFC][CLANG] Fix nullptr dereference issue in HandleRISCVRVVVectorBitsTypeAttr()

Manna created this revision. Manna added a reviewer: erichkeane. Herald added subscribers: VincentWu, vkmr, luismarques, sameer.abuasal, s.egerton, Jim, benna, psnobl, PkmX, rogfer01, shiva0217, kito-cheng, simoncook, arichardson. Herald added a project: All. Manna requested review of this

[PATCH] D150253: [RISCV] Add Zvfhmin extension for clang.

craig.topper added a comment. Do we need to enable these intrinsics for Zvfhmin? vfloat16mf4_t __riscv_vle16_v_f16mf4 (const float16_t *base, size_t vl); vfloat16mf2_t __riscv_vle16_v_f16mf2 (const float16_t *base, size_t vl); vfloat16m1_t __riscv_vle16_v_f16m1 (const float16_t *base,

[PATCH] D150253: [RISCV] Add Zvfhmin extension for clang.

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150253/new/ https://reviews.llvm.org/D150253

[PATCH] D150253: [RISCV] Add Zvfhmin extension for clang.

craig.topper added a comment. In D150253#4382857 , @jacquesguan wrote: > In D150253#4381435 , @craig.topper > wrote: > >> We need to support reinterpret intrinsics so that we can load/store bf16 >> values. > >

[clang] cf236a0 - [NFC][CLANG] Fix nullptr dereference issue in DeduceTemplateArgumentsByTypeMatch()

Author: Manna, Soumi Date: 2023-05-30T19:02:40-07:00 New Revision: cf236a037fd846d12131809ed07766fceec65fdc URL: https://github.com/llvm/llvm-project/commit/cf236a037fd846d12131809ed07766fceec65fdc DIFF: https://github.com/llvm/llvm-project/commit/cf236a037fd846d12131809ed07766fceec65fdc.diff

[PATCH] D151529: [NFC][CLANG] Fix nullptr dereference issue in DeduceTemplateArgumentsByTypeMatch()

This revision was automatically updated to reflect the committed changes. Closed by commit rGcf236a037fd8: [NFC][CLANG] Fix nullptr dereference issue in… (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151529/new/

[PATCH] D150253: [RISCV] Add Zvfhmin extension for clang.

jacquesguan added a comment. In D150253#4381435 , @craig.topper wrote: > We need to support reinterpret intrinsics so that we can load/store bf16 > values. Sorry, I don't understand your comment well. I think that change you mentioned should not be

[PATCH] D151721: [NFC][CLANG] Fix nullptr dereference issue in Type::getRVVEltType()

This revision was automatically updated to reflect the committed changes. Closed by commit rG0c05128aeaf8: [NFC][CLANG] Fix nullptr dereference issue in Type::getRVVEltType() (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 0c05128 - [NFC][CLANG] Fix nullptr dereference issue in Type::getRVVEltType()

Author: Manna, Soumi Date: 2023-05-30T18:46:56-07:00 New Revision: 0c05128aeaf8611f835ee59f96467100e1bec6dc URL: https://github.com/llvm/llvm-project/commit/0c05128aeaf8611f835ee59f96467100e1bec6dc DIFF: https://github.com/llvm/llvm-project/commit/0c05128aeaf8611f835ee59f96467100e1bec6dc.diff

[PATCH] D151537: [NFC] Update cpu_specific test to use a newer CPU

LuoYuanke added a comment. In D151537#4380763 , @erichkeane wrote: > I don't really see the justification here? Why do this change? If the > intent is to just test a newer architecture, we can add tests for that, not > change existing ones. KNL is

[PATCH] D150689: [clang][DependencyScanner] Remove all warning flags when suppressing warnings

Bigcheese added inline comments. Comment at: clang/lib/Tooling/DependencyScanning/ModuleDepCollector.cpp:50 + // optimize. + if (!IsSystemModule) +return; ributzka wrote: > This removes also all warnings when building your own module, because of the >

[PATCH] D151634: [clang] Add test for CWG253

shafik added inline comments. Comment at: clang/test/CXX/drs/dr0xx.cpp:1022 -namespace dr78 { // dr78: sup +namespace dr78 { // dr78: no // Under DR78, this is valid, because 'k' has static storage duration, so is This is [issue

[PATCH] D151763: [clang] Fix crash when passing a braced-init list to a parentehsized aggregate init expression

ayzhao updated this revision to Diff 526858. ayzhao added a comment. rebase to see if this fixes CI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151763/new/ https://reviews.llvm.org/D151763 Files: clang/docs/ReleaseNotes.rst

[PATCH] D150646: [clang][X86] Add __cpuidex function to cpuid.h

aidengrossman added a comment. In D150646#4379543 , @glandium wrote: > There seem to still be two problems with this change, with mingw: > > - with `-fms-extensions`: > > echo '#include "cpuid.h"' | ./clang/bin/clang++ >

[PATCH] D151763: [clang] Fix crash when passing a braced-init list to a parentehsized aggregate init expression

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. Thank you for the quick fix! LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151763/new/ https://reviews.llvm.org/D151763

[PATCH] D127663: [clang][lex] NFCI: Use DirectoryEntryRef in HeaderSearch::LookupFile

bnbarham accepted this revision. bnbarham added inline comments. Comment at: clang/lib/Frontend/FrontendAction.cpp:811 // Relative searches begin from CWD. - const DirectoryEntry *Dir = nullptr; - if (auto DirOrErr = CI.getFileManager().getDirectory(".")) -

[PATCH] D127663: [clang][lex] NFCI: Use DirectoryEntryRef in HeaderSearch::LookupFile

jansvoboda11 updated this revision to Diff 526850. jansvoboda11 added a comment. Match Windows `\\` path separators too Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127663/new/ https://reviews.llvm.org/D127663 Files:

[PATCH] D151586: [clang][modules] NFCI: Extract optionality out of `Module::{Header,DirectoryName}`

jansvoboda11 updated this revision to Diff 526849. jansvoboda11 added a comment. Herald added a project: clang-tools-extra. Change `auto` to `std::optional<...>` in all places Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151586/new/

[PATCH] D151743: [OMP] Fix compiler assert "DeclRefExpr for Decl not entered in LocalDeclMap?"

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaaa33b6a98de: Fix assert DeclRefExpr for Decl not entered in LocalDeclMap? (authored by jyu2). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] aaa33b6 - Fix assert "DeclRefExpr for Decl not entered in LocalDeclMap?"

Author: Jennifer Yu Date: 2023-05-30T16:40:06-07:00 New Revision: aaa33b6a98de2be7cdc827b13e60c103206d6461 URL: https://github.com/llvm/llvm-project/commit/aaa33b6a98de2be7cdc827b13e60c103206d6461 DIFF: https://github.com/llvm/llvm-project/commit/aaa33b6a98de2be7cdc827b13e60c103206d6461.diff

[PATCH] D151763: [clang] Fix crash when passing a braced-init list to a parentehsized aggregate init expression

ayzhao created this revision. ayzhao added a reviewer: shafik. Herald added a project: All. ayzhao requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The previous code incorrectly assumed that we would never call warnBracedScalarInit(...)

[clang] d54b2d1 - [ExtractAPI] clang-format DeclarationFragments::insert

Author: Kazu Hirata Date: 2023-05-30T16:28:22-07:00 New Revision: d54b2d1c01d05dd0e29e0a7fd90adacc8998841a URL: https://github.com/llvm/llvm-project/commit/d54b2d1c01d05dd0e29e0a7fd90adacc8998841a DIFF: https://github.com/llvm/llvm-project/commit/d54b2d1c01d05dd0e29e0a7fd90adacc8998841a.diff

[clang] 749aeea - [clang][ExtractAPI] Fix -Wpessimizing-move in DeclarationFragments.h (NFC)

Author: Jie Fu Date: 2023-05-31T07:20:24+08:00 New Revision: 749aeeaf66a483345e12f69cc1f55dad4e997297 URL: https://github.com/llvm/llvm-project/commit/749aeeaf66a483345e12f69cc1f55dad4e997297 DIFF: https://github.com/llvm/llvm-project/commit/749aeeaf66a483345e12f69cc1f55dad4e997297.diff LOG:

[PATCH] D151523: [ASTStructuralEquivalence] Fix crash when ObjCCategoryDecl doesn't have corresponding ObjCInterfaceDecl.

vsapsai added inline comments. Comment at: clang/lib/AST/ASTStructuralEquivalence.cpp:2062 + *Intf2 = D2->getClassInterface(); + if ((Intf1 != nullptr) != (Intf2 != nullptr)) +return false; shafik wrote: > I think this would be

[PATCH] D150939: [CMake] Remove BOLT from Fuchsia toolchain

haowei added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150939/new/ https://reviews.llvm.org/D150939 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D150939: [CMake] Remove BOLT from Fuchsia toolchain

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaf4da3d74630: [CMake] Remove BOLT from Fuchsia toolchain (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] af4da3d - [CMake] Remove BOLT from Fuchsia toolchain

Author: Petr Hosek Date: 2023-05-30T23:02:26Z New Revision: af4da3d7463028542c77397c3da0ced76e1e97c3 URL: https://github.com/llvm/llvm-project/commit/af4da3d7463028542c77397c3da0ced76e1e97c3 DIFF: https://github.com/llvm/llvm-project/commit/af4da3d7463028542c77397c3da0ced76e1e97c3.diff LOG:

[PATCH] D150939: [CMake] Remove BOLT from Fuchsia toolchain

phosek updated this revision to Diff 526836. phosek added a reviewer: haowei. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150939/new/ https://reviews.llvm.org/D150939 Files: clang/cmake/caches/Fuchsia-stage2.cmake Index:

[PATCH] D151761: clang-format: Add AlignConsecutiveShortCaseLabels

galenelias created this revision. galenelias added a project: clang-format. Herald added projects: All, clang. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan, MyDeveloperDay. galenelias requested review of this revision. This resolves

[PATCH] D127663: [clang][lex] NFCI: Use DirectoryEntryRef in HeaderSearch::LookupFile

jansvoboda11 added a comment. The failing test was a fun one to debug. It didn't test what it intended to. It wanted to check that header referenced from module map is found via a search path, but the command line was constructed in such way that the header was found relative to the includer.

[PATCH] D127663: [clang][lex] NFCI: Use DirectoryEntryRef in HeaderSearch::LookupFile

jansvoboda11 updated this revision to Diff 526830. jansvoboda11 added a comment. Herald added a subscriber: ributzka. Fix the `Modules/filename.cpp` test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127663/new/ https://reviews.llvm.org/D127663

[PATCH] D151589: [lld] add context-sensitive PGO options for MachO

ellis updated this revision to Diff 526825. ellis marked 3 inline comments as not done. ellis added a comment. Rename test function to `foo` since `_start` is not a necessary symbol Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151589/new/

[PATCH] D151048: [clang][ExtractAPI] Modify declaration fragment methods to add a new fragment at an arbitrary offset.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG135ce2f820d8: [clang][ExtractAPI] Modify declaration fragment methods to add a new fragment… (authored by Ruturaj4). Changed prior to commit:

[clang] 92180da - [clang][ExtractAPI] Modify declaration fragment methods to add a new fragment at an arbitrary offset.

Author: ruturaj4 Date: 2023-05-30T17:30:22-05:00 New Revision: 92180dae775f66193069279ee7532735ea2fee06 URL: https://github.com/llvm/llvm-project/commit/92180dae775f66193069279ee7532735ea2fee06 DIFF: https://github.com/llvm/llvm-project/commit/92180dae775f66193069279ee7532735ea2fee06.diff

[clang] 135ce2f - [clang][ExtractAPI] Modify declaration fragment methods to add a new fragment at an arbitrary offset.

Author: ruturaj4 Date: 2023-05-30T17:30:22-05:00 New Revision: 135ce2f820d881d5a7c5d90feab109174918a21f URL: https://github.com/llvm/llvm-project/commit/135ce2f820d881d5a7c5d90feab109174918a21f DIFF: https://github.com/llvm/llvm-project/commit/135ce2f820d881d5a7c5d90feab109174918a21f.diff

[PATCH] D151683: [clang] Enable C++11-style attributes in all language modes

philnik added a comment. In D151683#4380877 , @erichkeane wrote: > What is the justification for this? What exactly are you asking for? Why I'd like to back port it? This would make quite a bit of code in libc++ simpler and avoids pit-falls where an

[PATCH] D151589: [lld] add context-sensitive PGO options for MachO

int3 added inline comments. Comment at: lld/test/MachO/cspgo-gen.ll:13 + +define void @_start() { +entry: doesn't *really* matter since you are creating a dylib, but `lld-macho` doesn't actually treat `_start` as a special symbol (only `main`). maybe rename to

[PATCH] D151701: [HIP] Add missing __hip_atomic_fetch_sub support

This revision was automatically updated to reflect the committed changes. Closed by commit rGe3fbede7f3fd: [HIP] Add missing __hip_atomic_fetch_sub support (authored by ldrumm). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151701/new/

[clang] e3fbede - [HIP] Add missing __hip_atomic_fetch_sub support

Author: Luke Drummond Date: 2023-05-30T22:22:43+01:00 New Revision: e3fbede7f3fd7693d5a15a8cfa0b62d9a4f84877 URL: https://github.com/llvm/llvm-project/commit/e3fbede7f3fd7693d5a15a8cfa0b62d9a4f84877 DIFF: https://github.com/llvm/llvm-project/commit/e3fbede7f3fd7693d5a15a8cfa0b62d9a4f84877.diff

[PATCH] D151753: [Clang][Sema] Do not try to analyze dependent alignment during -Wcast-align

serge-sans-paille created this revision. serge-sans-paille added reviewers: dim, Fznamznon. Herald added a project: All. serge-sans-paille requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix #63007 Repository: rG LLVM Github Monorepo

[PATCH] D151625: [clang] Add `clang::equality_operator_compares_members_lexicographically`

philnik added a comment. In D151625#4380735 , @erichkeane wrote: > I'm a little dense today perhaps, but I don't get the use case for this? Can > you ELI-EWG? Is this an attribute we expect our users to use? The name is > horrifyingly long for

[PATCH] D150318: [clang][deps] NFC: Pass around the whole scanning service

jansvoboda11 added a comment. Any other feedback? Comment at: clang/include/clang/Tooling/DependencyScanning/ModuleDepCollector.h:19 #include "clang/Serialization/ASTReader.h" +#include "clang/Tooling/DependencyScanning/DependencyScanningService.h" #include

[PATCH] D151277: [clang][modules] Mark fewer identifiers as out-of-date

jansvoboda11 added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151277/new/ https://reviews.llvm.org/D151277 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D151749: [Headers][doc] Add "shuffle-like" intrinsic descriptions to avx2intrin.h

probinson updated this revision to Diff 526782. probinson added a comment. Update some SATURATEx to SATURATExU CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151749/new/ https://reviews.llvm.org/D151749 Files: clang/lib/Headers/avx2intrin.h Index: clang/lib/Headers/avx2intrin.h

[PATCH] D127660: [clang][lex] NFCI: Use DirectoryEntryRef in Preprocessor::MainFileDir

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. jansvoboda11 marked an inline comment as done. Closed by commit rGe19f352beee7: [clang][lex] NFCI: Use DirectoryEntryRef in Preprocessor::MainFileDir (authored by

[PATCH] D127658: [clang][lex] NFCI: Use FileEntryRef in Sema::CodeCompleteIncludedFile

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb1e5b28b8c4d: [clang][lex] NFCI: Use FileEntryRef in Sema::CodeCompleteIncludedFile (authored by jansvoboda11). Herald added a subscriber: ributzka.

[PATCH] D127654: [clang] NFCI: Use DirectoryEntryRef in Module::Directory

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. jansvoboda11 marked 2 inline comments as done. Closed by commit rG32d6f3cfd90b: [clang] NFCI: Use DirectoryEntryRef in Module::Directory (authored by jansvoboda11).

[PATCH] D127651: [clang][lex] NFCI: Use DirectoryEntryRef in ModuleMap::parseModuleMapFile()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd574e918dba3: [clang][lex] NFCI: Use DirectoryEntryRef in ModuleMap::parseModuleMapFile() (authored by jansvoboda11). Herald added a subscriber:

[clang] e19f352 - [clang][lex] NFCI: Use DirectoryEntryRef in Preprocessor::MainFileDir

Author: Jan Svoboda Date: 2023-05-30T13:54:06-07:00 New Revision: e19f352beee72d8fc30d9a5366eadd2372719fa3 URL: https://github.com/llvm/llvm-project/commit/e19f352beee72d8fc30d9a5366eadd2372719fa3 DIFF: https://github.com/llvm/llvm-project/commit/e19f352beee72d8fc30d9a5366eadd2372719fa3.diff

[PATCH] D127648: [clang][lex] NFCI: Use DirectoryEntryRef in ModuleMap::inferFrameworkModule()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG95279d7670cd: [clang][lex] NFCI: Use DirectoryEntryRef in ModuleMap::inferFrameworkModule() (authored by jansvoboda11). Herald added a subscriber:

[clang] b1e5b28 - [clang][lex] NFCI: Use FileEntryRef in Sema::CodeCompleteIncludedFile

Author: Jan Svoboda Date: 2023-05-30T13:54:06-07:00 New Revision: b1e5b28b8c4d8af294906ee27a62b28079d3f337 URL: https://github.com/llvm/llvm-project/commit/b1e5b28b8c4d8af294906ee27a62b28079d3f337 DIFF: https://github.com/llvm/llvm-project/commit/b1e5b28b8c4d8af294906ee27a62b28079d3f337.diff

[clang] 32d6f3c - [clang] NFCI: Use DirectoryEntryRef in Module::Directory

Author: Jan Svoboda Date: 2023-05-30T13:54:06-07:00 New Revision: 32d6f3cfd90b90321e84477b2bd353afbf9876ea URL: https://github.com/llvm/llvm-project/commit/32d6f3cfd90b90321e84477b2bd353afbf9876ea DIFF: https://github.com/llvm/llvm-project/commit/32d6f3cfd90b90321e84477b2bd353afbf9876ea.diff

[clang-tools-extra] d574e91 - [clang][lex] NFCI: Use DirectoryEntryRef in ModuleMap::parseModuleMapFile()

Author: Jan Svoboda Date: 2023-05-30T13:54:06-07:00 New Revision: d574e918dba31e670a87c46e7de281819b3c0ea9 URL: https://github.com/llvm/llvm-project/commit/d574e918dba31e670a87c46e7de281819b3c0ea9 DIFF: https://github.com/llvm/llvm-project/commit/d574e918dba31e670a87c46e7de281819b3c0ea9.diff

[clang] 769d282 - [clang][lex] NFCI: Use FileEntryRef in ModuleMap::{load,lookup}ModuleMap()

Author: Jan Svoboda Date: 2023-05-30T13:54:06-07:00 New Revision: 769d282d7292d14591a721ee967962736160095e URL: https://github.com/llvm/llvm-project/commit/769d282d7292d14591a721ee967962736160095e DIFF: https://github.com/llvm/llvm-project/commit/769d282d7292d14591a721ee967962736160095e.diff

[clang] 95279d7 - [clang][lex] NFCI: Use DirectoryEntryRef in ModuleMap::inferFrameworkModule()

Author: Jan Svoboda Date: 2023-05-30T13:54:06-07:00 New Revision: 95279d7670cd54a50cf72d1fbc99701ef1faa72b URL: https://github.com/llvm/llvm-project/commit/95279d7670cd54a50cf72d1fbc99701ef1faa72b DIFF: https://github.com/llvm/llvm-project/commit/95279d7670cd54a50cf72d1fbc99701ef1faa72b.diff

[PATCH] D127647: [clang][lex] NFCI: Use FileEntryRef in ModuleMap::{load,lookup}ModuleMap()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG769d282d7292: [clang][lex] NFCI: Use FileEntryRef in ModuleMap::{load,lookup}ModuleMap() (authored by jansvoboda11). Repository: rG LLVM Github

[PATCH] D151749: [Headers][doc] Add "shuffle-like" intrinsic descriptions to avx2intrin.h

probinson created this revision. probinson added reviewers: RKSimon, pengfei, goldstein.w.n, craig.topper. Herald added a project: All. probinson requested review of this revision. (Time to look for the next round of embarrassing mistakes...) https://reviews.llvm.org/D151749 Files:

[PATCH] D151609: [Driver] Remove unused class ForceSuccessCommand

This revision was automatically updated to reflect the committed changes. Closed by commit rG692f3059fb95: [Driver] Remove unused class ForceSuccessCommand (authored by kazu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151609/new/

[clang] 692f305 - [Driver] Remove unused class ForceSuccessCommand

Author: Kazu Hirata Date: 2023-05-30T13:16:15-07:00 New Revision: 692f3059fb95fe191033d2f710c51babc08b9425 URL: https://github.com/llvm/llvm-project/commit/692f3059fb95fe191033d2f710c51babc08b9425 DIFF: https://github.com/llvm/llvm-project/commit/692f3059fb95fe191033d2f710c51babc08b9425.diff

[PATCH] D151523: [ASTStructuralEquivalence] Fix crash when ObjCCategoryDecl doesn't have corresponding ObjCInterfaceDecl.

shafik added inline comments. Comment at: clang/lib/AST/ASTStructuralEquivalence.cpp:2062 + *Intf2 = D2->getClassInterface(); + if ((Intf1 != nullptr) != (Intf2 != nullptr)) +return false; I think this would be easier to read if you

[clang] 28b26b1 - [clang] [test] Narrow down an MSVC specific behaviour to only not covever MinGW

Author: Martin Storsjö Date: 2023-05-30T23:05:57+03:00 New Revision: 28b26b161c2f5f8aecf8fffa7220cacc990ba51c URL: https://github.com/llvm/llvm-project/commit/28b26b161c2f5f8aecf8fffa7220cacc990ba51c DIFF:

[PATCH] D151661: [clang] [test] Narrow down an MSVC specific behaviour to only not covever MinGW

This revision was automatically updated to reflect the committed changes. Closed by commit rG28b26b161c2f: [clang] [test] Narrow down an MSVC specific behaviour to only not covever MinGW (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D148723: [clang] Restrict Inline Builtin to non-static, non-odr linkage

mstorsjo added a comment. In D148723#4381414 , @serge-sans-paille wrote: > In D148723#4380165 , @mstorsjo > wrote: > >> This causes failed asserts with `_FORTIFY_SOURCE` with the mingw-w64 >> headers. Here's a

[PATCH] D151589: [lld] add context-sensitive PGO options for MachO

ellis updated this revision to Diff 526751. ellis marked 3 inline comments as done. ellis added a comment. Add test to check that `PGOInstrumentationGen`(`Use`) are run Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151589/new/

[clang] d81ce04 - [Driver] Report error for unsupported -mlarge-endian/-mlittle-endian

Author: Fangrui Song Date: 2023-05-30T12:45:21-07:00 New Revision: d81ce04587c006b6731198956c522c93d0df1050 URL: https://github.com/llvm/llvm-project/commit/d81ce04587c006b6731198956c522c93d0df1050 DIFF: https://github.com/llvm/llvm-project/commit/d81ce04587c006b6731198956c522c93d0df1050.diff

[PATCH] D151515: [Sema] add cast from IncompleteArrayType to ConstantArrayType in TryReferenceListInitialization

HerrCai0907 added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:4433 +// where H is the initializer list. +Sequence.AddQualificationConversionStep(cv1T1, VK_XValue); + } erichkeane wrote: > Is `VK_XValue` correct here? The

[PATCH] D150430: Implement BufferOverlap check for sprint/snprintf

ArnaudBienner updated this revision to Diff 526743. ArnaudBienner added a comment. - clang-format fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150430/new/ https://reviews.llvm.org/D150430 Files:

[PATCH] D151575: [clang][diagnostics] Always show include stacks on errors

denik accepted this revision. denik added a comment. This revision is now accepted and ready to land. As long as having `In file included from` on each error **without notes** from one include file is fine, I don't see any problem with this. LGTM. But let's check what others think about it. For

[PATCH] D151741: [Lex] Only warn on defining or undefining language-defined builtins

nickdesaulniers added inline comments. Comment at: clang/lib/Lex/PPDirectives.cpp:163-172 + // C defines macros starting with __STDC, and C++ defines macros starting with + // __STDCPP + if (MacroName.startswith("__STDC")) +return true; + // C++ defines the __cplusplus

[PATCH] D145610: [clang][driver][AIX] accept maix32/maix64 gcc compat options

MaskRay added inline comments. Comment at: clang/lib/Driver/Driver.cpp:598 + // The `-maix[32|64]` flags are only valid for AIX targets. + if (Arg *A = Args.getLastArgNoClaim(options::OPT_maix32, options::OPT_maix64); + A && !Target.isOSAIX()) It'd be

[PATCH] D151741: [Lex] Only warn on defining or undefining language-defined builtins

nickdesaulniers added inline comments. Comment at: clang/test/Preprocessor/macro-reserved.c:19 #undef __STDC_HOSTED__ // expected-warning {{undefining builtin macro}} +#undef __INT32_TYPE__ Please add tests for the rest of

[PATCH] D150212: [clang][Sema] Improve diagnostics for auto return type

rsmith accepted this revision. rsmith added a comment. LGTM too. Comment at: clang/test/SemaCXX/auto-type-from-cxx.cpp:31-43 +class Abstract{ + public: +void fun(); +virtual void vfun()=0; +void call(){getCaller()(*this);} // expected-note {{in instantiation of

[PATCH] D144654: [Lex] Warn when defining or undefining any builtin macro

nickdesaulniers added a comment. In D144654#4380488 , @john.brawn wrote: > gcc has the same warning so I wasn't expecting this cause to change problems, > but looking more closely at gcc's behaviour it looks like it only warns for > some builtin

[PATCH] D151609: [Driver] Remove unused class ForceSuccessCommand

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. lgtm, thanks! (clicky: https://reviews.llvm.org/rG6625680a581c5e29c53d9f58d864cc6cd3cd05f6) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D151743: [OMP] Fix compiler assert "DeclRefExpr for Decl not entered in LocalDeclMap?"

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151743/new/ https://reviews.llvm.org/D151743

  1   2   3   >