[PATCH] D143075: BareMetal ToolChain multilib layering

phosek added inline comments. Comment at: clang/lib/Driver/ToolChains/BareMetal.cpp:242-246 + // No multilibs selected so return a single default multilib. + static llvm::SmallVector Default = {Multilib()}; + return llvm::iterator_range< +

[PATCH] D142986: Enable multilib.yaml in the BareMetal ToolChain

phosek added inline comments. Comment at: clang/lib/Driver/ToolChains/BareMetal.cpp:176 + +#define MULTILIB_YAML_FILENAME "multilib.yaml" + This is not idiomatic, I couldn't find any instance of `#define` for string literals anywhere in LLVM. I believe the

[PATCH] D149946: [LoongArch] Define `ual` feature and override `allowsMisalignedMemoryAccesses`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG47601815ec3a: [LoongArch] Define `ual` feature and override `allowsMisalignedMemoryAccesses` (authored by SixWeining). Repository: rG LLVM Github

[clang] 4760181 - [LoongArch] Define `ual` feature and override `allowsMisalignedMemoryAccesses`

Author: Weining Lu Date: 2023-06-07T13:40:58+08:00 New Revision: 47601815ec3a4f31c797c75748af08acfabc46dc URL: https://github.com/llvm/llvm-project/commit/47601815ec3a4f31c797c75748af08acfabc46dc DIFF: https://github.com/llvm/llvm-project/commit/47601815ec3a4f31c797c75748af08acfabc46dc.diff

[PATCH] D142933: Add -print-multi-selection-flags-experimental option

phosek added inline comments. Comment at: clang/include/clang/Driver/Options.td:4261 def print_multi_lib : Flag<["-", "--"], "print-multi-lib">; +def print_multi_selection_flags : Flag<["-", "--"], "print-multi-selection-flags-experimental">, + HelpText<"Print the flags used

[PATCH] D149946: [LoongArch] Define `ual` feature and override `allowsMisalignedMemoryAccesses`

SixWeining updated this revision to Diff 529164. SixWeining added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149946/new/ https://reviews.llvm.org/D149946 Files: clang/include/clang/Driver/Options.td

[PATCH] D142933: Add -print-multi-selection-flags-experimental option

phosek added inline comments. Comment at: clang/lib/Driver/ToolChain.cpp:250-285 + // Enumerate boolean flags we care about for the purposes of multilib here. + // There must be a smarter way to do it but this gets us started. + const struct HasFlag { +ID Pos, Neg; +

[PATCH] D142932: Multilib YAML parsing

phosek added a comment. The only remaining concern I have is about the YAML schema, specifically the naming of `Regex`, `MatchFlags` and `NoMatchFlags` fields. Specifically, I think it something like this might be cleaner: FlagMap: - Match:

[PATCH] D151437: [NFC][Driver] Change MultilibBuilder interface

phosek added inline comments. Comment at: clang/include/clang/Driver/MultilibBuilder.h:80 + /// \p Flag must be a flag accepted by the driver. + MultilibBuilder (bool Required, StringRef Flag); I think it would be cleaner to swap the order of arguments and

[PATCH] D112932: Use llvm.is_fpclass to implement FP classification functions

sepavloff updated this revision to Diff 529156. sepavloff added a comment. Herald added subscribers: llvm-commits, hiraditya. Herald added a project: LLVM. Add createIsFPClass to IRBuilder Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112932/new/

[PATCH] D151438: [NFC][Driver] Change Multilib flag representation

This revision was automatically updated to reflect the committed changes. Closed by commit rGce8fa36e59e1: [NFC][Driver] Change Multilib flag representation (authored by michaelplatings). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151438/new/

[PATCH] D151437: [NFC][Driver] Change MultilibBuilder interface

This revision was automatically updated to reflect the committed changes. Closed by commit rG47b431d6617d: [NFC][Driver] Change MultilibBuilder interface (authored by michaelplatings). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151437/new/

[clang] ce8fa36 - [NFC][Driver] Change Multilib flag representation

Author: Michael Platings Date: 2023-06-07T05:53:04+01:00 New Revision: ce8fa36e59e1995fde84730eeb460e06f42d7728 URL: https://github.com/llvm/llvm-project/commit/ce8fa36e59e1995fde84730eeb460e06f42d7728 DIFF:

[clang] 47b431d - [NFC][Driver] Change MultilibBuilder interface

Author: Michael Platings Date: 2023-06-07T05:53:04+01:00 New Revision: 47b431d6617d5029e30370ec988e5087f65e2d6b URL: https://github.com/llvm/llvm-project/commit/47b431d6617d5029e30370ec988e5087f65e2d6b DIFF:

[PATCH] D152070: [2/11][Clang][RISCV] Expand all variants of RVV intrinsic tuple types

eopXD updated this revision to Diff 529152. eopXD added a comment. Bump CI based on change in parent revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152070/new/ https://reviews.llvm.org/D152070 Files:

[PATCH] D152069: [1/11][Clang][Type] Expand BuiltinTypeBits from 8 to 16 bits

eopXD updated this revision to Diff 529151. eopXD marked an inline comment as done. eopXD added a comment. Address comment from Erich. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152069/new/ https://reviews.llvm.org/D152069 Files:

[PATCH] D151867: [Clang][RISCV] Make generic clz/ctz builtins defined for zero on RISCV targets.

craig.topper added a comment. In D151867#4401952 , @Yunzezhu wrote: > In D151867#4400255 , @craig.topper > wrote: > >> From the C language perspective with this change, __builtin_clz/ctz is still >> considered

[PATCH] D151867: [Clang][RISCV] Make generic clz/ctz builtins defined for zero on RISCV targets.

Yunzezhu added a comment. In D151867#4400255 , @craig.topper wrote: > From the C language perspective with this change, __builtin_clz/ctz is still > considered undefined for 0 and code that uses it is ill-formed. > `isCLZForZeroUndef` is only intended

[PATCH] D152197: Fix static analyzer bugs with null pointer dereferences in CheckSizelessVectorOperands()

Manna marked an inline comment as done. Manna added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:11148 if (LHSType->isVLSTBuiltinType() && RHSType->isVLSTBuiltinType() && Context.getBuiltinVectorTypeInfo(LHSBuiltinTy).EC !=

[PATCH] D152197: Fix static analyzer bugs with null pointer dereferences in CheckSizelessVectorOperands()

Manna updated this revision to Diff 529138. Manna retitled this revision from "[NFC][CLANG] Fix static analyzer bugs with null pointer dereferences in CheckSizelessVectorOperands()" to "Fix static analyzer bugs with null pointer dereferences in CheckSizelessVectorOperands()". Manna edited the

[PATCH] D152335: [Clang] Add check to Sema::AddAlignedAttr to verify active bits is not out of range

shafik created this revision. shafik added reviewers: aaron.ballman, erichkeane. Herald added a project: All. shafik requested review of this revision. If we provide too large a value for the alignment attribute `APInt::getZExtValue()` will assert. This PR adds a active bits check and folds it

[PATCH] D152330: [clang-tidy] Check functions called from catch blocks

denizevrenci updated this revision to Diff 529140. denizevrenci added a comment. Sort tests out a bit more Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152330/new/ https://reviews.llvm.org/D152330 Files:

[PATCH] D152330: [clang-tidy] Check functions called from catch blocks

denizevrenci updated this revision to Diff 529137. denizevrenci added a comment. Sort out tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152330/new/ https://reviews.llvm.org/D152330 Files:

[PATCH] D152269: [StaticAnalyzer] Fix false negative on NilArgChecker when creating literal object

tripleCC added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/BasicObjCFoundationChecks.cpp:151-164 + auto ArgSVal = C.getSVal(E).getAs(); + if (!ArgSVal) +return; + + ProgramStateRef StNonNull, StNull; + std::tie(StNonNull, StNull) =

[PATCH] D152194: [StaticAnalyzer] Fix nullptr dereference issue found by static analyzer tool

Manna updated this revision to Diff 529133. Manna retitled this revision from "[NFC][CLANG] Fix nullptr dereference issue found by static analyzer tool" to "[StaticAnalyzer] Fix nullptr dereference issue found by static analyzer tool". Manna edited the summary of this revision. Manna added a

[PATCH] D152330: [clang-tidy] Check functions called from catch blocks

denizevrenci updated this revision to Diff 529134. denizevrenci added a comment. Rebase on main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152330/new/ https://reviews.llvm.org/D152330 Files:

[PATCH] D152330: [clang-tidy] Check functions called from catch blocks

ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. LGTM. And please wait for several days for other reviewers. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone/exception-escape-coro.cpp:132-136 if

[PATCH] D152285: Add support for the NO_COLOR environment variable

shafik added a comment. `CLICOLOR/CLICOLOR_FORCE` seems a lot more complicated, `NO-COLOR` feels like a win for low cost and does not preclude supporting others later on if we feel there is a need. So LGTM but I would like to see more feedback. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D152274: [clang] Don't create import decls without -fmodules

ChuanqiXu added inline comments. Comment at: clang/test/Modules/getSourceDescriptor-crash.cpp:2 +// RUN: rm -rf %t +// RUN: %clang_cc1 -I %S/Inputs/getSourceDescriptor-crash -S -emit-llvm -debug-info-kind=limited -debugger-tuning=lldb -fmodules -fmodules-cache-path=%t

[PATCH] D152330: [clang-tidy] Check functions called from catch blocks

denizevrenci added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone/exception-escape-coro.cpp:132-136 if constexpr (ThrowInUnhandledException) { throw 1; +} else if constexpr (RethrowInUnhandledException) { + throw; }

[PATCH] D152269: [StaticAnalyzer] Fix false negative on NilArgChecker when creating literal object

tripleCC added inline comments. Comment at: clang/test/Analysis/NSContainers.m:336-337 +void testCreateArrayLiteralWithNullableArg() { + (void)@[getNonnullFoo()]; // no warning + (void)@[getNullableFoo()]; // expected-warning {{Nullable pointer is passed to a callee that

[PATCH] D152330: [clang-tidy] Check functions called from catch blocks

ChuanqiXu added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone/exception-escape-coro.cpp:132-136 if constexpr (ThrowInUnhandledException) { throw 1; +} else if constexpr (RethrowInUnhandledException) { + throw; }

[clang] d4c5b45 - [NFC] Remove unneeded semicolon after function definition

Author: Jim Lin Date: 2023-06-07T09:29:49+08:00 New Revision: d4c5b452934a31f9b3685cf58bd682104b686d1a URL: https://github.com/llvm/llvm-project/commit/d4c5b452934a31f9b3685cf58bd682104b686d1a DIFF: https://github.com/llvm/llvm-project/commit/d4c5b452934a31f9b3685cf58bd682104b686d1a.diff LOG:

[PATCH] D152330: [clang-tidy] Check functions called from catch blocks

denizevrenci created this revision. denizevrenci added reviewers: njames93, PiotrZSL, ChuanqiXu. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. denizevrenci requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber:

[PATCH] D152269: [StaticAnalyzer] Fix false negative on NilArgChecker when creating literal object

tripleCC updated this revision to Diff 529116. tripleCC added a comment. [StaticAnalyzer] add might be null test case for NilArgChecker Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152269/new/ https://reviews.llvm.org/D152269 Files:

[PATCH] D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1

ychen added a comment. In D139837#4401134 , @cor3ntin wrote: > I think this looks good but I'll let @aaron.ballman do the final approval. Thanks for the review @cor3ntin. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D151528: [clang][DeclPrinter] Fix AST print of out-of-line record definitions

strimo378 added a comment. Please use "Timo Stripf" and timo.str...@emmtrix.com Thank you for your review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151528/new/ https://reviews.llvm.org/D151528 ___

[PATCH] D144006: [DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (4/7)

dzhidzhoev updated this revision to Diff 529100. dzhidzhoev added a comment. Added AutoUpdater, moving function-local types belonging to DICompileUnit to a corresponding DISubprogram. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144006/new/

[PATCH] D150803: [WebAssembly] Add a new `wasm_async` clang attribute for marking async functions.

sbc100 added a comment. In D150803#4401552 , @sunfish wrote: > In D150803#4401204 , @sbc100 wrote: > >> In D150803#4401061 , @sunfish >> wrote: >> >>> wasm_jspi works

[PATCH] D144004: [DebugMetadata][DwarfDebug] Fix DWARF emisson of function-local imported entities (3/7)

dzhidzhoev updated this revision to Diff 529098. dzhidzhoev added a comment. Added AutoUpdater, moving function-local imported entities belonging to DICompileUnit to a corresponding DISubprogram. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D150803: [WebAssembly] Add a new `wasm_async` clang attribute for marking async functions.

sunfish added a comment. In D150803#4401204 , @sbc100 wrote: > In D150803#4401061 , @sunfish wrote: > >> wasm_jspi works for me. > > The problem with that is that we will also likely want to use this attribute >

[PATCH] D143984: [DebugMetadata] Simplify handling subprogram's retainedNodes field. NFCI (1/7)

dzhidzhoev updated this revision to Diff 529096. dzhidzhoev added a comment. Rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143984/new/ https://reviews.llvm.org/D143984 Files: clang/test/CodeGen/attr-btf_tag-disubprogram-callsite.c

[PATCH] D148924: [clang] Show error if defaulted comparions operator function is volatile or has ref-qualifier &&.

shafik accepted this revision. shafik added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148924/new/ https://reviews.llvm.org/D148924 ___ cfe-commits mailing list

[PATCH] D152321: [clang] Replace use of Type::getPointerTo() (NFC)

JOE1994 created this revision. JOE1994 added a reviewer: nikic. Herald added a subscriber: StephenFan. Herald added a project: All. JOE1994 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Partial progress towards replacing in-tree uses of

[PATCH] D152017: [DebugInfo] Add flag to only emit referenced member functions

rnk added a comment. In D152017#4401075 , @dblaikie wrote: > Yeah, mixed feelings about a default-on flag, so you have to use `-gno-*`. > Though one name in that form, might be `-gno-canonical-types`. > (pedantically C++ calls these things "member

[PATCH] D148700: [clang] Add support for “regular” keyword attributes

rsmith added a comment. In D148700#4401353 , @jyknight wrote: > Yes, standard attributes aren't supposed to be used for things which affect > the type system (although, we certainly have many, already, which do, since > we expose most GCC-syntax

[PATCH] D152318: [Fuchsia] Add llvm-strings to Fuchsia clang build

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbb398898dad9: [Fuchsia] Add llvm-strings to Fuchsia clang build. (authored by haowei). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] bb39889 - [Fuchsia] Add llvm-strings to Fuchsia clang build.

Author: Haowei Wu Date: 2023-06-06T16:27:35-07:00 New Revision: bb398898dad98e001f8b665a37ab6fb8cef70814 URL: https://github.com/llvm/llvm-project/commit/bb398898dad98e001f8b665a37ab6fb8cef70814 DIFF: https://github.com/llvm/llvm-project/commit/bb398898dad98e001f8b665a37ab6fb8cef70814.diff

[PATCH] D152318: [Fuchsia] Add llvm-strings to Fuchsia clang build

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152318/new/ https://reviews.llvm.org/D152318

[PATCH] D152318: [Fuchsia] Add llvm-strings to Fuchsia clang build

haowei created this revision. haowei added reviewers: phosek, mcgrathr. Herald added subscribers: abrachet, mstorsjo. Herald added a project: All. haowei requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch adds 'llvm-strings' to

[PATCH] D151863: [x86][MC] Fix movdir64b addressing

MaskRay added inline comments. Comment at: llvm/test/CodeGen/X86/movdir64b-inline-asm-x86_64.ll:1 +; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py UTC_ARGS: --version 2 +; RUN: llc < %s -mtriple=x86_64-unknown-unknown -mattr=+movdir64b | FileCheck

[PATCH] D142823: Intrinsics: Allow tablegen to mark parameters with dereferenceable

arsenm updated this revision to Diff 529074. arsenm added a comment. Split out amdgpu parts CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142823/new/ https://reviews.llvm.org/D142823 Files: llvm/include/llvm/IR/Intrinsics.td llvm/test/TableGen/intrin-side-effects.td

[PATCH] D148700: [clang] Add support for “regular” keyword attributes

jyknight added a comment. > This makes ``CXX11`` and ``C2x`` spellings > unsuitable for attributes that affect the type system, that change the > binary interface of the code, or that have other similar semantic meaning. Yes, standard attributes aren't supposed to be used for things which affect

[PATCH] D152285: Add support for the NO_COLOR environment variable

MaskRay added a comment. Thanks for the detailed description. I am generally conservative when it comes to new use cases for environment variables. However, `NO_COLOR` seems to become a standard and a large number of tools respect it, I think it is the right call to support it. If we don't

[PATCH] D152207: [HIP] Instruct lld to go through all archives

scchan updated this revision to Diff 529061. scchan added a comment. remove ws Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152207/new/ https://reviews.llvm.org/D152207 Files: clang/lib/Driver/ToolChains/HIPAMD.cpp

[PATCH] D152207: [HIP] Instruct lld to go through all archives

scchan updated this revision to Diff 529060. scchan added a comment. Updated patch to address review feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152207/new/ https://reviews.llvm.org/D152207 Files:

[PATCH] D152312: HIP: Use frexp builtins in math headers

arsenm created this revision. arsenm added reviewers: yaxunl, JonChesterfield. Herald added a project: All. arsenm requested review of this revision. Herald added a subscriber: wdng. https://reviews.llvm.org/D152312 Files: clang/lib/Headers/__clang_hip_math.h

[clang] 0874110 - [Driver] Change some Separate CC1 options to use the Joined = form

Author: Fangrui Song Date: 2023-06-06T15:12:45-07:00 New Revision: 087411010422ae50f412c74d3b1eeff0b680e74b URL: https://github.com/llvm/llvm-project/commit/087411010422ae50f412c74d3b1eeff0b680e74b DIFF: https://github.com/llvm/llvm-project/commit/087411010422ae50f412c74d3b1eeff0b680e74b.diff

[PATCH] D138473: clang/HIP: Inline frexp/frexpf implementations

arsenm closed this revision. arsenm added a comment. e1fa30d005afa32be1a8d490e99652cd56440826 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138473/new/ https://reviews.llvm.org/D138473 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D138396: HIP: Directly call signbit builtins

arsenm added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138396/new/ https://reviews.llvm.org/D138396 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D138399: HIP: Directly call isinf builtins

arsenm added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138399/new/ https://reviews.llvm.org/D138399 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D138395: HIP: Directly call fmin/fmax builtins

arsenm added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138395/new/ https://reviews.llvm.org/D138395 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D150803: [WebAssembly] Add a new `wasm_async` clang attribute for marking async functions.

sbc100 added a comment. In D150803#4401061 , @sunfish wrote: > wasm_jspi works for me. The problem with that is that we will also likely want to use this attribute for asyncify (which is the current async approach we have today) as well as JSPI (which

[PATCH] D151277: [clang][modules] Mark fewer identifiers as out-of-date

Bigcheese accepted this revision. Bigcheese added a comment. Looks good, although I'm not an expert on this bit either. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151277/new/ https://reviews.llvm.org/D151277

[PATCH] D150843: [clang][Diagnostics] Refactor printableTextForNextCharacter

tahonermann added a comment. The changes look good to me. I suggested two minor edits to align with parameter name changes. The summary states that the changes are not quite NFC. In that case, we would ideally have a test that demonstrates the changed behavior. Would adding such a test be

[PATCH] D150226: [Clang] Remove ability to downgrade warning on the diagnostic for setting a non fixed enum to a value outside the range of the enumeration values

jyknight added a comment. In D150226#4400782 , @rupprecht wrote: > As a general question/feature request: is there a way to have specific > warnings apply even for system headers? It would be nice if I could check > what breaks when by adding

[PATCH] D150209: [clang][Interp] Add more shift error checking

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150209/new/ https://reviews.llvm.org/D150209 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D138473: clang/HIP: Inline frexp/frexpf implementations

arsenm added a comment. Herald added a subscriber: jplehr. After D149716 this can switch to use the new builtin, and thus restores the ye olde southern islands workaround CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138473/new/

[PATCH] D150913: [Clang][BFloat16] Upgrade __bf16 to arithmetic type, change mangling, and extend excess precision support.

tahonermann added a comment. I'm late to review and can no longer stamp an approval on this, but I'll note for the historical record that the changes look good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150913/new/

[PATCH] D144911: adding bf16 support to NVPTX

tra added inline comments. Comment at: llvm/lib/Target/NVPTX/NVPTXISelLowering.cpp:615 setFP16OperationAction(Op, MVT::v2f16, Legal, Expand); - } - - for (const auto : {ISD::FADD, ISD::FMUL, ISD::FSUB, ISD::FMA}) { setBF16OperationAction(Op, MVT::bf16, Legal,

[PATCH] D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1

cor3ntin added a comment. I think this looks good but I'll let @aaron.ballman do the final approval. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139837/new/ https://reviews.llvm.org/D139837 ___

[PATCH] D152096: [Clang] Check for abstract parameters only when functions are defined.

cor3ntin updated this revision to Diff 529045. cor3ntin marked 2 inline comments as done. cor3ntin added a comment. Address Aaron's comments. Initially these changes were tracked in https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2018/p0929r2.html I fixed the specific github issue but more

[PATCH] D152226: [FunctionAttrs] Propagate some func/arg/ret attributes from caller to callsite (WIP)

arsenm added inline comments. Comment at: llvm/include/llvm/Transforms/Utils/InferCallsiteAttrs.h:1 +#ifndef LLVM_TRANSFORMS_UTILS_INFERCALLSITEATTRS_H +#define LLVM_TRANSFORMS_UTILS_INFERCALLSITEATTRS_H Missing license header Comment at:

[PATCH] D151532: [test] Test ext_vector_type operators with implicit conversions

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Thank you for the extra test coverage. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151532/new/

[PATCH] D149573: [Clang][C++23] Implement core language changes from P1467R9 extended floating-point types and standard names

tahonermann added a comment. This is looking good to me. I added a few comments seeking clarification. I'm concerned about the changes to the existing calls to `getFloatingTypeOrder()`. The changes look like they will preserve prior behavior for standard types just fine, but I'm not sure

[PATCH] D152226: [FunctionAttrs] Propagate some func/arg/ret attributes from caller to callsite (WIP)

goldstein.w.n added inline comments. Comment at: libc/CMakeLists.txt:22 +# that clang will use it. +if(LLVM_LIBC_MAKE_DISCOVERABLE) + if(LLVM_ENABLE_PER_TARGET_RUNTIME_DIR) sivachandra wrote: > Likely out of date and not required for this patch? woops, left

[clang] 5805aeb - [test] Restore x86-registered-target in Driver/as-warnings.c

Author: Fangrui Song Date: 2023-06-06T14:08:49-07:00 New Revision: 5805aeb0d924805c4ea132829debfaedcbcb0e76 URL: https://github.com/llvm/llvm-project/commit/5805aeb0d924805c4ea132829debfaedcbcb0e76 DIFF: https://github.com/llvm/llvm-project/commit/5805aeb0d924805c4ea132829debfaedcbcb0e76.diff

[PATCH] D152017: [DebugInfo] Add flag to only emit referenced member functions

dblaikie added a comment. In D152017#4400735 , @probinson wrote: > Oh, `-fstandalone-debug` should override this? In the Sony implementation, it > does. (Sorry for not remembering that sooner.) I'd think of this as orthogonal to that, potentially. by

[clang] 8a21ea1 - clang: Start emitting intrinsic for __builtin_ldexp*

Author: Matt Arsenault Date: 2023-06-06T17:07:19-04:00 New Revision: 8a21ea1d0a3883a8d0aa15440388f91e49da4d08 URL: https://github.com/llvm/llvm-project/commit/8a21ea1d0a3883a8d0aa15440388f91e49da4d08 DIFF:

[PATCH] D150803: [WebAssembly] Add a new `wasm_async` clang attribute for marking async functions.

sunfish added a comment. wasm_jspi works for me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150803/new/ https://reviews.llvm.org/D150803 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D151373: [libclang] Expose arguments of clang::annotate{_type}

aaron.ballman added a comment. Thank you for the additions! This should have test coverage in clang/unitttests/libclang/LibclangTest.cpp and a release note. Comment at: clang/tools/libclang/CIndex.cpp:2745 } +// TODO these two methods are exactly the same. Can this be

[PATCH] D152090: [clang][Driver] Add -fcaret-diagnostics-max-lines as a driver option

MaskRay added a comment. In D152090#4398097 , @tbaeder wrote: > In D152090#4395827 , @MaskRay wrote: > >> `def fcaret_diagnostics_max_lines` in `Options.td` has the `NoDriverOption` >> flag. Move it to other

[clang] 0aa4af7 - [Driver] Change some Separate CC1 options to use the Joined = form

Author: Fangrui Song Date: 2023-06-06T13:50:04-07:00 New Revision: 0aa4af711e567c8683cee95ffbb14812df03cecc URL: https://github.com/llvm/llvm-project/commit/0aa4af711e567c8683cee95ffbb14812df03cecc DIFF: https://github.com/llvm/llvm-project/commit/0aa4af711e567c8683cee95ffbb14812df03cecc.diff

[PATCH] D150803: [WebAssembly] Add a new `wasm_async` clang attribute for marking async functions.

brendandahl marked an inline comment as done. brendandahl added a comment. In D150803#4389062 , @sunfish wrote: > In D150803#4389040 , @dschuff wrote: > >> Hm, this is interesting because in the long term we plan

[PATCH] D151820: [clang][WebAssembly] Fix __BIGGEST_ALIGNMENT__ under emscripten

sbc100 added a comment. In D151820#4400795 , @tlively wrote: > In D151820#4385512 , @dschuff wrote: > >> I seem to recall that @tlively and I spent a bunch of time with XNNpack >> chasing down some kind of

[PATCH] D152021: [clang][AIX] Fix Overly Strick LTO Option Checking against `data-sections` when `mxcoff-roptr` is in Effect

qiongsiwu1 updated this revision to Diff 529030. qiongsiwu1 added a comment. Address code review. Thanks @MaskRay for the feedback! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152021/new/ https://reviews.llvm.org/D152021 Files:

[PATCH] D150803: [WebAssembly] Add a new `wasm_async` clang attribute for marking async functions.

brendandahl marked 2 inline comments as done. brendandahl added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:7638 + D->addAttr(::new (S.Context) WebAssemblyAsyncAttr(S.Context, AL)); + D->addAttr(UsedAttr::CreateImplicit(S.Context)); +}

[PATCH] D150803: [WebAssembly] Add a new `wasm_async` clang attribute for marking async functions.

brendandahl updated this revision to Diff 529028. brendandahl added a comment. Review comments. Add tombstone for unused functions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150803/new/ https://reviews.llvm.org/D150803 Files:

[PATCH] D152251: [clang][CodeGen] Fix GPU-specific attributes being dropped by bitcode linking

arsenm accepted this revision. arsenm added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/CodeGenCUDA/link-builtin-bitcode-gpu-attrs-preserved.cu:34 +// CHECK: define {{.*}} i32 @do_intrin_stuff() #[[ATTR:[0-9]+]] +// CHECK: attributes

[PATCH] D152305: [clang-format] Add the KeepEmptyLinesAtEOF option

owenpan created this revision. owenpan added a reviewer: klimek. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, MyDeveloperDay. owenpan requested review of this revision. Adds an option

[PATCH] D143075: BareMetal ToolChain multilib layering

michaelplatings added inline comments. Comment at: clang/lib/Driver/ToolChains/BareMetal.cpp:228 + +llvm::SmallVector BareMetal::getOrderedMultilibs() const { + // Get multilibs in reverse order because they're ordered most-specific last. phosek wrote: > Can

[PATCH] D143075: BareMetal ToolChain multilib layering

michaelplatings updated this revision to Diff 529021. michaelplatings marked an inline comment as done. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143075/new/ https://reviews.llvm.org/D143075 Files:

[PATCH] D143059: [Driver] Enable selecting multiple multilibs

michaelplatings updated this revision to Diff 529017. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143059/new/ https://reviews.llvm.org/D143059 Files: clang/include/clang/Driver/Multilib.h

[PATCH] D142986: Enable multilib.yaml in the BareMetal ToolChain

michaelplatings added inline comments. Comment at: clang/lib/Driver/ToolChains/BareMetal.cpp:183 - SmallString<128> SysRootDir; - llvm::sys::path::append(SysRootDir, getDriver().Dir, "../lib/clang-runtimes", - getDriver().getTargetTriple());

[PATCH] D142986: Enable multilib.yaml in the BareMetal ToolChain

michaelplatings updated this revision to Diff 529016. michaelplatings marked an inline comment as done. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142986/new/ https://reviews.llvm.org/D142986 Files:

[PATCH] D150910: [libclang] Add CXBinaryOperatorKind and CXUnaryOperatorKind (implements 29138)

aaron.ballman added a comment. Thank you for the additions! This should have some amount of test coverage added to clang/unittests/libclang/LibclangTest.cpp and a release note. Comment at: clang/tools/libclang/CIndex.cpp:9606 + +CXString

[PATCH] D142933: Add -print-multi-selection-flags-experimental option

michaelplatings updated this revision to Diff 529013. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142933/new/ https://reviews.llvm.org/D142933 Files: clang/include/clang/Driver/Options.td

[PATCH] D151587: [clang][ConstantEmitter] have tryEmitPrivateForVarInit try ConstExprEmitter fast-path first

nickdesaulniers added a comment. In D151587#4399684 , @ahatanak wrote: > Is there a github issue for this crash? I'm not aware, but I also haven't looked. > Is anyone looking into this? I guess I am tangentially as it seems to be a blocker for this

[PATCH] D152303: [ExprConstant] fix ICE from Evaluate on _Atomic structs

nickdesaulniers created this revision. Herald added a project: All. nickdesaulniers requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes two crashes reported by @efriedma and @ahatanak, as per @ahatanak's analysis. Link:

[PATCH] D151753: [Clang][Sema] Do not try to analyze dependent alignment during -Wcast-align

serge-sans-paille added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:16163 +// Dependent alignment cannot be resolved -> bail out. +if (any_of(VD->specific_attrs(), + [](auto *A) { return A->isAlignmentDependent(); }))

  1   2   3   >