[PATCH] D152226: [FunctionAttrs] Propagate some func/arg/ret attributes from caller to callsite (WIP)

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. goldstein.w.n marked an inline comment as done. Closed by commit rG4fa971ff62c3:

[PATCH] D152771: [docs] Fix LibTooling documentation for OptionsParser change

serge-sans-paille accepted this revision. serge-sans-paille added a comment. This revision is now accepted and ready to land. I'm fine with the change. It would be great if this could `literalinclude` these two sample codes (as in

[PATCH] D152351: [clang] Add __builtin_isfpclass

sepavloff marked 2 inline comments as done. sepavloff added inline comments. Comment at: clang/test/CodeGen/isfpclass.c:2 +// RUN: %clang_cc1 -triple x86_64-linux-gnu -S -O1 -emit-llvm %s -o - | FileCheck %s + +_Bool check_isfpclass_finite(float x) { arsenm

[PATCH] D152351: [clang] Add __builtin_isfpclass

sepavloff updated this revision to Diff 530772. sepavloff added a comment. Herald added subscribers: aheejin, dschuff. Updated patch - Added named constants for data classes, - Fixed documentation, - Changed test for generated IR. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D151761: clang-format: Add AlignConsecutiveShortCaseStatements

galenelias added a comment. Well, I guess I didn't put quite enough thought into the `AlignCaseColons` option. While this solves the empty case label problem, it will also match in non-short case label scenarios such as the following, which doesn't seem desirable: switch (level) { case

[PATCH] D152764: [clang-tidy] Reserved-identifier: Improved AllowedIdentifiers option to support regular expressions

logan-5 added a comment. Thanks for the patch. This seems like it'll make the check much more useful. Comment at: clang-tools-extra/clang-tidy/bugprone/ReservedIdentifierCheck.cpp:48 + Options.get("AllowedIdentifiers", ""))) { + for (const auto : AllowedIdentifiers)

[PATCH] D152570: [clang] Fix filename remapping in template arguments

dankm added a comment. Maybe for the description something like: Apply -fmacro-prefix-map to anonymous tags in template arguments Do I need to mention TypePrinter? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152570/new/

[PATCH] D152570: [clang] Fix filename remapping in template arguments

dankm updated this revision to Diff 530763. dankm added a comment. Renamed & cleaned up unit tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152570/new/ https://reviews.llvm.org/D152570 Files: clang/docs/ReleaseNotes.rst

[PATCH] D152771: [docs] Fix LibTooling documentation for OptionsParser change

motemen created this revision. motemen added reviewers: serge-sans-paille, nridge. Herald added a project: All. motemen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Additional documentation fix per https://reviews.llvm.org/D94420

[PATCH] D152570: [clang] Fix filename remapping in template arguments

dankm added a comment. Avoiding "Fix" in the description is a good suggestion. Whether it's a bugfix or not is a matter of perspective, and what's really happening here is I'm adjusting compliant implementation defined behavior, not really fixing it. Comment at:

[PATCH] D125272: [clang] Add -fcheck-new support

heatd updated this revision to Diff 530755. heatd added a comment. Remove -S from the fcheck-new test RUN:, as requested by MaskRay Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125272/new/ https://reviews.llvm.org/D125272 Files:

[PATCH] D138810: [RISCV] Support vector crypto extension C intrinsics

4vtomat added a comment. Sorry for late reply, this is the relevant spec for C intrinsics: https://github.com/riscv-non-isa/rvv-intrinsic-doc/pull/234 I will update the patch according to this! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D152570: [clang] Fix filename remapping in template arguments

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Looks great! > [clang] Fix filename remapping in template arguments Personally I don't consider this a bug fix, but this changes does move into a desired direction, by making

[PATCH] D152226: [FunctionAttrs] Propagate some func/arg/ret attributes from caller to callsite (WIP)

arsenm added inline comments. Comment at: llvm/lib/Transforms/Utils/InferCallsiteAttrs.cpp:692 + else +memset(, kMaybe, sizeof(CurFnInfo)); + Caller = ParentFunc; Not very C++y, use the default constructor? Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D152226: [FunctionAttrs] Propagate some func/arg/ret attributes from caller to callsite (WIP)

arsenm added a comment. Typo guranteed in message Comment at: llvm/include/llvm/Transforms/Utils/InferCallsiteAttrs.h:1 +//===- InferCallsiteAttrs.h - Propagate attributes to callsites ---===// +// Missing C++ mode comment Comment

[PATCH] D152746: [C++20][Modules] Complete implementation of module.import p7.

ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152746/new/ https://reviews.llvm.org/D152746

[PATCH] D152279: [Driver] Default -msmall-data-limit= to 0

MaskRay added a comment. In D152279#4414574 , @hiraditya wrote: > In D152279#4406896 , @MaskRay wrote: > >> In D152279#4405901 , @asb wrote: >> >>> One of the key things

[PATCH] D152762: [clang][docs] Update SanitizerSpecialCaseList docs

MaskRay added a comment. For this patch, the best test is actually `llvm/unittests/Support/SpecialCaseListTest.cpp`. `clang/test/CodeGen/profile-filter-new.c` is a bit loosely connected to the gist of the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D152762: [clang][docs] Update SanitizerSpecialCaseList docs

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. > "The meaning of * in regular expression for entity names is different - it is > treated as in shell wildcarding." Right. See `SpecialCaseList.cpp` > I've removed fun:MyFooBar since it

[PATCH] D152697: AMDGPU: Add llvm.amdgcn.log intrinsic

arsenm closed this revision. arsenm added a comment. eccc89b26cc24c917bea0baa72ad5cd2c8d8fa1a CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152697/new/ https://reviews.llvm.org/D152697

[clang] eccc89b - AMDGPU: Add llvm.amdgcn.log intrinsic

Author: Matt Arsenault Date: 2023-06-12T21:10:30-04:00 New Revision: eccc89b26cc24c917bea0baa72ad5cd2c8d8fa1a URL: https://github.com/llvm/llvm-project/commit/eccc89b26cc24c917bea0baa72ad5cd2c8d8fa1a DIFF:

[PATCH] D125272: [clang] Add -fcheck-new support

MaskRay accepted this revision. MaskRay added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/CodeGenCXX/fcheck-new.cpp:3 +// RUN: %clang_cc1 -fcheck-new -triple x86_64-linux-gnu -S -disable-O0-optnone \ +// RUN: -emit-llvm -o - %s | opt

[PATCH] D152226: [FunctionAttrs] Propagate some func/arg/ret attributes from caller to callsite (WIP)

goldstein.w.n added a comment. ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152226/new/ https://reviews.llvm.org/D152226 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D152604: [Driver] Default -fsanitize-address-globals-dead-stripping to true for ELF

This revision was automatically updated to reflect the committed changes. Closed by commit rGa8d3ae712290: [Driver] Default -fsanitize-address-globals-dead-stripping to true for ELF (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] a8d3ae7 - [Driver] Default -fsanitize-address-globals-dead-stripping to true for ELF

Author: Fangrui Song Date: 2023-06-12T17:58:40-07:00 New Revision: a8d3ae712290d6f85db2deb9164181058f5c1307 URL: https://github.com/llvm/llvm-project/commit/a8d3ae712290d6f85db2deb9164181058f5c1307 DIFF: https://github.com/llvm/llvm-project/commit/a8d3ae712290d6f85db2deb9164181058f5c1307.diff

[PATCH] D152764: [clang-tidy] Reserved-identifier: Improved AllowedIdentifiers option to support regular expressions

felix642 created this revision. Herald added subscribers: PiotrZSL, carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. felix642 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Fixes:

[PATCH] D151820: [clang][WebAssembly] Fix __BIGGEST_ALIGNMENT__ under emscripten

dschuff added a comment. > Presumably this change of change makes most sense in the emscripten ChangeLog > right? We don't tend to document emscripten-specific changes in the llvm > release notes do we? Yes, I think so. Also I think it's more likely to be seen by users in the emscripten

[PATCH] D152083: [clang] Warning for uninitialized elements in fixed-size arrays

Sinitax updated this revision to Diff 530726. Sinitax added a comment. Fix test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152083/new/ https://reviews.llvm.org/D152083 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/DiagnosticGroups.td

[PATCH] D152762: [clang][docs] Update SanitizerSpecialCaseList docs

ellis created this revision. Herald added a project: All. ellis retitled this revision from "[clang][docs] Update Sanitizer docs and test" to "[clang][docs] Update SanitizerSpecialCaseList docs". ellis edited the summary of this revision. ellis added reviewers: vlad.tsyrklevich, MaskRay. ellis

[PATCH] D151820: [clang][WebAssembly] Fix __BIGGEST_ALIGNMENT__ under emscripten

sbc100 added a comment. In D151820#4415754 , @dschuff wrote: >> As far as I can tell the only way this change could break XNNpack if >> XNN_ALLOCATION_ALIGNMENT = 8 is wrongly set there... as long as that is the >> correct value for

[PATCH] D151761: clang-format: Add AlignConsecutiveShortCaseStatements

galenelias updated this revision to Diff 530707. galenelias edited the summary of this revision. galenelias added a comment. Ok, I added the ability to align the case label colons. In your original message you mentioned "I'd like to align the colon (and thus the statement behind that)" which

[PATCH] D151820: [clang][WebAssembly] Fix __BIGGEST_ALIGNMENT__ under emscripten

dschuff added a comment. > As far as I can tell the only way this change could break XNNpack if > XNN_ALLOCATION_ALIGNMENT = 8 is wrongly set there... as long as that is the > correct value for XNN_ALLOCATION_ALIGNMENT I don't see how this change could > break it. If XNN_ALLOCATION_ALIGNMENT

[PATCH] D144911: adding bf16 support to NVPTX

tra added a comment. Almost there. Just few cosmetic nits remaining. Comment at: llvm/lib/Target/NVPTX/MCTargetDesc/NVPTXInstPrinter.cpp:64-69 + case 9: OS << "%h"; break; case 8: + case 10: OS << "%hh"; tra wrote: > Looks like I've forgot

[PATCH] D152689: [NFC] Remove dead conditionals

schittir added a comment. Thank you for the review, @aaron.ballman and @rjmccall The latest patch fixes clang-format issue causing build failure. Could you please take a look at this again? Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152689/new/

[PATCH] D152689: [NFC] Remove dead conditionals

schittir updated this revision to Diff 530702. schittir added a comment. Fix clang-format issue in SemaOverload.cpp CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152689/new/ https://reviews.llvm.org/D152689 Files: clang/lib/CodeGen/CGObjCMac.cpp clang/lib/Sema/SemaOverload.cpp

[clang] 591c4b6 - [Driver] Remove misused NoXarchOption from some Windows options

Author: Fangrui Song Date: 2023-06-12T15:50:29-07:00 New Revision: 591c4b64b3650884c2c68eb47d755ebb62981b99 URL: https://github.com/llvm/llvm-project/commit/591c4b64b3650884c2c68eb47d755ebb62981b99 DIFF: https://github.com/llvm/llvm-project/commit/591c4b64b3650884c2c68eb47d755ebb62981b99.diff

[clang] 518621e - [Fuchsia] Pass CursesAndPanel_ROOT through to stage2

Author: Daniel Thornburgh Date: 2023-06-12T15:43:39-07:00 New Revision: 518621e90b0bcdb1c261e06256b9c845ef674cf2 URL: https://github.com/llvm/llvm-project/commit/518621e90b0bcdb1c261e06256b9c845ef674cf2 DIFF:

[PATCH] D152117: [RISC-V] Zvk update to 0.9.7, Zvknc/Zvksc

This revision was automatically updated to reflect the committed changes. Closed by commit rGc5a88fe3d071: [RISC-V] Zvk update to 0.9.7, Zvknc/Zvksc (authored by ego, committed by craig.topper). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github

[clang] c5a88fe - [RISC-V] Zvk update to 0.9.7, Zvknc/Zvksc

Author: Eric Gouriou Date: 2023-06-12T15:43:08-07:00 New Revision: c5a88fe3d071b9f120541b56b0e3e78bca4feea0 URL: https://github.com/llvm/llvm-project/commit/c5a88fe3d071b9f120541b56b0e3e78bca4feea0 DIFF: https://github.com/llvm/llvm-project/commit/c5a88fe3d071b9f120541b56b0e3e78bca4feea0.diff

[PATCH] D146557: [MLIR][OpenMP] Refactoring createTargetData in OMPIRBuilder

TIFitis added inline comments. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:4741 + if (IsFinished && BB->use_empty()) { +delete BB; +return; jdoerfert wrote: > you should not just delete BB. eraseFromParent is a better way. That said, it > is

[PATCH] D146557: [MLIR][OpenMP] Refactoring createTargetData in OMPIRBuilder

TIFitis updated this revision to Diff 530680. TIFitis added a comment. Update MLIR BodyGen callback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146557/new/ https://reviews.llvm.org/D146557 Files:

[PATCH] D152732: [clang][dataflow] Support limits on the SAT solver to force timeouts.

ymandel marked 3 inline comments as done. ymandel added a comment. In D152732#4415168 , @mboehme wrote: > In D152732#4414707 , @ymandel wrote: > >> In D152732#4414661 ,

[PATCH] D152400: CodeGen: hand two tests to the care of update_cc_test_checks

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0bd281eceff5: CodeGen: hand two tests to the care of update_cc_test_checks (authored by durin42). Repository: rG LLVM Github Monorepo CHANGES

[clang] 0bd281e - CodeGen: hand two tests to the care of update_cc_test_checks

Author: Augie Fackler Date: 2023-06-12T17:39:44-04:00 New Revision: 0bd281eceff58f1e92eed6b53a33152be9810b42 URL: https://github.com/llvm/llvm-project/commit/0bd281eceff58f1e92eed6b53a33152be9810b42 DIFF: https://github.com/llvm/llvm-project/commit/0bd281eceff58f1e92eed6b53a33152be9810b42.diff

[PATCH] D144999: [Clang][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs.

oontvoo added a comment. In D144999#4415137 , @jasonmolenda wrote: > Michael and I looked into this. This simple c++ file is resulting in > eh_frame unwind info on aarch64 darwin instead of compact unwind info. The > eh_frame instructions don't

[PATCH] D152604: [Driver] Default -fsanitize-address-globals-dead-stripping to true for ELF

eugenis accepted this revision. eugenis added a comment. LGTM This is long overdue, I think. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152604/new/ https://reviews.llvm.org/D152604 ___

[PATCH] D152604: [Driver] Default -fsanitize-address-globals-dead-stripping to true for ELF

MaskRay added a comment. In D152604#4415392 , @rnk wrote: > I think there's a fair bit more cleanup and simplification to be done, see > asanUsesGlobalsGC > > and

[PATCH] D146557: [MLIR][OpenMP] Refactoring createTargetData in OMPIRBuilder

TIFitis updated this revision to Diff 530671. TIFitis marked 6 inline comments as done. TIFitis added a comment. Addressed reviewer comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146557/new/ https://reviews.llvm.org/D146557 Files:

[PATCH] D152604: [Driver] Default -fsanitize-address-globals-dead-stripping to true for ELF

rnk added a comment. I think there's a fair bit more cleanup and simplification to be done, see asanUsesGlobalsGC and the comments there. We could check CGOpts.DataSections right there, for example, and

[PATCH] D150997: [llvm] Split out DenseMapInfo specialization

IncludeGuardian updated this revision to Diff 530667. IncludeGuardian added a comment. Fix missing includes in test, fix formatting, and rebase on top of https://reviews.llvm.org/D151557 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150997/new/ https://reviews.llvm.org/D150997 Files:

[PATCH] D152720: [clangd][ObjC] Support ObjC class rename from implementation decls

dgoldman updated this revision to Diff 530665. dgoldman added a comment. Run clang format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152720/new/ https://reviews.llvm.org/D152720 Files: clang-tools-extra/clangd/FindTarget.cpp

[PATCH] D142388: [clang] Add builtin_nondeterministic_value

rsmith added a comment. In D142388#4414375 , @aaron.ballman wrote: > In D142388#4412521 , @rsmith wrote: > >> I have a concern with the name of this builtin. People are going to assume >> it produces a

[PATCH] D150602: [clang-tidy] Move formatDereference to FixitHintUtils

mikecrowe updated this revision to Diff 530662. mikecrowe added a comment. Add clangTooling to LINK_LIBS for tooling::fixit::getText for clangTidyUtils to fix failure to build with BUILD_SHARED_LIBS=ON: ld.lld: error: undefined symbol:

[PATCH] D152752: [MS] Fix passing aligned records by value in some cases

rnk created this revision. rnk added reviewers: nikic, hans. Herald added subscribers: StephenFan, pengfei. Herald added a project: All. rnk requested review of this revision. Herald added a project: clang. It's not exactly clear what the meaning of TypeInfo::AlignRequirement is, so go directly

[PATCH] D149444: [ARM] Allow codegen for Armv6m eXecute-Only (XO) sections

MaskRay accepted this revision. MaskRay added a comment. > Actual implementation of code-gen for v6m will follow in follow-up patches, > which will include an implementation of relocations needed to support this. Normally we implement the feature in llvm/ first, and the `clang/lib/Driver`

[PATCH] D152747: [include-cleaner] Traverse implicit template instantations if the templates are inside the main file.

hokein created this revision. hokein added a reviewer: kadircet. Herald added a project: All. hokein requested review of this revision. Herald added a project: clang-tools-extra. This patch tweaks the WalkAST to traverse imlicit template instantations, presumably this is a big behavior change.

[PATCH] D152732: [clang][dataflow] Support limits on the SAT solver to force timeouts.

mboehme added a comment. In D152732#4414707 , @ymandel wrote: > In D152732#4414661 , @xazax.hun > wrote: > >> Huge +1, I think most solvers need to have some resource limits in place as >> the runtime can

[PATCH] D152689: [NFC] Remove dead conditionals

aaron.ballman accepted this revision. aaron.ballman added inline comments. Comment at: clang/lib/CodeGen/CGObjCMac.cpp:3812 llvm::GlobalVariable *GV; - if (ForClass) -GV = rjmccall wrote: > aaron.ballman wrote: > > I agree this is dead code (see line

[PATCH] D152650: [docs] Improve UndefinedBehaviorSanitizer.rst

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGee0367ef13f8: [docs] Improve UndefinedBehaviorSanitizer.rst (authored by MaskRay). Changed prior to commit:

[clang] ee0367e - [docs] Improve UndefinedBehaviorSanitizer.rst

Author: Fangrui Song Date: 2023-06-12T13:04:29-07:00 New Revision: ee0367ef13f87cdac869647d731f820a98746fe6 URL: https://github.com/llvm/llvm-project/commit/ee0367ef13f87cdac869647d731f820a98746fe6 DIFF: https://github.com/llvm/llvm-project/commit/ee0367ef13f87cdac869647d731f820a98746fe6.diff

[PATCH] D152650: [docs] Improve UndefinedBehaviorSanitizer.rst

MaskRay updated this revision to Diff 530645. MaskRay marked an inline comment as done. MaskRay edited the summary of this revision. MaskRay added a comment. better -fsanitize=... -fno-sanitize example Add "If the signal is not caught, the program will typically terminate due to a ``SIGILL`` or

[PATCH] D152650: [docs] Improve UndefinedBehaviorSanitizer.rst

MaskRay added inline comments. Comment at: clang/docs/UndefinedBehaviorSanitizer.rst:62 + # -fno-sanitize=undefined nullifies the previous -fsanitize=undefined. + % clang -fsanitize=undefined -fno-sanitize=undefined -fsanitize=alignment a.c + vitalybuka wrote:

[PATCH] D144999: [Clang][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs.

jasonmolenda added a comment. Michael and I looked into this. This simple c++ file is resulting in eh_frame unwind info on aarch64 darwin instead of compact unwind info. The eh_frame instructions don't describe the epilogue, so lldb is stopping on the final RET instruction after it has

[PATCH] D152650: [docs] Improve UndefinedBehaviorSanitizer.rst

vitalybuka accepted this revision. vitalybuka added inline comments. This revision is now accepted and ready to land. Comment at: clang/docs/UndefinedBehaviorSanitizer.rst:62 + # -fno-sanitize=undefined nullifies the previous -fsanitize=undefined. + % clang

[PATCH] D152746: [C++20][Modules] Complete implementation of module.import p7.

iains created this revision. Herald added a subscriber: ChuanqiXu. Herald added a project: All. iains edited the summary of this revision. iains added a reviewer: ChuanqiXu. iains added a subscriber: clang-modules. iains published this revision for review. iains added a comment. Herald added a

[clang] 1d6c3e2 - [Driver] Mark m_x86_Features_Group options as TargetSpecific

Author: Fangrui Song Date: 2023-06-12T12:47:33-07:00 New Revision: 1d6c3e29f6aa45914faa7be00a939b8f550f38e9 URL: https://github.com/llvm/llvm-project/commit/1d6c3e29f6aa45914faa7be00a939b8f550f38e9 DIFF: https://github.com/llvm/llvm-project/commit/1d6c3e29f6aa45914faa7be00a939b8f550f38e9.diff

[PATCH] D152570: [clang] Fix filename remapping in template arguments

dankm updated this revision to Diff 530638. dankm added a comment. Fix unit tests on windows Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152570/new/ https://reviews.llvm.org/D152570 Files: clang/docs/ReleaseNotes.rst clang/lib/AST/Expr.cpp

[clang] 34d7acd - [Driver] Mark many target-specific driver-only options as TargetSpecific

Author: Fangrui Song Date: 2023-06-12T12:34:08-07:00 New Revision: 34d7acd444b88342fc93fca202608c1e16fa5946 URL: https://github.com/llvm/llvm-project/commit/34d7acd444b88342fc93fca202608c1e16fa5946 DIFF: https://github.com/llvm/llvm-project/commit/34d7acd444b88342fc93fca202608c1e16fa5946.diff

[PATCH] D151325: [analyzer] Differentiate lifetime extended temporaries

steakhal added a comment. Ping @NoQ @xazax.hun Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151325/new/ https://reviews.llvm.org/D151325 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D152732: [clang][dataflow] Support limits on the SAT solver to force timeouts.

gribozavr2 added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/WatchedLiteralsSolver.h:37 + // measurements like CPU cycles or time to ensure deterministic results. + std::int64_t MaxIterations = std::numeric_limits::max(); +

[PATCH] D151047: [clang-format] Fix indentation for selective formatting.

Sedeniono marked an inline comment as done. Sedeniono added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:80 + // directive, since these do not terminate a code block. + if (!Line.InPPDirective && Line.Level < IndentForLevel.size()) +

[PATCH] D152741: -fskip-vtable-filepaths

modimo created this revision. Herald added subscribers: hoy, wenlei. Herald added a project: All. modimo requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D152741

[PATCH] D151047: [clang-format] Fix indentation for selective formatting.

Sedeniono updated this revision to Diff 530627. Sedeniono marked an inline comment as done. Sedeniono added a comment. Updated diff: Captured the intention of "going to lower levels" via a debug assert in nextLine(). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D125272: [clang] Add -fcheck-new support

heatd updated this revision to Diff 530617. heatd added a comment. Addressed MaskRay's feedback: Added a testcase that showcases the conditional calling of a constructor (due to new not being tagged nonnull) Kept the testcase with the simple _Znwm call Deleted the ATTR tags at the end

[PATCH] D152732: [clang][dataflow] Support limits on the SAT solver to force timeouts.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb639ebaa8f83: [clang][dataflow] Support limits on the SAT solver to force timeouts. (authored by ymandel). Repository: rG LLVM Github Monorepo

[clang] b639eba - [clang][dataflow] Support limits on the SAT solver to force timeouts.

Author: Yitzhak Mandelbaum Date: 2023-06-12T18:34:32Z New Revision: b639ebaa8f83dbed8adeae0a178a43d6115c9590 URL: https://github.com/llvm/llvm-project/commit/b639ebaa8f83dbed8adeae0a178a43d6115c9590 DIFF: https://github.com/llvm/llvm-project/commit/b639ebaa8f83dbed8adeae0a178a43d6115c9590.diff

[PATCH] D152732: [clang][dataflow] Support limits on the SAT solver to force timeouts.

ymandel added a comment. In D152732#4414771 , @xazax.hun wrote: > In D152732#4414707 , @ymandel wrote: > >> Ultimately what matters for a user is the global limit. > > I am not 100% sure about that. While it is

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

Prabhuk updated this revision to Diff 530609. Prabhuk added a comment. Addressed comments from last reviews except for adding lit tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152206/new/ https://reviews.llvm.org/D152206 Files:

[PATCH] D152073: [5/11][Clang][RISCV] Expand all variants for unit stride fault-first segment load

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152073/new/ https://reviews.llvm.org/D152073

[PATCH] D152732: [clang][dataflow] Support limits on the SAT solver to force timeouts.

xazax.hun added a comment. In D152732#4414707 , @ymandel wrote: > Ultimately what matters for a user is the global limit. I am not 100% sure about that. While it is true that the user cares about the process not hanging, but global vs local limits can

[PATCH] D152072: [4/11][Clang][RISCV] Expand all variants for unit stride segment store

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152072/new/ https://reviews.llvm.org/D152072

[PATCH] D152732: [clang][dataflow] Support limits on the SAT solver to force timeouts.

kinu added a comment. LGTM as well, I was initially thinking about having a local limit per query (which could be easier to pinpoint the particular query that explodes), but per-solver instance limit could make sense as a starter too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D152732: [clang][dataflow] Support limits on the SAT solver to force timeouts.

ymandel added a comment. In D152732#4414661 , @xazax.hun wrote: > Huge +1, I think most solvers need to have some resource limits in place as > the runtime can explode. I am just not 100% what is the best approach here, > putting a global limit on the

[PATCH] D146557: [MLIR][OpenMP] Refactoring createTargetData in OMPIRBuilder

jdoerfert added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:1487 + // possible, or else at the end of the function. + void emitBlock(BasicBlock *BB, Function *CurFn, bool IsFinished = false); + This does not mention the

[PATCH] D152732: [clang][dataflow] Support limits on the SAT solver to force timeouts.

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. Huge +1, I think most solvers need to have some resource limits in place as the runtime can explode. I am just not 100% what is the best approach here, putting a global limit on the

[PATCH] D152054: [OpenMP] Codegen support for thread_limit on target directive

sandeepkosuri updated this revision to Diff 530591. sandeepkosuri added a comment. Updated `target_codegen.cpp` test case to incorporate my changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152054/new/ https://reviews.llvm.org/D152054 Files:

[PATCH] D152734: [HIP] Fix HIP path detection

yaxunl created this revision. yaxunl added a reviewer: tra. Herald added subscribers: kerbowa, jvesely. Herald added a project: All. yaxunl requested review of this revision. Herald added a subscriber: MaskRay. Fix two issues: 1. `--hip-path` should not do rigorous checking, i.e. if .hipVersion

[PATCH] D152732: [clang][dataflow] Support limits on the SAT solver to force timeouts.

ymandel created this revision. ymandel added reviewers: kinu, xazax.hun, mboehme, sgatev. Herald added a subscriber: martong. Herald added a reviewer: NoQ. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang. This patch allows the client of a

[PATCH] D152279: [Driver] Default -msmall-data-limit= to 0

hiraditya added a comment. In D152279#4406896 , @MaskRay wrote: > In D152279#4405901 , @asb wrote: > >> One of the key things we've been discussing on this at the LLVM call is that >> we probably want to keep

[PATCH] D152689: [NFC] Remove dead conditionals

rjmccall accepted this revision. rjmccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/CodeGen/CGObjCMac.cpp:3812 llvm::GlobalVariable *GV; - if (ForClass) -GV = aaron.ballman wrote: > I agree this is dead

[PATCH] D142388: [clang] Add builtin_nondeterministic_value

xbolva00 added inline comments. Comment at: clang/docs/LanguageExtensions.rst:3087 + +``__builtin_nondeterministic_value`` returns a valid nondeterministic value of the same type as the provided argument. + This text really sells this new builtin as a random

[PATCH] D142388: [clang] Add builtin_nondeterministic_value

xbolva00 added a comment. https://reviews.llvm.org/D136737 used 'builtin_unspecified_value' which could be okay. Are we sure we want to expose this intrinsic as it can be easily misused (as mentioned, as random generator) and/or cause security issues? Maybe only allow it in system headers

[PATCH] D152634: [Sema] Remove unused isNonTypeNestedNameSpecifier

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you for the cleanup! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152634/new/ https://reviews.llvm.org/D152634

[PATCH] D152708: [RFC][Draft] Enable primitive support for Two-Level Line Tables in LLVM

dblaikie added a comment. Are there any known (or vague/unknown) limitations on the implementation with respect to the actual output/on-disk representation? (like, would doing some kind of size analysis of the output when using this patch/feature lead to incorrect conclusions about the cost of

[PATCH] D152246: [clang][ThreadSafety] Analyze known function pointer values

aaron.ballman added a comment. In D152246#4412333 , @aaronpuchert wrote: > That's a tough one. The change seems to be correct, and makes more patterns > visible. Of course I wonder how it comes that we see calls of a function > pointer with a uniquely

[PATCH] D152708: [RFC][Draft] Enable primitive support for Two-Level Line Tables in LLVM

dblaikie added a comment. Really appreciate you providing this prototype. > This solves one of the current weaknesses in DWARF debugging, which is the > inability to set breakpoints or step onto inlined callsites. However, there > are other proposals (such as Location View Numbering) that

[PATCH] D142388: [clang] Add builtin_nondeterministic_value

aaron.ballman added a comment. In D142388#4412521 , @rsmith wrote: > I have a concern with the name of this builtin. People are going to assume it > produces a nondeterministic value, and use it for seeding random number > generators and similar, and

[PATCH] D151820: [clang][WebAssembly] Fix __BIGGEST_ALIGNMENT__ under emscripten

sbc100 added a comment. Can we land this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151820/new/ https://reviews.llvm.org/D151820 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D152570: [clang] Fix filename remapping in template arguments

dankm updated this revision to Diff 530563. dankm added a comment. Rebase and hopefully fix builds. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152570/new/ https://reviews.llvm.org/D152570 Files: clang/docs/ReleaseNotes.rst

[PATCH] D143984: [DebugMetadata] Simplify handling subprogram's retainedNodes field. NFCI (1/7)

dzhidzhoev added a comment. Updated DebugInfo test of OCaml binding. In D143984#4409015 , @dblaikie wrote: > When we migrated to github we gained higher fidelity for attributing authors > (we can now commit on someone's behalf but have the commit

  1   2   >