[PATCH] D151696: [x86] Remove CPU_SPECIFIC* MACROs and add getManglingForCPU

FreddyYe added a comment. This patch means to remove `CPU_SPECIFIC*` MACROs in X86TargetParser.def and move that part of functionality into X86TargetParser.cpp. Since these two files **both** maintain a table with `cpuname`, `features of this cpu supported`, ... This move can reduce the codes.

[PATCH] D151696: [x86] Remove CPU_SPECIFIC* MACROs and add getManglingForCPU

FreddyYe updated this revision to Diff 531615. FreddyYe added a comment. misc refine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151696/new/ https://reviews.llvm.org/D151696 Files: clang/lib/Basic/Targets/X86.cpp

[PATCH] D148697: [clang-tidy] Add more checks for functions which should be noexcept

Dinistro added a comment. Sorry for the noise. I didn't pull in between the different runs and was still on the broken version. Thanks for fixing this issue :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148697/new/

[PATCH] D152782: [CodeGen] Remove unused declaration/function GetOrCreateRTTIProxyGlobalVariable

This revision was automatically updated to reflect the committed changes. Closed by commit rG8fd80d1d1366: [CodeGen] Remove unused function GetOrCreateRTTIProxyGlobalVariable (authored by kazu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 8fd80d1 - [CodeGen] Remove unused function GetOrCreateRTTIProxyGlobalVariable

Author: Kazu Hirata Date: 2023-06-14T22:04:40-07:00 New Revision: 8fd80d1d136685688ff49c9d80552bbb7addbda4 URL: https://github.com/llvm/llvm-project/commit/8fd80d1d136685688ff49c9d80552bbb7addbda4 DIFF: https://github.com/llvm/llvm-project/commit/8fd80d1d136685688ff49c9d80552bbb7addbda4.diff

[PATCH] D152321: [clang] Replace use of Type::getPointerTo() (NFC)

barannikov88 added a comment. I guess you need to rebase onto 066fb7a5 at least. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152321/new/ https://reviews.llvm.org/D152321

[PATCH] D152696: Prevent deadlocks in death tests.

This revision was automatically updated to reflect the committed changes. Closed by commit rGdfbcee286b9b: Prevent deadlocks in death tests. (authored by mboehme). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152696/new/

[PATCH] D137524: clang/AMDGPU: Emit atomicrmw for atomic_inc/dec builtins

pravinjagtap accepted this revision as: pravinjagtap. pravinjagtap added a comment. LGTM, In the context of atomic optimizer, when we extend the support for `atomicInc` and `atomicDec`, I think, the visitor of AtomicRMWInst will find the potential candidate for optimization now instead of

[PATCH] D152321: [clang] Replace use of Type::getPointerTo() (NFC)

barannikov88 accepted this revision. barannikov88 added a comment. This revision is now accepted and ready to land. LGTM with CI fixed, thanks. I'd like @nikic to also take a look though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152321/new/

[PATCH] D152880: [clang][NFC] Add a notice to desugarForDiagnostic

This revision was automatically updated to reflect the committed changes. Closed by commit rG0e08374abb2c: [clang][NFC] Add a notice to desugarForDiagnostic (authored by zyounan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152880/new/

[clang] 0e08374 - [clang][NFC] Add a notice to desugarForDiagnostic

Author: Younan Zhang Date: 2023-06-15T11:55:06+08:00 New Revision: 0e08374abb2c61a3ae5c24d5f60be3b548da9778 URL: https://github.com/llvm/llvm-project/commit/0e08374abb2c61a3ae5c24d5f60be3b548da9778 DIFF: https://github.com/llvm/llvm-project/commit/0e08374abb2c61a3ae5c24d5f60be3b548da9778.diff

[PATCH] D152279: [Driver] Default -msmall-data-limit= to 0

MaskRay added a comment. Thank you for chiming in. I disagree that we keep default=8 for embedded without understanding (a) why 8 provides values and (b) justifying that the value is significant enough for embedded to be different. I think Alex's argument "I think we can generally expect more

[PATCH] D152279: [Driver] Default -msmall-data-limit= to 0

shiva0217 added a comment. In D152279#4422887 , @MaskRay wrote: > In D152279#4420312 , @asb wrote: > >> In D152279#4415974 , @MaskRay >> wrote: >> >>> However, RISC-V

[PATCH] D152924: [libLTO][AIX] Respect `-f[no]-integrated-as` on AIX

shchenz added a comment. @qiongsiwu1 Hi, thanks for the patch. Almost good to me, except one small nit. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:700 +CmdArgs.push_back(Args.MakeArgString( +Twine(PluginOptPrefix) + "-no-integrated-as=" +

[PATCH] D151349: [HIP] emit macro `__HIP_NO_IMAGE_SUPPORT`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc0f0d50653e1: [HIP] emit macro `__HIP_NO_IMAGE_SUPPORT` (authored by yaxunl). Herald added a project: clang. Changed prior to commit:

[clang] c0f0d50 - [HIP] emit macro `__HIP_NO_IMAGE_SUPPORT`

Author: Yaxun (Sam) Liu Date: 2023-06-14T22:53:41-04:00 New Revision: c0f0d50653e16145beee474a3d0d602596502dde URL: https://github.com/llvm/llvm-project/commit/c0f0d50653e16145beee474a3d0d602596502dde DIFF:

[PATCH] D151696: [WIP] Remove CPU_SPECIFIC* MACROs and use unified getManglingForCPU

FreddyYe updated this revision to Diff 531596. FreddyYe added a comment. Update to a more conservative change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151696/new/ https://reviews.llvm.org/D151696 Files: clang/lib/Basic/Targets/X86.cpp

[PATCH] D152989: Pre-commit test for D151696.

FreddyYe created this revision. Herald added a project: All. FreddyYe requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Meanwhile this patch added missing tests for supported CPU names of cpu_dispatch/specific attribute. Repository: rG

[PATCH] D152321: [clang] Replace use of Type::getPointerTo() (NFC)

JOE1994 added inline comments. Comment at: clang/lib/CodeGen/CGBuilder.h:170 Address CreateElementBitCast(Address Addr, llvm::Type *Ty, const llvm::Twine = "") { +return Address(Addr.getPointer(), Ty, barannikov88 wrote: >

[PATCH] D152321: [clang] Replace use of Type::getPointerTo() (NFC)

JOE1994 updated this revision to Diff 531593. JOE1994 added a comment. - Apply suggestions from barannikov88 - Used `git clang-format` to tidy up code format Thank you for your feedback! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152321/new/

[clang] dc895d0 - [RISCV] Remove redundant line `NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py` from riscv64-zknd-zkne.c

Author: Jim Lin Date: 2023-06-15T10:22:06+08:00 New Revision: dc895d023e63fd9276fe493eded776e101015c86 URL: https://github.com/llvm/llvm-project/commit/dc895d023e63fd9276fe493eded776e101015c86 DIFF: https://github.com/llvm/llvm-project/commit/dc895d023e63fd9276fe493eded776e101015c86.diff LOG:

[PATCH] D152965: [OpenMP] Correctly diagnose conflicting target identifierers for AMDGPU

yaxunl accepted this revision. yaxunl added a comment. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152965/new/ https://reviews.llvm.org/D152965 ___ cfe-commits mailing list

[PATCH] D150023: [ABI] [C++20] [Modules] Don't generate vtable if the class is defined in other module unit

ChuanqiXu added a comment. Thanks for keeping the bot green. I see the failure comes from an ABI difference showed up in the test case. I'll try to address it and land it again later. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150023/new/

[PATCH] D152914: [Draft] Make __builtin_cpu builtins target-independent

arsenm added inline comments. Comment at: llvm/include/llvm/IR/Intrinsics.td:903-907 +// Load of a value provided by the system library at a fixed address. Used for +// accessing things like HWCAP word provided by GLIBC. +def int_fixed_addr_ld +:

[PATCH] D152764: [clang-tidy] Reserved-identifier: Improved AllowedIdentifiers option to support regular expressions

felix642 updated this revision to Diff 531590. felix642 added a comment. Renamed allowedIdentifiers to allowedIdentifiersRaw Moved regex parsing to a new method Moved entry in releaseNotes.rst Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D137872: Implement lambdas with inalloca parameters by forwarding to function without inalloca calling convention.

akhuang updated this revision to Diff 531571. akhuang added a comment. update test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137872/new/ https://reviews.llvm.org/D137872 Files: clang/include/clang/CodeGen/CGFunctionInfo.h

[PATCH] D137872: Implement lambdas with inalloca parameters by forwarding to function without inalloca calling convention.

akhuang added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:1472 +// the call operator body. +EmitLambdaStaticInvokeBody(cast(FD)); } else if (FD->isDefaulted() && isa(FD) && efriedma wrote: > akhuang wrote: > > efriedma wrote: >

[PATCH] D137872: Implement lambdas with inalloca parameters by forwarding to function without inalloca calling convention.

akhuang updated this revision to Diff 531569. akhuang added a comment. Emit call op which forwards %this argument Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137872/new/ https://reviews.llvm.org/D137872 Files:

[PATCH] D152472: [Clang][MS] Remove assertion on BaseOffset can't be smaller than Size.

thakis added a comment. Also on http://45.33.8.238/win/79874/step_7.txt Reverted in 9c560350dd57d0dcb849c5915fa7c50b139ce671 for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152472/new/ https://reviews.llvm.org/D152472

[clang] 9c56035 - Revert "[Clang][MS] Remove assertion on BaseOffset can't be smaller than Size."

Author: Nico Weber Date: 2023-06-14T16:19:48-07:00 New Revision: 9c560350dd57d0dcb849c5915fa7c50b139ce671 URL: https://github.com/llvm/llvm-project/commit/9c560350dd57d0dcb849c5915fa7c50b139ce671 DIFF: https://github.com/llvm/llvm-project/commit/9c560350dd57d0dcb849c5915fa7c50b139ce671.diff

[PATCH] D150023: [ABI] [C++20] [Modules] Don't generate vtable if the class is defined in other module unit

thakis added a comment. Reverted in dbdd6372b7af2f6df5f41d19d966e6bac1b30208 for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150023/new/ https://reviews.llvm.org/D150023

[clang] dbdd637 - Revert "[ABI] [C++20] [Modules] Don't generate vtable if the class is defined in other module unit"

Author: Nico Weber Date: 2023-06-14T16:17:42-07:00 New Revision: dbdd6372b7af2f6df5f41d19d966e6bac1b30208 URL: https://github.com/llvm/llvm-project/commit/dbdd6372b7af2f6df5f41d19d966e6bac1b30208 DIFF: https://github.com/llvm/llvm-project/commit/dbdd6372b7af2f6df5f41d19d966e6bac1b30208.diff

[PATCH] D152975: [clang-format] Allow break after return keyword

gedare updated this revision to Diff 531561. gedare added a comment. - Regenerate ClangFormatStyleOptions.rst Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152975/new/ https://reviews.llvm.org/D152975 Files:

[PATCH] D152924: [libLTO][AIX] Respect `-f[no]-integrated-as` on AIX

steven_wu accepted this revision. steven_wu added a comment. This revision is now accepted and ready to land. I see. Sounds fine to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152924/new/ https://reviews.llvm.org/D152924

[PATCH] D152804: [clang-format] Propose a new solution to - Fix overlapping replacements before PPDirectives

owenpan added a comment. I've updated D151954 . If that doesn't work, we should land this patch and continue to work on a more general solution. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152804/new/

[PATCH] D152977: [NFC] Fix potential dereferencing of null return value.

schittir created this revision. schittir added reviewers: aaron.ballman, tahonermann, erichkeane. Herald added subscribers: steakhal, martong. Herald added a reviewer: NoQ. Herald added a project: All. schittir requested review of this revision. Herald added a project: clang. Herald added a

[PATCH] D152975: [clang-format] Allow break after return keyword

gedare updated this revision to Diff 531557. gedare added a comment. Regenerate docs Herald added a comment. NOTE: Clang-Format Team Automated Review Comment Your review contains a change to ClangFormatStyleOptions.rst but not a change to clang/include/clang/Format/Format.h

[PATCH] D152976: Regenerate ClangFormatStyleOptions.rst

gedare created this revision. Herald added a project: All. Herald added a comment. gedare requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. NOTE: Clang-Format Team Automated Review Comment Your review contains a change to

[PATCH] D148385: [RISCV] Implement KCFI operand bundle lowering

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Will be good to wait a few days to give regular RISC-V backend developers a chance to leave any final comments. Comment at: llvm/lib/Target/RISCV/RISCVAsmPrinter.cpp:332

[PATCH] D152975: [clang-format] Allow break after return keyword

gedare created this revision. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan, MyDeveloperDay. gedare requested review of this revision. Herald added a comment. NOTE: Clang-Format Team Automated

[PATCH] D151954: [clang-format] Fix overlapping whitespace replacements before PPDirective

owenpan updated this revision to Diff 531538. owenpan edited the summary of this revision. owenpan added a reviewer: paulkirth. owenpan removed a subscriber: paulkirth. owenpan added a comment. Add a member `Newlines` to `struct FormatToken` and compute it only once in

[clang] fc60bf2 - [DebugInfo] Always emit `.debug_names` with DWARF 5 for Apple platforms

Author: Jonas Devlieghere Date: 2023-06-14T15:28:33-07:00 New Revision: fc60bf2de11149d2c027d63e7ad5a98afa6fab80 URL: https://github.com/llvm/llvm-project/commit/fc60bf2de11149d2c027d63e7ad5a98afa6fab80 DIFF:

[PATCH] D152472: [Clang][MS] Remove assertion on BaseOffset can't be smaller than Size.

leonardchan added a comment. Hi. I think this caused the override-layout.cpp test to fail on our windows builder (https://logs.chromium.org/logs/fuchsia/buildbucket/cr-buildbucket/8778279637538184401/+/u/clang/test/stdout?format=raw): FAIL: Clang :: CodeGenCXX/override-layout.cpp (7816 of

[PATCH] D152279: [Driver] Default -msmall-data-limit= to 0

MaskRay added a comment. In D152279#4420312 , @asb wrote: > In D152279#4415974 , @MaskRay wrote: > >> However, RISC-V `-msmall-data-limit=` is probably a case warranting a >> difference. >> The global pointer

[PATCH] D146777: [clang] Preliminary fat-lto-object support

paulkirth updated this revision to Diff 531534. paulkirth added a comment. Rebase and pass fat-lto-objects to LLD from clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146777/new/ https://reviews.llvm.org/D146777 Files:

[PATCH] D148827: -fsanitize=function: support C

glandium added a comment. In D148827#4422794 , @MaskRay wrote: > 6.3.2.3.1 is about a pointer casting rule, which is different from type > compatibility. Pointer _conversion_ rule. Specifically, these are implicit conversions that require no casting.

[PATCH] D150226: [Clang] Remove ability to downgrade warning on the diagnostic for setting a non fixed enum to a value outside the range of the enumeration values

dblaikie added a comment. In D150226#4417539 , @aaron.ballman wrote: > In D150226#4408980 , @dblaikie > wrote: > >> In D150226#4408563 , @erichkeane >> wrote: >> >>>

[PATCH] D152965: [OpenMP] Correctly diagnose conflicting target identifierers for AMDGPU

jhuber6 updated this revision to Diff 531531. jhuber6 added a comment. Clang format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152965/new/ https://reviews.llvm.org/D152965 Files: clang/lib/Driver/Driver.cpp

[PATCH] D152965: [OpenMP] Correctly diagnose conflicting target identifierers for AMDGPU

jhuber6 created this revision. jhuber6 added reviewers: JonChesterfield, yaxunl, jdoerfert. Herald added subscribers: sunshaoce, kerbowa, guansong, tpr, dstuttard, jvesely, kzhuravl. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits,

[PATCH] D152882: [LinkerWrapper] Support device binaries in multiple link jobs

jhuber6 added a comment. In D152882#4422797 , @yaxunl wrote: > In D152882#4422788 , @jhuber6 wrote: > >> In D152882#4421138 , @yaxunl wrote: >> >>> However, bitcode of

[PATCH] D152882: [LinkerWrapper] Support device binaries in multiple link jobs

yaxunl added a comment. In D152882#4422788 , @jhuber6 wrote: > In D152882#4421138 , @yaxunl wrote: > >> However, bitcode of target ID gfx90a:xnack+ is allowed to link in bitcode >> of target ID gfx90a as long

[PATCH] D148827: -fsanitize=function: support C

MaskRay added a comment. In D148827#4422709 , @glandium wrote: > OTOH. 6.2.7.3: > >> A composite type can be constructed from two types that are compatible; it >> is a type that is compatible with both of the two types (...) > > 6.2.7.5: > >> EXAMPLE

[PATCH] D152473: [clang-format] Add test case for issue 63170

owenpan added a comment. In D152473#4410030 , @paulkirth wrote: > In D152473#4409975 , > @MyDeveloperDay wrote: > >> In D152473#4409146 , @paulkirth >> wrote: >> >>>

[PATCH] D152882: [LinkerWrapper] Support device binaries in multiple link jobs

jhuber6 added a comment. In D152882#4421138 , @yaxunl wrote: > However, bitcode of target ID gfx90a:xnack+ is allowed to link in bitcode of > target ID gfx90a as long as they are from different containers. So there are > two rules about target ID: 1.

[PATCH] D152882: [LinkerWrapper] Support device binaries in multiple link jobs

jhuber6 updated this revision to Diff 531520. jhuber6 added a comment. Herald added subscribers: kerbowa, jvesely. Adjusting test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152882/new/ https://reviews.llvm.org/D152882 Files:

[clang-tools-extra] cf1c6da - [clang-tidy][NFC] Update ReleaseNotes to mention some performance changes in checks

Author: Piotr Zegar Date: 2023-06-14T21:20:37Z New Revision: cf1c6dae84320ca0a50da34c4e9bff89d2d82286 URL: https://github.com/llvm/llvm-project/commit/cf1c6dae84320ca0a50da34c4e9bff89d2d82286 DIFF: https://github.com/llvm/llvm-project/commit/cf1c6dae84320ca0a50da34c4e9bff89d2d82286.diff LOG:

[PATCH] D148827: -fsanitize=function: support C

glandium added a comment. OTOH. 6.2.7.3: > A composite type can be constructed from two types that are compatible; it is > a type that is compatible with both of the two types (...) 6.2.7.5: > EXAMPLE Given the following two file scope declarations: > int f(int (*)(), double (*)[3]); > int

[clang] 04c0161 - Revert "[DebugInfo] Always emit `.debug_names` with DWARF 5 for Apple platforms"

Author: Jonas Devlieghere Date: 2023-06-14T14:16:16-07:00 New Revision: 04c0161c027676119fdc617f5b883dbda97c8549 URL: https://github.com/llvm/llvm-project/commit/04c0161c027676119fdc617f5b883dbda97c8549 DIFF:

[PATCH] D148697: [clang-tidy] Add more checks for functions which should be noexcept

nemanjai added a comment. In D148697#4422642 , @PiotrZSL wrote: > In D148697#4422629 , @nemanjai > wrote: > >> It was also causing PPC bots to break. I fixed it in >>

[PATCH] D148697: [clang-tidy] Add more checks for functions which should be noexcept

PiotrZSL added a comment. In D148697#4422629 , @nemanjai wrote: > It was also causing PPC bots to break. I fixed it in > https://reviews.llvm.org/rGffd7a200fdfbd01ef296101647d2f2da91ddfd41 O, thank you. Thats explain a lot. Because when I look into

[PATCH] D148827: -fsanitize=function: support C

MaskRay added a comment. In D148827#4422498 , @glandium wrote: > In D148827#4379764 , @MaskRay wrote: > >> These cases are UB and should be caught. It's not an excuse that they use C. > > Are they really though?

[PATCH] D148697: [clang-tidy] Add more checks for functions which should be noexcept

nemanjai added a comment. In D148697#4421739 , @Dinistro wrote: > In D148697#4421643 , @PiotrZSL > wrote: > >> @Dinistro It compiles & links with clang 16 also (shared libs). So I'm >> unable to reproduce. > >

[clang] 5d54213 - [Clang][MS] Remove assertion on BaseOffset can't be smaller than Size.

Author: Zequan Wu Date: 2023-06-14T16:48:26-04:00 New Revision: 5d54213ee557a86fae82af0f75498adf02f24e82 URL: https://github.com/llvm/llvm-project/commit/5d54213ee557a86fae82af0f75498adf02f24e82 DIFF: https://github.com/llvm/llvm-project/commit/5d54213ee557a86fae82af0f75498adf02f24e82.diff

[PATCH] D152472: [Clang][MS] Remove assertion on BaseOffset can't be smaller than Size.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5d54213ee557: [Clang][MS] Remove assertion on BaseOffset cant be smaller than Size. (authored by zequanwu). Repository: rG LLVM Github Monorepo

[clang] 8193b29 - Revert "[HIP] Allow std::malloc in device function"

Author: Yaxun (Sam) Liu Date: 2023-06-14T16:33:30-04:00 New Revision: 8193b291cefa732dd37fc917bd2921385e639d21 URL: https://github.com/llvm/llvm-project/commit/8193b291cefa732dd37fc917bd2921385e639d21 DIFF:

[PATCH] D152818: [Clang] Fix assertion when pragma FENV_ACCESS is used with a throw function.

zahiraam added a comment. In D152818#4421064 , @nicolerabjohn wrote: > I've opened an issue (https://github.com/llvm/llvm-project/issues/63063) > where we hit the same assertion. There's a smaller test case, and we've done > enough investigation that

[PATCH] D148827: -fsanitize=function: support C

glandium added a comment. In D148827#4379764 , @MaskRay wrote: > These cases are UB and should be caught. It's not an excuse that they use C. Are they really though? struct A { int a; }; int foo(struct A *a) { return 42; } int

[PATCH] D59528: [clang-tidy] Expand modular headers for PPCallbacks

PiotrZSL added a comment. Herald added subscribers: carlosgalvezp, shchenz. Herald added a project: All. Looks like this change is responsible for https://github.com/llvm/llvm-project/issues/59807 and https://github.com/llvm/llvm-project/issues/62337 issues. Repository: rL LLVM CHANGES

[PATCH] D152741: [WPD] implement -fskip-vtable-filepaths

modimo added a comment. In D152741#4421067 , @tejohnson wrote: > In D152741#4419366 , @modimo wrote: > >> In D152741#4419324 , @tejohnson >> wrote: >> >>> In

[PATCH] D148385: [RISCV] Implement KCFI operand bundle lowering

samitolvanen added a comment. > Needs some thoughts to merge the above paragraphs with the existing one Great points. I updated the commit message and tried to capture most of these, PTAL. Comment at: llvm/lib/Target/RISCV/RISCVAsmPrinter.cpp:332 + continue; +while

[PATCH] D148385: [RISCV] Implement KCFI operand bundle lowering

samitolvanen updated this revision to Diff 531476. samitolvanen marked 9 inline comments as done. samitolvanen added a comment. Addressed feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148385/new/ https://reviews.llvm.org/D148385 Files:

[PATCH] D152856: [Driver] Allow warning for unclaimed TargetSpecific options

mstorsjo added inline comments. Comment at: llvm/include/llvm/Option/Arg.h:53 + /// This is used for generating an "argument unused" warning (without + /// clang::driver::options::TargetSpecific) or "unsupported option" error + /// (with TargetSpecific).

[PATCH] D118754: [DebugInfo] Always emit `.debug_names` with dwarf 5 for Apple platforms

This revision was automatically updated to reflect the committed changes. Closed by commit rGe0d57295bf6a: [DebugInfo] Always emit `.debug_names` with DWARF 5 for Apple platforms (authored by JDevlieghere). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG

[clang] e0d5729 - [DebugInfo] Always emit `.debug_names` with DWARF 5 for Apple platforms

Author: Jonas Devlieghere Date: 2023-06-14T13:03:31-07:00 New Revision: e0d57295bf6a3c04f2901d9c70f529d570f48b65 URL: https://github.com/llvm/llvm-project/commit/e0d57295bf6a3c04f2901d9c70f529d570f48b65 DIFF:

[PATCH] D152856: [Driver] Allow warning for unclaimed TargetSpecific options

MaskRay added inline comments. Comment at: llvm/include/llvm/Option/Arg.h:53 + /// This is used for generating an "argument unused" warning (without + /// clang::driver::options::TargetSpecific) or "unsupported option" error + /// (with TargetSpecific).

[PATCH] D152472: [Clang][MS] Remove assertion on BaseOffset can't be smaller than Size.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152472/new/ https://reviews.llvm.org/D152472

[PATCH] D151587: [clang][ConstantEmitter] have tryEmitPrivate[ForVarInit] try ConstExprEmitter fast-path first

efriedma added inline comments. Comment at: clang/lib/CodeGen/CGExprConstant.cpp:917 + bool VisitArraySubscriptExpr(const ArraySubscriptExpr *A) { +return Visit(A->getBase()) || Visit(A->getIdx()); + } Should only need to visit base, not idx. Repository:

[PATCH] D152946: [C++20][Modules] Implement P2615R1 revised export diagnostics.

iains created this revision. Herald added a subscriber: ChuanqiXu. Herald added a project: All. iains added a reviewer: ChuanqiXu. iains added a subscriber: clang-modules. iains edited the summary of this revision. iains published this revision for review. iains added a comment. Herald added a

[PATCH] D137872: Implement lambdas with inalloca parameters by forwarding to function without inalloca calling convention.

efriedma added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:1472 +// the call operator body. +EmitLambdaStaticInvokeBody(cast(FD)); } else if (FD->isDefaulted() && isa(FD) && akhuang wrote: > efriedma wrote: > > Does this pass

[clang-tools-extra] dc4359f - [clang-tidy] Fix wrong code generation for `modernize-loop-convert` with structured bindings.

Author: AMS21 Date: 2023-06-14T18:57:29Z New Revision: dc4359fecf02f4230b4a5b900077c29d1b90f4ab URL: https://github.com/llvm/llvm-project/commit/dc4359fecf02f4230b4a5b900077c29d1b90f4ab DIFF: https://github.com/llvm/llvm-project/commit/dc4359fecf02f4230b4a5b900077c29d1b90f4ab.diff LOG:

[PATCH] D152852: [clang-tidy] Fix wrong code generation for `modernize-loop-convert` with structured bindings.

This revision was automatically updated to reflect the committed changes. Closed by commit rGdc4359fecf02: [clang-tidy] Fix wrong code generation for `modernize-loop-convert` with… (authored by AMS21, committed by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D142994: [UsersManual] Add llvm-progen as an alternative tool for AutoFDO profile generation.

hoy added a comment. In D142994#4094193 , @wenlei wrote: > Given llvm-profgen is in llvm tree, I'm wondering if it makes sense to treat > it first option instead of alternative to out of tree create_llvm_prof. wdyt > @davidxl @davidxl any thought on

[PATCH] D152226: [FunctionAttrs] Propagate some func/arg/ret attributes from caller to callsite (WIP)

goldstein.w.n added inline comments. Comment at: llvm/lib/Transforms/Utils/InferCallsiteAttrs.cpp:597 + // callsite violating the constraint. + if (checkCallerDoesNotAccessMemory() && !CB->doesNotAccessMemory()) { +// Wait until we know we actually need it to do

[PATCH] D152396: [clang][doc] Rescue some deleted bits of the command-line reference.

This revision was automatically updated to reflect the committed changes. Closed by commit rGf51924d124bd: [clang docs] Rescue some deleted bits of the command-line reference. (authored by efriedma). Changed prior to commit: https://reviews.llvm.org/D152396?vs=529422=531448#toc Repository:

[clang] f51924d - [clang docs] Rescue some deleted bits of the command-line reference.

Author: Eli Friedman Date: 2023-06-14T11:44:02-07:00 New Revision: f51924d124bdd0e089cd28756578cec13ede1a8c URL: https://github.com/llvm/llvm-project/commit/f51924d124bdd0e089cd28756578cec13ede1a8c DIFF: https://github.com/llvm/llvm-project/commit/f51924d124bdd0e089cd28756578cec13ede1a8c.diff

[PATCH] D148697: [clang-tidy] Add more checks for functions which should be noexcept

PiotrZSL added a comment. In D148697#4421739 , @Dinistro wrote: > In D148697#4421643 , @PiotrZSL > wrote: > >> @Dinistro It compiles & links with clang 16 also (shared libs). So I'm >> unable to reproduce. > >

[PATCH] D152788: [Clang] Show type in enum out of range diagnostic

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG69d42eef4bec: [Clang] Show type in enum out of range diagnostic (authored by dim). Changed prior to commit:

[clang] 69d42ee - [Clang] Show type in enum out of range diagnostic

Author: Dimitry Andric Date: 2023-06-14T20:34:19+02:00 New Revision: 69d42eef4bec208a2312bfa0d2194013817eeba0 URL: https://github.com/llvm/llvm-project/commit/69d42eef4bec208a2312bfa0d2194013817eeba0 DIFF:

[PATCH] D147218: [OpenMP][Flang][MLIR] Lowering of OpenMP requires directive from parse tree to MLIR

skatrak requested review of this revision. skatrak added a comment. Changing status to "Request Review" again due to some significant changes to the approach. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147218/new/

[PATCH] D152720: [clangd][ObjC] Support ObjC class rename from implementation decls

dgoldman updated this revision to Diff 531439. dgoldman added a comment. - Implement discussed fixes + category support Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152720/new/ https://reviews.llvm.org/D152720 Files:

[PATCH] D93829: [clangd] Support outgoing calls in call hierarchy

qchateau added a comment. I'm interested but I don't have enough free time these days. So if anyone wants to take it from there, feel free to reuse my commits (or not). If I find myself with some free time and nobody else is working on this, I'll give it a shot Repository: rG LLVM Github

[PATCH] D152472: [Clang][MS] Remove assertion on BaseOffset can't be smaller than Size.

zequanwu updated this revision to Diff 531438. zequanwu marked 5 inline comments as done. zequanwu added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152472/new/ https://reviews.llvm.org/D152472 Files:

[PATCH] D147218: [OpenMP][Flang][MLIR] Lowering of OpenMP requires directive from parse tree to MLIR

skatrak updated this revision to Diff 531437. skatrak added a comment. Update patch to integrate with related patch D149337 and address reviewer's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D152882: [LinkerWrapper] Support device binaries in multiple link jobs

jhuber6 added a comment. In D152882#4421138 , @yaxunl wrote: > The design of target ID put constraints on target ID's that can be embedded > into one executable > https://clang.llvm.org/docs/ClangOffloadBundler.html#bundle-entry-id . For > example,

[PATCH] D137872: Implement lambdas with inalloca parameters by forwarding to function without inalloca calling convention.

akhuang updated this revision to Diff 531435. akhuang added a comment. Call GenerateCode to emit __impl function body Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137872/new/ https://reviews.llvm.org/D137872 Files:

[PATCH] D137872: Implement lambdas with inalloca parameters by forwarding to function without inalloca calling convention.

akhuang added inline comments. Comment at: clang/lib/CodeGen/CGClass.cpp:3097 + FD->getLocation(), FD->getLocation()); +CGF.EmitFunctionBody(FD->getBody()); +CGF.FinishFunction(); efriedma wrote: > Is there any way we can use

[PATCH] D93829: [clangd] Support outgoing calls in call hierarchy

nridge added a comment. Thank you Sam for the suggested performance improvements, and outlining a way forward. @qchateau, are you interested in updating the patch to implement some of the described optimizations / address other comments? Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D152788: [Clang] Show type in enum out of range diagnostic

dim added inline comments. Comment at: clang/test/SemaCXX/constant-expression-cxx11.cpp:2479-2486 +template struct Bitfield { + static constexpr T max = static_cast((1 << size) - 1); +}; + +void testValueInRangeOfEnumerationValuesViaTemplate() { + Bitfield good; + Bitfield

[PATCH] D152500: [clangd] Unwrap type sugar in HeuristicResolver::resolveTypeToRecordDecl()

This revision was automatically updated to reflect the committed changes. Closed by commit rG19c9af81b1c5: [clangd] Unwrap type sugar in HeuristicResolver::resolveTypeToRecordDecl() (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 19c9af8 - [clangd] Unwrap type sugar in HeuristicResolver::resolveTypeToRecordDecl()

Author: Nathan Ridge Date: 2023-06-14T13:51:00-04:00 New Revision: 19c9af81b1c5dd7b3d11d235a77b7181b9368a28 URL: https://github.com/llvm/llvm-project/commit/19c9af81b1c5dd7b3d11d235a77b7181b9368a28 DIFF: https://github.com/llvm/llvm-project/commit/19c9af81b1c5dd7b3d11d235a77b7181b9368a28.diff

  1   2   3   >