[PATCH] D153835: [Sema] Clone VisibilityAttr for functions in template instantiations

MaskRay updated this revision to Diff 534842. MaskRay edited the summary of this revision. MaskRay added a comment. remove a misleading comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153835/new/ https://reviews.llvm.org/D153835 Files:

[PATCH] D153835: [Sema] Clone VisibilityAttr for functions in template instantiations

MaskRay created this revision. MaskRay added reviewers: clang, aaron.ballman, efriedma, rjmccall, smeenai. Herald added a project: All. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix

[clang] 32c7efd - [test] Improve symbol visibility test

Author: Fangrui Song Date: 2023-06-26T22:20:02-07:00 New Revision: 32c7efddfde9e59d88fcd9254b0433f6646d5b6d URL: https://github.com/llvm/llvm-project/commit/32c7efddfde9e59d88fcd9254b0433f6646d5b6d DIFF: https://github.com/llvm/llvm-project/commit/32c7efddfde9e59d88fcd9254b0433f6646d5b6d.diff

[PATCH] D129635: [OpenMP] Update the default version of OpenMP to 5.1

saiislam added a comment. @jdoerfert @RaviNarayanaswamy @ABataev Are there any features in this table which have been already implemented but have not been tagged? https://clang.llvm.org/docs/OpenMPSupport.html#openmp-5-1-implementation-details Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D153006: [clang][dataflow] Perform deep copies in copy and move operations.

mboehme marked an inline comment as done. mboehme added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/RecordOps.cpp:20 + +void copyRecord(AggregateStorageLocation , AggregateStorageLocation , +Environment ) { MaskRay wrote: > See

[PATCH] D153833: [clang][dataflow] Use namespace qualifiers when defining functions.

mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. See

[PATCH] D105759: Implement P2361 Unevaluated string literals

ChuanqiXu added inline comments. Comment at: clang/lib/Lex/Pragma.cpp:807 if (Tok.is(tok::string_literal) && !Tok.hasUDSuffix()) { StringLiteralParser Literal(Tok, PP); if (Literal.hadError) aaron.ballman wrote: > aaron.ballman wrote: > > cor3ntin

[PATCH] D153542: [C++20][Modules] Implement P2615R1 exported specialization diagnostics.

ChuanqiXu added inline comments. Comment at: clang/lib/Sema/SemaModule.cpp:848-849 +if (auto *FD = dyn_cast(D)) { + if (FD->getTemplateSpecializationKind() == TSK_ExplicitSpecialization) +BadExport = true; +} else if (auto *VD = dyn_cast(D)) {

[PATCH] D153542: [C++20][Modules] Implement P2615R1 exported specialization diagnostics.

ChuanqiXu added inline comments. Comment at: clang/lib/Sema/SemaModule.cpp:848-849 +if (auto *FD = dyn_cast(D)) { + if (FD->getTemplateSpecializationKind() == TSK_ExplicitSpecialization) +BadExport = true; +} else if (auto *VD = dyn_cast(D)) {

[PATCH] D134334: [Clang] Fix crash in isCXXDeclarationSpecifier when attempting to annotate template name

shafik added a comment. ping @rsmith CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134334/new/ https://reviews.llvm.org/D134334 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D153580: [SystemZ][z/OS] Add support for z/OS link step (executable and shared libs)

SeanP updated this revision to Diff 534816. SeanP added a comment. Apply comments from D153582 for similar changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153580/new/ https://reviews.llvm.org/D153580 Files:

[PATCH] D150646: [clang][X86] Add __cpuidex function to cpuid.h

aidengrossman added a comment. In D150646#4450551 , @glandium wrote: > Did you find something? Not yet. I just finished finals a week ago so I haven't had as much time as I would've liked to get through this. I'll contact some people tonight in regards

[PATCH] D144829: [WIP][BPF] Add a few new insns under cpu=v4

yonghong-song updated this revision to Diff 534801. yonghong-song added a comment. - avoid changing conditions during JMP -> JMPL conversion. Otherwise, verification may fail in some cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144829/new/

[PATCH] D153579: [clang-format] Fix RAS reference alignment when PAS is left or middle

owenpan added inline comments. Comment at: clang/lib/Format/WhitespaceManager.cpp:459 Changes[i].Spaces != 0) { for (int Previous = i - 1; Previous >= 0 && See below. Comment at:

[PATCH] D153585: [clang-format] Fix align consecutive declarations over function pointers

owenpan added inline comments. Comment at: clang/lib/Format/WhitespaceManager.cpp:869-871 if (C.Tok->is(TT_FunctionDeclarationName)) return true; +if (C.Tok->is(TT_FunctionTypeLParen)) We should merge the two `if` statements.

[PATCH] D152628: [RISCV] Add __builtin_riscv_zip/unzip for Zbkb to match gcc.

craig.topper added a comment. Herald added a subscriber: wangpc. In D152628#4416794 , @asb wrote: > I'm not super familiar with these builtins so this might be a silly question > why are the new builtins added in this patch LiLi (long int) rather than

[PATCH] D148869: [Driver][BareMetal] Support --emit-static-lib in BareMetal driver

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. phosek marked an inline comment as done. Closed by commit rG5614d1a0a10d: [Driver][BareMetal] Support --emit-static-lib in BareMetal driver (authored by phosek).

[PATCH] D148869: [Driver][BareMetal] Support --emit-static-lib in BareMetal driver

phosek marked an inline comment as done. phosek added inline comments. Comment at: clang/lib/Driver/ToolChains/BareMetal.cpp:170 bool BareMetal::handlesTarget(const llvm::Triple ) { return isARMBareMetal(Triple) || isAArch64BareMetal(Triple) ||

[clang] 5614d1a - [Driver][BareMetal] Support --emit-static-lib in BareMetal driver

Author: Petr Hosek Date: 2023-06-26T23:19:02Z New Revision: 5614d1a0a10de06887a9a021c104e601eb441413 URL: https://github.com/llvm/llvm-project/commit/5614d1a0a10de06887a9a021c104e601eb441413 DIFF: https://github.com/llvm/llvm-project/commit/5614d1a0a10de06887a9a021c104e601eb441413.diff LOG:

[PATCH] D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1

ychen updated this revision to Diff 534778. ychen added a comment. - add a DeductionCandidate parameter Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139837/new/ https://reviews.llvm.org/D139837 Files: clang/docs/ReleaseNotes.rst

[PATCH] D153667: [HIP]: Add gpu-link-output to control link job creation

jhuber6 added a comment. In D153667#4450705 , @jrbyrnes wrote: > In D153667#4450517 , @jhuber6 wrote: > >> What's the difference here between this and the existing `--hip-link`? > > Hi @jhuber6 > > The commit is

[PATCH] D152996: [RISCV][POC] Model frm control for vfadd

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInsertReadWriteCSR.cpp:105 +.addImm(FRMImm); +MI.addOperand(MachineOperand::CreateReg(RISCV::FRM, /*IsDef*/ false, +/*IsImp*/ true));

[PATCH] D153667: [HIP]: Add gpu-link-output to control link job creation

jrbyrnes added a comment. In D153667#4450517 , @jhuber6 wrote: > What's the difference here between this and the existing `--hip-link`? Hi @jhuber6 The commit is poorly named, the main purpose is to introduce `-no-gpu-link-output.` We want a way to

[PATCH] D153652: [Support] Don't set "all_exe" mode by default for file written by llvm::writeToOutput

avl added inline comments. Comment at: llvm/test/tools/llvm-dwarfutil/ELF/X86/mirror-permissions-unix.test:2 +## The Unix version of this test must use umask(1) because +## llvm-darfutil respects the umask in setting output permissions. +## Setting the umask to 0 ensures

[PATCH] D152986: [clang] Allow 'nomerge' attribute for function pointers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG06eee734c1ea: [clang] Allow nomerge attribute for function pointers (authored by eddyz87). Changed prior to commit:

[clang] 06eee73 - [clang] Allow 'nomerge' attribute for function pointers

Author: Eduard Zingerman Date: 2023-06-27T01:15:45+03:00 New Revision: 06eee734c1ea9de754c1e7e8c79c0897b9e01350 URL: https://github.com/llvm/llvm-project/commit/06eee734c1ea9de754c1e7e8c79c0897b9e01350 DIFF:

[PATCH] D153702: [Clang] Implement P2738R1 - constexpr cast from void*

shafik added inline comments. Comment at: clang/test/CXX/expr/expr.const/p5-26.cpp:13 +(void)static_cast(a); //cxx23-note {{cast from 'void *' is not allowed in a constant expression in C++ standards before C++2c}} +(void)static_cast(a); +(void)static_cast(a);

[clang] 214e7ce - [NFC] Bump up DIAG_SIZE_AST as we have hit the limit as of f27afed.

Author: Douglas Yung Date: 2023-06-26T14:35:03-07:00 New Revision: 214e7ce4e4b08b77fa5878bf1147419d66854167 URL: https://github.com/llvm/llvm-project/commit/214e7ce4e4b08b77fa5878bf1147419d66854167 DIFF: https://github.com/llvm/llvm-project/commit/214e7ce4e4b08b77fa5878bf1147419d66854167.diff

[PATCH] D150646: [clang][X86] Add __cpuidex function to cpuid.h

glandium added a comment. In D150646#4382763 , @aidengrossman wrote: > Interesting. I would've thought `-fms-extensions` by itself would've declared > that macro (which is what I gathered reading what caused the MSVC compatible > builtins to get

[PATCH] D152741: [WPD] implement -funknown-vtable-visibility-filepaths

modimo added a comment. In D152741#4445807 , @wenlei wrote: >> For concrete data are you talking about between the different solutions e.g. >> --lto-whole-program-visibility, -funknown-vtable-visibility-filepaths, RTTI >> based, FatLTO based etc or

[PATCH] D153667: [HIP]: Add gpu-link-output to control link job creation

jhuber6 added a comment. What's the difference here between this and the existing `--hip-link`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153667/new/ https://reviews.llvm.org/D153667 ___ cfe-commits

[clang] d54bd7a - [dataflow] Fix -Wunused-variable in -DLLVM_ENABLE_ASSERTIONS=off builds after D153006

Author: Fangrui Song Date: 2023-06-26T14:00:59-07:00 New Revision: d54bd7aced8b75e04a2925ce99c816f55c350428 URL: https://github.com/llvm/llvm-project/commit/d54bd7aced8b75e04a2925ce99c816f55c350428 DIFF: https://github.com/llvm/llvm-project/commit/d54bd7aced8b75e04a2925ce99c816f55c350428.diff

[PATCH] D153006: [clang][dataflow] Perform deep copies in copy and move operations.

MaskRay added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/RecordOps.cpp:20 + +void copyRecord(AggregateStorageLocation , AggregateStorageLocation , +Environment ) { See

[PATCH] D149280: [clang-tidy] Add modernize-printf-to-std-print check

PiotrZSL added a comment. In D149280#4450418 , @mikecrowe wrote: > Despite the fact that I've worked on what became this check for about two > years, now that it's landed I've suddenly spotted a significant flaw: > `printf` returns the number of

[PATCH] D153493: [dataflow] avoid more accidental copies of Environment

ymandel added a comment. In D153493#4450358 , @sammccall wrote: >> I realize the complexity is frustrating, but I don't see how that's related >> to the issue here. The complexity of the `JoinedStateBuilder` is caused by >> the desire to minimize

[PATCH] D149280: [clang-tidy] Add modernize-printf-to-std-print check

mikecrowe added a comment. Despite the fact that I've worked on what became this check for about two years, now that it's landed I've suddenly spotted a significant flaw: `printf` returns the number of characters printed, whereas `std::print` doesn't return anything. None of my test cases made

[PATCH] D153589: [NFC] Initialize pointer fields and remove a needless null check.

schittir added inline comments. Comment at: clang/lib/Analysis/CFG.cpp:4156 // CFG generation for unevaluated operands. - if (S && !S->isTypeDependent() && S->isPotentiallyEvaluated()) + if (!S->isTypeDependent() && S->isPotentiallyEvaluated()) return VisitChildren(S);

[PATCH] D153493: [dataflow] avoid more accidental copies of Environment

sammccall added a comment. In D153493#4450191 , @ymandel wrote: > I don't want to block the progress you're making elsewhere and I think the > concerns here are sufficiently localized to revisit another time. So, feel > free to reify any

[PATCH] D153582: [SystemZ][z/OS] Add required options/macro/etc for z/os compilation step

SeanP marked 3 inline comments as done. SeanP added a comment. Thanks. made these changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153582/new/ https://reviews.llvm.org/D153582 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D153582: [SystemZ][z/OS] Add required options/macro/etc for z/os compilation step

SeanP updated this revision to Diff 534729. SeanP added a comment. apply feedback CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153582/new/ https://reviews.llvm.org/D153582 Files: clang/include/clang/Driver/Options.td clang/lib/Basic/Targets/OSTargets.h

[PATCH] D153667: [HIP]: Add gpu-link-output to control link job creation

jrbyrnes updated this revision to Diff 534725. jrbyrnes marked an inline comment as done. jrbyrnes added a comment. Fix tests + add tests. Add phase test for -fgpu-rdc --no-gpu-link-output (these are not intended to be used together) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D153728: [llvm] Move AttributeMask to a separate header

nikic accepted this revision. nikic added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153728/new/ https://reviews.llvm.org/D153728 ___

[PATCH] D153418: Adding iconv support to CharSetConverter class

efriedma added a comment. > I think this is reasonable since gcc's fexec-charset option also says the > name can be any encoding supported by the iconv library (copy pasted below > from https://gcc.gnu.org/onlinedocs/gcc-13.1.0/gcc.pdf) so this would match > that behaviour "gcc did it"

[clang] 5c8d247 - [dataflow] Fix -Wunused-variable in -DLLVM_ENABLE_ASSERTIONS=off builds after D153006

Author: Fangrui Song Date: 2023-06-26T12:48:20-07:00 New Revision: 5c8d24732b75002df475e2af91220b2056a06979 URL: https://github.com/llvm/llvm-project/commit/5c8d24732b75002df475e2af91220b2056a06979 DIFF: https://github.com/llvm/llvm-project/commit/5c8d24732b75002df475e2af91220b2056a06979.diff

[PATCH] D150978: [clang][Sema] Add CodeCompletionContext::CCC_ObjCClassForwardDecl

dgoldman updated this revision to Diff 534714. dgoldman added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150978/new/ https://reviews.llvm.org/D150978 Files: clang-tools-extra/clangd/CodeComplete.cpp

[PATCH] D153493: [dataflow] avoid more accidental copies of Environment

ymandel accepted this revision. ymandel added a comment. This revision is now accepted and ready to land. I don't want to block the progress you're making elsewhere and I think the concerns here are sufficiently localized to revisit another time. So, feel free to reify any

[PATCH] D153417: New CharSetConverter wrapper class for ConverterEBCDIC

efriedma added a comment. In D153417#4449812 , @abhina.sreeskantharajan wrote: > In D153417#4438764 , @efriedma > wrote: > >> As I mentioned at >>

[PATCH] D153805: Expose DataflowAnalysisContext.querySolver().

ymandel accepted this revision. ymandel added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysisContext.h:178-181 + /// Possible outcomes are: + /// - `Satisfiable`: A satisfying assignment

[PATCH] D153691: [Driver][ARM] Warn about -mabi= for assembler input

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfe5bab537270: [Driver][ARM] Warn about -mabi= for assembler input (authored by MaskRay). Changed prior to commit:

[clang] fe5bab5 - [Driver][ARM] Warn about -mabi= for assembler input

Author: Fangrui Song Date: 2023-06-26T12:28:02-07:00 New Revision: fe5bab537270e21469b8dfe09aae2ec11f1aca7f URL: https://github.com/llvm/llvm-project/commit/fe5bab537270e21469b8dfe09aae2ec11f1aca7f DIFF: https://github.com/llvm/llvm-project/commit/fe5bab537270e21469b8dfe09aae2ec11f1aca7f.diff

[PATCH] D153805: Expose DataflowAnalysisContext.querySolver().

bazuzi created this revision. bazuzi added reviewers: ymandel, gribozavr2, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. bazuzi requested review of this revision. Herald added a project: clang. This allows for use of the same solver used by the DAC for additional solving

[PATCH] D153584: [dataflow] Make SAT solver deterministic

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd85c233e4b05: [dataflow] Make SAT solver deterministic (authored by sammccall). Changed prior to commit:

[clang] d85c233 - [dataflow] Make SAT solver deterministic

Author: Sam McCall Date: 2023-06-26T21:16:25+02:00 New Revision: d85c233e4b05497a6d8c6e3f2a5fd63d9eeb200d URL: https://github.com/llvm/llvm-project/commit/d85c233e4b05497a6d8c6e3f2a5fd63d9eeb200d DIFF: https://github.com/llvm/llvm-project/commit/d85c233e4b05497a6d8c6e3f2a5fd63d9eeb200d.diff

[PATCH] D153691: [Driver][ARM] Warn about -mabi= for assembler input

michaelplatings accepted this revision. michaelplatings added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153691/new/ https://reviews.llvm.org/D153691

[PATCH] D153493: [dataflow] avoid more accidental copies of Environment

sammccall updated this revision to Diff 534691. sammccall added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153493/new/ https://reviews.llvm.org/D153493 Files:

[PATCH] D151047: [clang-format] Fix indentation for selective formatting.

Sedeniono updated this revision to Diff 534688. Sedeniono added a comment. As suggested by @owenpan, split the commits differently. My previous statement, that the whole fix consists of a revert of D129064 was not entirely correct: The fix reintroduces the

[PATCH] D153493: [dataflow] avoid more accidental copies of Environment

sammccall marked an inline comment as done. sammccall added a comment. > Regarding the design. This looks like an optimal solution in terms of copying > but introduces lifetime risks and complexity that I'm uncomfortable with. FWIW I agree with the complexity (not the lifetime risks). I think

[PATCH] D153798: [clang-format] Correctly annotate operator free function call

rymiel created this revision. rymiel added reviewers: HazardyKnusperkeks, owenpan, MyDeveloperDay. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. rymiel requested review of this revision. The annotator correctly annotates an overloaded operator call when

[clang] afa1fc4 - OpenMP: Add fma math test

Author: Matt Arsenault Date: 2023-06-26T14:47:56-04:00 New Revision: afa1fc47b669d8cbd480cb50a0d10aea8e1e4007 URL: https://github.com/llvm/llvm-project/commit/afa1fc47b669d8cbd480cb50a0d10aea8e1e4007 DIFF:

[PATCH] D153226: OpenMP: Don't include stdbool.h in builtin headers

arsenm closed this revision. arsenm added a comment. dee1f5b32c3a6a5694c3bb2fbf68d162447a5970 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153226/new/ https://reviews.llvm.org/D153226

[PATCH] D152858: OpenMP: Use generated checks and pragma declare target

arsenm closed this revision. arsenm added a comment. 53d28b2a71063b974ec058ced614d1c95d5584fe CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152858/new/ https://reviews.llvm.org/D152858

[clang] dee1f5b - OpenMP: Don't include stdbool.h in builtin headers

Author: Matt Arsenault Date: 2023-06-26T14:45:09-04:00 New Revision: dee1f5b32c3a6a5694c3bb2fbf68d162447a5970 URL: https://github.com/llvm/llvm-project/commit/dee1f5b32c3a6a5694c3bb2fbf68d162447a5970 DIFF:

[clang] 53d28b2 - OpenMP: Use generated checks and pragma declare target

Author: Matt Arsenault Date: 2023-06-26T14:45:09-04:00 New Revision: 53d28b2a71063b974ec058ced614d1c95d5584fe URL: https://github.com/llvm/llvm-project/commit/53d28b2a71063b974ec058ced614d1c95d5584fe DIFF:

[PATCH] D152720: [clangd][ObjC] Support ObjC class rename from implementation decls

This revision was automatically updated to reflect the committed changes. Closed by commit rG1b66840f7103: [clangd][ObjC] Support ObjC class rename from implementation decls (authored by dgoldman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 1b66840 - [clangd][ObjC] Support ObjC class rename from implementation decls

Author: David Goldman Date: 2023-06-26T14:43:37-04:00 New Revision: 1b66840f71030f5d5934e99398a59c3485ba111e URL: https://github.com/llvm/llvm-project/commit/1b66840f71030f5d5934e99398a59c3485ba111e DIFF: https://github.com/llvm/llvm-project/commit/1b66840f71030f5d5934e99398a59c3485ba111e.diff

[PATCH] D153370: [RISCV] Add support for custom instructions for Sifive S76.

This revision was automatically updated to reflect the committed changes. Closed by commit rG4c37d30e22ae: [RISCV] Add support for custom instructions for Sifive S76. (authored by garvitgupta08, committed by craig.topper). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 4c37d30 - [RISCV] Add support for custom instructions for Sifive S76.

Author: Garvit Gupta Date: 2023-06-26T11:36:00-07:00 New Revision: 4c37d30e22ae655394c8b3a7e292c06d393b9b44 URL: https://github.com/llvm/llvm-project/commit/4c37d30e22ae655394c8b3a7e292c06d393b9b44 DIFF: https://github.com/llvm/llvm-project/commit/4c37d30e22ae655394c8b3a7e292c06d393b9b44.diff

[PATCH] D153092: [Clang][CodeGen]`vtable`, `typeinfo` et al. are globals

AlexVlx added a comment. In D153092#4448514 , @yaxunl wrote: > In D153092#4447445 , @AlexVlx wrote: > >> Fixed issue found via internal testing (thanks @yaxunl). > > Can we add a test to cover the regression

[PATCH] D153092: [Clang][CodeGen]`vtable`, `typeinfo` et al. are globals

AlexVlx updated this revision to Diff 534670. AlexVlx added a comment. Add missing test for `vtable` initializers on the `__device__` side. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153092/new/ https://reviews.llvm.org/D153092 Files: clang/lib/CodeGen/CGVTT.cpp

[PATCH] D153691: [Driver][ARM] Warn about -mabi= for assembler input

MaskRay updated this revision to Diff 534668. MaskRay marked an inline comment as done. MaskRay added a comment. Thanks for the comments. Improved comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153691/new/ https://reviews.llvm.org/D153691

[clang-tools-extra] 9aaf3cf - [clang-tidy][NFC] Repharse a lite bit documentation for misc-header-include-cycle check

Author: Piotr Zegar Date: 2023-06-26T18:20:39Z New Revision: 9aaf3cf9bfe803d0a32709aa160951a6675b5926 URL: https://github.com/llvm/llvm-project/commit/9aaf3cf9bfe803d0a32709aa160951a6675b5926 DIFF: https://github.com/llvm/llvm-project/commit/9aaf3cf9bfe803d0a32709aa160951a6675b5926.diff LOG:

[PATCH] D153417: New CharSetConverter wrapper class for ConverterEBCDIC

abhina.sreeskantharajan added a comment. In D153417#4438764 , @efriedma wrote: > As I mentioned at > https://discourse.llvm.org/t/rfc-enabling-fexec-charset-support-to-llvm-and-clang-reposting/71512 > , I think SimplifyLibCalls needs to be aware of

[PATCH] D153695: [clang][Interp] Fix passing parameters of composite type

shafik added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeEmitter.h:71 - /// Parameter indices. - llvm::DenseMap Params; + /// Parameter indices. > + llvm::DenseMap Params; I don't understand the additional comment, Comment

[PATCH] D152829: clang: Add start of header test for __clang_hip_libdevice_declares

arsenm added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152829/new/ https://reviews.llvm.org/D152829 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D153690: [clang][Sema] Remove dead diagnostic for loss of __unaligned qualifier

cjdb added a comment. Can we get a snippet of code to demonstrate what isn't being diagnosed anymore, please? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153690/new/ https://reviews.llvm.org/D153690

[PATCH] D153536: [Clang] Implement P2169 A nice placeholder with no name

shafik added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:18217 + NewFD->setIsPlaceholderVar(LangOpts.CPlusPlus && II && II->isPlaceholder()); if (PrevDecl && !isa(PrevDecl)) { cor3ntin wrote: > shafik wrote: > > Why can't we fold this into

[PATCH] D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1

erichkeane added a comment. Thanks for this! I have no concerns from what I can see, but I see the others are doing a very thorough review, so I'll let them do the approvals. Comment at: clang/include/clang/AST/DeclCXX.h:1911 setRangeEnd(EndLocation); -

[PATCH] D153493: [dataflow] avoid more accidental copies of Environment

ymandel added a comment. Just FYI (since you mentioned it in your description): LatticeEffect is vestigial and should be removed. It's now only used (properly) for widening. Regarding the design. This looks like an optimal solution in terms of copying but introduces lifetime risks and

[PATCH] D153179: [clang codegen] Fix ABI for HVA returns on AArch64 MSVC.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa1540e4852a9: [clang codegen] Fix ABI for HVA returns on AArch64 MSVC. (authored by efriedma). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] a1540e4 - [clang codegen] Fix ABI for HVA returns on AArch64 MSVC.

Author: Eli Friedman Date: 2023-06-26T10:45:41-07:00 New Revision: a1540e4852a90e7f72c996a3832edfd20968bd9e URL: https://github.com/llvm/llvm-project/commit/a1540e4852a90e7f72c996a3832edfd20968bd9e DIFF: https://github.com/llvm/llvm-project/commit/a1540e4852a90e7f72c996a3832edfd20968bd9e.diff

[PATCH] D153653: [clang][Interp] Make CXXTemporaryObjectExprs leave a value behind

shafik added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:1022 + +if (DiscardResult) + return this->emitPopPtr(E); Could you just pass `DiscardResult` to `visitLocalInitializer` CHANGES SINCE LAST ACTION

[PATCH] D105759: Implement P2361 Unevaluated string literals

cor3ntin updated this revision to Diff 534640. cor3ntin marked 2 inline comments as done. cor3ntin added a comment. Address some of Aaron's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105759/new/ https://reviews.llvm.org/D105759 Files:

[PATCH] D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1

cor3ntin added a comment. In D139837#4449536 , @ychen wrote: > In D139837#4449327 , @cor3ntin > wrote: > >> @ychen You probably want to update the description, i think it's updated >> (you implemented ctad for

[PATCH] D153649: [clang][Interp] Fix return statements with expresssion in void functions

shafik added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeStmtGen.cpp:312 return this->emitRet(*ReturnType, RS); +} else if (RE->getType()->isVoidType()) { + if (!this->visit(RE)) You could also guard the cleanup and `emitRet` above

[PATCH] D153293: [clang][WebAssembly] support wasm32-wasi shared libraries

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG55e199a2c9f4: [clang][WebAssembly] Support wasm32-wasi shared libraries (authored by dicej, committed by sbc100). Changed prior to commit:

[clang] 55e199a - [clang][WebAssembly] Support wasm32-wasi shared libraries

Author: Joel Dice Date: 2023-06-26T10:31:40-07:00 New Revision: 55e199a2c9f4b218499733d60129deffa0a025fe URL: https://github.com/llvm/llvm-project/commit/55e199a2c9f4b218499733d60129deffa0a025fe DIFF: https://github.com/llvm/llvm-project/commit/55e199a2c9f4b218499733d60129deffa0a025fe.diff

[PATCH] D151587: [clang][ConstantEmitter] have tryEmitPrivate[ForVarInit] try ConstExprEmitter fast-path first

efriedma added inline comments. Comment at: clang/test/CodeGenOpenCL/amdgpu-nullptr.cl:60 -// CHECK: @fold_priv ={{.*}} local_unnamed_addr addrspace(1) global ptr addrspace(5) addrspacecast (ptr null to ptr addrspace(5)), align 4 +// CHECK: @fold_priv ={{.*}}

[PATCH] D105759: Implement P2361 Unevaluated string literals

cor3ntin marked 6 inline comments as done. cor3ntin added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1411 let Documentation = [DeprecatedDocs]; + let ParseArgumentsAsUnevaluated = 1; } aaron.ballman wrote: > What is the plan for

[PATCH] D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1

ychen added a comment. In D139837#4449327 , @cor3ntin wrote: > @ychen You probably want to update the description, i think it's updated (you > implemented ctad for parenthesized ctrs) Thanks for the remainder, Corentin. Hopefully, this will be ready to

[PATCH] D153670: [clang/HeaderSearch] Make sure `loadSubdirectoryModuleMaps` doesn't cause loading of regular files

This revision was automatically updated to reflect the committed changes. Closed by commit rG03a0f4b61ca5: [clang/HeaderSearch] Make sure `loadSubdirectoryModuleMaps` doesnt cause… (authored by akyrtzi). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 03a0f4b - [clang/HeaderSearch] Make sure `loadSubdirectoryModuleMaps` doesn't cause loading of regular files

Author: Argyrios Kyrtzidis Date: 2023-06-26T10:18:02-07:00 New Revision: 03a0f4b61ca50a267a405a29ff1986473a55f9d9 URL: https://github.com/llvm/llvm-project/commit/03a0f4b61ca50a267a405a29ff1986473a55f9d9 DIFF:

[PATCH] D151587: [clang][ConstantEmitter] have tryEmitPrivate[ForVarInit] try ConstExprEmitter fast-path first

arsenm added inline comments. Comment at: clang/test/CodeGenOpenCL/amdgpu-nullptr.cl:60 -// CHECK: @fold_priv ={{.*}} local_unnamed_addr addrspace(1) global ptr addrspace(5) addrspacecast (ptr null to ptr addrspace(5)), align 4 +// CHECK: @fold_priv ={{.*}} local_unnamed_addr

[PATCH] D152686: [clangd] Enforce strict unused includes by default

cjdb added a comment. This patch seems to have broken clangd for a project of mine. Most of my headers are now flagged as not being directly used even though they're the root header for the symbol. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D151963: [clang][NFC] Remove trailing whitespaces and enforce it in lib, include and docs

aaron.ballman added a comment. In D151963#4449346 , @aaron.ballman wrote: > In D151963#4390675 , @erichkeane > wrote: > >> This looks fine to me. HOWEVER, please make sure to add this commit to >>

[PATCH] D147875: [clang][Diagnostics] Show line numbers when printing code snippets

jrtc27 added a comment. In D147875#4448545 , @hans wrote: > I noticed that at least for some cases of `-Wformat`, the line numbers on the > left seem to be off: https://github.com/llvm/llvm-project/issues/63524 That's because DisplayLineNo refers to

[PATCH] D105759: Implement P2361 Unevaluated string literals

cor3ntin marked 2 inline comments as done. cor3ntin added inline comments. Comment at: clang/lib/AST/Expr.cpp:1140 + case Unevaluated: +return sizeof(char); // Host; +break; aaron.ballman wrote: > shafik wrote: > > Why not grouped w/ `Ordinary` above? >

[PATCH] D105759: Implement P2361 Unevaluated string literals

aaron.ballman added a subscriber: ChuanqiXu. aaron.ballman added a comment. This also should update the cxx_status page and have a release note. Comment at: clang/include/clang/Basic/Attr.td:1411 let Documentation = [DeprecatedDocs]; + let ParseArgumentsAsUnevaluated = 1;

[PATCH] D105759: Implement P2361 Unevaluated string literals

cor3ntin marked 43 inline comments as done. cor3ntin added inline comments. Comment at: clang/lib/AST/Expr.cpp:1165 +unsigned CharByteWidth = mapCharByteWidth(Ctx.getTargetInfo(), Kind); +unsigned ByteLength = Str.size(); +assert((ByteLength % CharByteWidth == 0) &&

[PATCH] D152720: [clangd][ObjC] Support ObjC class rename from implementation decls

dgoldman updated this revision to Diff 534618. dgoldman marked an inline comment as done. dgoldman added a comment. Fixes for review + rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152720/new/ https://reviews.llvm.org/D152720 Files:

[PATCH] D153582: [SystemZ][z/OS] Add required options/macro/etc for z/os compilation step

MaskRay added inline comments. Comment at: clang/test/Driver/zos-comp.c:3 + +// RUN: %clang -c -### %s 2>&1 \ +// RUN:--target=s390x-ibm-zos \ wrap too quickly. The whole thing can be placed on one line. Comment at:

  1   2   3   >