[PATCH] D154758: [clang][Interp] Emit correct diagnostic for uninitialized reads

tbaeder updated this revision to Diff 538325. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154758/new/ https://reviews.llvm.org/D154758 Files: clang/lib/AST/Interp/Interp.cpp clang/test/AST/Interp/constexpr-nqueens.cpp clang/test/AST/Interp/cxx20.cpp

[PATCH] D154675: [Clang] Fix crash when emitting diagnostic for out of order designated initializers in C++

shafik updated this revision to Diff 538323. shafik marked an inline comment as done. shafik added a comment. -Add fix for wrong field in diagnostic CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154675/new/ https://reviews.llvm.org/D154675 Files: clang/lib/Sema/SemaInit.cpp

[PATCH] D105759: Implement P2361 Unevaluated string literals

barannikov88 added a comment. @cor3ntin I've been working on pretty much the same functionality in our downstream fork. I was not aware of the paper, nor of the ongoing work in this direction, and so I unfortunately missed the review. Thanks for this patch, it significantly reduces the number

[PATCH] D153725: [clang] Make amdgpu-arch tool work on Windows

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. yaxunl marked an inline comment as done. Closed by commit rG661d91a0fd4a: [clang] Make amdgpu-arch tool work on Windows (authored by yaxunl). Herald added a project:

[clang] 661d91a - [clang] Make amdgpu-arch tool work on Windows

Author: Yaxun (Sam) Liu Date: 2023-07-08T00:01:02-04:00 New Revision: 661d91a0fd4ad80ecc49ebb9e0fff01b4de2ce1c URL: https://github.com/llvm/llvm-project/commit/661d91a0fd4ad80ecc49ebb9e0fff01b4de2ce1c DIFF:

[PATCH] D154758: [clang][Interp] Emit correct diagnostic for uninitialized reads

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, shafik, cor3ntin. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This fixes a long standing diagnostic difference

[PATCH] D154396: [clang] Add support for SerenityOS

ADKaster planned changes to this revision. ADKaster added a comment. Planning to rebase on top of Generic_ELF per Petr's suggestion. Comment at: clang/lib/Driver/ToolChains/Serenity.cpp:85 + auto linkerIs = [Exec](const char *name) { +return

[PATCH] D154552: [clang-format] Add note directive generation for docs

gedare added a comment. It looks like this: F28163425: image.png Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154552/new/ https://reviews.llvm.org/D154552 ___

[PATCH] D153359: [clang][Diagnostics] Fix distant source ranges in bad-conversion notes

cjdb accepted this revision. cjdb added a comment. This revision is now accepted and ready to land. Yep! Thanks for working on this :-) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153359/new/ https://reviews.llvm.org/D153359 ___

[PATCH] D154552: [clang-format] Add note directive generation for docs

owenpan added a comment. Can you attach a screenshot of how the new `note` section would look like? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154552/new/ https://reviews.llvm.org/D154552 ___

[PATCH] D154755: [clang-format] Fix formatting of if statements with BlockIndent

gedare added a comment. Although I chose to preserve the existing behavior of `AlwaysBreak` and to mimic it for `BlockIndent`, I think it would be best to choose a consistent approach and document it. I also have a patch that does not apply the AlignAfterOpenBracket for if clauses, which could

[clang] 0556ab3 - [clang-format][NFC] Improve efficiency of isFunctionDeclarationName

Author: Owen Pan Date: 2023-07-07T16:29:36-07:00 New Revision: 0556ab33532964dd8720b3b3ebd87dfe459d81d2 URL: https://github.com/llvm/llvm-project/commit/0556ab33532964dd8720b3b3ebd87dfe459d81d2 DIFF: https://github.com/llvm/llvm-project/commit/0556ab33532964dd8720b3b3ebd87dfe459d81d2.diff

[PATCH] D154755: [clang-format] Fix formatting of if statements with BlockIndent

gedare created this revision. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan, MyDeveloperDay. gedare requested review of this revision. A bug with BlockIndent prevents line breaks within if (and

[PATCH] D122874: [clang] Add GNU spelling for no_unqiue_address attribute

philnik abandoned this revision. philnik added a comment. I'm dropping this in favour of D151683 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122874/new/ https://reviews.llvm.org/D122874

[PATCH] D154693: [RISCV] Remote redundant _ta suffix in RVV intrinsics builtins. NFC

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154693/new/ https://reviews.llvm.org/D154693

[PATCH] D153920: [clang] Move the clang formatting job to run-buildbot to fix the CI

philnik updated this revision to Diff 538290. philnik marked 7 inline comments as done. philnik added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153920/new/ https://reviews.llvm.org/D153920 Files:

[PATCH] D151761: clang-format: Add AlignConsecutiveShortCaseStatements

galenelias updated this revision to Diff 538288. galenelias marked 2 inline comments as done. galenelias added a comment. Addressed outstanding review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151761/new/ https://reviews.llvm.org/D151761 Files:

[PATCH] D141757: [clangd] allow extracting to variable for lambda expressions

5chmidti updated this revision to Diff 538289. 5chmidti added a comment. Ping, and: - removed mention of captures from the condition about blocking extraction because that is allowed - removed `(of a lambda)` from the following comment because it is not just about defaulted parameters of

[PATCH] D151761: clang-format: Add AlignConsecutiveShortCaseStatements

galenelias marked 6 inline comments as done. galenelias added inline comments. Comment at: clang/include/clang/Format/Format.h:380 +} +bool operator!=(const ShortCaseStatementsAlignmentStyle ) const { + return !(*this == R); HazardyKnusperkeks

[PATCH] D138499: [clangd] Extract Function: add hoisting support

5chmidti updated this revision to Diff 538286. 5chmidti added a comment. Ping, and: - change find_if of post-use detection to range-for with a filtered range - make `renderHoistedCall` a private member of `NewFunction` - remove the `Render` lambda in `renderHoistSet` in favor of putting the body

[PATCH] D154658: Optimize emission of `dynamic_cast` to final classes.

rsmith updated this revision to Diff 538283. rsmith added a comment. - Mark gep as inbounds. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154658/new/ https://reviews.llvm.org/D154658 Files: clang/lib/AST/ExprCXX.cpp

[PATCH] D154503: [Sema] Fix handling of functions that hide classes

shafik added reviewers: aaron.ballman, clang-language-wg. shafik added a comment. For more visibility. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154503/new/ https://reviews.llvm.org/D154503 ___ cfe-commits mailing list

[PATCH] D154658: Optimize emission of `dynamic_cast` to final classes.

rsmith marked an inline comment as done. rsmith added a comment. In D154658#4481225 , @rjmccall wrote: > In D154658#4479213 , @rsmith wrote: > >> I think (hope?) we should be able to apply this to a much larger

[PATCH] D154658: Optimize emission of `dynamic_cast` to final classes.

rsmith updated this revision to Diff 538281. rsmith added a comment. - Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154658/new/ https://reviews.llvm.org/D154658 Files: clang/lib/AST/ExprCXX.cpp

[PATCH] D131533: [Flang][Driver] Enable PIC in the frontend

clementval added inline comments. Herald added a subscriber: sunshaoce. Comment at: flang/test/Driver/pic-flags.f90:3 -! RUN: %flang -### %s --target=aarch64-linux-gnu 2>&1 | FileCheck %s --check-prefix=CHECK-NOPIE -! RUN: %flang -### %s --target=aarch64-linux-gnu -fno-pie

[PATCH] D143617: [Clang][CMake] Support perf, LBR, and Instrument CLANG_BOLT options

Amir updated this revision to Diff 538271. Amir added a comment. Rebase + reformatted with `black` (D150761 ) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143617/new/ https://reviews.llvm.org/D143617 Files:

[clang] 2a65d03 - [libc] Add support for creating wrapper headers for offloading in clang

Author: Joseph Huber Date: 2023-07-07T16:02:33-05:00 New Revision: 2a65d0388ca0f1c756f4c1a859cbb9e24b364942 URL: https://github.com/llvm/llvm-project/commit/2a65d0388ca0f1c756f4c1a859cbb9e24b364942 DIFF: https://github.com/llvm/llvm-project/commit/2a65d0388ca0f1c756f4c1a859cbb9e24b364942.diff

[PATCH] D154696: [Clang] Diagnose jumps into statement expressions

cor3ntin marked 2 inline comments as done. cor3ntin added inline comments. Comment at: clang/docs/ReleaseNotes.rst:571 (`#61758 `_) +- Correcly diagnose jumps into statement expressions. + (`#63682

[PATCH] D154696: [Clang] Diagnose jumps into statement expressions

cor3ntin updated this revision to Diff 538252. cor3ntin marked an inline comment as done. cor3ntin added a comment. Fix test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154696/new/ https://reviews.llvm.org/D154696 Files:

[PATCH] D154696: [Clang] Diagnose jumps into statement expressions

cor3ntin updated this revision to Diff 538250. cor3ntin marked an inline comment as done. cor3ntin added a comment. Missed a comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154696/new/ https://reviews.llvm.org/D154696 Files:

[PATCH] D154696: [Clang] Diagnose jumps into statement expressions

cor3ntin updated this revision to Diff 538249. cor3ntin added a comment. Address Shafik's feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154696/new/ https://reviews.llvm.org/D154696 Files: clang/docs/ReleaseNotes.rst

[PATCH] D154672: [OPENMP52] Deprecation of 'depend' clause in ordered directive.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG852fe30b687e: [OPENMP52] Deprecation of depend clause in ordered directive. (authored by jyu2). Changed prior to commit:

[clang] 852fe30 - [OPENMP52] Deprecation of 'depend' clause in ordered directive.

Author: Jennifer Yu Date: 2023-07-07T13:07:17-07:00 New Revision: 852fe30b687e1df9f67007944a90c748ea77f587 URL: https://github.com/llvm/llvm-project/commit/852fe30b687e1df9f67007944a90c748ea77f587 DIFF: https://github.com/llvm/llvm-project/commit/852fe30b687e1df9f67007944a90c748ea77f587.diff

[PATCH] D154647: [RISCV] Re-define sha256, Zksed, and Zksh intrinsics to use i32 types.

craig.topper updated this revision to Diff 538239. craig.topper added a comment. Rebase and add the missing autoupgrade tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154647/new/ https://reviews.llvm.org/D154647 Files:

[PATCH] D154543: [Support] Move StringExtras.h include from Error.h to Error.cpp

IncludeGuardian updated this revision to Diff 538238. IncludeGuardian added a comment. Rebasing on `main` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154543/new/ https://reviews.llvm.org/D154543 Files: clang/lib/Driver/ToolChain.cpp clang/lib/Driver/ToolChains/BareMetal.cpp

[PATCH] D154543: [Support] Move StringExtras.h include from Error.h to Error.cpp

IncludeGuardian added a comment. @MaskRay Thanks. I have updated the title to use `[Support]` and I will land the additional includes separately to the removal. This was very good advice last attempt as it I did have to revert the change. CHANGES SINCE LAST ACTION

[PATCH] D154123: [HIP] Start document HIP support by clang

arsenm added inline comments. Comment at: clang/docs/HIPSupport.rst:49 + +You can also use ``--offload-arch=native`` to let ``amdgpu-arch`` automatically detect the GPU architecture on your system: + s/architecture/architectures Comment at:

[PATCH] D153835: [Sema] Clone VisibilityAttr for functions in template instantiations

rjmccall added a comment. I agree that the change to test51 is the right result, yes. The explicit visibility attribute on the template declaration should take precedence over the visibility of the types in the template parameter list, and then the explicit visibility attribute on the

[PATCH] D151761: clang-format: Add AlignConsecutiveShortCaseStatements

HazardyKnusperkeks added inline comments. Comment at: clang/include/clang/Format/Format.h:380 +} +bool operator!=(const ShortCaseStatementsAlignmentStyle ) const { + return !(*this == R); I'd drop that. We don't have it for any other struct. And

[PATCH] D154706: [RISCV] Add XLEN width integer type: riscv_int.h

craig.topper added inline comments. Comment at: clang/lib/Headers/riscv_int.h:10 + +#ifndef __RISCV_INT_H + Don't you have to `#define __RISCV_INT_H` after this to make this a complete include guard? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D154503: [Sema] Fix handling of functions that hide classes

rjmccall added inline comments. Comment at: clang/lib/Sema/SemaLookup.cpp:542 +N = Decls.size(); + } + john.brawn wrote: > rjmccall wrote: > > This is going to fire on every single ordinary lookup that finds multiple > > declarations, right? I haven't

[PATCH] D154130: [lit] Avoid os.path.realpath on Windows due to MAX_PATH limitations

MrTrillian added a comment. In D154130#4481673 , @aaron.ballman wrote: > Adding a few more folks who are interested in lit changes to try to get the > review unstuck. > > FWIW, I worry about the subtlety of the `>` change because it's not entirely >

[PATCH] D153835: [Sema] Clone VisibilityAttr for functions in template instantiations

MaskRay added a subscriber: erichkeane. MaskRay added a comment. In D153835#4481462 , @rjmccall wrote: > We made a decision ten years or so ago to use a slightly different > interpretation of the visibility attributes, so differences from GCC are not >

[PATCH] D139629: clang: Stop emitting "strictfp"

arsenm closed this revision. arsenm added a comment. 42d4c85ca83f25f993444fb5bbaa58525f724991 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139629/new/ https://reviews.llvm.org/D139629

[clang] 42d4c85 - clang: Stop emitting "strictfp"

Author: Matt Arsenault Date: 2023-07-07T15:28:21-04:00 New Revision: 42d4c85ca83f25f993444fb5bbaa58525f724991 URL: https://github.com/llvm/llvm-project/commit/42d4c85ca83f25f993444fb5bbaa58525f724991 DIFF:

[clang] 75b7901 - clang: Regenerate test checks

Author: Matt Arsenault Date: 2023-07-07T15:28:21-04:00 New Revision: 75b79019013b0891fe5afcd19097ad3c5958d34d URL: https://github.com/llvm/llvm-project/commit/75b79019013b0891fe5afcd19097ad3c5958d34d DIFF:

[PATCH] D139629: clang: Stop emitting "strictfp"

arsenm accepted this revision. arsenm added a comment. This revision is now accepted and ready to land. self accept after latest comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139629/new/ https://reviews.llvm.org/D139629 ___

[PATCH] D151761: clang-format: Add AlignConsecutiveShortCaseStatements

galenelias updated this revision to Diff 538228. galenelias marked an inline comment as done. galenelias edited the summary of this revision. galenelias added a comment. This iteration switches away from using `AlignConsecutiveStyle` and instead uses a new `ShortCaseStatementsAlignmentStyle`.

[PATCH] D151761: clang-format: Add AlignConsecutiveShortCaseStatements

galenelias marked an inline comment as done. galenelias added inline comments. Comment at: clang/include/clang/Format/Format.h:327 + /// \version 17 + AlignConsecutiveStyle AlignConsecutiveShortCaseStatements; HazardyKnusperkeks wrote: > Since you are not

[PATCH] D153738: Add LibClang guide

aaron.ballman added a comment. In D153738#4474602 , @manuel5975p wrote: > Incorporate Aaron Ballman's corrections Hmm, something seems to have gone sideways somewhere because it looks like none of the comments were addressed -- did you perhaps

[PATCH] D154130: [lit] Avoid os.path.realpath on Windows due to MAX_PATH limitations

aaron.ballman added reviewers: jdenny, jhenderson. aaron.ballman added a comment. Adding a few more folks who are interested in lit changes to try to get the review unstuck. FWIW, I worry about the subtlety of the `>` change because it's not entirely clear to me when I'd need to use `%>t` in a

[PATCH] D154696: [Clang] Diagnose jumps into statement expressions

shafik added inline comments. Comment at: clang/docs/ReleaseNotes.rst:571 (`#61758 `_) +- Correcly diagnose jumps into statement expressions. + (`#63682 `_)

[PATCH] D148216: [UTC] Add fallback support for specific metadata, and check their defs

jdoerfert reopened this revision. jdoerfert added a comment. This revision is now accepted and ready to land. This is broken: https://github.com/llvm/llvm-project/issues/63746 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148216/new/

[PATCH] D148216: [UTC] Add fallback support for specific metadata, and check their defs

jdoerfert closed this revision. jdoerfert added a comment. When you commit things, can you please add the Differential Revision into the commit message so it is closed here and we can easily find the review for a change. Committed as 8a3fdf7b908978625e9a7e57fbb443e4e6f98976

[PATCH] D153920: [clang] Move the clang formatting job to run-buildbot to fix the CI

aaron.ballman added a comment. In D153920#4481410 , @philnik wrote: > @aaron.ballman @erichkeane @cor3ntin (anybody else?) are you fine with moving > the clang build kite-pipeline to `clang/utils/ci` and adding a `run-buildbot`? I think that seems

[PATCH] D152495: [Clang][SemaCXX] Add unused warning for variables declared in condition expressions

aaron.ballman added a comment. This is a bit of an odd situation -- the condition variable *is* used (e.g., its value is loaded to determine whether to go into the if branch or the else branch), so we should not be marking it as unused in `Sema::CheckConditionVariable()`. Instead, I think we

[PATCH] D154736: [Driver][ARM] Warn about -mabi= for assembler input with -fno-integrated-as

MaskRay created this revision. MaskRay added reviewers: michaelplatings, peter.smith, simon_tatham, nathanchance, nickdesaulniers. Herald added a subscriber: kristof.beyls. Herald added a project: All. MaskRay requested review of this revision. Herald added a project: clang. Herald added a

[PATCH] D154133: [amdgpu] start documenting amdgpu support by clang

scchan added inline comments. Comment at: clang/docs/AMDGPUSupport.rst:47 + * - ``__amdgcn_feature___`` + - Defined for each supported target feature. The value is 1 if the feature is enabled and 0 if it is disabled. Allowed feature names are sramecc and xnack. + * -

[PATCH] D153920: [clang] Move the clang formatting job to run-buildbot to fix the CI

ldionne requested changes to this revision. ldionne added a comment. This revision now requires changes to proceed. I really like where this is going, this will create a framework where Clang can add more pre-commit CI checks if they desire. Comment at:

[PATCH] D154689: [clang] Correct calculation of MemberExpr's dependence

shafik accepted this revision. shafik added a comment. LGTM, thank you for the quick fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154689/new/ https://reviews.llvm.org/D154689 ___ cfe-commits

[PATCH] D153835: [Sema] Clone VisibilityAttr for functions in template instantiations

rjmccall requested changes to this revision. rjmccall added a comment. This revision now requires changes to proceed. We made a decision ten years or so ago to use a slightly different interpretation of the visibility attributes, so differences from GCC are not by themselves unexpected or

[PATCH] D139629: clang: Stop emitting "strictfp"

zahiraam added a comment. In D139629#4481408 , @rjmccall wrote: > In D139629#4481030 , @zahiraam > wrote: > >> According to this comment https://reviews.llvm.org/D87528#2342132, it looks >> like @rjmccall had

[PATCH] D153920: [clang] Move the clang formatting job to run-buildbot to fix the CI

philnik added subscribers: cor3ntin, erichkeane, aaron.ballman. philnik added a comment. @aaron.ballman @erichkeane @cor3ntin (anybody else?) are you fine with moving the clang build kite-pipeline to `clang/utils/ci` and adding a `run-buildbot`? Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D139629: clang: Stop emitting "strictfp"

rjmccall added a comment. In D139629#4481030 , @zahiraam wrote: > According to this comment https://reviews.llvm.org/D87528#2342132, it looks > like @rjmccall had proposed the addition of the attribute. @rjmccall Do you > recall why it was added? My

[PATCH] D153725: [clang] Make amdgpu-arch tool work on Windows

jhuber6 accepted this revision. jhuber6 added a comment. This revision is now accepted and ready to land. LG CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153725/new/ https://reviews.llvm.org/D153725 ___ cfe-commits mailing list

[PATCH] D153920: [clang] Move the clang formatting job to run-buildbot to fix the CI

philnik updated this revision to Diff 538208. philnik marked 2 inline comments as done. philnik added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D153725: [clang] Make amdgpu-arch tool work on Windows

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/tools/amdgpu-arch/AMDGPUArchByHIP.cpp:96 + return 0; +} jdoerfert wrote: > Where is the call to this? forgot to call this in main. fixed. CHANGES SINCE LAST ACTION

[PATCH] D154672: [OPENMP52] Deprecation of 'depend' clause in ordered directive.

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:1532 InGroup; +def warn_omp_depend_in_ordered_deprecated : Warning<"denpend clause for ordered is deprecated; use doacross instaed">, InGroup; jyu2 wrote: >

[PATCH] D153725: [clang] Make amdgpu-arch tool work on Windows

yaxunl updated this revision to Diff 538207. yaxunl marked an inline comment as done. yaxunl added a comment. revised by comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153725/new/ https://reviews.llvm.org/D153725 Files: clang/tools/amdgpu-arch/AMDGPUArch.cpp

[PATCH] D153725: [clang] Make amdgpu-arch tool work on Windows

jdoerfert added inline comments. Comment at: clang/tools/amdgpu-arch/AMDGPUArchByHIP.cpp:96 + return 0; +} Where is the call to this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153725/new/ https://reviews.llvm.org/D153725

[PATCH] D153725: [clang] Make amdgpu-arch tool work on Windows

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/tools/amdgpu-arch/AMDGPUArch.cpp:48-52 + if (!printGPUsByHSA()) +return 0; +#endif + return printGPUsByHSA(); jhuber6 wrote: > Are we missing something here ? They

[PATCH] D154133: [amdgpu] start documenting amdgpu support by clang

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/docs/AMDGPUSupport.rst:47 + * - ``__amdgcn_feature___`` + - Defined for each supported target feature. The value is 1 if the feature is enabled and 0 if it is disabled. Allowed

[PATCH] D154123: [HIP] Start document HIP support by clang

yaxunl updated this revision to Diff 538201. yaxunl marked an inline comment as done. yaxunl added a comment. revised by comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154123/new/ https://reviews.llvm.org/D154123 Files: clang/docs/HIPSupport.rst Index:

[PATCH] D154123: [HIP] Start document HIP support by clang

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/docs/HIPSupport.rst:82 +=== + +1. **Compiler Options**: If you specify paths using the compiler options, these will override the correponding paths set via

[PATCH] D151575: [clang][diagnostics] Always show include stacks on errors

SlaterLatiao updated this revision to Diff 538197. SlaterLatiao added a comment. - Emit include stack on all top-level diagnostics. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151575/new/ https://reviews.llvm.org/D151575 Files:

[PATCH] D151730: [RISCV] Support target attribute for function

reames added a comment. Can you separate the change to RISCVAsmPrinter.cpp into it's own review? This looks useful for any case where we have functions in the same model with different function attributes. The __attribute__((target...) syntax is one way to have that, but there are also

[PATCH] D152093: [clang][Analysis] Handle && and || against variable and its negation as tautology

thakis added a comment. Seems like a nice idea to me, thanks! Do you have any numbers on how often this fires in practice, and what the true positive rate is? (Build some large-ish open source project with this, and see what it finds.) Did you verify that this has negligible compile time

[PATCH] D154543: [llvm] Move StringExtras.h include from Error.h to Error.cpp

MaskRay added a comment. > [llvm] Move StringExtras.h include from Error.h to Error.cpp If you land the #include changes separately, I think the tag can be changed to `[Support] `. `Support` is sufficient to refer to llvm-project/llvm/ CHANGES SINCE LAST ACTION

[PATCH] D154543: [llvm] Move StringExtras.h include from Error.h to Error.cpp

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. I have spot checked a few files and the additional #include looks great! As mentioned in the other patch, it would be better landing the #include adjustment part separately so that the

[PATCH] D154658: Optimize emission of `dynamic_cast` to final classes.

rjmccall added a comment. In D154658#4479213 , @rsmith wrote: > In D154658#4479170 , @rjmccall > wrote: > >> I don't think it's an intended guarantee of the Itanium ABI that the v-table >> will be unique, and

[clang] 9306352 - [Clang] Emit KCFI type hashes for member functions

Author: Sami Tolvanen Date: 2023-07-07T16:50:30Z New Revision: 930635271f810316f48bd1aa78935acf36a08f8f URL: https://github.com/llvm/llvm-project/commit/930635271f810316f48bd1aa78935acf36a08f8f DIFF: https://github.com/llvm/llvm-project/commit/930635271f810316f48bd1aa78935acf36a08f8f.diff

[PATCH] D154123: [HIP] Start document HIP support by clang

scchan added inline comments. Comment at: clang/docs/HIPSupport.rst:82 +=== + +1. **Compiler Options**: If you specify paths using the compiler options, these will override the correponding paths set via environment variables. I think

[PATCH] D153273: [analyzer] Rework support for CFGScopeBegin, CFGScopeEnd, CFGLifetime elements

ymandel accepted this revision. ymandel added inline comments. Comment at: clang/lib/Analysis/CFG.cpp:773 void addLoopExit(const Stmt *LoopStmt); - void addAutomaticObjDtors(LocalScope::const_iterator B, -LocalScope::const_iterator E, Stmt *S); -

[PATCH] D154133: [amdgpu] start documenting amdgpu support by clang

scchan added inline comments. Comment at: clang/docs/AMDGPUSupport.rst:47 + * - ``__amdgcn_feature___`` + - Defined for each supported target feature. The value is 1 if the feature is enabled and 0 if it is disabled. Allowed feature names are sramecc and xnack. + * -

[PATCH] D153725: [clang] Make amdgpu-arch tool work on Windows

jhuber6 added inline comments. Comment at: clang/tools/amdgpu-arch/AMDGPUArch.cpp:48-52 + if (!printGPUsByHSA()) +return 0; +#endif + return printGPUsByHSA(); Are we missing something here ? They look the same. CHANGES SINCE LAST ACTION

[PATCH] D153725: [clang] Make amdgpu-arch tool work on Windows

yaxunl marked 5 inline comments as done. yaxunl added inline comments. Comment at: clang/tools/amdgpu-arch/AMDGPUArch.cpp:50 +#else + return printGPUsByHSA(); +#endif jhuber6 wrote: > arsenm wrote: > > The HIP path should work on linux too. I generally think we

[PATCH] D153725: [clang] Make amdgpu-arch tool work on Windows

yaxunl updated this revision to Diff 538170. yaxunl marked an inline comment as done. yaxunl added a comment. revised by comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153725/new/ https://reviews.llvm.org/D153725 Files: clang/tools/amdgpu-arch/AMDGPUArch.cpp

[PATCH] D152003: [clang] Fix `static_cast` to array of unknown bound

Fznamznon updated this revision to Diff 538165. Fznamznon added a comment. Rebase, move the logic, modify c-style casts as well Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152003/new/ https://reviews.llvm.org/D152003 Files:

[PATCH] D153914: [clang-cl] Enable concatenation of predefined identifiers

RIscRIpt added a comment. Added @aaron.ballman as reviewer, because he was reviewer of related patch: 878e590503dff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153914/new/

[PATCH] D154672: [OPENMP52] Deprecation of 'depend' clause in ordered directive.

jyu2 added inline comments. Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:1532 InGroup; +def warn_omp_depend_in_ordered_deprecated : Warning<"denpend clause for ordered is deprecated; use doacross instaed">, InGroup; aaron.ballman wrote: >

[PATCH] D154672: [OPENMP52] Deprecation of 'depend' clause in ordered directive.

jyu2 updated this revision to Diff 538162. jyu2 added a comment. Thanks @jdoerfert, @ABataev and @aaron.ballman for the code reviews. This is addressing comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154672/new/

[PATCH] D154423: [clang][analyzer] Add all success/failure messages to StdLibraryFunctionsChecker.

balazske added a comment. The standard streams may need special handling, this can be useful for `StreamChecker` too. One problem is that the standard streams can be changed by the program, so we can not know for sure if these are the original values. Still it can be better to assume that

[PATCH] D153418: Adding iconv support to CharSetConverter class

abhina.sreeskantharajan added a comment. In D153418#4478766 , @tahonermann wrote: >> Please correct me if I'm wrong, I'm not too familiar with icu4c, but I think >> adding support for ICU would be the better long-term solution since it seems >> to

[PATCH] D139629: clang: Stop emitting "strictfp"

zahiraam added a subscriber: rjmccall. zahiraam added a comment. According to this comment https://reviews.llvm.org/D87528#2342132, it looks like @rjmccall had proposed the addition of the attribute. @rjmccall Do you recall why it was added? CHANGES SINCE LAST ACTION

[PATCH] D154290: [WIP][Clang] Implement P2741R3 - user-generated static_assert messages

tbaeder added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:16893 + + if (const StringLiteral *SL = dyn_cast(Message); + SL && SL->getCharByteWidth() == 1) { Comment at: clang/lib/Sema/SemaDeclCXX.cpp:16898 + } + +

[PATCH] D154290: [WIP][Clang] Implement P2741R3 - user-generated static_assert messages

cor3ntin updated this revision to Diff 538154. cor3ntin added a comment. Rebase. This is now ready for review. Note that after discussion with CWG, the consensus seems to be that the wording is fine, an implementation has to behave As if the full expression Message.data()[I] is called for each

[PATCH] D149248: [RISCV][MC] MC layer support for the experimental zacas extension

reames accepted this revision. reames added a comment. This revision is now accepted and ready to land. LGTM Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:3338 +unsigned Rs2 = Inst.getOperand(2).getReg(); +if (Rd % 2 == 1) { + SMLoc Loc =

[clang] 5e9ab9c - Fix the Clang sphinx bot

Author: Aaron Ballman Date: 2023-07-07T11:08:17-04:00 New Revision: 5e9ab9c615c3b108b05d729a5706dd46f5ebdc97 URL: https://github.com/llvm/llvm-project/commit/5e9ab9c615c3b108b05d729a5706dd46f5ebdc97 DIFF: https://github.com/llvm/llvm-project/commit/5e9ab9c615c3b108b05d729a5706dd46f5ebdc97.diff

[PATCH] D154130: [lit] Avoid os.path.realpath on Windows due to MAX_PATH limitations

MrTrillian added a comment. @rnk , I would appreciate your review on this since you helped with the previous iteration. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154130/new/ https://reviews.llvm.org/D154130

[PATCH] D154130: [lit] Avoid os.path.realpath on Windows due to MAX_PATH limitations

MrTrillian added a comment. All premerge build failures seem like flukes. - `x64 windows` failed 1/3 times - `x64 debian` failed 2/3 times with a timeout (passes locally) - `libcxx` seems to be failing for everyone: https://buildkite.com/llvm-project/libcxx-ci Repository: rG LLVM Github

  1   2   3   >