[PATCH] D4784: [clang-tidy] Add check for possibly incomplete switch statements

xgupta updated this revision to Diff 539390. xgupta added a comment. Update ReleaseNotes.rst CHANGES SINCE LAST ACTION https://reviews.llvm.org/D4784/new/ https://reviews.llvm.org/D4784 Files: clang-tools-extra/clang-tidy/misc/CMakeLists.txt

[PATCH] D153989: [compiler-rt] Move crt into builtins

arichardson added a comment. I think reduplication of build logic makes sense but these are conceptually separate things. The compiler rt builtins are needed in many cases where the C start-up code isn't (e.g. baremetal OS code). Would moving it to a subdirectory of builtins/ work too? That

[PATCH] D145302: [clangd] Add library for clangd main function

raj.khem added a comment. indeed, broke my CI with same issue. In D145302#4491973 , @glandium wrote: > This broke building with `-DLLVM_LINK_LLVM_DYLIB=ON`: > > /usr/bin/ld: >

[PATCH] D4784: [clang-tidy] Add check for possibly incomplete switch statements

xgupta updated this revision to Diff 539389. xgupta added a comment. Address bkramer's comments except one for "checking that you're casting from an enum". CHANGES SINCE LAST ACTION https://reviews.llvm.org/D4784/new/ https://reviews.llvm.org/D4784 Files:

[PATCH] D4784: [clang-tidy] Add check for possibly incomplete switch statements

xgupta updated this revision to Diff 539383. xgupta added a comment. . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D4784/new/ https://reviews.llvm.org/D4784 Files: clang-tools-extra/clang-tidy/misc/CMakeLists.txt clang-tools-extra/clang-tidy/misc/IncompleteSwitchCheck.cpp

[PATCH] D154969: [dataflow] document flow condition

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfa689726768b: [dataflow] document flow condition (authored by sammccall). Changed prior to commit:

[clang] fa68972 - [dataflow] document flow condition

Author: Sam McCall Date: 2023-07-12T07:20:46+02:00 New Revision: fa689726768b7b5cae01970cce2e59a72a0229b4 URL: https://github.com/llvm/llvm-project/commit/fa689726768b7b5cae01970cce2e59a72a0229b4 DIFF: https://github.com/llvm/llvm-project/commit/fa689726768b7b5cae01970cce2e59a72a0229b4.diff

[PATCH] D4784: [clang-tidy] Add check for possibly incomplete switch statements

xgupta updated this revision to Diff 539378. xgupta retitled this revision from "[clang-tidy] Add check for possibly incomplete switch statements " to "[clang-tidy] Add check for possibly incomplete switch statements". xgupta added a reviewer: PiotrZSL. xgupta added a comment. Herald added a

[PATCH] D153701: [WIP][Clang] Implement P2718R0 "Lifetime extension in range-based for loops"

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:8901-8914 + // [P2718R0] Lifetime extension in range-based for loops. + // + // 6.7.7 [class.temporary] p5: + // There are four contexts in which temporaries are destroyed at a different

[PATCH] D154965: [clang][dataflow] Fix initializing a reference field with an `InitListExpr`.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbd9b57de4ff7: [clang][dataflow] Fix initializing a reference field with an `InitListExpr`. (authored by mboehme). Repository: rG LLVM Github

[PATCH] D154961: [clang][dataflow] Include fields initialized in an `InitListExpr` in `getModeledFields()`.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb47bdcbc7207: [clang][dataflow] Include fields initialized in an `InitListExpr` in… (authored by mboehme). Repository: rG LLVM Github Monorepo

[PATCH] D154952: [clang][dataflow] Various refactorings in TypeErasedDataflowAnalysisTest.cpp

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1e9b4fc1dcf2: [clang][dataflow] Various refactorings in TypeErasedDataflowAnalysisTest.cpp (authored by mboehme). Repository: rG LLVM Github

[PATCH] D154949: [clang][dataflow] Use `getFieldValue()` in TransferTest.cpp.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG103a0fc08460: [clang][dataflow] Use `getFieldValue()` in TransferTest.cpp. (authored by mboehme). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D154935: [clang][dataflow] Introduce `getFieldValue()` test helpers.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2902ea3d817b: [clang][dataflow] Introduce `getFieldValue()` test helpers. (authored by mboehme). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D154934: [clang][dataflow] Use `IntegerValue` instead of `StructValue` in `ValueTest`.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0014aab2d588: [clang][dataflow] Use `IntegerValue` instead of `StructValue` in `ValueTest`. (authored by mboehme). Repository: rG LLVM Github

[clang] bd9b57d - [clang][dataflow] Fix initializing a reference field with an `InitListExpr`.

Author: Martin Braenne Date: 2023-07-12T04:52:30Z New Revision: bd9b57de4ff7c65be0d69179232ba2d5fe832195 URL: https://github.com/llvm/llvm-project/commit/bd9b57de4ff7c65be0d69179232ba2d5fe832195 DIFF: https://github.com/llvm/llvm-project/commit/bd9b57de4ff7c65be0d69179232ba2d5fe832195.diff

[clang] b47bdcb - [clang][dataflow] Include fields initialized in an `InitListExpr` in `getModeledFields()`.

Author: Martin Braenne Date: 2023-07-12T04:52:29Z New Revision: b47bdcbc7207aac617d3c35dfc029f79b0a46fd8 URL: https://github.com/llvm/llvm-project/commit/b47bdcbc7207aac617d3c35dfc029f79b0a46fd8 DIFF: https://github.com/llvm/llvm-project/commit/b47bdcbc7207aac617d3c35dfc029f79b0a46fd8.diff

[clang] 1e9b4fc - [clang][dataflow] Various refactorings in TypeErasedDataflowAnalysisTest.cpp

Author: Martin Braenne Date: 2023-07-12T04:52:27Z New Revision: 1e9b4fc1dcf27ae43477efe0329f738e4419871b URL: https://github.com/llvm/llvm-project/commit/1e9b4fc1dcf27ae43477efe0329f738e4419871b DIFF: https://github.com/llvm/llvm-project/commit/1e9b4fc1dcf27ae43477efe0329f738e4419871b.diff

[clang] 0014aab - [clang][dataflow] Use `IntegerValue` instead of `StructValue` in `ValueTest`.

Author: Martin Braenne Date: 2023-07-12T04:52:22Z New Revision: 0014aab2d5882525c23130108e17fbbb5a2120f1 URL: https://github.com/llvm/llvm-project/commit/0014aab2d5882525c23130108e17fbbb5a2120f1 DIFF: https://github.com/llvm/llvm-project/commit/0014aab2d5882525c23130108e17fbbb5a2120f1.diff

[clang] 103a0fc - [clang][dataflow] Use `getFieldValue()` in TransferTest.cpp.

Author: Martin Braenne Date: 2023-07-12T04:52:25Z New Revision: 103a0fc0846050dd671e6485ab52491042f905c6 URL: https://github.com/llvm/llvm-project/commit/103a0fc0846050dd671e6485ab52491042f905c6 DIFF: https://github.com/llvm/llvm-project/commit/103a0fc0846050dd671e6485ab52491042f905c6.diff

[clang] 2902ea3 - [clang][dataflow] Introduce `getFieldValue()` test helpers.

Author: Martin Braenne Date: 2023-07-12T04:52:23Z New Revision: 2902ea3d817bf381817ff76228c3212f4dc87d47 URL: https://github.com/llvm/llvm-project/commit/2902ea3d817bf381817ff76228c3212f4dc87d47 DIFF: https://github.com/llvm/llvm-project/commit/2902ea3d817bf381817ff76228c3212f4dc87d47.diff

[PATCH] D154965: [clang][dataflow] Fix initializing a reference field with an `InitListExpr`.

mboehme updated this revision to Diff 539366. mboehme added a comment. Changes in response to review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154965/new/ https://reviews.llvm.org/D154965 Files:

[PATCH] D154935: [clang][dataflow] Introduce `getFieldValue()` test helpers.

mboehme updated this revision to Diff 539365. mboehme added a comment. Changes in response to review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154935/new/ https://reviews.llvm.org/D154935 Files:

[PATCH] D143241: [Clang] Reset FP options before function instantiations

thesamesam added a comment. During our regular snapshot testing, we've hit this in Gentoo on 32-bit Linux x86: https://github.com/llvm/llvm-project/issues/63704#issuecomment-1631791518. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143241/new/

[PATCH] D154701: [clang] Overridden CXXMethodDecl::isVirtual() assertion failed before fully imported.

danix800 added inline comments. Comment at: clang/test/Analysis/ctu-astimport-virtual-assertion/main.cpp:22 + +#include "Inputs/input.h" balazske wrote: > Such tests are not in the //Analysis// folder but in the //ASTMerge// folder > instead. I would say that

[PATCH] D154822: [clang] Support '-fgpu-default-stream=per-thread' for NVIDIA CUDA

boxu-zhang added a comment. I don't have the permission to push to main branch. Can anyone push this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154822/new/ https://reviews.llvm.org/D154822 ___

[PATCH] D154290: [Clang] Implement P2741R3 - user-generated static_assert messages

shafik added inline comments. Comment at: clang/test/SemaCXX/static-assert-cxx26.cpp:1 +// RUN: %clang_cc1 -std=c++2c -fsyntax-only %s -verify + How about a test case w/ `data()` and or `size()` has default arguments. Repository: rG LLVM Github Monorepo

[PATCH] D154290: [Clang] Implement P2741R3 - user-generated static_assert messages

shafik added inline comments. Comment at: clang/test/SemaCXX/static-assert-cxx26.cpp:167 +static_assert(false, MessageInvalidSize{}); // expected-error {{static assertion failed}} \ + // expected-error {{the message in a

[PATCH] D145302: [clangd] Add library for clangd main function

glandium added a comment. This broke building with `-DLLVM_LINK_LLVM_DYLIB=ON`: /usr/bin/ld: tools/clang/tools/extra/clangd/refactor/tweaks/CMakeFiles/obj.clangDaemonTweaks.dir/AddUsing.cpp.o: in function `clang::clangd::(anonymous

[PATCH] D146777: [clang] Preliminary fat-lto-object support

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:623 +if (Args.hasArg(options::OPT_ffat_lto_objects)) + CmdArgs.push_back("-fat-lto-objects"); } New lld long options only allow `--` form. So use two dashes.

[PATCH] D146777: [clang] Preliminary fat-lto-object support

paulkirth updated this revision to Diff 539346. paulkirth added a comment. Rebase and try to accomodate Unified LTO changes. Based on the Unified LTO patches, I think this is the correct handling for FatLTO, but I'd like to get a second opinion before landing this. CC: @ormris Repository:

[clang] 875b881 - [clang-format][NFC] Remove redundant parentheses in the source code

Author: Owen Pan Date: 2023-07-11T17:05:00-07:00 New Revision: 875b881186c4eb146e77e76ad72ee0a356d7c69f URL: https://github.com/llvm/llvm-project/commit/875b881186c4eb146e77e76ad72ee0a356d7c69f DIFF: https://github.com/llvm/llvm-project/commit/875b881186c4eb146e77e76ad72ee0a356d7c69f.diff

[clang] b10899d - [clang] Fix -Wlogical-op-parentheses in Clang.cpp (NFC)

Author: Jie Fu Date: 2023-07-12T07:53:50+08:00 New Revision: b10899d869954e1426684cbc20a43d7303075d49 URL: https://github.com/llvm/llvm-project/commit/b10899d869954e1426684cbc20a43d7303075d49 DIFF: https://github.com/llvm/llvm-project/commit/b10899d869954e1426684cbc20a43d7303075d49.diff LOG:

[clang] fd2254b - clang: Update test for strict minnum/maxnum fix

Author: Matt Arsenault Date: 2023-07-11T19:51:38-04:00 New Revision: fd2254b7358d0f78a79784688bd8012c1a52b9cf URL: https://github.com/llvm/llvm-project/commit/fd2254b7358d0f78a79784688bd8012c1a52b9cf DIFF:

[PATCH] D151730: [RISCV] Support target attribute for function

craig.topper added a comment. In D151730#4491773 , @jrtc27 wrote: > Isn't multiversioning a separate thing that builds on top of per-function > target attributes? That's what I thought. The supportsMultiVersioning call was in an earlier version of the

[PATCH] D151730: [RISCV] Support target attribute for function

jrtc27 added a comment. Isn't multiversioning a separate thing that builds on top of per-function target attributes? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151730/new/ https://reviews.llvm.org/D151730

[PATCH] D151730: [RISCV] Support target attribute for function

reames added a comment. FYI, this change appears to be a partial diff. Locally, I need to add RISCV to supportsMultiVersioning() to get this to work at all. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151730/new/

[PATCH] D154484: [clang-format] Add an option to remove redundant parentheses

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3a6a0702c2a4: [clang-format] Add an option to remove redundant parentheses (authored by owenpan). Changed prior to commit:

[clang] 3a6a070 - [clang-format] Add an option to remove redundant parentheses

Author: Owen Pan Date: 2023-07-11T16:33:19-07:00 New Revision: 3a6a0702c2a4c2290f0b55b0451a9f97d7592baf URL: https://github.com/llvm/llvm-project/commit/3a6a0702c2a4c2290f0b55b0451a9f97d7592baf DIFF: https://github.com/llvm/llvm-project/commit/3a6a0702c2a4c2290f0b55b0451a9f97d7592baf.diff

[PATCH] D123971: [clang][PS4] Enable SplitLTOUnits by default

ormris added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123971/new/ https://reviews.llvm.org/D123971 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D123971: [clang][PS4] Enable SplitLTOUnits by default

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG392b30680752: [clang][PS4] Enable SplitLTOUnits and Unified LTO by default (authored by ormris). Herald added a project: clang. Herald added a

[clang] 392b306 - [clang][PS4] Enable SplitLTOUnits and Unified LTO by default

Author: Matthew Voss Date: 2023-07-11T16:25:07-07:00 New Revision: 392b3068075279c7e321583c4d426edf15c935ca URL: https://github.com/llvm/llvm-project/commit/392b3068075279c7e321583c4d426edf15c935ca DIFF: https://github.com/llvm/llvm-project/commit/392b3068075279c7e321583c4d426edf15c935ca.diff

[PATCH] D154923: [CodeGen] Support bitcode input containing multiple modules

MaskRay added a comment. In D154923#4491411 , @efriedma wrote: > If I follow correctly, this is basically undoing the splitting that was done > by the command that produced the bitcode file? Yes, undoing

[PATCH] D150803: [WebAssembly] Support `annotate` clang attributes for marking functions.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG220fe00a7c0f: [WebAssembly] Support `annotate` clang attributes for marking functions. (authored by brendandahl, committed by dschuff).

[PATCH] D153906: [clang] Allow disassembly of multi-module bitcode files

ormris added a comment. Thanks! Pushed as 048a0c246908291c82d2f4531d3df45a4c4a8a18 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153906/new/ https://reviews.llvm.org/D153906

[clang] 048a0c2 - [clang] Support Unified LTO Bitcode Frontend

Author: Matthew Voss Date: 2023-07-11T15:13:57-07:00 New Revision: 048a0c246908291c82d2f4531d3df45a4c4a8a18 URL: https://github.com/llvm/llvm-project/commit/048a0c246908291c82d2f4531d3df45a4c4a8a18 DIFF: https://github.com/llvm/llvm-project/commit/048a0c246908291c82d2f4531d3df45a4c4a8a18.diff

[PATCH] D154923: [CodeGen] Support bitcode input containing multiple modules

efriedma added a comment. If I follow correctly, this is basically undoing the splitting that was done by the command that produced the bitcode file? I guess that could be useful. But it requires either renaming your object files from the default ".o" to ".bc", or explicitly passing "-x ir"?

[PATCH] D154290: [Clang] Implement P2741R3 - user-generated static_assert messages

aaron.ballman added a comment. (Not a full review, I ran out of steam -- I wanted to get you some feedback that I already found though.) Comment at: clang/include/clang/AST/Expr.h:766-767 + bool EvaluateCharPointerAsString(std::string , +

[PATCH] D153621: [Clang] Correctly handle $, @, and ` when represented as UCN

tahonermann accepted this revision. tahonermann added a comment. This revision is now accepted and ready to land. > I'll probably merge that EoW unless you scream! Why wait? :) Looks good! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153621/new/

[PATCH] D154602: [clang][clangd] Don't crash/assert on -gsplit-dwarf=single without output

DmitryPolukhin added inline comments. Comment at: clang/unittests/Driver/ToolChainTest.cpp:371 +TEST(CompilerInvocation, SplitSwarfSingleCrash) { + static constexpr const char *Args[] = {"clang", "-gdwarf-4", "-gsplit-dwarf=single", "-c", "foo.cpp"}; + CreateInvocationOptions

[PATCH] D145302: [clangd] Add library for clangd main function

This revision was automatically updated to reflect the committed changes. Closed by commit rG56ac9d46a7c1: [clangd] Add library for clangd main function (authored by ivanmurashko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145302/new/

[clang-tools-extra] 56ac9d4 - [clangd] Add library for clangd main function

Author: Ivan Murashko Date: 2023-07-11T21:48:50+01:00 New Revision: 56ac9d46a7c1468d587ccec02a781e52d0bb298a URL: https://github.com/llvm/llvm-project/commit/56ac9d46a7c1468d587ccec02a781e52d0bb298a DIFF: https://github.com/llvm/llvm-project/commit/56ac9d46a7c1468d587ccec02a781e52d0bb298a.diff

[PATCH] D154300: [CUDA][HIP] Fix template argument deduction

tra added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:12758-12764 +std::optional MorePreferableByCUDA = +CheckCUDAPreference(FD, Result); +// If FD has different CUDA preference than Result. +if (MorePreferableByCUDA) { +

[PATCH] D154602: [clang][clangd] Don't crash/assert on -gsplit-dwarf=single without output

DmitryPolukhin updated this revision to Diff 539283. DmitryPolukhin added a comment. Run clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154602/new/ https://reviews.llvm.org/D154602 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp

[PATCH] D154602: [clang][clangd] Don't crash/assert on -gsplit-dwarf=single without output

DmitryPolukhin updated this revision to Diff 539281. DmitryPolukhin added a comment. Use --target=arm-linux-gnueabi Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154602/new/ https://reviews.llvm.org/D154602 Files:

[PATCH] D155012: Fix types of arm64 MSVC __readx18/__writex18 intrinsics

ahatanak created this revision. ahatanak added reviewers: ravikandhadai, Bigcheese, steplong. ahatanak added a project: clang. Herald added a subscriber: kristof.beyls. Herald added a project: All. ahatanak requested review of this revision. Herald added a subscriber: wangpc. Using `L` for type

[clang] 546ec64 - Restore "[MemProf] Use new option/pass for profile feedback and matching"

Author: Teresa Johnson Date: 2023-07-11T13:16:20-07:00 New Revision: 546ec641b4b1bbbf9e66a53983b635fe85d365e6 URL: https://github.com/llvm/llvm-project/commit/546ec641b4b1bbbf9e66a53983b635fe85d365e6 DIFF:

[PATCH] D154602: [clang][clangd] Don't crash/assert on -gsplit-dwarf=single without output

MaskRay accepted this revision. MaskRay added inline comments. Comment at: clang/unittests/Driver/ToolChainTest.cpp:371 +TEST(CompilerInvocation, SplitSwarfSingleCrash) { + static constexpr const char *Args[] = {"clang", "-gdwarf-4", "-gsplit-dwarf=single", "-c", "foo.cpp"}; +

[PATCH] D152924: [libLTO][AIX] Respect `-f[no]-integrated-as` on AIX

MaskRay accepted this revision. MaskRay added a comment. Some nits about testing, otherwise LG In D152924#4490950 , @qiongsiwu1 wrote: > In D152924#4490581 , @MaskRay wrote: > >> We have

[PATCH] D154696: [Clang] Diagnose jumps into statement expressions

cor3ntin added a comment. Thanks for the review :D Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154696/new/ https://reviews.llvm.org/D154696 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D154696: [Clang] Diagnose jumps into statement expressions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. cor3ntin marked 2 inline comments as done. Closed by commit rGb0cc947b5d0a: [Clang] Diagnose jumps into statement expressions (authored by cor3ntin). Changed prior to

[clang] b0cc947 - [Clang] Diagnose jumps into statement expressions

Author: Corentin Jabot Date: 2023-07-11T21:41:14+02:00 New Revision: b0cc947b5d0a74f4ffe63c53b32978b21498e72e URL: https://github.com/llvm/llvm-project/commit/b0cc947b5d0a74f4ffe63c53b32978b21498e72e DIFF:

[PATCH] D152924: [libLTO][AIX] Respect `-f[no]-integrated-as` on AIX

qiongsiwu1 added a comment. In D152924#4490581 , @MaskRay wrote: > We have `TargetOptions::DisableIntegratedAS` (your llc.cpp change). Do you > know why it is not feasible for the places you want to check? I am checking/using

[PATCH] D153536: [Clang] Implement P2169 A nice placeholder with no name

cor3ntin added a comment. @dblaikie Would you be willing to look at the debugger side of things in a subsequent patch? I'm not familiar with debug symbol code gen so I'm not sure I'd be able to improve thing the right way. Comment at:

[PATCH] D153621: [Clang] Correctly handle $, @, and ` when represented as UCN

cor3ntin added a comment. @tahonermann I'll probably merge that EoW unless you scream! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153621/new/ https://reviews.llvm.org/D153621 ___ cfe-commits mailing

[PATCH] D154884: [clang-tidy] Make MatchesAnyListedNameMatcher cope with unnamed Decl

This revision was automatically updated to reflect the committed changes. Closed by commit rGb389a62518ad: [clang-tidy] Make MatchesAnyListedNameMatcher cope with unnamed Decl (authored by mikecrowe, committed by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D154788: [clang-tidy] Don't split \r\n in modernize-use-std-print check

This revision was automatically updated to reflect the committed changes. Closed by commit rG2ce765eb2f4f: [clang-tidy] Dont split \r\n in modernize-use-std-print check (authored by mikecrowe, committed by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] b389a62 - [clang-tidy] Make MatchesAnyListedNameMatcher cope with unnamed Decl

Author: Mike Crowe Date: 2023-07-11T19:22:32Z New Revision: b389a62518ad54ae5a183efa43f8408571b2b8cb URL: https://github.com/llvm/llvm-project/commit/b389a62518ad54ae5a183efa43f8408571b2b8cb DIFF: https://github.com/llvm/llvm-project/commit/b389a62518ad54ae5a183efa43f8408571b2b8cb.diff LOG:

[clang-tools-extra] 2ce765e - [clang-tidy] Don't split \r\n in modernize-use-std-print check

Author: Mike Crowe Date: 2023-07-11T19:22:31Z New Revision: 2ce765eb2f4feb7555d1416842c542743990b004 URL: https://github.com/llvm/llvm-project/commit/2ce765eb2f4feb7555d1416842c542743990b004 DIFF: https://github.com/llvm/llvm-project/commit/2ce765eb2f4feb7555d1416842c542743990b004.diff LOG:

[clang] 3096226 - [RISCV] Fix name mangling for LMUL!=1 vector types with attribute(rvv_vector_bits)

Author: Craig Topper Date: 2023-07-11T12:01:35-07:00 New Revision: 30962268e7a559d8714cca4d1af742915c9d29b1 URL: https://github.com/llvm/llvm-project/commit/30962268e7a559d8714cca4d1af742915c9d29b1 DIFF: https://github.com/llvm/llvm-project/commit/30962268e7a559d8714cca4d1af742915c9d29b1.diff

[PATCH] D153659: [RISCV] Fix name mangling for LMUL!=1 vector types with attribute(rvv_vector_bits)

This revision was automatically updated to reflect the committed changes. Closed by commit rG30962268e7a5: [RISCV] Fix name mangling for LMUL!=1 vector types with attribute… (authored by craig.topper). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D154696: [Clang] Diagnose jumps into statement expressions

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM though there might be a minor typo with a test comment. Comment at: clang/test/Sema/asm-goto.cpp:56 + // expected-note@+1 {{jump enters a statement

[PATCH] D154999: [clang-tidy] Add bugprone-std-forward-type-mismatch check

PiotrZSL created this revision. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. PiotrZSL requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Detects instances

[PATCH] D154602: [clang][clangd] Don't crash/assert on -gsplit-dwarf=single without output

DmitryPolukhin added inline comments. Comment at: clang/unittests/Driver/ToolChainTest.cpp:371 +TEST(CompilerInvocation, SplitSwarfSingleCrash) { + static constexpr const char *Args[] = {"clang", "-gdwarf-4", "-gsplit-dwarf=single", "-c", "foo.cpp"}; + CreateInvocationOptions

[PATCH] D154602: [clang][clangd] Don't crash/assert on -gsplit-dwarf=single without output

DmitryPolukhin updated this revision to Diff 539223. DmitryPolukhin added a comment. Added -target arm-linux-gnueabi Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154602/new/ https://reviews.llvm.org/D154602 Files:

[PATCH] D152996: [RISCV][POC] Model frm control for vfadd

eopXD updated this revision to Diff 539222. eopXD added a comment. Under RISCVInsertReadWriteCSR, add implicit depdendency to MI if rounding mode is FRM_DYN. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152996/new/

[PATCH] D154915: [ARM][AArch64] Add ARM specific builtin for clz that is not undefined for 0 in ubsan.

craig.topper updated this revision to Diff 539221. craig.topper added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154915/new/ https://reviews.llvm.org/D154915 Files: clang/include/clang/Basic/BuiltinsAArch64.def

[PATCH] D148381: [WIP][Clang] Add element_count attribute

void updated this revision to Diff 539219. void added a comment. Rebasing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148381/new/ https://reviews.llvm.org/D148381 Files: clang/include/clang/Basic/Attr.td

[PATCH] D154784: [clang] Fix crash caused by PseudoObjectExprBitfields::NumSubExprs overflow

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you for the fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154784/new/ https://reviews.llvm.org/D154784

[PATCH] D152924: [libLTO][AIX] Respect `-f[no]-integrated-as` on AIX

MaskRay added a comment. We have `TargetOptions::DisableIntegratedAS` (your llc.cpp change). Do you know why it is not feasible for the places you want to check? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152924/new/

[PATCH] D154186: [clang][DeclPrinter] Fix AST print of delegating constructors

aaron.ballman added inline comments. Comment at: clang/test/AST/ast-print-method-decl.cpp:15 + // CHECK-NEXT: }; +}; strimo378 wrote: > aaron.ballman wrote: > > I'd also like to see test cases along the lines of: > > ``` > > struct B { > > template > >

[PATCH] D152924: [libLTO][AIX] Respect `-f[no]-integrated-as` on AIX

MaskRay added inline comments. Comment at: clang/test/Driver/lto-aix.c:76 // CSPGO: "-bplugin_opt:-cs-profile-generate" "-bplugin_opt:-cs-profile-path=default_%m.profraw" +// +// Test integrated assembler options This `^//$` line is not useful. Some tests use

[PATCH] D154991: [FPEnv][TableGen] Add strictfp attribute to constrained intrinsics by default.

arsenm accepted this revision. arsenm added inline comments. This revision is now accepted and ready to land. Comment at: llvm/include/llvm/IR/Intrinsics.td:1102 -let IntrProperties = [IntrInaccessibleMemOnly, IntrWillReturn] in { +/// IntrStrictFP - The intrinsic is allowed

[PATCH] D154359: [clang] Reset FP options before template instantiation

zahiraam added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiateDecl.cpp:5093 +FpPragmaStack.CurrentValue = FPOptionsOverride(); + if (addInstantiatedParametersToScope(Function, PatternDecl, Scope, This seems to be fixing the crash.

[clang] 06611e3 - [clang] Implement `PointerLikeTraits` for `{File,Directory}EntryRef`

Author: Jan Svoboda Date: 2023-07-11T11:17:24-07:00 New Revision: 06611e361363a4c209aaccd0ee24652d2c56cafb URL: https://github.com/llvm/llvm-project/commit/06611e361363a4c209aaccd0ee24652d2c56cafb DIFF: https://github.com/llvm/llvm-project/commit/06611e361363a4c209aaccd0ee24652d2c56cafb.diff

[PATCH] D154905: [clang] Implement `PointerLikeTraits` for `{File,Directory}EntryRef`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. jansvoboda11 marked an inline comment as done. Closed by commit rG06611e361363: [clang] Implement `PointerLikeTraits` for `{File,Directory}EntryRef` (authored by

[PATCH] D154991: [FPEnv][TableGen] Add strictfp attribute to constrained intrinsics by default.

kpn updated this revision to Diff 539204. kpn added a comment. Move test and change to round-tripping as requested. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154991/new/ https://reviews.llvm.org/D154991 Files: clang/test/CodeGenOpenCL/cl20-device-side-enqueue-attributes.cl

[PATCH] D154983: [clang-extdef-mapping] register necessary targest for ms-style asm block

thieta accepted this revision. thieta added a comment. This revision is now accepted and ready to land. Looks fine to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154983/new/ https://reviews.llvm.org/D154983

[PATCH] D154991: [FPEnv][TableGen] Add strictfp attribute to constrained intrinsics by default.

arsenm added inline comments. Comment at: llvm/test/Feature/fp-intrinsics-attr.ll:1 +; RUN: opt -passes=verify -S < %s | FileCheck %s + Should move to test/Assembler and round trip through llvm-as and llvm-dis like other similar tests Repository: rG LLVM

[PATCH] D154991: [FPEnv][TableGen] Add strictfp attribute to constrained intrinsics by default.

kpn created this revision. kpn added reviewers: pengfei, chapuni, akshaykhadse, craig.topper, arsenm. Herald added a subscriber: jdoerfert. Herald added a project: All. kpn requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, wdng. Herald added projects: clang,

[PATCH] D154658: Optimize emission of `dynamic_cast` to final classes.

rjmccall added a comment. In D154658#4482202 , @rsmith wrote: > In D154658#4481225 , @rjmccall > wrote: > >> In D154658#4479213 , @rsmith wrote: >> >>> I think (hope?)

[PATCH] D152554: [OpenMP] Migrate device code privatisation from Clang CodeGen to OMPIRBuilder

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152554/new/ https://reviews.llvm.org/D152554

[PATCH] D150803: [WebAssembly] Support `annotate` clang attributes for marking functions.

brendandahl updated this revision to Diff 539191. brendandahl added a comment. Rebase on main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150803/new/ https://reviews.llvm.org/D150803 Files: lld/test/wasm/func-attr-tombstone.s

[PATCH] D154910: [ARM][AArch64] Make ACLE __clzl/__clzll return unsigned int instead of unsigned long/uint64_t.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2df12f30551e: [ARM][AArch64] Make ACLE __clzl/__clzll return unsigned int instead of unsigned… (authored by craig.topper). Repository: rG LLVM

[clang] 2df12f3 - [ARM][AArch64] Make ACLE __clzl/__clzll return unsigned int instead of unsigned long/uint64_t.

Author: Craig Topper Date: 2023-07-11T10:42:25-07:00 New Revision: 2df12f30551e0cb9ecfd49a0cacf929e785c15da URL: https://github.com/llvm/llvm-project/commit/2df12f30551e0cb9ecfd49a0cacf929e785c15da DIFF: https://github.com/llvm/llvm-project/commit/2df12f30551e0cb9ecfd49a0cacf929e785c15da.diff

[PATCH] D153920: [clang] Move the clang formatting job to run-buildbot to fix the CI

philnik updated this revision to Diff 539183. philnik added a comment. Herald added a reviewer: NoQ. Try to fix CI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153920/new/ https://reviews.llvm.org/D153920 Files:

[PATCH] D154602: [clang][clangd] Don't crash/assert on -gsplit-dwarf=single without output

MaskRay added inline comments. Comment at: clang/unittests/Driver/ToolChainTest.cpp:371 +TEST(CompilerInvocation, SplitSwarfSingleCrash) { + static constexpr const char *Args[] = {"clang", "-gdwarf-4", "-gsplit-dwarf=single", "-c", "foo.cpp"}; + CreateInvocationOptions

[PATCH] D154602: [clang][clangd] Don't crash/assert on -gsplit-dwarf=single without output

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. https://maskray.me/blog/2021-08-08-toolchain-testing#the-test-checks-at-the-wrong-layer I think there is a minor "The test checks too little" issue as we can utilize the test to check a few

[PATCH] D154357: [Driver] Recognize powerpc-unknown-eabi as a bare-metal toolchain

MaskRay added a comment. The code change looks good but the driver test will cause an issue. I think we need a fake sysroot tree under `Inputs/`. Otherwise if we have a system cross gcc at `/usr/lib/gcc{,-cross}/powerpc64le-unknown-eabi/12`, Clang Driver will pick up these files. This is really

[PATCH] D152021: [clang][AIX] Fix Overly Strict LTO Option Checking against `data-sections` when `mxcoff-roptr` is in Effect

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0b66b3417c02: [clang][AIX] Fix Overly Strict LTO Option Checking against `data-sections` when… (authored by qiongsiwu1). Repository: rG LLVM

  1   2   3   >