[PATCH] D155387: [Clang] Fix member lookup so that we don't ignore ambiguous lookups in some cases

shafik added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:14930 LookupQualifiedName(R, Record->getDecl()); - R.suppressDiagnostics(); + R.suppressAccessDiagnostics(); shafik wrote: > rsmith wrote: > > shafik wrote: > > > I was a bit

[PATCH] D155413: [NFC] Add `push_back` to `llvm::Function`

etcwilde added a comment. Failure was a formatting issue in `clang/lib/Analysis/UnsafeBufferUsage.cpp`. I just fixed that in d7b45945fbb7c4ac27c456dd7c2ff8bb40fcf8f8 . I don't know how to re-trigger the tests though.

[clang] d7b4594 - [NFC][clang] Fix format in UnsafeBufferUsage.cpp

Author: Evan Wilde Date: 2023-07-16T22:45:29-07:00 New Revision: d7b45945fbb7c4ac27c456dd7c2ff8bb40fcf8f8 URL: https://github.com/llvm/llvm-project/commit/d7b45945fbb7c4ac27c456dd7c2ff8bb40fcf8f8 DIFF: https://github.com/llvm/llvm-project/commit/d7b45945fbb7c4ac27c456dd7c2ff8bb40fcf8f8.diff

[PATCH] D155380: [clang] Fix delayed template parsing

sepavloff updated this revision to Diff 540861. sepavloff added a comment. Fix clang-format errors Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155380/new/ https://reviews.llvm.org/D155380 Files: clang/include/clang/Sema/Sema.h

[PATCH] D4784: [clang-tidy] Add check for possibly incomplete switch statements

xgupta added a comment. In D4784#4504690 , @PiotrZSL wrote: > Just few nits (column numbers in test, missing doxygen comment, ...). > Please fix those before committing. > > Except that, looking good to me. Thanks for this nice code review. Repository:

[PATCH] D4784: [clang-tidy] Add check for possibly incomplete switch statements

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG42179bbf6bcc: [clang-tidy] Add check for possibly incomplete switch statements (authored by shivam-amd). Repository: rG LLVM Github Monorepo

[clang-tools-extra] 42179bb - [clang-tidy] Add check for possibly incomplete switch statements

Author: Shivam Gupta Date: 2023-07-17T10:40:11+05:30 New Revision: 42179bbf6bcc9f90256b443c30f5e99f862bc2f6 URL: https://github.com/llvm/llvm-project/commit/42179bbf6bcc9f90256b443c30f5e99f862bc2f6 DIFF: https://github.com/llvm/llvm-project/commit/42179bbf6bcc9f90256b443c30f5e99f862bc2f6.diff

[PATCH] D4784: [clang-tidy] Add check for possibly incomplete switch statements

xgupta updated this revision to Diff 540857. xgupta marked 6 inline comments as done. xgupta added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D4784/new/ https://reviews.llvm.org/D4784 Files:

[PATCH] D4784: [clang-tidy] Add check for possibly incomplete switch statements

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. Just few nits (column numbers in test, missing doxygen comment, ...). Please fix those before committing. Except that, looking good to me. Comment at:

[PATCH] D155416: [Clang][RISCV] Improve diagnostic message for full multiply intrinsics

eopXD created this revision. eopXD added reviewers: aaron.ballman, craig.topper. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones,

[PATCH] D155413: [NFC] Add `push_back` to `llvm::Function`

etcwilde updated this revision to Diff 540850. etcwilde added a comment. Fixing `push_back` formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155413/new/ https://reviews.llvm.org/D155413 Files: clang/lib/CodeGen/CGStmt.cpp

[PATCH] D155414: [Clang][RISCV] Guard RVV intrinsics types that is not available when ELEN < 64

eopXD created this revision. eopXD added reviewers: aaron.ballman, craig.topper. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones,

[PATCH] D4784: [clang-tidy] Add check for possibly incomplete switch statements

xgupta updated this revision to Diff 540845. xgupta marked an inline comment as done. xgupta added a comment. Updated testcase [WIP] Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D4784/new/ https://reviews.llvm.org/D4784 Files:

[PATCH] D142702: [Clang][AArch64][SME] Generate target features from +(no)sme.* options

bryanpkc updated this revision to Diff 540842. bryanpkc marked an inline comment as done. bryanpkc added a comment. Removed dependency on SVE and SVE2 as per @sdesmalen's suggestion. Also made `nobf16` imply `nosme` to be consistent with the handling of other feature dependencies. Repository:

[PATCH] D134681: [Clang][AArch64][SME] Add outer product intrinsics

bryanpkc updated this revision to Diff 540841. bryanpkc added a comment. Removed the attribute macro from tests, as @sdesmalen suggested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134681/new/ https://reviews.llvm.org/D134681 Files:

[PATCH] D134680: [Clang][AArch64][SME] Add intrinsics for adding vector elements to ZA tile

bryanpkc updated this revision to Diff 540840. bryanpkc added a comment. Removed the attribute macro from tests, as @sdesmalen suggested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134680/new/ https://reviews.llvm.org/D134680 Files:

[PATCH] D134678: [Clang][AArch64][SME] Add intrinsics for ZA array load/store (LDR/STR)

bryanpkc updated this revision to Diff 540839. bryanpkc added a comment. Removed the attribute macro from tests, as @sdesmalen suggested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134678/new/ https://reviews.llvm.org/D134678 Files:

[PATCH] D134677: [Clang][AArch64][SME] Add ZA zeroing intrinsics

bryanpkc updated this revision to Diff 540838. bryanpkc added a comment. Removed the attribute macro as suggested. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134677/new/ https://reviews.llvm.org/D134677 Files: clang/include/clang/Basic/arm_sme.td

[PATCH] D128648: [Clang][AArch64][SME] Add vector read/write (mova) intrinsics

bryanpkc marked an inline comment as done. bryanpkc added inline comments. Comment at: clang/test/CodeGen/aarch64-sme-intrinsics/acle_sme_read.c:13 +#else +#define ARM_STREAMING_ATTR __attribute__((arm_streaming)) +#endif sdesmalen wrote: > The spelling has

[PATCH] D155413: [NFC] Add `push_back` to `llvm::Function`

etcwilde created this revision. etcwilde added reviewers: compnerd, vporpo. etcwilde added a project: LLVM. Herald added a project: All. etcwilde requested review of this revision. Herald added a project: clang. Herald added subscribers: llvm-commits, cfe-commits. Appending a basic block to a

[PATCH] D155407: [Driver] Warn about all instances -mios-version-min not just the last

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf7ad7d147b9c: [Driver] Warn about all instances -mios-version-min not just the last (authored by porglezomp). Repository: rG LLVM Github Monorepo

[clang] f7ad7d1 - [Driver] Warn about all instances -mios-version-min not just the last

Author: Cassie Jones Date: 2023-07-16T16:45:49-07:00 New Revision: f7ad7d147b9c1e45e3f80f9e50be9984a8798e1a URL: https://github.com/llvm/llvm-project/commit/f7ad7d147b9c1e45e3f80f9e50be9984a8798e1a DIFF: https://github.com/llvm/llvm-project/commit/f7ad7d147b9c1e45e3f80f9e50be9984a8798e1a.diff

[PATCH] D155387: [Clang] Fix member lookup so that we don't ignore ambiguous lookups in some cases

shafik added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:14930 LookupQualifiedName(R, Record->getDecl()); - R.suppressDiagnostics(); + R.suppressAccessDiagnostics(); rsmith wrote: > shafik wrote: > > I was a bit conservative where I

[PATCH] D155410: [clang][Interp] Fix comparing nan/inf floating point values

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, shafik, cor3ntin. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D155408: [Driver] Also warn about -mwatchos-version-min and -mtvos-version-min

porglezomp created this revision. porglezomp added reviewers: arphaman, t.p.northover, MaskRay, ahatanak. Herald added a subscriber: kristof.beyls. Herald added a project: All. porglezomp requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D155367: [clang][Interp] Implement __builtin_inf() etc.

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/InterpBuiltin.cpp:119 +static bool interp__builtin_inf(InterpState , CodePtr OpPC, +const InterpFrame *Frame, const Function *F) { cor3ntin wrote: > why does that

[PATCH] D155387: [Clang] Fix member lookup so that we don't ignore ambiguous lookups in some cases

rsmith added inline comments. Comment at: clang/include/clang/Sema/Lookup.h:228-229 Other.Paths = nullptr; -Other.Diagnose = false; +Other.DiagnoseAccess = false; +Other.DiagnoseAmbiguous = false; return *this; cor3ntin wrote: > rsmith

[PATCH] D154853: [clangd][c++20]Consider the constraint of a constrained auto in FindTarget.

nridge added inline comments. Comment at: clang-tools-extra/clangd/unittests/FindTargetTests.cpp:581 + +[[Fooable]] auto i = 42; + )cpp"; nridge wrote: > sammccall wrote: > > this is going to have the same behavior on the `auto` token, right? > > > > This

[PATCH] D154853: [clangd][c++20]Consider the constraint of a constrained auto in FindTarget.

nridge added inline comments. Comment at: clang-tools-extra/clangd/unittests/FindTargetTests.cpp:581 + +[[Fooable]] auto i = 42; + )cpp"; sammccall wrote: > this is going to have the same behavior on the `auto` token, right? > > This is my main practical

[PATCH] D155407: [Driver] Warn about all instances -mios-version-min not just the last

porglezomp created this revision. porglezomp added reviewers: arphaman, t.p.northover, MaskRay, ahatanak. Herald added a project: All. porglezomp requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Follow-up to D155123

[PATCH] D78038: [clangd] WIP: fix several bugs relating to include insertion

nridge added a comment. Also adding links to the open issues this fixes: - https://github.com/clangd/clangd/issues/333 - https://github.com/clangd/clangd/issues/337 Note the second issue is not specific to include insertion; it's a false positive diagnostic, which I think makes it a more

[PATCH] D155175: [Clang] Fix consteval propagation for aggregates and defaulted constructors

efriedma added a comment. > You have something specific in mind? I was thinking something along the lines of the original testcase in 63742, which successfully compiled in 16, started producing an assertion on main, and successfully compiles with this patch. Repository: rG LLVM Github

[PATCH] D78038: [clangd] WIP: fix several bugs relating to include insertion

nridge added reviewers: hokein, kadircet, VitaNuo. nridge added a comment. Let's try adding some reviewers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78038/new/ https://reviews.llvm.org/D78038 ___

[PATCH] D4784: [clang-tidy] Add check for possibly incomplete switch statements

PiotrZSL added a comment. Tests need to be reverted, and template handling corrected (check comments). After that it looks good to me. Comment at: clang-tools-extra/clang-tidy/bugprone/SwitchMissingDefaultCaseCheck.cpp:29 + Finder->addMatcher( +

[PATCH] D153458: [clang-tidy] Model noexcept more properly in bugprone-exception-escape

PiotrZSL updated this revision to Diff 540823. PiotrZSL marked 5 inline comments as done. PiotrZSL added a comment. Fix review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153458/new/ https://reviews.llvm.org/D153458 Files:

[PATCH] D151495: [clang-tidy] Improve build-in type handling in bugprone-swapped-arguments

This revision was automatically updated to reflect the committed changes. Closed by commit rGcc4f86562127: [clang-tidy] Improve build-in type handling in bugprone-swapped-arguments (authored by PiotrZSL). Changed prior to commit: https://reviews.llvm.org/D151495?vs=525786=540822#toc

[clang-tools-extra] cc4f865 - [clang-tidy] Improve build-in type handling in bugprone-swapped-arguments

Author: Piotr Zegar Date: 2023-07-16T18:29:29Z New Revision: cc4f86562127f29560abb54d0c11f277b3373a2a URL: https://github.com/llvm/llvm-project/commit/cc4f86562127f29560abb54d0c11f277b3373a2a DIFF: https://github.com/llvm/llvm-project/commit/cc4f86562127f29560abb54d0c11f277b3373a2a.diff LOG:

[PATCH] D155387: [Clang] Fix member lookup so that we don't ignore ambiguous lookups in some cases

cor3ntin added inline comments. Comment at: clang/include/clang/Sema/Lookup.h:228-229 Other.Paths = nullptr; -Other.Diagnose = false; +Other.DiagnoseAccess = false; +Other.DiagnoseAmbiguous = false; return *this; rsmith wrote: > cor3ntin

[PATCH] D154838: [analyzer] Add check for null pointer passed to %p of printf family

steakhal added a comment. Expect a review on around the next weekend due to vacations from me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154838/new/ https://reviews.llvm.org/D154838 ___ cfe-commits

[PATCH] D151495: [clang-tidy] Improve build-in type handling in bugprone-swapped-arguments

carlosgalvezp accepted this revision. carlosgalvezp added a comment. This revision is now accepted and ready to land. LGTM, thank you for the fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151495/new/ https://reviews.llvm.org/D151495

[PATCH] D4784: [clang-tidy] Add check for possibly incomplete switch statements

xgupta added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/SwitchMissingDefaultCaseCheck.cpp:19 + Finder->addMatcher( + switchStmt(has(implicitCastExpr().bind("cast")), + unless(hasAncestor(switchStmt(has(defaultStmt())

[PATCH] D4784: [clang-tidy] Add check for possibly incomplete switch statements

xgupta updated this revision to Diff 540818. xgupta marked 5 inline comments as done. xgupta added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D4784/new/ https://reviews.llvm.org/D4784 Files:

[PATCH] D153458: [clang-tidy] Model noexcept more properly in bugprone-exception-escape

carlosgalvezp added a comment. Looks good, great to see all these issues fixed! Have a couple small comments. Comment at: clang-tools-extra/clang-tidy/utils/ExceptionAnalyzer.cpp:319 +static bool cannotThrow(const FunctionDecl *Func) { + const auto *FunProto =

[PATCH] D155064: [clang][SemaCXX] Diagnose tautological uses of consteval if and is_constant_evaluated

philnik added inline comments. Comment at: libcxx/test/std/algorithms/alg.modifying.operations/alg.copy/ranges.copy.segmented.pass.cpp:96 int main(int, char**) { - if (!std::is_constant_evaluated()) { -test_containers, std::deque>(); cor3ntin wrote: >

[PATCH] D154869: [Flang] [FlangRT] Implement FlangRT library as solution to Flang's runtime LLVM integration

awarzynski added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:934-936 + // Default to the /../lib and + // /../runtimes/runtimes-bins/lib directories. This works fine + // on the platforms that we have tested so far. We will probably have to

[PATCH] D155387: [Clang] Fix member lookup so that we don't ignore ambiguous lookups in some cases

rsmith added inline comments. Comment at: clang/include/clang/Sema/Lookup.h:228-229 Other.Paths = nullptr; -Other.Diagnose = false; +Other.DiagnoseAccess = false; +Other.DiagnoseAmbiguous = false; return *this; cor3ntin wrote: > Does

[PATCH] D153881: Create diagnostic group for definition deprecation warning

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb0697a1cb0b5: Create diagnostic group for definition deprecation warning (authored by nuriamari, committed by aaron.ballman). Changed prior to

[clang] b0697a1 - Create diagnostic group for definition deprecation warning

Author: Nuri Amari Date: 2023-07-16T12:36:26-04:00 New Revision: b0697a1cb0b539c773548f62402816e2d9b6f107 URL: https://github.com/llvm/llvm-project/commit/b0697a1cb0b539c773548f62402816e2d9b6f107 DIFF: https://github.com/llvm/llvm-project/commit/b0697a1cb0b539c773548f62402816e2d9b6f107.diff

[PATCH] D155175: [Clang] Fix consteval propagation for aggregates and defaulted constructors

cor3ntin updated this revision to Diff 540809. cor3ntin added a comment. Assert if we try to generate code for a CallExpr to an immediate function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155175/new/ https://reviews.llvm.org/D155175 Files:

[PATCH] D155239: [clang-format] Add SpacesInParens with SpacesInParensOptions

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:4046 + ? (Style.SpacesInParens == FormatStyle::SIPO_Always || + Style.SpacesInParentheses) + : true; isn't SpacesInParentheses

[PATCH] D155175: [Clang] Fix consteval propagation for aggregates and defaulted constructors

cor3ntin added a comment. In D155175#4498788 , @efriedma wrote: > Do we need CodeGen testcases here for full coverage? The testcases from the > issue passed with -fsyntax-only. You have something specific in mind? The examples in the issues now lead

[PATCH] D150083: [clang-format] ObjCPropertyAttributeOrder to sort ObjC property attributes

MyDeveloperDay added a comment. may remove the other build system files, I don't think its our responsiblity to keep them upto date. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150083/new/ https://reviews.llvm.org/D150083 ___ cfe-commits

[PATCH] D150083: [clang-format] ObjCPropertyAttributeOrder to sort ObjC property attributes

MyDeveloperDay added a comment. I don't have a problem with this, but I'm not an ObjC person so I can't really review from the validity of what its changing. If @owenpan and @HazardyKnusperkeks don't have an problem with this then I don't either as it likely won't impact most C++ users.

[PATCH] D155064: [clang][SemaCXX] Diagnose tautological uses of consteval if and is_constant_evaluated

cor3ntin added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:1546 def warn_consteval_if_always_true : Warning< + "consteval if is always %select{true|false}0 in this context">, To be consistent with other tautological warnings

[PATCH] D155380: [clang] Fix delayed template parsing

mgorny accepted this revision. mgorny added a comment. This revision is now accepted and ready to land. Thanks. I can confirm that the tests pass for me with this applied. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155380/new/

[PATCH] D4784: [clang-tidy] Add check for possibly incomplete switch statements

PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/SwitchMissingDefaultCaseCheck.cpp:19 + Finder->addMatcher( + switchStmt(has(implicitCastExpr().bind("cast")), + unless(hasAncestor(switchStmt(has(defaultStmt())

[PATCH] D4784: [clang-tidy] Add check for possibly incomplete switch statements

PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/SwitchMissingDefaultCaseCheck.cpp:16-29 +void SwitchMissingDefaultCaseCheck::registerMatchers( +ast_matchers::MatchFinder *Finder) { + Finder->addMatcher( +

[PATCH] D134475: [Clang] Add support for [[msvc::constexpr]] C++11 attribute

RIscRIpt added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:3543 +definition or a return statement. It has no effect on function declarations. +This attribute permits constant evaluation of ``[[msvc::constexpr]]`` functions +in ``[[msvc::constexpr]]

[PATCH] D134475: [Clang] Add support for [[msvc::constexpr]] C++11 attribute

RIscRIpt updated this revision to Diff 540803. RIscRIpt marked an inline comment as done. RIscRIpt added a comment. Bump Renamed clang/test/AST/msvc-* to ms-* Tried to improve doc note. Rebased onto one of stable commits from main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D155387: [Clang] Fix member lookup so that we don't ignore ambiguous lookups in some cases

cor3ntin added inline comments. Comment at: clang/include/clang/Sema/Lookup.h:197-200 +DiagnoseAccess(std::move(Other.DiagnoseAccess)), +DiagnoseAmbiguous(std::move(Other.DiagnoseAmbiguous)), AllowHidden(std::move(Other.AllowHidden)),

[PATCH] D155367: [clang][Interp] Implement __builtin_inf() etc.

cor3ntin added inline comments. Comment at: clang/lib/AST/Interp/InterpBuiltin.cpp:119 +static bool interp__builtin_inf(InterpState , CodePtr OpPC, +const InterpFrame *Frame, const Function *F) { why does that return a bool? you

[PATCH] D154795: [clang][Interp] Check pointers for live-ness when returning them

cor3ntin added a comment. LGTM. It may be worth submitting an issue for the current behavior which is wrong. Do you want to add a quote to the standard? (https://eel.is/c++draft/expr.const#13.3) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D4784: [clang-tidy] Add check for possibly incomplete switch statements

xgupta marked 3 inline comments as done. xgupta added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/SwitchMissingDefaultCaseCheck.cpp:16-29 +void SwitchMissingDefaultCaseCheck::registerMatchers( +ast_matchers::MatchFinder *Finder) { +

[PATCH] D4784: [clang-tidy] Add check for possibly incomplete switch statements

xgupta updated this revision to Diff 540798. xgupta marked an inline comment as done. xgupta added a comment. Address comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D4784/new/ https://reviews.llvm.org/D4784 Files:

[PATCH] D155081: Specify the developer policy around links to external resources

aaron.ballman added a comment. In D155081#4499046 , @lattner wrote: > Thank you so much for raising this issue Aaron. > > Documenting the policy in the developer policy is totally the right thing to > do given this cross-cuts individual subprojects, but

[PATCH] D155401: [clang][Interp] Implement __builtin_fmax

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, shafik, cor3ntin. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D155400: [clang][Interp] Implement __builtin_fabs()

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, shafik, cor3ntin. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D155367: [clang][Interp] Implement __builtin_inf() etc.

tbaeder updated this revision to Diff 540774. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155367/new/ https://reviews.llvm.org/D155367 Files: clang/lib/AST/Interp/InterpBuiltin.cpp Index: clang/lib/AST/Interp/InterpBuiltin.cpp

[PATCH] D155175: [Clang] Fix consteval propagation for aggregates and defaulted constructors

cor3ntin updated this revision to Diff 540773. cor3ntin added a comment. Fix the evaluation context of member initializers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155175/new/ https://reviews.llvm.org/D155175 Files:

[PATCH] D155396: [Sema][ObjC] Propagating value-dependent errors into BlockExpr

danix800 created this revision. danix800 added a reviewer: aaron.ballman. danix800 added a project: clang. Herald added a project: All. danix800 requested review of this revision. Herald added a subscriber: cfe-commits. Fix https://github.com/llvm/llvm-project/issues/63863 Repository: rG LLVM

[PATCH] D155394: [clang][Interp] Implement __builtin_fpclassify

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, shafik, cor3ntin. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D154903: clangd: Provide the resource dir via environment variable

sammccall added a comment. I'm a little nervous about this. On the one hand it's simple and I want to get you unblocked but: - the more ways to initialize resource dir and the more places this needs to be propagated to, the more likely this is to get out of sync - we might want to remove the

[PATCH] D155380: [clang] Fix delayed template parsing

sepavloff updated this revision to Diff 540764. sepavloff added a comment. Use calculated default FP options Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155380/new/ https://reviews.llvm.org/D155380 Files: clang/include/clang/Sema/Sema.h

[PATCH] D155370: [CodeComplete] Don't emit parameters when not FunctionCanBeCall

sammccall added a comment. I'm not sure switching to RK_Pattern is ideal, but I think there are a couple of (easy?) alternatives that achieve the same. > Regard to the heuristic itself, it's currently a bit inconvenient that I have > to switch headers and sources back and forth and do

[PATCH] D155393: [clang][Interp] Implement __builtin_isfpclass

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, shafik, cor3ntin. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D155392: [clangd] add a config knob to disable modules

sammccall added inline comments. Comment at: clang-tools-extra/clangd/unittests/FindSymbolsTests.cpp:497 TEST(DocumentSymbols, ExportContext) { + Config EnableModules; + EnableModules.CompileFlags.NaiveModules = true; For existing tests of how modules

[PATCH] D155392: [clangd] add a config knob to disable modules

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. We don't

[PATCH] D155369: [clang][Interp] Implement __builtin_isnan()

tbaeder updated this revision to Diff 540760. tbaeder marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155369/new/ https://reviews.llvm.org/D155369 Files: clang/lib/AST/Interp/Function.cpp clang/lib/AST/Interp/Function.h