[PATCH] D151547: [RISCV] Remove experimental for zihintntl.

BeMg added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151547/new/ https://reviews.llvm.org/D151547 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D155145: [X86] Add AVX-VNNI-INT16 instructions.

pengfei accepted this revision. pengfei added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155145/new/ https://reviews.llvm.org/D155145

[PATCH] D155148: [X86] Add SM4 instructions.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG049d6a3f428e: [X86] Add SM4 instructions. (authored by FreddyYe). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 049d6a3 - [X86] Add SM4 instructions.

Author: Freddy Ye Date: 2023-07-20T13:35:15+08:00 New Revision: 049d6a3f428efeb1a22f62e55b808f60b0bf27cc URL: https://github.com/llvm/llvm-project/commit/049d6a3f428efeb1a22f62e55b808f60b0bf27cc DIFF: https://github.com/llvm/llvm-project/commit/049d6a3f428efeb1a22f62e55b808f60b0bf27cc.diff

[PATCH] D155148: [X86] Add SM4 instructions.

FreddyYe updated this revision to Diff 542305. FreddyYe added a comment. rebase and fix lit fail Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155148/new/ https://reviews.llvm.org/D155148 Files: clang/docs/ReleaseNotes.rst

[PATCH] D155145: [X86] Add AVX-VNNI-INT16 instructions.

FreddyYe added a comment. ping... Anyone help accept? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155145/new/ https://reviews.llvm.org/D155145 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D155773: [llvm][MemoryBuiltins] Add alloca support to getInitialValueOfAllocation

jmciver created this revision. jmciver added reviewers: nikic, efriedma, fhahn. Herald added subscribers: kmitropoulou, ormris, ChuanqiXu, StephenFan, wenlei, steven_wu, hiraditya. Herald added a project: All. jmciver published this revision for review. Herald added projects: clang, LLVM. Herald

[PATCH] D153906: [clang] Allow disassembly of multi-module bitcode files

MaskRay added a comment. Is a simpler change like D154923 sufficient? It also handles the case when we don't emit `.ll`, but `.o` or `.s`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153906/new/ https://reviews.llvm.org/D153906

[PATCH] D155539: [CUDA][HIP] Use the same default language std as C++

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2d1d07152bd2: [CUDA][HIP] Use the same default language std as C++ (authored by yaxunl). Herald added a project: clang. Changed prior to commit:

[clang] 2d1d071 - [CUDA][HIP] Use the same default language std as C++

Author: Yaxun (Sam) Liu Date: 2023-07-19T23:54:58-04:00 New Revision: 2d1d07152bd26b001dedec3400b4b01d3bb11622 URL: https://github.com/llvm/llvm-project/commit/2d1d07152bd26b001dedec3400b4b01d3bb11622 DIFF:

[PATCH] D151547: [RISCV] Remove experimental for zihintntl.

jacquesguan added a comment. In D151547#4514424 , @asb wrote: > I remain concerned about exposing the intrinsics if they're not yet agreed as > finalised. I see there is now a PR to add them to riscv-c-api doc >

[PATCH] D151547: [RISCV] Remove experimental for zihintntl.

jacquesguan updated this revision to Diff 542290. jacquesguan marked 2 inline comments as done. jacquesguan added a comment. rebase main and address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151547/new/

[PATCH] D155776: [NFC] Add checks for self-assignment.

schittir created this revision. Herald added a project: All. schittir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D155776 Files:

[PATCH] D155775: [Clang][Driver][RFC] Add driver support for C++ Parallel Algorithm Offload

AlexVlx updated this revision to Diff 542287. AlexVlx added a comment. Removed some accidental noise. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155775/new/ https://reviews.llvm.org/D155775 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td

[PATCH] D155775: [Clang][Driver][RFC] Add driver support for C++ Parallel Algorithm Offload

AlexVlx created this revision. AlexVlx added reviewers: jansvoboda11, arsenm, yaxunl, MaskRay. AlexVlx added a project: clang. Herald added subscribers: cmtice, kerbowa, ormris, hiraditya, tpr, jvesely. Herald added a reviewer: jhenderson. Herald added a project: All. AlexVlx requested review of

[PATCH] D155774: [NFC] Remove needless nullchecks.

schittir created this revision. schittir added reviewers: aaron.ballman, tahonermann. Herald added a project: All. schittir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D143617: [Clang][CMake] Support perf, LBR, and Instrument CLANG_BOLT options

Amir updated this revision to Diff 542280. Amir added a comment. Make the name of BOLT-instrumented Clang binary (CLANG_BOLT_INSTRUMENTED) a user-settable cache variable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143617/new/

[PATCH] D154324: [C++20] [Modules] [ODRHash] Use CanonicalType for base classes

alexfh added a comment. In D154324#4516917 , @ChuanqiXu wrote: > In D154324#4516605 , @alexfh wrote: > >> Hi, we've started seeing compilation errors with our modularized build after >> this commit. The errors

[PATCH] D155147: [X86] Add SM3 instructions.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc6f66de21af0: [X86] Add SM3 instructions. (authored by FreddyYe). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] c6f66de - [X86] Add SM3 instructions.

Author: Freddy Ye Date: 2023-07-20T10:24:16+08:00 New Revision: c6f66de21af060ead6e5402858351e9e869dc15f URL: https://github.com/llvm/llvm-project/commit/c6f66de21af060ead6e5402858351e9e869dc15f DIFF: https://github.com/llvm/llvm-project/commit/c6f66de21af060ead6e5402858351e9e869dc15f.diff

[PATCH] D155147: [X86] Add SM3 instructions.

FreddyYe updated this revision to Diff 542274. FreddyYe added a comment. rebase and fix lit fail Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155147/new/ https://reviews.llvm.org/D155147 Files: clang/docs/ReleaseNotes.rst

[PATCH] D143617: [Clang][CMake] Support perf, LBR, and Instrument CLANG_BOLT options

Amir updated this revision to Diff 542272. Amir added a comment. Set CLANG_BOLT_INSTRUMENTED in parent scope too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143617/new/ https://reviews.llvm.org/D143617 Files: clang/CMakeLists.txt

[PATCH] D155769: [Clang][docs][RFC] Add documentation for C++ Parallel Algorithm Offload

AlexVlx created this revision. AlexVlx added reviewers: rjmccall, yaxunl, aaron.ballman. AlexVlx added a project: clang. Herald added a subscriber: arphaman. Herald added a project: All. AlexVlx requested review of this revision. Herald added a subscriber: cfe-commits. This patch adds the

[PATCH] D154324: [C++20] [Modules] [ODRHash] Use CanonicalType for base classes

ChuanqiXu added a comment. In D154324#4516605 , @alexfh wrote: > Hi, we've started seeing compilation errors with our modularized build after > this commit. The errors say `'SomeType' has different definitions in > different modules`, but then point to

[PATCH] D86310: [X86] Align i128 to 16 bytes in x86 datalayouts

hvdijk added a comment. In D86310#4516876 , @pengfei wrote: > Just FYI. There are a few reports about the compatibility issues, e.g., > #41784 . Thanks. This is a case where clang breaks up `__int128`

[PATCH] D155146: [X86] Add SHA512 instructions.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfc3b7874b6c9: [X86] Add SHA512 instructions. (authored by FreddyYe). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] fc3b787 - [X86] Add SHA512 instructions.

Author: Freddy Ye Date: 2023-07-20T09:44:44+08:00 New Revision: fc3b7874b6c95f04a249e2c9da3c5221f50c85b2 URL: https://github.com/llvm/llvm-project/commit/fc3b7874b6c95f04a249e2c9da3c5221f50c85b2 DIFF: https://github.com/llvm/llvm-project/commit/fc3b7874b6c95f04a249e2c9da3c5221f50c85b2.diff

[PATCH] D153059: [-Wunsafe-buffer-usage] Group parameter fix-its

NoQ added a comment. Alright, I think I managed to fully chew through this patch and I think it's beautiful and everything makes sense to me! I have a tiny complaint though: It is very large though, 500 lines of code is very hard to digest all at once. Because we aren't coming in with all the

[PATCH] D86310: [X86] Align i128 to 16 bytes in x86 datalayouts

pengfei added a comment. Just FYI. There are a few reports about the compatibility issues, e.g., #41784 . There's also concern about the alignment difference between `_BitInt(128)` and `__int128`, see #60925

[PATCH] D155146: [X86] Add SHA512 instructions.

FreddyYe updated this revision to Diff 542267. FreddyYe added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155146/new/ https://reviews.llvm.org/D155146 Files: clang/docs/ReleaseNotes.rst

[PATCH] D143617: [Clang][CMake] Support perf, LBR, and Instrument CLANG_BOLT options

Amir updated this revision to Diff 542264. Amir marked an inline comment as done. Amir added a comment. Fix instrumentation mode Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143617/new/ https://reviews.llvm.org/D143617 Files:

[PATCH] D155529: [clang-format] Add SpaceInParensOption for __attribute__ keyword

gedare updated this revision to Diff 542254. gedare added a comment. remove blank line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155529/new/ https://reviews.llvm.org/D155529 Files: clang/docs/ClangFormatStyleOptions.rst

[PATCH] D155529: [clang-format] Add SpaceInParensOption for __attribute__ keyword

gedare updated this revision to Diff 542253. gedare added a comment. Rebase onto D155239 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155529/new/ https://reviews.llvm.org/D155529 Files:

[PATCH] D153092: [Clang][CodeGen]`vtable`, `typeinfo` et al. are globals

bjope added inline comments. Comment at: clang/lib/CodeGen/CGVTables.cpp:693 return Int32Ty; - return Int8PtrTy; + return GlobalsInt8PtrTy; } I noticed that we have some old fixes downstream that conflicts with the changes you've made here. I thought

[PATCH] D144829: [BPF] Add a few new insns under cpu=v4

ast accepted this revision. ast added a comment. lgtm. @eddyz87 pls take a look Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144829/new/ https://reviews.llvm.org/D144829 ___ cfe-commits mailing list

[PATCH] D155239: [clang-format] Add SpacesInParens with SpacesInParensOptions

gedare updated this revision to Diff 542249. gedare added a comment. Add config parse tests for deprecated options, and add tests for __attribute__ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155239/new/ https://reviews.llvm.org/D155239 Files:

[PATCH] D151587: [clang][ConstantEmitter] have tryEmitPrivate[ForVarInit] try ConstExprEmitter fast-path first

efriedma added a comment. This seems to work: diff --git a/clang/lib/AST/Expr.cpp b/clang/lib/AST/Expr.cpp index 25d3535e..98b1e4d 100644 --- a/clang/lib/AST/Expr.cpp +++ b/clang/lib/AST/Expr.cpp @@ -3319,6 +3319,10 @@ bool Expr::isConstantInitializer(ASTContext , bool IsForRef,

[PATCH] D144829: [WIP][BPF] Add a few new insns under cpu=v4

yonghong-song updated this revision to Diff 542245. yonghong-song added a comment. - remove a copy-paste comment from s390 arch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144829/new/ https://reviews.llvm.org/D144829 Files:

[PATCH] D155714: [clang] Fix diagnostics for defaulted, implicitly deleted 'operator=='.

AMP999 updated this revision to Diff 542240. AMP999 added a comment. Revised the formatting of the change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155714/new/ https://reviews.llvm.org/D155714 Files: clang/lib/Sema/SemaDeclCXX.cpp

[PATCH] D155759: [Clang][CodeGen] Follow-up for `vtable`, `typeinfo` et al. are globals

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf385abf131e0: [Clang][CodeGen] Follow-up for `vtable`, `typeinfo` et al. are globals (authored by AlexVlx). Repository: rG LLVM Github Monorepo

[clang] f385abf - [Clang][CodeGen] Follow-up for `vtable`, `typeinfo` et al. are globals

Author: Alex Voicu Date: 2023-07-19T23:57:12+01:00 New Revision: f385abf131e01b12b14ac3bc7214eb119b40523e URL: https://github.com/llvm/llvm-project/commit/f385abf131e01b12b14ac3bc7214eb119b40523e DIFF: https://github.com/llvm/llvm-project/commit/f385abf131e01b12b14ac3bc7214eb119b40523e.diff

[PATCH] D154324: [C++20] [Modules] [ODRHash] Use CanonicalType for base classes

alexfh added a comment. Hi, we've started seeing compilation errors with our modularized build after this commit. The errors say `'SomeType' has different definitions in different modules`, but then point to the same definition that comes from the same textual header included into two modules.

[PATCH] D152914: [Draft] Make __builtin_cpu builtins target-independent

ilinpv added a comment. In D152914#4497599 , @nemanjai wrote: > I took a quick look at your patch. I think it would be preferable to make the > builtins target-independent rather than implementing the builtin by the same > name for multiple targets.

[clang] 990645f - Revert "[OptTable] Make explicitly included options override excluded ones"

Author: Justin Bogner Date: 2023-07-19T15:43:50-07:00 New Revision: 990645f949c7ede7467b93294bbddbe4661513f1 URL: https://github.com/llvm/llvm-project/commit/990645f949c7ede7467b93294bbddbe4661513f1 DIFF: https://github.com/llvm/llvm-project/commit/990645f949c7ede7467b93294bbddbe4661513f1.diff

[PATCH] D155729: [OptTable] Make explicitly included options override excluded ones

MaskRay added a comment. Thank you! The clean up is nice. I missed the original change that added the DXCOption complexity.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155729/new/ https://reviews.llvm.org/D155729

[PATCH] D155729: [OptTable] Make explicitly included options override excluded ones

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb2eda85f047f: [OptTable] Make explicitly included options override excluded ones (authored by bogner). Repository: rG LLVM Github Monorepo

[clang] b2eda85 - [OptTable] Make explicitly included options override excluded ones

Author: Justin Bogner Date: 2023-07-19T15:28:34-07:00 New Revision: b2eda85f047f27788ccd7b9af9bd59c5d44b2051 URL: https://github.com/llvm/llvm-project/commit/b2eda85f047f27788ccd7b9af9bd59c5d44b2051 DIFF: https://github.com/llvm/llvm-project/commit/b2eda85f047f27788ccd7b9af9bd59c5d44b2051.diff

[clang-tools-extra] b2eda85 - [OptTable] Make explicitly included options override excluded ones

Author: Justin Bogner Date: 2023-07-19T15:28:34-07:00 New Revision: b2eda85f047f27788ccd7b9af9bd59c5d44b2051 URL: https://github.com/llvm/llvm-project/commit/b2eda85f047f27788ccd7b9af9bd59c5d44b2051 DIFF: https://github.com/llvm/llvm-project/commit/b2eda85f047f27788ccd7b9af9bd59c5d44b2051.diff

[PATCH] D154658: Optimize emission of `dynamic_cast` to final classes.

rjmccall added a comment. LGTM, except, should we have a way to turn this optimization off specifically? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154658/new/ https://reviews.llvm.org/D154658 ___

[PATCH] D153914: [clang-cl] Enable concatenation of predefined identifiers

RIscRIpt added inline comments. Comment at: clang/include/clang/Basic/TokenKinds.h:87-93 +/// Return true if this token is a predefined macro +/// unexpandable by MSVC preprocessor. +inline bool isUnexpandableMsMacro(TokenKind K) { + return K == tok::kw___FUNCTION__ || K ==

[clang] aa972f6 - -fsanitize=function, MicrosoftMangle: Switch to xxh3_64bits

Author: Fangrui Song Date: 2023-07-19T15:20:50-07:00 New Revision: aa972f607c55cdbab3b9182aacb3ed6a5d9e73e1 URL: https://github.com/llvm/llvm-project/commit/aa972f607c55cdbab3b9182aacb3ed6a5d9e73e1 DIFF: https://github.com/llvm/llvm-project/commit/aa972f607c55cdbab3b9182aacb3ed6a5d9e73e1.diff

[PATCH] D155759: [Clang][CodeGen] Follow-up for `vtable`, `typeinfo` et al. are globals

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155759/new/ https://reviews.llvm.org/D155759

[PATCH] D155756: -fsanitize={function,kcfi}: Switch to xxh3_64bits

MaskRay added a comment. In D155756#4516501 , @samitolvanen wrote: > Changing the hash function breaks compatibility with the Rust KCFI > implementation >

[PATCH] D154658: Optimize emission of `dynamic_cast` to final classes.

rsmith added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154658/new/ https://reviews.llvm.org/D154658 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D155759: [Clang][CodeGen] Follow-up for `vtable`, `typeinfo` et al. are globals

AlexVlx created this revision. AlexVlx added reviewers: yaxunl, efriedma, rjmccall. Herald added a project: All. AlexVlx requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Unfortunately,

[PATCH] D151587: [clang][ConstantEmitter] have tryEmitPrivate[ForVarInit] try ConstExprEmitter fast-path first

nickdesaulniers added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:8360 + // Do not constant fold an R-value. + if (Info.EvalMode == EvalInfo::EM_ConstantFold && !E->isLValue()) +return false; efriedma wrote: > efriedma wrote: > >

[PATCH] D155756: -fsanitize={function,kcfi}: Switch to xxh3_64bits

samitolvanen added a comment. Changing the hash function breaks compatibility with the Rust KCFI implementation . I would personally like

[PATCH] D155667: [-Wunsafe-buffer-usage] Check source location validity before using `TypeLoc`s

This revision was automatically updated to reflect the committed changes. Closed by commit rGa6302b6934b3: [-Wunsafe-buffer-usage] Check source location validity before using `TypeLoc`s (authored by ziqingluo-90). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] a6302b6 - [-Wunsafe-buffer-usage] Check source location validity before using `TypeLoc`s

Author: ziqingluo-90 Date: 2023-07-19T15:04:42-07:00 New Revision: a6302b6934b349fff122eeb6c4b39eff580c4b1b URL: https://github.com/llvm/llvm-project/commit/a6302b6934b349fff122eeb6c4b39eff580c4b1b DIFF: https://github.com/llvm/llvm-project/commit/a6302b6934b349fff122eeb6c4b39eff580c4b1b.diff

[PATCH] D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS

DiggerLin updated this revision to Diff 542209. DiggerLin marked 5 inline comments as done. DiggerLin added a comment. address comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142660/new/ https://reviews.llvm.org/D142660 Files:

[PATCH] D155756: -fsanitize={function,kcfi}: Switch to xxh3_64bits

MaskRay created this revision. MaskRay added a reviewer: samitolvanen. Herald added a project: All. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Following recent changes switching from xxh64 to xxh32 for better hashing

[PATCH] D155524: [-Wunsafe-buffer-usage] Ignore the FixableGadgets that will not be fixed at an earlier stage

ziqingluo-90 updated this revision to Diff 542199. ziqingluo-90 added a comment. Address comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155524/new/ https://reviews.llvm.org/D155524 Files: clang/lib/Analysis/UnsafeBufferUsage.cpp

[PATCH] D155385: [clangd] enable unused-include warnings for standard library headers

This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rGe289ee99cec4: [clangd] enable unused-include warnings for standard library headers (authored by sammccall). Changed prior to commit:

[clang-tools-extra] e289ee9 - [clangd] enable unused-include warnings for standard library headers

Author: Sam McCall Date: 2023-07-19T23:43:47+02:00 New Revision: e289ee99cec4607243aeaa01504f6b3cf65b65fe URL: https://github.com/llvm/llvm-project/commit/e289ee99cec4607243aeaa01504f6b3cf65b65fe DIFF: https://github.com/llvm/llvm-project/commit/e289ee99cec4607243aeaa01504f6b3cf65b65fe.diff

[PATCH] D155705: [clang] Fix specialization of non-templated member classes of class templates

shafik added a comment. Thank you for the fix! Can you explain why the fix fixes the bug? It is not a lot of change but I am not familiar enough to see what the underlying issue actually is. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] eddc485 - [Driver][test] Add -no-canonical-prefixes after D154357

Author: Fangrui Song Date: 2023-07-19T14:39:52-07:00 New Revision: eddc4850d81f4c9f79d0b17869d67eac8ca88070 URL: https://github.com/llvm/llvm-project/commit/eddc4850d81f4c9f79d0b17869d67eac8ca88070 DIFF: https://github.com/llvm/llvm-project/commit/eddc4850d81f4c9f79d0b17869d67eac8ca88070.diff

[PATCH] D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS

DiggerLin marked 10 inline comments as done. DiggerLin added inline comments. Comment at: llvm/tools/llvm-ar/llvm-ar.cpp:1394 object::Archive::K_AIXBIG) { Match = *(*ArgIt + 2) != '\0' ? *ArgIt + 2 : *(++ArgIt); BitMode = getBitMode(Match);

[PATCH] D155385: [clangd] enable unused-include warnings for standard library headers

sammccall marked an inline comment as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:75-77 +if (tooling::stdlib::Header::named(Inc.Written)) return true; return false; kadircet wrote: > believe it

[PATCH] D150226: [Clang] Remove ability to downgrade warning on the diagnostic for setting a non fixed enum to a value outside the range of the enumeration values

dblaikie added a comment. In D150226#4515843 , @aaron.ballman wrote: > In D150226#4515783 , @dblaikie > wrote: > >> In D150226#4498024 , >> @aaron.ballman wrote: >>

[PATCH] D155729: [OptTable] Make explicitly included options override excluded ones

bogner added inline comments. Comment at: clang/include/clang/Driver/Options.h:40 + Ignored = (1 << 18), + TargetSpecific = (1 << 19), }; bob80905 wrote: > Given that the id for these flags have changed, does it make sense to write a > test that makes sure

[PATCH] D155641: [-Wunsafe-buffer-usage] Do not assert that function parameters have names.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. ziqingluo-90 marked an inline comment as done. Closed by commit rG4b5f17e008c6: [-Wunsafe-buffer-usage] Do not assert that function parameters have names (authored by

[clang] 4b5f17e - [-Wunsafe-buffer-usage] Do not assert that function parameters have names

Author: Ziqing Luo Date: 2023-07-19T14:14:28-07:00 New Revision: 4b5f17e008c684998a5ee10454d34714736eb6c5 URL: https://github.com/llvm/llvm-project/commit/4b5f17e008c684998a5ee10454d34714736eb6c5 DIFF: https://github.com/llvm/llvm-project/commit/4b5f17e008c684998a5ee10454d34714736eb6c5.diff

[PATCH] D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS

DiggerLin marked 14 inline comments as done. DiggerLin added a comment. In D142660#4509464 , @jhenderson wrote: > I still have concerns about the option-parsing logic being duplicated, but > I'm out of time to review it now. I'll try to look tomorrow.

[PATCH] D86310: [X86] Align i128 to 16 bytes in x86 datalayouts

tmgross added a comment. Here's confirmation that `_BitInt(128)` should be 8-byte aligned and not 16 (so, different from `__int128`) from https://gitlab.com/x86-psABIs/x86-64-ABI: > • For N > 64, they are treated as struct of 64-bit integer chunks. The number > of > chunks is the smallest

[PATCH] D86310: [X86] Align i128 to 16 bytes in x86 datalayouts

hvdijk added a comment. In D86310#4516184 , @tmgross wrote: > Is the compatibility note here only meant to address calls between LLVM and > GCC, not generated code? Because of course, struct layout and pass-in-memory > function calls are incompatible.

[PATCH] D154130: [lit] Avoid os.path.realpath on Windows due to MAX_PATH limitations

tahonermann added a comment. It is unclear to me why/when we would ever want the substitute drive expansion; the modified tests aren't very elucidating. My naive expectation is that we effectively want to restore the Python 3.7 behavior. Comment at:

[clang-tools-extra] 2870303 - [clang-tidy][NFC] Fixes in release notes

Author: Piotr Zegar Date: 2023-07-19T20:45:17Z New Revision: 287030384c90d705fbdb2112cfaf39d1497d23f5 URL: https://github.com/llvm/llvm-project/commit/287030384c90d705fbdb2112cfaf39d1497d23f5 DIFF: https://github.com/llvm/llvm-project/commit/287030384c90d705fbdb2112cfaf39d1497d23f5.diff LOG:

[PATCH] D86310: [X86] Align i128 to 16 bytes in x86 datalayouts

tmgross added a comment. In D86310#4504168 , @hvdijk wrote: > THE CURRENT STATE > [...] > Compatibility between LLVM and GCC > > For x86, the current i128 handling is compatible. The alignment to 8 byte > boundaries causes no compatibility issues because

[PATCH] D155342: [clang][JumpDiagnostics] ignore non-asm goto target scopes

nathanchance added a comment. Thanks, I can confirm that the `__attribute__((__cleanup__(...)))` errors that we observed with Peter's work-in-progress guards series are resolved and that all the errors I observed when building the kernel after https://reviews.llvm.org/D154696 was merged are no

[PATCH] D155667: [-Wunsafe-buffer-usage] Check source location validity before using `TypeLoc`s

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155667/new/ https://reviews.llvm.org/D155667 ___

[PATCH] D153914: [clang-cl] Enable concatenation of predefined identifiers

tahonermann added inline comments. Comment at: clang/include/clang/Basic/TokenKinds.h:87-93 +/// Return true if this token is a predefined macro +/// unexpandable by MSVC preprocessor. +inline bool isUnexpandableMsMacro(TokenKind K) { + return K == tok::kw___FUNCTION__ || K ==

[PATCH] D153092: [Clang][CodeGen]`vtable`, `typeinfo` et al. are globals

AlexVlx added inline comments. Comment at: clang/lib/CodeGen/CGVTables.cpp:836 +fnPtr = +llvm::ConstantExpr::getAddrSpaceCast(fnPtr, CGM.GlobalsInt8PtrTy); + return builder.add(fnPtr); efriedma wrote: > If I follow correctly, the fnPtr

[PATCH] D154869: [Flang] [FlangRT] Implement FlangRT library as solution to Flang's runtime LLVM integration

efriedma added inline comments. Comment at: flang/runtime/CMakeLists.txt:251 - INSTALL_WITH_TOOLCHAIN -) +if (DEFINED LLVM_ENABLE_RUNTIMES AND "flang-rt" IN_LIST LLVM_ENABLE_RUNTIMES) + add_flang_library(FortranRuntime STATIC pscoro wrote: > efriedma wrote:

[PATCH] D151834: Include math-errno with fast-math

zahiraam added a comment. Review anyone please? Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151834/new/ https://reviews.llvm.org/D151834 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D147283: [Sema] Search template parameter scopes before searching namespace/file scopes when performing unqualified name lookup

ahatanak updated this revision to Diff 542165. ahatanak added a comment. Remove unneeded code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147283/new/ https://reviews.llvm.org/D147283 Files: clang/lib/Sema/SemaLookup.cpp

[PATCH] D147283: [Sema] Search template parameter scopes before searching namespace/file scopes when performing unqualified name lookup

ahatanak added inline comments. Comment at: clang/lib/Sema/SemaLookup.cpp:1403 + // Find the innermost file scope, so we can add using directives + // from local scopes. + InnermostFileScope = S; This isn't needed as

[PATCH] D153092: [Clang][CodeGen]`vtable`, `typeinfo` et al. are globals

efriedma added inline comments. Comment at: clang/lib/CodeGen/CGVTables.cpp:836 +fnPtr = +llvm::ConstantExpr::getAddrSpaceCast(fnPtr, CGM.GlobalsInt8PtrTy); + return builder.add(fnPtr); If I follow correctly, the fnPtr is guaranteed to

[PATCH] D147283: [Sema] Search template parameter scopes before searching namespace/file scopes when performing unqualified name lookup

ahatanak added inline comments. Comment at: clang/lib/Sema/SemaLookup.cpp:1392 - if (!VisitedUsingDirectives) { -// Add using directives from this context up to the top level. -for (DeclContext *UCtx = Ctx; UCtx; UCtx = UCtx->getParent()) {

[PATCH] D144164: [clang][Interp] Handle PtrMemOps

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:234 + if (!LT || !RT || !T) +return this->bail(BO); Should we be checking `!T` earlier (it's used within the `Discard` lambda with an unprotected dereference)?

[PATCH] D144164: [clang][Interp] Handle PtrMemOps

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:213-214 + if (BO->isPtrMemOp()) +return this->visit(RHS); + Do we need similar changes for unary operators, pointer arithmetic operators, etc?

[PATCH] D151587: [clang][ConstantEmitter] have tryEmitPrivate[ForVarInit] try ConstExprEmitter fast-path first

efriedma added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:8360 + // Do not constant fold an R-value. + if (Info.EvalMode == EvalInfo::EM_ConstantFold && !E->isLValue()) +return false; efriedma wrote: > nickdesaulniers wrote: > > efriedma

[PATCH] D147283: [Sema] Search template parameter scopes before searching namespace/file scopes when performing unqualified name lookup

ahatanak updated this revision to Diff 542150. ahatanak added a comment. - Defer collecting using directives until lookup into local scopes is done. - Simplify the second loop. - Add more comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D155387: [Clang] Fix member lookup so that we don't ignore ambiguous lookups in some cases

shafik added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:15191 OverloadCandidateSet::iterator Best; switch (CandidateSet.BestViableFunction(*this, OpLoc, Best)) { case OR_Success: @rsmith if `R.isAmbiguous()` should we even check the

[PATCH] D151587: [clang][ConstantEmitter] have tryEmitPrivate[ForVarInit] try ConstExprEmitter fast-path first

efriedma added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:8360 + // Do not constant fold an R-value. + if (Info.EvalMode == EvalInfo::EM_ConstantFold && !E->isLValue()) +return false; nickdesaulniers wrote: > efriedma wrote: > >

[PATCH] D155239: [clang-format] Add SpacesInParens with SpacesInParensOptions

HazardyKnusperkeks requested changes to this revision. HazardyKnusperkeks added a comment. This revision now requires changes to proceed. D155529#inline-1505573 But what does `clang-format` without this patch format? I just want to make sure,

[PATCH] D151834: Include math-errno with fast-math

zahiraam added inline comments. Comment at: clang/test/CodeGen/math-errno.c:28 +// FAST-LABEL: define dso_local nofpclass(nan inf) float @f1 +// FAST: call fast nofpclass(nan inf) float @sqrtf(float noundef nofpclass(nan inf) {{.*}}) #[[ATTR3_FAST:[0-9]+]] +//

[PATCH] D151834: Include math-errno with fast-math

zahiraam updated this revision to Diff 542141. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151834/new/ https://reviews.llvm.org/D151834 Files: clang/include/clang/Basic/FPOptions.def clang/include/clang/Basic/LangOptions.h clang/lib/CodeGen/CGBuiltin.cpp

[PATCH] D150226: [Clang] Remove ability to downgrade warning on the diagnostic for setting a non fixed enum to a value outside the range of the enumeration values

aaron.ballman added a comment. In D150226#4515783 , @dblaikie wrote: > In D150226#4498024 , @aaron.ballman > wrote: > >> In D150226#4461846 , @efriedma >> wrote: >> >>>

[PATCH] D155714: [clang] Fix diagnostics for defaulted, implicitly deleted 'operator=='.

AMP999 updated this revision to Diff 542136. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155714/new/ https://reviews.llvm.org/D155714 Files: clang/lib/Sema/SemaDeclCXX.cpp clang/test/CXX/class/class.compare/class.compare.default/p1.cpp

[PATCH] D151587: [clang][ConstantEmitter] have tryEmitPrivate[ForVarInit] try ConstExprEmitter fast-path first

nickdesaulniers added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:8360 + // Do not constant fold an R-value. + if (Info.EvalMode == EvalInfo::EM_ConstantFold && !E->isLValue()) +return false; efriedma wrote: > nickdesaulniers wrote: > >

  1   2   3   >