[PATCH] D154471: [clang] Add serialization support for the DynamicAllocLValue variant of APValue::LValueBase::Ptr

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2e7d711a1061: [clang] Add serialization support for the DynamicAllocLValue variant of APValue… (authored by nridge). Repository: rG LLVM Github

[clang] 2e7d711 - [clang] Add serialization support for the DynamicAllocLValue variant of APValue::LValueBase::Ptr

Author: Nathan Ridge Date: 2023-07-21T23:16:51-04:00 New Revision: 2e7d711a106170185e9bbbf15115613d9a5854c5 URL: https://github.com/llvm/llvm-project/commit/2e7d711a106170185e9bbbf15115613d9a5854c5 DIFF: https://github.com/llvm/llvm-project/commit/2e7d711a106170185e9bbbf15115613d9a5854c5.diff

[PATCH] D155539: [CUDA][HIP] Use the same default language std as C++

yaxunl added a comment. In D155539#4524189 , @probinson wrote: > This change to lang-std.cpp causes it not to verify _which_ language standard > is the default. It only verifies that cuda and hip don't _change_ it. > If you run FileCheck on one of those

[PATCH] D154923: [CodeGen] Support bitcode input containing multiple modules

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb2f7b5dbaefe: [CodeGen] Support bitcode input containing multiple modules (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES

[clang] b2f7b5d - [CodeGen] Support bitcode input containing multiple modules

Author: Fangrui Song Date: 2023-07-21T20:05:35-07:00 New Revision: b2f7b5dbaefe4f2e3f8f279735ea3509a796693f URL: https://github.com/llvm/llvm-project/commit/b2f7b5dbaefe4f2e3f8f279735ea3509a796693f DIFF: https://github.com/llvm/llvm-project/commit/b2f7b5dbaefe4f2e3f8f279735ea3509a796693f.diff

[PATCH] D156014: [Clang][NVPTX] Permit use of the alias attribute for NVPTX targets

jhuber6 added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:1995 } - if (S.Context.getTargetInfo().getTriple().isNVPTX()) { -S.Diag(AL.getLoc(), diag::err_alias_not_supported_on_nvptx); tra wrote: > tra wrote: > > Allowing or not

[PATCH] D155857: [clang] fix nonnull warnings during build

MaskRay added inline comments. Comment at: llvm/cmake/modules/HandleLLVMOptions.cmake:773 + # Disabling this GCC warning as it is emitting a lot of false positives + append_if(CMAKE_COMPILER_IS_GNUCXX "-Wno-nonnull" CMAKE_CXX_FLAGS) Use an imperative

[PATCH] D156014: [Clang][NVPTX] Permit use of the alias attribute for NVPTX targets

tra added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:1995 } - if (S.Context.getTargetInfo().getTriple().isNVPTX()) { -S.Diag(AL.getLoc(), diag::err_alias_not_supported_on_nvptx); tra wrote: > Allowing or not `noreturn` depends on the

[PATCH] D156014: [Clang][NVPTX] Permit use of the alias attribute for NVPTX targets

tra added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:1995 } - if (S.Context.getTargetInfo().getTriple().isNVPTX()) { -S.Diag(AL.getLoc(), diag::err_alias_not_supported_on_nvptx); Allowing or not `noreturn` depends on the CUDA version

[PATCH] D151761: clang-format: Add AlignConsecutiveShortCaseStatements

galenelias added a comment. In D151761#4483050 , @HazardyKnusperkeks wrote: > Thanks for the patience, I'm really looking forward to use this. > > But please wait for other opinions. Thanks so much @HazardyKnusperkeks for all the feedback and help.

[PATCH] D156014: [Clang][NVPTX] Permit use of the alias attribute for NVPTX targets

jhuber6 created this revision. jhuber6 added reviewers: tra, arsenm, jlebar, kushanam, aaron.ballman, yaxunl, jdoerfert. Herald added subscribers: mattd, gchakrabarti, asavonic, jeroen.dobbelaere. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers:

[PATCH] D155982: Partially revert "clang/HIP: Remove __llvm_amdgcn_* wrapper hacks"

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155982/new/ https://reviews.llvm.org/D155982 ___ cfe-commits mailing list

[PATCH] D154658: Optimize emission of `dynamic_cast` to final classes.

This revision was automatically updated to reflect the committed changes. Closed by commit rG9d525bf94b25: Optimize emission of `dynamic_cast` to final classes. (authored by rsmith). Changed prior to commit: https://reviews.llvm.org/D154658?vs=542693=543133#toc Repository: rG LLVM Github

[clang] 9d525bf - Optimize emission of `dynamic_cast` to final classes.

Author: Richard Smith Date: 2023-07-21T19:07:59-07:00 New Revision: 9d525bf94b255df89587db955b5fa2d3c03c2c3e URL: https://github.com/llvm/llvm-project/commit/9d525bf94b255df89587db955b5fa2d3c03c2c3e DIFF: https://github.com/llvm/llvm-project/commit/9d525bf94b255df89587db955b5fa2d3c03c2c3e.diff

[clang] aa34b34 - Set default C++ level for PlayStation(r) to C++17.

Author: Sunil Srivastava Date: 2023-07-21T18:18:21-07:00 New Revision: aa34b34e93d444efec6cd894e5e55927d0e413e6 URL: https://github.com/llvm/llvm-project/commit/aa34b34e93d444efec6cd894e5e55927d0e413e6 DIFF:

[PATCH] D138263: [clang-format] Supress aligning of trailing namespace comments

owenpan accepted this revision. owenpan added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2976-2977 +FormatToken *LBrace = FormatTok; +LBrace->setFinalizedType(TT_NamespaceLBrace); +

[PATCH] D154324: [C++20] [Modules] [ODRHash] Use CanonicalType for base classes

rsmith added a comment. In D154324#4524235 , @v.g.vassilev wrote: > @rsmith, thanks for the suggestions! Could you go over > `ODRHash::AddTemplateName` suggest how to fix it to address > https://reviews.llvm.org/D153003 and

[PATCH] D155671: [include-cleaner] allow spelling strategies to customize verbatim/system headers

This revision was automatically updated to reflect the committed changes. Closed by commit rGab4e461353bb: [include-cleaner] allow spelling strategies to customize verbatim/system headers (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] ab4e461 - [include-cleaner] allow spelling strategies to customize verbatim/system headers

Author: Sam McCall Date: 2023-07-22T02:36:29+02:00 New Revision: ab4e461353bb16e538aca260121533fec7e0678c URL: https://github.com/llvm/llvm-project/commit/ab4e461353bb16e538aca260121533fec7e0678c DIFF: https://github.com/llvm/llvm-project/commit/ab4e461353bb16e538aca260121533fec7e0678c.diff

[PATCH] D154324: [C++20] [Modules] [ODRHash] Use CanonicalType for base classes

alexfh added a comment. In D154324#4522552 , @Hahnfeld wrote: > In D154324#4522551 , @alexfh wrote: > >> BTW, if in a.h I change >> >> typename std::enable_if<::p::P::value>::type> >> >> to >> >> typename

[PATCH] D155540: [clangd] Remove extra dependancies for clangd

MaskRay added a comment. In D155540#4524326 , @sammccall wrote: > In D155540#4524219 , @MaskRay wrote: > >> `llvm/cmake/modules/HandleLLVMOptions.cmake` passes `-Wl,-z,defs`. >> `-DBUILD_SHARED_LIBS=on` builds

[PATCH] D155540: [clangd] Remove extra dependancies for clangd

sammccall added a comment. In D155540#4524219 , @MaskRay wrote: > `llvm/cmake/modules/HandleLLVMOptions.cmake` passes `-Wl,-z,defs`. > `-DBUILD_SHARED_LIBS=on` builds get checking from the linker option >

[PATCH] D154923: [CodeGen] Support bitcode input containing multiple modules

ormris accepted this revision. ormris added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154923/new/ https://reviews.llvm.org/D154923

[PATCH] D154130: [lit][clang] Avoid realpath on Windows due to MAX_PATH limitations

MrTrillian marked an inline comment as done. MrTrillian added inline comments. Comment at: clang/test/Lexer/case-insensitive-include-win.c:5-9 +// Note: We must use the real path here, because the logic to detect case +// mismatch relies on resolving the real path and checking

[PATCH] D155921: [clang][dataflow] Reverse course on `getValue()` deprecation.

xazax.hun accepted this revision. xazax.hun added a comment. Sounds good to me. I believe this make check author's lives easier. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155921/new/ https://reviews.llvm.org/D155921

[PATCH] D155847: [analyzer] Fix crash in GenericTaintChecker when propagatig taint to AllocaRegion

xazax.hun accepted this revision. xazax.hun added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155847/new/ https://reviews.llvm.org/D155847 ___ cfe-commits mailing list

[PATCH] D105049: [NFC] Remove extra semicolons in clang/lib/APINotes/APINotesFormat.h

This revision was automatically updated to reflect the committed changes. Closed by commit rGe4ad1f976d12: [NFC] Remove extra semicolons in clang/lib/APINotes/APINotesFormat.h (authored by etcwilde). Herald added a project: All. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] e4ad1f9 - [NFC] Remove extra semicolons in clang/lib/APINotes/APINotesFormat.h

Author: Evan Wilde Date: 2023-07-21T16:19:53-07:00 New Revision: e4ad1f976d1209b8ff233e6aab924f92b7484c2d URL: https://github.com/llvm/llvm-project/commit/e4ad1f976d1209b8ff233e6aab924f92b7484c2d DIFF: https://github.com/llvm/llvm-project/commit/e4ad1f976d1209b8ff233e6aab924f92b7484c2d.diff

[PATCH] D155446: [clang][dataflow] Eliminate duplication between `AggregateStorageLocation` and `StructValue`.

xazax.hun accepted this revision. xazax.hun added a comment. I did not do a thorough review checking every line, but I read the design paper and skimmed through this patch. Love the direction, and I am OK with landing this as is. Comment at:

[PATCH] D155982: Partially revert "clang/HIP: Remove __llvm_amdgcn_* wrapper hacks"

arsenm updated this revision to Diff 543111. arsenm marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155982/new/ https://reviews.llvm.org/D155982 Files: clang/lib/Headers/__clang_hip_libdevice_declares.h

[PATCH] D153914: [clang-cl] Enable concatenation of predefined identifiers

RIscRIpt added a comment. Thanks to your suggestion of testing different types, I realized clang does not support MSVC macros with `u`, `u8`, and `U` prefixes in addition to `L__FUNCDNAME`. By the way, clang replicates MSVC behavior a little bit incorrectly: `L__FUNCTION__` is not a valid

[PATCH] D153914: [clang-cl] Enable concatenation of predefined identifiers

RIscRIpt updated this revision to Diff 543109. RIscRIpt marked 5 inline comments as done. RIscRIpt added a comment. Address review comments, rebase onto main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153914/new/

[PATCH] D154324: [C++20] [Modules] [ODRHash] Use CanonicalType for base classes

v.g.vassilev added a comment. @rsmith, thanks for the suggestions! Could you go over `ODRHash::AddTemplateName` suggest how to fix it to address https://reviews.llvm.org/D153003 and https://reviews.llvm.org/D41416#4496451? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D155540: [clangd] Remove extra dependancies for clangd

MaskRay added a comment. `llvm/cmake/modules/HandleLLVMOptions.cmake` passes `-Wl,-z,defs`. `-DBUILD_SHARED_LIBS=on` builds get checking from the linker option (https://maskray.me/blog/2021-06-13-dependency-related-linker-options#z-defs). This is similar Bazel's layering_check. For a

[clang] 17f4f26 - Revert "Reapply [IR] Mark and constant expressions as undesirable"

Author: Nathan Chancellor Date: 2023-07-21T15:57:03-07:00 New Revision: 17f4f262fc5c4361cf43e91f2137ff7b2dcadc62 URL: https://github.com/llvm/llvm-project/commit/17f4f262fc5c4361cf43e91f2137ff7b2dcadc62 DIFF:

[PATCH] D155694: [NFC][analyzer] Enable implicit destructor for cfg-lifetime tests

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang/test/Analysis/lifetime-cfg-output.cpp:6 +// that has non-trivial destructor. As the behavior for such types is different +// from ones with

[PATCH] D156000: Track the RequestingModule in the HeaderSearch LookupFile cache.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7c5e4efb099e: Track the RequestingModule in the HeaderSearch LookupFile cache. (authored by rsmith). Repository: rG LLVM Github Monorepo CHANGES

[clang] 7c5e4ef - Track the RequestingModule in the HeaderSearch LookupFile cache.

Author: Richard Smith Date: 2023-07-21T15:49:47-07:00 New Revision: 7c5e4efb099e0badb4912467b7286938a4ed5011 URL: https://github.com/llvm/llvm-project/commit/7c5e4efb099e0badb4912467b7286938a4ed5011 DIFF: https://github.com/llvm/llvm-project/commit/7c5e4efb099e0badb4912467b7286938a4ed5011.diff

[PATCH] D155539: [CUDA][HIP] Use the same default language std as C++

probinson added a comment. This change to lang-std.cpp causes it not to verify _which_ language standard is the default. It only verifies that cuda and hip don't _change_ it. If you run FileCheck on one of those output files, it would preserve that property. Repository: rG LLVM Github

[PATCH] D155540: [clangd] Remove extra dependancies for clangd

saghir added a comment. Thank you for the review and your comments @sammccall and @mstorsjo. As I understand there is no strong opinion here either way. I think we can leave things as they are for now. I am going to abandon this patch. If someone else feels strongly about removing them, they

[PATCH] D153701: [WIP][Clang] Implement P2718R0 "Lifetime extension in range-based for loops"

rsmith added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:8901-8914 + // [P2718R0] Lifetime extension in range-based for loops. + // + // 6.7.7 [class.temporary] p5: + // There are four contexts in which temporaries are destroyed at a different + // point

[PATCH] D154324: [C++20] [Modules] [ODRHash] Use CanonicalType for base classes

rsmith added a comment. I've done a pass through this file looking for places where we incorrectly add to the ODR hash a type that was written within some other entity than the one that we're ODR hashing, that could validly be spelled differently in different declarations of that other entity.

[PATCH] D76096: [clang] allow const structs/unions/arrays to be constant expressions for C

efriedma added a comment. > Is the idea for the way forward here to ensure (i.e. adding code such) that > ConstExprEmitter can constant evaluate such Expr's? For that exact construct, EvaluateAsRValue will also fail, so there's no real regression. The issue would be for a constant global

[PATCH] D156004: s/ #include / #include "llvm/ADT/SmallVector.h" /

lukasza added a comment. https://llvm.org/docs/MyFirstTypoFix.html#updating-your-change told me to run `arc diff`... not sure if I should abandon the original revision and reupload a cleaned-up fix instead? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D76096: [clang] allow const structs/unions/arrays to be constant expressions for C

efriedma added a comment. Hmm, that kind of construct could run into issues with large global variables. If we "inline" a bunch of large global constants into initializers for arrays, we could significantly increase codesize. Not sure how likely that is in practice. We could maybe consider

[PATCH] D156004: s/ #include / #include "llvm/ADT/SmallVector.h" /

lukasza created this revision. Herald added a project: All. lukasza requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D156004 Files: clang/lib/Sema/SemaDeclCXX.cpp Index:

[PATCH] D156000: Track the RequestingModule in the HeaderSearch LookupFile cache.

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM, thanks for the quick turnaround! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156000/new/ https://reviews.llvm.org/D156000

[PATCH] D155895: Anonymous unions should be transparent wrt `[[clang::trivial_abi]]`.

lukasza marked 5 inline comments as done. lukasza added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:10325 - for (const auto *FD : RD.fields()) { -// Ill-formed if the field is an ObjectiveC pointer or of a type that is -// non-trivial for the purpose

[PATCH] D76096: [clang] allow const structs/unions/arrays to be constant expressions for C

nickdesaulniers added a comment. In D76096#4524092 , @nickdesaulniers wrote: > In D76096#4524003 , @efriedma wrote: > >> The ones most likely to be a concern are InitListExpr and StringLiteral. > > Here's a

[PATCH] D156003: Anonymous unions should be transparent wrt `[[clang::trivial_abi]]`.

lukasza created this revision. Herald added a project: All. lukasza requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Consider the test input below: struct [[clang::trivial_abi]] Trivial { Trivial() {} Trivial(Trivial&& other) {}

[PATCH] D155982: Partially revert "clang/HIP: Remove __llvm_amdgcn_* wrapper hacks"

yaxunl added inline comments. Comment at: clang/lib/Headers/__clang_hip_libdevice_declares.h:13-15 +#if __has_include("hip/hip_version.h") +#include "hip/hip_version.h" +#endif // __has_include("hip/hip_version.h") pls condition this with ``` #if

[PATCH] D155998: Set default C++ level for PlayStation(r) to C++17.

probinson accepted this revision. probinson added a comment. This revision is now accepted and ready to land. Huh. It looks like someone else removed that stuff from lang-std.cpp recently. I'd have thought that would cause a failure on our bot, but whatever. LGTM. CHANGES SINCE LAST ACTION

[PATCH] D76096: [clang] allow const structs/unions/arrays to be constant expressions for C

nickdesaulniers added a comment. In D76096#4524003 , @efriedma wrote: > The ones most likely to be a concern are InitListExpr and StringLiteral. Here's a reduced instance from the Linux kernel: struct timespec64 { long tv_sec; long tv_nsec;

[PATCH] D155396: [Sema][ObjC] Invalidate BlockDecl with invalid return expr & its parent BlockExpr

rjmccall added a comment. Dropping the entire block from the AST on error would be unfortunate for some kinds of tooling, but as long as we maintain it with a `RecoveryExpr`, that seems like a fine approach to me. As a general rule, I think we should be tracking basically everything on the

[PATCH] D154658: Optimize emission of `dynamic_cast` to final classes.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks, LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154658/new/ https://reviews.llvm.org/D154658

[PATCH] D146242: [ARM] Fixing ABI mismatch for packed structs passed as function arguments

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Okay, LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146242/new/ https://reviews.llvm.org/D146242

[PATCH] D155998: Set default C++ level for PlayStation(r) to C++17.

Sunil_Srivastava updated this revision to Diff 543088. Sunil_Srivastava added a comment. Deleted Sie specific test, now that the behavior is same as the default. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155998/new/ https://reviews.llvm.org/D155998 Files:

[PATCH] D154503: [Sema] Fix handling of functions that hide classes

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thank you, this looks great, and I really appreciate that you found a way to make it work with just the single loop (in the typical case). CHANGES SINCE LAST ACTION

[PATCH] D155387: [Clang] Fix member lookup so that we don't ignore ambiguous lookups in some cases

rsmith added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:15191 OverloadCandidateSet::iterator Best; switch (CandidateSet.BestViableFunction(*this, OpLoc, Best)) { case OR_Success: shafik wrote: > @rsmith if `R.isAmbiguous()` should we

[PATCH] D156000: Track the RequestingModule in the HeaderSearch LookupFile cache.

rsmith created this revision. rsmith added a reviewer: jansvoboda11. Herald added a project: All. rsmith requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Different requesting modules can have different lookup results, so don't cache results

[PATCH] D155998: Set default C++ level for PlayStation(r) to C++17.

probinson added a comment. (Also remove the now-incorrect comment from lang-std.cpp) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155998/new/ https://reviews.llvm.org/D155998 ___ cfe-commits mailing

[PATCH] D154923: [CodeGen] Support bitcode input containing multiple modules

MaskRay updated this revision to Diff 543084. MaskRay added a comment. rename a variable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154923/new/ https://reviews.llvm.org/D154923 Files: clang/lib/CodeGen/CodeGenAction.cpp

[PATCH] D154923: [CodeGen] Support bitcode input containing multiple modules

MaskRay updated this revision to Diff 543083. MaskRay edited the summary of this revision. MaskRay added a comment. rename a variable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154923/new/ https://reviews.llvm.org/D154923 Files:

[PATCH] D76096: [clang] allow const structs/unions/arrays to be constant expressions for C

efriedma added a comment. The ones most likely to be a concern are InitListExpr and StringLiteral. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76096/new/ https://reviews.llvm.org/D76096 ___

[PATCH] D155998: Set default C++ level for Playstation(r) to C++17.

probinson added a comment. The value of a separate test for PS4/PS5 is questionable, now that it's the same as the general Clang default. Probably better to delete `lang-std-sie.cpp` and remove the UNSUPPORTED from `lang-std.cpp` ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D76096: [clang] allow const structs/unions/arrays to be constant expressions for C

nickdesaulniers added a comment. In D76096#4523828 , @efriedma wrote: > The idea would be looking for places we EvaluateAsRValue an array or struct. > Not sure what that stack trace represents. Perhaps you mean calling `EvaluateAsRValue` with a

[PATCH] D155211: [NVPTX] Add initial support for '.alias' in PTX

This revision was automatically updated to reflect the committed changes. Closed by commit rGf4381d464457: [NVPTX] Add initial support for .alias in PTX (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155211/new/

[PATCH] D154923: [CodeGen] Support bitcode input containing multiple modules

ormris added a comment. This is a good way to resolve the inconsistencies I was looking at in my own review. > I think whether a bitcode input file contains 2 modules (internal > implementation strategy) should not be a criterion to require an additional > driver option Agreed. Most users

[PATCH] D155544: [AIX][TLS] Add -maix-small-local-exec-tls option.

hubert.reinterpretcast added a comment. In D155544#4523857 , @amyk wrote: > Wouldn't this patch need to land before the back-end patch, because I > introduce the option here, and then I use it in the backend patch? Please move the `llvm/` changes into

[PATCH] D153946: [clangd] Add a flag to allow indexing of reserved identifiers

nridge abandoned this revision. nridge added a comment. Abandoning in favour of D155381 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153946/new/ https://reviews.llvm.org/D153946

[PATCH] D155859: [Headers][doc] Add misc non-AVX2 intrinsic descriptions

probinson added inline comments. Comment at: clang/lib/Headers/rdseedintrin.h:56 +/// ELSE +/// Store16(__p, 0) +/// result := 0 pengfei wrote: > 32 Oops. Fixed. Comment at: clang/lib/Headers/rdseedintrin.h:84 +/// ELSE +/// Store16(__p,

[PATCH] D155859: [Headers][doc] Add misc non-AVX2 intrinsic descriptions

probinson updated this revision to Diff 543075. probinson marked 4 inline comments as done. probinson added a comment. Address review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155859/new/ https://reviews.llvm.org/D155859 Files: clang/lib/Headers/adxintrin.h

[PATCH] D154130: [lit][clang] Avoid realpath on Windows due to MAX_PATH limitations

tahonermann added inline comments. Comment at: clang/test/Lexer/case-insensitive-include-win.c:5-9 +// Note: We must use the real path here, because the logic to detect case +// mismatch relies on resolving the real path and checking that casing differs. +// If we use %t and we

[PATCH] D155998: Set default C++ level for Playstation to C++17.

Sunil_Srivastava created this revision. Herald added a project: All. Sunil_Srivastava requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D155998 Files:

[PATCH] D155997: [Phase Ordering] Don't speculate in SimplifyCFG before PGO annotation

tejohnson created this revision. tejohnson added reviewers: aeubanks, nikic. Herald added subscribers: khei4, wlei, StephenFan, wenlei, hiraditya. Herald added a project: All. tejohnson requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: cfe-commits.

[PATCH] D155955: [Clang] Improve the handling of large arrays evaluation.

shafik added a comment. Did you evaluate trying to use `StepsLeft` at all to limit the allocation? Should the limit be setable via the command line like what we do with steps via `-fconstexpr-steps`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D155381: [clangd] Allow indexing of __reserved_names outside system headers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG290a98c7b008: [clangd] Allow indexing of __reserved_names outside system headers (authored by sammccall). Changed prior to commit:

[clang-tools-extra] 290a98c - [clangd] Allow indexing of __reserved_names outside system headers

Author: Sam McCall Date: 2023-07-21T23:30:31+02:00 New Revision: 290a98c7b00899b6aba0fc892e8f29fecc00a82e URL: https://github.com/llvm/llvm-project/commit/290a98c7b00899b6aba0fc892e8f29fecc00a82e DIFF: https://github.com/llvm/llvm-project/commit/290a98c7b00899b6aba0fc892e8f29fecc00a82e.diff

[PATCH] D155861: [Headers][doc] Add SHA1/SHA256 intrinsic descriptions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG775d6df6a5f2: [Headers][doc] Add SHA1/SHA256 intrinsic descriptions (authored by probinson). Herald added a project: clang. Changed prior to

[clang] 775d6df - [Headers][doc] Add SHA1/SHA256 intrinsic descriptions

Author: Paul Robinson Date: 2023-07-21T14:26:47-07:00 New Revision: 775d6df6a5f2fbe8d4ad6174badc2ef553ada6e3 URL: https://github.com/llvm/llvm-project/commit/775d6df6a5f2fbe8d4ad6174badc2ef553ada6e3 DIFF: https://github.com/llvm/llvm-project/commit/775d6df6a5f2fbe8d4ad6174badc2ef553ada6e3.diff

[PATCH] D153914: [clang-cl] Enable concatenation of predefined identifiers

tahonermann requested changes to this revision. tahonermann added a comment. This revision now requires changes to proceed. I think this is looking good. The only big thing I noticed is some code that looks like it should have been removed with the last set of changes. Otherwise, just some

[PATCH] D153946: [clangd] Add a flag to allow indexing of reserved identifiers

sammccall added a comment. In D153946#4521576 , @nridge wrote: > Yeah, I'm happy to go with D155381 instead. > > In D153946#4503585 , @sammccall > wrote: > >> (Stupid

[PATCH] D155544: [AIX][TLS] Add -maix-small-local-exec-tls option.

amyk added a comment. In D155544#4523536 , @hubert.reinterpretcast wrote: > Patch should not land before back-end patch. I also suggest having the patch > incorporate the new option into the Clang release notes before it lands. I'm currently

[PATCH] D76096: [clang] allow const structs/unions/arrays to be constant expressions for C

efriedma added a comment. The idea would be looking for places we EvaluateAsRValue an array or struct. Not sure what that stack trace represents. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76096/new/ https://reviews.llvm.org/D76096

[PATCH] D132779: Enforce module decl-use restrictions and private header restrictions in textual headers

rsmith added a comment. In D132779#4523783 , @jansvoboda11 wrote: > Hi @rsmith, this commit makes it possible for `HeaderInfo::LookupFile()` to > be called with different `RequestingModule` within single `CompilerInstance`. > This is problematic,

[PATCH] D155898: [clangd] Fix go-to-type target location

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rGd9d9a2cb2f0d: [clangd] Use index for go-to-type (authored by sammccall). Changed prior to commit:

[clang-tools-extra] d9d9a2c - [clangd] Use index for go-to-type

Author: Sam McCall Date: 2023-07-21T23:10:33+02:00 New Revision: d9d9a2cb2f0db7a92eb7d5ef0c619fb41aa5c8a8 URL: https://github.com/llvm/llvm-project/commit/d9d9a2cb2f0db7a92eb7d5ef0c619fb41aa5c8a8 DIFF: https://github.com/llvm/llvm-project/commit/d9d9a2cb2f0db7a92eb7d5ef0c619fb41aa5c8a8.diff

[PATCH] D154324: [C++20] [Modules] [ODRHash] Use CanonicalType for base classes

rsmith added a comment. OK, I see. The problem is that the canonical version of the type can be spelled in different ways in different translation units, due to us treating some expressions as being equivalent despite them not being the same under the ODR. For example, we consider these

[PATCH] D155898: [clangd] Fix go-to-type target location

sammccall marked an inline comment as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:347 +void enhanceLocatedSymbolsFromIndex( +llvm::MutableArrayRef Result, +const llvm::DenseMap , usaxena95 wrote: > nit:

[PATCH] D76096: [clang] allow const structs/unions/arrays to be constant expressions for C

nickdesaulniers added a comment. In D76096#4523750 , @nickdesaulniers wrote: > In D76096#4523718 , @efriedma wrote: > >> My primary concern here is making sure we don't actually blow up >> compile-time. D151587

[clang-tools-extra] ee032bc - [clangd] Add BlockEnd comments for control flow statements

Author: Sam McCall Date: 2023-07-21T22:57:46+02:00 New Revision: ee032bccc934d034909962a9306f7c9d1ca72759 URL: https://github.com/llvm/llvm-project/commit/ee032bccc934d034909962a9306f7c9d1ca72759 DIFF: https://github.com/llvm/llvm-project/commit/ee032bccc934d034909962a9306f7c9d1ca72759.diff

[PATCH] D155421: [clangd] Add BlockEnd comments for control flow statements

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rGee032bccc934: [clangd] Add BlockEnd comments for control flow statements (authored by sammccall).

[PATCH] D132779: Enforce module decl-use restrictions and private header restrictions in textual headers

jansvoboda11 added a comment. Hi @rsmith, this commit makes it possible for `HeaderInfo::LookupFile()` to be called with different `RequestingModule` within single `CompilerInstance`. This is problematic, since some modules may see headers other modules can't (due to

[PATCH] D155992: [clangd] Use xxh3_64bits for background index file digests

MaskRay created this revision. MaskRay added reviewers: kadircet, sammccall. Herald added a subscriber: arphaman. Herald added a project: All. MaskRay requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. Herald added a project: clang-tools-extra. Many sources

[PATCH] D155421: [clangd] Add BlockEnd comments for control flow statements

sammccall marked 3 inline comments as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/InlayHints.cpp:252 +// This is used to summarize e.g. the condition of a while loop. +std::string summarizeExpr(const Expr *E) { + struct Namer : ConstStmtVisitor {

[PATCH] D155861: [Headers][doc] Add SHA1/SHA256 intrinsic descriptions

probinson added a comment. Thanks! The pre-merge check caught mistakes in the \param commands, which I fixed before pushing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155861/new/ https://reviews.llvm.org/D155861 ___ cfe-commits mailing

[PATCH] D76096: [clang] allow const structs/unions/arrays to be constant expressions for C

nickdesaulniers updated this revision to Diff 543051. nickdesaulniers added a comment. - use better identifiers in test - remove half baked comment from test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76096/new/ https://reviews.llvm.org/D76096

[PATCH] D155540: [clangd] Remove extra dependancies for clangd

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. I don't have a strong opinion here (or solid understanding of dynamic linking!) I suppose the idea is that clangdMain has dependencies from the source files in this directory, and the

[PATCH] D76096: [clang] allow const structs/unions/arrays to be constant expressions for C

nickdesaulniers added a comment. In D76096#4523718 , @efriedma wrote: > My primary concern here is making sure we don't actually blow up > compile-time. D151587 fixes the > dependency from CGExprConstant, which was

[PATCH] D76096: [clang] allow const structs/unions/arrays to be constant expressions for C

nickdesaulniers updated this revision to Diff 543048. nickdesaulniers retitled this revision from "[clang] allow const structs to be constant expressions for C" to "[clang] allow const structs/unions/arrays to be constant expressions for C". nickdesaulniers added a comment. - add moar tests for

  1   2   3   >