[PATCH] D155824: [LoongArch] Support -march=native and -mtune=

xen0n added a comment. In D155824#4530474 , @SixWeining wrote: > @xen0n Do you have any inputs? I think supporting these options can improve > compatibility with gcc (although there is no ScheduleModel difference among > currently supported

[PATCH] D155798: [X86] Support -march=graniterapids-d and update -march=graniterapids

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6d23a3faa4e6: [X86] Support -march=graniterapids-d and update -march=graniterapids (authored by FreddyYe). Repository: rG LLVM Github Monorepo

[PATCH] D155798: [X86] Support -march=graniterapids-d and update -march=graniterapids

FreddyYe updated this revision to Diff 543826. FreddyYe added a comment. rebase and fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155798/new/ https://reviews.llvm.org/D155798 Files: clang/docs/ReleaseNotes.rst

[PATCH] D156205: wasm: link crt1 even in case of -shared

yamt created this revision. Herald added subscribers: pmatos, asb, sunfish, jgravelle-google, sbc100, dschuff. Herald added a project: All. yamt requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, aheejin. Herald added a project: clang. This allows

[clang] 6cf8179 - Don't perform dynamic_cast optimization at -O0.

Author: Richard Smith Date: 2023-07-24T22:24:33-07:00 New Revision: 6cf8179661997f8d512cdf944f4f4c0c01cb37c1 URL: https://github.com/llvm/llvm-project/commit/6cf8179661997f8d512cdf944f4f4c0c01cb37c1 DIFF: https://github.com/llvm/llvm-project/commit/6cf8179661997f8d512cdf944f4f4c0c01cb37c1.diff

[PATCH] D155544: [AIX][TLS][clang] Add -maix-small-local-exec-tls clang option.

amyk updated this revision to Diff 543818. amyk marked 5 inline comments as done. amyk added a comment. Address review comments from Hubert and update this patch to be only the clang portion of the option. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D156184: [OpenMP] Add the `ompx_attribute` clause for target directives

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGef9ec4bbcca2: [OpenMP] Add the `ompx_attribute` clause for target directives (authored by jdoerfert). Herald added a project: clang. Herald added a

[clang] ef9ec4b - [OpenMP] Add the `ompx_attribute` clause for target directives

Author: Johannes Doerfert Date: 2023-07-24T22:04:45-07:00 New Revision: ef9ec4bbcca2fa4f64df47bc426f1d1c59ea47e2 URL: https://github.com/llvm/llvm-project/commit/ef9ec4bbcca2fa4f64df47bc426f1d1c59ea47e2 DIFF:

[PATCH] D156201: [ASTImporter] Fix two cases on fields circular refs

danix800 created this revision. danix800 added a project: clang. Herald added a subscriber: martong. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: All. danix800 requested review of this revision. Herald added a subscriber: cfe-commits. Fixes two

[PATCH] D142327: [clang][RISCV] Fix ABI handling of empty structs with hard FP calling conventions in C++

SixWeining added inline comments. Comment at: clang/lib/CodeGen/Targets/RISCV.cpp:178 return false; -if (isEmptyRecord(getContext(), Ty, true)) +if (isEmptyRecord(getContext(), Ty, true, true)) return true; asb wrote: > rogfer01 wrote: > >

[PATCH] D154324: [C++20] [Modules] [ODRHash] Use CanonicalType for base classes

ChuanqiXu added a comment. @alexfh Thanks for your reproducer! I've reverted the commit. @rsmith thanks for your very detailed suggestion too! I'll try to address them in a separate review page. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 8a86f85 - Revert "[C++20] [Modules] Use CanonicalType for base classes"

Author: Chuanqi Xu Date: 2023-07-25T11:03:57+08:00 New Revision: 8a86f85ab1e65fb5c148d7a645197b4634a2e2fc URL: https://github.com/llvm/llvm-project/commit/8a86f85ab1e65fb5c148d7a645197b4634a2e2fc DIFF: https://github.com/llvm/llvm-project/commit/8a86f85ab1e65fb5c148d7a645197b4634a2e2fc.diff

[PATCH] D155784: [X86] Update features for sierraforest, grandridge

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5cc4b1059b28: [X86] Update features for sierraforest, grandridge (authored by FreddyYe). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 5cc4b10 - [X86] Update features for sierraforest, grandridge

Author: Freddy Ye Date: 2023-07-25T11:00:41+08:00 New Revision: 5cc4b1059b2842418514a54599a37900b8c608a0 URL: https://github.com/llvm/llvm-project/commit/5cc4b1059b2842418514a54599a37900b8c608a0 DIFF: https://github.com/llvm/llvm-project/commit/5cc4b1059b2842418514a54599a37900b8c608a0.diff

[PATCH] D154784: [clang] Fix crash caused by PseudoObjectExprBitfields::NumSubExprs overflow

dblaikie added inline comments. Comment at: clang/include/clang/AST/Stmt.h:596-597 -// These don't need to be particularly wide, because they're -// strictly limited by the forms of expressions we permit. -unsigned NumSubExprs : 8; -unsigned ResultIndex : 32 -

[PATCH] D155798: [X86] Support -march=graniterapids-d and update -march=graniterapids

FreddyYe updated this revision to Diff 543797. FreddyYe marked an inline comment as done. FreddyYe added a comment. address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155798/new/ https://reviews.llvm.org/D155798 Files:

[clang] cead149 - Add new option -fkeep-persistent-storage-variables to Clang release notes

Author: Zheng Qian Date: 2023-07-24T22:56:18-04:00 New Revision: cead1497ae0c1d57ee6883500c7c205f83798440 URL: https://github.com/llvm/llvm-project/commit/cead1497ae0c1d57ee6883500c7c205f83798440 DIFF: https://github.com/llvm/llvm-project/commit/cead1497ae0c1d57ee6883500c7c205f83798440.diff

[PATCH] D155501: Add new option -fkeep-persistent-storage-variables to Clang release notes

This revision was automatically updated to reflect the committed changes. Closed by commit rGcead1497ae0c: Add new option -fkeep-persistent-storage-variables to Clang release notes (authored by qianzhen, committed by hubert.reinterpretcast). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D154366: [clang][ExprConstant] Print template arguments when describing stack frame

dblaikie added a comment. @hazohelet can you commit this yourself, or do you need someone to commit it on your behalf? (& if so, what name/email address would you like to be credited) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154366/new/ https://reviews.llvm.org/D154366

[PATCH] D155239: [clang-format] Add SpacesInParens with SpacesInParensOptions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc669541c969c: [clang-format] Add SpacesInParens with SpacesInParensOptions (authored by gedare, committed by owenpan). Changed prior to commit:

[clang] c669541 - [clang-format] Add SpacesInParens with SpacesInParensOptions

Author: Gedare Bloom Date: 2023-07-24T19:27:23-07:00 New Revision: c669541c969c70190933b4a16384c60de80242c0 URL: https://github.com/llvm/llvm-project/commit/c669541c969c70190933b4a16384c60de80242c0 DIFF: https://github.com/llvm/llvm-project/commit/c669541c969c70190933b4a16384c60de80242c0.diff

[PATCH] D156090: [Driver][XRay][test] Mark these tests as supported on loongarch64

Ami-zhang abandoned this revision. Ami-zhang added a comment. Thanks @MaskRay . 05c2c09bb1f10261f6f804a2d510c55d97b1584c improved these XRay tests. Abandon this change. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D155239: [clang-format] Add SpacesInParens with SpacesInParensOptions

owenpan added inline comments. Comment at: clang/docs/ReleaseNotes.rst:830 +- Add ``SpacesInParens`` style with ``SpacesInParensOptions`` to replace + ``SpacesInConditionalStatement``, ``SpacesInCStyleCastParentheses``, + ``SpaceInEmptyParentheses``, and

[PATCH] D156195: [docs] Add llvm & clang release notes for LoongArch

SixWeining created this revision. SixWeining added reviewers: xen0n, xry111, hev, wangleiat. Herald added a project: All. SixWeining requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D155824: [LoongArch] Support -march=native and -mtune=

SixWeining added a comment. @xen0n Do you have any inputs? I think supporting these options can improve compatibility with gcc (although there is no ScheduleModel difference among currently supported processors) and I hope it can be merged into LLVM17. Repository: rG LLVM Github Monorepo

[PATCH] D156089: [Driver][XRay][test] Convert more tests to check 'target=...' after 016785d9316d8c5abc5fdf3cdb86479095bbb677

SixWeining abandoned this revision. SixWeining added a comment. 841ff7c6ca4c6fa9ff3ac6ba93e177462b7d668e addresses this issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 74720d1 - [clang-format] Add AlignConsecutiveShortCaseStatements

Author: Galen Elias Date: 2023-07-24T18:39:25-07:00 New Revision: 74720d1b338efb0725dd80bf3e59069700f6e2f0 URL: https://github.com/llvm/llvm-project/commit/74720d1b338efb0725dd80bf3e59069700f6e2f0 DIFF: https://github.com/llvm/llvm-project/commit/74720d1b338efb0725dd80bf3e59069700f6e2f0.diff

[clang] 87ad34f - Revert "[clang-format] Add AlignConsecutiveShortCaseStatements"

Author: Owen Pan Date: 2023-07-24T18:37:42-07:00 New Revision: 87ad34ffdcf2de99dab0ac86f148a03e4bd2dddc URL: https://github.com/llvm/llvm-project/commit/87ad34ffdcf2de99dab0ac86f148a03e4bd2dddc DIFF: https://github.com/llvm/llvm-project/commit/87ad34ffdcf2de99dab0ac86f148a03e4bd2dddc.diff

[PATCH] D155997: [Phase Ordering] Don't speculate in SimplifyCFG before PGO annotation

tejohnson added a comment. In D155997#4529861 , @aeubanks wrote: > the pipeline change and simplifycfg change should be split into two changes SimplifyCFG change split into D156194 . Repository: rG LLVM Github

[PATCH] D155814: Fix the linting problems which causes `clang/utils/ci/run-buildbot check-format` to return 1.

ziqingluo-90 accepted this revision. ziqingluo-90 added a comment. This revision is now accepted and ready to land. Thanks for cleaning the trailing whites. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155814/new/ https://reviews.llvm.org/D155814

[clang] ac6e551 - Revert "Revert "[clang-format] Add AlignConsecutiveShortCaseStatements""

Author: Owen Pan Date: 2023-07-24T18:24:30-07:00 New Revision: ac6e55146f8c48f8ced95dfe54004142c0b36756 URL: https://github.com/llvm/llvm-project/commit/ac6e55146f8c48f8ced95dfe54004142c0b36756 DIFF: https://github.com/llvm/llvm-project/commit/ac6e55146f8c48f8ced95dfe54004142c0b36756.diff

[PATCH] D156116: [Clang][LoongArch] Fix ABI handling of empty structs in C++ to match GCC behaviour

SixWeining added a comment. In D156116#4530365 , @thakis wrote: > This seems to not build: http://45.33.8.238/linux/113405/step_4.txt (?) Thanks, I have reverted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 4f093b3 - Revert "[clang-format] Add AlignConsecutiveShortCaseStatements"

Author: Owen Pan Date: 2023-07-24T18:19:38-07:00 New Revision: 4f093b31669a4f8e417259583141159586a05b28 URL: https://github.com/llvm/llvm-project/commit/4f093b31669a4f8e417259583141159586a05b28 DIFF: https://github.com/llvm/llvm-project/commit/4f093b31669a4f8e417259583141159586a05b28.diff

[clang] 983f248 - Revert "[Clang][LoongArch] Fix ABI handling of empty structs in C++ to match GCC behaviour"

Author: Weining Lu Date: 2023-07-25T09:18:06+08:00 New Revision: 983f2488326e1f8034f3b0686cd44221d8697bdc URL: https://github.com/llvm/llvm-project/commit/983f2488326e1f8034f3b0686cd44221d8697bdc DIFF: https://github.com/llvm/llvm-project/commit/983f2488326e1f8034f3b0686cd44221d8697bdc.diff

[PATCH] D151761: clang-format: Add AlignConsecutiveShortCaseStatements

This revision was automatically updated to reflect the committed changes. Closed by commit rG4ba00844174d: [clang-format] Add AlignConsecutiveShortCaseStatements (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151761/new/

[clang] 4ba0084 - [clang-format] Add AlignConsecutiveShortCaseStatements

Author: Owen Pan Date: 2023-07-24T18:16:21-07:00 New Revision: 4ba00844174db562d2bd8b15dab6aac605eddf57 URL: https://github.com/llvm/llvm-project/commit/4ba00844174db562d2bd8b15dab6aac605eddf57 DIFF: https://github.com/llvm/llvm-project/commit/4ba00844174db562d2bd8b15dab6aac605eddf57.diff

[PATCH] D156192: [-Wunsafe-buffer-usage] Stop generating incorrect fix-its for variable declarations with unsupported specifiers

ziqingluo-90 created this revision. ziqingluo-90 added reviewers: NoQ, jkorous, t-rasmud, malavikasamak. Herald added a project: All. ziqingluo-90 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We have to give up on fixing a variable

[PATCH] D156040: [AMDGPU] Add dynamic stack bit info to kernel-resource-usage Rpass output

crobeck updated this revision to Diff 543772. crobeck edited the summary of this revision. crobeck added a comment. Change remark order and add static stack w/ indirect function call test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D155798: [X86] Support -march=graniterapids-d and update -march=graniterapids

skan accepted this revision. skan added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155798/new/ https://reviews.llvm.org/D155798 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D156116: [Clang][LoongArch] Fix ABI handling of empty structs in C++ to match GCC behaviour

thakis added a comment. This seems to not build: http://45.33.8.238/linux/113405/step_4.txt (?) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156116/new/ https://reviews.llvm.org/D156116 ___ cfe-commits

[PATCH] D154931: [LoongArch] Support InlineAsm for LSX and LASX

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd25c79dc7000: [LoongArch] Support InlineAsm for LSX and LASX (authored by chenli, committed by SixWeining). Repository: rG LLVM Github Monorepo

[clang] d25c79d - [LoongArch] Support InlineAsm for LSX and LASX

Author: chenli Date: 2023-07-25T09:02:29+08:00 New Revision: d25c79dc70008b835312e5cc7ef48b199fda3165 URL: https://github.com/llvm/llvm-project/commit/d25c79dc70008b835312e5cc7ef48b199fda3165 DIFF: https://github.com/llvm/llvm-project/commit/d25c79dc70008b835312e5cc7ef48b199fda3165.diff LOG:

[PATCH] D156116: [Clang][LoongArch] Fix ABI handling of empty structs in C++ to match GCC behaviour

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc299efbf284f: [Clang][LoongArch] Fix ABI handling of empty structs in C++ to match GCC… (authored by SixWeining). Repository: rG LLVM Github

[clang] c299efb - [Clang][LoongArch] Fix ABI handling of empty structs in C++ to match GCC behaviour

Author: Weining Lu Date: 2023-07-25T08:59:40+08:00 New Revision: c299efbf284fae92bb8d7d29110f76912f089daf URL: https://github.com/llvm/llvm-project/commit/c299efbf284fae92bb8d7d29110f76912f089daf DIFF: https://github.com/llvm/llvm-project/commit/c299efbf284fae92bb8d7d29110f76912f089daf.diff

[PATCH] D156114: [Clang][LoongArch] Pre-commit test for D156116

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG669d2bbc837e: [Clang][LoongArch] Pre-commit test for D156116

[clang] 669d2bb - [Clang][LoongArch] Pre-commit test for D156116

Author: Weining Lu Date: 2023-07-25T08:59:40+08:00 New Revision: 669d2bbc837ee56d6bb05d5d55615246fc8b6b5c URL: https://github.com/llvm/llvm-project/commit/669d2bbc837ee56d6bb05d5d55615246fc8b6b5c DIFF: https://github.com/llvm/llvm-project/commit/669d2bbc837ee56d6bb05d5d55615246fc8b6b5c.diff

[PATCH] D156189: [-Wunsafe-buffer-usage] Refactor to let local variable fix-its and parameter fix-its share common code

ziqingluo-90 added inline comments. Comment at: clang/test/SemaCXX/warn-unsafe-buffer-usage-fixits-local-var-span.cpp:242 ptr[2] = 30; - auto p = new int[10]; - // CHECK-DAG: fix-it:"{{.*}}":{[[@LINE-1]]:3-[[@LINE-1]]:11}:"std::span p" We no longer

[PATCH] D156178: [HLSL] add pow library function

bob80905 added inline comments. Comment at: clang/test/CodeGenHLSL/builtins/pow.hlsl:10 +// CHECK: call half @llvm.pow.f16( +// NO_HALF: define noundef float @"?test_pow_half@@YA$halff@$halff@0@Z"( +// NO_HALF: call float @llvm.pow.f32( bogner wrote: > Why check

[PATCH] D156178: [HLSL] add pow library function

bob80905 updated this revision to Diff 543757. bob80905 added a comment. - add func name to checks, clang format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156178/new/ https://reviews.llvm.org/D156178 Files:

[PATCH] D156189: [-Wunsafe-buffer-usage] Refactor to let local variable fix-its and parameter fix-its share common code

ziqingluo-90 created this revision. ziqingluo-90 added reviewers: NoQ, jkorous, t-rasmud, malavikasamak. Herald added a project: All. ziqingluo-90 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Refactor the code for local variable fix-its

[PATCH] D154658: Optimize emission of `dynamic_cast` to final classes.

thakis added a comment. This caused https://github.com/llvm/llvm-project/issues/64088 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154658/new/ https://reviews.llvm.org/D154658 ___ cfe-commits mailing

[PATCH] D156188: Refactor and improve for parameter fix-its

ziqingluo-90 created this revision. ziqingluo-90 added reviewers: NoQ, jkorous, t-rasmud, malavikasamak. Herald added a project: All. ziqingluo-90 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. - Factor out the code that will be shared by

[PATCH] D154123: [HIP] Start document HIP support by clang

keryell added inline comments. Comment at: clang/docs/HIPSupport.rst:30 + +Clang provides partial HIP support on Intel GPUs using the CHIP-Star project ``_. CHIP-Star implements the HIP runtime over oneAPI Level Zero or OpenCL runtime. The

[PATCH] D156185: [clang][ConstExprEmitter] handle ArrayToPointerDecay ImplicitCastExpr of StringLiterals

efriedma added a comment. > so if you were concerned with arrays of string literals, we need this patch. Ohhh that's not what I meant by StringLiterals. I meant cases where the string literal is an rvalue, like `char foo[10] = "x";`. If it's an lvalue, we go through

[PATCH] D156178: [HLSL] add pow library function

bogner added a comment. Looking at https://learn.microsoft.com/en-us/windows/win32/direct3dhlsl/dx-graphics-hlsl-pow, it seems a bit underspecified, but do we need to worry about differences between that spec and IEEE behaviour here? For example, it says there that `x<0, y=any -> NaN`, but

[PATCH] D156185: [clang][ConstExprEmitter] handle ArrayToPointerDecay ImplicitCastExpr of StringLiterals

efriedma added a comment. > I guess I lost focus on the "struct or array part." Right... scalars weren't the concern for D76096 . They have much less overhead going through ExprConstant, and any evaluation of scalars isn't a regression because we currently

[PATCH] D156185: [clang][ConstExprEmitter] handle ArrayToPointerDecay ImplicitCastExpr of StringLiterals

nickdesaulniers added a comment. For this case in this patch in particular: extern const char* bar; const char* foo [] = { "hello", "goodbye", bar }; TranslationUnitDecl |-VarDecl col:20 used bar 'const char *' extern `-VarDecl line:2:13 foo 'const char *[3]'

[PATCH] D156175: [clang][ConstExprEmitter] handle NullToPointer ImplicitCastExpr

efriedma added inline comments. Comment at: clang/lib/CodeGen/CGExprConstant.cpp:1131-1132 +case CK_NullToPointer: { + if (llvm::Constant *C = Visit(subExpr, destType)) +if (C->isNullValue()) + return CGM.EmitNullConstant(destType);

[PATCH] D156185: [clang][ConstExprEmitter] handle ArrayToPointerDecay ImplicitCastExpr of StringLiterals

nickdesaulniers added a comment. In D156185#4530117 , @efriedma wrote: > We can do a whole bunch of these, but at some point we hit diminishing > returns... bailing out here isn't *that* expensive. Do you have some idea > how far you want to go with

[PATCH] D156178: [HLSL] add pow library function

bob80905 added inline comments. Comment at: clang/test/CodeGenHLSL/builtins/pow.hlsl:6 +// RUN: dxil-pc-shadermodel6.3-library %s -emit-llvm -disable-llvm-passes \ +// RUN: -D__HLSL_ENABLE_16_BIT -o - | FileCheck %s --check-prefix=NO_HALF + beanz wrote: >

[PATCH] D156185: [clang][ConstExprEmitter] handle ArrayToPointerDecay ImplicitCastExpr of StringLiterals

efriedma added a comment. We can do a whole bunch of these, but at some point we hit diminishing returns... bailing out here isn't *that* expensive. Do you have some idea how far you want to go with this? Adding a couple obvious checks like this isn't a big deal, but I don't want to build up

[PATCH] D156178: [HLSL] add pow library function

beanz added inline comments. Comment at: clang/test/CodeGenHLSL/builtins/pow.hlsl:6 +// RUN: dxil-pc-shadermodel6.3-library %s -emit-llvm -disable-llvm-passes \ +// RUN: -D__HLSL_ENABLE_16_BIT -o - | FileCheck %s --check-prefix=NO_HALF + Does this need to

[PATCH] D156154: [clang][ConstExprEmitter] handle IntegerLiterals

shafik added a comment. In D156154#4529907 , @nickdesaulniers wrote: > > Should speed up "is the below expression a constant expression?" > >> What kind of code do this effect? > > > > int y = 2; > ^ is 2 a constant expression? Nice!

[PATCH] D156182: [clang][CodeGenModule] remove declaration of GetAddrOfConstantString

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156182/new/ https://reviews.llvm.org/D156182

[PATCH] D156185: [clang][ConstExprEmitter] handle ArrayToPointerDecay ImplicitCastExpr of StringLiterals

nickdesaulniers created this revision. Herald added a project: All. nickdesaulniers requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Consider the following statement: const char* foo = "foo"; For the sub-AST: `-ImplicitCastExpr

[PATCH] D156182: [clang][CodeGenModule] remove declaration of GetAddrOfConstantString

nickdesaulniers created this revision. Herald added a project: All. nickdesaulniers requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. It looks like the definition was removed in cd21d541397e but the declaration was not. Surprisingly (to

[PATCH] D155997: [Phase Ordering] Don't speculate in SimplifyCFG before PGO annotation

aeubanks added inline comments. Comment at: llvm/test/Transforms/SimplifyCFG/fold-branch-to-common-dest.ll:3 ; RUN: opt < %s -S -passes=simplifycfg -simplifycfg-require-and-preserve-domtree=1 -bonus-inst-threshold=10 | FileCheck %s +; RUN: opt < %s -S -passes='simplifycfg'

[PATCH] D155997: [Phase Ordering] Don't speculate in SimplifyCFG before PGO annotation

tejohnson added inline comments. Comment at: llvm/lib/Passes/PassBuilderPipelines.cpp:277 +static cl::opt AlwaysAllowSimplifyCFGSpeculation( +"always-allow-simplify-cfg-speculation", cl::init(false), cl::Hidden, aeubanks wrote: > can we just drop the flag

[PATCH] D156178: [HLSL] add pow library function

bob80905 updated this revision to Diff 543731. bob80905 added a comment. - add eof newline Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156178/new/ https://reviews.llvm.org/D156178 Files: clang/lib/Headers/hlsl/hlsl_intrinsics.h

[PATCH] D156178: [HLSL] add pow library function

bob80905 updated this revision to Diff 543730. bob80905 added a comment. - remove non-floating-point func decls from header file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156178/new/ https://reviews.llvm.org/D156178 Files:

[PATCH] D155529: [clang-format] Add SpaceInParensOption for __attribute__ keyword

gedare updated this revision to Diff 543729. gedare added a comment. Add a release note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155529/new/ https://reviews.llvm.org/D155529 Files: clang/docs/ClangFormatStyleOptions.rst

[PATCH] D155239: [clang-format] Add SpacesInParens with SpacesInParensOptions

gedare updated this revision to Diff 543727. gedare added a comment. Add a release note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155239/new/ https://reviews.llvm.org/D155239 Files: clang/docs/ClangFormatStyleOptions.rst

[PATCH] D156178: [HLSL] add pow library function

bob80905 created this revision. bob80905 added reviewers: python3kgae, beanz. Herald added a subscriber: Anastasia. Herald added a project: All. bob80905 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change exposes the pow library

[PATCH] D154550: [clang-format] Allow empty loops on a single line.

gedare updated this revision to Diff 543721. gedare added a comment. This revision is now accepted and ready to land. Change option name from NonEmpty to NonNullStatement. Fix space before semi. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D156175: [clang][ConstExprEmitter] handle NullToPointer ImplicitCastExpr

nickdesaulniers added inline comments. Comment at: clang/lib/CodeGen/CGExprConstant.cpp:1131-1132 +case CK_NullToPointer: { + if (llvm::Constant *C = Visit(subExpr, destType)) +if (C->isNullValue()) + return CGM.EmitNullConstant(destType);

[PATCH] D156154: [clang][ConstExprEmitter] handle IntegerLiterals

nickdesaulniers added a comment. In D156154#4529889 , @shafik wrote: > What practical effects will this have? As of D151587 ... From the commit message `Improves the ability of ConstExprEmitter to evaluate constants.`

[PATCH] D156154: [clang][ConstExprEmitter] handle IntegerLiterals

shafik added a comment. What practical effects will this have? What kind of code do this effect? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156154/new/ https://reviews.llvm.org/D156154 ___

[PATCH] D156175: [clang][ConstExprEmitter] handle NullToPointer ImplicitCastExpr

nickdesaulniers created this revision. Herald added a subscriber: inglorion. Herald added a project: All. nickdesaulniers requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Consider the following statement: void* foo = ((void *)0); For

[PATCH] D155997: [Phase Ordering] Don't speculate in SimplifyCFG before PGO annotation

aeubanks added a comment. the pipeline change and simplifycfg change should be split into two changes Comment at: llvm/lib/Passes/PassBuilderPipelines.cpp:277 +static cl::opt AlwaysAllowSimplifyCFGSpeculation( +"always-allow-simplify-cfg-speculation", cl::init(false),

[PATCH] D153914: [clang-cl] Enable concatenation of predefined identifiers

cor3ntin added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:2010-2013 +OS << "R\"EFLPM(" + << PredefinedExpr::ComputeName(getPredefinedExprKind(Tok.getKind()), + currentDecl) + << ")EFLPM\"";

[PATCH] D144829: [BPF] Add a few new insns under cpu=v4

yonghong-song updated this revision to Diff 543709. yonghong-song added a comment. Three major changes in this patch: - for ldsx insns, remove 32bit ldsx insns (1-byte and 2-byte sign extension) since the ldsx insn expects to sign extension all the way up to 8-byte and normal 32bit insn (e.g.

[PATCH] D156172: [clang][CodeGen] Emit annotations for function declarations.

brendandahl created this revision. Herald added a project: All. brendandahl requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previously, annotations were only emitted for function definitions. With this change annotations are also emitted

[PATCH] D156161: [clang-tidy] Add --enable-module-headers-parsing option

PiotrZSL updated this revision to Diff 543708. PiotrZSL retitled this revision from "[clang-tidy] Add --experimental-enable-module-headers-parsing option" to "[clang-tidy] Add --enable-module-headers-parsing option". PiotrZSL edited the summary of this revision. PiotrZSL added a comment. Herald

[PATCH] D156064: [SemaCXX] Recognise initializer_list injected-class-name types as initializer_lists

shafik added a comment. This makes sense I see that `isStdInitializerList(...)` is used in a lot of places, this makes me wonder if we need additional test coverage. I also added some folks for more review visibility. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D154790: [HIP] Use native math functions for `-fcuda-approx-transcendentals`

yaxunl added a comment. ping It passes internal CI. Also tested with Blender main branch with -ffast-math and no regressions were found. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154790/new/ https://reviews.llvm.org/D154790 ___

[PATCH] D154893: [Clang] Fix some triviality computations

shafik added inline comments. Comment at: clang/include/clang/AST/DeclCXX.h:1269 /// Determine whether this class has a non-trivial copy constructor /// (C++ [class.copy]p6, C++11 [class.copy]p12) bool hasNonTrivialCopyConstructor() const { philnik

[PATCH] D156024: [clang-tidy] Add --experimental-disable-module-headers-parsing option

PiotrZSL abandoned this revision. PiotrZSL added a comment. Will be integrated into D156161 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156024/new/ https://reviews.llvm.org/D156024

[PATCH] D156032: Implement CWG2137 (list-initialization from objects of the same type)

MitalAshok updated this revision to Diff 543699. MitalAshok added a comment. Add CWG2311 fix too Too much code and tests rely on elision of `T{ T_prvalue }` in C++17, so add change to allow that to be elided when this does not pick a initializer-list constructor. Repository: rG LLVM Github

[PATCH] D156064: [SemaCXX] Recognise initializer_list injected-class-name types as initializer_lists

MitalAshok updated this revision to Diff 543697. MitalAshok added a comment. Remove now unneeded FIXME Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156064/new/ https://reviews.llvm.org/D156064 Files: clang/docs/ReleaseNotes.rst

[PATCH] D155794: [OpenMP][OpenMPIRBuilder] Migrate setPropertyExecutionMode() from Clang to OpenMPIRBuilder.

raghavendhra updated this revision to Diff 543696. raghavendhra added a comment. Addressed review comments by making setPropertyExecutionMode() to return a Global Value instead of void. Rebased patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D153310: clang: Add elementwise pow builtin

This revision was automatically updated to reflect the committed changes. Closed by commit rG3a98e73169e1: clang: Add elementwise pow builtin (authored by bob80905). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153310/new/

[clang] 3a98e73 - clang: Add elementwise pow builtin

Author: Joshua Batista Date: 2023-07-24T14:03:58-07:00 New Revision: 3a98e73169e1d8e4fbb739462eea62445db1a6c8 URL: https://github.com/llvm/llvm-project/commit/3a98e73169e1d8e4fbb739462eea62445db1a6c8 DIFF:

[PATCH] D154130: [lit][clang] Avoid realpath on Windows due to MAX_PATH limitations

tahonermann added a comment. > Marking comments as resolved per my reply. I'm not sure if that's best > practice! Yes, that is fine. Comment at: clang/test/Lexer/case-insensitive-include-win.c:5-9 +// Note: We must use the real path here, because the logic to detect case +//

[PATCH] D156143: Add Adrian and David as owners for debug info

dblaikie added a comment. Sounds good, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156143/new/ https://reviews.llvm.org/D156143 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D151587: [clang][ConstantEmitter] have tryEmitPrivate[ForVarInit] try ConstExprEmitter fast-path first

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb54294e2c959: [clang][ConstantEmitter] have tryEmitPrivate[ForVarInit] try ConstExprEmitter… (authored by nickdesaulniers). Repository: rG LLVM

[clang] b54294e - [clang][ConstantEmitter] have tryEmitPrivate[ForVarInit] try ConstExprEmitter fast-path first

Author: Nick Desaulniers Date: 2023-07-24T13:50:45-07:00 New Revision: b54294e2c9596088aaf557b221bcf471745864bc URL: https://github.com/llvm/llvm-project/commit/b54294e2c9596088aaf557b221bcf471745864bc DIFF:

[PATCH] D155991: [DWARF] Make sure file entry for artificial functions has an MD5 checksum

dblaikie added a comment. Any memory usage measurements to check this doesn't have a significant adverse impact by copying all the strings? (or performance by having to do string rather than pointer equality comparisons?) Could/should we do the lookup on the CU filename before it goes into the

[PATCH] D156128: [Clang][AArch64] Fix up immediate range of f64f64 mopa/mops intrinsics

bryanpkc added inline comments. Comment at: clang/include/clang/Basic/arm_sme.td:254 [IsStreaming, IsSharedZA], - [ImmCheck<0, ImmCheck0_3>]>; + [ImmCheck<0, ImmCheck0_0>]>; }

[PATCH] D153536: [Clang] Implement P2169 A nice placeholder with no name

dblaikie added a comment. In D153536#4521156 , @hubert.reinterpretcast wrote: > In D153536#4512897 , @dblaikie > wrote: > >> but at least at a first blush I can't reproduce the failures shown... > > @dblaikie,

[PATCH] D150226: [Clang] Remove ability to downgrade warning on the diagnostic for setting a non fixed enum to a value outside the range of the enumeration values

dblaikie added a comment. > I think getting new system headers is harder for projects to deal with, so I > think I'm now in agreement with you that we should enable the warning as an > error in system headers. Awesome - glad we're on the same page :) CHANGES SINCE LAST ACTION

  1   2   3   4   >