[PATCH] D156394: [Clang][RISCV] Bump rvv intrinsics version to v0.12

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG20e87e2f7941: [Clang][RISCV] Bump rvv intrinsics version to v0.12 (authored by eopXD). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 20e87e2 - [Clang][RISCV] Bump rvv intrinsics version to v0.12

Author: eopXD Date: 2023-07-26T22:54:40-07:00 New Revision: 20e87e2f794173deebd1cf8c86684452bb0c989b URL: https://github.com/llvm/llvm-project/commit/20e87e2f794173deebd1cf8c86684452bb0c989b DIFF: https://github.com/llvm/llvm-project/commit/20e87e2f794173deebd1cf8c86684452bb0c989b.diff LOG:

[PATCH] D156221: [RISCV] Support overloaded version ntlh intrinsic function

kito-cheng added inline comments. Comment at: clang/lib/Headers/riscv_ntlh.h:28 + __builtin_riscv_ntl_load((PTR), __RISCV_NTLH_ALL) +#define SELECT_NTL_LOAD(_1, _2, NAME, ...) NAME + `__SELECT_NTL_LOAD` Comment at:

[PATCH] D156394: [Clang][RISCV] Bump rvv intrinsics version to v0.12

kito-cheng accepted this revision. kito-cheng added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156394/new/ https://reviews.llvm.org/D156394

[PATCH] D156357: clang: Add elementwise bitreverse builtin

bob80905 updated this revision to Diff 544610. bob80905 added a comment. - remove tests that only test floating point inputs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156357/new/ https://reviews.llvm.org/D156357 Files:

[PATCH] D156394: [Clang][RISCV] Bump rvv intrinsics version to v0.12

eopXD created this revision. eopXD added reviewers: asb, craig.topper, kito-cheng. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01,

[PATCH] D156321: [Clang][RISCV] Remove RVV intrinsics `vread_csr`,`vwrite_csr`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7cb81c1b8ce5: [Clang][RISCV] Remove RVV intrinsics `vread_csr`,`vwrite_csr` (authored by eopXD). Repository: rG LLVM Github Monorepo CHANGES

[clang] 7cb81c1 - [Clang][RISCV] Remove RVV intrinsics `vread_csr`,`vwrite_csr`

Author: eopXD Date: 2023-07-26T22:33:41-07:00 New Revision: 7cb81c1b8ce5012c36bb8ed0eb4da2f94fb4f0fc URL: https://github.com/llvm/llvm-project/commit/7cb81c1b8ce5012c36bb8ed0eb4da2f94fb4f0fc DIFF: https://github.com/llvm/llvm-project/commit/7cb81c1b8ce5012c36bb8ed0eb4da2f94fb4f0fc.diff LOG:

[PATCH] D156337: [clang] Allow setting the uninitialized attribute on record

shafik added a comment. I think a test verifying that during constant evaluation we still flag the read of a local tagged uninitialized as ill-formed would be nice. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156337/new/

[PATCH] D156337: [clang] Allow setting the uninitialized attribute on record

shafik added a reviewer: clang-language-wg. shafik added a comment. Adding clang-language-wg for more visibility. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156337/new/ https://reviews.llvm.org/D156337

[PATCH] D156247: [Clang] Add a warning on uses of coroutine keywords

ChuanqiXu added a comment. While I am not against the approach, do you think we need similar semantics for `-fno-concepts`, `-fno-modules`, etc... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156247/new/ https://reviews.llvm.org/D156247

[PATCH] D156247: [Clang] Add a warning on uses of coroutine keywords

shafik added a comment. In D156247#4536034 , @tahonermann wrote: >> You are absolutely right, -fno-coroutines would totally work for us, had it >> been available. > > Good. Gcc handles `-fcoroutines` and `-fno-coroutines` as I would expect >

[PATCH] D141918: WIP: [Clang] Emit 'unwindabort' when applicable.

jroelofs added inline comments. Herald added a subscriber: jplehr. Comment at: clang/lib/CodeGen/CodeGenFunction.h:2021 + /* Indicates whether we should generate calls using unwindabort, instead of a + * terminate landingpad, for the current EH Scope. */ + bool

[PATCH] D156307: [clang][DeclPrinter] Fix AST print of curly constructor initializers

strimo378 updated this revision to Diff 544566. strimo378 added a comment. Added additional ctor variants as suggested by the reviewers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156307/new/ https://reviews.llvm.org/D156307 Files:

[PATCH] D156325: [Driver] Link shared asan runtime lib with -z now on Solaris/x86

MaskRay added a comment. This needs a clang/test/Driver test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156325/new/ https://reviews.llvm.org/D156325 ___ cfe-commits mailing list

[PATCH] D156357: clang: Add elementwise bitreverse builtin

bob80905 updated this revision to Diff 544563. bob80905 added a comment. - remove strictfp test, add cgbuiltin case and update test in codegen Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156357/new/ https://reviews.llvm.org/D156357 Files:

[PATCH] D156312: [analyzer] Upstream BitwiseShiftChecker

NoQ added a comment. > (1) UBOR is only triggered when the constant folding performed by the Clang > Static Analyzer engine determines that the value of a binary operator > expression is undefined Yes I wholeheartedly agree, these checks are pre-condition checks, they should have never been

[PATCH] D154880: [-Wunsafe-buffer-usage] Add a facility for debugging low fixit coverage.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa6ae740e743a: [-Wunsafe-buffer-usage] Add a facility for debugging low fixit coverage (authored by t-rasmud). Herald added a project: clang.

[clang] a6ae740 - [-Wunsafe-buffer-usage] Add a facility for debugging low fixit coverage

Author: Rashmi Mudduluru Date: 2023-07-26T17:07:36-07:00 New Revision: a6ae740e743a2241f7104c13152cd0a0582765c5 URL: https://github.com/llvm/llvm-project/commit/a6ae740e743a2241f7104c13152cd0a0582765c5 DIFF:

[PATCH] D155955: [Clang] Improve the handling of large arrays evaluation.

efriedma added a comment. The general approach seems fine. The multiplier for constexpr vs. constant folding can be left for a followup, and we can continue to consider other possible improvements elsewhere. I guess I have one remaining question here: how does this interact with SFINAE? In

[PATCH] D153058: [clang][CFG] Support construction of a weak topological ordering of the CFG.

ymandel marked 5 inline comments as done. ymandel added a comment. Thanks for the helpful suggestions! Comment at: clang/include/clang/Analysis/Analyses/IntervalPartition.h:104 +/// intervals) if and only if it is reducible (its limit flow graph has one +/// node). Returns

[PATCH] D153058: [clang][CFG] Support construction of a weak topological ordering of the CFG.

ymandel updated this revision to Diff 544551. ymandel marked 2 inline comments as done. ymandel added a comment. Addressed comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153058/new/ https://reviews.llvm.org/D153058 Files:

[PATCH] D76096: [clang] allow const structs/unions/arrays to be constant expressions for C

efriedma added a comment. > But prior to D151587 , we did that for C++. > Why is C special here? And prior to this patch, we did that for C++ 11+. Why > is C++ 03 special here? I'm trying to avoid regressions. C++11 made constant evaluation a lot more

[PATCH] D156351: clang driver throws error for -mabi=elfv2 or elfv2

MaskRay added a comment. > After clang release/16.x there is a regression that -mabi=elfv1 or > -mabi=elfv2 are being unused and throws warning. Please just give the full clang command line and add a test case under `test/Driver`. FWIW: `clang --target=powerpc64le-linux-gnu -mabi=elfv1

[PATCH] D154007: Reland "Try to implement lambdas with inalloca parameters by forwarding without use of inallocas."

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG27dab4d305ac: Reland Try to implement lambdas with inalloca parameters by forwarding without… (authored by akhuang). Repository: rG LLVM Github

[clang] 27dab4d - Reland "Try to implement lambdas with inalloca parameters by forwarding without use of inallocas."t

Author: Amy Huang Date: 2023-07-26T16:13:36-07:00 New Revision: 27dab4d305acb6e0935e014c061c5317016ae2b3 URL: https://github.com/llvm/llvm-project/commit/27dab4d305acb6e0935e014c061c5317016ae2b3 DIFF: https://github.com/llvm/llvm-project/commit/27dab4d305acb6e0935e014c061c5317016ae2b3.diff

[PATCH] D156370: [clang-format] Fix bug with parsing of function/variable names.

gedare added a comment. In D156370#4536793 , @HazardyKnusperkeks wrote: > Does this result in a different annotation? Could you add a test for that? If I understand you correctly, it does, for example: `$ echo "void __attribute__((naked)) foo(int

[PATCH] D154880: [-Wunsafe-buffer-usage] Add a facility for debugging low fixit coverage.

t-rasmud updated this revision to Diff 544547. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154880/new/ https://reviews.llvm.org/D154880 Files: clang/include/clang/Analysis/Analyses/UnsafeBufferUsage.h clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D156360: [clang-format] Support function and overloaded operator SpacesInParensOption

gedare updated this revision to Diff 544544. gedare added a comment. Add tests and correct function call detection. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156360/new/ https://reviews.llvm.org/D156360 Files:

[PATCH] D154130: [lit][clang] Avoid realpath on Windows due to MAX_PATH limitations

benlangmuir added inline comments. Comment at: clang/lib/Basic/FileManager.cpp:655 + SmallString<4096> AbsPathBuf = Name; + SmallString<4096> RealPathBuf; + if (!FS->makeAbsolute(AbsPathBuf)) { 8k is a lot of stack space. The only reason this was 4k in the

[PATCH] D156224: [Clang] use unsigned integer constants in unit-test | fixes build error on ppc64le-lld-multistage-test

shafik added inline comments. Comment at: clang/unittests/libclang/LibclangTest.cpp:1232 ASSERT_TRUE(staticAssertCsr.has_value()); - size_t argCnt = 0; + int argCnt = 0; Traverse(*staticAssertCsr, [](CXCursor cursor, CXCursor parent) { Above you used

[PATCH] D154880: [-Wunsafe-buffer-usage] Add a facility for debugging low fixit coverage.

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. LGTM! I'm excited to learn what this new facility discovers! Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:1730-1735 +#ifndef NDEBUG +#define DEBUG_NOTE_DECL_FAIL(D, Msg)

[PATCH] D144634: [Clang][OpenMP] Support for Code Generation of loop bind clause

koops updated this revision to Diff 544542. koops added a comment. Fixing Alexey's suggestions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144634/new/ https://reviews.llvm.org/D144634 Files: clang/include/clang/AST/StmtOpenMP.h clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D150946: [clang][Interp] PointerToIntegral casts

phosek added a comment. This test is failing on our Windows builders with the following error: Script: -- : 'RUN: at line 1'; c:\b\s\w\ir\x\w\llvm_build\bin\clang.exe -cc1 -internal-isystem c:\b\s\w\ir\x\w\llvm_build\lib\clang\18\include -nostdsysteminc

[PATCH] D153623: [clang][Sema] Add fixit for scoped enum format error

smeenai added a comment. Sorry for the delayed comment here. The fix-it is convenient, but is it the best suggestion? It'll end up suggesting truncating the enum value instead of using the proper format specifier in https://godbolt.org/z/xdhrefG95, for example. More insidiously, the

[PATCH] D156366: HIP: Use __builtin_sqrt instead of routing through ocml sqrt for f64

arsenm closed this revision. arsenm added a comment. 63dbe7e808d07bdf25bad85301980bc323b0cd64 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156366/new/ https://reviews.llvm.org/D156366 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D156378: [clang][CGExprConstant] handle unary negation on integrals

nickdesaulniers updated this revision to Diff 544538. nickdesaulniers added a comment. - fix oneline class Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156378/new/ https://reviews.llvm.org/D156378 Files: clang/lib/CodeGen/CGExprConstant.cpp

[PATCH] D156378: [clang][CGExprConstant] handle unary negation on integrals

nickdesaulniers created this revision. Herald added a project: All. nickdesaulniers requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Consider the statement: int x = -1; And the following AST: `-VarDecl 0x55c4823a7670 col:5 x 'int'

[PATCH] D130096: [Clang][AMDGPU] Emit AMDGPU library control constants in clang

arsenm added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:9461-9463 + bool CorrectSqrt = CGM.getLangOpts().OpenCL + ? CGM.getCodeGenOpts().OpenCLCorrectlyRoundedDivSqrt + :

[PATCH] D156330: [hexagon] restore library path arguments

bcain updated this revision to Diff 544533. bcain added a comment. Too hasty w/the last update - forgot to remove the `-###`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156330/new/ https://reviews.llvm.org/D156330 Files:

[PATCH] D130096: [Clang][AMDGPU] Emit AMDGPU library control constants in clang

arsenm added a comment. We should just do this now. clang shouldn't have to dig around on disk to emit a constant definition for a constant it already knows, and we have a clear path to removing these globals altogether. I have adequate patches to completely delete `__oclc_daz_opt` today.

[PATCH] D156330: [hexagon] restore library path arguments

bcain updated this revision to Diff 544532. bcain added a comment. I misunderstood the previous suggestion about `-fdriver-only -Werror -v` and thought I needed to separate the test into two invocations. Combined these back into a single RUN now. Repository: rG LLVM Github Monorepo

[PATCH] D156330: [hexagon] restore library path arguments

MaskRay added a comment. In D156330#4536827 , @bcain wrote: > Fixed target: `--target=hexagon-unknown-linux` was not correct for testing > this bug, it should have been `--target=hexagon-unknown-linux-musl`. > > Used `-fdriver-only -Werror` as suggested

[PATCH] D156330: [hexagon] restore library path arguments

bcain updated this revision to Diff 544527. bcain added a comment. Fixed target: `--target=hexagon-unknown-linux` was not correct for testing this bug, it should have been `--target=hexagon-unknown-linux-musl`. Used `-fdriver-only -Werror` as suggested but it did require separating the tests.

[PATCH] D156370: [clang-format] Fix bug with parsing of function/variable names.

HazardyKnusperkeks added a comment. Does this result in a different annotation? Could you add a test for that? Comment at: clang/lib/Format/TokenAnnotator.cpp:2211-2212 if (PreviousNotConst->is(tok::r_paren) && -PreviousNotConst->is(TT_TypeDeclarationParen)) { +

[PATCH] D156363: [Driver] -###: exit with code 1 if hasErrorOccurred

MaskRay added a comment. @jhuber6 @yaxunl you may want to revise some AMDGPU related tests, e.g. `amdgcn-gz-options.cl`. Some `RUN: %clang` lines currently fail with `error: cannot find ROCm device library; provide its path via '--rocm-path' or '--rocm-device-lib-path', or pass '-nogpulib' to

[PATCH] D154880: [-Wunsafe-buffer-usage] Add a facility for debugging low fixit coverage.

t-rasmud updated this revision to Diff 544521. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154880/new/ https://reviews.llvm.org/D154880 Files: clang/include/clang/Analysis/Analyses/UnsafeBufferUsage.h clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D153689: [clang][Interp] Handle CXXConstructExprs

shafik added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:1109 +template +bool ByteCodeExprGen::VisitCXXConstructExpr( +const CXXConstructExpr *E) { Should we be checking `isElidable()`? Repository: rG LLVM Github Monorepo

[PATCH] D156370: [clang-format] Fix bug with parsing of function/variable names.

gedare created this revision. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan, MyDeveloperDay. gedare requested review of this revision. Function and variable names are not detected correctly when

[PATCH] D156330: [hexagon] restore library path arguments

bcain added a comment. In D156330#4535974 , @MaskRay wrote: > Tip: use `%clang -fdriver-only -Werror -v` to test that a command produces no > warning or error and has an exit code of 0. Without it your > `Args.ClaimAllArgs(options::OPT_L);` change is

[PATCH] D154880: [-Wunsafe-buffer-usage] Add a facility for debugging low fixit coverage.

NoQ added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:1730-1731 +#define DEBUG_NOTE_DECL_FAIL(D, Msg) \ +Handler.addDebugNoteForVar((D), (D)->getBeginLoc(), "failed to produce fixit for declaration '" + D->getNameAsString() + "'" + Msg) +

[PATCH] D154880: [-Wunsafe-buffer-usage] Add a facility for debugging low fixit coverage.

t-rasmud added a comment. In D154880#4533035 , @ziqingluo-90 wrote: > This is a lot of work, thank you @t-rasmud & @NoQ ! > > I have a minor suggestion: can we use some macros to make the debug stub even > shorter? > The prefix `"failed to produce

[PATCH] D154880: [-Wunsafe-buffer-usage] Add a facility for debugging low fixit coverage.

t-rasmud updated this revision to Diff 544510. t-rasmud retitled this revision from "[-Wunsafe-buffer-usage][WIP] Add a facility for debugging low fixit coverage." to "[-Wunsafe-buffer-usage] Add a facility for debugging low fixit coverage.". CHANGES SINCE LAST ACTION

[PATCH] D156368: [OpenMP] Do not always emit unused extern variables

jhuber6 created this revision. jhuber6 added reviewers: JonChesterfield, jdoerfert, tianshilei1992, ye-luo, RaviNarayanaswamy, ABataev. Herald added subscribers: sunshaoce, guansong, yaxunl. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers:

[PATCH] D156366: HIP: Use __builtin_sqrt instead of routing through ocml sqrt for f64

jhuber6 accepted this revision. jhuber6 added a comment. This revision is now accepted and ready to land. Thanks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156366/new/ https://reviews.llvm.org/D156366 ___ cfe-commits mailing list

[PATCH] D153653: [clang][Interp] Make CXXTemporaryObjectExprs leave a value behind

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153653/new/ https://reviews.llvm.org/D153653 ___ cfe-commits mailing list

[clang] 08247d7 - [Driver][test] Fix continuation lines from debug-options.c

Author: Fangrui Song Date: 2023-07-26T13:47:39-07:00 New Revision: 08247d70711ad9472647ef4f948f1f67139e URL: https://github.com/llvm/llvm-project/commit/08247d70711ad9472647ef4f948f1f67139e DIFF: https://github.com/llvm/llvm-project/commit/08247d70711ad9472647ef4f948f1f67139e.diff

[PATCH] D153058: [clang][CFG] Support construction of a weak topological ordering of the CFG.

sammccall accepted this revision. sammccall added a comment. Thanks, this is much simpler! Just nits & apologies for the delay. Comment at: clang/include/clang/Analysis/Analyses/IntervalPartition.h:24 #include "llvm/ADT/DenseSet.h" +#include +#include some

[PATCH] D156212: [clang][Interp] Implement remaining strcmp builtins

shafik added inline comments. Comment at: clang/test/AST/Interp/builtin-functions.cpp:17 + static_assert(__builtin_strncmp("abaa", "abba", 1) == 0); + static_assert(__builtin_strncmp("abaa", "abba", 0) == 0); + static_assert(__builtin_strncmp(0, 0, 0) == 0);

[PATCH] D116910: [OpenMP][3/3] Introduce the KernelEnvironment into Clang tests

jdoerfert closed this revision. jdoerfert added a comment. Herald added subscribers: jplehr, sunshaoce, mattd. Herald added a project: All. Subsumed by D142569 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D155213: [HIP] Add `-fno-offload-uniform-block`

yaxunl updated this revision to Diff 544491. yaxunl edited the summary of this revision. yaxunl added a comment. make the option generic for offloading languages CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155213/new/ https://reviews.llvm.org/D155213 Files:

[PATCH] D156360: [clang-format] Support function and overloaded operator SpacesInParensOption

HazardyKnusperkeks added a comment. You need some tests to show that the new options really apply like intended. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156360/new/ https://reviews.llvm.org/D156360

[PATCH] D156360: [clang-format] Support function and overloaded operator SpacesInParensOption

gedare created this revision. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan, MyDeveloperDay. gedare requested review of this revision. This change separates function calls, declarations,

[clang] 380dbfd - Revert "Reapply [IR] Mark and/or constant expressions as undesirable"

Author: Matthew Voss Date: 2023-07-26T12:54:07-07:00 New Revision: 380dbfd8cab0c48c46c01b519b908c6ef4d6e775 URL: https://github.com/llvm/llvm-project/commit/380dbfd8cab0c48c46c01b519b908c6ef4d6e775 DIFF: https://github.com/llvm/llvm-project/commit/380dbfd8cab0c48c46c01b519b908c6ef4d6e775.diff

[PATCH] D156175: [clang][ConstExprEmitter] handle NullToPointer ImplicitCastExpr

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2c26397f76d9: [clang][ConstExprEmitter] handle NullToPointer ImplicitCastExpr (authored by nickdesaulniers). Repository: rG LLVM Github Monorepo

[clang] 2c26397 - [clang][ConstExprEmitter] handle NullToPointer ImplicitCastExpr

Author: Nick Desaulniers Date: 2023-07-26T12:53:02-07:00 New Revision: 2c26397f76d9b8d2a0dc8207eeca5b0d3216f3f0 URL: https://github.com/llvm/llvm-project/commit/2c26397f76d9b8d2a0dc8207eeca5b0d3216f3f0 DIFF:

[PATCH] D155870: [Clang][CodeGen] Another follow-up for `vtable`, `typeinfo` et al. are globals

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155870/new/ https://reviews.llvm.org/D155870 ___ cfe-commits mailing list

[PATCH] D155895: Anonymous unions should be transparent wrt `[[clang::trivial_abi]]`.

lukasza updated this revision to Diff 544478. lukasza added a comment. Rebasing... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155895/new/ https://reviews.llvm.org/D155895 Files: clang/include/clang/Basic/LangOptions.h clang/lib/Frontend/CompilerInvocation.cpp

[PATCH] D156322: Outputs parameter comments using clang-doc and markdown generator

BotellaA updated this revision to Diff 544477. BotellaA added a comment. Updated the expected result in the MD generator test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156322/new/ https://reviews.llvm.org/D156322 Files: clang-tools-extra/clang-doc/MDGenerator.cpp

[PATCH] D155895: Anonymous unions should be transparent wrt `[[clang::trivial_abi]]`.

lukasza updated this revision to Diff 544476. lukasza added a comment. Added support for `-fclang-abi-compat=17` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155895/new/ https://reviews.llvm.org/D155895 Files: clang/include/clang/Basic/LangOptions.h

[PATCH] D156277: [Parser][ObjC] Stop parsing on eof

rjmccall added inline comments. Comment at: clang/lib/Parse/ParseObjc.cpp:749 + if (!Tok.is(tok::eof)) +ConsumeToken(); break; aaron.ballman wrote: > rjmccall wrote: > > aaron.ballman wrote: > > > aaron.ballman wrote: > > > > danix800 wrote:

[PATCH] D138263: [clang-format] Supress aligning of trailing namespace comments

HazardyKnusperkeks added a comment. In D138263#4535269 , @MyDeveloperDay wrote: > In D138263#3936536 , > @HazardyKnusperkeks wrote: > >> In D138263#3936007 , @owenpan

[PATCH] D156259: Fix a bug that erroneously placed function arguments on a new line despite all arguments being able to fit on the same line.

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:263 State.StartOfStringLiteral = 0; + State.NoLineBreak = false; State.StartOfLineLevel = 0; jp4a50 wrote: > HazardyKnusperkeks wrote: > > Was this

[PATCH] D154911: Enabling fstack_clash_protection for arm32 bit, thumb and thumb2 mode

tnfchris added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3460 + } else if (EffectiveTriple.isArm() || EffectiveTriple.isThumb()) { +CmdArgs.push_back("-mstack-probe-size=1024"); + } efriedma wrote: > tnfchris wrote: > > efriedma

[PATCH] D156277: [Parser][ObjC] Stop parsing on eof

aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseObjc.cpp:749 + if (!Tok.is(tok::eof)) +ConsumeToken(); break; rjmccall wrote: > aaron.ballman wrote: > > aaron.ballman wrote: > > > danix800 wrote: > > > > tbaeder wrote: >

[PATCH] D155529: [clang-format] Add SpaceInParensOption for __attribute__ keyword

gedare updated this revision to Diff 544466. gedare added a comment. Rebase to 18 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155529/new/ https://reviews.llvm.org/D155529 Files: clang/docs/ClangFormatStyleOptions.rst

[PATCH] D155895: Anonymous unions should be transparent wrt `[[clang::trivial_abi]]`.

rsmith added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:10339-10343 + if (RT->getDecl()->isAnonymousStructOrUnion()) { +FieldsToCheck.append(RT->getDecl()->field_begin(), + RT->getDecl()->field_end()); +continue;

[PATCH] D156357: clang: Add elementwise bitreverse builtin

bob80905 updated this revision to Diff 544463. bob80905 added a comment. Herald added subscribers: wangpc, luke, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, niosHD, sabuasal,

[PATCH] D156357: clang: Add elementwise bitreverse builtin

bob80905 created this revision. Herald added a subscriber: Anastasia. Herald added a project: All. bob80905 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add codegen for llvm bitreverse elementwise builtin The bitreverse elementwise

[PATCH] D154130: [lit][clang] Avoid realpath on Windows due to MAX_PATH limitations

MrTrillian added a comment. Ping. Any brave reviewer to help here? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154130/new/ https://reviews.llvm.org/D154130 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D76096: [clang] allow const structs/unions/arrays to be constant expressions for C

nickdesaulniers added a comment. In D76096#4533497 , @efriedma wrote: > Basically, I don't want order-of-magnitude compile-time regressions with > large global variables. There are basically two components to that: > > - That the fast path for emitting

[PATCH] D156277: [Parser][ObjC] Stop parsing on eof

aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseObjc.cpp:749 + if (!Tok.is(tok::eof)) +ConsumeToken(); break; aaron.ballman wrote: > danix800 wrote: > > tbaeder wrote: > > > Why is there a `ConsumeToken()` call at all

[PATCH] D156277: [Parser][ObjC] Stop parsing on eof

rjmccall added inline comments. Comment at: clang/lib/Parse/ParseObjc.cpp:749 + if (!Tok.is(tok::eof)) +ConsumeToken(); break; aaron.ballman wrote: > danix800 wrote: > > tbaeder wrote: > > > Why is there a `ConsumeToken()` call at all here?

[PATCH] D156175: [clang][ConstExprEmitter] handle NullToPointer ImplicitCastExpr

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156175/new/ https://reviews.llvm.org/D156175

[PATCH] D156274: [NFC] Avoid potential dereferencing of nullptr.

aaron.ballman added inline comments. Comment at: clang/lib/AST/ItaniumMangle.cpp:1659 mangleCXXDtorType(Dtor_Complete); +assert(ND); writeAbiTags(ND, AdditionalAbiTags); efriedma wrote: > aaron.ballman wrote: > > This seems incorrect -- if the

[PATCH] D156274: [NFC] Avoid potential dereferencing of nullptr.

efriedma added inline comments. Comment at: clang/lib/AST/ItaniumMangle.cpp:1659 mangleCXXDtorType(Dtor_Complete); +assert(ND); writeAbiTags(ND, AdditionalAbiTags); aaron.ballman wrote: > This seems incorrect -- if the declaration name is a

[PATCH] D144634: [Clang][OpenMP] Support for Code Generation of loop bind clause

ABataev added inline comments. Comment at: clang/include/clang/AST/StmtOpenMP.h:291 + /// the frontend. + OpenMPDirectiveKind prevMappedDirective; + OpenMPDirectiveKind PrevMappedDirective = llvm::omp::OMPD_unknown; Comment at:

[PATCH] D156307: [clang][DeclPrinter] Fix AST print of curly constructor initializers

aaron.ballman added inline comments. Comment at: clang/test/AST/ast-print-method-decl.cpp:65 + // CHECK-NEXT: CurlyCtorInit() : a1({}), a2{}, b{} { + CurlyCtorInit() : a1({}), a2{}, b{} { + // CHECK-NEXT: } Can you add another ctor that uses round parens for

[PATCH] D156352: [OpenMP][Sema] Fix directive name modifier/if-clause/'target teams loop'

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7cb9698374ac: [OpenMP][Sema] Fix directive name modifier/if-clause/target teams loop (authored by ddpagan). Repository: rG LLVM Github Monorepo

[clang] 7cb9698 - [OpenMP][Sema] Fix directive name modifier/if-clause/'target teams loop'

Author: Dave Pagan Date: 2023-07-26T13:19:56-05:00 New Revision: 7cb9698374ac2eb4cb01dd1a866339e8aa409834 URL: https://github.com/llvm/llvm-project/commit/7cb9698374ac2eb4cb01dd1a866339e8aa409834 DIFF: https://github.com/llvm/llvm-project/commit/7cb9698374ac2eb4cb01dd1a866339e8aa409834.diff

[PATCH] D156307: [clang][DeclPrinter] Fix AST print of curly constructor initializers

shafik added a comment. Maybe add a designated init test in there as well e.g. struct A { int x {}; }; struct B { B() : a({.x = 1}) { } A a; }; Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156307/new/

[PATCH] D156352: [OpenMP][Sema] Fix directive name modifier/if-clause/'target teams loop'

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156352/new/ https://reviews.llvm.org/D156352

[PATCH] D156247: [Clang] Add a warning on uses of coroutine keywords

aaron.ballman added a comment. In D156247#4536034 , @tahonermann wrote: >> You are absolutely right, -fno-coroutines would totally work for us, had it >> been available. > > Good. Gcc handles `-fcoroutines` and `-fno-coroutines` as I would expect >

[PATCH] D156277: [Parser][ObjC] Stop parsing on eof

aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseObjc.cpp:749 + if (!Tok.is(tok::eof)) +ConsumeToken(); break; danix800 wrote: > tbaeder wrote: > > Why is there a `ConsumeToken()` call at all here? The token is already >

[PATCH] D156352: [OpenMP][Sema] Fix directive name modifier/if-clause/'target teams loop'

ddpagan created this revision. ddpagan added reviewers: ABataev, jdoerfert, ronlieb. ddpagan added projects: OpenMP, clang. Herald added subscribers: sunshaoce, guansong, yaxunl. Herald added a project: All. ddpagan requested review of this revision. Herald added subscribers: cfe-commits, jplehr,

[PATCH] D156344: Disable call to fma for soft-float

long5hot added a comment. Apologies for updating diff too many times, used arcanist first time. Won't happend again! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156344/new/ https://reviews.llvm.org/D156344 ___ cfe-commits mailing list

[PATCH] D154911: Enabling fstack_clash_protection for arm32 bit, thumb and thumb2 mode

efriedma added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3460 + } else if (EffectiveTriple.isArm() || EffectiveTriple.isThumb()) { +CmdArgs.push_back("-mstack-probe-size=1024"); + } tnfchris wrote: > efriedma wrote: > > Why 1024? >

[PATCH] D156351: clang driver throws error for -mabi=elfv2 or elfv2

long5hot created this revision. Herald added a project: All. long5hot requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. After clang release/16.x there is a regression that -mabi=elfv1 or -mabi=elfv2 are being unused and throws

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

Mordante added a comment. In D112921#4535716 , @wangpc wrote: > In D112921#4532378 , @Mordante > wrote: > >> In D112921#4530916 , @wangpc wrote: >> >>> In

[PATCH] D156344: Disable call to fma for soft-float

long5hot updated this revision to Diff 544438. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156344/new/ https://reviews.llvm.org/D156344 Files: llvm/lib/Target/PowerPC/PPCISelLowering.cpp llvm/test/CodeGen/PowerPC/ppcsoftops.ll Index: llvm/test/CodeGen/PowerPC/ppcsoftops.ll

  1   2   3   >