[PATCH] D155863: [X86][Regcall] Add an option to respect regcall ABI v.4 in win64

This revision was automatically updated to reflect the committed changes. Closed by commit rG6ee497aa0b48: [X86][Regcall] Add an option to respect regcall ABI v.4 in win64win32 (authored by yubing). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 6ee497a - [X86][Regcall] Add an option to respect regcall ABI v.4 in win64

Author: Bing1 Yu Date: 2023-08-03T13:58:33+08:00 New Revision: 6ee497aa0b48ad892447f29a90b4e61241949295 URL: https://github.com/llvm/llvm-project/commit/6ee497aa0b48ad892447f29a90b4e61241949295 DIFF: https://github.com/llvm/llvm-project/commit/6ee497aa0b48ad892447f29a90b4e61241949295.diff

[PATCH] D156655: [clang-format] Handle goto labels preceded by C++11 attributes

This revision was automatically updated to reflect the committed changes. Closed by commit rG70d7ea0cebcf: [clang-format] Handle goto labels preceded by C++11 attributes (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 70d7ea0 - [clang-format] Handle goto labels preceded by C++11 attributes

Author: Owen Pan Date: 2023-08-02T22:48:48-07:00 New Revision: 70d7ea0cebcf363cd0ddcfb76375fb5fada87dd5 URL: https://github.com/llvm/llvm-project/commit/70d7ea0cebcf363cd0ddcfb76375fb5fada87dd5 DIFF: https://github.com/llvm/llvm-project/commit/70d7ea0cebcf363cd0ddcfb76375fb5fada87dd5.diff

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

MaskRay added a comment. Herald added a subscriber: jplehr. If you continue this work, consider landing this rename in multiple phases, e.g. - Use lit substitutions instead of `flang-new` and other preparatory stuff so that the next step has very little change - change flang-new to flang and

[PATCH] D156693: [clang][ASTImporter]Skip check friend template declaration in VisitClassTemplateDecl

jcsxky updated this revision to Diff 546698. jcsxky added a comment. format code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156693/new/ https://reviews.llvm.org/D156693 Files: clang/lib/AST/ASTImporter.cpp

[clang] 1f3c1cb - [Parser][ObjC] Fix crash on nested top-level block with better recovery path

Author: dingfei Date: 2023-08-03T12:58:48+08:00 New Revision: 1f3c1cba49a1ace7d2813b3be69279df322c2db0 URL: https://github.com/llvm/llvm-project/commit/1f3c1cba49a1ace7d2813b3be69279df322c2db0 DIFF: https://github.com/llvm/llvm-project/commit/1f3c1cba49a1ace7d2813b3be69279df322c2db0.diff LOG:

[PATCH] D155145: [X86] Add AVX-VNNI-INT16 instructions.

anna added a comment. thank you @craig.topper and @pengfei . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155145/new/ https://reviews.llvm.org/D155145 ___ cfe-commits mailing list

[PATCH] D156933: [HLSL] Add reversebits library function

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe545392b1de3: [HLSL] Add reversebits library function (authored by bob80905). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] e545392 - [HLSL] Add reversebits library function

Author: Joshua Batista Date: 2023-08-02T20:50:40-07:00 New Revision: e545392b1de304d3bf2776f671cb7327e335b90b URL: https://github.com/llvm/llvm-project/commit/e545392b1de304d3bf2776f671cb7327e335b90b DIFF:

[PATCH] D152770: [clang][ExtractAPI] Add support for Objective-C categories

Ruturaj4 updated this revision to Diff 546683. Ruturaj4 added a comment. 1. Updating D152770 : [clang][ExtractAPI] Add support for Objective-C categories # 2. Enter a brief description of the changes included in this update. 3. The first line is used as

[PATCH] D152770: [clang][ExtractAPI] Add support for Objective-C categories

Ruturaj4 added inline comments. Comment at: clang/include/clang/ExtractAPI/ExtractAPIVisitor.h:488 + bool IsFromExternalModule = true; + for (const auto : API.getObjCInterfaces()) { +if (InterfaceDecl->getName() == Interface.second.get()->Name) { dang

[PATCH] D152770: [clang][ExtractAPI] Add support for Objective-C categories

Ruturaj4 updated this revision to Diff 546682. Ruturaj4 marked 4 inline comments as done. Ruturaj4 added a comment. 1. Updating D152770 : [clang][ExtractAPI] Add support for Objective-C categories # 2. Enter a brief description of the changes included in this

[PATCH] D155145: [X86] Add AVX-VNNI-INT16 instructions.

pengfei added a comment. In D155145#4556178 , @craig.topper wrote: > In D155145#4556157 , @anna wrote: > >> In D155145#4554786 , @anna wrote: >> Can you capture the

[PATCH] D156962: [Driver] Mark m_x86_Features_Group options as TargetSpecific

skan accepted this revision. skan added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156962/new/ https://reviews.llvm.org/D156962 ___

[PATCH] D138810: [RISCV] Support vector crypto extension C intrinsics

4vtomat updated this revision to Diff 546677. 4vtomat added a comment. Update missing comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138810/new/ https://reviews.llvm.org/D138810 Files: clang/include/clang/Basic/riscv_vector.td

[PATCH] D155145: [X86] Add AVX-VNNI-INT16 instructions.

craig.topper added a comment. In D155145#4556157 , @anna wrote: > In D155145#4554786 , @anna wrote: > >>> Can you capture the values of EAX, EBX, ECX, and EDX after the two calls to >>> getX86CpuIDAndInfoEx that

[PATCH] D155145: [X86] Add AVX-VNNI-INT16 instructions.

pengfei added a comment. In D155145#4556157 , @anna wrote: > In D155145#4554786 , @anna wrote: > >>> Can you capture the values of EAX, EBX, ECX, and EDX after the two calls to >>> getX86CpuIDAndInfoEx that have

[PATCH] D156962: [Driver] Mark m_x86_Features_Group options as TargetSpecific

MaskRay created this revision. MaskRay added reviewers: pengfei, skan, RKSimon. Herald added a subscriber: kristof.beyls. Herald added a project: All. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. so that they lead to an error

[PATCH] D155145: [X86] Add AVX-VNNI-INT16 instructions.

anna added a comment. In D155145#4554786 , @anna wrote: >> Can you capture the values of EAX, EBX, ECX, and EDX after the two calls to >> getX86CpuIDAndInfoEx that have 0x7 as the first argument? Maybe there's a >> bug in CPUID on Sandy Bridge. > >

[PATCH] D155145: [X86] Add AVX-VNNI-INT16 instructions.

pengfei added a comment. Thanks @anna and @craig.topper I think we can dump the value with the simple code $ cat cpuid.c #include #include int main() { unsigned int info[4]; for (int i = 0; i < 2; ++i) { __get_cpuid_count(7, 1, info, info + 1, info + 2, info + 3);

[PATCH] D138810: [RISCV] Support vector crypto extension C intrinsics

4vtomat added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:2405 + defvar suffix = !if(IsVV, "vv", "vi"); + defvar prototype = !if(IsVV, "UvUvUvUv", "UvUvUvKz"); + defm "" : RVVBuiltinSet; craig.topper wrote: > Can we split this into

[PATCH] D138810: [RISCV] Support vector crypto extension C intrinsics

4vtomat updated this revision to Diff 546671. 4vtomat marked 3 inline comments as done. 4vtomat added a comment. This update does a few things: 1. Update Craig's comments. 2. Make `LMUL=8` valid(https://github.com/riscv-non-isa/rvv-intrinsic-doc/pull/234#discussion_r1282568330). 3. Rebase.

[PATCH] D156441: [clangd]Fix addUsing tweak doesn't traverse same-level anon namespaces

chouzz added a comment. @kadircet Could you please take a look this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156441/new/ https://reviews.llvm.org/D156441 ___ cfe-commits mailing list

[PATCH] D155850: [Clang][CodeGen][RFC] Add codegen support for C++ Parallel Algorithm Offload

AlexVlx added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:5315 + !GV->isThreadLocal() && + !(getLangOpts().HIPStdPar && getLangOpts().CUDAIsDevice)) { if (D->getTLSKind() == VarDecl::TLS_Dynamic) efriedma wrote: > You can't

[PATCH] D156466: [clang][CGExprConstant] handle implicit widening/narrowing Int-to-Int casts

nickdesaulniers updated this revision to Diff 546646. nickdesaulniers edited the summary of this revision. nickdesaulniers added a comment. - update description Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156466/new/

[PATCH] D156466: [clang][CGExprConstant] handle implicit widening/narrowing Int-to-Int casts

nickdesaulniers updated this revision to Diff 546645. nickdesaulniers marked an inline comment as done. nickdesaulniers added a comment. - add test case that would have caught SExt bug - fix SExt bug Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D153924: Allowing exception handling in OpenMP target regions when offloading to AMDGCN or NVPTX targets

AntonRydahl added inline comments. Comment at: clang/include/clang/Basic/DiagnosticCommonKinds.td:432 + "Target '%0' does not support exception handling." + " To allow code generation for '%0', 'catch' statement will be replaced by a no operation instruction.">; }

[PATCH] D153924: Allowing exception handling in OpenMP target regions when offloading to AMDGCN or NVPTX targets

AntonRydahl marked 2 inline comments as done. AntonRydahl added inline comments. Comment at: clang/lib/CodeGen/CGException.cpp:624 + const bool is_omp_gpu_target = + (CGM.getLangOpts().OpenMPIsDevice && (T.isNVPTX() || T.isAMDGCN())); + if (is_omp_gpu_target) {

[PATCH] D155850: [Clang][CodeGen][RFC] Add codegen support for C++ Parallel Algorithm Offload

efriedma added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:5559 +return EmitStdParUnsupportedBuiltin(this, FD); + else +ErrorUnsupported(E, "builtin function"); Else-after-return. Comment at:

[PATCH] D156948: [clang][modules] Add -Wsystem-headers-in-module=

benlangmuir created this revision. benlangmuir added reviewers: jansvoboda11, iana. Herald added a project: All. benlangmuir requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Add a way to enable -Wsystem-headers only for a specific

[PATCH] D153924: Allowing exception handling in OpenMP target regions when offloading to AMDGCN or NVPTX targets

AntonRydahl updated this revision to Diff 546636. AntonRydahl added a comment. Herald added subscribers: wangpc, kerbowa, jvesely. Updated the tests to use `%clang_cc1 -verify`. There are still things that need to be improved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D153557: [clang][ExtractAPI] Add support for C++ classes

evelez7 updated this revision to Diff 546635. evelez7 added a comment. Reintroduce fix from f4de606ef271 and use clang frontend for C++ tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D156378: [clang][CGExprConstant] handle unary negation on integrals

nickdesaulniers updated this revision to Diff 546634. nickdesaulniers marked an inline comment as done. nickdesaulniers added a comment. - prefer VisitUnaryMinus as per @efriedma Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156378/new/

[PATCH] D156172: [clang][CodeGen] Emit annotations for function declarations.

brendandahl updated this revision to Diff 546632. brendandahl added a comment. Switch to emitting annotations and the end. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156172/new/ https://reviews.llvm.org/D156172 Files:

[PATCH] D156482: [clang][CGExprConstant] handle FunctionToPointerDecay

efriedma added inline comments. Comment at: clang/lib/CodeGen/CGExprConstant.cpp:1128 +case CK_NoOp: +case CK_NonAtomicToAtomic: return Visit(subExpr, destType); I think I'd prefer to continue treating an undecayed function as an "lvalue", to

[PATCH] D156466: [clang][CGExprConstant] handle implicit widening/narrowing Int-to-Int casts

efriedma added inline comments. Comment at: clang/lib/CodeGen/CGExprConstant.cpp:1152 + return CI; +llvm::APInt A = CI->getValue().sextOrTrunc(DstWidth); +return llvm::ConstantInt::get(CGM.getLLVMContext(), A); sextOrTrunc()

[PATCH] D156378: [clang][CGExprConstant] handle unary negation on integrals

efriedma added inline comments. Comment at: clang/lib/CodeGen/CGExprConstant.cpp:1366 + llvm::Constant *VisitUnaryOperator(UnaryOperator *U, QualType T) { +switch (U->getOpcode()) { StmtVisitor supports defining a function "VisitUnaryMinus", so you don't

[PATCH] D153557: [clang][ExtractAPI] Add support for C++ classes

haowei added a comment. FYI, this patch fails the Windows bots in a different way. (you can see the error triggered in the pre-merge build in https://buildkite.com/llvm-project/premerge-checks/builds/161603#018909c4-fe90-4de6-91a3-d251dc5ada8f) The error message from our builders are:

[PATCH] D153557: [clang][ExtractAPI] Add support for C++ classes

evelez7 added a comment. @haowei Thank you for letting me know! That patch does seem to fix it, unfortunately it didn't fail on my end. Thanks again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153557/new/ https://reviews.llvm.org/D153557

[PATCH] D76096: [clang] allow const structs/unions/arrays to be constant expressions for C

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG610ec954e1f8: [clang] allow const structs/unions/arrays to be constant expressions for C (authored by nickdesaulniers). Repository: rG LLVM

[clang] 610ec95 - [clang] allow const structs/unions/arrays to be constant expressions for C

Author: Nick Desaulniers Date: 2023-08-02T15:32:37-07:00 New Revision: 610ec954e1f81c0e8fcadedcd25afe643f5a094e URL: https://github.com/llvm/llvm-project/commit/610ec954e1f81c0e8fcadedcd25afe643f5a094e DIFF:

[PATCH] D156936: [Clang] Increase default architecture from sm_35 to sm_52

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGab202aa7004a: [Clang] Increase default architecture from sm_35 to sm_52 (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES

[clang] ab202aa - [Clang] Increase default architecture from sm_35 to sm_52

Author: Joseph Huber Date: 2023-08-02T17:30:23-05:00 New Revision: ab202aa7004a451ee9f496505256cfcb94d71747 URL: https://github.com/llvm/llvm-project/commit/ab202aa7004a451ee9f496505256cfcb94d71747 DIFF: https://github.com/llvm/llvm-project/commit/ab202aa7004a451ee9f496505256cfcb94d71747.diff

[PATCH] D147283: [Sema] Search template parameter scopes before searching namespace/file scopes when performing unqualified name lookup

ahatanak added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147283/new/ https://reviews.llvm.org/D147283 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D156901: [OpenMP] Change OpenMP default version in documentation and help text for -fopenmp-version

clementval added inline comments. Comment at: flang/test/Driver/driver-help.f90:55 ! HELP-NEXT: -fopenmp-version= -! HELP-NEXT:Set OpenMP version (e.g. 45 for OpenMP 4.5, 50 for OpenMP 5.0). Default value is 50 for Clang and 11 for Flang +! HELP-NEXT:

[PATCH] D156901: [OpenMP] Change OpenMP default version in documentation and help text for -fopenmp-version

jdoerfert added inline comments. Comment at: flang/test/Driver/driver-help.f90:55 ! HELP-NEXT: -fopenmp-version= -! HELP-NEXT:Set OpenMP version (e.g. 45 for OpenMP 4.5, 50 for OpenMP 5.0). Default value is 50 for Clang and 11 for Flang +! HELP-NEXT:

[PATCH] D156933: [HLSL] Add reversebits library function

bob80905 updated this revision to Diff 546618. bob80905 added a comment. - remove fnative half type from run line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156933/new/ https://reviews.llvm.org/D156933 Files:

[PATCH] D156925: [Driver] Don't try to spell check unsupported options

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7ef1718c4d4e: [Driver] Dont try to spell check unsupported options (authored by bogner). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 7ef1718 - [Driver] Don't try to spell check unsupported options

Author: Justin Bogner Date: 2023-08-02T14:23:14-07:00 New Revision: 7ef1718c4d4ecd99f3ba48236f7fd4fd9ffb540c URL: https://github.com/llvm/llvm-project/commit/7ef1718c4d4ecd99f3ba48236f7fd4fd9ffb540c DIFF: https://github.com/llvm/llvm-project/commit/7ef1718c4d4ecd99f3ba48236f7fd4fd9ffb540c.diff

[PATCH] D156506: [clang][Interp] Check floating results for NaNs

jcranmer-intel added a comment. You definitely don't want these rules to apply to all qNaNs. It's when an input operand is an sNaN for many operations. Note that the result of an operation with an sNaN as input (and FP result type) is a qNaN output, and the only times that you get an sNaN

[PATCH] D141918: WIP: [Clang] Emit 'unwindabort' when applicable.

jyknight updated this revision to Diff 546613. jyknight edited the summary of this revision. jyknight added a comment. Rebase patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141918/new/ https://reviews.llvm.org/D141918 Files:

[PATCH] D156933: [HLSL] Add reversebits library function

python3kgae accepted this revision. python3kgae added a comment. This revision is now accepted and ready to land. Don't need -fnative-half-type in the RUN line. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156933/new/

[PATCH] D156925: [Driver] Don't try to spell check unsupported options

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Looks great! We've had `def _ : Joined<"--">` since commit 46fffee081b583a617fa94397b0c758bdf3a4a80 (2009) when TableGen based options were introduced. Due to it, the error messages are

[PATCH] D156474: [-Wunsafe-buffer-usage][NFC] Slightly refactor and optimize the code

t-rasmud accepted this revision. t-rasmud added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:2179 + if (FixItsForVariable.count(GrpMate)) +

[PATCH] D156234: [clang][deps] add support for dependency scanning with cc1 command line

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM after Windows CI gets fixed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156234/new/ https://reviews.llvm.org/D156234

[PATCH] D156474: [-Wunsafe-buffer-usage][NFC] Slightly refactor and optimize the code

ziqingluo-90 added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:2179 + if (FixItsForVariable.count(GrpMate)) +FinalFixItsForVariable[Var].insert(FinalFixItsForVariable[Var].end(), +

[PATCH] D153557: [clang][ExtractAPI] Add support for C++ classes

haowei added a comment. Thanks for reverting. I wasn't doing any changes to this when you were asking though, but looking at build log, it looks like the assertion error disappeared after f4de606ef271fe362f03d30c53a850f9877ec238

[PATCH] D156936: [Clang] Increase default architecture from sm_35 to sm_52

jhuber6 created this revision. jhuber6 added reviewers: tra, jdoerfert, yaxunl, jlebar. Herald added a project: All. jhuber6 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We previously defaulted to `sm_35` for the purpose of unspecified

[PATCH] D156933: [HLSL] Add reversebits library function

bob80905 updated this revision to Diff 546585. bob80905 added a comment. - rename file, make merge 2 Runs into 1 with enable16bit defined Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156933/new/ https://reviews.llvm.org/D156933 Files:

[PATCH] D156861: [Driver] Remove references to Solaris 12

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. While you are modifying the lines `static const char ...[]` should look better than `static const char *const SolarisX86Triples[]` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D156935: [HIP] Fix test rocm-detect.hip

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG590d7e266426: [HIP] Fix test rocm-detect.hip (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES

[clang] 590d7e2 - [HIP] Fix test rocm-detect.hip

Author: Yaxun (Sam) Liu Date: 2023-08-02T16:12:54-04:00 New Revision: 590d7e2664260d5ceef77be03cdc3564e0f57f72 URL: https://github.com/llvm/llvm-project/commit/590d7e2664260d5ceef77be03cdc3564e0f57f72 DIFF:

[clang] 61f3ce7 - [Driver] Change some group DocName from "flags" to "options"

Author: Fangrui Song Date: 2023-08-02T13:07:26-07:00 New Revision: 61f3ce7bb305d875bca4c7f22aaaf0940602448b URL: https://github.com/llvm/llvm-project/commit/61f3ce7bb305d875bca4c7f22aaaf0940602448b DIFF: https://github.com/llvm/llvm-project/commit/61f3ce7bb305d875bca4c7f22aaaf0940602448b.diff

[PATCH] D156935: [HIP] Fix test rocm-detect.hip

yaxunl created this revision. yaxunl added reviewers: tra, MaskRay, jhuber6. Herald added a project: All. yaxunl requested review of this revision. Two run lines fail due to missing device libs for gfx902, which are fixed by using gfx1010 which has device lib. The other two spack tests have to

[PATCH] D153557: [clang][ExtractAPI] Add support for C++ classes

evelez7 added a comment. In D153557#4554980 , @haowei wrote: > Hi, we are seeing a test error on `Clang :: > ExtractAPI/constructor_destructor.cpp` after this patch was landed. Error > message: Hi! Sorry about that, I see you've made some changes. Do

[PATCH] D156901: [OpenMP] Change OpenMP default version in documentation and help text for -fopenmp-version

tianshilei1992 added inline comments. Comment at: flang/test/Driver/driver-help.f90:55 ! HELP-NEXT: -fopenmp-version= -! HELP-NEXT:Set OpenMP version (e.g. 45 for OpenMP 4.5, 50 for OpenMP 5.0). Default value is 50 for Clang and 11 for Flang +!

[PATCH] D156901: [OpenMP] Change OpenMP default version in documentation and help text for -fopenmp-version

clementval added inline comments. Comment at: flang/test/Driver/driver-help.f90:55 ! HELP-NEXT: -fopenmp-version= -! HELP-NEXT:Set OpenMP version (e.g. 45 for OpenMP 4.5, 50 for OpenMP 5.0). Default value is 50 for Clang and 11 for Flang +! HELP-NEXT:

[PATCH] D156933: [HLSL] Add reversebits library function

python3kgae added inline comments. Comment at: clang/test/CodeGenHLSL/builtins/bitreverse.hlsl:32 +// CHECK: call <4 x i16> @llvm.bitreverse.v4i16 +// NO_HALF: define noundef <4 x i16> @"?test_bitreverse_short4@@YAT?$__vector@F$03@__clang@@T12@@Z"( +// NO_HALF: call <4 x i16>

[PATCH] D156930: [Clang] Fix Offloading related tests after D156363

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbc080221b3a2: [Clang] Fix Offloading related tests after D156363 (authored by jhuber6). Changed prior to commit:

[clang] bc08022 - [Clang] Fix Offloading related tests after D156363

Author: Joseph Huber Date: 2023-08-02T14:34:51-05:00 New Revision: bc080221b3a2c73739caa2bf0521dd3984d0a934 URL: https://github.com/llvm/llvm-project/commit/bc080221b3a2c73739caa2bf0521dd3984d0a934 DIFF: https://github.com/llvm/llvm-project/commit/bc080221b3a2c73739caa2bf0521dd3984d0a934.diff

[PATCH] D156933: [HLSL] Add bitreverse library function

bob80905 updated this revision to Diff 546576. bob80905 added a comment. - change builtin name to reversebits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156933/new/ https://reviews.llvm.org/D156933 Files:

[PATCH] D156933: [HLSL] Add bitreverse library function

bob80905 created this revision. Herald added a subscriber: Anastasia. Herald added a project: All. bob80905 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D156933 Files:

[PATCH] D156556: [AggressiveInstCombine][NFC] Fix typo

goldstein.w.n accepted this revision. goldstein.w.n added a comment. This revision is now accepted and ready to land. In D156556#4555036 , @kitaisreal wrote: > In D156556#4554436 , @goldstein.w.n > wrote: > >>

[PATCH] D156928: [Clang][AMDGPU] Fix handling of -mcode-object-version=none arg

jhuber6 added a comment. In D156928#4555121 , @yaxunl wrote: > `-mcode-object-version=none` was intentionally designed to work with `clang > -cc1` only, since it does not work with clang driver if users link with > device library. Device library can

[PATCH] D156928: [Clang][AMDGPU] Fix handling of -mcode-object-version=none arg

yaxunl added a comment. `-mcode-object-version=none` was intentionally designed to work with `clang -cc1` only, since it does not work with clang driver if users link with device library. Device library can still use it by using it with `-Xclang`. Repository: rG LLVM Github Monorepo

[PATCH] D156363: [Driver] -###: exit with code 1 if hasErrorOccurred

ro added a comment. In D156363#4554884 , @MaskRay wrote: > In D156363#4554812 , @jhuber6 wrote: > >> >> Probably because we're not specifying the `--target=` I'll add that in my >> fix for AMDGPU I'm working

[PATCH] D156277: [Parser][ObjC] Fix parser crash on nested top-level block with better recovery path

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. Small wording suggestion for the comment, but feel free to commit with that change. Comment at: clang/lib/Parse/ParseObjc.cpp:742 -// Eat the identifier. +

[PATCH] D156930: [Clang] Fix Offloading related tests after D156363

yaxunl accepted this revision. yaxunl added a comment. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156930/new/ https://reviews.llvm.org/D156930 ___ cfe-commits mailing list

[PATCH] D156930: [Clang] Fix Offloading related tests after D156363

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Thanks! I guess `--rocm-path=` can be used in some places, but `-nogpulib -nogpuinc` is good as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 2e65a42 - [Driver][test] Ensure --target= for -flto commands

Author: Fangrui Song Date: 2023-08-02T11:57:02-07:00 New Revision: 2e65a423e277b40a885b9de8a2cbf60f2f812cd6 URL: https://github.com/llvm/llvm-project/commit/2e65a423e277b40a885b9de8a2cbf60f2f812cd6 DIFF: https://github.com/llvm/llvm-project/commit/2e65a423e277b40a885b9de8a2cbf60f2f812cd6.diff

[PATCH] D156928: [Clang][AMDGPU] Fix handling of -mcode-object-version=none arg

jhuber6 added inline comments. Comment at: clang/include/clang/Basic/TargetOptions.h:90 +COV_Default = 400, +COV_MAX = 500 }; Typically we just put a `COV_LAST` to indicate that it's over the accepted enumerations. Comment at:

[PATCH] D156556: [AggressiveInstCombine][NFC] Fix typo

kitaisreal added a comment. In D156556#4554436 , @goldstein.w.n wrote: > Can you mark the title as NFC? It seems that title of revision is "[AggressiveInstCombine][NFC] Fix typo". Do you mean to put NFC at the beginning ? Repository: rG LLVM

[PATCH] D156930: [Clang] Fix Offloading related tests after D156363

jhuber6 created this revision. jhuber6 added reviewers: MaskRay, yaxunl, JonChesterfield, tra, jdoerfert, ronlieb, jplehr. Herald added subscribers: mattd, asavonic, ormris, kerbowa, steven_wu, hiraditya, jvesely. Herald added a project: All. jhuber6 requested review of this revision. Herald

[clang] f4de606 - fix use-after-free introduced in 8b76b44e46ac

Author: Augie Fackler Date: 2023-08-02T14:38:08-04:00 New Revision: f4de606ef271fe362f03d30c53a850f9877ec238 URL: https://github.com/llvm/llvm-project/commit/f4de606ef271fe362f03d30c53a850f9877ec238 DIFF: https://github.com/llvm/llvm-project/commit/f4de606ef271fe362f03d30c53a850f9877ec238.diff

[PATCH] D156928: [Clang][AMDGPU] Fix handling of -mcode-object-version=none arg

arsenm added a comment. missing tests Comment at: clang/lib/Driver/ToolChains/Clang.cpp:1066 +if (!IsCC1As) { + std::string CodeObjVerStr = (CodeObjVer ? Twine(CodeObjVer) : "none").str(); CmdArgs.insert(CmdArgs.begin() + 1, don't need to go

[clang] 11b7ce2 - [ASanStableABI][Driver] Stop linking to asan dylib when stable abi is enabled

Author: Blue Gaston Date: 2023-08-02T11:30:29-07:00 New Revision: 11b7ce26f2a22ca147feaaf1cfd2d21b85fc3d83 URL: https://github.com/llvm/llvm-project/commit/11b7ce26f2a22ca147feaaf1cfd2d21b85fc3d83 DIFF: https://github.com/llvm/llvm-project/commit/11b7ce26f2a22ca147feaaf1cfd2d21b85fc3d83.diff

[PATCH] D156718: [ASanStableABI][Driver] Stop linking to asan dylib when stable abi is enabled

This revision was automatically updated to reflect the committed changes. Closed by commit rG11b7ce26f2a2: [ASanStableABI][Driver] Stop linking to asan dylib when stable abi is enabled (authored by Blue Gaston bgast...@apple.com). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D156928: [Clang][AMDGPU] Fix handling of -mcode-object-version=none arg

saiislam created this revision. saiislam added reviewers: jhuber6, yaxunl. Herald added subscribers: tpr, dstuttard, kzhuravl. Herald added a project: All. saiislam requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, wdng. Herald added a project: clang.

[PATCH] D153557: [clang][ExtractAPI] Add support for C++ classes

haowei added a comment. Hi, we are seeing a test error on `Clang :: ExtractAPI/constructor_destructor.cpp` after this patch was landed. Error message: Script: -- : 'RUN: at line 1'; rm -rf /b/s/w/ir/x/w/llvm_build/tools/clang/test/ExtractAPI/Output/constructor_destructor.cpp.tmp :

[PATCH] D156363: [Driver] -###: exit with code 1 if hasErrorOccurred

jhuber6 added a comment. In D156363#4554913 , @yaxunl wrote: > Thanks. I will wait for your patch. You can leave the tricky ones to me if > you would like. e.g. the rocm-detect.hip You can go ahead and fix that one then. Repository: rG LLVM Github

[PATCH] D156925: [Driver] Don't try to spell check unsupported options

bogner created this revision. bogner added reviewers: Bigcheese, MaskRay. Herald added a subscriber: mcrosier. Herald added a reviewer: sscalpone. Herald added a reviewer: awarzynski. Herald added projects: Flang, All. bogner requested review of this revision. Herald added subscribers:

[PATCH] D156363: [Driver] -###: exit with code 1 if hasErrorOccurred

yaxunl added a comment. In D156363#4554693 , @jhuber6 wrote: > In D156363#4554687 , @yaxunl wrote: > >> In D156363#4554435 , @jhuber6 >> wrote: >> >>> Clang ::

[PATCH] D156363: [Driver] -###: exit with code 1 if hasErrorOccurred

MaskRay added a comment. In D156363#4554812 , @jhuber6 wrote: > In D156363#4554790 , @ro wrote: > >> In D156363#4553043 , @ro wrote: >> >>> It seems the latest commit of

[PATCH] D76096: [clang] allow const structs/unions/arrays to be constant expressions for C

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. In D76096#4540442 , @nickdesaulniers wrote: > Consider the following code: > > long x [] = {1, 2, 3, 4, 5 + 4}; > > Even with some of my recent

[PATCH] D138810: [RISCV] Support vector crypto extension C intrinsics

craig.topper added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:4496 +static bool CheckInValidEGW(const TargetInfo , CallExpr *TheCall, Sema , +QualType Type, int EGW) { InValid -> Invalid Comment

[PATCH] D155809: [NFC] [Clang] Fix strict weak ordering in ItaniumVTableBuilder

MaskRay added a comment. I think `assert((A == B || (A->getOverloadedOperator() == OO_EqualEqual && B->getOverloadedOperator() == OO_EqualEqual)) && ...);` would look better , but the current form is fine as well. > You will see 2 failures in >

[PATCH] D156363: [Driver] -###: exit with code 1 if hasErrorOccurred

jhuber6 added a comment. In D156363#4554790 , @ro wrote: > In D156363#4553043 , @ro wrote: > >> It seems the latest commit of this patch has (re-)introduced two failures on >> the Solaris/amd64 buildbot >>

[PATCH] D156363: [Driver] -###: exit with code 1 if hasErrorOccurred

ro added a comment. In D156363#4553043 , @ro wrote: > It seems the latest commit of this patch has (re-)introduced two failures on > the Solaris/amd64 buildbot > : > > FAIL:

[PATCH] D155145: [X86] Add AVX-VNNI-INT16 instructions.

anna added a comment. > Can you capture the values of EAX, EBX, ECX, and EDX after the two calls to > getX86CpuIDAndInfoEx that have 0x7 as the first argument? Maybe there's a bug > in CPUID on Sandy Bridge. Sure, on the original code before the patch you suggested right? The two calls are:

  1   2   3   >