[PATCH] D157201: [Clang] Support qualified name as member designator in offsetof

yichi170 added inline comments. Comment at: clang/test/SemaCXX/offsetof.cpp:106 +int x3[__builtin_offsetof(struct X2, X2::static_a) == 0 ? 1 : -1]; // expected-error{{no member named 'static_a'}} +int x4[__builtin_offsetof(struct X2, X2::X2) == 0 ? 1 : -1]; //

[PATCH] D152793: [RISCV] Add MC layer support for Zicfiss.

fakepaper56 planned changes to this revision. fakepaper56 added a comment. Herald added a subscriber: sunshaoce. The spec does some change, I need to sync with the spec. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152793/new/

[PATCH] D158152: [clang-tidy]mark record initList as non-const param

HerrCai0907 updated this revision to Diff 551802. HerrCai0907 added a comment. fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158152/new/ https://reviews.llvm.org/D158152 Files:

[PATCH] D156821: [CodeGen] [ubsan] Respect integer overflow handling in abs builtin

MaskRay added a comment. In D156821#4600605 , @craig.topper wrote: > In D156821#4600550 , @MaskRay wrote: > >>> Currenly both Clang and GCC support the following set of flags that control >> >> code gen of

[clang] 8b6f09e - Revert "[clang][X86] Add __cpuidex function to cpuid.h"

Author: Aiden Grossman Date: 2023-08-19T17:18:10-07:00 New Revision: 8b6f09e257b521947b50761737290e5bf31c80f3 URL: https://github.com/llvm/llvm-project/commit/8b6f09e257b521947b50761737290e5bf31c80f3 DIFF:

[clang] 58696d2 - [clang][X86] Add __cpuidex function to cpuid.h

Author: Aiden Grossman Date: 2023-08-19T17:12:23-07:00 New Revision: 58696d2f5bbae32dddcaec6891293e769465e77c URL: https://github.com/llvm/llvm-project/commit/58696d2f5bbae32dddcaec6891293e769465e77c DIFF:

[PATCH] D149867: [Clang][M68k] Add Clang support for the new M68k_RTD CC

myhsu added inline comments. Comment at: clang/test/Sema/m68k-mrtd.c:4-9 +#ifdef MRTD +// expected-error@+3 {{function with no prototype cannot use the m68k_rtd calling convention}} +#endif +void foo(int arg) { + bar(arg); +} aaron.ballman wrote: > myhsu

[PATCH] D149867: [Clang][M68k] Add Clang support for the new M68k_RTD CC

myhsu updated this revision to Diff 551797. myhsu marked 4 inline comments as done. myhsu added a comment. - Add more C++ tests for `m68k_rtd`, both Sema and CodeGen ones - Addressed other comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149867/new/

[PATCH] D158231: [clang][test] Fix clang machine-function-split tests

MaskRay resigned from this revision. MaskRay added a comment. This revision now requires review to proceed. Sorry, after reading through D157750 , I think the patch should be reverted. Comment at:

[PATCH] D158346: [clang-tidy] [readability-container-size-empty] improved check to detect missing usage of .empty() on string_literals Fixes #64547

felix642 updated this revision to Diff 551789. felix642 added a comment. Clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158346/new/ https://reviews.llvm.org/D158346 Files:

[PATCH] D158346: [clang-tidy] [readability-container-size-empty] improved check to detect missing usage of .empty() on string_literals Fixes #64547

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. LGTM, run clang-format on this code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158346/new/ https://reviews.llvm.org/D158346

[PATCH] D158329: [X86] Support arch=x86-64{,-v2,-v3,-v4} for target_clones attribute

MaskRay added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:13278 +llvm::Value * +CodeGenFunction::EmitX86CpuSupports(std::array FeatureMask) { Value *Result = Builder.getTrue(); erichkeane wrote: > Hmm... I guess size-wise this is on the edge

[PATCH] D158329: [X86] Support arch=x86-64{,-v2,-v3,-v4} for target_clones attribute

MaskRay updated this revision to Diff 551787. MaskRay marked 4 inline comments as done. MaskRay added a comment. Use Lo_32/Hi_32 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158329/new/ https://reviews.llvm.org/D158329 Files:

[PATCH] D158309: [flang][driver] Mark -Wl as visible in Flang

kiranchandramohan accepted this revision. kiranchandramohan added a comment. This revision is now accepted and ready to land. LG. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158309/new/ https://reviews.llvm.org/D158309

[PATCH] D158348: [clang][X86] Add __cpuidex function to cpuid.h

aidengrossman added reviewers: aaron.ballman, glandium, mstorsjo, craig.topper. aidengrossman added a comment. This is an updated version of https://reviews.llvm.org/D150646 that uses `__has_builtin` instead of checking for a definition of `_MSC_EXTENSIONS`. This fixes the cases that I have

[PATCH] D158348: [clang][X86] Add __cpuidex function to cpuid.h

aidengrossman created this revision. Herald added a project: All. aidengrossman requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, jplehr, sstefan1. Herald added a project: clang. MSVC has a __cpuidex function implemented to call the

[PATCH] D158346: [clang-tidy] [readability-container-size-empty] improved check to detect missing usage of .empty() on string_literals Fixes #64547

felix642 marked 2 inline comments as done. felix642 added a comment. Hi @PiotrZSL, thank you for the feedback. I have addressed most of your comments, but I'm not sure to understand what you mean by "Commit/Change description should be updated". Would you be able to clarify that for me?

[PATCH] D158346: [clang-tidy] [readability-container-size-empty] improved check to detect missing usage of .empty() on string_literals Fixes #64547

felix642 updated this revision to Diff 551785. felix642 added a comment. Fixed tests and addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158346/new/ https://reviews.llvm.org/D158346 Files:

[PATCH] D153924: [OpenMP] Allow exceptions in target regions when offloading to GPUs

jhuber6 added inline comments. Comment at: clang/test/OpenMP/amdgpu_exceptions.cpp:11 +// RUN: %clang_cc1 -fopenmp -triple amdgcn-amd-amdhsa -fopenmp-is-target-device -fexceptions %s -emit-llvm -S -verify=with -Wopenmp-target-exception -o - &> /dev/null +// RUN: %clang_cc1

[PATCH] D158338: [clang-tidy] [bugprone-implicit-widening-of-multiplication-result] Improved check to ignore false positives with integer literals.

PiotrZSL added a comment. Yes doing some basic calculations would be probably the best, but for that we would need to implement some "calculator" or find some exist implementation some're in clang. Even if it would support only basic operations like * Repository: rG LLVM Github Monorepo

[PATCH] D158338: [clang-tidy] [bugprone-implicit-widening-of-multiplication-result] Improved check to ignore false positives with integer literals.

felix642 added a comment. Hi @PiotrZSL thank you for taking the time to look at this revision. I agree with you we should not silence a warning if no other tool can diagnose the issue. I'm guessing that -Winteger-overflow does no trigger any warning on unsigned "overflow" since behavior is

[PATCH] D158346: [clang-tidy] [readability-container-size-empty] improved check to detect missing usage of .empty() on string_literals Fixes #64547

PiotrZSL requested changes to this revision. PiotrZSL added a comment. This revision now requires changes to proceed. - Release notes entry is missing. - Commit/Change description should be updated Comment at:

[PATCH] D158346: [clang-tidy] [readability-container-size-empty] improved check to detect missing usage of .empty() on string_literals Fixes #64547

felix642 created this revision. Herald added subscribers: PiotrZSL, carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. felix642 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Repository:

[PATCH] D158301: Add back overriding-t-options for -m-version-min diagnostic

dexonsmith added inline comments. Comment at: clang/test/Driver/darwin-version.c:217 // RUN: FileCheck --check-prefix=CHECK-VERSION-TNO-OSV1 %s -// CHECK-VERSION-TNO-OSV1: overriding '-mmacos-version-min=10.6' option with '-target x86_64-apple-macos10.11.2' +//

[PATCH] D153298: [clang-tidy] Extend bugprone-exception-escape diagnostics

PiotrZSL abandoned this revision. PiotrZSL marked 4 inline comments as done. PiotrZSL added a comment. I do not plan to work on this check anymore, sorry for a wasted time. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153298/new/

[PATCH] D148461: [clang-tidy] Support C++17/20 in bugprone-exception-escape

PiotrZSL abandoned this revision. PiotrZSL added a comment. I do not plan to work on this check anymore, sorry for a wasted time. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148461/new/ https://reviews.llvm.org/D148461

[PATCH] D148461: [clang-tidy] Support C++17/20 in bugprone-exception-escape

isuckatcs added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/ExceptionAnalyzer.cpp:306 + + if (From->isMemberPointerType() || To->isMemberPointerType()) return false; PiotrZSL wrote: > isuckatcs wrote: > > isuckatcs wrote: > > >

[PATCH] D153924: [OpenMP] Allow exceptions in target regions when offloading to GPUs

jdoerfert added a comment. I think this is basically done, one question though. Comment at: clang/test/OpenMP/amdgpu_exceptions.cpp:11 +// RUN: %clang_cc1 -fopenmp -triple amdgcn-amd-amdhsa -fopenmp-is-target-device -fexceptions %s -emit-llvm -S -verify=with

[PATCH] D158329: [X86] Support arch=x86-64{,-v2,-v3,-v4} for target_clones attribute

erichkeane added a comment. Cant help with the RT/LLVM parts, but the clang parts are pretty much right. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:13278 +llvm::Value * +CodeGenFunction::EmitX86CpuSupports(std::array FeatureMask) { Value *Result = Builder.getTrue();

[PATCH] D158338: [clang-tidy] [bugprone-implicit-widening-of-multiplication-result] Improved check to ignore false positives with integer literals.

PiotrZSL added a comment. In short I'm against simply ignoring literal calculations because this check is only thing that currently detect this issue: https://github.com/llvm/llvm-project/issues/64828 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D153298: [clang-tidy] Extend bugprone-exception-escape diagnostics

PiotrZSL planned changes to this revision. PiotrZSL marked 4 inline comments as done. PiotrZSL added a comment. TODO: Resolve rest of review comments. Comment at: clang-tools-extra/clang-tidy/utils/ExceptionAnalyzer.cpp:14 void

[PATCH] D158338: [clang-tidy] [bugprone-implicit-widening-of-multiplication-result] Improved check to ignore false positives with integer literals.

PiotrZSL added a comment. I'm not sure if this is right fix, example: const std::size_t k1Tb = 1024 * 1024 * 1024 * 1024; This is detected by -Winteger-overflow, but this: const std::size_t k1Pb = 1024U * 1024U * 1024U * 1024U * 1024U; is not detect by anything except this check, even

[PATCH] D157750: Properly handle -fsplit-machine-functions for fatbinary compilation

MaskRay added inline comments. Comment at: clang/test/Driver/fsplit-machine-functions-with-cuda-nvptx.c:9 + +// Check that -fsplit-machine-functions is passed to both x86 and cuda compilation and does not cause driver error. +// MFS2: -fsplit-machine-functions

[PATCH] D157750: Properly handle -fsplit-machine-functions for fatbinary compilation

MaskRay added a comment. Sorry, but I think this change should be reverted. (a) `-fsplit-machine-functions` on an unsupported target now emits a warning instead of an error. This diverges from the regular expectation for target-specific features. % fclang --target=riscv64

[PATCH] D153298: [clang-tidy] Extend bugprone-exception-escape diagnostics

isuckatcs added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/ExceptionAnalyzer.cpp:542 + CaughtExceptions)) { + CaughtExceptions.emplace(CaughtType, SourceLocation()); ExceptionInfo Rethrown =

[PATCH] D153298: [clang-tidy] Extend bugprone-exception-escape diagnostics

isuckatcs added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/ExceptionEscapeCheck.cpp:88 + + for (auto [ThrowType, ThrowLoc] : AnalyzeResult.getExceptionTypes()) +diag(ThrowLoc, "may throw %0 here", DiagnosticIDs::Note)

[PATCH] D148461: [clang-tidy] Support C++17/20 in bugprone-exception-escape

PiotrZSL updated this revision to Diff 551776. PiotrZSL marked an inline comment as done. PiotrZSL added a comment. Add throw_basefn_catch_const_basefn test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148461/new/ https://reviews.llvm.org/D148461

[PATCH] D148461: [clang-tidy] Support C++17/20 in bugprone-exception-escape

PiotrZSL marked 2 inline comments as done. PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/ExceptionAnalyzer.cpp:306 + + if (From->isMemberPointerType() || To->isMemberPointerType()) return false; isuckatcs wrote: >

[PATCH] D158329: [X86] Support arch=x86-64{,-v2,-v3,-v4} for target_clones attribute

MaskRay added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:13272 + uint64_t Mask = llvm::X86::getCpuSupportsMask(FeatureStrs); + uint32_t FeaturesMask[4] = {uint32_t(Mask), uint32_t(Mask >> 32), 0, 0}; + return EmitX86CpuSupports(FeaturesMask);

[PATCH] D158329: [X86] Support arch=x86-64{,-v2,-v3,-v4} for target_clones attribute

MaskRay updated this revision to Diff 551773. MaskRay marked 6 inline comments as done. MaskRay added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158329/new/ https://reviews.llvm.org/D158329 Files:

[PATCH] D148461: [clang-tidy] Support C++17/20 in bugprone-exception-escape

isuckatcs added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/ExceptionAnalyzer.cpp:306 + + if (From->isMemberPointerType() || To->isMemberPointerType()) return false; isuckatcs wrote: > PiotrZSL wrote: > > isuckatcs wrote: > > >

[PATCH] D158301: Add back overriding-t-options for -m-version-min diagnostic

MaskRay added inline comments. Comment at: clang/test/Driver/darwin-version.c:217 // RUN: FileCheck --check-prefix=CHECK-VERSION-TNO-OSV1 %s -// CHECK-VERSION-TNO-OSV1: overriding '-mmacos-version-min=10.6' option with '-target x86_64-apple-macos10.11.2' +//

[PATCH] D141414: [clang] add warning on shifting boolean type

NekoCdr added a comment. @angelomatnigoogle are you still working on this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141414/new/ https://reviews.llvm.org/D141414 ___ cfe-commits mailing list

[PATCH] D158338: [clang-tidy] [bugprone-implicit-widening-of-multiplication-result] Improved check to ignore false positives with integer literals.

felix642 updated this revision to Diff 551771. felix642 added a comment. Fixed format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158338/new/ https://reviews.llvm.org/D158338 Files:

[PATCH] D158338: [clang-tidy] [bugprone-implicit-widening-of-multiplication-result] Improved check to ignore false positives with integer literals.

felix642 created this revision. Herald added subscribers: PiotrZSL, carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. felix642 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. The

[PATCH] D155064: [clang][SemaCXX] Diagnose tautological uses of consteval if and is_constant_evaluated

hazohelet marked an inline comment as done. hazohelet added inline comments. Comment at: libcxx/include/__type_traits/is_constant_evaluated.h:31 + return false; +#endif } philnik wrote: > Mordante wrote: > > hazohelet wrote: > > > Mordante wrote: > > > > Why

[PATCH] D154784: [clang] Fix crash caused by PseudoObjectExprBitfields::NumSubExprs overflow

yronglin added inline comments. Comment at: clang/include/clang/AST/Stmt.h:596-597 -// These don't need to be particularly wide, because they're -// strictly limited by the forms of expressions we permit. -unsigned NumSubExprs : 8; -unsigned ResultIndex : 32 -

[PATCH] D158152: [clang-tidy]mark record initList as non-const param

PiotrZSL added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:230 +- Improved :doc:`readability-non-const-parameter.cpp + ` check to ignore Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D154784: [clang] Fix crash caused by PseudoObjectExprBitfields::NumSubExprs overflow

yronglin marked an inline comment as done. yronglin added inline comments. Comment at: clang/include/clang/AST/Stmt.h:596-597 -// These don't need to be particularly wide, because they're -// strictly limited by the forms of expressions we permit. -unsigned

[PATCH] D153298: [clang-tidy] Extend bugprone-exception-escape diagnostics

PiotrZSL updated this revision to Diff 551761. PiotrZSL added a comment. Rebase + Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153298/new/ https://reviews.llvm.org/D153298 Files:

[PATCH] D158301: Add back overriding-t-options for -m-version-min diagnostic

dexonsmith added inline comments. Comment at: clang/test/Driver/darwin-version.c:217 // RUN: FileCheck --check-prefix=CHECK-VERSION-TNO-OSV1 %s -// CHECK-VERSION-TNO-OSV1: overriding '-mmacos-version-min=10.6' option with '-target x86_64-apple-macos10.11.2' +//

[PATCH] D148461: [clang-tidy] Support C++17/20 in bugprone-exception-escape

PiotrZSL updated this revision to Diff 551760. PiotrZSL added a comment. Rebase + Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148461/new/ https://reviews.llvm.org/D148461 Files: clang-tools-extra/clang-tidy/utils/ExceptionAnalyzer.cpp

[PATCH] D155064: [clang][SemaCXX] Diagnose tautological uses of consteval if and is_constant_evaluated

philnik added inline comments. Comment at: libcxx/include/__type_traits/is_constant_evaluated.h:31 + return false; +#endif } Mordante wrote: > hazohelet wrote: > > Mordante wrote: > > > Why is this needed? Does this mean the builtin will fail in C++03 mode? >

[PATCH] D158008: [AArch64] Add patterns for FMADD, FMSUB

overmighty added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64InstrFormats.td:5393 + (EXTRACT_SUBREG V128:$Rn, hsub), FPR16:$Rm, FPR16:$Ra)>; + } + dzhidzhoev wrote: > BTW, these lines add some patterns for fnmadd. Could you add some

[PATCH] D144429: [clang-tidy] Add bugprone-chained-comparison check

PiotrZSL updated this revision to Diff 551758. PiotrZSL added a comment. Rebase + Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144429/new/ https://reviews.llvm.org/D144429 Files:

[PATCH] D56644: [clang-tidy] readability-container-size-empty handle std::string length()

PiotrZSL updated this revision to Diff 551757. PiotrZSL added a comment. Rebase + Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56644/new/ https://reviews.llvm.org/D56644 Files:

[PATCH] D158008: [AArch64] Add patterns for FMADD, FMSUB

overmighty updated this revision to Diff 551754. overmighty added a reviewer: dzhidzhoev. overmighty added a comment. - Rebase new upstream commits. - Replace usage of deprecated `vector_extract` with `extractelt` in new patterns. - Add `f16` operators before `EXTRACT_SUBREG`s in new `*Hrrr`

[PATCH] D158279: clang: Make rewrite-includes-macros.cpp runnable on non-Win

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG960881a7f32a: clang: Make rewrite-includes-macros.cpp runnable on non-Win (authored by thakis). Herald added a project: clang. Repository: rG

[clang] 960881a - clang: Make rewrite-includes-macros.cpp runnable on non-Win

Author: Nico Weber Date: 2023-08-19T10:47:37-04:00 New Revision: 960881a7f32abc50fd0e5a349a9981437eba221a URL: https://github.com/llvm/llvm-project/commit/960881a7f32abc50fd0e5a349a9981437eba221a DIFF: https://github.com/llvm/llvm-project/commit/960881a7f32abc50fd0e5a349a9981437eba221a.diff

[PATCH] D157383: [clang][Diagnostics] Provide source range to integer-overflow warnings

This revision was automatically updated to reflect the committed changes. Closed by commit rG985a72b6b3e7: [clang][Diagnostics] Provide source range to integer-overflow warnings (authored by hazohelet). Changed prior to commit: https://reviews.llvm.org/D157383?vs=548149=551746#toc Repository:

[clang] 985a72b - [clang][Diagnostics] Provide source range to integer-overflow warnings

Author: Takuya Shimizu Date: 2023-08-19T22:05:12+09:00 New Revision: 985a72b6b3e74f0d29780b2a97b5817473338ffe URL: https://github.com/llvm/llvm-project/commit/985a72b6b3e74f0d29780b2a97b5817473338ffe DIFF:

[PATCH] D157201: [Clang] Support qualified name as member designator in offsetof

cor3ntin added inline comments. Comment at: clang/test/SemaCXX/offsetof.cpp:106 +int x3[__builtin_offsetof(struct X2, X2::static_a) == 0 ? 1 : -1]; // expected-error{{no member named 'static_a'}} +int x4[__builtin_offsetof(struct X2, X2::X2) == 0 ? 1 : -1]; //

[PATCH] D155064: [clang][SemaCXX] Diagnose tautological uses of consteval if and is_constant_evaluated

hazohelet updated this revision to Diff 551744. hazohelet marked 2 inline comments as done. hazohelet added a comment. Address comments from Mark - Added comment about the need of macro use in libc++ include file. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155064/new/

[PATCH] D158301: Add back overriding-t-options for -m-version-min diagnostic

aaron.ballman added a subscriber: dblaikie. aaron.ballman added a comment. This seems like a reasonable approach to me. CC @dblaikie and @dexonsmith to make sure this addresses their concerns. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D155064: [clang][SemaCXX] Diagnose tautological uses of consteval if and is_constant_evaluated

Mordante added inline comments. Comment at: libcxx/include/__type_traits/is_constant_evaluated.h:31 + return false; +#endif } hazohelet wrote: > Mordante wrote: > > Why is this needed? Does this mean the builtin will fail in C++03 mode? >

[PATCH] D155064: [clang][SemaCXX] Diagnose tautological uses of consteval if and is_constant_evaluated

hazohelet added inline comments. Comment at: libcxx/include/__type_traits/is_constant_evaluated.h:31 + return false; +#endif } Mordante wrote: > Why is this needed? Does this mean the builtin will fail in C++03 mode? `__libcpp_is_constant_evaluated` always

[PATCH] D155064: [clang][SemaCXX] Diagnose tautological uses of consteval if and is_constant_evaluated

Mordante added inline comments. Comment at: libcxx/include/__type_traits/is_constant_evaluated.h:31 + return false; +#endif } Why is this needed? Does this mean the builtin will fail in C++03 mode? Comment at:

[clang] 69a8636 - [clang][NFC] Remove redundant whitespaces

Author: Younan Zhang Date: 2023-08-19T19:25:32+08:00 New Revision: 69a8636c4dec2c9e561224e603ea9864a06bee3a URL: https://github.com/llvm/llvm-project/commit/69a8636c4dec2c9e561224e603ea9864a06bee3a DIFF: https://github.com/llvm/llvm-project/commit/69a8636c4dec2c9e561224e603ea9864a06bee3a.diff

[PATCH] D158302: [clang] Add simple utils to ensure static assert on bit count of DeclContext

danix800 updated this revision to Diff 551738. danix800 added a comment. Apply git-clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158302/new/ https://reviews.llvm.org/D158302 Files: clang/include/clang/AST/DeclBase.h

[PATCH] D158302: [clang] Add simple utils to ensure static assert on bit count of DeclContext

danix800 updated this revision to Diff 551737. danix800 added a comment. Remove ununsed code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158302/new/ https://reviews.llvm.org/D158302 Files: clang/include/clang/AST/DeclBase.h

[PATCH] D156605: [clangd][CodeComplete] Improve FunctionCanBeCall

zyounan updated this revision to Diff 551736. zyounan added a comment. Sorry, forgot to update tests :( Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156605/new/ https://reviews.llvm.org/D156605 Files: clang-tools-extra/clangd/CodeComplete.cpp

[PATCH] D157565: [CodeGen] Add AArch64 behavior to existing MFS tests

thakis added a comment. This breaks tests on windows: http://45.33.8.238/win/82918/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157565/new/

[PATCH] D156605: [clangd][CodeComplete] Improve FunctionCanBeCall

zyounan updated this revision to Diff 551730. zyounan added a comment. Fix the bool expression. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156605/new/ https://reviews.llvm.org/D156605 Files: clang-tools-extra/clangd/CodeComplete.cpp

[PATCH] D158329: [X86] Support arch=x86-64{,-v2,-v3,-v4} for target_clones attribute

pengfei added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:13272 + uint64_t Mask = llvm::X86::getCpuSupportsMask(FeatureStrs); + uint32_t FeaturesMask[4] = {uint32_t(Mask), uint32_t(Mask >> 32), 0, 0}; + return EmitX86CpuSupports(FeaturesMask);

[PATCH] D158061: [clang] Construct ExprRequirement with SubstitutionDiagnostic on SubstFailure

zyounan updated this revision to Diff 551728. zyounan added a comment. Rebase and Remove the stray status Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158061/new/ https://reviews.llvm.org/D158061 Files: clang/docs/ReleaseNotes.rst

[PATCH] D158061: [clang] Construct ExprRequirement with SubstitutionDiagnostic on SubstFailure

zyounan updated this revision to Diff 551726. zyounan added a comment. Add release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158061/new/ https://reviews.llvm.org/D158061 Files: clang/docs/ReleaseNotes.rst

[PATCH] D156605: [clangd][CodeComplete] Improve FunctionCanBeCall

zyounan added a comment. Thanks for Sam and Nathan's thorough review! I've updated, and please take another look. (Apologize for churning on weekends, but I don't have chunk time during the week.) Comment at: clang-tools-extra/clangd/CodeCompletionStrings.cpp:258 case

[PATCH] D156605: [clangd][CodeComplete] Improve FunctionCanBeCall

zyounan updated this revision to Diff 551723. zyounan marked 14 inline comments as done. zyounan added a comment. Address many comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156605/new/ https://reviews.llvm.org/D156605 Files:

[clang] d188916 - [Driver][DXC] Accept -f{no-, }discard-value-names in the DXC driver

Author: Justin Bogner Date: 2023-08-19T01:47:16-07:00 New Revision: d1889167b10a68bf25c284b040ee1ac4df844000 URL: https://github.com/llvm/llvm-project/commit/d1889167b10a68bf25c284b040ee1ac4df844000 DIFF: https://github.com/llvm/llvm-project/commit/d1889167b10a68bf25c284b040ee1ac4df844000.diff

[PATCH] D154382: [ClangRepl] support code completion at a REPL

v.g.vassilev accepted this revision. v.g.vassilev added a comment. Thanks for working on this @capfredf. Let me know if I should land that for you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154382/new/ https://reviews.llvm.org/D154382

[PATCH] D158285: [NFC][CLANG] Fix wrong orders of function arguments positions

steakhal requested changes to this revision. steakhal added subscribers: tbaeder, ABataev. steakhal added a comment. This revision now requires changes to proceed. I think we have two 2 TPs, that were interesting to see. I've CCd the code owners of the affected parts to confirm this. As a

[clang] b627bde - [Interp] Modernize State (NFC)

Author: Kazu Hirata Date: 2023-08-19T00:27:12-07:00 New Revision: b627bde4d5cdbdb8c72c6a94f39e145f5cb28887 URL: https://github.com/llvm/llvm-project/commit/b627bde4d5cdbdb8c72c6a94f39e145f5cb28887 DIFF: https://github.com/llvm/llvm-project/commit/b627bde4d5cdbdb8c72c6a94f39e145f5cb28887.diff

[clang] fbaf5cb - [StaticAnalyzer] Modernize EventDispatcher (NFC)

Author: Kazu Hirata Date: 2023-08-19T00:27:11-07:00 New Revision: fbaf5cbb734fb1ae1f905a3d3657a09ccbeba86a URL: https://github.com/llvm/llvm-project/commit/fbaf5cbb734fb1ae1f905a3d3657a09ccbeba86a DIFF: https://github.com/llvm/llvm-project/commit/fbaf5cbb734fb1ae1f905a3d3657a09ccbeba86a.diff

[clang] 519ea98 - [Sema] Modernize VirtSpecifiers (NFC)

Author: Kazu Hirata Date: 2023-08-19T00:27:09-07:00 New Revision: 519ea98044127a0abd8f0648404ae55ce2c05c70 URL: https://github.com/llvm/llvm-project/commit/519ea98044127a0abd8f0648404ae55ce2c05c70 DIFF: https://github.com/llvm/llvm-project/commit/519ea98044127a0abd8f0648404ae55ce2c05c70.diff

[clang-tools-extra] 2fbbb7e - [clangd] Modernize SymbolLocation::Position (NFC)

Author: Kazu Hirata Date: 2023-08-19T00:27:08-07:00 New Revision: 2fbbb7efe0d23c69029f175b6b0555b45fcf9c0e URL: https://github.com/llvm/llvm-project/commit/2fbbb7efe0d23c69029f175b6b0555b45fcf9c0e DIFF: https://github.com/llvm/llvm-project/commit/2fbbb7efe0d23c69029f175b6b0555b45fcf9c0e.diff

[clang] f237da1 - [AST] Use DenseMap::lookup (NFC)

Author: Kazu Hirata Date: 2023-08-18T23:52:57-07:00 New Revision: f237da1a2f6b89d8a832d37d64fb57795bfa7b9a URL: https://github.com/llvm/llvm-project/commit/f237da1a2f6b89d8a832d37d64fb57795bfa7b9a DIFF: https://github.com/llvm/llvm-project/commit/f237da1a2f6b89d8a832d37d64fb57795bfa7b9a.diff

[clang-tools-extra] 11e2975 - Fx typos in documentation

Author: Kazu Hirata Date: 2023-08-18T23:36:04-07:00 New Revision: 11e2975810acd6abde9071818e03634d99492b54 URL: https://github.com/llvm/llvm-project/commit/11e2975810acd6abde9071818e03634d99492b54 DIFF: https://github.com/llvm/llvm-project/commit/11e2975810acd6abde9071818e03634d99492b54.diff

[clang] 11e2975 - Fx typos in documentation

Author: Kazu Hirata Date: 2023-08-18T23:36:04-07:00 New Revision: 11e2975810acd6abde9071818e03634d99492b54 URL: https://github.com/llvm/llvm-project/commit/11e2975810acd6abde9071818e03634d99492b54 DIFF: https://github.com/llvm/llvm-project/commit/11e2975810acd6abde9071818e03634d99492b54.diff