[PATCH] D158259: [clang][RISCV] Support operators for RVV sizeless vector types

Jim added inline comments. Comment at: clang/test/CodeGen/riscv-rvv-vla-arith-ops.c:3 +// RUN: %clang_cc1 -triple riscv64-none-linux-gnu -target-feature +zve64d \ +// RUN: -target-feature +f -target-feature +d -disable-O0-optnone \ +// RUN: -mvscale-min=4 -mvscale-max=4

[PATCH] D158402: [Clang][RISCV] Add vcreate intrinsics for RVV tuple types

Jim added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:2833 } + let Name = "vcreate_v", + UnMaskedPolicyScheme = NonePolicy, Can we add a blank line before this. Comment at:

[PATCH] D158480: [clang-tidy][readability-braces-around-statements] ignore false-positive for constexpr if statement in lambda expression

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158480/new/ https://reviews.llvm.org/D158480

[PATCH] D158486: [clang-tidy] Ignore used special-members in modernize-use-equals-delete

PiotrZSL created this revision. PiotrZSL added reviewers: malcolm.parsons, njames93, carlosgalvezp. Herald added a subscriber: xazax.hun. Herald added a project: All. PiotrZSL requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits.

[PATCH] D158259: [clang][RISCV] Support operators for RVV sizeless vector types

Jim added inline comments. Comment at: clang/test/CodeGen/riscv-rvv-vla-arith-ops.c:3 +// RUN: %clang_cc1 -triple riscv64-none-linux-gnu -target-feature +zve64d \ +// RUN: -target-feature +f -target-feature +d -disable-O0-optnone \ +// RUN: -mvscale-min=4 -mvscale-max=4

[PATCH] D157953: [CGCall][RISCV] Handle function calls with parameter of RVV tuple type

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157953/new/ https://reviews.llvm.org/D157953

[PATCH] D158402: [Clang][RISCV] Add vcreate intrinsics for RVV tuple types

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158402/new/ https://reviews.llvm.org/D158402

[PATCH] D156693: [clang][ASTImporter]Skip check depth of friend template parameter

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG07ab5140080e: [clang][ASTImporter]Skip check depth of friend template parameter (authored by jcsxky, committed by wangpc). Repository: rG LLVM

[clang] 07ab514 - [clang][ASTImporter]Skip check depth of friend template parameter

Author: huqizhi Date: 2023-08-22T13:16:11+08:00 New Revision: 07ab5140080eecdf9f0f6215f70377accb8696f1 URL: https://github.com/llvm/llvm-project/commit/07ab5140080eecdf9f0f6215f70377accb8696f1 DIFF: https://github.com/llvm/llvm-project/commit/07ab5140080eecdf9f0f6215f70377accb8696f1.diff LOG:

[PATCH] D158476: [driver] Search for compatible Android runtime directories

smeenai added a comment. In D158476#4605360 , @MaskRay wrote: >> // Android target triples contain a target version. If we don't have >> libraries for the exact target version, we should fall back to the next >> newest version or a versionless path, if

[PATCH] D158484: [PowerPC][altivec] Correct modulo number of vector char

lkail created this revision. lkail added reviewers: PowerPC, nemanjai, qiucf. Herald added subscribers: sunshaoce, shchenz, kbarton. Herald added a project: All. lkail requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. According to

[PATCH] D86310: [X86] Align i128 to 16 bytes in x86 datalayouts

tmgross added a comment. In D86310#4597359 , @hvdijk wrote: > In D86310#4596841 , @tmgross wrote: > >> I think that D158169 seems to have fixed >> clang as well; after applying

[clang] be1516d - [PowerPC] Precommit test of `vec_promote` on `vector char`. NFC.

Author: Kai Luo Date: 2023-08-22T04:14:34Z New Revision: be1516d46b1c9ad873d1b30b3494c3a3d0d8e02b URL: https://github.com/llvm/llvm-project/commit/be1516d46b1c9ad873d1b30b3494c3a3d0d8e02b DIFF: https://github.com/llvm/llvm-project/commit/be1516d46b1c9ad873d1b30b3494c3a3d0d8e02b.diff LOG:

[PATCH] D158461: [Driver] Remove unlikely-working Minix.cpp and Contiki.cpp

MaskRay updated this revision to Diff 552204. MaskRay added a comment. update gn Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158461/new/ https://reviews.llvm.org/D158461 Files: clang/lib/Basic/Targets.cpp clang/lib/Basic/Targets/OSTargets.h

[PATCH] D151730: [RISCV] Support target attribute for function

wangpc added inline comments. Comment at: clang/lib/Basic/Targets/RISCV.cpp:376 + + if (AttrString.startswith("+") || AttrString.startswith("-")) { +// EXTENSION like arch=+v,+zbb,-c `-` is removed in

[PATCH] D158461: [Driver] Remove unlikely-working Minix.cpp and Contiki.cpp

brad added inline comments. Comment at: llvm/utils/gn/secondary/clang/lib/Driver/BUILD.gn:69 "ToolChains/CommonArgs.cpp", "ToolChains/Contiki.cpp", "ToolChains/CrossWindows.cpp", Here too. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D158152: [clang-tidy]mark record initList as non-const param

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1c9412441b87: [clang-tidy]mark record initList as non-const param (authored by HerrCai0907). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang-tools-extra] 1c94124 - [clang-tidy]mark record initList as non-const param

Author: Congcong Cai Date: 2023-08-22T11:43:27+08:00 New Revision: 1c9412441b87eb15262fb4653015ff30c42d URL: https://github.com/llvm/llvm-project/commit/1c9412441b87eb15262fb4653015ff30c42d DIFF: https://github.com/llvm/llvm-project/commit/1c9412441b87eb15262fb4653015ff30c42d.diff

[PATCH] D158480: [clang-tidy][readability-braces-around-statements] ignore false-positive for constexpr if statement in lambda expression

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:233 + ` check to + ignore false-positive for constexpr if statement in lambda expression. + `if constexpr`? Please also enclose it in double back-ticks. Repository:

[PATCH] D151730: [RISCV] Support target attribute for function

BeMg updated this revision to Diff 552200. BeMg added a comment. Herald added a subscriber: sunshaoce. Remove some condition because RFC doesn't support it. (Must include prefix arch|cpu|tune) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D158152: [clang-tidy]mark record initList as non-const param

HerrCai0907 updated this revision to Diff 552199. HerrCai0907 added a comment. add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158152/new/ https://reviews.llvm.org/D158152 Files:

[PATCH] D148474: [Clang] Fix ResolveConstructorOverload to not select a conversion function if we are going use copy elision

shafik added a comment. In D148474#4490041 , @dim wrote: > FWIW, this fix works for the test cases I had via > https://bugs.freebsd.org/269067 and > https://github.com/llvm/llvm-project/issues/60182, but I got the following > failure during check-all:

[clang] a0db738 - [clang][Interp] Add missing static_assert messages

Author: Douglas Yung Date: 2023-08-21T20:28:39-07:00 New Revision: a0db73850439c6fb72409dbef6d88ef2aef6f9f1 URL: https://github.com/llvm/llvm-project/commit/a0db73850439c6fb72409dbef6d88ef2aef6f9f1 DIFF: https://github.com/llvm/llvm-project/commit/a0db73850439c6fb72409dbef6d88ef2aef6f9f1.diff

[PATCH] D158480: [clang-tidy][readability-braces-around-statements] ignore false-positive for constexpr if statement in lambda expression

HerrCai0907 created this revision. Herald added subscribers: PiotrZSL, carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. HerrCai0907 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Fixed:

[PATCH] D158476: [driver] Search for compatible Android runtime directories

MaskRay added a comment. > // Android target triples contain a target version. If we don't have > libraries for the exact target version, we should fall back to the next > newest version or a versionless path, if any. An Android maintainer can override my opinion but my feeling is that this

[PATCH] D158183: Clang/Gnu: Scan GCC with triple without vendor if vendor is unknown

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6ee3b2a6: Clang/Gnu: Scan GCC with triple without vendor if vendor is unknown (authored by wzssyqa, committed by brad). Herald added a project:

[clang] 6ee3b24 - Clang/Gnu: Scan GCC with triple without vendor if vendor is unknown

Author: YunQiang Su Date: 2023-08-21T22:13:50-04:00 New Revision: 6ee3b2a6410b8188d57d3bc5903674ae3187 URL: https://github.com/llvm/llvm-project/commit/6ee3b2a6410b8188d57d3bc5903674ae3187 DIFF: https://github.com/llvm/llvm-project/commit/6ee3b2a6410b8188d57d3bc5903674ae3187.diff

[PATCH] D157833: [C++20] [Coroutines] Mark await_suspend as noinline if the awaiter is not empty

This revision was automatically updated to reflect the committed changes. Closed by commit rGc4672454743e: [C++20] [Coroutines] Mark await_suspend as noinline if the awaiter is not empty (authored by ChuanqiXu). Changed prior to commit: https://reviews.llvm.org/D157833?vs=550955=552187#toc

[clang] c467245 - [C++20] [Coroutines] Mark await_suspend as noinline if the awaiter is not empty

Author: Chuanqi Xu Date: 2023-08-22T09:56:44+08:00 New Revision: c4672454743e942f148a1aff1e809dae73e464f6 URL: https://github.com/llvm/llvm-project/commit/c4672454743e942f148a1aff1e809dae73e464f6 DIFF: https://github.com/llvm/llvm-project/commit/c4672454743e942f148a1aff1e809dae73e464f6.diff

[PATCH] D158476: [driver] Search for compatible Android runtime directories

smeenai created this revision. smeenai added reviewers: collinbaker, thakis, MaskRay, phosek, danalbert, srhines. Herald added subscribers: danielkiss, kristof.beyls. Herald added a project: All. smeenai requested review of this revision. Herald added a project: clang. Herald added a subscriber:

[PATCH] D158475: [driver] Refactor getRuntimePaths. NFC

smeenai created this revision. smeenai added reviewers: collinbaker, thakis, phosek, MaskRay. Herald added a project: All. smeenai requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This used to be getRuntimePath till

[PATCH] D148381: [WIP][Clang] Add counted_by attribute

void updated this revision to Diff 552184. void edited the summary of this revision. void added a comment. Make __builtin_dynamic_object_size use the __counted_by attribute to help determine the object size. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D156693: [clang][ASTImporter]Skip check depth of friend template parameter

jcsxky added inline comments. Comment at: clang/unittests/AST/StructuralEquivalenceTest.cpp:140 +D0->getASTContext(), D1->getASTContext(), NonEquivalentDecls01, +StructuralEquivalenceKind::Default, false, false, false, +IgnoreTemplateParmDepth);

[PATCH] D158474: [clang][ExtractAPI] Fix bool spelling coming from the macro definition.

evelez7 created this revision. evelez7 added a reviewer: dang. Herald added a reviewer: ributzka. Herald added a project: All. evelez7 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. getFragmentsForType resulted in a bool typeIdentifier

[PATCH] D156693: [clang][ASTImporter]Skip check depth of friend template parameter

jcsxky updated this revision to Diff 552179. jcsxky added a comment. add argument comment according to bugprone-argument-comment . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D141177: [Clang] Don't tell people to place _Alignas on a struct in diagnostics

theo-lw updated this revision to Diff 552181. theo-lw added a comment. Ran clang-format on this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141177/new/ https://reviews.llvm.org/D141177 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/AttributeCommonInfo.h

[PATCH] D157385: [clang][CFG] Cleanup functions

aaronpuchert added inline comments. Comment at: clang/test/Analysis/scopes-cfg-output.cpp:1473-1474 +// CHECK-NEXT:3: F f __attribute__((cleanup(cleanup_F))); +// CHECK-NEXT:4: [B1.3].~F() (Implicit destructor) +// CHECK-NEXT:5: CleanupFunction (cleanup_F) +//

[PATCH] D157331: [clang] Implement C23

ZijunZhao added inline comments. Comment at: clang/lib/Headers/stdckdint.h:1 +/*=== stdckdint.h - Standard header for checking integer + *-=== aaron.ballman wrote: > hiraditya wrote: > > nit: format. > The formatting for this is still

[PATCH] D157331: [clang] Implement C23

ZijunZhao added inline comments. Comment at: clang/test/C/C2x/n2683.c:16 + +bool flag_add = ckd_add(, a33, char_var); +bool flag_sub = ckd_sub(, bool_var, day); aaron.ballman wrote: > It looks like the builtins are missing some checks that are required

[PATCH] D158472: [clang][Diagnostics] Emit fix-it hint separately on overload resolution failure

hazohelet added a comment. This breaks the one-note-for-one-overload-candidate rule of overload resolution failure diagnostics (https://github.com/llvm/llvm-project/blob/ff08c8e57e39d7970b65637595cdc221901f4ed1/clang/lib/Sema/SemaOverload.cpp#L11517-L11526), but in most cases this change would

[PATCH] D158472: [clang][Diagnostics] Emit fix-it hint separately on overload resolution failure

hazohelet created this revision. hazohelet added reviewers: aaron.ballman, cjdb, tbaeder, shafik. Herald added a subscriber: arphaman. Herald added a project: All. hazohelet requested review of this revision. Herald added a project: clang. D153359 addressed the

[PATCH] D157331: [clang] Implement C23

ZijunZhao updated this revision to Diff 552177. ZijunZhao marked 9 inline comments as done. ZijunZhao added a comment. 1. Reformat test files in C/C2x 2. Update the definition and the test about `__STDC_VERSION_STDCKDINT_H__` 3. Update release docs and the introduction in the test file 4. Update

[PATCH] D158469: [clang][deps] Compute command lines and file deps on-demand

jansvoboda11 created this revision. jansvoboda11 added a reviewer: benlangmuir. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Although generating command

[PATCH] D158461: [Driver] Remove unlikely-working Minix.cpp and Contiki.cpp

MaskRay updated this revision to Diff 552171. MaskRay retitled this revision from "[Driver] Remove unlikely-working Minix.cpp" to "[Driver] Remove unlikely-working Minix.cpp and Contiki.cpp". MaskRay edited the summary of this revision. MaskRay added a comment. Herald added a project: LLVM.

[PATCH] D158461: [Driver] Remove unlikely-working Minix.cpp

MaskRay added a comment. In D158461#4605084 , @brad wrote: > Isn't there more than this to do a full proper removal? > > Looking around it looks like the Ananas and Contiki support can be removed. > Ananas used > to use Clang but switched back to GCC

[PATCH] D153114: [clangd] [C++20] [Modules] Support C++20 modules for clangd

sammccall added a comment. In D153114#4604438 , @nridge wrote: > In D153114#4603579 , @sammccall > wrote: > >> - to identify what module names we must have PCMs for in order to build a >> given TU (either an

[PATCH] D158233: [SEH] Fix wrong argument passes to the call of OutlinedFinally.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGff08c8e57e39: [SEH] Fix wrong argument passes to the call of OutlinedFinally. (authored by jyu2). Changed prior to commit:

[clang] ff08c8e - [SEH] Fix wrong argument passes to the call of OutlinedFinally.

Author: Jennifer Yu Date: 2023-08-21T17:07:38-07:00 New Revision: ff08c8e57e39d7970b65637595cdc221901f4ed1 URL: https://github.com/llvm/llvm-project/commit/ff08c8e57e39d7970b65637595cdc221901f4ed1 DIFF: https://github.com/llvm/llvm-project/commit/ff08c8e57e39d7970b65637595cdc221901f4ed1.diff

[PATCH] D157632: [Profile] Allow online merging with debug info correlation.

aeubanks added inline comments. Comment at: compiler-rt/lib/profile/InstrProfilingMerge.c:146 +if (!(__llvm_profile_get_version() & VARIANT_MASK_DBG_CORRELATE)) { + PROF_ERR("%s\n", "Missing profile data section."); + return 1; aeubanks wrote: >

[PATCH] D155610: [Clang][Sema] Fix display of characters on static assertion failure

hazohelet updated this revision to Diff 552167. hazohelet marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155610/new/ https://reviews.llvm.org/D155610 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaDeclCXX.cpp

[PATCH] D158371: [clang-tidy] Fix DanglingHandleCheck to work in C++17 and later mode

loskutov updated this revision to Diff 552164. loskutov added a comment. git clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158371/new/ https://reviews.llvm.org/D158371 Files:

[PATCH] D156192: [-Wunsafe-buffer-usage] Stop generating incorrect fix-its for variable declarations with unsupported specifiers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. ziqingluo-90 marked an inline comment as done. Closed by commit rGb58e52889808: [-Wunsafe-buffer-usage] Stop generating incorrect fix-its for variable… (authored by

[clang] b58e528 - [-Wunsafe-buffer-usage] Stop generating incorrect fix-its for variable declarations with unsupported specifiers

Author: Ziqing Luo Date: 2023-08-21T16:34:44-07:00 New Revision: b58e52889808e0e8da55ac77f651762f202aa4c5 URL: https://github.com/llvm/llvm-project/commit/b58e52889808e0e8da55ac77f651762f202aa4c5 DIFF: https://github.com/llvm/llvm-project/commit/b58e52889808e0e8da55ac77f651762f202aa4c5.diff

[PATCH] D158461: [Driver] Remove unlikely-working Minix.cpp

brad added a comment. Isn't there more than this to do a full proper removal? Looking around it looks like the Ananas and Contiki support can be removed. Ananas used to use Clang but switched back to GCC and the bits there are not maintained. The Contiki support never went anywhere.

[PATCH] D158254: Fixing the memory leak using split() instead of strtok

hchilama added a comment. Hi @abhina.sreeskantharajan can I please know the next process on how to land this revision to opensource? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158254/new/ https://reviews.llvm.org/D158254

[PATCH] D158233: [SEH] Fix wrong argument passes to the call of OutlinedFinally.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm, thanks! Comment at: clang/lib/CodeGen/CGCleanup.cpp:881 + // to indicate abnormal termination) + const FunctionDecl *FD = dyn_cast_or_null(CurFuncDecl); if

[PATCH] D158233: [SEH] Fix wrong argument passes to the call of OutlinedFinally.

jyu2 added inline comments. Comment at: clang/lib/CodeGen/CGCleanup.cpp:882 if (!Scope.hasBranchThroughs() && !HasFixups && !HasFallthrough && - Scope.getNumBranchAfters() == 1) { + !getLangOpts().EHAsynch && Scope.getNumBranchAfters() == 1) {

[PATCH] D158233: [SEH] Fix wrong argument passes to the call of OutlinedFinally.

jyu2 updated this revision to Diff 552157. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158233/new/ https://reviews.llvm.org/D158233 Files: clang/lib/CodeGen/CGCleanup.cpp clang/test/CodeGen/exceptions-seh-finally.c

[PATCH] D156565: Diagnose use of VLAs in C++ by default

shafik added a comment. In D156565#4599812 , @aaron.ballman wrote: > Enable the diagnostic by default in C++ language modes, and under -Wall in > GNU++ language modes. I am happy with that approach. CHANGES SINCE LAST ACTION

[PATCH] D157833: [C++20] [Coroutines] Mark await_suspend as noinline if the awaiter is not empty

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Alright, LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157833/new/ https://reviews.llvm.org/D157833 ___ cfe-commits mailing

[PATCH] D158239: [clang][ExtractAPI] Add support for namespaces

evelez7 updated this revision to Diff 552155. evelez7 marked an inline comment as done. evelez7 added a comment. Move DetermineParentDecl to determineParentRecord in APIVisitor as a private method. Easier to just let it fetch the record for us and return nullptr if the parent is the

[PATCH] D157632: [Profile] Allow online merging with debug info correlation.

aeubanks added inline comments. Comment at: compiler-rt/lib/profile/InstrProfilingMerge.c:146 +if (!(__llvm_profile_get_version() & VARIANT_MASK_DBG_CORRELATE)) { + PROF_ERR("%s\n", "Missing profile data section."); + return 1; we're running into

[PATCH] D155387: [Clang] Fix member lookup so that we don't ignore ambiguous lookups in some cases

rsmith added a comment. In D155387#4579866 , @ilya-biryukov wrote: > I believe this should compile as according to (over.match.oper)p4 > : > >> A non-template function or function template F

[PATCH] D158218: [CMake] Deprecate DEFAULT_SYSROOT and GCC_INSTALL_PREFIX

sbc100 added inline comments. Comment at: clang/CMakeLists.txt:179-183 +if(DEFAULT_SYSROOT) + message(WARNING "DEFAULT_SYSROOT is deprecated and will be removed. Use " +"configuration files (https://clang.llvm.org/docs/UsersManual.html#configuration-files)" +"to

[PATCH] D158378: [Driver] move Minix header search path management to the driver

MaskRay added a comment. Created https://reviews.llvm.org/D158461 to remove it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158378/new/ https://reviews.llvm.org/D158378 ___ cfe-commits mailing list

[PATCH] D158461: [Driver] Remove unlikely-working Minix.cpp

MaskRay created this revision. MaskRay added a reviewer: brad. Herald added a project: All. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This ToolChain was added back in 2010 but has been unmaintained with no test. The

[PATCH] D156189: [-Wunsafe-buffer-usage] Refactor to let local variable fix-its and parameter fix-its share common code

ziqingluo-90 added a comment. Addressed comments and have landed this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156189/new/ https://reviews.llvm.org/D156189 ___ cfe-commits mailing list

[PATCH] D156189: [-Wunsafe-buffer-usage] Refactor to let local variable fix-its and parameter fix-its share common code

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. ziqingluo-90 marked 4 inline comments as done. Closed by commit rG3a67b912386e: [-Wunsafe-buffer-usage] Refactor to let local variable fix-its and parameter… (authored

[clang] 3a67b91 - [-Wunsafe-buffer-usage] Refactor to let local variable fix-its and parameter fix-its share common code

Author: Ziqing Luo Date: 2023-08-21T14:50:04-07:00 New Revision: 3a67b912386e70073efcb2225c6354b85048b1ae URL: https://github.com/llvm/llvm-project/commit/3a67b912386e70073efcb2225c6354b85048b1ae DIFF: https://github.com/llvm/llvm-project/commit/3a67b912386e70073efcb2225c6354b85048b1ae.diff

[PATCH] D157130: [RISCV] Check type size for lax conversions between RVV builtin types and VectorType::RVVFixedLengthDataVector.

This revision was automatically updated to reflect the committed changes. Closed by commit rG33af2f131db7: [RISCV] Check type size for lax conversions between RVV builtin types and… (authored by craig.topper). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 33af2f1 - [RISCV] Check type size for lax conversions between RVV builtin types and VectorType::RVVFixedLengthDataVector.

Author: Craig Topper Date: 2023-08-21T14:28:57-07:00 New Revision: 33af2f131db71a18aefc5469129540e2097a537f URL: https://github.com/llvm/llvm-project/commit/33af2f131db71a18aefc5469129540e2097a537f DIFF: https://github.com/llvm/llvm-project/commit/33af2f131db71a18aefc5469129540e2097a537f.diff

[PATCH] D158409: [WebAssembly] Add multiple memories feature

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG86ed8cb8fabe: [WebAssembly] Add multiple memories feature (authored by ashleynh, committed by tlively). Changed prior to commit:

[clang] 86ed8cb - [WebAssembly] Add multiple memories feature

Author: Ashley Nelson Date: 2023-08-21T14:23:14-07:00 New Revision: 86ed8cb8fabe7716b9046317231f861fee5f126a URL: https://github.com/llvm/llvm-project/commit/86ed8cb8fabe7716b9046317231f861fee5f126a DIFF: https://github.com/llvm/llvm-project/commit/86ed8cb8fabe7716b9046317231f861fee5f126a.diff

[PATCH] D158409: [WebAssembly] Add multiple memories feature

ashleynh added inline comments. Comment at: clang/include/clang/Driver/Options.td:4583-4584 def mno_extended_const : Flag<["-"], "mno-extended-const">, Group; +def mmulti_memories : Flag<["-"], "mmulti-memories">, Group; +def mno_multi_memories : Flag<["-"],

[clang] 77596e6 - Revert D157750 "[Driver][CodeGen] Properly handle -fsplit-machine-functions for fatbinary compilation."

Author: Fangrui Song Date: 2023-08-21T13:54:15-07:00 New Revision: 77596e6b167bf0a5efa790597d6b75ac5e685b55 URL: https://github.com/llvm/llvm-project/commit/77596e6b167bf0a5efa790597d6b75ac5e685b55 DIFF: https://github.com/llvm/llvm-project/commit/77596e6b167bf0a5efa790597d6b75ac5e685b55.diff

[PATCH] D139730: [OpenMP][DeviceRTL][AMDGPU] Support code object version 5

arsenm added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:17067 + +Value *Iscov5 = CGF.Builder.CreateICmpSGE( +ABIVersion, Capitalization is weird, IsCOV5? Comment at: clang/lib/CodeGen/CGBuiltin.cpp:17082-17083 +

[PATCH] D157572: [clang] Add `[[clang::library_extension]]` attribute

philnik added a comment. In D157572#4604482 , @aaron.ballman wrote: >> This allows standard libraries to mark symbols as extensions, so the >> compiler can generate extension warnings when they are used. > > Huh, so this is basically the opposite of

[PATCH] D158448: WIP

nickdesaulniers created this revision. Herald added a project: All. nickdesaulniers requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D158448 Files:

[PATCH] D61670: [clang] [MinGW] Add the option -fno-autoimport

rnk added a comment. In D61670#4604486 , @mstorsjo wrote: > In D61670#4604145 , @rnk wrote: > >> cc +@aeubanks @jyknight to consider using the code model for this purpose > > Hmm, I don't quite understand this

[PATCH] D157757: [Headers] Replace __need_STDDEF_H_misc with specific __need_ macros

iana added inline comments. Comment at: clang/lib/Headers/stddef.h:118-122 +#ifdef __cplusplus +namespace std { +typedef decltype(nullptr) nullptr_t; +} +using ::std::nullptr_t; aaron.ballman wrote: > iana wrote: > > aaron.ballman wrote: > > > iana wrote: > > >

[PATCH] D61670: [clang] [MinGW] Add the option -fno-autoimport

mstorsjo added a comment. In D61670#4604145 , @rnk wrote: > cc +@aeubanks @jyknight to consider using the code model for this purpose Hmm, I don't quite understand this comment; do you suggest that we after all should use the code model for controlling

[PATCH] D157572: [clang] Add `[[clang::library_extension]]` attribute

aaron.ballman added a comment. > This allows standard libraries to mark symbols as extensions, so the compiler > can generate extension warnings when they are used. Huh, so this is basically the opposite of the `__extension__` macro (which is used to silence extension warnings)? I don't think

[PATCH] D157879: [clang] Report missing designated initializers in C++

ianloic added a comment. In D157879#4604233 , @aeubanks wrote: > ah I thought this was in `-Wall` but it's not > > the struct is > > struct Foo { > const void* buffer; > uint32_t capacity; > uint32_t reserved; > }; > > where `reserved`

[PATCH] D158363: [clang-format] Fix segmentation fault when formatting nested namespaces

HazardyKnusperkeks added a comment. Please upload the patch with the full context. And add a test case. (From your issue.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158363/new/ https://reviews.llvm.org/D158363

[PATCH] D158409: [WebAssembly] Add multiple memories feature

tlively added inline comments. Comment at: clang/include/clang/Driver/Options.td:4583-4584 def mno_extended_const : Flag<["-"], "mno-extended-const">, Group; +def mmulti_memories : Flag<["-"], "mmulti-memories">, Group; +def mno_multi_memories : Flag<["-"],

[PATCH] D157708: [Sema] Suppress lookup diagnostics when checking reversed operators

rsmith added a comment. The prior behavior of Clang is correct. A search of a class scope is ill-formed if it finds an ambiguous result, see http://eel.is/c++draft/basic.lookup#class.member.lookup-6.sentence-2 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D158409: [WebAssembly] Add multiple memories feature

ashleynh updated this revision to Diff 552097. ashleynh added a comment. switching back to multiple memories for description Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158409/new/ https://reviews.llvm.org/D158409 Files:

[PATCH] D158409: [WebAssembly] Add multiple memories feature

aheejin added inline comments. Comment at: clang/include/clang/Driver/Options.td:4583-4584 def mno_extended_const : Flag<["-"], "mno-extended-const">, Group; +def mmulti_memories : Flag<["-"], "mmulti-memories">, Group; +def mno_multi_memories : Flag<["-"],

[PATCH] D158372: [Clang] Treat invalid UDL as two tokens

rsmith added inline comments. Comment at: clang/docs/ReleaseNotes.rst:97 ^ -- Implemented `CWG1473 `_ which allows spaces after ``operator""``. - Clang used to err on the lack of space when the literal suffix

[PATCH] D157757: [Headers] Replace __need_STDDEF_H_misc with specific __need_ macros

aaron.ballman added inline comments. Comment at: clang/lib/Headers/stddef.h:118-122 +#ifdef __cplusplus +namespace std { +typedef decltype(nullptr) nullptr_t; +} +using ::std::nullptr_t; iana wrote: > aaron.ballman wrote: > > iana wrote: > > > ldionne wrote: > >

[PATCH] D158409: [WebAssembly] Add multiple memories feature

ashleynh updated this revision to Diff 552096. ashleynh added a comment. removed - Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158409/new/ https://reviews.llvm.org/D158409 Files: clang/include/clang/Driver/Options.td

[PATCH] D158409: [WebAssembly] Add multiple memories feature

aheejin accepted this revision. aheejin added a comment. This revision is now accepted and ready to land. LGTM % nit and the name resolution (multimemory vs. multi-memory) Comment at: clang/include/clang/Driver/Options.td:4583-4584 def mno_extended_const : Flag<["-"],

[PATCH] D153114: [clangd] [C++20] [Modules] Support C++20 modules for clangd

nridge added a comment. In D153114#4603579 , @sammccall wrote: > Dep scanning - roles > > > IIUC we do this for two reasons: > > - to identify what module names we must have PCMs for in order to build a > given TU (either an open

[PATCH] D128861: [clang-tidy] add cppcoreguidelines-symmetric-binary-operator

5chmidti added a comment. Thanks for your review comments :) . I'll incorporate them and reference your comments when I post the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128861/new/ https://reviews.llvm.org/D128861

[PATCH] D158430: [flang][driver] Mark -fuse-ld as visible in Flang

erjin updated this revision to Diff 552091. erjin added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158430/new/ https://reviews.llvm.org/D158430 Files: clang/include/clang/Driver/Options.td flang/test/Driver/misc-flags.f90

[PATCH] D157757: [Headers] Replace __need_STDDEF_H_misc with specific __need_ macros

iana added inline comments. Comment at: clang/lib/Headers/stddef.h:118-122 +#ifdef __cplusplus +namespace std { +typedef decltype(nullptr) nullptr_t; +} +using ::std::nullptr_t; aaron.ballman wrote: > iana wrote: > > ldionne wrote: > > > iana wrote: > > > >

[PATCH] D157129: [NFC] Fix unnecessary copy with auto.

srividya-sundaram abandoned this revision. srividya-sundaram added a comment. I did spend a good amount of time trying to figure out how to abandon this review and gave up eventually. Even after your comment, I had to search a bit for the "Add Action.." drop down. Clearly, I'm UI challenged.

[PATCH] D158409: [WebAssembly] Add multiple memories feature

ashleynh updated this revision to Diff 552088. ashleynh added a comment. Squashed into one commit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158409/new/ https://reviews.llvm.org/D158409 Files: clang/include/clang/Driver/Options.td

[PATCH] D156693: [clang][ASTImporter]Skip check depth of friend template parameter

shafik added inline comments. Comment at: clang/unittests/AST/StructuralEquivalenceTest.cpp:140 +D0->getASTContext(), D1->getASTContext(), NonEquivalentDecls01, +StructuralEquivalenceKind::Default, false, false, false, +IgnoreTemplateParmDepth);

[PATCH] D157129: [NFC] Fix unnecessary copy with auto.

aaron.ballman added a comment. Herald added a subscriber: sunshaoce. In D157129#4571112 , @srividya-sundaram wrote: > Based on your comments, and after discussing with @tahonermann, I am > abandoning this patch. Btw, it helps reviewers if you

  1   2   3   >