[PATCH] D158475: [driver] Refactor getRuntimePaths. NFC

glandium added a comment. In D158475#4623842 , @smeenai wrote: > In D158475#4623471 , @glandium > wrote: > >> This conflicts with D146664 > > It sounds like you want the same

[PATCH] D158475: [driver] Refactor getRuntimePaths. NFC

smeenai added a comment. In D158475#4623471 , @glandium wrote: > This conflicts with D146664 It sounds like you want the same logic as D158476 to apply to the stdlib search as well

[PATCH] D153924: [OpenMP] Allow exceptions in target regions when offloading to GPUs

This revision was automatically updated to reflect the committed changes. Closed by commit rG0cfc2dba93b1: [OpenMP] Allow exceptions in target regions when offloading to GPUs (authored by AntonRydahl). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 0cfc2db - [OpenMP] Allow exceptions in target regions when offloading to GPUs

Author: Anton Rydahl Date: 2023-08-28T22:36:13-07:00 New Revision: 0cfc2dba93b172802b580713a492ea14148a0218 URL: https://github.com/llvm/llvm-project/commit/0cfc2dba93b172802b580713a492ea14148a0218 DIFF: https://github.com/llvm/llvm-project/commit/0cfc2dba93b172802b580713a492ea14148a0218.diff

[PATCH] D159064: [Modules] Make clang modules for the C standard library headers

iana updated this revision to Diff 554183. iana added a comment. Remove the module cache before running the stdarg/stddef unit tests in module mode Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159064/new/ https://reviews.llvm.org/D159064 Files:

[PATCH] D159064: [Modules] Make clang modules for the C standard library headers

iana created this revision. iana added reviewers: aaron.ballman, rsmith, efriedma, ldionne, ChuanqiXu, Bigcheese, vsapsai, benlangmuir, dexonsmith. Herald added a subscriber: ributzka. Herald added a project: All. iana requested review of this revision. Herald added a project: clang. Herald added

[PATCH] D152054: [OpenMP] Codegen support for thread_limit on target directive

mstorsjo added a comment. In D152054#4622642 , @vadikp-intel wrote: > Windows importing is now done by name, and new exports do not need to have an > ordinal specified for them i.e. you can add a line with just the API name to > dllexports. Oh,

[PATCH] D159018: [clang][modules] Add a c23 module feature

iana updated this revision to Diff 554158. iana added a comment. remove the extra #endif (which oddly didn't produce an error locally so I must've ran the tests wrong the first time...) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159018/new/

[PATCH] D159054: [Driver] Removal of C_INCLUDE_DIRS feature

brad updated this revision to Diff 554156. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159054/new/ https://reviews.llvm.org/D159054 Files: clang/CMakeLists.txt clang/include/clang/Config/config.h.cmake clang/lib/Driver/ToolChains/Darwin.cpp

[PATCH] D158739: AIX: Issue an error when specifying an alias for a common symbol

hubert.reinterpretcast added a comment. Aside from the comments Digger has made, I have no additional concerns about this patch. It is an improvement (although there are adjacent cases that need further handling). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

wangpc marked 2 inline comments as done. wangpc added inline comments. Comment at: clang/include/clang/Basic/SizedDeallocation.h:23 +namespace clang { +inline llvm::VersionTuple sizedDeallocMinVersion(llvm::Triple::OSType OS) { + switch (OS) { MaskRay wrote: >

[PATCH] D159054: [Driver] Removal of C_INCLUDE_DIRS feature

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Technically there is some risk but I think the blast radius, if present, is extremely small. `C_INCLUDE_DIRS` is not recognized by GCC. If I use

[PATCH] D159054: [Driver] Removal of C_INCLUDE_DIRS feature

brad created this revision. brad added reviewers: MaskRay, tstellar, probinson. brad added a project: clang. Herald added subscribers: pmatos, asb, abrachet, jgravelle-google, sbc100, dschuff, emaste. Herald added a project: All. brad requested review of this revision. Herald added a subscriber:

[clang] 6f1b2e4 - [NFC] Correct the test code in pr65018

Author: Chuanqi Xu Date: 2023-08-29T11:30:47+08:00 New Revision: 6f1b2e4e97e2d6e8f19a9a6d64547b027617fa39 URL: https://github.com/llvm/llvm-project/commit/6f1b2e4e97e2d6e8f19a9a6d64547b027617fa39 DIFF: https://github.com/llvm/llvm-project/commit/6f1b2e4e97e2d6e8f19a9a6d64547b027617fa39.diff

[PATCH] D158709: [Headers][Modules] Make separate headers for the stdarg.h and stddef.h pieces so that they can be modularized

ChuanqiXu accepted this revision. ChuanqiXu added a comment. LGTM too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158709/new/ https://reviews.llvm.org/D158709 ___ cfe-commits mailing list

[PATCH] D159042: [Driver] Add LiteOS and z/OS to ShouldAddDefaultIncludePaths()

This revision was automatically updated to reflect the committed changes. Closed by commit rG196ff0c7ddac: [Driver] Add LiteOS and z/OS to ShouldAddDefaultIncludePaths() (authored by brad). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159042/new/

[clang] 196ff0c - [Driver] Add LiteOS and z/OS to ShouldAddDefaultIncludePaths()

Author: Brad Smith Date: 2023-08-28T23:01:50-04:00 New Revision: 196ff0c7ddacf571a3fc6c9163e85fd91ecab6b3 URL: https://github.com/llvm/llvm-project/commit/196ff0c7ddacf571a3fc6c9163e85fd91ecab6b3 DIFF: https://github.com/llvm/llvm-project/commit/196ff0c7ddacf571a3fc6c9163e85fd91ecab6b3.diff

[PATCH] D158475: [driver] Refactor getRuntimePaths. NFC

glandium added a comment. This conflicts with D146664 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158475/new/ https://reviews.llvm.org/D158475 ___ cfe-commits

[PATCH] D158376: [Driver] move DragonFly header search path management to the driver

brad updated this revision to Diff 554140. brad added a comment. Remove C_INCLUDE_DIRS bits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158376/new/ https://reviews.llvm.org/D158376 Files: clang/lib/Driver/ToolChains/DragonFly.cpp

[PATCH] D133361: [BPF] Attribute btf_decl_tag("ctx") for structs

yonghong-song added a comment. I will try to review other parts of code in the next few days. Comment at: llvm/include/llvm/IR/Intrinsics.td:2432 ImmArg>]>; +def int_context_marker_bpf : DefaultAttrsIntrinsic<[llvm_ptr_ty], +

[PATCH] D158977: [clang][dataflow] Don't associate prvalue expressions with storage locations.

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. Thanks! Sometimes I am wondering whether we actually need a full map for PRValues. E.g., once we processed a `MaterializeTemporaryExpr`, we now have a location for the value, and it

[clang] c1b5674 - [OpenMP] Change OpenMP default version in documentation and help text for -fopenmp-version

Author: Anton Rydahl Date: 2023-08-28T19:05:55-07:00 New Revision: c1b5674fbb76c4b137a1e856441019605668f1ca URL: https://github.com/llvm/llvm-project/commit/c1b5674fbb76c4b137a1e856441019605668f1ca DIFF: https://github.com/llvm/llvm-project/commit/c1b5674fbb76c4b137a1e856441019605668f1ca.diff

[PATCH] D153924: [OpenMP] Allow exceptions in target regions when offloading to GPUs

AntonRydahl added a comment. In D153924#4623357 , @jhuber6 wrote: > The libcxx tests are always broken randomly in my experience. I wouldn't > worry about it. Thanks a bunch! I did not know that. Shall I just land the patch? Repository: rG LLVM

[PATCH] D156901: [OpenMP] Change OpenMP default version in documentation and help text for -fopenmp-version

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGc1b5674fbb76: [OpenMP] Change OpenMP default version in documentation and help text for… (authored by AntonRydahl).

[PATCH] D153924: [OpenMP] Allow exceptions in target regions when offloading to GPUs

jhuber6 added a comment. The libcxx tests are always broken randomly in my experience. I wouldn't worry about it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153924/new/ https://reviews.llvm.org/D153924

[PATCH] D153924: [OpenMP] Allow exceptions in target regions when offloading to GPUs

AntonRydahl updated this revision to Diff 554132. AntonRydahl added a comment. Rebased on main to see if libc++ CI is still failing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153924/new/ https://reviews.llvm.org/D153924 Files:

[PATCH] D137213: [clang][modules] NFCI: Pragma diagnostic mappings: write/read FileID instead of SourceLocation

dexonsmith added a comment. Now that the behaviour change is understood, maybe it'd be useful to split the patch in two: - First, this patch, plus a call to `ASTReader::getInputFile()` only for its side effects, to make this patch actually NFC. - Second, committed a few days later, a patch

[PATCH] D126586: [InstrProf] Single byte counters in coverage

ayzhao added a comment. In D126586#4622003 , @gulfem wrote: > Fixed the issue that causes a crash in InstCombinePHI.cpp. Phi instructions > need to be inserted at the beginning of basic blocks, and profile increments > need to be inserted after phis

[PATCH] D158538: [MS-ABI] Remove comdat attribute for inheriting ctor.

jyu2 marked an inline comment as done. jyu2 added a comment. Thanks. @rnk Comment at: clang/test/CodeGenCXX/ms-inheriting-ctor.cpp:41 + +// CHECK-LABEL: define internal noundef ptr @"??0?$B@_N@@QEAA@AEBVF@@AEBUA@@@Z"(ptr noundef nonnull returned align 1 dereferenceable(1)

[PATCH] D159045: [clang-tidy] Improved documentation for readability-function-size

felix642 updated this revision to Diff 554124. felix642 added a comment. Linked issue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159045/new/ https://reviews.llvm.org/D159045 Files:

[PATCH] D159045: [clang-tidy] Improved documentation for readability-function-size

felix642 updated this revision to Diff 554122. felix642 added a comment. Fixed commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159045/new/ https://reviews.llvm.org/D159045 Files:

[PATCH] D159045: [clang-tidy] Improved documentation for readability-function-size

felix642 created this revision. Herald added subscribers: PiotrZSL, carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. felix642 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. The

[PATCH] D158475: [driver] Refactor getRuntimePaths. NFC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb6a1473f97d3: [driver] Refactor getRuntimePaths. NFC (authored by smeenai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] b6a1473 - [driver] Refactor getRuntimePaths. NFC

Author: Shoaib Meenai Date: 2023-08-28T17:34:50-07:00 New Revision: b6a1473f97d38471b08331dee7ae7f6112c495c0 URL: https://github.com/llvm/llvm-project/commit/b6a1473f97d38471b08331dee7ae7f6112c495c0 DIFF: https://github.com/llvm/llvm-project/commit/b6a1473f97d38471b08331dee7ae7f6112c495c0.diff

[PATCH] D158872: [clang][ASTMatchers] Add a few type-related Matchers

danix800 added a comment. In D158872#4622124 , @aaron.ballman wrote: > Are these matchers going to be used in-tree (by clang-tidy, or something > else)? We typically do not add new AST matches until there's a need for them > because the AST matchers

[PATCH] D158995: [clang] Add a Windows build in the Clang pre-commit CI

ldionne updated this revision to Diff 554115. ldionne added a comment. Poke CI -- it seemed to time out this afternoon due to Phab. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158995/new/ https://reviews.llvm.org/D158995 Files:

[PATCH] D158376: [Driver] move DragonFly header search path management to the driver

brad added a comment. David? Frederic? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158376/new/ https://reviews.llvm.org/D158376 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D137213: [clang][modules] NFCI: Pragma diagnostic mappings: write/read FileID instead of SourceLocation

jansvoboda11 added a subscriber: rsmith. jansvoboda11 added inline comments. Comment at: clang/lib/Serialization/ASTReader.cpp:6343 "Invalid data, missing pragma diagnostic states"); - SourceLocation Loc = ReadSourceLocation(F, Record[Idx++]); - auto

[PATCH] D159042: [Driver] Add LiteOS and z/OS to ShouldAddDefaultIncludePaths()

brad created this revision. brad added reviewers: MaskRay, kpdev42, abhina.sreeskantharajan. brad added a project: clang. Herald added subscribers: abrachet, phosek. Herald added a project: All. brad requested review of this revision. LiteOS (OHOS) and z/ZOS already have header path handling in

[PATCH] D157157: [clang] Add clang support for Machine Function Splitting on AArch64

dhoekwater updated this revision to Diff 554100. dhoekwater edited the summary of this revision. dhoekwater added a comment. Remove the dependency again Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157157/new/ https://reviews.llvm.org/D157157

[PATCH] D157157: [clang] Add clang support for Machine Function Splitting on AArch64

dhoekwater updated this revision to Diff 554099. dhoekwater edited the summary of this revision. dhoekwater added a comment. Add the old dependency to hopefully get the change to propagate when I remove it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D157157: [clang] Add clang support for Machine Function Splitting on AArch64

dhoekwater updated this revision to Diff 554098. dhoekwater edited the summary of this revision. dhoekwater added a comment. Remove a dependency to see if that fixes things. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157157/new/

[PATCH] D157157: [clang] Add clang support for Machine Function Splitting on AArch64

dhoekwater updated this revision to Diff 554094. dhoekwater added a comment. Hopefully get rid of a dead dependency Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157157/new/ https://reviews.llvm.org/D157157 Files:

[PATCH] D154014: [SpecialCaseList] Use Globs instead of Regex

ellis updated this revision to Diff 554089. ellis added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154014/new/ https://reviews.llvm.org/D154014 Files: clang/docs/SanitizerSpecialCaseList.rst

[PATCH] D158869: [clang] Fix timing of propagation of MSInheritanceAttr for template instantiation declarations.

tahonermann marked 2 inline comments as done. tahonermann added inline comments. Comment at: clang/lib/Sema/SemaTemplate.cpp:10110-10111 +// propagated to the new node prior to instantiation. +if (PrevDecl && PrevDecl->hasAttr()) { +

[PATCH] D158778: [CUDA] Propagate __float128 support from the host.

tra added a subscriber: ABataev. tra added a comment. @ABataev This patch breaks breaks two tests: - github.com/llvm/llvm-project/blob/main/clang/test/OpenMP/nvptx_unsupported_type_codegen.cpp - github.com/llvm/llvm-project/blob/main/clang/test/OpenMP/nvptx_unsupported_type_messages.cpp It's

[PATCH] D148381: [WIP][Clang] Add counted_by attribute

void updated this revision to Diff 554083. void added a comment. Move the isFlexibleArrayMemberLike fully into Decl and fix tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148381/new/ https://reviews.llvm.org/D148381 Files:

[PATCH] D157157: [clang] Add clang support for Machine Function Splitting on AArch64

dhoekwater updated this revision to Diff 554082. dhoekwater added a comment. Rebase onto main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157157/new/ https://reviews.llvm.org/D157157 Files: clang/lib/Driver/ToolChains/Clang.cpp

[PATCH] D157157: [clang] Add clang support for Machine Function Splitting on AArch64

dhoekwater added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5852 options::OPT_fno_split_machine_functions)) { -// This codegen pass is only available on x86-elf targets. -if (Triple.isX86() &&

[PATCH] D158071: [clang] Remove rdar links; NFC

MaskRay added a comment. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158071/new/ https://reviews.llvm.org/D158071 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D158538: [MS-ABI] Remove comdat attribute for inheriting ctor.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1d0bd8e51be2: [MSABI] Remove comdat attribute for inheriting ctor. (authored by jyu2). Changed prior to commit:

[clang] 1d0bd8e - [MSABI] Remove comdat attribute for inheriting ctor.

Author: Jennifer Yu Date: 2023-08-28T15:19:23-07:00 New Revision: 1d0bd8e51be2627f79bede54735c38b917ea04ee URL: https://github.com/llvm/llvm-project/commit/1d0bd8e51be2627f79bede54735c38b917ea04ee DIFF: https://github.com/llvm/llvm-project/commit/1d0bd8e51be2627f79bede54735c38b917ea04ee.diff

[PATCH] D158857: [clang][aarch64] Add support for the MS qualifiers __ptr32, __ptr64, __sptr, __uptr for aarch64

efriedma added a comment. If you don't have autoupgrade, that means you can't link IR built with older versions of LLVM to IR built with newer versions. llvm::UpgradeDataLayoutString is designed to fix this incompatibility. It's probably worth doing here given that it's relatively

[PATCH] D157157: [clang] Add clang support for Machine Function Splitting on AArch64

dhoekwater updated this revision to Diff 554070. dhoekwater marked 4 inline comments as done. dhoekwater edited the summary of this revision. dhoekwater added a comment. Make a comment more accurate and simplify test command functions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D159024: [Parser] Parse string literal arguments of 'availability', 'external_source_symbol' and 'uuid' attributes as unevaluated

barannikov88 created this revision. barannikov88 added reviewers: cor3ntin, aaron.ballman. Herald added a subscriber: jdoerfert. Herald added a project: All. barannikov88 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is a

[PATCH] D158641: [AArch64][Android][DRAFT] Fix FMV ifunc resolver usage on old Android APIs.

rprichard added inline comments. Comment at: compiler-rt/lib/builtins/cpu_model.c:1382 +return; +#if defined(__ANDROID__) + // ifunc resolvers don't have hwcaps in arguments on Android API lower enh wrote: > srhines wrote: > > MaskRay wrote: > > > enh

[PATCH] D141714: Fix ast print of variables with attributes

giulianobelinassi added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141714/new/ https://reviews.llvm.org/D141714 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D156821: [CodeGen] [ubsan] Respect integer overflow handling in abs builtin

brooksmoses added a comment. Just as an FYI note, this found a bug in one of our random-number generators that was taking a random 32-bit integer and applying abs() to it. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156821/new/

[PATCH] D157118: [NFC][Clang] Fix static analyzer concerns

eandrews updated this revision to Diff 554063. eandrews added a comment. Changed a dyn_cast to cast and handled ObjCAtFinallyStmt similar to how ObjCAtTryStmt is handled, i.e. just check that it exists before calling PrintRawCompoundStmt CHANGES SINCE LAST ACTION

[PATCH] D158869: [clang] Fix timing of propagation of MSInheritanceAttr for template instantiation declarations.

rnk added inline comments. Comment at: clang/lib/Sema/SemaTemplate.cpp:10110-10111 +// propagated to the new node prior to instantiation. +if (PrevDecl && PrevDecl->hasAttr()) { + Specialization->addAttr(PrevDecl->getAttr()); +

[PATCH] D158929: [clang-tidy] Add exit code support to clang-tidy-diff.py

FlashSheridan added a comment. Thank you kindly, this is looking very good on our recent changes in my manual usage. (It will take some more work before I can run it in our GitHub Action, which I’m looking forward to.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D152054: [OpenMP] Codegen support for thread_limit on target directive

vadikp-intel added a comment. Windows importing is now done by name, and new exports do not need to have an ordinal specified for them i.e. you can add a line with just the API name to dllexports. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D158857: [clang][aarch64] Add support for the MS qualifiers __ptr32, __ptr64, __sptr, __uptr for aarch64

rnk added a subscriber: efriedma. rnk added a comment. +@efriedma, since I think we had that ongoing thread about what to do with i128 alignment in data layout. Is this a reasonable way to handle the datalayout migration? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158857/new/

[PATCH] D158933: [clang] Implement -funsigned-bitfields

shafik added reviewers: aaron.ballman, clang-language-wg. shafik added a comment. Adding more reviewers for visibility. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158933/new/ https://reviews.llvm.org/D158933 ___ cfe-commits mailing list

[PATCH] D159018: [clang][modules] Add a c23 module feature

iana added a comment. Would we want to back port this to llvm 17? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159018/new/ https://reviews.llvm.org/D159018 ___ cfe-commits mailing list

[PATCH] D157963: [clang-format] Annotate constructor/destructor names

owenpan updated this revision to Diff 554051. owenpan added a comment. Fixed the crash and added a test case in `TokenAnnotatorTest.cpp`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157963/new/ https://reviews.llvm.org/D157963 Files: clang/lib/Format/TokenAnnotator.cpp

[PATCH] D158223: [clang] Add clang::unnamed_addr attribute that marks globals' address as not significant

aeubanks added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:1416-1417 +not significant. This allows global constants with the same contents to be +merged. This can break global pointer identity, i.e. two different globals have +the same address. +

[PATCH] D159018: [clang][modules] Add a c23 module feature

iana created this revision. iana added reviewers: ChuanqiXu, Bigcheese, v.g.vassilev, aaron.ballman. Herald added a subscriber: ributzka. Herald added a project: All. iana requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add a c23 module

[PATCH] D157963: [clang-format] Annotate constructor/destructor names

owenpan added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3135 + if (!Tok) +break; +} When simplifying the function, I forgot that we are in the inner loop here and thus `break` won't exit the outer loop. Repository: rG

[PATCH] D139730: [OpenMP][DeviceRTL][AMDGPU] Support code object version 5

yaxunl accepted this revision. yaxunl added a comment. LGTM. Thanks Comment at: clang/test/CodeGenCUDA/amdgpu-code-object-version-linking.cu:12 +// RUN: llvm-link %t_0 %t_5 -o -| llvm-dis -o - | FileCheck -check-prefix=LINKED5 %s + +#include "Inputs/cuda.h"

[PATCH] D156901: [OpenMP] Change OpenMP default version in documentation and help text for -fopenmp-version

AntonRydahl updated this revision to Diff 554049. AntonRydahl added a comment. Rebased on main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156901/new/ https://reviews.llvm.org/D156901 Files: clang/docs/OpenMPSupport.rst

[PATCH] D157913: [WIP][Coverage] Allow Clang coverage to be used with debug info correlation.

zequanwu updated this revision to Diff 554048. zequanwu added a comment. __llvm_prf_names section in the binary could be non-zero because non-instrumented function names are store there to indicate execution of 0. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D159016: [clang] Fix assertion failure using -MJ with -fsyntax-only

benlangmuir created this revision. benlangmuir added a reviewer: MaskRay. Herald added a project: All. benlangmuir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. If there is no output filename we should not assert when writing output for

[PATCH] D158223: [clang] Add clang::unnamed_addr attribute that marks globals' address as not significant

rnk added a subscriber: dblaikie. rnk added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:1416-1417 +not significant. This allows global constants with the same contents to be +merged. This can break global pointer identity, i.e. two different globals have

[PATCH] D158803: [Sema][HLSL] Consolidate handling of HLSL attributes

bogner updated this revision to Diff 554044. bogner added a comment. - Now with more const - Added DiagnoseHLSLAttrStageMismatch and avoided using raw strings in diagnostics Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158803/new/

[PATCH] D152054: [OpenMP] Codegen support for thread_limit on target directive

mstorsjo added subscribers: vadikp-intel, natgla. mstorsjo added a comment. In D152054#4620927 , @mstorsjo wrote: > This new test is failing on Windows, due to `__kmpc_set_thread_limit` not > being exported - see e.g. >

[PATCH] D158407: [clang][dataflow] #llvm #flow-analysis Simplify formula at CNF construction time, and short-cut solving of known contradictory formulas.

burakemir added a comment. Thanks for the review. PTAL. Comment at: clang/lib/Analysis/FlowSensitive/WatchedLiteralsSolver.cpp:426 + // considered for the simplification of earlier clauses. Do a final + // pass to find more opportunities for simplification. + CNFFormula

[PATCH] D158407: [clang][dataflow] #llvm #flow-analysis Simplify formula at CNF construction time, and short-cut solving of known contradictory formulas.

burakemir updated this revision to Diff 554040. burakemir marked 2 inline comments as done. burakemir added a comment. Addressing reviewer comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158407/new/ https://reviews.llvm.org/D158407 Files:

[PATCH] D159010: [Driver,X86] Ignore -mfpmath= for assembler input

This revision was automatically updated to reflect the committed changes. Closed by commit rG081afa3d04a4: [Driver,X86] Ignore -mfpmath= for assembler input (authored by MaskRay). Changed prior to commit: https://reviews.llvm.org/D159010?vs=554010=554037#toc Repository: rG LLVM Github

[clang] 081afa3 - [Driver,X86] Ignore -mfpmath= for assembler input

Author: Fangrui Song Date: 2023-08-28T13:37:33-07:00 New Revision: 081afa3d04a4bc0d43c62b5b0e5a84f86a8a70ec URL: https://github.com/llvm/llvm-project/commit/081afa3d04a4bc0d43c62b5b0e5a84f86a8a70ec DIFF: https://github.com/llvm/llvm-project/commit/081afa3d04a4bc0d43c62b5b0e5a84f86a8a70ec.diff

[PATCH] D157632: [Profile] Allow online merging with debug info correlation.

This revision was automatically updated to reflect the committed changes. Closed by commit rGf52f8e817ea3: [Profile] Allow online merging with debug info correlation. (authored by zequanwu). Changed prior to commit: https://reviews.llvm.org/D157632?vs=550051=554035#toc Repository: rG LLVM

[clang] f52f8e8 - [Profile] Allow online merging with debug info correlation.

Author: Zequan Wu Date: 2023-08-28T16:35:41-04:00 New Revision: f52f8e817ea36e003e8f09672de48c3c460093f4 URL: https://github.com/llvm/llvm-project/commit/f52f8e817ea36e003e8f09672de48c3c460093f4 DIFF: https://github.com/llvm/llvm-project/commit/f52f8e817ea36e003e8f09672de48c3c460093f4.diff

[PATCH] D153924: [OpenMP] Allow exceptions in target regions when offloading to GPUs

AntonRydahl marked 2 inline comments as done. AntonRydahl added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:869 bool IsThrownVarInScope) { - // Don't report an error if 'throw' is used in system headers. - if

[PATCH] D153924: [OpenMP] Allow exceptions in target regions when offloading to GPUs

AntonRydahl updated this revision to Diff 554034. AntonRydahl marked 2 inline comments as done. AntonRydahl added a comment. Replaced instances of `const llvm::Triple T` with `const llvm::Triple `. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D159010: [Driver,X86] Ignore -mfpmath= for assembler input

MaskRay added a comment. Tested by parona on Libera Chat IRC. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159010/new/ https://reviews.llvm.org/D159010 ___ cfe-commits mailing list

[clang] dd850f0 - [llvm][clang][modules] Fix test failure on big-endian bots

Author: Jan Svoboda Date: 2023-08-28T13:18:40-07:00 New Revision: dd850f0bae8f38b721e9ae6b8ba915dbf7d9bac7 URL: https://github.com/llvm/llvm-project/commit/dd850f0bae8f38b721e9ae6b8ba915dbf7d9bac7 DIFF: https://github.com/llvm/llvm-project/commit/dd850f0bae8f38b721e9ae6b8ba915dbf7d9bac7.diff

[clang] 79af92b - Reland "[clang-repl] support code completion at a REPL."

Author: Fred Fu Date: 2023-08-28T20:09:03Z New Revision: 79af92bb99dd86cc36d6a81066063fb9cd77c78a URL: https://github.com/llvm/llvm-project/commit/79af92bb99dd86cc36d6a81066063fb9cd77c78a DIFF: https://github.com/llvm/llvm-project/commit/79af92bb99dd86cc36d6a81066063fb9cd77c78a.diff LOG:

[PATCH] D158538: [MS-ABI] Remove comdat attribute for inheriting ctor.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm with some tweaks to the test. Comment at: clang/test/CodeGenCXX/ms-inheriting-ctor.cpp:41 + +// CHECK-LABEL: define internal noundef ptr

[clang-tools-extra] 752f87c - Revert "Reland "[clang-repl] support code completion at a REPL.""

Author: Vassil Vassilev Date: 2023-08-28T20:05:14Z New Revision: 752f87cd6a1a354790f4728848827077467ac15d URL: https://github.com/llvm/llvm-project/commit/752f87cd6a1a354790f4728848827077467ac15d DIFF: https://github.com/llvm/llvm-project/commit/752f87cd6a1a354790f4728848827077467ac15d.diff

[PATCH] D157632: [Profile] Allow online merging with debug info correlation.

vitalybuka added a comment. Reverted cd591e02d4563d4b90792ed5f441e1cf5b30443e Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157632/new/ https://reviews.llvm.org/D157632

[PATCH] D159000: Reland "[Profile] Allow online merging with debug info correlation."

vitalybuka added a comment. Reverted. Please continue on original review: `arc diff HEAD^ --revision D157632` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159000/new/ https://reviews.llvm.org/D159000

[PATCH] D153924: [OpenMP] Allow exceptions in target regions when offloading to GPUs

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG, see below. Comment at: clang/lib/Sema/SemaExprCXX.cpp:869 bool IsThrownVarInScope) { - // Don't report an error if 'throw' is used

[PATCH] D158929: [clang-tidy] Add exit code support to clang-tidy-diff.py

PiotrZSL updated this revision to Diff 554028. PiotrZSL marked 2 inline comments as done. PiotrZSL added a comment. Fix some Pylint issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158929/new/ https://reviews.llvm.org/D158929 Files:

[clang] cd591e0 - Revert "Reland "[Profile] Allow online merging with debug info correlation.""

Author: Vitaly Buka Date: 2023-08-28T13:01:25-07:00 New Revision: cd591e02d4563d4b90792ed5f441e1cf5b30443e URL: https://github.com/llvm/llvm-project/commit/cd591e02d4563d4b90792ed5f441e1cf5b30443e DIFF: https://github.com/llvm/llvm-project/commit/cd591e02d4563d4b90792ed5f441e1cf5b30443e.diff

[PATCH] D153924: [OpenMP] Allow exceptions in target regions when offloading to GPUs

AntonRydahl marked 2 inline comments as done. AntonRydahl added inline comments. Comment at: clang/test/OpenMP/amdgpu_exceptions.cpp:11 +// RUN: %clang_cc1 -fopenmp -triple amdgcn-amd-amdhsa -fopenmp-is-target-device -fexceptions %s -emit-llvm -S -verify=with

[PATCH] D158538: [MS-ABI] Remove comdat attribute for inheriting ctor.

jyu2 updated this revision to Diff 554025. jyu2 added a comment. Thanks @rnk. This is address his comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158538/new/ https://reviews.llvm.org/D158538 Files: clang/lib/AST/ASTContext.cpp

[PATCH] D158538: [MS-ABI] Remove comdat attribute for inheriting ctor.

jyu2 added a comment. Hi @rnk, Thank you so much for the suggestion. >> Before we do that, you should be able to delete the logic in >> CodeGenModule::getFunctionLinkage to handle inheriting constructor thunks. >> Your change should have the same effect. Can you do that, and check that it >>

[PATCH] D154382: [ClangRepl] support code completion at a REPL

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5ab25a42ba70: Reland [clang-repl] support code completion at a REPL. (authored by capfredf, committed by v.g.vassilev). Changed prior to commit:

[clang-tools-extra] 5ab25a4 - Reland "[clang-repl] support code completion at a REPL."

Author: Fred Fu Date: 2023-08-28T19:59:56Z New Revision: 5ab25a42ba70c4b50214b0e78eaaccd30696fa09 URL: https://github.com/llvm/llvm-project/commit/5ab25a42ba70c4b50214b0e78eaaccd30696fa09 DIFF: https://github.com/llvm/llvm-project/commit/5ab25a42ba70c4b50214b0e78eaaccd30696fa09.diff LOG:

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

MaskRay accepted this revision. MaskRay added inline comments. Comment at: clang/include/clang/Basic/SizedDeallocation.h:23 +namespace clang { +inline llvm::VersionTuple sizedDeallocMinVersion(llvm::Triple::OSType OS) { + switch (OS) { Does this need to be in

  1   2   3   >