[PATCH] D159167: [clang-repl][Orc] Export executable symbols in ClangReplInterpreterExceptionTests

lkail created this revision. lkail added reviewers: lhames, v.g.vassilev. Herald added a project: All. lkail requested review of this revision. Herald added subscribers: cfe-commits, wangpc. Herald added a project: clang. In Orc runtime, we use `dlopen(nullptr, ...)` to open current executable,

[PATCH] D158540: Improve error message for constexpr constructors of virtual base classes

xgupta accepted this revision. xgupta added a comment. This revision is now accepted and ready to land. LGTM, Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158540/new/ https://reviews.llvm.org/D158540 ___ cfe-commits mailing list

[PATCH] D158540: Improve error message for constexpr constructors of virtual base classes

NoumanAmir657 updated this revision to Diff 554571. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158540/new/ https://reviews.llvm.org/D158540 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Sema/SemaDeclCXX.cpp

[PATCH] D153907: [AIX] [TOC] Add -mtocdata/-mno-tocdata options on AIX

hubert.reinterpretcast added inline comments. Comment at: clang/docs/UsersManual.rst:3161 +static storage duration, including static data members of classes and +block-scope static variables will be marked with the toc-data attribute. +Alternatively, the user can specify a comma

[PATCH] D159163: [analyzer][NFC] Workaround miscompilation on recent MSVC

danix800 created this revision. danix800 added a reviewer: steakhal. danix800 added a project: clang. Herald added subscribers: manas, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: NoQ. Herald

[PATCH] D159054: [Driver] Removal of C_INCLUDE_DIRS feature

brad updated this revision to Diff 554567. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159054/new/ https://reviews.llvm.org/D159054 Files: clang/CMakeLists.txt clang/include/clang/Config/config.h.cmake clang/lib/Driver/ToolChains/Darwin.cpp

[PATCH] D158953: [analyzer] MmapWriteExecChecker: use getAs instead of castAs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2b6160ea3f9a: [analyzer] MmapWriteExecChecker: use getAs instead of castAs (authored by dingfei fd...@feysh.com). Repository: rG LLVM Github

[clang] 2b6160e - [analyzer] MmapWriteExecChecker: use getAs instead of castAs

Author: dingfei Date: 2023-08-30T12:34:23+08:00 New Revision: 2b6160ea3f9aa1e859928053ef2893fd511430f2 URL: https://github.com/llvm/llvm-project/commit/2b6160ea3f9aa1e859928053ef2893fd511430f2 DIFF: https://github.com/llvm/llvm-project/commit/2b6160ea3f9aa1e859928053ef2893fd511430f2.diff LOG:

[PATCH] D159016: [clang] Fix assertion failure using -MJ with -fsyntax-only

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Looks great! Comment at: clang/test/Driver/compilation_database_fsyntax_only.c:1 +// RUN: mkdir -p %t.workdir && cd %t.workdir +// RUN: %clang -fsyntax-only %s -MJ - 2>&1

[PATCH] D159145: [RISCV] Don't add -unaligned-scalar-mem to target features by default.

craig.topper updated this revision to Diff 554561. craig.topper added a comment. Remove change to sifive-x280. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159145/new/ https://reviews.llvm.org/D159145 Files:

[PATCH] D117929: [XRay] Add support for RISCV

MaskRay added inline comments. Comment at: compiler-rt/lib/xray/xray_trampoline_riscv32.S:54 + // Handler address will be null if it is not set + beq a2, x0, FunctionEntry_restore + This local symbol doesn't seem useful. We can just use numbers

[PATCH] D159159: [PowerPC] Disable float128 on AIX in Clang

qiucf created this revision. qiucf added a reviewer: PowerPC. Herald added subscribers: steven.zhang, shchenz, kbarton, nemanjai. Herald added a project: All. qiucf requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. PowerPC AIX backend does

[PATCH] D159068: [clang][X86] Update excessive register save diagnostic to more closely follow the interrupt attribute spec

This revision was automatically updated to reflect the committed changes. Closed by commit rGfa1dc06a1b39: [clang][X86] Update excessive register save diagnostic to more closely follow… (authored by antangelo, committed by pengfei). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] fa1dc06 - [clang][X86] Update excessive register save diagnostic to more closely follow the interrupt attribute spec

Author: Antonio Abbatangelo Date: 2023-08-30T11:52:04+08:00 New Revision: fa1dc06a1b3997f025b0d81539c31a74e6b6ec79 URL: https://github.com/llvm/llvm-project/commit/fa1dc06a1b3997f025b0d81539c31a74e6b6ec79 DIFF:

[PATCH] D158540: Improve error message for constexpr constructors of virtual base classes

xgupta added a subscriber: rsmith. xgupta added a comment. Just address @rsmith, I think after that we are fine to commit this review. > + "%sub{select_special_member_kind}0 cannot be 'constexpr' in a class or > struct with virtual base classes">; Please don't say "class or struct" here.

[PATCH] D159145: [RISCV] Don't add -unaligned-scalar-mem to target features by default.

wangpc added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVProcessors.td:185 + FeatureStdExtZbb, + FeatureUnalignedScalarMem], [TuneSiFive7,

[PATCH] D158376: [Driver] move DragonFly header search path management to the driver

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf3476332e453: [Driver] move DragonFly header search path management to the driver (authored by brad). Changed prior to commit:

[clang] f347633 - [Driver] move DragonFly header search path management to the driver

Author: Brad Smith Date: 2023-08-29T23:18:42-04:00 New Revision: f3476332e4531a667063b8980de1fbc5fb4a6251 URL: https://github.com/llvm/llvm-project/commit/f3476332e4531a667063b8980de1fbc5fb4a6251 DIFF: https://github.com/llvm/llvm-project/commit/f3476332e4531a667063b8980de1fbc5fb4a6251.diff

[PATCH] D158376: [Driver] move DragonFly header search path management to the driver

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Looks great! Comment at: clang/lib/Lex/InitHeaderSearch.cpp:331 - case llvm::Triple::DragonFly: -AddPath("/usr/include/c++/5.0", CXXSystem, false); -break;

[PATCH] D158132: [Driver] move ELFIAMCU / RTEMS header search path management to the driver

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd267990e8c53: [Driver] move ELFIAMCU / RTEMS header search path management to the driver (authored by brad). Repository: rG LLVM Github Monorepo

[PATCH] D158920: Delete CloudABI support

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5165593a97a0: Delete CloudABI support (authored by brad). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] d267990 - [Driver] move ELFIAMCU / RTEMS header search path management to the driver

Author: Brad Smith Date: 2023-08-29T23:04:02-04:00 New Revision: d267990e8c5329de76f0bb1673954ebbd666afc0 URL: https://github.com/llvm/llvm-project/commit/d267990e8c5329de76f0bb1673954ebbd666afc0 DIFF: https://github.com/llvm/llvm-project/commit/d267990e8c5329de76f0bb1673954ebbd666afc0.diff

[clang] 5165593 - Delete CloudABI support

Author: Brad Smith Date: 2023-08-29T22:57:30-04:00 New Revision: 5165593a97a04caad553cb0c213d3b3d359b1853 URL: https://github.com/llvm/llvm-project/commit/5165593a97a04caad553cb0c213d3b3d359b1853 DIFF: https://github.com/llvm/llvm-project/commit/5165593a97a04caad553cb0c213d3b3d359b1853.diff

[PATCH] D158132: [Driver] move ELFIAMCU / RTEMS header search path management to the driver

brad updated this revision to Diff 554553. brad added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158132/new/ https://reviews.llvm.org/D158132 Files: clang/lib/Lex/InitHeaderSearch.cpp Index:

[PATCH] D151938: [clang][index] NFCI: Make `CXFile` a `FileEntryRef`

Jake-Egan added a comment. Sorry for the late response @jansvoboda11, when `lookupModuleFile` is called, the file `build/tools/clang/test/Index/Core/Output/index-with-module.m.tmp.mcp/A03A61VI43WA/ModA-21USRMHJNU3PG.pcm` doesn't exist. So it seems there's some issue with the creation of the

[PATCH] D158376: [Driver] move DragonFly header search path management to the driver

brad added inline comments. Comment at: clang/lib/Lex/InitHeaderSearch.cpp:331 - case llvm::Triple::DragonFly: -AddPath("/usr/include/c++/5.0", CXXSystem, false); -break; MaskRay wrote: > 5.0 becomes 8.0 after move? > 5.0 becomes 8.0 after move? Read

[PATCH] D159145: [RISCV] Don't add -unaligned-scalar-mem to target features by default.

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVProcessors.td:185 + FeatureStdExtZbb, + FeatureUnalignedScalarMem], [TuneSiFive7,

[PATCH] D158376: [Driver] move DragonFly header search path management to the driver

MaskRay added inline comments. Comment at: clang/lib/Lex/InitHeaderSearch.cpp:331 - case llvm::Triple::DragonFly: -AddPath("/usr/include/c++/5.0", CXXSystem, false); -break; 5.0 becomes 8.0 after move? Repository: rG LLVM Github Monorepo CHANGES

[clang] d1bc6f9 - [Clang][CMake] Remove GCC option override in BOLT.cmake

Author: Amir Aupov Date: 2023-08-29T19:41:03-07:00 New Revision: d1bc6f9953ccc351df835a40146569084ba5754d URL: https://github.com/llvm/llvm-project/commit/d1bc6f9953ccc351df835a40146569084ba5754d DIFF: https://github.com/llvm/llvm-project/commit/d1bc6f9953ccc351df835a40146569084ba5754d.diff

[PATCH] D159145: [RISCV] Don't add -unaligned-scalar-mem to target features by default.

wangpc added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVProcessors.td:185 + FeatureStdExtZbb, + FeatureUnalignedScalarMem], [TuneSiFive7,

[PATCH] D158948: [clang][ASTImporter] Add import of type-related nodes

danix800 added a comment. Changes planned for https://reviews.llvm.org/D158872 is still under discussion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158948/new/ https://reviews.llvm.org/D158948 ___

[PATCH] D158948: [clang][ASTImporter] Add import of type-related nodes

danix800 updated this revision to Diff 554545. danix800 added a comment. 1. Simplify error handling 2. Remove unnecessary tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158948/new/ https://reviews.llvm.org/D158948 Files:

[PATCH] D158614: [UBSan] Disable the function sanitizer on an execute-only target.

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang/lib/Basic/Sanitizers.cpp:126 + // execute-only output (no data access to code sections). + if (const llvm::opt::Arg *A = +

[PATCH] D159068: [clang][X86] Update excessive register save diagnostic to more closely follow the interrupt attribute spec

antangelo added a comment. Thank you for the quick reviews! I don't have currently have commit access to commit the changes myself, is it possible for someone to commit on my behalf? My name and email are: Name: Antonio Abbatangelo Email: cont...@antangelo.com Repository: rG LLVM Github

[PATCH] D158872: [clang][ASTMatchers] Add a few type-related Matchers

danix800 added a comment. In D158872#4626272 , @sammccall wrote: > In D158872#4626095 , @aaron.ballman > wrote: > >> Out of curiosity, are you testing on Windows with MSVC? My understanding on >> build time

[PATCH] D158475: [driver] Refactor getRuntimePaths. NFC

glandium added a comment. In D158475#4626636 , @smeenai wrote: > I'm halfway through an implementation of this, but I just realized that on > Android, Clang never searches for C++ headers installed alongside the driver: >

[PATCH] D152495: [Clang][SemaCXX] Add unused warning for variables declared in condition expressions

This revision was automatically updated to reflect the committed changes. Closed by commit rG92023b150990: Reland [Clang][SemaCXX] Add unused warning for variables declared in condition… (authored by hazohelet). Changed prior to commit: https://reviews.llvm.org/D152495?vs=550443=554539#toc

[PATCH] D158016: [NFC] Remove unused variables declared in conditions

This revision was automatically updated to reflect the committed changes. Closed by commit rG01b88dd66d9d: [NFC] Remove unused variables declared in conditions (authored by hazohelet). Changed prior to commit: https://reviews.llvm.org/D158016?vs=550438=554538#toc Repository: rG LLVM Github

[clang] 92023b1 - Reland "[Clang][SemaCXX] Add unused warning for variables declared in condition expressions"

Author: Takuya Shimizu Date: 2023-08-30T10:05:10+09:00 New Revision: 92023b15099012a657da07ebf49dd7d94a260f84 URL: https://github.com/llvm/llvm-project/commit/92023b15099012a657da07ebf49dd7d94a260f84 DIFF:

[clang] 01b88dd - [NFC] Remove unused variables declared in conditions

Author: Takuya Shimizu Date: 2023-08-30T10:05:06+09:00 New Revision: 01b88dd66d9d52d3f531a7d490e18c549f36f445 URL: https://github.com/llvm/llvm-project/commit/01b88dd66d9d52d3f531a7d490e18c549f36f445 DIFF:

[PATCH] D157813: [Driver][VE] Support VPU flag as a feature for VE

MaskRay accepted this revision. MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/VE.cpp:22 + std::vector ) { + // Defaults. + bool EnableVPU = true; kaz7 wrote: > MaskRay wrote: > > Delete the comment. The

[PATCH] D157331: [clang] Implement C23

ZijunZhao marked an inline comment as not done. ZijunZhao added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:388 + } + // First two arguments should be integers. aaron.ballman wrote: > I keeps my original code because it just checks once but

[PATCH] D157331: [clang] Implement C23

ZijunZhao updated this revision to Diff 554534. ZijunZhao marked 3 inline comments as done. ZijunZhao added a comment. 1. Remove pure integer check to the right place 2. Update error msg and all related tests 3. Add explanations to header file Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D148381: [WIP][Clang] Add counted_by attribute

void updated this revision to Diff 554533. void added a comment. Fix some issues Nick pointed out. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148381/new/ https://reviews.llvm.org/D148381 Files: clang/include/clang/AST/Decl.h

[PATCH] D148381: [WIP][Clang] Add counted_by attribute

void marked 4 inline comments as done. void added a comment. In D148381#4625462 , @nickdesaulniers wrote: > I assume you plan to add some clang CodeGen tests at some point? Yes. :-) Comment at:

[PATCH] D159054: [Driver] Removal of C_INCLUDE_DIRS feature

brad added a comment. Just FYI I am not in a rush to commit this. I am posting this more so as a means of prodding for discussion of the feature. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159054/new/ https://reviews.llvm.org/D159054

[PATCH] D157813: [Driver][VE] Support VPU flag as a feature for VE

kaz7 marked 2 inline comments as done. kaz7 added a comment. In D157813#4621978 , @MaskRay wrote: >> [VE][Clang] Change to enable VPU flag by default > > For components like llvm/, clang/, we usually use a more specific tag. I'd > pick `[Driver]` over

[PATCH] D157813: [VE][Clang] Change to enable VPU flag by default

kaz7 marked an inline comment as done. kaz7 added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/VE.cpp:22 + std::vector ) { + // Defaults. + bool EnableVPU = true; MaskRay wrote: > Delete the comment. The code speaks

[PATCH] D157813: [VE][Clang] Change to enable VPU flag by default

kaz7 updated this revision to Diff 554528. kaz7 added a comment. Change to not control backend default bahavior but support VPU flag in the backend for VE. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157813/new/ https://reviews.llvm.org/D157813

[clang] 8f48392 - clang: Update tests after is.fpclass combine change

Author: Matt Arsenault Date: 2023-08-29T19:46:24-04:00 New Revision: 8f48392bc05a130218a15c65302f684988921307 URL: https://github.com/llvm/llvm-project/commit/8f48392bc05a130218a15c65302f684988921307 DIFF:

[PATCH] D148381: [WIP][Clang] Add counted_by attribute

void added a comment. In D148381#4626229 , @serge-sans-paille wrote: > Jumping a bit late in the thread, apologize in advance if I missed something. > > The GCC version of the attributes seems to be `element_count` (as found in > the link

[PATCH] D159137: [AIX] Fix Link Issue when `-fprofile-update=[atomic|prefer-atomic]` is in Effect

qiongsiwu1 marked 2 inline comments as done. qiongsiwu1 added inline comments. Comment at: clang/test/Driver/fprofile-update.c:17 +// AIX specific tests +// RUN: %if system-aix %{ %clang -### %s -fprofile-generate -fprofile-update=atomic 2>&1 | FileCheck %s --check-prefix=AIX

[PATCH] D159137: [AIX] Fix Link Issue when `-fprofile-update=[atomic|prefer-atomic]` is in Effect

qiongsiwu1 updated this revision to Diff 554523. qiongsiwu1 added a comment. Address code review feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159137/new/ https://reviews.llvm.org/D159137 Files: clang/lib/Driver/ToolChains/AIX.cpp clang/test/Driver/fprofile-update.c

[PATCH] D153924: [OpenMP] Allow exceptions in target regions when offloading to GPUs

AntonRydahl updated this revision to Diff 554520. AntonRydahl added a comment. Updating the line numbers in the unit tests to match the addition of `// REQUIRES: ` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153924/new/

[PATCH] D159133: [Sema] Make C++ functional-style cast warn about dropped qualifiers (-Wcast-qual)

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. This seems like it will generate warning cleanup work for vendors, so I'll mention #clang-vendors , but I think the code looks good. I don't think it

[PATCH] D159103: [Driver][HLSL] Improve diagnostics for invalid shader model and stage

bogner added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:710-716 + "Shader model is required in target '%0' for DXIL generation">; +def err_drv_dxil_unsupported_shader_model : Error< + "Shader model '%0' in target '%1' is invalid for DXIL

[PATCH] D158475: [driver] Refactor getRuntimePaths. NFC

smeenai added a comment. In D158475#4623852 , @glandium wrote: > In D158475#4623842 , @smeenai wrote: > >> In D158475#4623471 , @glandium >> wrote: >> >>> This conflicts

[PATCH] D117929: [XRay] Add support for RISCV

ashwin98 updated this revision to Diff 554513. ashwin98 added a comment. Sorry - I missed adding updates with the last diff - I think I've addressed most of the comments. Just realized that the diff didn't include context, updated that as well. CHANGES SINCE LAST ACTION

[clang] 7af0eff - Revert "[OpenMP] Allow exceptions in target regions when offloading to GPUs"

Author: antonrydahl Date: 2023-08-29T15:59:47-07:00 New Revision: 7af0eff5405bb88dc96c0b19892da0fbb44db433 URL: https://github.com/llvm/llvm-project/commit/7af0eff5405bb88dc96c0b19892da0fbb44db433 DIFF: https://github.com/llvm/llvm-project/commit/7af0eff5405bb88dc96c0b19892da0fbb44db433.diff

Re: [PATCH] D158540: Improve error message for constexpr constructors of virtual base classes

On Tue, 22 Aug 2023 at 12:43, Nouman Amir via Phabricator via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Index: clang/include/clang/Basic/DiagnosticSemaKinds.td > === > --- clang/include/clang/Basic/DiagnosticSemaKinds.td >

[PATCH] D159145: [RISCV] Don't add -unaligned-scalar-mem to target features by default.

craig.topper created this revision. craig.topper added reviewers: wangpc, kito-cheng, asb, reames, jrtc27. Herald added subscribers: jobnoorman, luke, sunshaoce, VincentWu, vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult,

[PATCH] D159137: [AIX] Fix Link Issue when `-fprofile-update=[atomic|prefer-atomic]` is in Effect

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:440 + StringRef Val = A->getValue(); + if (Val == "atomic" || Val == "prefer-atomic") +CmdArgs.push_back("-latomic"); qiongsiwu1 wrote: > This check here is copied

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

MaskRay added inline comments. Comment at: clang/include/clang/Basic/SizedDeallocation.h:23 +namespace clang { +inline llvm::VersionTuple sizedDeallocMinVersion(llvm::Triple::OSType OS) { + switch (OS) { wangpc wrote: > MaskRay wrote: > > Does this need to be

[PATCH] D153924: [OpenMP] Allow exceptions in target regions when offloading to GPUs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4c62e943b717: [OpenMP] Allow exceptions in target regions when offloading to GPUs (authored by AntonRydahl). Repository: rG LLVM Github Monorepo

[clang] 4c62e94 - [OpenMP] Allow exceptions in target regions when offloading to GPUs

Author: Anton Rydahl Date: 2023-08-29T15:05:59-07:00 New Revision: 4c62e943b7178127861ca39163a0ed4caeb14943 URL: https://github.com/llvm/llvm-project/commit/4c62e943b7178127861ca39163a0ed4caeb14943 DIFF: https://github.com/llvm/llvm-project/commit/4c62e943b7178127861ca39163a0ed4caeb14943.diff

[PATCH] D159133: [Sema] Make C++ functional-style cast warn about dropped qualifiers (-Wcast-qual)

shafik added a comment. I think this makes sense especially if it matches up w/ gcc but would like to see more feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159133/new/ https://reviews.llvm.org/D159133

[PATCH] D159024: [Parser] Parse string literal arguments of 'availability', 'external_source_symbol' and 'uuid' attributes as unevaluated

barannikov88 updated this revision to Diff 554497. barannikov88 added a comment. Update the failing test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159024/new/ https://reviews.llvm.org/D159024 Files: clang/lib/Parse/ParseDecl.cpp

[PATCH] D159133: [Sema] Make C++ functional-style cast warn about dropped qualifiers (-Wcast-qual)

shafik added reviewers: aaron.ballman, clang-language-wg. shafik added a comment. Add more reviewers for visibility. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159133/new/ https://reviews.llvm.org/D159133

[PATCH] D152752: [MS] Fix passing aligned records by value in some cases

rnk added a comment. I put together a fix here: https://github.com/llvm/llvm-project/compare/main...rnk:llvm-project:fix-vararg-align I don't have arcanist set up like I used to, and I don't write as much code as I used to, so I kind of want to submit this as a pull request as soon as they

[PATCH] D159126: [Clang] Add captures to the instantiation scope of lambda call operators

beanz added a comment. Yea, the gist of it is that in HLSL `this` is a reference not a pointer, which means the `CXXThisExpr` is always an LValue. I think the right fix for this is to cleanup the `CXXThisExpr` creation code and create a `CXXThisExpr::Create` method like the other AST nodes.

[PATCH] D159126: [Clang] Add captures to the instantiation scope of lambda call operators

cor3ntin added a comment. @beanz Oh wow, excellent, i did not expect a solution so fast! I'm glad to know there may indeed be an issue with HLSL rather than this patch because I'm not sure I could have come up with a different fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D159126: [Clang] Add captures to the instantiation scope of lambda call operators

beanz added a comment. @cor3ntin, I know what the problem is and I think I can put up a review for a fix tonight or (more likely) tomorrow. Is that okay? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159126/new/ https://reviews.llvm.org/D159126

[PATCH] D159138: [clang][Sema] Fix format size estimator's handling of %o, %x, %X with alternative form

hazohelet created this revision. hazohelet added reviewers: aaron.ballman, nickdesaulniers, serge-sans-paille. Herald added a project: All. hazohelet requested review of this revision. Herald added a project: clang. The wrong handling of %x specifier with alternative form causes a false positive

[PATCH] D158540: Improve error message for constexpr constructors of virtual base classes

NoumanAmir657 updated this revision to Diff 554489. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158540/new/ https://reviews.llvm.org/D158540 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Sema/SemaDeclCXX.cpp

[PATCH] D154287: [clang-tidy] Add modernize-use-std-format check

mikecrowe updated this revision to Diff 554486. mikecrowe edited the summary of this revision. mikecrowe added a comment. Fix ReleaseNotes order and remove unnecessary .html from list.rst Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154287/new/

[PATCH] D159137: [AIX] Fix Link Issue when `-fprofile-update=[atomic|prefer-atomic]` is in Effect

qiongsiwu1 added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:440 + StringRef Val = A->getValue(); + if (Val == "atomic" || Val == "prefer-atomic") +CmdArgs.push_back("-latomic"); This check here is copied from

[PATCH] D158540: Improve error message for constexpr constructors of virtual base classes

NoumanAmir657 updated this revision to Diff 554485. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158540/new/ https://reviews.llvm.org/D158540 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Sema/SemaDeclCXX.cpp

[PATCH] D159137: [AIX] Fix Link Issue when `-fprofile-update=[atomic|prefer-atomic]` is in Effect

qiongsiwu1 created this revision. qiongsiwu1 added reviewers: w2yehia, MaskRay. qiongsiwu1 added a project: clang. Herald added a project: All. qiongsiwu1 requested review of this revision. Herald added a subscriber: cfe-commits. https://reviews.llvm.org/D157280 enabled `-fprofile-update` for

[clang] 0863051 - Reland "[clang-format] Annotate constructor/destructor names"

Author: Owen Pan Date: 2023-08-29T13:14:52-07:00 New Revision: 0863051208870b284a1ee899defc0ba2b6e53fc4 URL: https://github.com/llvm/llvm-project/commit/0863051208870b284a1ee899defc0ba2b6e53fc4 DIFF: https://github.com/llvm/llvm-project/commit/0863051208870b284a1ee899defc0ba2b6e53fc4.diff

[PATCH] D158614: [UBSan] Disable the function sanitizer on an execute-only target.

MaggieYi added inline comments. Comment at: clang/include/clang/Basic/DiagnosticCommonKinds.td:326 def err_unsupported_abi_for_opt : Error<"'%0' can only be used with the '%1' ABI">; +def err_unsupported_opt_for_execute_only_target +: Error<"unsupported option '%0' for the

[PATCH] D158614: [UBSan] Disable the function sanitizer on an execute-only target.

MaggieYi updated this revision to Diff 554474. MaggieYi marked 7 inline comments as done. MaggieYi added a comment. Thanks @MaskRay, I have updated the patch following your suggestions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158614/new/ https://reviews.llvm.org/D158614 Files:

[clang] 452cb7f - Reland "[clang-repl] Adapt to the recent dylib-related changes in ORC."

Author: Vassil Vassilev Date: 2023-08-29T19:42:58Z New Revision: 452cb7f20bc7b976eb6fec4ac9f2d902f4175c08 URL: https://github.com/llvm/llvm-project/commit/452cb7f20bc7b976eb6fec4ac9f2d902f4175c08 DIFF: https://github.com/llvm/llvm-project/commit/452cb7f20bc7b976eb6fec4ac9f2d902f4175c08.diff

[PATCH] D158778: [CUDA] Propagate __float128 support from the host.

tra added a comment. In D158778#4626181 , @jhuber6 wrote: > Just doing a simple example here https://godbolt.org/z/Y3E58PKMz shows that > for NVPTX we error out (as I would expect) but for AMDGPU we emit an x86 > 80-bit double. With this patch NVPTX

[PATCH] D158872: [clang][ASTMatchers] Add a few type-related Matchers

sammccall added a comment. In D158872#4626095 , @aaron.ballman wrote: > Out of curiosity, are you testing on Windows with MSVC? My understanding on > build time performance impacts was that it's debug builds with MSVC that get > hit especially hard.

[PATCH] D61670: [clang] [MinGW] Add the option -fno-autoimport

mstorsjo added a comment. In D61670#4621724 , @aeubanks wrote: > I don't have all the context here, but seems fine once the commit description > is updated with the new spelling Thanks. Yeah I've updated the commit message locally (I wonder if the `arc`

[PATCH] D157963: [clang-format] Annotate constructor/destructor names

This revision was automatically updated to reflect the committed changes. Closed by commit rG086305120887: Reland [clang-format] Annotate constructor/destructor names (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157963/new/

[PATCH] D158967: [clang][clangd] Ensure the stack bottom before building AST

sammccall added a comment. In D158967#4626156 , @rsmith wrote: > Adding another fallback in `ASTFrontendAction::ExecuteAction` seems OK to me > if that's an entry point that's commonly used by tools. (Where is that being > called from in clangd's case?

[clang] ca0aa53 - [clang-format] Handle Template Arguments with AlignConsecutiveXX

Author: Björn Schäpers Date: 2023-08-29T21:59:44+02:00 New Revision: ca0aa533656ceb806d2744c38766f70c317f1053 URL: https://github.com/llvm/llvm-project/commit/ca0aa533656ceb806d2744c38766f70c317f1053 DIFF:

[PATCH] D152752: [MS] Fix passing aligned records by value in some cases

rnk added a subscriber: mstorsjo. rnk added a comment. I need to get to it, my recollection is that @mstorsjo ran into the same issue here for mingw and made some changes, I wanted to go dig those up as a starting point. I may have completely forgotten things though. Repository: rG LLVM

[PATCH] D148381: [WIP][Clang] Add counted_by attribute

serge-sans-paille added a comment. Jumping a bit late in the thread, apologize in advance if I missed something. The GCC version of the attributes seems to be `element_count` (as found in the link https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108896 mentionned by @kees) I guess we could align

[PATCH] D159126: [Clang] Add captures to the instantiation scope of lambda call operators

beanz added a comment. I'll apply this patch and debug the issue today. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159126/new/ https://reviews.llvm.org/D159126 ___ cfe-commits mailing list

[PATCH] D158869: [clang] Fix timing of propagation of MSInheritanceAttr for template instantiation declarations.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Comment at: clang/test/CodeGenCXX/microsoft-abi-member-pointers.cpp:958 +extern template class a; +template class a; +} tahonermann wrote: > rnk wrote: > >

[PATCH] D155858: Add a concept AST node.

sammccall added a comment. OK, so I learned a bit about initializeLocal/trivial TypeSourceInfo. Mostly things I didn't want to know :-) TL;DR I think the current version of the patch is right. The crash is caused by: 1. `CheckTemplateArgument` calls `SubstType` without passing a `TypeLoc`,

[PATCH] D158778: [CUDA] Propagate __float128 support from the host.

jhuber6 added a comment. In D158778#4625892 , @tra wrote: > In D158778#4624408 , @ABataev wrote: > >> Just checks removal should be fine > > Looks like OpenMP handles long double and __float128 differently -- it

[PATCH] D153907: [AIX] [TOC] Add -mtocdata/-mno-tocdata options on AIX

syzaara updated this revision to Diff 554461. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153907/new/ https://reviews.llvm.org/D153907 Files: clang/docs/UsersManual.rst clang/include/clang/Basic/CodeGenOptions.h clang/include/clang/Basic/DiagnosticDriverKinds.td

[clang] e6cd950 - Revert "[clang-repl] Adapt to the recent dylib-related changes in ORC."

Author: Vassil Vassilev Date: 2023-08-29T19:34:20Z New Revision: e6cd950d1b4a07f8c339b6f55374e4aa229e42f7 URL: https://github.com/llvm/llvm-project/commit/e6cd950d1b4a07f8c339b6f55374e4aa229e42f7 DIFF: https://github.com/llvm/llvm-project/commit/e6cd950d1b4a07f8c339b6f55374e4aa229e42f7.diff

[PATCH] D158967: [clang][clangd] Ensure the stack bottom before building AST

rsmith added a comment. In D158967#4621361 , @zyounan wrote: >> Currently the code in CompilerInstance::ExecuteAction seems to acknowledge >> that there should be a fallback. I'm suggesting to move this fallback down >> to a function that actually runs

[PATCH] D157118: [NFC][Clang] Fix static analyzer concerns

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG39191c457715: [NFC][Clang] Fix static analyzer concerns (authored by eandrews). Herald added a project: clang. Repository: rG LLVM Github

[clang] 39191c4 - [NFC][Clang] Fix static analyzer concerns

Author: Elizabeth Andrews Date: 2023-08-29T12:23:26-07:00 New Revision: 39191c45771564b8a0930d71b4c229147cf839db URL: https://github.com/llvm/llvm-project/commit/39191c45771564b8a0930d71b4c229147cf839db DIFF:

[clang] 196d856 - [clang-repl] Adapt to the recent dylib-related changes in ORC.

Author: Vassil Vassilev Date: 2023-08-29T19:17:18Z New Revision: 196d8569d46dc5200c44e70cdf839b042148b988 URL: https://github.com/llvm/llvm-project/commit/196d8569d46dc5200c44e70cdf839b042148b988 DIFF: https://github.com/llvm/llvm-project/commit/196d8569d46dc5200c44e70cdf839b042148b988.diff

  1   2   3   >