[clang-tools-extra] [clang-tidy][modernize-use-using]fix function pointer typedef correctly (PR #65558)

https://github.com/HerrCai0907 resolved https://github.com/llvm/llvm-project/pull/65558 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][modernize-use-using]fix function pointer typedef correctly (PR #65558)

https://github.com/HerrCai0907 resolved https://github.com/llvm/llvm-project/pull/65558 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][modernize-use-using]fix function pointer typedef correctly (PR #65558)

https://github.com/HerrCai0907 updated https://github.com/llvm/llvm-project/pull/65558: >From f25a855ac2d3ec4b89f55a08e415596b3b65f142 Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Thu, 7 Sep 2023 10:14:28 +0800 Subject: [PATCH 1/2] [clang-tidy][modernize-use-using]fix function pointer

[clang-tools-extra] [clang-tidy][modernize-use-using]fix function pointer typedef correctly (PR #65558)

@@ -314,3 +314,10 @@ typedef struct { struct { int a; struct { struct { int b; } c; int d; } e; } f; typedef struct { struct { int a; } b; union { int c; float d; struct { int e; }; }; struct { double f; } g; } PR50990_siblings; // CHECK-MESSAGES: :[[@LINE-1]]:1: warning: use

[clang] c998106 - [Lex] Remove unused AddGnuCPlusPlusIncludePaths after e75f240a0432d827c28a5d77fad26a099ceb7a72

Author: Fangrui Song Date: 2023-09-06T22:25:47-07:00 New Revision: c998106a7fea2b11bee250dd1f92ed4418a08c5a URL: https://github.com/llvm/llvm-project/commit/c998106a7fea2b11bee250dd1f92ed4418a08c5a DIFF: https://github.com/llvm/llvm-project/commit/c998106a7fea2b11bee250dd1f92ed4418a08c5a.diff

[PATCH] D155978: [SPIRV] Add SPIR-V logical triple.

mpaszkowski added a comment. In D155978#4639499 , @Keenuts wrote: > In D155978#4639094 , @mpaszkowski > wrote: > >> @Keenuts Hi Nathan, thanks for the patch! I agree with your approach and I >> think that this

[PATCH] D158715: [Driver] Cleanup last vestiges of Minix / Contiki support

uabelho added inline comments. Comment at: clang/lib/Lex/InitHeaderSearch.cpp:336 - case llvm::Triple::Minix: -AddGnuCPlusPlusIncludePaths("/usr/gnu/include/c++/4.4.3", -"", "", "", triple); brad wrote: > uabelho wrote: > >

[PATCH] D158266: [OpenMP] Patch for Support to loop bind clause : Checking Parent Region

koops added a comment. Can someone please review the changes that I uploaded last week? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158266/new/ https://reviews.llvm.org/D158266 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang-format] Fix misannotation of && before noexcept (PR #65526)

https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/65526 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix misannotation of && before noexcept (PR #65526)

https://github.com/owenca approved this pull request. https://github.com/llvm/llvm-project/pull/65526 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][modernize-use-using]fix function pointer typedef correctly (PR #65558)

@@ -246,6 +246,9 @@ Changes in existing checks ` check to accurately generate fixes for reordering arguments. +- Improved :doc:`modernize-use-using` PiotrZSL wrote: put space before <, juts for visibility.

[clang-tools-extra] [clang-tidy][modernize-use-using]fix function pointer typedef correctly (PR #65558)

@@ -314,3 +314,10 @@ typedef struct { struct { int a; struct { struct { int b; } c; int d; } e; } f; typedef struct { struct { int a; } b; union { int c; float d; struct { int e; }; }; struct { double f; } g; } PR50990_siblings; // CHECK-MESSAGES: :[[@LINE-1]]:1: warning: use

[clang-tools-extra] [clang-tidy][modernize-use-using]fix function pointer typedef correctly (PR #65558)

@@ -314,3 +314,10 @@ typedef struct { struct { int a; struct { struct { int b; } c; int d; } e; } f; typedef struct { struct { int a; } b; union { int c; float d; struct { int e; }; }; struct { double f; } g; } PR50990_siblings; // CHECK-MESSAGES: :[[@LINE-1]]:1: warning: use

[clang-tools-extra] [lit] Are all RUN lines skipped in windows cmd? (PR #65242)

compnerd wrote: I think that might be a bit too accelerated. I work mostly with a fork of LLVM (https://github.com/apple/llvm-project) and do care about the usability of `cmd` as a shell. I think that Swift is a large enough consumer of LLVM to consider testing that before declaring this

[clang-tools-extra] [clang-tidy] Exclude bitwise operators in bugprone-non-zero-enum-to-bool-conversion (PR #65498)

PiotrZSL wrote: > explicit bit usage will not case false positive without this patch. Should we > consider case of operator overloading? Yes, thats a side effect due to implicit casting enums to integers. I added tests because those were missing, then I implemented version with

[clang] [APINotes] Support `SwiftImportAs` for C++ structs (PR #65323)

https://github.com/compnerd approved this pull request. https://github.com/llvm/llvm-project/pull/65323 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D92733: Fix PR25627 - false positive diagnostics involving implicit-captures in dependent lambda expressions.

faisalv added a comment. In D92733#4638319 , @cor3ntin wrote: > @Fznamznon This might be of interest to you > @faisalv are you still working on this? Yeah - sorry - been a little distracted with other stuff. I tried uploading an updated patch to

[PATCH] D159115: [clang-repl] Adapt to the recent dylib-related changes in ORC.

mgorny added a comment. In D159115#4640154 , @tuliom wrote: > This new test does not work on ppc64le. I'm sorry, by "new" you mean the version with `uintptr_t` or the original as well? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] [clang-tidy][modernize-use-using]fix function pointer typedef correctly (PR #65558)

https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65558 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][modernize-use-using]fix function pointer typedef correctly (PR #65558)

https://github.com/HerrCai0907 review_requested https://github.com/llvm/llvm-project/pull/65558 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][modernize-use-using]fix function pointer typedef correctly (PR #65558)

https://github.com/HerrCai0907 review_requested https://github.com/llvm/llvm-project/pull/65558 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][modernize-use-using]fix function pointer typedef correctly (PR #65558)

https://github.com/HerrCai0907 review_requested https://github.com/llvm/llvm-project/pull/65558 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][modernize-use-using]fix function pointer typedef correctly (PR #65558)

https://github.com/HerrCai0907 review_requested https://github.com/llvm/llvm-project/pull/65558 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][modernize-use-using]fix function pointer typedef correctly (PR #65558)

https://github.com/HerrCai0907 created https://github.com/llvm/llvm-project/pull/65558: Fixed #65055 >From f25a855ac2d3ec4b89f55a08e415596b3b65f142 Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Thu, 7 Sep 2023 10:14:28 +0800 Subject: [PATCH] [clang-tidy][modernize-use-using]fix function

[clang-tools-extra] [MLIR] Enabling Intel GPU Integration. (PR #65539)

@@ -116,6 +116,7 @@ add_definitions(-DMLIR_ROCM_CONVERSIONS_ENABLED=${MLIR_ENABLE_ROCM_CONVERSIONS}) set(MLIR_ENABLE_CUDA_RUNNER 0 CACHE BOOL "Enable building the mlir CUDA runner") set(MLIR_ENABLE_ROCM_RUNNER 0 CACHE BOOL "Enable building the mlir ROCm runner")

[clang-tools-extra] [MLIR] Enabling Intel GPU Integration. (PR #65539)

@@ -0,0 +1,223 @@ +//===- SyclRuntimeWrappers.cpp - MLIR SYCL wrapper library ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang] [MLIR] Enabling Intel GPU Integration. (PR #65539)

@@ -0,0 +1,223 @@ +//===- SyclRuntimeWrappers.cpp - MLIR SYCL wrapper library ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang] [MLIR] Enabling Intel GPU Integration. (PR #65539)

https://github.com/keryell edited https://github.com/llvm/llvm-project/pull/65539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [MLIR] Enabling Intel GPU Integration. (PR #65539)

@@ -0,0 +1,223 @@ +//===- SyclRuntimeWrappers.cpp - MLIR SYCL wrapper library ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang-tools-extra] [MLIR] Enabling Intel GPU Integration. (PR #65539)

@@ -0,0 +1,223 @@ +//===- SyclRuntimeWrappers.cpp - MLIR SYCL wrapper library ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang] [MLIR] Enabling Intel GPU Integration. (PR #65539)

@@ -0,0 +1,223 @@ +//===- SyclRuntimeWrappers.cpp - MLIR SYCL wrapper library ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang-tools-extra] [MLIR] Enabling Intel GPU Integration. (PR #65539)

@@ -0,0 +1,223 @@ +//===- SyclRuntimeWrappers.cpp - MLIR SYCL wrapper library ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang] [MLIR] Enabling Intel GPU Integration. (PR #65539)

@@ -116,6 +116,7 @@ add_definitions(-DMLIR_ROCM_CONVERSIONS_ENABLED=${MLIR_ENABLE_ROCM_CONVERSIONS}) set(MLIR_ENABLE_CUDA_RUNNER 0 CACHE BOOL "Enable building the mlir CUDA runner") set(MLIR_ENABLE_ROCM_RUNNER 0 CACHE BOOL "Enable building the mlir ROCm runner")

[clang-tools-extra] [MLIR] Enabling Intel GPU Integration. (PR #65539)

https://github.com/keryell commented: Quite interesting! At some point it would be nice to have some design document or documentation somewhere explaining how all these MLIR runners works, including this one. Globally this PR add a SYCL runner, but it is very specific for Intel Level 0. It

[PATCH] D159250: [X86][RFC] Add new option `-m[no-]evex512` to disable ZMM and 64-bit mask instructions for AVX512 features

skan accepted this revision. skan added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159250/new/ https://reviews.llvm.org/D159250 ___

[PATCH] D159250: [X86][RFC] Add new option `-m[no-]evex512` to disable ZMM and 64-bit mask instructions for AVX512 features

skan added inline comments. Comment at: llvm/lib/Target/X86/X86Subtarget.cpp:277 + + if (posAVX512F != StringRef::npos && + (posNoAVX512F == StringRef::npos || posNoAVX512F < posAVX512F)) Well. It's a very tricky implementation, but I can find out a better

[PATCH] D159167: [clang-repl][Orc] Export executable symbols in ClangReplInterpreterExceptionTests

lkail added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159167/new/ https://reviews.llvm.org/D159167 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D158920: Delete CloudABI support

emaste added a comment. In D158920#4620361 , @brad wrote: > Looking for any feedback from the FreeBSD guys. Sorry for no reply earlier, I was away for some of the summer and missed this originally. While CloudABI was a very interesting FreeBSD-related

[clang-tools-extra] [clang-tidy] Exclude bitwise operators in bugprone-non-zero-enum-to-bool-conversion (PR #65498)

HerrCai0907 wrote: explicit bit usage will not case false positive without this patch. Should we consider case of operator overloading? ```cpp bool explicitBitUsage1(EStatus value) { return (value & SUCCESS); } bool explicitBitUsage2(EStatus value) { return (value | SUCCESS); } ```

[PATCH] D159250: [X86][RFC] Add new option `-m[no-]evex512` to disable ZMM and 64-bit mask instructions for AVX512 features

pengfei added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159250/new/ https://reviews.llvm.org/D159250 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] [libc++] Implement ranges::contains (PR #65148)

https://github.com/ZijunZhaoCCK resolved https://github.com/llvm/llvm-project/pull/65148 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libc++] Implement ranges::contains (PR #65148)

https://github.com/ZijunZhaoCCK resolved https://github.com/llvm/llvm-project/pull/65148 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [libc++] Implement ranges::contains (PR #65148)

https://github.com/ZijunZhaoCCK resolved https://github.com/llvm/llvm-project/pull/65148 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libc++] Implement ranges::contains (PR #65148)

https://github.com/ZijunZhaoCCK resolved https://github.com/llvm/llvm-project/pull/65148 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [libc++] Implement ranges::contains (PR #65148)

@@ -0,0 +1,190 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang] [libc++] Implement ranges::contains (PR #65148)

@@ -0,0 +1,190 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang-tools-extra] [MLIR] Enabling Intel GPU Integration. (PR #65539)

https://github.com/silee2 edited https://github.com/llvm/llvm-project/pull/65539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [MLIR] Enabling Intel GPU Integration. (PR #65539)

https://github.com/silee2 edited https://github.com/llvm/llvm-project/pull/65539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Skip additional tests of the same case upon failure (PR #65540)

owenca wrote: Before: ``` .../llvm-project/clang/unittests/Format/FormatTestBase.h:93: Failure Expected equality of these values: Expected.str() Which is: "(\n \"x\t\");" format(Code, Style, SC_ExpectComplete,

[PATCH] D159126: [Clang] Add captures to the instantiation scope of lambda call operators

abrachet added a comment. I'm seeing libcxx failures after this patch. See https://ci.chromium.org/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b8770673168839783889/overview # .---command stderr # |

[clang] [clang-format] Skip additional tests of the same case upon failure (PR #65540)

https://github.com/owenca updated https://github.com/llvm/llvm-project/pull/65540: >From e67336055c73e9d8c1d1fccff24395ca0197e985 Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Wed, 6 Sep 2023 14:53:39 -0700 Subject: [PATCH] [clang-format] Skip additional tests of the same case upon failure A

[clang] [AST] Only dump desugared type when visibly different (PR #65214)

https://github.com/zygoloid commented: The change looks good and like a nice improvement to me. I don't think this is undoing any of the intended functional changes of @mizvekov's work. https://github.com/llvm/llvm-project/pull/65214 ___ cfe-commits

[clang] Enabling Intel GPU Integration. (PR #65539)

@@ -0,0 +1,70 @@ +//===- SerializeToSPIRV.cpp - Convert GPU kernel to SPIRV blob -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang-tools-extra] Enabling Intel GPU Integration. (PR #65539)

@@ -811,8 +812,13 @@ LogicalResult ConvertAllocOpToGpuRuntimeCallPattern::matchAndRewrite( // descriptor. Type elementPtrType = this->getElementPtrType(memRefType); auto stream = adaptor.getAsyncDependencies().front(); + + auto isHostShared = rewriter.create( +

[clang] Enabling Intel GPU Integration. (PR #65539)

@@ -0,0 +1,70 @@ +//===- SerializeToSPIRV.cpp - Convert GPU kernel to SPIRV blob -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang] Enabling Intel GPU Integration. (PR #65539)

@@ -811,8 +812,13 @@ LogicalResult ConvertAllocOpToGpuRuntimeCallPattern::matchAndRewrite( // descriptor. Type elementPtrType = this->getElementPtrType(memRefType); auto stream = adaptor.getAsyncDependencies().front(); + + auto isHostShared = rewriter.create( +

[clang-tools-extra] Enabling Intel GPU Integration. (PR #65539)

@@ -0,0 +1,70 @@ +//===- SerializeToSPIRV.cpp - Convert GPU kernel to SPIRV blob -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang-tools-extra] Enabling Intel GPU Integration. (PR #65539)

https://github.com/joker-eph commented: LGTM overall, this should likely get reviewed by @antiagainst / @kuhar ; and it's be great if you can split the independent changes and send them ahead of the e2e integration. https://github.com/llvm/llvm-project/pull/65539

[clang] Enabling Intel GPU Integration. (PR #65539)

@@ -1158,7 +1178,7 @@ LogicalResult ConvertLaunchFuncOpToGpuRuntimeCallPattern::matchAndRewrite( {function.getResult(), adaptor.getGridSizeX(), adaptor.getGridSizeY(), adaptor.getGridSizeZ(), adaptor.getBlockSizeX(), adaptor.getBlockSizeY(),

[clang-tools-extra] Enabling Intel GPU Integration. (PR #65539)

@@ -71,7 +71,8 @@ void GPUToSPIRVPass::runOnOperation() { std::unique_ptr target = spirv::getMemorySpaceToStorageClassTarget(*context); spirv::MemorySpaceToStorageClassMap memorySpaceMap = - spirv::mapMemorySpaceToVulkanStorageClass; +

[clang] Enabling Intel GPU Integration. (PR #65539)

https://github.com/joker-eph commented: LGTM overall, this should likely get reviewed by @antiagainst / @kuhar ; and it's be great if you can split the independent changes and send them ahead of the e2e integration. https://github.com/llvm/llvm-project/pull/65539

[clang] Enabling Intel GPU Integration. (PR #65539)

@@ -71,7 +71,8 @@ void GPUToSPIRVPass::runOnOperation() { std::unique_ptr target = spirv::getMemorySpaceToStorageClassTarget(*context); spirv::MemorySpaceToStorageClassMap memorySpaceMap = - spirv::mapMemorySpaceToVulkanStorageClass; +

[clang] [AST] Only dump desugared type when visibly different (PR #65214)

jrtc27 wrote: > > > So it looks like some of these changes undo some of the change introduced > > > by @mizvekov in some tests. Maybe @zygoloid or @AaronBallman has some > > > more input here. > > > > > > Do you have a pointer to such changes? > > One of the commits is here: >

[clang] [AST] Only dump desugared type when visibly different (PR #65214)

shafik wrote: > > So it looks like some of these changes undo some of the change introduced > > by @mizvekov in some tests. Maybe @zygoloid or @AaronBallman has some more > > input here. > > Do you have a pointer to such changes? One of the commits is here: 15f3cd6bfc670 I know he did a

[clang] Enabling Intel GPU Integration. (PR #65539)

https://github.com/silee2 edited https://github.com/llvm/llvm-project/pull/65539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Enabling Intel GPU Integration. (PR #65539)

https://github.com/silee2 edited https://github.com/llvm/llvm-project/pull/65539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Enabling Intel GPU Integration. (PR #65539)

https://github.com/silee2 edited https://github.com/llvm/llvm-project/pull/65539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Enabling Intel GPU Integration. (PR #65539)

https://github.com/silee2 edited https://github.com/llvm/llvm-project/pull/65539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Enabling Intel GPU Integration. (PR #65539)

https://github.com/silee2 edited https://github.com/llvm/llvm-project/pull/65539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Enabling Intel GPU Integration. (PR #65539)

https://github.com/silee2 edited https://github.com/llvm/llvm-project/pull/65539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Enabling Intel GPU Integration. (PR #65539)

https://github.com/silee2 edited https://github.com/llvm/llvm-project/pull/65539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Enabling Intel GPU Integration. (PR #65539)

https://github.com/silee2 edited https://github.com/llvm/llvm-project/pull/65539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix the for statement disappearing in AST when an error occurs in the conditional expression of the for statement (PR #65381)

@@ -2158,8 +2158,10 @@ StmtResult Parser::ParseForStatement(SourceLocation *TrailingElseLoc) { // for-range-declaration next. bool MightBeForRangeStmt = !ForRangeInfo.ParsedForRangeDecl(); ColonProtectionRAIIObject ColonProtection(*this,

[clang] [Clang] Fix the for statement disappearing in AST when an error occurs in the conditional expression of the for statement (PR #65381)

https://github.com/shafik commented: This looks good to me but I would like another set of eyes on it. https://github.com/llvm/llvm-project/pull/65381 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [Clang] Fix the for statement disappearing in AST when an error occurs in the conditional expression of the for statement (PR #65381)

https://github.com/shafik edited https://github.com/llvm/llvm-project/pull/65381 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Enabling Intel GPU Integration. (PR #65539)

https://github.com/silee2 edited https://github.com/llvm/llvm-project/pull/65539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Enabling Intel GPU Integration. (PR #65539)

https://github.com/silee2 edited https://github.com/llvm/llvm-project/pull/65539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Enabling Intel GPU Integration. (PR #65539)

https://github.com/silee2 edited https://github.com/llvm/llvm-project/pull/65539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Enabling Intel GPU Integration. (PR #65539)

https://github.com/silee2 edited https://github.com/llvm/llvm-project/pull/65539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D158715: [Driver] Cleanup last vestiges of Minix / Contiki support

brad added inline comments. Comment at: clang/lib/Lex/InitHeaderSearch.cpp:336 - case llvm::Triple::Minix: -AddGnuCPlusPlusIncludePaths("/usr/gnu/include/c++/4.4.3", -"", "", "", triple); uabelho wrote: > @brad : > I think

[PATCH] D157762: Implement [[msvc::no_unique_address]]

akhuang updated this revision to Diff 556091. akhuang added a comment. add note to the docs about no ABI compatibility Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157762/new/ https://reviews.llvm.org/D157762 Files:

[PATCH] D147655: Implement mangling rules for C++20 concepts and requires-expressions.

rsmith added a comment. Ping. Are there any further concerns here? (This obviously needs to be merged with trunk, and the `-fclang-abi-compat=` checks and release notes need to be updated to match the latest release version.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] [libc++] Implement ranges::contains (PR #65148)

https://github.com/ZijunZhaoCCK unresolved https://github.com/llvm/llvm-project/pull/65148 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [libc++] Implement ranges::contains (PR #65148)

https://github.com/ZijunZhaoCCK unresolved https://github.com/llvm/llvm-project/pull/65148 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libc++] Implement ranges::contains (PR #65148)

https://github.com/ZijunZhaoCCK updated https://github.com/llvm/llvm-project/pull/65148: >From 02e9afd761228f401df4d9f8dfaaca44ffae0c6e Mon Sep 17 00:00:00 2001 From: zijunzhao Date: Thu, 31 Aug 2023 20:08:32 + Subject: [PATCH 1/2] [libc++] Implement ranges::contains Differential

[clang-tools-extra] [libc++] Implement ranges::contains (PR #65148)

https://github.com/ZijunZhaoCCK updated https://github.com/llvm/llvm-project/pull/65148: >From 02e9afd761228f401df4d9f8dfaaca44ffae0c6e Mon Sep 17 00:00:00 2001 From: zijunzhao Date: Thu, 31 Aug 2023 20:08:32 + Subject: [PATCH 1/2] [libc++] Implement ranges::contains Differential

[clang-tools-extra] Enabling Intel GPU Integration. (PR #65539)

https://github.com/silee2 edited https://github.com/llvm/llvm-project/pull/65539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Enabling Intel GPU Integration. (PR #65539)

https://github.com/silee2 edited https://github.com/llvm/llvm-project/pull/65539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Enabling Intel GPU Integration. (PR #65539)

https://github.com/silee2 edited https://github.com/llvm/llvm-project/pull/65539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Enabling Intel GPU Integration. (PR #65539)

https://github.com/silee2 edited https://github.com/llvm/llvm-project/pull/65539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Enabling Intel GPU Integration. (PR #65539)

https://github.com/silee2 edited https://github.com/llvm/llvm-project/pull/65539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Enabling Intel GPU Integration. (PR #65539)

https://github.com/silee2 edited https://github.com/llvm/llvm-project/pull/65539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Enabling Intel GPU Integration. (PR #65539)

silee2 wrote: > I suggest to extract `mgpu` interface changes and `serializetoSpirv` pass to > 2 separate PRs. Agree. And the changes are originally from different authors so should be splitted. https://github.com/llvm/llvm-project/pull/65539 ___

[clang] Enabling Intel GPU Integration. (PR #65539)

silee2 wrote: > I suggest to extract `mgpu` interface changes and `serializetoSpirv` pass to > 2 separate PRs. Agree. And the changes are originally from different authors so should be splitted. https://github.com/llvm/llvm-project/pull/65539 ___

[clang-tools-extra] Enabling Intel GPU Integration. (PR #65539)

https://github.com/silee2 edited https://github.com/llvm/llvm-project/pull/65539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Enabling Intel GPU Integration. (PR #65539)

https://github.com/silee2 edited https://github.com/llvm/llvm-project/pull/65539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Enabling Intel GPU Integration. (PR #65539)

Hardcode84 wrote: I suggest to extract `mgpu` interface changes and `serializetoSpirv` pass to 2 separate PRs. https://github.com/llvm/llvm-project/pull/65539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] Enabling Intel GPU Integration. (PR #65539)

Hardcode84 wrote: I suggest to extract `mgpu` interface changes and `serializetoSpirv` pass to 2 separate PRs. https://github.com/llvm/llvm-project/pull/65539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] Enabling Intel GPU Integration. (PR #65539)

https://github.com/silee2 edited https://github.com/llvm/llvm-project/pull/65539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Enabling Intel GPU Integration. (PR #65539)

https://github.com/silee2 edited https://github.com/llvm/llvm-project/pull/65539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   3   4   5   >