[PATCH] D156045: [clang][Interp] Enable existing source_location tests

tbaeder added a comment. @hazohelet Thanks for noticing. Should be fixed via https://github.com/llvm/llvm-project/commit/f8074942c5a6f266abb1c4d1465a4d8115b22d43. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156045/new/

[clang] f807494 - [clang][Interp] Fix SourceLocExpr used in CXXDefaultInitExprs

Author: Timm Bäder Date: 2023-09-09T07:28:50+02:00 New Revision: f8074942c5a6f266abb1c4d1465a4d8115b22d43 URL: https://github.com/llvm/llvm-project/commit/f8074942c5a6f266abb1c4d1465a4d8115b22d43 DIFF: https://github.com/llvm/llvm-project/commit/f8074942c5a6f266abb1c4d1465a4d8115b22d43.diff

[clang-tools-extra] [MLIR] Enabling Intel GPU Integration. (PR #65539)

Jianhui-Li wrote: > > We really just need a "mlir-runner" with target-platform as command > > parameters. > > What kind of "target-platform" command parameters do you have in mind? (other > than what we do now) The current way of mlir-cpu-runner using the share library name to indicate

[clang] [MLIR] Enabling Intel GPU Integration. (PR #65539)

Jianhui-Li wrote: > > We really just need a "mlir-runner" with target-platform as command > > parameters. > > What kind of "target-platform" command parameters do you have in mind? (other > than what we do now) The current way of mlir-cpu-runner using the share library name to indicate

[clang] 358d9db - [clang] NFCI: Use `FileEntryRef` in `checkMSVCHeaderSearch()`

Author: Jan Svoboda Date: 2023-09-08T21:28:05-07:00 New Revision: 358d9dbf4f1b9b3b166139a366d0e8c5162988c0 URL: https://github.com/llvm/llvm-project/commit/358d9dbf4f1b9b3b166139a366d0e8c5162988c0 DIFF: https://github.com/llvm/llvm-project/commit/358d9dbf4f1b9b3b166139a366d0e8c5162988c0.diff

[clang] c184f27 - Fixes for Haiku tests on Win32

Author: Brad Smith Date: 2023-09-09T00:13:26-04:00 New Revision: c184f27f55ab767e8c7bec589b24daeb4177c093 URL: https://github.com/llvm/llvm-project/commit/c184f27f55ab767e8c7bec589b24daeb4177c093 DIFF: https://github.com/llvm/llvm-project/commit/c184f27f55ab767e8c7bec589b24daeb4177c093.diff

[PATCH] D159436: [clang-tidy] Add support for optional parameters in config.

felix642 updated this revision to Diff 556334. felix642 added a comment. Forgot to update a comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159436/new/ https://reviews.llvm.org/D159436 Files: clang-tools-extra/clang-tidy/ClangTidyCheck.h

[clang] 0c41681 - [clang] NFCI: Use `FileEntryRef` in `VerifyDiagnosticConsumer`

Author: Jan Svoboda Date: 2023-09-08T20:12:08-07:00 New Revision: 0c41681a0ce3ab8c4f145b30e586d25a33b75bbf URL: https://github.com/llvm/llvm-project/commit/0c41681a0ce3ab8c4f145b30e586d25a33b75bbf DIFF: https://github.com/llvm/llvm-project/commit/0c41681a0ce3ab8c4f145b30e586d25a33b75bbf.diff

[PATCH] D159436: [clang-tidy] Add support for optional parameters in config.

felix642 added a comment. Hi @PiotrZSL and @carlosgalvezp, I have updated my PR based on your comments. Let me know what you think. What if: "MinimumLength" is a boolean. It's default value (if not specified) is True. And a user wants to set it as "False" here Wouldn't that

[PATCH] D159436: [clang-tidy] Add support for optional parameters in config.

felix642 updated this revision to Diff 556333. felix642 added a comment. Moved to a new method, changed tests, changed documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159436/new/ https://reviews.llvm.org/D159436 Files:

[clang] 523c471 - Reapply "[clang] NFCI: Adopt `SourceManager::getFileEntryRefForID()`"

Author: Jan Svoboda Date: 2023-09-08T19:04:01-07:00 New Revision: 523c471250a49b5603bd907ff05535f18ef61c91 URL: https://github.com/llvm/llvm-project/commit/523c471250a49b5603bd907ff05535f18ef61c91 DIFF: https://github.com/llvm/llvm-project/commit/523c471250a49b5603bd907ff05535f18ef61c91.diff

[PATCH] D159436: [clang-tidy] Add support for optional parameters in config.

felix642 updated this revision to Diff 556331. felix642 added a comment. Removed false option Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159436/new/ https://reviews.llvm.org/D159436 Files: clang-tools-extra/clang-tidy/ClangTidyCheck.h

[PATCH] D158948: [clang][ASTImporter] Add import of type-related nodes

haowei added a comment. In D158948#4642475 , @danix800 wrote: > In D158948#4642422 , @haowei wrote: > >> Looking at >>

[PATCH] D158948: [clang][ASTImporter] Add import of type-related nodes

danix800 added a comment. @haowei I noticed https://github.com/llvm/llvm-project/pull/65823, is it related to your work? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158948/new/ https://reviews.llvm.org/D158948

[PATCH] D158948: [clang][ASTImporter] Add import of type-related nodes

danix800 added a comment. In D158948#4642422 , @haowei wrote: > Looking at > https://github.com/llvm/llvm-project/blob/37a20cc68f545647e614c5ba4ae311dc3fd277e9/clang/lib/Testing/CommandLineArgs.cpp#L47, > this is were the unreachable code was hit. Is

[clang] [clang][VarDecl] Reset un-evaluated constant for all C++ modes (PR #65818)

shafik wrote: LGTM, thank you for the quick fix! https://github.com/llvm/llvm-project/pull/65818 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D159414: [Driver] Fixes for header / library paths on Haiku

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. brad marked 2 inline comments as not done. Closed by commit rGa3ba9d697b17: [Driver]

[clang] a3ba9d6 - [Driver] Fixes for header / library paths on Haiku

Author: Brad Smith Date: 2023-09-08T21:34:31-04:00 New Revision: a3ba9d697b17ebb969b86b5c3b34b102fd22e583 URL: https://github.com/llvm/llvm-project/commit/a3ba9d697b17ebb969b86b5c3b34b102fd22e583 DIFF: https://github.com/llvm/llvm-project/commit/a3ba9d697b17ebb969b86b5c3b34b102fd22e583.diff

[clang] [clang-format] BreakBeforeNoexceptSpecifier option added (PR #65808)

@@ -593,6 +593,47 @@ struct FormatStyle { /// \version 3.3 bool AllowAllParametersOfDeclarationOnNextLine; + /// Different ways to break before a noexcept specifier. + enum BreakBeforeNoexceptSpecifierStyle : int8_t { +/// No line break allowed. +/// \code +

[clang] [clang-format] BreakBeforeNoexceptSpecifier option added (PR #65808)

https://github.com/rymiel approved this pull request. https://github.com/llvm/llvm-project/pull/65808 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] BreakBeforeNoexceptSpecifier option added (PR #65808)

https://github.com/rymiel edited https://github.com/llvm/llvm-project/pull/65808 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D159339: [urgent][CodeGen] First check the kind and then the llvm::Function properties.

daltenty added a comment. In D159339#4642210 , @v.g.vassilev wrote: > In D159339#4642147 , @daltenty > wrote: > >> FYI: I tried to reproduce this on `powerpc64le-linux-gnu` at `-02` and >> didn't see it at

[clang] [Driver] Also use --no-as-needed when linking libatomic on Linux/Sparc (PR #65827)

https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65827 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Also use --no-as-needed when linking libatomic on Linux/Sparc (PR #65827)

https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65827 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Also use --no-as-needed when linking libatomic on Linux/Sparc (PR #65827)

https://github.com/brad0 review_requested https://github.com/llvm/llvm-project/pull/65827 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Also use --no-as-needed when linking libatomic on Linux/Sparc (PR #65827)

https://github.com/brad0 created https://github.com/llvm/llvm-project/pull/65827: None >From 7d31337b87043828f96129e2aa2a02eaaccc3e5e Mon Sep 17 00:00:00 2001 From: Brad Smith Date: Fri, 8 Sep 2023 17:44:48 -0400 Subject: [PATCH] [Driver] Also use --no-as-needed when linking libatomic on

[clang] [StackProtector] Clear out stack protector slot (PR #65461)

https://github.com/bwendling closed https://github.com/llvm/llvm-project/pull/65461 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [StackProtector] Clear out stack protector slot (PR #65461)

bwendling wrote: >From the feedback, I think this change may be a bit premature. As I mentioned, >there's already a way to zero the stack upon entry to the function. What I *really* want to do is zero out the register that held the stack guard value, like in the GCC patch @nickdesaulniers

[clang] [RISCV] Support predefined marcro __riscv_misaligned_{fast,avoid}. (PR #65756)

@@ -322,6 +327,8 @@ bool RISCVTargetInfo::handleTargetFeatures(std::vector , if (ISAInfo->hasExtension("zfh") || ISAInfo->hasExtension("zhinx")) HasLegalHalfType = true; + FastUnalignedAccess = llvm::is_contained(Features, "+unaligned-scalar-mem");

[PATCH] D159436: [clang-tidy] Add support for optional parameters in config.

felix642 updated this revision to Diff 556328. felix642 added a comment. Updated documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159436/new/ https://reviews.llvm.org/D159436 Files: clang-tools-extra/clang-tidy/ClangTidyCheck.h

[clang] Implement [[msvc::no_unique_address]] (PR #65675)

@@ -3055,7 +3195,7 @@ void MicrosoftRecordLayoutBuilder::injectVBPtr(const CXXRecordDecl *RD) { // It is possible that there were no fields or bases located after vbptr, // so the size was not adjusted before. if (Size < FieldStart) - Size = FieldStart; +

[PATCH] D159436: [clang-tidy] Add support for optional parameters in config.

felix642 updated this revision to Diff 556326. felix642 added a comment. Updated Differential to truly support optional parameters Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159436/new/ https://reviews.llvm.org/D159436 Files:

[clang-tools-extra] [clangd] Forward --target to system include extraction (PR #65824)

https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65824 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Forward --target to system include extraction (PR #65824)

https://github.com/mincrmatt12 created https://github.com/llvm/llvm-project/pull/65824: Some clang multilib configurations (such as the one currently used in the [beta ARM LLVM toolchain](https://github.com/ARM-software/LLVM-embedded-toolchain-for-Arm)) wind up only reporting the C++ include

[clang-tools-extra] [clangd] Forward --target to system include extraction (PR #65824)

https://github.com/mincrmatt12 review_requested https://github.com/llvm/llvm-project/pull/65824 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Update GoogleTest to v1.14.0 (PR #65823)

https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65823 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Update GoogleTest to v1.14.0 (PR #65823)

https://github.com/zeroomega review_requested https://github.com/llvm/llvm-project/pull/65823 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Update GoogleTest to v1.14.0 (PR #65823)

https://github.com/zeroomega review_requested https://github.com/llvm/llvm-project/pull/65823 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Update GoogleTest to v1.14.0 (PR #65823)

https://github.com/zeroomega review_requested https://github.com/llvm/llvm-project/pull/65823 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Update GoogleTest to v1.14.0 (PR #65823)

https://github.com/zeroomega review_requested https://github.com/llvm/llvm-project/pull/65823 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] f0f548a - [clang] Make test separator-agnostic

Author: Jan Svoboda Date: 2023-09-08T16:56:01-07:00 New Revision: f0f548a65a215c450d956dbcedb03656449705b9 URL: https://github.com/llvm/llvm-project/commit/f0f548a65a215c450d956dbcedb03656449705b9 DIFF: https://github.com/llvm/llvm-project/commit/f0f548a65a215c450d956dbcedb03656449705b9.diff

[clang] Implement [[msvc::no_unique_address]] (PR #65675)

https://github.com/amykhuang resolved https://github.com/llvm/llvm-project/pull/65675 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][VarDecl] Reset un-evaluated constant for all C++ modes (PR #65818)

https://github.com/erichkeane approved this pull request. https://github.com/llvm/llvm-project/pull/65818 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] 5523fef - [clang][lex] Use preferred path separator in includer-relative lookup

Author: Jan Svoboda Date: 2023-09-08T16:38:08-07:00 New Revision: 5523fefb01c282c4cbcaf6314a9aaf658c6c145f URL: https://github.com/llvm/llvm-project/commit/5523fefb01c282c4cbcaf6314a9aaf658c6c145f DIFF: https://github.com/llvm/llvm-project/commit/5523fefb01c282c4cbcaf6314a9aaf658c6c145f.diff

[PATCH] D148381: [Clang] Implement the 'counted_by' attribute

void updated this revision to Diff 556324. void added a comment. Add test output when the attribute isn't used. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148381/new/ https://reviews.llvm.org/D148381 Files: clang/include/clang/AST/Decl.h

[PATCH] D148381: [Clang] Implement the 'counted_by' attribute

void added inline comments. Comment at: clang/test/CodeGen/attr-counted-by.c:2 +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --version 3 +// RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -O2 -Wall

[PATCH] D148381: [Clang] Implement the 'counted_by' attribute

void added inline comments. Comment at: clang/test/CodeGen/attr-counted-by.c:2 +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --version 3 +// RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -O2 -Wall

[PATCH] D148381: [Clang] Implement the 'counted_by' attribute

void updated this revision to Diff 556323. void edited the summary of this revision. void added a comment. Fix docs to use the correct code examples throughout. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148381/new/

[clang] [Parse] Split incremental-extensions (PR #65683)

bnbarham wrote: > LGTM! Maybe we can cherry pick it for the patch release 17.0.1. If that’s a > critical patch for swift we can try for the 17.0.0 release. It's in the appropriate branches in our fork, so it's fine for us either way. I suggested it more because of

[PATCH] D158948: [clang][ASTImporter] Add import of type-related nodes

haowei added a comment. Hi I am working on updating GoogleTest in LLVM to v1.14.0 and during my local testing, I noticed that this patch added 2 new tests `ImportMatrixType` and `ImportOpenCLPipe` through `TEST_P` calls, however, both tests were not instantiated by `INSTANTIATE_TEST_SUITE_P`

[PATCH] D159490: Fix warning in MSVC

giulianobelinassi created this revision. giulianobelinassi added reviewers: aaron.ballman, erichkeane. Herald added a project: All. giulianobelinassi requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Currently there is no `PrintOnLeft`

[PATCH] D157191: Improve dumps of attributes

giulianobelinassi updated this revision to Diff 556319. giulianobelinassi added a comment. Fix warning in MSVC Summary: Currently there is no `PrintOnLeft` attribute set, which results in an empty switch-case. When compiling this, MSVC issues a warning saying that the switch-case is empty. Fix

[PATCH] D148381: [Clang] Add counted_by attribute

nickdesaulniers added inline comments. Comment at: clang/test/CodeGen/attr-counted-by.c:2 +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --version 3 +// RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -O2 -Wall

[clang] [clang][VarDecl] Reset un-evaluated constant for all C++ modes (PR #65818)

https://github.com/nickdesaulniers edited https://github.com/llvm/llvm-project/pull/65818 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][VarDecl] Reset un-evaluated constant for all C++ modes (PR #65818)

https://github.com/nickdesaulniers review_requested https://github.com/llvm/llvm-project/pull/65818 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][VarDecl] Reset un-evaluated constant for all C++ modes (PR #65818)

https://github.com/nickdesaulniers review_requested https://github.com/llvm/llvm-project/pull/65818 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][VarDecl] Reset un-evaluated constant for all C++ modes (PR #65818)

https://github.com/nickdesaulniers review_requested https://github.com/llvm/llvm-project/pull/65818 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][VarDecl] Reset un-evaluated constant for all C++ modes (PR #65818)

https://github.com/nickdesaulniers review_requested https://github.com/llvm/llvm-project/pull/65818 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][VarDecl] Reset un-evaluated constant for all C++ modes (PR #65818)

https://github.com/nickdesaulniers review_requested https://github.com/llvm/llvm-project/pull/65818 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][VarDecl] Reset un-evaluated constant for all C++ modes (PR #65818)

https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65818 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][VarDecl] Reset un-evaluated constant for all C++ modes (PR #65818)

https://github.com/nickdesaulniers review_requested https://github.com/llvm/llvm-project/pull/65818 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][VarDecl] Reset un-evaluated constant for all C++ modes (PR #65818)

https://github.com/nickdesaulniers review_requested https://github.com/llvm/llvm-project/pull/65818 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][VarDecl] Reset un-evaluated constant for all C++ modes (PR #65818)

https://github.com/nickdesaulniers created https://github.com/llvm/llvm-project/pull/65818: After commit 610ec954e1f8 ("[clang] allow const structs/unions/arrays to be constant expressions for C"), attempts to evaluate structs/unions/arrays as constants are also performed for C++98 and C++03.

[clang] [Documentation] Replace recommonmark by myst-parser (PR #65664)

https://github.com/JDevlieghere review_requested https://github.com/llvm/llvm-project/pull/65664 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D148381: [Clang] Add counted_by attribute

void added a comment. I changed more than just the testcase (not a lot, but non-trivial nonetheless). PTAL. Comment at: clang/test/CodeGen/attr-counted-by.c:2 +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --version 3 +// RUN:

[PATCH] D159064: [Modules] Make clang modules for the C standard library headers

iana updated this revision to Diff 556313. iana added a comment. Add the header guard comment to __stddef_null.h Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159064/new/ https://reviews.llvm.org/D159064 Files: clang/lib/Basic/Module.cpp

[PATCH] D148381: [Clang] Add counted_by attribute

void updated this revision to Diff 556312. void marked an inline comment as done. void added a comment. Remove unneded extern decl from test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148381/new/ https://reviews.llvm.org/D148381 Files:

[PATCH] D159064: [Modules] Make clang modules for the C standard library headers

iana updated this revision to Diff 556311. iana added a comment. Try deleting the module cache to fix the failing tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159064/new/ https://reviews.llvm.org/D159064 Files: clang/lib/Basic/Module.cpp

[PATCH] D148381: [Clang] Add counted_by attribute

void updated this revision to Diff 556310. void added a comment. - Expand test to show the unsanitized version, - Unify the ways of finding a specific field based on a predicate, - Make sure we're using the correct types in a couple of key places. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D159064: [Modules] Make clang modules for the C standard library headers

iana added inline comments. Comment at: clang/test/Modules/Inputs/System/usr/include/stdint.h:2 typedef int my_awesome_nonstandard_integer_type; + +/* C99 7.18.1.1 Exact-width integer types. dexonsmith wrote: > benlangmuir wrote: > > iana wrote: > > > iana

[PATCH] D159064: [Modules] Make clang modules for the C standard library headers

dexonsmith added inline comments. Comment at: clang/test/Modules/Inputs/System/usr/include/stdint.h:2 typedef int my_awesome_nonstandard_integer_type; + +/* C99 7.18.1.1 Exact-width integer types. benlangmuir wrote: > iana wrote: > > iana wrote: > > >

[clang] [clang-format] Fix a serious bug in git-clang-format (PR #65723)

https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/65723 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 743659b - [clang-format] Fix a serious bug in git-clang-format (#65723)

Author: Owen Pan Date: 2023-09-08T15:05:22-07:00 New Revision: 743659be87daff4cc8861c525d4a6229d787ef14 URL: https://github.com/llvm/llvm-project/commit/743659be87daff4cc8861c525d4a6229d787ef14 DIFF: https://github.com/llvm/llvm-project/commit/743659be87daff4cc8861c525d4a6229d787ef14.diff

[clang-tools-extra] [llvm-objcopy] Add --gap-fill and --pad-to options (PR #65515)

https://github.com/quic-akaryaki closed https://github.com/llvm/llvm-project/pull/65515 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D159486: Fix build error in CI.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd4ff8f815c21: Fix buildbot failure (authored by zahiraam). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D159486: Fix build error in CI.

zahiraam added a comment. In D159486#4642317 , @smeenai wrote: > I don't think pre-merge testing covers Mac, only Linux and Windows (which is > presumably how the original breakage got in). If the test passes for you > locally I'd just push it and

[clang-tools-extra] [llvm-objcopy] Add --gap-fill and --pad-to options (PR #65515)

https://github.com/quic-akaryaki updated https://github.com/llvm/llvm-project/pull/65515: >From 86d3cb57d89036700abf89fa31fe243bc9cb2c6c Mon Sep 17 00:00:00 2001 From: Alexey Karyakin Date: Tue, 5 Sep 2023 15:46:34 -0700 Subject: [PATCH] [llvm-objcopy] Add --gap-fill and --pad-to options

[clang] d4ff8f8 - Fix buildbot failure

Author: Zahira Ammarguellat Date: 2023-09-08T17:56:51-04:00 New Revision: d4ff8f815c21c6c511d7cdecda3f5376b8a9fb28 URL: https://github.com/llvm/llvm-project/commit/d4ff8f815c21c6c511d7cdecda3f5376b8a9fb28 DIFF:

[clang] [clang-format] Fix a serious bug in git-clang-format (PR #65723)

https://github.com/owenca updated https://github.com/llvm/llvm-project/pull/65723: >From cf7cca96897d392fcc9bef85c534261afb372d30 Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Fri, 8 Sep 2023 01:16:33 -0700 Subject: [PATCH] [clang-format] Fix a serious bug in git-clang-format When applying

[clang] e94e790 - [clang][test] Don't write temporary (actually, unused) outputs into CWD

Author: Dmitri Gribenko Date: 2023-09-08T23:54:41+02:00 New Revision: e94e790e46d0afd073b706afa0cf91804e7826e0 URL: https://github.com/llvm/llvm-project/commit/e94e790e46d0afd073b706afa0cf91804e7826e0 DIFF:

[PATCH] D159486: Fix build error in CI.

smeenai added a comment. I don't think pre-merge testing covers Mac, only Linux and Windows (which is presumably how the original breakage got in). If the test passes for you locally I'd just push it and monitor the bots afterwards. (That isn't general advice, but in this specific case, since

[PATCH] D159486: Fix build error in CI.

zahiraam added a comment. In D159486#4642309 , @smeenai wrote: > The `-triple x86_64-unknown-unknown` shouldn't be required after the regex > change, but I'm fine either way. I'd recommend pushing this to fix the bots, > and Aaron/Nico can do a

[PATCH] D148131: [clang-format] Avoid unnecessarily aggressive line-breaking when using "LambdaBodyIndentation: OuterScope" with argument bin-packing.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG210e7b3ca773: [clang-format] Improve line-breaking in LambdaBodyIndentation: OuterScope (authored by jp4a50, committed by owenpan). Changed prior

[clang] 210e7b3 - [clang-format] Improve line-breaking in LambdaBodyIndentation: OuterScope

Author: Jon Phillips Date: 2023-09-08T14:34:00-07:00 New Revision: 210e7b3ca773c07c2a8c2fd8f471db5c6724f3bc URL: https://github.com/llvm/llvm-project/commit/210e7b3ca773c07c2a8c2fd8f471db5c6724f3bc DIFF: https://github.com/llvm/llvm-project/commit/210e7b3ca773c07c2a8c2fd8f471db5c6724f3bc.diff

[PATCH] D159486: Fix build error in CI.

smeenai accepted this revision. smeenai added a comment. This revision is now accepted and ready to land. The `-triple x86_64-unknown-unknown` shouldn't be required after the regex change, but I'm fine either way. I'd recommend pushing this to fix the bots, and Aaron/Nico can do a post-commit

[PATCH] D159486: Fix build error in CI.

zahiraam added a comment. In D159486#4642305 , @smeenai wrote: > Generally it's preferred to either push bot failure fixes directly or revert > the original commit (also without review), to get bots unblocked as soon as > possible :) > > From what I

[PATCH] D159486: Fix build error in CI.

zahiraam updated this revision to Diff 556301. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159486/new/ https://reviews.llvm.org/D159486 Files: clang/test/CodeGen/math-errno.c Index: clang/test/CodeGen/math-errno.c ===

[PATCH] D159486: Fix build error in CI.

smeenai added a comment. Generally it's preferred to either push bot failure fixes directly or revert the original commit (also without review), to get bots unblocked as soon as possible :) From what I can see, the test failure is because `dso_local` isn't emitted on Mac. That seems

[PATCH] D148131: Avoid unnecessarily aggressive line-breaking when using "LambdaBodyIndentation: OuterScope" with argument bin-packing.

owenpan added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:22575 +#if 0 + // FIXME: As long as all the non-lambda arguments fit on a single line, AlwaysBreak + // doesn't force an initial line break, even if lambdas span multiple lines.

[clang] [clang-format] BreakBeforeNoexceptSpecifier option added (PR #65808)

https://github.com/HazardyKnusperkeks created https://github.com/llvm/llvm-project/pull/65808: It really bugs me that it breaks to ``` c++ ...) noexcept( noexcept(condition)... ``` This is a fix for people like me. From d0415b4436a11e649fbeae53b8060f70bae03254 Mon Sep 17 00:00:00 2001

[clang] [clang-format] BreakBeforeNoexceptSpecifier option added (PR #65808)

https://github.com/HazardyKnusperkeks review_requested https://github.com/llvm/llvm-project/pull/65808 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] BreakBeforeNoexceptSpecifier option added (PR #65808)

https://github.com/HazardyKnusperkeks review_requested https://github.com/llvm/llvm-project/pull/65808 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D159064: [Modules] Make clang modules for the C standard library headers

benlangmuir added a comment. Other than the giant header in the test we're still discussing, this basically LGTM. Comment at: clang/test/Modules/Inputs/System/usr/include/stdint.h:2 typedef int my_awesome_nonstandard_integer_type; + +/* C99 7.18.1.1 Exact-width integer

[clang] [AST] Only dump desugared type when visibly different (PR #65214)

jrtc27 wrote: I've added a release note (with hopefully valid reST syntax) and made the source comment less terse as requested https://github.com/llvm/llvm-project/pull/65214 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D159486: Fix build error in CI.

zahiraam updated this revision to Diff 556297. zahiraam added a reviewer: thakis. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159486/new/ https://reviews.llvm.org/D159486 Files: clang/test/CodeGen/math-errno.c Index: clang/test/CodeGen/math-errno.c

[clang-tools-extra] [clang-tidy] The first PR our of many PRs for the "Initialized Class Members" check. (PR #65189)

carlosgalvezp wrote: Thanks for the detailed response @adriannistor ! > will soon become a lot of if-then-else blocks. In general the decision as to which checks to have should be based on Coding Guidelines and user-facing experience - not on implementation complexity. In that sense, as a

[clang-tools-extra] [clang-tidy] The first PR our of many PRs for the "Initialized Class Members" check. (PR #65189)

https://github.com/PiotrZSL requested changes to this pull request. To be honest you still didn't clarify how this check is different from an exist ones. Entire section "Regarding the checker specifications (especially as they compare the cppcoreguidelines-pro-type-member-init):" says only

[clang] [clang][Docs] Document X86 interrupt attribute (PR #65662)

https://github.com/antangelo unlabeled https://github.com/llvm/llvm-project/pull/65662 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] The first PR our of many PRs for the "Initialized Class Members" check. (PR #65189)

@@ -0,0 +1,34 @@ +.. title:: clang-tidy - google-cpp-init-class-members + +google-cpp-init-class-members += + +Checks that class members are initialized in constructors (implicitly or +explicitly). Reports constructors or classes where class members

[clang-tools-extra] [clang-tidy] The first PR our of many PRs for the "Initialized Class Members" check. (PR #65189)

@@ -0,0 +1,34 @@ +.. title:: clang-tidy - google-cpp-init-class-members + +google-cpp-init-class-members += + +Checks that class members are initialized in constructors (implicitly or +explicitly). Reports constructors or classes where class members

  1   2   3   4   >