[PATCH] D136154: [clang-format] Fix the continuation indenter

hel-ableton added a comment. Hi Owen, thanks for reaching out, no. In fact we realized that we don't have enough capacity to be working on it. Best, Henrik - Henrik Lafrenz, Ableton AG Schoenhauser Allee 6-7, 10119 Berlin, Germany T: +49 30 288 763-256 Board: Gerhard Behles, Jan Bohl

[clang-tools-extra] [clang-tidy]add new check `bugprone-compare-pointer-to-member-virtual-function` (PR #66055)

@@ -0,0 +1,66 @@ +.. title:: clang-tidy - bugprone-compare-pointer-to-member-virtual-function + +bugprone-compare-pointer-to-member-virtual-function +=== + +Detects unspecified behavior about equality comparison between pointer to

[clang-tools-extra] [clang-tidy]add new check `bugprone-compare-pointer-to-member-virtual-function` (PR #66055)

@@ -0,0 +1,37 @@ +//===--- ComparePointerToMemberVirtualFunctionCheck.h - clang-tidy *- C++ +//-*-===// EugeneZelenko wrote: Please merge with previous line. You could reduce number of `=`. https://github.com/llvm/llvm-project/pull/66055

[clang-tools-extra] [clang-tidy]add new check `bugprone-compare-pointer-to-member-virtual-function` (PR #66055)

@@ -0,0 +1,107 @@ +//===--- ComparePointerToMemberVirtualFunctionCheck.cpp - clang-tidy --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang-tools-extra] [clang-tidy]add new check `bugprone-compare-pointer-to-member-virtual-function` (PR #66055)

@@ -0,0 +1,66 @@ +.. title:: clang-tidy - bugprone-compare-pointer-to-member-virtual-function + +bugprone-compare-pointer-to-member-virtual-function +=== + +Detects unspecified behavior about equality comparison between pointer to

[clang-tools-extra] [clang-tidy]add new check `bugprone-compare-pointer-to-member-virtual-function` (PR #66055)

@@ -0,0 +1,90 @@ +// RUN: %check_clang_tidy %s bugprone-compare-pointer-to-member-virtual-function %t + +struct A { + virtual ~A(); + void f1(); + void f2(); + virtual void f3(); + virtual void f4(); + + void g1(int); +}; + +bool Result; + +void base() { + Result = (::f1

[PATCH] D152405: [WIP][clang] Add experimental option to omit the RTTI component from the vtable when -fno-rtti is used

dyung added a comment. Hi @leonardchan your change was still causing a failure on the PS4 linux bot, so I reverted it in 070493ddbd9473499d6f00ca62bc6aa92808ed79 . I noticed earlier that the failing test

[clang] [Clang] Handle consteval expression in array bounds expressions (PR #66222)

https://github.com/shafik review_requested https://github.com/llvm/llvm-project/pull/66222 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Handle consteval expression in array bounds expressions (PR #66222)

https://github.com/shafik commented: If the function is `constexpr` do we treat it as a VLA? https://github.com/llvm/llvm-project/pull/66222 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [Clang] Handle consteval expression in array bounds expressions (PR #66222)

@@ -9843,30 +9833,44 @@ class Sema final { /// diagnostics that will be suppressed. std::optional isSFINAEContext() const; - /// Determines whether we are currently in a context that - /// is not evaluated as per C++ [expr] p5. - bool isUnevaluatedContext() const { +

[clang] [clang] fix lack comparison of declRefExpr in ASTStructuralEquivalence (PR #66041)

https://github.com/mzyKi updated https://github.com/llvm/llvm-project/pull/66041: >From fd7138ee568d0a46a71a7f4e268ecd491e600b31 Mon Sep 17 00:00:00 2001 From: miaozhiyuan Date: Tue, 12 Sep 2023 10:51:35 +0800 Subject: [PATCH] [clang] fix lack comparison of declRefExpr in

[clang] [Clang] Handle consteval expression in array bounds expressions (PR #66222)

@@ -13928,7 +13930,7 @@ static bool CheckTautologicalComparison(Sema , BinaryOperator *E, return false; IntRange OtherValueRange = GetExprRange( - S.Context, Other, S.isConstantEvaluated(), /*Approximate*/ false); + S.Context, Other,

[clang] [Clang] Handle consteval expression in array bounds expressions (PR #66222)

@@ -13928,7 +13930,7 @@ static bool CheckTautologicalComparison(Sema , BinaryOperator *E, return false; IntRange OtherValueRange = GetExprRange( - S.Context, Other, S.isConstantEvaluated(), /*Approximate*/ false); + S.Context, Other,

[clang] [Clang] Handle consteval expression in array bounds expressions (PR #66222)

@@ -14143,8 +14145,9 @@ static void AnalyzeComparison(Sema , BinaryOperator *E) { } // Otherwise, calculate the effective range of the signed operand. - IntRange signedRange = GetExprRange( - S.Context, signedOperand, S.isConstantEvaluated(), /*Approximate*/ true);

[clang] [Clang] Handle consteval expression in array bounds expressions (PR #66222)

@@ -15159,16 +15163,16 @@ static void CheckImplicitConversion(Sema , Expr *E, QualType T, IntRange SourceTypeRange = IntRange::forTargetOfCanonicalType(S.Context, Source); - IntRange LikelySourceRange = - GetExprRange(S.Context, E, S.isConstantEvaluated(),

[clang] [Clang] Handle consteval expression in array bounds expressions (PR #66222)

@@ -15090,8 +15093,9 @@ static void CheckImplicitConversion(Sema , Expr *E, QualType T, if (SourceBT && TargetBT && SourceBT->isIntegerType() && TargetBT->isFloatingType() && !IsListInit) { // Determine the number of precision bits in the source integer type. -

[clang] [clang] fix lack comparison of declRefExpr in ASTStructuralEquivalence (PR #66041)

https://github.com/mzyKi resolved https://github.com/llvm/llvm-project/pull/66041 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] fix lack comparison of declRefExpr in ASTStructuralEquivalence (PR #66041)

@@ -214,6 +214,16 @@ class StmtComparer { return E1->size() == E2->size(); } + bool IsStmtEquivalent(const DeclRefExpr *DRE1, const DeclRefExpr *DRE2) { +auto *Decl1 = DRE1->getDecl(); +auto *Decl2 = DRE2->getDecl(); mzyKi wrote: ```cpp ///

[clang] [clang] fix lack comparison of declRefExpr in ASTStructuralEquivalence (PR #66041)

https://github.com/mzyKi resolved https://github.com/llvm/llvm-project/pull/66041 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][CodeGen] Change CodeGenOpt::Level/CodeGenFileType into enum classes (PR #66295)

https://github.com/mshockwave approved this pull request. https://github.com/llvm/llvm-project/pull/66295 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D155610: [Clang][Sema] Fix display of characters on static assertion failure

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:16970 + OS << '\''; + WriteCharValueForDiagnostic(CodeUnit, BTy, TyWidth, OS); + OS << "' (0x" To have the diagnostic printer handle separating

[clang] [X86] Align 128/256 variants to use void * as 512 variants. (PR #66310)

https://github.com/FreddyLeaf review_requested https://github.com/llvm/llvm-project/pull/66310 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [X86] Align 128/256 variants to use void * as 512 variants. (PR #66310)

FreddyLeaf wrote: Here's the change for 512 variants before: https://reviews.llvm.org/D66786 https://github.com/llvm/llvm-project/pull/66310 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [X86] Align 128/256 variants to use void * as 512 variants. (PR #66310)

llvmbot wrote: @llvm/pr-subscribers-clang Changes For *_stream_* series intrinsics. -- Full diff: https://github.com/llvm/llvm-project/pull/66310.diff 10 Files Affected: - (modified) clang/lib/Headers/avx2intrin.h (+1-1) - (modified) clang/lib/Headers/avxintrin.h (+3-3) -

[clang] [X86] Align 128/256 variants to use void * as 512 variants. (PR #66310)

https://github.com/FreddyLeaf review_requested https://github.com/llvm/llvm-project/pull/66310 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [X86] Align 128/256 variants to use void * as 512 variants. (PR #66310)

https://github.com/FreddyLeaf review_requested https://github.com/llvm/llvm-project/pull/66310 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [X86] Align 128/256 variants to use void * as 512 variants. (PR #66310)

https://github.com/FreddyLeaf review_requested https://github.com/llvm/llvm-project/pull/66310 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [X86] Align 128/256 variants to use void * as 512 variants. (PR #66310)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66310 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [X86] Align 128/256 variants to use void * as 512 variants. (PR #66310)

https://github.com/FreddyLeaf review_requested https://github.com/llvm/llvm-project/pull/66310 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [X86] Align 128/256 variants to use void * as 512 variants. (PR #66310)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66310 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [X86] Align 128/256 variants to use void * as 512 variants. (PR #66310)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66310 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [X86] Align 128/256 variants to use void * as 512 variants. (PR #66310)

https://github.com/FreddyLeaf review_requested https://github.com/llvm/llvm-project/pull/66310 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [X86] Align 128/256 variants to use void * as 512 variants. (PR #66310)

https://github.com/FreddyLeaf created https://github.com/llvm/llvm-project/pull/66310: For *_stream_* series intrinsics. >From 21157a0e3b4c4e4e2430752ef806148685a942a2 Mon Sep 17 00:00:00 2001 From: Freddy Ye Date: Thu, 14 Sep 2023 09:17:39 +0800 Subject: [PATCH] [X86] Align 128/256 variants

[PATCH] D136154: [clang-format] Fix the continuation indenter

owenpan added a comment. Herald added a reviewer: MyDeveloperDay. @hel-ableton do you intend to continue working on this? If not, we can commandeer it and finish or abandon it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136154/new/ https://reviews.llvm.org/D136154

[clang] [Clang] Fix CXXRewrittenBinaryOperator::getDecomposedForm to handle case when spaceship operator returns comparison category by reference (PR #66270)

https://github.com/shafik review_requested https://github.com/llvm/llvm-project/pull/66270 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Stop breaking unbreakable strings in JS (PR #66168)

alexfh wrote: Unfortunately, this is not enough. I found at least one more broken case (pun intended): ``` export type LooongTypeName = ''|('BB'); ``` gets transformed into ``` export type LooongTypeName = ''|('B' +

[clang] e16474b - Revert "Revert "[clang] Add experimental option to omit the RTTI component from the vtable when -fno-rtti is used""

Author: Leonard Chan Date: 2023-09-14T00:00:50Z New Revision: e16474ba2cba8fa69b413a83852d06c93155f8c9 URL: https://github.com/llvm/llvm-project/commit/e16474ba2cba8fa69b413a83852d06c93155f8c9 DIFF: https://github.com/llvm/llvm-project/commit/e16474ba2cba8fa69b413a83852d06c93155f8c9.diff LOG:

[PATCH] D152405: [WIP][clang] Add experimental option to omit the RTTI component from the vtable when -fno-rtti is used

leonardchan added inline comments. Comment at: clang/include/clang/Driver/Options.td:2250 +def fexperimental_omit_rtti_component : + Flag<["-"], "fexperimental-omit-rtti-component">, + Group, Flags<[CC1Option]>, phosek wrote: > I think the name should signal

[clang] 87e11ec - Revert "[clang] Add experimental option to omit the RTTI component from the vtable when -fno-rtti is used"

Author: Leonard Chan Date: 2023-09-13T23:55:05Z New Revision: 87e11ecbaec95d8411d1b332d6d88d458b408739 URL: https://github.com/llvm/llvm-project/commit/87e11ecbaec95d8411d1b332d6d88d458b408739 DIFF: https://github.com/llvm/llvm-project/commit/87e11ecbaec95d8411d1b332d6d88d458b408739.diff LOG:

[PATCH] D135341: adds `__reference_constructs_from_temporary`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8f3b0b417143: [clang] adds `__reference_constructs_from_temporary` (authored by cjdb). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 8f3b0b4 - [clang] adds `__reference_constructs_from_temporary`

Author: Christopher Di Bella Date: 2023-09-13T23:51:43Z New Revision: 8f3b0b4171431ced5550d5c8a70d1b683343f062 URL: https://github.com/llvm/llvm-project/commit/8f3b0b4171431ced5550d5c8a70d1b683343f062 DIFF:

[PATCH] D158532: Anonymous unions should be transparent wrt `[[clang::trivial_abi]]`.

lukasza added a comment. @gribozavr2 - ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158532/new/ https://reviews.llvm.org/D158532 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D148381: [Clang] Implement the 'counted_by' attribute

void added inline comments. Comment at: clang/include/clang/AST/Decl.h:4272-4275 +FieldDecl *FD = nullptr; +for (FieldDecl *Field : fields()) + FD = Field; +return FD; aaron.ballman wrote: > Could this be implemented as: `return !field_empty() ?

[PATCH] D148381: [Clang] Implement the 'counted_by' attribute

void updated this revision to Diff 556734. void marked 36 inline comments as done. void added a comment. Added more error messages. Changed some code around to align with coding practices. Added some more test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D127270: [clang-format] Add space in placement new expression

owenpan added inline comments. Herald added a reviewer: rymiel. Comment at: clang/include/clang/Format/Format.h:3555 AfterFunctionDefinitionName(false), AfterIfMacros(false), - AfterOverloadedOperator(false), AfterRequiresInClause(false), -

[clang] [NFC][CodeGen] Change CodeGenOpt::{Level, FileType} into enum classes (PR #66295)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66295 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][CodeGen] Change CodeGenOpt::{Level, FileType} into enum classes (PR #66295)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66295 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][CodeGen] Change CodeGenOpt::{Level, FileType} into enum classes (PR #66295)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66295 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][CodeGen] Change CodeGenOpt::{Level, FileType} into enum classes (PR #66295)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66295 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][CodeGen] Change CodeGenOpt::{Level, FileType} into enum classes (PR #66295)

https://github.com/aeubanks review_requested https://github.com/llvm/llvm-project/pull/66295 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][CodeGen] Change CodeGenOpt::{Level, FileType} into enum classes (PR #66295)

https://github.com/aeubanks review_requested https://github.com/llvm/llvm-project/pull/66295 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][CodeGen] Change CodeGenOpt::{Level, FileType} into enum classes (PR #66295)

https://github.com/aeubanks review_requested https://github.com/llvm/llvm-project/pull/66295 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][CodeGen] Change CodeGenOpt::{Level, FileType} into enum classes (PR #66295)

https://github.com/aeubanks review_requested https://github.com/llvm/llvm-project/pull/66295 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CMake] Add VE cache file (PR #65921)

kaz7 wrote: Add a comment to the cache file and rebase. https://github.com/llvm/llvm-project/pull/65921 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CMake] Add VE cache file (PR #65921)

https://github.com/kaz7 updated https://github.com/llvm/llvm-project/pull/65921: >From 7c1a3ccb7977781ec8b45f4c230520abeca907f5 Mon Sep 17 00:00:00 2001 From: "Kazushi (Jam) Marukawa" Date: Mon, 11 Sep 2023 11:46:56 +0900 Subject: [PATCH] [CMake] Add VE cache file Add VE cache file for the

[clang] [MS] Follow up fix to pass aligned args to variadic x86_32 functions (PR #65692)

https://github.com/rnk closed https://github.com/llvm/llvm-project/pull/65692 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] c8c075e - [MS] Follow up fix to pass aligned args to variadic x86_32 functions (#65692)

Author: Reid Kleckner Date: 2023-09-13T16:29:11-07:00 New Revision: c8c075e8769a615451653b37e5426eb5d7a1d16c URL: https://github.com/llvm/llvm-project/commit/c8c075e8769a615451653b37e5426eb5d7a1d16c DIFF: https://github.com/llvm/llvm-project/commit/c8c075e8769a615451653b37e5426eb5d7a1d16c.diff

[clang] [MS] Follow up fix to pass aligned args to variadic x86_32 functions (PR #65692)

https://github.com/rnk resolved https://github.com/llvm/llvm-project/pull/65692 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [MS] Follow up fix to pass aligned args to variadic x86_32 functions (PR #65692)

llvmbot wrote: @llvm/pr-subscribers-clang Changes MSVC allows users to pass structures with required alignments greater than 4 to variadic functions. It does not pass them indirectly to correctly align them. Instead, it passes them directly with the usual 4 byte stack

[clang] [MS] Follow up fix to pass aligned args to variadic x86_32 functions (PR #65692)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65692 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [MS] Follow up fix to pass aligned args to variadic x86_32 functions (PR #65692)

@@ -812,11 +815,13 @@ ABIArgInfo X86_32ABIInfo::classifyArgumentType(QualType Ty, CCState , } llvm::IntegerType *PaddingType = NeedsPadding ? Int32 : nullptr; -// Pass over-aligned aggregates on Windows indirectly. This behavior was -// added in MSVC 2015.

[clang-tools-extra] [MS] Follow up fix to pass aligned args to variadic x86_32 functions (PR #65692)

https://github.com/rnk review_requested https://github.com/llvm/llvm-project/pull/65692 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [MS] Follow up fix to pass aligned args to variadic x86_32 functions (PR #65692)

https://github.com/rnk updated https://github.com/llvm/llvm-project/pull/65692: >From 98d560c8057b171c81b43d93c1a0c26f1d27cf5b Mon Sep 17 00:00:00 2001 From: Reid Kleckner Date: Tue, 29 Aug 2023 14:26:10 -0700 Subject: [PATCH 1/2] [MS] Follow up fix to pass aligned args to variadic x86_32

[PATCH] D144170: [clang-format] Add simple macro replacements in formatting.

owenpan added a comment. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan, MyDeveloperDay. It seems that this patch caused a regression. See https://github.com/llvm/llvm-project/issues/62768. Herald added a comment. NOTE: Clang-Format Team Automated Review Comment Your review

[PATCH] D152405: [WIP][clang] Add experimental option to omit the RTTI component from the vtable when -fno-rtti is used

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6385c1df919f: [clang] Add experimental option to omit the RTTI component from the vtable when… (authored by leonardchan). Changed prior to commit:

[clang] 6385c1d - [clang] Add experimental option to omit the RTTI component from the vtable when -fno-rtti is used

Author: Leonard Chan Date: 2023-09-13T23:15:50Z New Revision: 6385c1df919f237d4149fabf542a158f61010bf8 URL: https://github.com/llvm/llvm-project/commit/6385c1df919f237d4149fabf542a158f61010bf8 DIFF: https://github.com/llvm/llvm-project/commit/6385c1df919f237d4149fabf542a158f61010bf8.diff LOG:

[clang] Replace llvm.memcpy et al's i1 isVolatile with i8 VolFlags (PR #65748)

@@ -214,14 +214,14 @@ class LLVM_MemcpyIntrOpBase : /*requiresAccessGroup=*/1, /*requiresAliasAnalysis=*/1> { dag args = (ins Arg:$dst, Arg:$src, - AnySignlessInteger:$len, I1Attr:$isVolatile); urnathan wrote: thanks,

[clang] Replace llvm.memcpy et al's i1 isVolatile with i8 VolFlags (PR #65748)

@@ -24790,8 +24790,8 @@ static SDValue LowerVACOPY(SDValue Op, const X86Subtarget , return DAG.getMemcpy( Chain, DL, DstPtr, SrcPtr, DAG.getIntPtrConstant(Subtarget.isTarget64BitLP64() ? 24 : 16, DL), - Align(Subtarget.isTarget64BitLP64() ? 8 : 4),

[clang] [clang] Don't inherit dllimport/dllexport to exclude_from_explicit_in… (PR #65961)

https://github.com/rnk approved this pull request. Thanks! https://github.com/llvm/llvm-project/pull/65961 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D151938: [clang][index] NFCI: Make `CXFile` a `FileEntryRef`

jansvoboda11 added a comment. In D151938#4645381 , @Jake-Egan wrote: > @jansvoboda11 Actually, we could give you access to an AIX machine to debug > this. Would that work for you? Hi, I'd be happy to try that! Repository: rG LLVM Github Monorepo

[PATCH] D152405: [WIP][clang] Add experimental option to omit the RTTI component from the vtable when -fno-rtti is used

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/include/clang/Basic/LangOptions.def:453 +LANGOPT(OmitRTTIComponent, 1, 0, +"Use an ABI-incompatible v-table layout that omits the RTTI

[clang] [clang][deps] Implement move-conversion for `CowCompilerInvocation` (PR #66301)

https://github.com/jansvoboda11 closed https://github.com/llvm/llvm-project/pull/66301 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] c60ee7c - [clang][deps] Implement move-conversion for `CowCompilerInvocation` (#66301)

Author: Jan Svoboda Date: 2023-09-13T15:51:24-07:00 New Revision: c60ee7c7b2154013e2b7b4f83ea422fbb4015cb7 URL: https://github.com/llvm/llvm-project/commit/c60ee7c7b2154013e2b7b4f83ea422fbb4015cb7 DIFF: https://github.com/llvm/llvm-project/commit/c60ee7c7b2154013e2b7b4f83ea422fbb4015cb7.diff

[clang] [NFC][CodeGen] Change CodeGenOpt::{Level, FileType} into enum classes (PR #66295)

https://github.com/rnk commented: Seems reasonable to me. https://github.com/llvm/llvm-project/pull/66295 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D74094: Reapply: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas

nickdesaulniers added a comment. In D74094#4643653 , @nickdesaulniers wrote: > With this change re-applied (`b7f4915644844fb9f32e8763922a070f5fe4fd29` > reverted), a.out runs without issue. So yes, I need something other than a > godbolt link which

[clang] Implement [[msvc::no_unique_address]] (PR #65675)

@@ -55,7 +55,7 @@ CXX11(unlikely) // CHECK: likely: 201803L // CHECK: maybe_unused: 201603L // ITANIUM: no_unique_address: 201803L -// WINDOWS: no_unique_address: 0 +// WINDOWS: no_unique_address: 201803L amykhuang wrote: Tried this and the inheritance part

[PATCH] D152405: [WIP][clang] Add experimental option to omit the RTTI component from the vtable when -fno-rtti is used

leonardchan updated this revision to Diff 556724. leonardchan marked 2 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152405/new/ https://reviews.llvm.org/D152405 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td

[clang] f94695b - [clang] NFCI: Use `FileEntryRef` in `FileManager::getBufferForFile()`

Author: Jan Svoboda Date: 2023-09-13T15:02:20-07:00 New Revision: f94695b6eb0e0b2bb059c33903cc7dd4a3ddd47f URL: https://github.com/llvm/llvm-project/commit/f94695b6eb0e0b2bb059c33903cc7dd4a3ddd47f DIFF: https://github.com/llvm/llvm-project/commit/f94695b6eb0e0b2bb059c33903cc7dd4a3ddd47f.diff

[clang] Revert "[Parse] Split incremental-extensions" (PR #66281)

https://github.com/bnbarham closed https://github.com/llvm/llvm-project/pull/66281 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] f8ced20 - Revert "[Parse] Split incremental-extensions" (#66281)

Author: Ben Barham Date: 2023-09-13T14:55:01-07:00 New Revision: f8ced20ad3e8e0f630dbad06ac13b326c6d63bfa URL: https://github.com/llvm/llvm-project/commit/f8ced20ad3e8e0f630dbad06ac13b326c6d63bfa DIFF: https://github.com/llvm/llvm-project/commit/f8ced20ad3e8e0f630dbad06ac13b326c6d63bfa.diff

[clang] Revert "[Parse] Split incremental-extensions" (PR #66281)

https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/66281 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libc++] Implement ranges::contains (PR #65148)

https://github.com/ZijunZhaoCCK updated https://github.com/llvm/llvm-project/pull/65148: >From 02e9afd761228f401df4d9f8dfaaca44ffae0c6e Mon Sep 17 00:00:00 2001 From: zijunzhao Date: Thu, 31 Aug 2023 20:08:32 + Subject: [PATCH 01/11] [libc++] Implement ranges::contains Differential

[clang-tools-extra] [libc++] Implement ranges::contains (PR #65148)

https://github.com/ZijunZhaoCCK updated https://github.com/llvm/llvm-project/pull/65148: >From 02e9afd761228f401df4d9f8dfaaca44ffae0c6e Mon Sep 17 00:00:00 2001 From: zijunzhao Date: Thu, 31 Aug 2023 20:08:32 + Subject: [PATCH 01/11] [libc++] Implement ranges::contains Differential

[libunwind] [libc++] Implement ranges::contains (PR #65148)

https://github.com/ZijunZhaoCCK updated https://github.com/llvm/llvm-project/pull/65148: >From 02e9afd761228f401df4d9f8dfaaca44ffae0c6e Mon Sep 17 00:00:00 2001 From: zijunzhao Date: Thu, 31 Aug 2023 20:08:32 + Subject: [PATCH 01/11] [libc++] Implement ranges::contains Differential

[clang] [NFC][CodeGen] Change CodeGenOpt::{Level, FileType} into enum classes (PR #66295)

https://github.com/aeubanks review_requested https://github.com/llvm/llvm-project/pull/66295 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][CodeGen] Change CodeGenOpt::{Level, FileType} into enum classes (PR #66295)

https://github.com/aeubanks review_requested https://github.com/llvm/llvm-project/pull/66295 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][CodeGen] Change CodeGenOpt::{Level, FileType} into enum classes (PR #66295)

https://github.com/aeubanks review_requested https://github.com/llvm/llvm-project/pull/66295 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][CodeGen] Change CodeGenOpt::{Level, FileType} into enum classes (PR #66295)

https://github.com/aeubanks review_requested https://github.com/llvm/llvm-project/pull/66295 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][CodeGen] Change CodeGenOpt::{Level, FileType} into enum classes (PR #66295)

https://github.com/aeubanks review_requested https://github.com/llvm/llvm-project/pull/66295 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Support target names with dots in more utilities (PR #65812)

https://github.com/dankm updated https://github.com/llvm/llvm-project/pull/65812: >From a42cbcc0731725929c60ba4c1fd5254ae5e46613 Mon Sep 17 00:00:00 2001 From: Dan McGregor Date: Mon, 14 Aug 2023 18:44:08 -0600 Subject: [PATCH] Support: hoist lld's executable name code to Path Instead of

[clang-tools-extra] Support target names with dots in more utilities (PR #65812)

https://github.com/dankm updated https://github.com/llvm/llvm-project/pull/65812: >From a42cbcc0731725929c60ba4c1fd5254ae5e46613 Mon Sep 17 00:00:00 2001 From: Dan McGregor Date: Mon, 14 Aug 2023 18:44:08 -0600 Subject: [PATCH] Support: hoist lld's executable name code to Path Instead of

[clang] Update GoogleTest to v1.14.0 (PR #65823)

zeroomega wrote: Relanded as a866ce789eb99da4d7a486eeb60a53be6c75f4fd. I will monitor the bots and manually trigger clean build if linker error appears again. https://github.com/llvm/llvm-project/pull/65823 ___ cfe-commits mailing list

[clang] Support target names with dots in more utilities (PR #65812)

https://github.com/dankm updated https://github.com/llvm/llvm-project/pull/65812: >From a42cbcc0731725929c60ba4c1fd5254ae5e46613 Mon Sep 17 00:00:00 2001 From: Dan McGregor Date: Mon, 14 Aug 2023 18:44:08 -0600 Subject: [PATCH] Support: hoist lld's executable name code to Path Instead of

[clang] 2793ef6 - [clang] NFCI: Use `FileEntryRef` in `SrcMgr::ContentCache`

Author: Jan Svoboda Date: 2023-09-13T13:55:32-07:00 New Revision: 2793ef6797a406abf983139b2a18b30a9e277687 URL: https://github.com/llvm/llvm-project/commit/2793ef6797a406abf983139b2a18b30a9e277687 DIFF: https://github.com/llvm/llvm-project/commit/2793ef6797a406abf983139b2a18b30a9e277687.diff

[clang-tools-extra] Support target names with dots in more utilities (PR #65812)

https://github.com/dankm updated https://github.com/llvm/llvm-project/pull/65812: >From a42cbcc0731725929c60ba4c1fd5254ae5e46613 Mon Sep 17 00:00:00 2001 From: Dan McGregor Date: Mon, 14 Aug 2023 18:44:08 -0600 Subject: [PATCH] Support: hoist lld's executable name code to Path Instead of

[clang] [HIP] Fix comdat of template kernel handle (PR #66283)

@@ -43,6 +44,9 @@ __global__ void kernelfunc() {} __global__ void kernel_decl(); +template +__global__ void temp_kernel_decl(T x); Artem-B wrote: Nit: rename temp -> template? `temp` is strongly associated with 'temporary'.

[clang] [HIP] Fix comdat of template kernel handle (PR #66283)

https://github.com/Artem-B edited https://github.com/llvm/llvm-project/pull/66283 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HIP] Fix comdat of template kernel handle (PR #66283)

https://github.com/Artem-B approved this pull request. https://github.com/llvm/llvm-project/pull/66283 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] TaintPropagation checker strlen() should not propagate (PR #66086)

steakhal wrote: I actually wanted to propose another patch where the wchar variant of strlen would propagate taint, BTW. I still plan to do it, we will see when I reach that. https://github.com/llvm/llvm-project/pull/66086 ___ cfe-commits mailing

[clang] [analyzer] TaintPropagation checker strlen() should not propagate (PR #66086)

steakhal wrote: I can understand the frustration of the FPs. However, propagating taint there is the right thing to do. To me, the fault is on the diagnostic on the malloc. Those are the cause of the FPs, thus that needs to be removed instead of the propagation. I have this opinion even if the

  1   2   3   4   >