[clang] [Clang] Handle consteval expression in array bounds expressions (PR #66222)

hazohelet wrote: > Where do you think it matters? I can't this of cases where ConstantEvaluated > context are nested in one another without some intertwined potentially > evaluated context I was mostly thinking about cases where the array-bound expression appears inside immediate function

[PATCH] D155572: [clang][Interp] Start implementing binary operators for complex types

tbaeder updated this revision to Diff 556825. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155572/new/ https://reviews.llvm.org/D155572 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h clang/test/AST/Interp/complex.cpp Index:

[PATCH] D155572: [clang][Interp] Start implementing binary operators for complex types

tbaeder added a comment. In D155572#4645997 , @aaron.ballman wrote: > Hmmm, I think the answer is "no"... and "maybe." `_Complex` can only be > followed by `float`, `double`, or `long double` specifically per the C > standard. However, we also support

[PATCH] D152914: [Draft] Make __builtin_cpu builtins target-independent

nemanjai added a comment. In D152914#4602914 , @ilinpv wrote: > Friendly ping, are there any questions remained to proceed with > target-independent __builtin_cpu_supports ? Sorry, I have not gotten back to this review in quite some time as I have been

[clang] [Driver] Implement ToolChain on Haiku (PR #66038)

https://github.com/brad0 updated https://github.com/llvm/llvm-project/pull/66038: >From ac7c3555bd703e789ff3020cea2e11cb9dc054df Mon Sep 17 00:00:00 2001 From: X512 Date: Mon, 11 Sep 2023 20:56:02 -0400 Subject: [PATCH] [Driver] Implement ToolChain on Haiku Co-authored-by: David Karoly

[PATCH] D159064: [Modules] Make clang modules for the C standard library headers

iana added inline comments. Comment at: clang/lib/Headers/module.modulemap:269 + explicit module wint_t { +header "__stddef_wint_t.h" +export * iana wrote: > Arguably this should be textual since stddef.h shouldn't own wint_t and it's > just here for

[clang] Extend `retcon.once` coroutines lowering to optionally produce a normal result (PR #66333)

ChuanqiXu9 wrote: Got it. Thanks for the explanation : ) https://github.com/llvm/llvm-project/pull/66333 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Extend `retcon.once` coroutines lowering to optionally produce a normal result (PR #66333)

asl wrote: > Got it. Thanks. Then I am wondering how about the `retcon` ABI? I am confused > since the doc said the last continuation of `retcon` ABI will return a > nullptr to indicate it has finished. Don't we have the same problem? Or we > can't solve the problem in `retcon` ABI? Or we

[clang] Extend `retcon.once` coroutines lowering to optionally produce a normal result (PR #66333)

ChuanqiXu9 wrote: Got it. Thanks. Then I am wondering how about the `retcon` ABI? I am confused since the doc said the last continuation of `retcon` ABI will return a nullptr to indicate it has finished. Don't we have the same problem? Or we can't solve the problem in `retcon` ABI? Or we just

[clang] [NFC][CodeGen] Change CodeGenOpt::Level/CodeGenFileType into enum classes (PR #66295)

@@ -661,27 +661,27 @@ static bool FixupInvocation(CompilerInvocation , static unsigned getOptimizationLevel(ArgList , InputKind IK, DiagnosticsEngine ) { - unsigned DefaultOpt = llvm::CodeGenOpt::None; + unsigned DefaultOpt = 0; if

[clang] Extend `retcon.once` coroutines lowering to optionally produce a normal result (PR #66333)

asl wrote: > What make me curious is the motivation case of the PR. I mean what can be > presented in retcon.once ABI after the PR which is impossible/hard before. > And how do we handle that in retcon ABI. Well, the PR allows `recon.once` coroutines to have normal results in addition to

[clang] [ASTImport]improve ast comparation (PR #66110)

https://github.com/jcsxky closed https://github.com/llvm/llvm-project/pull/66110 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D159519: [clang][ASTImport] improve ast comparation

jcsxky created this revision. jcsxky added reviewers: donat.nagy, steakhal, balazske. jcsxky added projects: clang, clang-c. Herald added subscribers: ChuanqiXu, martong. Herald added a project: All. jcsxky requested review of this revision. Herald added a subscriber: cfe-commits. 1. VarDecl

[clang] Extend `retcon.once` coroutines lowering to optionally produce a normal result (PR #66333)

ChuanqiXu9 wrote: Oh, I am wondering if we have misunderstandings. I am not asking the reason why we don't have the problem which is discussing in the change of CoroFrame.cpp in return continuation ABI. I understand that fully. What make me curious is the motivation case of the PR. I mean

[clang] Extend `retcon.once` coroutines lowering to optionally produce a normal result (PR #66333)

asl wrote: > > > Out of curiousity, why don't we have the problem in the normal return > > > continuation ABI? > > > > > > The problem happens when the value is directly used in `coro.end` > > intrinsic. For example, when we're forwarding coroutine argument as a > > result. Or, when the

[clang] [RISCV] Install sifive_vector.h to riscv-resource-headers (PR #66330)

@@ -0,0 +1,6 @@ +// RUN: %clang_cc1 -triple riscv64 -target-feature +v %s +// REQUIRES: riscv-registered-target + +// expected-no-diagnostics + +#include 4vtomat wrote: Lit test is run before install, how can we check it's properly installed?

[clang-tools-extra] [Sema] add cast from IncompleteArrayType to ConstantArrayType in TryReferenceListInitialization (PR #65918)

https://github.com/HerrCai0907 updated https://github.com/llvm/llvm-project/pull/65918: >From cfedbe3fb2f2f331b3f9ee1f4f3e2fcd348797e2 Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Mon, 11 Sep 2023 09:15:41 +0800 Subject: [PATCH 1/4] [Sema] add cast from IncompleteArrayType to

[clang] [Sema] add cast from IncompleteArrayType to ConstantArrayType in TryReferenceListInitialization (PR #65918)

https://github.com/HerrCai0907 updated https://github.com/llvm/llvm-project/pull/65918: >From cfedbe3fb2f2f331b3f9ee1f4f3e2fcd348797e2 Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Mon, 11 Sep 2023 09:15:41 +0800 Subject: [PATCH 1/4] [Sema] add cast from IncompleteArrayType to

[clang] Extend `retcon.once` coroutines lowering to optionally produce a normal result (PR #66333)

ChuanqiXu9 wrote: > > Out of curiousity, why don't we have the problem in the normal return > > continuation ABI? > > The problem happens when the value is directly used in `coro.end` intrinsic. > For example, when we're forwarding coroutine argument as a result. Or, when > the value itself

[clang-tools-extra] [Sema] add cast from IncompleteArrayType to ConstantArrayType in TryReferenceListInitialization (PR #65918)

@@ -4532,6 +4532,15 @@ static void TryReferenceListInitialization(Sema , if (T1Quals.hasAddressSpace()) Sequence.AddQualificationConversionStep( cv1T1, DestType->isRValueReferenceType() ? VK_XValue : VK_LValue); + else if

[clang] [Sema] add cast from IncompleteArrayType to ConstantArrayType in TryReferenceListInitialization (PR #65918)

@@ -4532,6 +4532,15 @@ static void TryReferenceListInitialization(Sema , if (T1Quals.hasAddressSpace()) Sequence.AddQualificationConversionStep( cv1T1, DestType->isRValueReferenceType() ? VK_XValue : VK_LValue); + else if

[clang] Extend `retcon.once` coroutines lowering to optionally produce a normal result (PR #66333)

@@ -3046,7 +3046,8 @@ void coro::buildCoroutineFrame( // Collect the spills for arguments and other not-materializable values. for (Argument : F.args()) for (User *U : A.users()) - if (Checker.isDefinitionAcrossSuspend(A, U)) + if

[clang-tools-extra] [Sema] add cast from IncompleteArrayType to ConstantArrayType in TryReferenceListInitialization (PR #65918)

https://github.com/HerrCai0907 updated https://github.com/llvm/llvm-project/pull/65918: >From cfedbe3fb2f2f331b3f9ee1f4f3e2fcd348797e2 Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Mon, 11 Sep 2023 09:15:41 +0800 Subject: [PATCH 1/3] [Sema] add cast from IncompleteArrayType to

[clang] [Sema] add cast from IncompleteArrayType to ConstantArrayType in TryReferenceListInitialization (PR #65918)

https://github.com/HerrCai0907 updated https://github.com/llvm/llvm-project/pull/65918: >From cfedbe3fb2f2f331b3f9ee1f4f3e2fcd348797e2 Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Mon, 11 Sep 2023 09:15:41 +0800 Subject: [PATCH 1/3] [Sema] add cast from IncompleteArrayType to

[clang] Introduce paged vector (PR #66430)

ChuanqiXu9 wrote: I feel like it looks better to touch https://llvm.org/docs/LangRef.html to introduce new ADT and tell what is the benefit (pros and cons) of the new data structure. https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits

[clang] [Driver] Also respect SysRoot for the system library paths on DragonFly (PR #66056)

https://github.com/brad0 closed https://github.com/llvm/llvm-project/pull/66056 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 1e40dfc - [Driver] Also respect SysRoot for the system library paths on DragonFly (#66056)

Author: Brad Smith Date: 2023-09-14T21:18:37-04:00 New Revision: 1e40dfc5d4e099715dcf2d5b96f2f08b9718ed24 URL: https://github.com/llvm/llvm-project/commit/1e40dfc5d4e099715dcf2d5b96f2f08b9718ed24 DIFF: https://github.com/llvm/llvm-project/commit/1e40dfc5d4e099715dcf2d5b96f2f08b9718ed24.diff

[clang] [Driver] Also respect SysRoot for the system library paths on DragonFly (PR #66056)

brad0 wrote: Fixed the tests so they also pass on Windows. https://github.com/llvm/llvm-project/pull/66056 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Also respect SysRoot for the system library paths on DragonFly (PR #66056)

https://github.com/brad0 updated https://github.com/llvm/llvm-project/pull/66056: >From 91ee01975c2c59b6349ee4ac310ee7b2c3dfe7af Mon Sep 17 00:00:00 2001 From: Brad Smith Date: Tue, 12 Sep 2023 04:43:49 -0400 Subject: [PATCH] [Driver] Also respect SysRoot for the system library paths on

[clang] [clang][CodeGen] Use byval for SystemZ indirect arguments (PR #66404)

efriedma-quic wrote: There's a special case in the msan handling precisely because byval makes the ABI different. (If you look at the x86 code, you'll see that the generated code with byval is significantly different.) I don't think I know enough about dfsan to follow that argument.

[clang] [clang-format] Disable string breaking in JS for now (PR #66372)

https://github.com/owenca approved this pull request. https://github.com/llvm/llvm-project/pull/66372 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Disable string breaking in JS for now (PR #66372)

@@ -2237,15 +2237,10 @@ ContinuationIndenter::createBreakableToken(const FormatToken , LineState , bool AllowBreak) { unsigned StartColumn = State.Column - Current.ColumnWidth; if (Current.isStringLiteral()) { -// Strings in

[clang] [clang-format] Disable string breaking in JS for now (PR #66372)

https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/66372 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Disable string breaking in JS for now (PR #66372)

@@ -2783,17 +2783,17 @@ the configuration (without a prefix: ``Auto``). const char* x = "veryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryLongString"; - In C#, Java, and JavaScript: + In C# and Java: .. code-block:: c++ true: - var x =

[clang] [NFC][CodeGen] Change CodeGenOpt::Level/CodeGenFileType into enum classes (PR #66295)

@@ -661,27 +661,27 @@ static bool FixupInvocation(CompilerInvocation , static unsigned getOptimizationLevel(ArgList , InputKind IK, DiagnosticsEngine ) { - unsigned DefaultOpt = llvm::CodeGenOpt::None; + unsigned DefaultOpt = 0; if

[clang] [DependencyScanningFilesystem] Make sure the local/shared cache filename lookups use only absolute paths (PR #66122)

@@ -330,3 +353,20 @@ DependencyScanningWorkerFilesystem::openFileForRead(const Twine ) { return Result.getError(); return DepScanFile::create(Result.get()); } + +std::error_code DependencyScanningWorkerFilesystem::setCurrentWorkingDirectory( +const Twine ) { +

[clang] [clang-format] Disable string breaking in JS for now (PR #66372)

https://github.com/alexfh approved this pull request. This is the right call for now. There are multiple contexts in JS, TS and libraries like Closure, where simple string literals are expected. Getting all of these right may require some back-and-forths, during which clang-format will

[clang] [clang-format] Stop breaking unbreakable strings in JS (PR #66168)

alexfh wrote: > > Another thing is that we need to get this fixed really soon. Another (safer > > and actually preferred) alternative is to revert the change and address > > problematic use cases before recommitting it, but I'm also fine with > > forward-fixing this as long as fixes don't

[clang] [clang][CodeGen] Use byval for SystemZ indirect arguments (PR #66404)

iii-i wrote: There is special byval handling in MSan: ``` void visitCallBase(CallBase , IRBuilder<> ) override { ... for (const auto &[ArgNo, A] : llvm::enumerate(CB.args())) { ... bool IsByVal = CB.paramHasAttr(ArgNo, Attribute::ByVal); ``` If a target does not make use of byval,

[PATCH] D157913: [Coverage] Allow Clang coverage to be used with debug info correlation.

ellis accepted this revision. ellis added a comment. This revision is now accepted and ready to land. In D157913#4646201 , @zequanwu wrote: > In D157913#4646184 , @ellis wrote: > >> It looks like

[PATCH] D157385: [clang][CFG] Cleanup functions

aaronpuchert added inline comments. Comment at: clang/test/Analysis/scopes-cfg-output.cpp:1472 +// CHECK-NEXT:2: (CXXConstructExpr, [B1.3], F) +// CHECK-NEXT:3: F f __attribute__((cleanup(cleanup_F))); +// CHECK-NEXT:4: CleanupFunction (cleanup_F)

[PATCH] D152504: [clang][ThreadSafety] Analyze cleanup functions

aaronpuchert added a comment. Side note: I hope you've seen the failing test `Analysis/scopes-cfg-output.cpp`, but since that belongs to the predecessor change I assume it's an issue there. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152504/new/ https://reviews.llvm.org/D152504

[clang] Re-apply "[Parse] Split incremental-extensions" (PR #66446)

llvmbot wrote: @llvm/pr-subscribers-clang Changes Re-applies #65683 with a fix to always run `Actions.ActOnEndOfTranslationUnit` regardless of incremental processing. -- Full diff: https://github.com/llvm/llvm-project/pull/66446.diff 4 Files Affected: - (modified)

[PATCH] D152504: [clang][ThreadSafety] Analyze cleanup functions

aaronpuchert accepted this revision. aaronpuchert added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Analysis/ThreadSafety.cpp:1776 /// \param D The callee declaration. /// \param Self If \p Exp = nullptr, the implicit this

[clang] Re-apply "[Parse] Split incremental-extensions" (PR #66446)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66446 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Re-apply "[Parse] Split incremental-extensions" (PR #66446)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66446 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Re-apply "[Parse] Split incremental-extensions" (PR #66446)

https://github.com/bnbarham review_requested https://github.com/llvm/llvm-project/pull/66446 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Re-apply "[Parse] Split incremental-extensions" (PR #66446)

https://github.com/bnbarham created https://github.com/llvm/llvm-project/pull/66446: Re-applies #65683 with a fix to always run `Actions.ActOnEndOfTranslationUnit` regardless of incremental processing. >From 9063bb14660836507ccf1b5c36256bd5f9d1d21c Mon Sep 17 00:00:00 2001 From: Ben Barham

[clang] [clang][CodeGen] Use byval for SystemZ indirect arguments (PR #66404)

efriedma-quic wrote: > I just checked with a few small examples, and while the ABI does not seem to > change, the code generation looks broken for tail recursion: I'd guess the SystemZ backend doesn't implement byval properly (since it's not required for the C calling convention, probably

[clang-tools-extra] [MLIR] Enabling Intel GPU Integration. (PR #65539)

@@ -71,7 +71,8 @@ void GPUToSPIRVPass::runOnOperation() { std::unique_ptr target = spirv::getMemorySpaceToStorageClassTarget(*context); spirv::MemorySpaceToStorageClassMap memorySpaceMap = - spirv::mapMemorySpaceToVulkanStorageClass; +

[clang] [MLIR] Enabling Intel GPU Integration. (PR #65539)

@@ -71,7 +71,8 @@ void GPUToSPIRVPass::runOnOperation() { std::unique_ptr target = spirv::getMemorySpaceToStorageClassTarget(*context); spirv::MemorySpaceToStorageClassMap memorySpaceMap = - spirv::mapMemorySpaceToVulkanStorageClass; +

[PATCH] D74094: Reapply: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas

tellenbach added a comment. No real comment on the issue itself but on the example as a former Eigen maintainer (sorry for the noise if that's all obvious for you): auto round (Tensor m) { return (m + 0.5f).cast().cast(); } does not return a Tensor but an expression encoding the

[clang] [clang][CodeGen] Use byval for SystemZ indirect arguments (PR #66404)

iii-i wrote: I just checked with a few small examples, and while the ABI does not seem to change, the code generation looks broken for tail recursion: ``` $ cat 1.c void baz(long double); void quux(void) { baz((long double)1); } $ ./bin/clang -O3 -S 1.c $ cat 1.s [...] aghi%r15,

[clang] [clang][doc] Add documentation for the ASTs used to represent C++ templates (PR #66436)

https://github.com/shafik review_requested https://github.com/llvm/llvm-project/pull/66436 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][doc] Add documentation for the ASTs used to represent C++ templates (PR #66436)

https://github.com/shafik review_requested https://github.com/llvm/llvm-project/pull/66436 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][doc] Add documentation for the ASTs used to represent C++ templates (PR #66436)

https://github.com/shafik review_requested https://github.com/llvm/llvm-project/pull/66436 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][deps] Load module map file from PCM (PR #66389)

@@ -1307,6 +1307,9 @@ void ModuleMap::setInferredModuleAllowedBy(Module *M, std::error_code ModuleMap::canonicalizeModuleMapPath(SmallVectorImpl ) { + FileManager = SourceMgr.getFileManager(); + FM.makeAbsolutePath(Path); benlangmuir wrote: This would

[clang] Support target names with dots in more utilities (PR #65812)

dankm wrote: Hm. I'm happy with this file, but I also discovered a bunch of other `tool-name` tests that can be updated. I'll add those too. https://github.com/llvm/llvm-project/pull/65812 ___ cfe-commits mailing

[clang] Support target names with dots in more utilities (PR #65812)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65812 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Support target names with dots in more utilities (PR #65812)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65812 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Support target names with dots in more utilities (PR #65812)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65812 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Coverage] Add coverage for constructor member initializers. (PR #66441)

https://github.com/ZequanWu review_requested https://github.com/llvm/llvm-project/pull/66441 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Coverage] Add coverage for constructor member initializers. (PR #66441)

https://github.com/ZequanWu review_requested https://github.com/llvm/llvm-project/pull/66441 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Coverage] Add coverage for constructor member initializers. (PR #66441)

https://github.com/ZequanWu review_requested https://github.com/llvm/llvm-project/pull/66441 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Support target names with dots in more utilities (PR #65812)

https://github.com/dankm updated https://github.com/llvm/llvm-project/pull/65812: >From 416d75e617cc87b6e497815ce6ad1da630eb14a1 Mon Sep 17 00:00:00 2001 From: Dan McGregor Date: Mon, 14 Aug 2023 18:44:08 -0600 Subject: [PATCH 1/2] Support: hoist lld's executable name code to Path Instead of

[clang] [Coverage] Add coverage for constructor member initializers. (PR #66441)

llvmbot wrote: @llvm/pr-subscribers-clang Changes Before, constructor member initializers are shown as not covered. This adds coverage info for them. -- Full diff: https://github.com/llvm/llvm-project/pull/66441.diff 2 Files Affected: - (modified)

[clang] [Coverage] Add coverage for constructor member initializers. (PR #66441)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66441 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Coverage] Add coverage for constructor member initializers. (PR #66441)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66441 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Coverage] Add coverage for constructor member initializers. (PR #66441)

https://github.com/ZequanWu created https://github.com/llvm/llvm-project/pull/66441: Before, constructor member initializers are shown as not covered. This adds coverage info for them. >From be614f6412f0ddd9e4fea8842fbf0ddc389e6be6 Mon Sep 17 00:00:00 2001 From: Zequan Wu Date: Thu, 14 Sep

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

Prabhuk updated this revision to Diff 556813. Prabhuk marked 2 inline comments as done. Prabhuk added a comment. Addressed review comments. Added "-dll" and "-tsaware:no" linker flags for UEFI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] Fix math-errno issue (PR #66381)

https://github.com/zahiraam edited https://github.com/llvm/llvm-project/pull/66381 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix math-errno issue (PR #66381)

https://github.com/zahiraam ready_for_review https://github.com/llvm/llvm-project/pull/66381 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix math-errno issue (PR #66381)

https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/66381: >From 997e3b69ac5c20a9130b957c86c08b16d23af07c Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Thu, 14 Sep 2023 06:27:35 -0700 Subject: [PATCH 1/3] Fix math-errno issue ---

[clang] Introduce paged vector (PR #66430)

llvmbot wrote: @llvm/pr-subscribers-clang-modules Changes None -- Full diff: https://github.com/llvm/llvm-project/pull/66430.diff 5 Files Affected: - (modified) clang/include/clang/Basic/SourceManager.h (+2-1) - (modified) clang/include/clang/Serialization/ASTReader.h (+3-2)

[clang] [clang][doc] Add documentation for the ASTs used to represent C++ templates (PR #66436)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66436 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][CodeGen] Change CodeGenOpt::Level/CodeGenFileType into enum classes (PR #66295)

https://github.com/aeubanks closed https://github.com/llvm/llvm-project/pull/66295 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D74094: Reapply: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas

nickdesaulniers added a comment. In D74094#4646152 , @nickdesaulniers wrote: > In D74094#4645998 , @dexonsmith > wrote: > >> In D74094#4645562 , >> @nickdesaulniers

[clang] Introduce paged vector (PR #66430)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Introduce paged vector (PR #66430)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Introduce paged vector (PR #66430)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Introduce paged vector (PR #66430)

https://github.com/ktf created https://github.com/llvm/llvm-project/pull/66430: None >From b952f0577dfe8112f394bd5392212f843c0cc86e Mon Sep 17 00:00:00 2001 From: Giulio Eulisse <10544+...@users.noreply.github.com> Date: Thu, 14 Sep 2023 21:58:21 +0200 Subject: [PATCH 1/2] Introduce PagedVector

[PATCH] D69062: Resolve LWG issue 2426

EricWF commandeered this revision. EricWF edited reviewers, added: zoecarver; removed: EricWF. EricWF added a comment. Herald added a reviewer: libc++. Herald added a project: All. In D69062#1711610 , @ldionne wrote: > If we want to mark the LWG issue as

[PATCH] D61364: [libcxx] [test] Fix incorrect allocator::construct assertions in associative container tests

EricWF commandeered this revision. EricWF edited reviewers, added: BillyONeal; removed: EricWF. EricWF added a comment. Herald added a project: All. Fixing this requires a bunch of container overall in the containers that I don't have the time for right now. So I'm going to go ahead and close

[PATCH] D148381: [Clang] Implement the 'counted_by' attribute

void added inline comments. Comment at: clang/include/clang/Basic/Attr.td:4246 +private: + SourceRange countedByFieldLoc; +public: aaron.ballman wrote: > void wrote: > > erichkeane wrote: > > > aaron.ballman wrote: > > > > Teeny tiniest of coding

[PATCH] D157913: [Coverage] Allow Clang coverage to be used with debug info correlation.

zequanwu added a comment. In D157913#4646184 , @ellis wrote: > It looks like `debug-info-correlate-coverage.ll` was renamed twice. Is this > intended? I just moved `llvm/test/Instrumentation/InstrProfiling/debug-info-correlate-coverage.ll.` to

[PATCH] D157913: [Coverage] Allow Clang coverage to be used with debug info correlation.

zequanwu updated this revision to Diff 556809. zequanwu marked 3 inline comments as done. zequanwu added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157913/new/ https://reviews.llvm.org/D157913 Files:

[clang] [NFC][CodeGen] Change CodeGenOpt::Level/CodeGenFileType into enum classes (PR #66295)

https://github.com/rnk approved this pull request. https://github.com/llvm/llvm-project/pull/66295 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D157913: [Coverage] Allow Clang coverage to be used with debug info correlation.

ellis added a comment. It looks like `debug-info-correlate-coverage.ll` was renamed twice. Is this intended? Comment at: compiler-rt/lib/profile/InstrProfilingWriter.c:276-277 __llvm_profile_get_num_counters(CountersBegin, CountersEnd); - const uint64_t NamesSize =

[clang] [clang-format] Fix a bug in ContinuationIndenter (PR #66354)

https://github.com/owenca updated https://github.com/llvm/llvm-project/pull/66354: >From 73669f7d04070feade2282384478e96b8bc6d727 Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Thu, 14 Sep 2023 02:59:43 -0700 Subject: [PATCH] [clang-format] Fix a bug in ContinuationIndenter See

[clang] [HIP] Fix comdat of template kernel handle (PR #66283)

https://github.com/yxsamliu closed https://github.com/llvm/llvm-project/pull/66283 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] d7e1932 - [HIP] Fix comdat of template kernel handle (#66283)

Author: Yaxun (Sam) Liu Date: 2023-09-14T15:56:02-04:00 New Revision: d7e1932f857986df039b222619623428dc4ffe30 URL: https://github.com/llvm/llvm-project/commit/d7e1932f857986df039b222619623428dc4ffe30 DIFF:

[clang] [clang][CodeGen] Use byval for SystemZ indirect arguments (PR #66404)

efriedma-quic wrote: byval changes the calling convention: instead of passing a pointer, it copies the pointed-to value into the argument list. It's not clear to me why msan cares about whether a pointer is an implicit or explicit value... but if it does, we'd want to use an attribute that

[clang] [analyzer] TaintPropagation checker strlen() should not propagate (PR #66086)

steakhal wrote: Request another round of review once you are happy with the content and addressed the open comments. On the grand scheme we are aligned. https://github.com/llvm/llvm-project/pull/66086 ___ cfe-commits mailing list

[clang] Update GoogleTest to v1.14.0 (PR #65823)

bjope wrote: > > Ok, seems like the only problem is the MemProf unit test > > compiler-rt/lib/memprof/tests/ > > So if I manually disable that I don't see any other failures with this > > patch. > > I think any components that uses freshly built clang (stage1) could > potentially run into

[clang] [DependencyScanningFilesystem] Make sure the local/shared cache filename lookups use only absolute paths (PR #66122)

@@ -330,3 +353,20 @@ DependencyScanningWorkerFilesystem::openFileForRead(const Twine ) { return Result.getError(); return DepScanFile::create(Result.get()); } + +std::error_code DependencyScanningWorkerFilesystem::setCurrentWorkingDirectory( +const Twine ) { +

[clang] [dataflow] Parse formulas from text (PR #66424)

sam-mccall wrote: Not sure if this is really important to have checked in, but I've wanted to investigate/reproduce flow condition slowness a few times now, so thought I should send the patch in case others think it's useful. https://github.com/llvm/llvm-project/pull/66424

[clang] [dataflow] Parse formulas from text (PR #66424)

https://github.com/sam-mccall review_requested https://github.com/llvm/llvm-project/pull/66424 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [dataflow] Parse formulas from text (PR #66424)

https://github.com/sam-mccall review_requested https://github.com/llvm/llvm-project/pull/66424 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [dataflow] Parse formulas from text (PR #66424)

llvmbot wrote: @llvm/pr-subscribers-clang-analysis Changes My immediate use for this is not in checked-in code, but rather the ability to plug printed flow conditions (from analysis logs) back into sat solver unittests to reproduce slowness. It does allow simplifying some of

[clang] [dataflow] Parse formulas from text (PR #66424)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66424 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   3   4   >