[clang] [Driver] Implement ToolChain on Haiku (PR #66038)

2023-09-20 Thread Fangrui Song via cfe-commits
@@ -9,20 +9,142 @@ #include "Haiku.h" #include "CommonArgs.h" #include "clang/Config/config.h" +#include "clang/Driver/Compilation.h" #include "llvm/Support/Path.h" using namespace clang::driver; +using namespace clang::driver::tools; using namespace

[clang] [Driver] Implement ToolChain on Haiku (PR #66038)

2023-09-20 Thread Fangrui Song via cfe-commits
@@ -36,3 +36,32 @@ // CHECK-C-HEADER-PATH: "-internal-isystem" "/boot/system/develop/headers/gnu" // CHECK-C-HEADER-PATH: "-internal-isystem" "/boot/system/develop/headers/posix" // CHECK-C-HEADER-PATH: "-internal-isystem" "/boot/system/develop/headers" + +// Check

[clang] [Driver] Implement ToolChain on Haiku (PR #66038)

2023-09-20 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay edited https://github.com/llvm/llvm-project/pull/66038 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Implement ToolChain on Haiku (PR #66038)

2023-09-20 Thread Fangrui Song via cfe-commits
@@ -15,30 +15,53 @@ namespace clang { namespace driver { +namespace tools { + +/// Directly call GNU Binutils assembler and linker +namespace haiku { +class LLVM_LIBRARY_VISIBILITY Linker : public Tool { MaskRay wrote: `final`

[clang] [Driver] Implement ToolChain on Haiku (PR #66038)

2023-09-20 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay approved this pull request. Can a Haiku developer confirm that these changes work on Haiku? https://github.com/llvm/llvm-project/pull/66038 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [RISCV] Fix wrong implication for zvknhb. (PR #66860)

2023-09-20 Thread Brandon Wu via cfe-commits
https://github.com/4vtomat resolved https://github.com/llvm/llvm-project/pull/66860 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RISCV] Fix wrong implication for zvknhb. (PR #66860)

2023-09-20 Thread Brandon Wu via cfe-commits
https://github.com/4vtomat updated https://github.com/llvm/llvm-project/pull/66860 >From 3c28f7bace91dc4edd5e87b9f1a36d100cf38318 Mon Sep 17 00:00:00 2001 From: 4vtomat Date: Tue, 19 Sep 2023 23:06:01 -0700 Subject: [PATCH 1/2] [RISCV] Fix wrong implication for zvknhb. ---

[clang] [clang][AST][ASTImporter] improve AST comparasion on VarDecl & GotoStmt (PR #66976)

2023-09-20 Thread Qizhi Hu via cfe-commits
https://github.com/jcsxky closed https://github.com/llvm/llvm-project/pull/66976 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D159519: [clang][AST][ASTImporter] improve AST comparasion on VarDecl & GotoStmt

2023-09-20 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGb8f056de025f: [clang][AST][ASTImporter] improve AST comparasion on VarDecl GotoStmt (#66976) (authored by jcsxky, committed by GitHub nore...@github.com). Repository: rG LLVM Github Monorepo CHANGES

[clang] b8f056d - [clang][AST][ASTImporter] improve AST comparasion on VarDecl & GotoStmt (#66976)

2023-09-20 Thread via cfe-commits
Author: Qizhi Hu Date: 2023-09-21T13:13:43+08:00 New Revision: b8f056de025f5047bfed5573e65a8c840dbb76d4 URL: https://github.com/llvm/llvm-project/commit/b8f056de025f5047bfed5573e65a8c840dbb76d4 DIFF: https://github.com/llvm/llvm-project/commit/b8f056de025f5047bfed5573e65a8c840dbb76d4.diff

[clang] [clang][AST][ASTImporter] improve AST comparasion on VarDecl & GotoStmt (PR #66976)

2023-09-20 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Changes improve AST comparasion on VarDecl GotoStmt: 1. VarDecl should not be ignored, 2. GotoStmt has no children, it should be handle explicitly. Reviewed By: donat.nagy Differential Revision: https://reviews.llvm.org/D159519 --- Full

[clang] [RISCV] Fix wrong implication for zvknhb. (PR #66860)

2023-09-20 Thread Brandon Wu via cfe-commits
@@ -599,15 +599,21 @@ def HasStdExtZvkned : Predicate<"Subtarget->hasStdExtZvkned()">, def FeatureStdExtZvknha : SubtargetFeature<"experimental-zvknha", "HasStdExtZvknha", "true", "'Zvknha' (Vector SHA-2 (SHA-256 only))">; - -def FeatureStdExtZvknhb

[clang] [clang][AST][ASTImporter] improve AST comparasion on VarDecl & GotoStmt (PR #66976)

2023-09-20 Thread Qizhi Hu via cfe-commits
https://github.com/jcsxky created https://github.com/llvm/llvm-project/pull/66976 improve AST comparasion on VarDecl & GotoStmt: 1. VarDecl should not be ignored, 2. GotoStmt has no children, it should be handle explicitly. Reviewed By: donat.nagy Differential Revision:

[clang] [flang][Driver] Support -rpath, -shared, and -static in the frontend (PR #66702)

2023-09-20 Thread Fangrui Song via cfe-commits
@@ -50,3 +50,19 @@ ! MSVC-SAME: FortranDecimal.lib ! MSVC-SAME: /subsystem:console ! MSVC-SAME: "[[object_file]]" + +! Verify that certain linker flags are known to the frontend and are passed on +! to the linker. + +! RUN: %flang -### -rpath /path/to/dir %s 2>&1 \

[clang] Introduce paged vector (PR #66430)

2023-09-20 Thread Fangrui Song via cfe-commits
@@ -0,0 +1,302 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +//

[clang] Introduce paged vector (PR #66430)

2023-09-20 Thread Fangrui Song via cfe-commits
@@ -0,0 +1,302 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +//

[clang] Introduce paged vector (PR #66430)

2023-09-20 Thread Fangrui Song via cfe-commits
@@ -0,0 +1,322 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +//

[clang] Introduce paged vector (PR #66430)

2023-09-20 Thread Fangrui Song via cfe-commits
@@ -0,0 +1,302 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +//

[clang] [clang][AST][ASTImporter] improve AST comparasion on VarDecl & GotoStmt (PR #66110)

2023-09-20 Thread Qizhi Hu via cfe-commits
https://github.com/jcsxky edited https://github.com/llvm/llvm-project/pull/66110 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][AST][ASTImporter] improve AST comparasion on VarDecl & GotoStmt (PR #66110)

2023-09-20 Thread Qizhi Hu via cfe-commits
https://github.com/jcsxky edited https://github.com/llvm/llvm-project/pull/66110 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

2023-09-20 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/66514 >From 4323e6952a577a81a5fdc51ce9571f28d7ccb6f9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?=

[clang] [RISCV] Fix wrong implication for zvknhb. (PR #66860)

2023-09-20 Thread Craig Topper via cfe-commits
@@ -599,15 +599,21 @@ def HasStdExtZvkned : Predicate<"Subtarget->hasStdExtZvkned()">, def FeatureStdExtZvknha : SubtargetFeature<"experimental-zvknha", "HasStdExtZvknha", "true", "'Zvknha' (Vector SHA-2 (SHA-256 only))">; - -def FeatureStdExtZvknhb

[clang] [Clang][LLVM][Coroutines] Prevent __coro_gro from outliving __promise (PR #66706)

2023-09-20 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 edited https://github.com/llvm/llvm-project/pull/66706 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [MSVC, ARM64] Add _Copy* and _Count* intrinsics (PR #66554)

2023-09-20 Thread Eli Friedman via cfe-commits
https://github.com/efriedma-quic approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/66554 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-analysis]Fix false positive in mutation check when using pointer to member function (PR #66846)

2023-09-20 Thread via cfe-commits
@@ -100,6 +100,20 @@ AST_MATCHER(CXXTypeidExpr, isPotentiallyEvaluated) { return Node.isPotentiallyEvaluated(); } +AST_MATCHER(CXXMemberCallExpr, isConstCallee) { + const auto *CalleeDecl = Node.getCalleeDecl(); + const auto *VD = dyn_cast_or_null(CalleeDecl); + if (!VD)

[clang-tools-extra] [clang-analysis]Fix false positive in mutation check when using pointer to member function (PR #66846)

2023-09-20 Thread via cfe-commits
@@ -100,6 +100,20 @@ AST_MATCHER(CXXTypeidExpr, isPotentiallyEvaluated) { return Node.isPotentiallyEvaluated(); } +AST_MATCHER(CXXMemberCallExpr, isConstCallee) { + const auto *CalleeDecl = Node.getCalleeDecl(); EugeneZelenko wrote: Please don't use

[clang-tools-extra] [clang-analysis]Fix false positive in mutation check when using pointer to member function (PR #66846)

2023-09-20 Thread via cfe-commits
@@ -100,6 +100,20 @@ AST_MATCHER(CXXTypeidExpr, isPotentiallyEvaluated) { return Node.isPotentiallyEvaluated(); } +AST_MATCHER(CXXMemberCallExpr, isConstCallee) { + const auto *CalleeDecl = Node.getCalleeDecl(); + const auto *VD = dyn_cast_or_null(CalleeDecl); + if (!VD)

[clang] [Clang] Enable AIX local-dynamic TLS mode (PR #66972)

2023-09-20 Thread Ting Wang via cfe-commits
orcguru wrote: It's not expected that this commit includes all commits from the backend patch. Maybe I have to serialize the code review. Close this now. https://github.com/llvm/llvm-project/pull/66972 ___ cfe-commits mailing list

[clang] [Clang] Enable AIX local-dynamic TLS mode (PR #66972)

2023-09-20 Thread Ting Wang via cfe-commits
https://github.com/orcguru closed https://github.com/llvm/llvm-project/pull/66972 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Enable AIX local-dynamic TLS mode (PR #66972)

2023-09-20 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Changes We are going to support local-dynamic TLS mode on AIX targets. This patch removes relevant guards in clang. --- Patch is 137.79 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/66972.diff 21

[clang] [clang-format] Don't split "DPI"/"DPI-C" in Verilog imports (PR #66951)

2023-09-20 Thread Owen Pan via cfe-commits
owenca wrote: Please wait for @sstwcw. IMO it would be better to disable splitting string literals after `import`. https://github.com/llvm/llvm-project/pull/66951 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [RISCV] Fix wrong implication for zvknhb. (PR #66860)

2023-09-20 Thread Brandon Wu via cfe-commits
@@ -599,15 +599,21 @@ def HasStdExtZvkned : Predicate<"Subtarget->hasStdExtZvkned()">, def FeatureStdExtZvknha : SubtargetFeature<"experimental-zvknha", "HasStdExtZvknha", "true", "'Zvknha' (Vector SHA-2 (SHA-256 only))">; - -def FeatureStdExtZvknhb

[clang] [Clang][LLVM][Coroutines] Prevent __coro_gro from outliving __promise (PR #66706)

2023-09-20 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 commented: Thanks. It looks good if we can add llvm test in llvm/test/Transforms/Coroutines for the new metadata. https://github.com/llvm/llvm-project/pull/66706 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [Clang][LLVM][Coroutines] Prevent __coro_gro from outliving __promise (PR #66706)

2023-09-20 Thread Chuanqi Xu via cfe-commits
@@ -104,3 +105,5 @@ invoker g() { // CHECK: call void @_ZN7invoker15invoker_promise17get_return_objectEv({{.*}} %[[AggRes]] co_return; } + +// CHECK: ![[OutFrameMetadata]] = !{} ChuanqiXu9 wrote: nit: no newline

[clang] [Clang][LLVM][Coroutines] Prevent __coro_gro from outliving __promise (PR #66706)

2023-09-20 Thread Chuanqi Xu via cfe-commits
@@ -6691,6 +6691,22 @@ sections that the user does not want removed after linking. ... !0 = !{} +'``coro.outside.frame``' Metadata +^^ + +``coro.outside.frame`` metadata may be attached to an alloca instruction to +to signify that it shouldn't be

[clang] [Clang][LLVM][Coroutines] Prevent __coro_gro from outliving __promise (PR #66706)

2023-09-20 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 edited https://github.com/llvm/llvm-project/pull/66706 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RISCV] Fix wrong implication for zvknhb. (PR #66860)

2023-09-20 Thread Craig Topper via cfe-commits
@@ -599,15 +599,21 @@ def HasStdExtZvkned : Predicate<"Subtarget->hasStdExtZvkned()">, def FeatureStdExtZvknha : SubtargetFeature<"experimental-zvknha", "HasStdExtZvknha", "true", "'Zvknha' (Vector SHA-2 (SHA-256 only))">; - -def FeatureStdExtZvknhb

[clang] [RISCV] Fix wrong implication for zvknhb. (PR #66860)

2023-09-20 Thread Brandon Wu via cfe-commits
https://github.com/4vtomat unresolved https://github.com/llvm/llvm-project/pull/66860 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RISCV] Fix wrong implication for zvknhb. (PR #66860)

2023-09-20 Thread Brandon Wu via cfe-commits
@@ -599,15 +599,21 @@ def HasStdExtZvkned : Predicate<"Subtarget->hasStdExtZvkned()">, def FeatureStdExtZvknha : SubtargetFeature<"experimental-zvknha", "HasStdExtZvknha", "true", "'Zvknha' (Vector SHA-2 (SHA-256 only))">; - -def FeatureStdExtZvknhb

[clang] [OpenMP] Introduce support for OMPX extensions and taskgraph frontend (PR #66919)

2023-09-20 Thread Shilei Tian via cfe-commits
@@ -347,10 +347,6 @@ if(LIBOMP_OMPD_SUPPORT AND ((NOT LIBOMP_OMPT_SUPPORT) OR (NOT "${CMAKE_SYSTEM_NA set(LIBOMP_OMPD_SUPPORT FALSE) endif() -# OMPX Taskgraph support shiltian wrote: I'm not sure if I asked it before, but if possible can we run some task

[clang] [RISCV] Fix wrong implication for zvknhb. (PR #66860)

2023-09-20 Thread Craig Topper via cfe-commits
@@ -599,15 +599,21 @@ def HasStdExtZvkned : Predicate<"Subtarget->hasStdExtZvkned()">, def FeatureStdExtZvknha : SubtargetFeature<"experimental-zvknha", "HasStdExtZvknha", "true", "'Zvknha' (Vector SHA-2 (SHA-256 only))">; - -def FeatureStdExtZvknhb

[clang] [OpenMP] Introduce support for OMPX extensions and taskgraph frontend (PR #66919)

2023-09-20 Thread Shilei Tian via cfe-commits
shiltian wrote: Since that is an extension, we have to check `getLangOpts().OpenMPExtensions`. https://github.com/llvm/llvm-project/pull/66919 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [RISCV] Fix wrong implication for zvknhb. (PR #66860)

2023-09-20 Thread Brandon Wu via cfe-commits
https://github.com/4vtomat resolved https://github.com/llvm/llvm-project/pull/66860 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RISCV] Fix wrong implication for zvknhb. (PR #66860)

2023-09-20 Thread Brandon Wu via cfe-commits
4vtomat wrote: no change, just to re-trigger checks. https://github.com/llvm/llvm-project/pull/66860 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 69074bf - [clang] NFCI: Use `FileEntryRef` in `FileManagerTest`

2023-09-20 Thread Jan Svoboda via cfe-commits
Author: Jan Svoboda Date: 2023-09-20T18:41:25-07:00 New Revision: 69074bf144c1bf54040d289584e3d1d54f883a37 URL: https://github.com/llvm/llvm-project/commit/69074bf144c1bf54040d289584e3d1d54f883a37 DIFF: https://github.com/llvm/llvm-project/commit/69074bf144c1bf54040d289584e3d1d54f883a37.diff

[clang-tools-extra] 3de1e30 - [clang] NFCI: Use `FileEntryRef` in `SymbolCollector`

2023-09-20 Thread Jan Svoboda via cfe-commits
Author: Jan Svoboda Date: 2023-09-20T18:41:25-07:00 New Revision: 3de1e30c9a59c0c2f7d498488532e1e324059082 URL: https://github.com/llvm/llvm-project/commit/3de1e30c9a59c0c2f7d498488532e1e324059082 DIFF: https://github.com/llvm/llvm-project/commit/3de1e30c9a59c0c2f7d498488532e1e324059082.diff

[clang] [libc++] Implement ranges::contains_subrange (PR #66963)

2023-09-20 Thread via cfe-commits
https://github.com/ZijunZhaoCCK updated https://github.com/llvm/llvm-project/pull/66963 >From 5a2c930770cf548c5e3f3451e76b48cb067e6762 Mon Sep 17 00:00:00 2001 From: Zijun Zhao Date: Wed, 13 Sep 2023 14:26:01 -0700 Subject: [PATCH 1/2] [libc++] Implement ranges::contains_subrange ---

[clang] [RISCV] Fix wrong implication for zvknhb. (PR #66860)

2023-09-20 Thread Brandon Wu via cfe-commits
https://github.com/4vtomat updated https://github.com/llvm/llvm-project/pull/66860 >From 3c28f7bace91dc4edd5e87b9f1a36d100cf38318 Mon Sep 17 00:00:00 2001 From: 4vtomat Date: Tue, 19 Sep 2023 23:06:01 -0700 Subject: [PATCH] [RISCV] Fix wrong implication for zvknhb. ---

[clang] [libc++] Implement ranges::contains_subrange (PR #66963)

2023-09-20 Thread via cfe-commits
https://github.com/ZijunZhaoCCK updated https://github.com/llvm/llvm-project/pull/66963 >From 5a2c930770cf548c5e3f3451e76b48cb067e6762 Mon Sep 17 00:00:00 2001 From: Zijun Zhao Date: Wed, 13 Sep 2023 14:26:01 -0700 Subject: [PATCH] [libc++] Implement ranges::contains_subrange ---

[clang] [libc++] Implement ranges::contains_subrange (PR #66963)

2023-09-20 Thread via cfe-commits
https://github.com/ZijunZhaoCCK updated https://github.com/llvm/llvm-project/pull/66963 >From 5a2c930770cf548c5e3f3451e76b48cb067e6762 Mon Sep 17 00:00:00 2001 From: Zijun Zhao Date: Wed, 13 Sep 2023 14:26:01 -0700 Subject: [PATCH] [libc++] Implement ranges::contains_subrange ---

[clang] [clang][Sema] Fix crash introduced in b2cd9db589335d5885c04df83003a623cf2f05ff (PR #66954)

2023-09-20 Thread Shafik Yaghmour via cfe-commits
shafik wrote: Thanks for the quick fix! https://github.com/llvm/llvm-project/pull/66954 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] -fsanitize=function: fix MSVC hashing to sugared type (PR #66816)

2023-09-20 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov updated https://github.com/llvm/llvm-project/pull/66816 >From f2e022964f00e348ad3ab04ade88182485f7c19d Mon Sep 17 00:00:00 2001 From: Matheus Izvekov Date: Tue, 19 Sep 2023 22:21:25 +0200 Subject: [PATCH] -fsanitize=function: fix MSVC hashing to sugared type

[clang] 4914d33 - -fsanitize=function: Add a (bugged) test case for a sugared function type

2023-09-20 Thread Matheus Izvekov via cfe-commits
Author: Matheus Izvekov Date: 2023-09-21T02:57:49+02:00 New Revision: 4914d33b6fc4284a491e3c9a050f277511da17b6 URL: https://github.com/llvm/llvm-project/commit/4914d33b6fc4284a491e3c9a050f277511da17b6 DIFF:

[clang] 2ed0453 - -fsanitize=function: Add a MSVC test case

2023-09-20 Thread Matheus Izvekov via cfe-commits
Author: Matheus Izvekov Date: 2023-09-21T02:56:57+02:00 New Revision: 2ed0453b10ddf6617856b0c93be5bf72a8090f2f URL: https://github.com/llvm/llvm-project/commit/2ed0453b10ddf6617856b0c93be5bf72a8090f2f DIFF:

[clang] [clang][modules] Move `SLocEntry` search into `ASTReader` (PR #66966)

2023-09-20 Thread Jan Svoboda via cfe-commits
jansvoboda11 wrote: Marking as draft for now. We still need to cache the lightweight offset deserialization. While this patch speeds up the dependency scanner as it stands, implicit modules compile slows down by 50%. https://github.com/llvm/llvm-project/pull/66966

[clang] [clang][modules] Move `SLocEntry` search into `ASTReader` (PR #66966)

2023-09-20 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-modules Changes In `getFileID()` the `SourceManager` ends up doing a binary search over its buffer of `SLocEntries`. For modules, this binary search fully deserializes the entire `SLocEntry` block for visited each entry. This shows up in profiles

[clang] [clang][modules] Move `SLocEntry` search into `ASTReader` (PR #66966)

2023-09-20 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 created https://github.com/llvm/llvm-project/pull/66966 In `getFileID()` the `SourceManager` ends up doing a binary search over its buffer of `SLocEntries`. For modules, this binary search fully deserializes the entire `SLocEntry` block for visited each entry.

[clang-tools-extra] [llvm-profdata] Do not create numerical strings for MD5 function names read from a Sample Profile. (PR #66164)

2023-09-20 Thread William Junda Huang via cfe-commits
@@ -0,0 +1,225 @@ +//===--- ProfileFuncRef.h - Sample profile function name ---*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang] [Sema] Fix fixit cast printing inside macros (PR #66853)

2023-09-20 Thread Shoaib Meenai via cfe-commits
https://github.com/smeenai closed https://github.com/llvm/llvm-project/pull/66853 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 61c5ad8 - [Sema] Fix fixit cast printing inside macros (#66853)

2023-09-20 Thread via cfe-commits
Author: Shoaib Meenai Date: 2023-09-20T17:32:35-07:00 New Revision: 61c5ad8857a71510e4393680a1e42740da4ba6fa URL: https://github.com/llvm/llvm-project/commit/61c5ad8857a71510e4393680a1e42740da4ba6fa DIFF: https://github.com/llvm/llvm-project/commit/61c5ad8857a71510e4393680a1e42740da4ba6fa.diff

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

2023-09-20 Thread Prabhu Karthikeyan Rajasekaran via Phabricator via cfe-commits
Prabhuk updated this revision to Diff 557154. Prabhuk added a comment. Minor cleanup. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152206/new/ https://reviews.llvm.org/D152206 Files: clang/lib/Basic/Targets.cpp

[clang-tools-extra] [llvm-profdata] Do not create numerical strings for MD5 function names read from a Sample Profile. (PR #66164)

2023-09-20 Thread William Junda Huang via cfe-commits
huangjd wrote: Added performance measurement. This patch does significantly reduce profile load time, which is its motivation https://github.com/llvm/llvm-project/pull/66164 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [llvm-profdata] Do not create numerical strings for MD5 function names read from a Sample Profile. (PR #66164)

2023-09-20 Thread William Junda Huang via cfe-commits
huangjd wrote: Added performance measurement. This patch does significantly reduce profile load time, which is its motivation https://github.com/llvm/llvm-project/pull/66164 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] [llvm-profdata] Do not create numerical strings for MD5 function names read from a Sample Profile. (PR #66164)

2023-09-20 Thread William Junda Huang via cfe-commits
https://github.com/huangjd edited https://github.com/llvm/llvm-project/pull/66164 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm-profdata] Do not create numerical strings for MD5 function names read from a Sample Profile. (PR #66164)

2023-09-20 Thread William Junda Huang via cfe-commits
https://github.com/huangjd edited https://github.com/llvm/llvm-project/pull/66164 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

2023-09-20 Thread Prabhu Karthikeyan Rajasekaran via Phabricator via cfe-commits
Prabhuk updated this revision to Diff 557153. Prabhuk added a comment. Update X86 backend to use Microsoft ABI for UEFI target. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152206/new/ https://reviews.llvm.org/D152206 Files:

[PATCH] D138846: MC/DC in LLVM Source-Based Code Coverage: LLVM back-end and compiler-rt

2023-09-20 Thread Alan Phipps via Phabricator via cfe-commits
alanphipps added a comment. In D138846#4649110 , @akhuang wrote: > I'm still working on a repro, but after this patch we're seeing "truncated > profile data" errors in chromium (crbug.com/1485303) Thank you for the heads-up! If there's an issue, I'm

[clang] [clang][modules] Remove preloaded SLocEntries from PCM files (PR #66962)

2023-09-20 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-modules Changes This commit removes the list of SLocEntry offsets to preload eagerly from PCM files. Commit introducing this functionality (258ae54a) doesn't clarify why this would be more performant than the lazy approach used regularly.

[clang] [clang][modules] Remove preloaded SLocEntries from PCM files (PR #66962)

2023-09-20 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 created https://github.com/llvm/llvm-project/pull/66962 This commit removes the list of SLocEntry offsets to preload eagerly from PCM files. Commit introducing this functionality (258ae54a) doesn't clarify why this would be more performant than the lazy

[clang] [clang-format] Don't split "DPI"/"DPI-C" in Verilog imports (PR #66951)

2023-09-20 Thread via cfe-commits
@@ -2270,7 +2270,15 @@ ContinuationIndenter::createBreakableToken(const FormatToken , if (State.Stack.back().IsInsideObjCArrayLiteral) return nullptr; +// The "DPI" (or "DPI-C") in SystemVerilog direct programming interface +// imports cannot be split, e.g.

[clang] [clang-format] Don't split "DPI"/"DPI-C" in Verilog imports (PR #66951)

2023-09-20 Thread via cfe-commits
https://github.com/alexfh approved this pull request. Looks good once the comment is addressed. https://github.com/llvm/llvm-project/pull/66951 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang-format] Don't split "DPI"/"DPI-C" in Verilog imports (PR #66951)

2023-09-20 Thread via cfe-commits
https://github.com/alexfh edited https://github.com/llvm/llvm-project/pull/66951 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] -fsanitize=function: fix MSVC hashing to sugared type (PR #66816)

2023-09-20 Thread Matheus Izvekov via cfe-commits
mizvekov wrote: I think this is a better direction overall, although it has the downside that it might be more difficult to backport this to 17. https://github.com/llvm/llvm-project/pull/66816 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] -fsanitize=function: fix MSVC hashing to sugared type (PR #66816)

2023-09-20 Thread Reid Kleckner via cfe-commits
rnk wrote: Seems reasonable to me, but I want @efriedma-quic to approve as well, if this is a reasonable implementation of your direction. https://github.com/llvm/llvm-project/pull/66816 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang] Enable descriptions for --print-supported-extensions (PR #66715)

2023-09-20 Thread Balint Cristian via cfe-commits
https://github.com/cbalint13 resolved https://github.com/llvm/llvm-project/pull/66715 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][LLVM][Coroutines] Prevent __coro_gro from outliving __promise (PR #66706)

2023-09-20 Thread Bruno Cardoso Lopes via cfe-commits
bcardosolopes wrote: Thanks for the clarifications > By forcing the GRO not living on the coroutine frames, it shouldn't be a > problem if the lifetime of `__coro_gro` outlives the `__promise`. The only > limit is that the initialization of `__coro_gro` should be in the lifetime of >

[clang] [Clang][LLVM][Coroutines] Prevent __coro_gro from outliving __promise (PR #66706)

2023-09-20 Thread Bruno Cardoso Lopes via cfe-commits
https://github.com/bcardosolopes edited https://github.com/llvm/llvm-project/pull/66706 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Coroutines] Improve GRO handling to better fit scopes and cleanups (PR #66706)

2023-09-20 Thread Bruno Cardoso Lopes via cfe-commits
https://github.com/bcardosolopes edited https://github.com/llvm/llvm-project/pull/66706 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [libc++] Implement ranges::contains (PR #65148)

2023-09-20 Thread via cfe-commits
https://github.com/ZijunZhaoCCK updated https://github.com/llvm/llvm-project/pull/65148 >From 02e9afd761228f401df4d9f8dfaaca44ffae0c6e Mon Sep 17 00:00:00 2001 From: zijunzhao Date: Thu, 31 Aug 2023 20:08:32 + Subject: [PATCH 01/11] [libc++] Implement ranges::contains Differential

[clang-tools-extra] [libc++] Implement ranges::contains (PR #65148)

2023-09-20 Thread via cfe-commits
https://github.com/ZijunZhaoCCK updated https://github.com/llvm/llvm-project/pull/65148 >From 02e9afd761228f401df4d9f8dfaaca44ffae0c6e Mon Sep 17 00:00:00 2001 From: zijunzhao Date: Thu, 31 Aug 2023 20:08:32 + Subject: [PATCH 01/11] [libc++] Implement ranges::contains Differential

[clang] [libc++] Implement ranges::contains (PR #65148)

2023-09-20 Thread via cfe-commits
https://github.com/ZijunZhaoCCK updated https://github.com/llvm/llvm-project/pull/65148 >From 02e9afd761228f401df4d9f8dfaaca44ffae0c6e Mon Sep 17 00:00:00 2001 From: zijunzhao Date: Thu, 31 Aug 2023 20:08:32 + Subject: [PATCH 01/11] [libc++] Implement ranges::contains Differential

[clang] [Clang][Coroutines] Improve GRO handling to better fit scopes and cleanups (PR #66706)

2023-09-20 Thread Bruno Cardoso Lopes via cfe-commits
https://github.com/bcardosolopes updated https://github.com/llvm/llvm-project/pull/66706 >From 6312dd56ed3a2f47e7291ae32ca044622a317259 Mon Sep 17 00:00:00 2001 From: Bruno Cardoso Lopes Date: Wed, 20 Sep 2023 15:00:06 -0700 Subject: [PATCH] [Clang][LLVM][Coroutines] Prevent __coro_gro from

[clang] [Sema] Fix fixit cast printing inside macros (PR #66853)

2023-09-20 Thread Shoaib Meenai via cfe-commits
https://github.com/smeenai updated https://github.com/llvm/llvm-project/pull/66853 >From 701b1d99515e40eec8dcbaba3a0b2dc436bf9652 Mon Sep 17 00:00:00 2001 From: Shoaib Meenai Date: Tue, 19 Sep 2023 19:46:56 -0700 Subject: [PATCH] [Sema] Fix fixit cast printing inside macros

[clang-tools-extra] c03d184 - [clang] NFCI: Use `FileEntryRef` in `PreamblePatch`

2023-09-20 Thread Jan Svoboda via cfe-commits
Author: Jan Svoboda Date: 2023-09-20T16:10:18-07:00 New Revision: c03d18441c94a69c0b32a7882a66c8cc95c6e928 URL: https://github.com/llvm/llvm-project/commit/c03d18441c94a69c0b32a7882a66c8cc95c6e928 DIFF: https://github.com/llvm/llvm-project/commit/c03d18441c94a69c0b32a7882a66c8cc95c6e928.diff

[clang] [clang] Enable descriptions for --print-supported-extensions (PR #66715)

2023-09-20 Thread Balint Cristian via cfe-commits
https://github.com/cbalint13 updated https://github.com/llvm/llvm-project/pull/66715 >From 4d7d748be3f1d7db94094c00c9ae0d07ecaf6b7e Mon Sep 17 00:00:00 2001 From: Balint Cristian Date: Thu, 21 Sep 2023 01:46:13 +0300 Subject: [PATCH] [clang] Enable descriptions for --print-supported-extensions

[clang] [clang-format] Disable OuterScope lambda indentation behaviour for constructor initializers (PR #66755)

2023-09-20 Thread Owen Pan via cfe-commits
@@ -22537,10 +22537,12 @@ TEST_F(FormatTest, FormatsLambdas) { " }\n" "}", Style); - verifyFormat("std::sort(v.begin(), v.end(),\n" - " [](const auto , const auto ) {\n" - " return foo.baz <

[clang] [clang] Enable descriptions for --print-supported-extensions (PR #66715)

2023-09-20 Thread Balint Cristian via cfe-commits
https://github.com/cbalint13 edited https://github.com/llvm/llvm-project/pull/66715 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Enable descriptions for --print-supported-extensions (PR #66715)

2023-09-20 Thread Balint Cristian via cfe-commits
https://github.com/cbalint13 edited https://github.com/llvm/llvm-project/pull/66715 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Enable descriptions for --print-supported-extensions (PR #66715)

2023-09-20 Thread Balint Cristian via cfe-commits
https://github.com/cbalint13 unresolved https://github.com/llvm/llvm-project/pull/66715 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Enable descriptions for --print-supported-extensions (PR #66715)

2023-09-20 Thread Balint Cristian via cfe-commits
@@ -198,13 +199,20 @@ static int PrintSupportedExtensions(std::string TargetStr) { std::unique_ptr TheTargetMachine( TheTarget->createTargetMachine(TargetStr, "", "", Options, std::nullopt)); const llvm::Triple = TheTargetMachine->getTargetTriple(); + const

[PATCH] D138846: MC/DC in LLVM Source-Based Code Coverage: LLVM back-end and compiler-rt

2023-09-20 Thread Amy Huang via Phabricator via cfe-commits
akhuang added a comment. I'm still working on a repro, but after this patch we're seeing "truncated profile data" errors in chromium Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138846/new/ https://reviews.llvm.org/D138846

[clang] [clang] Enable descriptions for --print-supported-extensions (PR #66715)

2023-09-20 Thread Balint Cristian via cfe-commits
https://github.com/cbalint13 resolved https://github.com/llvm/llvm-project/pull/66715 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Enable descriptions for --print-supported-extensions (PR #66715)

2023-09-20 Thread Balint Cristian via cfe-commits
cbalint13 wrote: @DavidSpickett , Addressed all requests. * Here is the console output: [console-output.txt.gz](https://github.com/llvm/llvm-project/files/12677908/console-output.txt.gz) ``` $ zcat ~/console-output.txt.gz | grep 'print' $ ./bin/clang --target=arm-unknown-linux-gnu

[PATCH] D158561: [-Wunsafe-buffer-usage] Add AST info to the unclaimed DRE debug notes for analysis

2023-09-20 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. I like where this is going, and I appreciate the test! Tests for tiny debug utilities aren't critical for the compiler, but they're a great way to demonstrate and document how to invoke the script and how it's supposed to work. Comment at:

[clang] [clang] Enable descriptions for --print-supported-extensions (PR #66715)

2023-09-20 Thread Balint Cristian via cfe-commits
https://github.com/cbalint13 resolved https://github.com/llvm/llvm-project/pull/66715 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] -fsanitize=function: fix MSVC hashing to sugared type (PR #66816)

2023-09-20 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov updated https://github.com/llvm/llvm-project/pull/66816 >From 725a8b45144d6aaab71d282110619f5f843d527f Mon Sep 17 00:00:00 2001 From: Matheus Izvekov Date: Tue, 19 Sep 2023 21:50:39 +0200 Subject: [PATCH 1/3] -fsanitize=function: Add a MSVC test case ---

[clang] [clang] Enable descriptions for --print-supported-extensions (PR #66715)

2023-09-20 Thread Balint Cristian via cfe-commits
https://github.com/cbalint13 updated https://github.com/llvm/llvm-project/pull/66715 >From 707106f0a42f9682af5354aa46f28155471fd5f2 Mon Sep 17 00:00:00 2001 From: Balint Cristian Date: Thu, 21 Sep 2023 00:56:09 +0300 Subject: [PATCH] [clang] Enable descriptions for --print-supported-extensions

[clang] [IRPGO][ValueProfile] Instrument virtual table address that could be used to do virtual table address comparision for indirect-call-promotion. (PR #66825)

2023-09-20 Thread via cfe-commits
@@ -19,20 +19,38 @@ namespace llvm { // Visitor class that finds all indirect call. struct PGOIndirectCallVisitor : public InstVisitor { std::vector IndirectCalls; + std::vector VTableAddrs; PGOIndirectCallVisitor() = default; void visitCallBase(CallBase ) { if

[clang] 9ee65a7 - Revert "[Coverage] Fix -Wswitch after D138847"

2023-09-20 Thread Fangrui Song via cfe-commits
Author: Fangrui Song Date: 2023-09-20T14:45:19-07:00 New Revision: 9ee65a7618d29caccbadc52d60f9bfc2e6468907 URL: https://github.com/llvm/llvm-project/commit/9ee65a7618d29caccbadc52d60f9bfc2e6468907 DIFF: https://github.com/llvm/llvm-project/commit/9ee65a7618d29caccbadc52d60f9bfc2e6468907.diff

[clang] [clang][Sema] Fix crash introduced in b2cd9db589335d5885c04df83003a623cf2f05ff (PR #66954)

2023-09-20 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. https://github.com/llvm/llvm-project/pull/66954 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   3   4   5   >