[clang] [ORC] Implement basic reoptimization. (PR #67050)

2023-09-22 Thread via cfe-commits
@@ -0,0 +1,28 @@ +//=== RedirectionManager.cpp - Redirection manager interface in Orc ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang] [ORC] Implement basic reoptimization. (PR #67050)

2023-09-22 Thread via cfe-commits
@@ -0,0 +1,179 @@ +//===-- JITLinkRedirectableSymbolManager.cpp - JITLink redirection in Orc -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang] [ORC] Implement basic reoptimization. (PR #67050)

2023-09-22 Thread via cfe-commits
@@ -0,0 +1,179 @@ +//===-- JITLinkRedirectableSymbolManager.cpp - JITLink redirection in Orc -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang] [ORC] Implement basic reoptimization. (PR #67050)

2023-09-22 Thread via cfe-commits
https://github.com/lhames requested changes to this pull request. Just reviewing the `RedirectionManager` interface and implementation patch for now. I have some minor comments, but otherwise this is looking amazing -- thank you very much @sunho!

[clang] [ORC] Implement basic reoptimization. (PR #67050)

2023-09-22 Thread via cfe-commits
@@ -0,0 +1,179 @@ +//===-- JITLinkRedirectableSymbolManager.cpp - JITLink redirection in Orc -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang] [ORC] Implement basic reoptimization. (PR #67050)

2023-09-22 Thread via cfe-commits
@@ -0,0 +1,179 @@ +//===-- JITLinkRedirectableSymbolManager.cpp - JITLink redirection in Orc -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang] [ORC] Implement basic reoptimization. (PR #67050)

2023-09-22 Thread via cfe-commits
@@ -0,0 +1,102 @@ +//===- RedirectionManager.h - Redirection manager interface -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang] e5f169f - Revert "[ORC][LLJIT] Move enable-debugger-support utility out of LLJITBuilder."

2023-09-22 Thread Lang Hames via cfe-commits
Author: Lang Hames Date: 2023-09-22T21:43:41-07:00 New Revision: e5f169f91a86af3490d9251387b3f5455941bb83 URL: https://github.com/llvm/llvm-project/commit/e5f169f91a86af3490d9251387b3f5455941bb83 DIFF: https://github.com/llvm/llvm-project/commit/e5f169f91a86af3490d9251387b3f5455941bb83.diff

[clang] [clang-format][NFC] Clean up alignTrailingComments() (PR #67218)

2023-09-22 Thread Owen Pan via cfe-commits
https://github.com/owenca created https://github.com/llvm/llvm-project/pull/67218 None >From b00e6394bb1fe30be40e040b9201c4f3f1b28cd3 Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Fri, 22 Sep 2023 21:33:02 -0700 Subject: [PATCH] [clang-format][NFC] Clean up alignTrailingComments() ---

[clang] [Clang][RISCV] Handle RVV tuple types correctly as OutputOperands for inline asm (PR #67018)

2023-09-22 Thread Craig Topper via cfe-commits
topperc wrote: Does this mean the backend register allocation will pick a large LMUL register the same size as the whole tuple and force the register to be overly aligned? For example an lmul=1 seg2 tuple can use v0+v1, or v1+v2, or v2+v3, etc. But lmul=2 can only use v0+v1, v2+v3, v4+v5,

[clang] [clang][Interp] Handle CXXScalarValueInitExprs (PR #67147)

2023-09-22 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik commented: Looks good but I want more tests. https://github.com/llvm/llvm-project/pull/67147 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Handle CXXScalarValueInitExprs (PR #67147)

2023-09-22 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik edited https://github.com/llvm/llvm-project/pull/67147 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Handle CXXScalarValueInitExprs (PR #67147)

2023-09-22 Thread Shafik Yaghmour via cfe-commits
@@ -31,6 +31,13 @@ static_assert(b, ""); constexpr int one = true; static_assert(one == 1, ""); +constexpr bool b2 = bool(); shafik wrote: There are a lot of scalars: https://eel.is/c++draft/basic.types.general#9 Can we have a test for each case?

[clang] [clang] Turn -Wenum-constexpr-conversion into a hard error (PR #67170)

2023-09-22 Thread Shafik Yaghmour via cfe-commits
shafik wrote: This change is a lot more involved, this is on my list of things to do. See the discussion here: https://reviews.llvm.org/D150226 https://github.com/llvm/llvm-project/pull/67170 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [HIP] Support compressing device binary (PR #67162)

2023-09-22 Thread Yaxun Liu via cfe-commits
https://github.com/yxsamliu updated https://github.com/llvm/llvm-project/pull/67162 >From aa1aee8695a062c472dbb9efd1e87a2ba7cdc58b Mon Sep 17 00:00:00 2001 From: "Yaxun (Sam) Liu" Date: Thu, 21 Sep 2023 13:52:16 -0400 Subject: [PATCH] [HIP] Support compressing device binary Add option

[clang-tools-extra] [clangd] Show alignment for records and fields decls (PR #67213)

2023-09-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clangd Changes Shows align for records and fields declarations in hover information. Example: ```cpp struct A { char a; short b; }; ``` For this struct hover informations shows: ``` Size: 4 bytes Align: 2 bytes ```

[clang-tools-extra] [clangd] Show alignment for records and fields decls (PR #67213)

2023-09-22 Thread via cfe-commits
https://github.com/sr-tream created https://github.com/llvm/llvm-project/pull/67213 Shows align for records and fields declarations in hover information. Example: ```cpp struct A { char a; short b; }; ``` For this struct hover informations shows: ``` Size: 4 bytes Align: 2 bytes ```

[clang] Modify BoundsSan to improve debuggability (PR #65972)

2023-09-22 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka requested changes to this pull request. the code LGTM, but llvm-project/llvm/test/Instrumentation/BoundsChecking/ test is needed Maybe just extend llvm-project/llvm/test/Instrumentation/BoundsChecking/simple.ll https://github.com/llvm/llvm-project/pull/65972

[clang] Modify BoundsSan to improve debuggability (PR #65972)

2023-09-22 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka edited https://github.com/llvm/llvm-project/pull/65972 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Modify BoundsSan to improve debuggability (PR #65972)

2023-09-22 Thread Vitaly Buka via cfe-commits
@@ -0,0 +1,83 @@ +; RUN: llc -O3 -mtriple arm64-linux -filetype asm -o - %s | FileCheck %s -check-prefix CHECK-ASM +; What this test does is check that even with nomerge, the functions still get merged in +; compiled code as the ubsantrap call gets lowered to a single

[clang] Modify BoundsSan to improve debuggability (PR #65972)

2023-09-22 Thread Vitaly Buka via cfe-commits
@@ -180,19 +183,27 @@ static bool addBoundsChecking(Function , TargetLibraryInfo , // will create a fresh block every time it is called. BasicBlock *TrapBB = nullptr; auto GetTrapBB = [](BuilderTy ) { -if (TrapBB && SingleTrapBB) - return TrapBB; -

[clang] Recommit "Implement [[msvc::no_unique_address]] (#65675)" (PR #67199)

2023-09-22 Thread Richard Smith via cfe-commits
@@ -1798,11 +1798,24 @@ def ArmMveStrictPolymorphism : TypeAttr, TargetSpecificAttr { let Documentation = [ArmMveStrictPolymorphismDocs]; } -def NoUniqueAddress : InheritableAttr, TargetSpecificAttr { - let Spellings = [CXX11<"", "no_unique_address", 201803>]; +def

[PATCH] D147655: Implement mangling rules for C++20 concepts and requires-expressions.

2023-09-22 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added a comment. In D147655#4649864 , @dyung wrote: > Hi @rsmith, we have an internal test where your change seems to have changed > the mangling in C++17 mode and wanted to check if that was intentional. [...] > Are these changes in non-C++20

[clang] aaa79a5 - [release notes] Add forgotten case to list of changed manglings.

2023-09-22 Thread Richard Smith via cfe-commits
Author: Richard Smith Date: 2023-09-22T17:40:07-07:00 New Revision: aaa79a59317f859485d701d1eb68ac4cb213e1d1 URL: https://github.com/llvm/llvm-project/commit/aaa79a59317f859485d701d1eb68ac4cb213e1d1 DIFF: https://github.com/llvm/llvm-project/commit/aaa79a59317f859485d701d1eb68ac4cb213e1d1.diff

[clang] ce8c228 - Use llvm::drop_begin and llvm::drop_end (NFC)

2023-09-22 Thread Kazu Hirata via cfe-commits
Author: Kazu Hirata Date: 2023-09-22T17:29:10-07:00 New Revision: ce8c22856e3526ee7ab8ff037cdd7a7e1670c4a7 URL: https://github.com/llvm/llvm-project/commit/ce8c22856e3526ee7ab8ff037cdd7a7e1670c4a7 DIFF: https://github.com/llvm/llvm-project/commit/ce8c22856e3526ee7ab8ff037cdd7a7e1670c4a7.diff

[clang] 3bca659 - Use llvm::is_contained (NFC)

2023-09-22 Thread Kazu Hirata via cfe-commits
Author: Kazu Hirata Date: 2023-09-22T17:20:50-07:00 New Revision: 3bca65955668b478bcf2cac49f1731f20da8da9c URL: https://github.com/llvm/llvm-project/commit/3bca65955668b478bcf2cac49f1731f20da8da9c DIFF: https://github.com/llvm/llvm-project/commit/3bca65955668b478bcf2cac49f1731f20da8da9c.diff

[clang] [clang] Implement constexpr bit_cast for vectors (PR #66894)

2023-09-22 Thread Richard Smith via cfe-commits
@@ -7095,6 +7096,40 @@ class APValueToBufferConverter { return true; } + bool visitVector(const APValue , QualType Ty, CharUnits Offset) { +const auto *VT = Ty->castAs(); +unsigned VectorLength = Val.getVectorLength(); + +if (VT->isExtVectorBoolType()) { +

[clang] [analyzer] Fix crash in BasicValueFactory.cpp with __int128_t integers (PR #67212)

2023-09-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-static-analyzer-1 Changes This change avoids a crash in BasicValueFactory by checking the bit width of an APSInt to avoid calling getZExtValue if greater than 64-bits. This was caught by our internal, randomized test generator. Clang invocation

[clang] [analyzer] Fix crash in BasicValueFactory.cpp with __int128_t integers (PR #67212)

2023-09-22 Thread via cfe-commits
https://github.com/vabridgers created https://github.com/llvm/llvm-project/pull/67212 This change avoids a crash in BasicValueFactory by checking the bit width of an APSInt to avoid calling getZExtValue if greater than 64-bits. This was caught by our internal, randomized test generator.

[clang] [compiler-rt] Implement __extendxftf2 for x86_64 (PR #66918)

2023-09-22 Thread Alexander Shaposhnikov via cfe-commits
https://github.com/alexander-shaposhnikov updated https://github.com/llvm/llvm-project/pull/66918 >From 84cb5de329c228702da9f864312df31dc00692dc Mon Sep 17 00:00:00 2001 From: Alexander Shaposhnikov Date: Wed, 20 Sep 2023 14:25:46 + Subject: [PATCH] Implement __extendxftf2 for x86_64 ---

[clang-tools-extra] [compiler-rt] Implement __extendxftf2 for x86_64 (PR #66918)

2023-09-22 Thread Alexander Shaposhnikov via cfe-commits
https://github.com/alexander-shaposhnikov updated https://github.com/llvm/llvm-project/pull/66918 >From 84cb5de329c228702da9f864312df31dc00692dc Mon Sep 17 00:00:00 2001 From: Alexander Shaposhnikov Date: Wed, 20 Sep 2023 14:25:46 + Subject: [PATCH] Implement __extendxftf2 for x86_64 ---

[clang] [Driver] Move assertion check before checking Output.isFilename (PR #67210)

2023-09-22 Thread Brad Smith via cfe-commits
https://github.com/brad0 created https://github.com/llvm/llvm-project/pull/67210 None >From 39053d20aeec2fea1d0ef14bd9dde6a3454f83a7 Mon Sep 17 00:00:00 2001 From: Brad Smith Date: Fri, 22 Sep 2023 19:35:21 -0400 Subject: [PATCH] [Driver] Move assertion check before checking Output.isFilename

[libunwind] [libunwind] Pass -Wl,--export-dynamic on all supported platforms (PR #67205)

2023-09-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-libunwind Changes I was trying to run the tests on FreeBSD and noticed that we weren't printing symbol names. It turns out this is because of the missing -Wl,--export dynamic flag. Instead of hardcoding the name of the flag and only passing it for

[libunwind] [libunwind] Pass -Wl,--export-dynamic on all supported platforms (PR #67205)

2023-09-22 Thread Alexander Richardson via cfe-commits
https://github.com/arichardson created https://github.com/llvm/llvm-project/pull/67205 I was trying to run the tests on FreeBSD and noticed that we weren't printing symbol names. It turns out this is because of the missing -Wl,--export dynamic flag. Instead of hardcoding the name of the flag

[clang] e1a5bb5 - [ORC][LLJIT] Move enable-debugger-support utility out of LLJITBuilder.

2023-09-22 Thread Lang Hames via cfe-commits
Author: Lang Hames Date: 2023-09-22T16:18:20-07:00 New Revision: e1a5bb59b91d60c0d87feb78f0e0614589a4c927 URL: https://github.com/llvm/llvm-project/commit/e1a5bb59b91d60c0d87feb78f0e0614589a4c927 DIFF: https://github.com/llvm/llvm-project/commit/e1a5bb59b91d60c0d87feb78f0e0614589a4c927.diff

[libunwind] ab78962 - [libunwind] Relax a REQUIRES on a test that passes on FreeBSD

2023-09-22 Thread Alex Richardson via cfe-commits
Author: Alex Richardson Date: 2023-09-22T16:16:16-07:00 New Revision: ab7896231e176e52801702b7221bcac2f4ffbd59 URL: https://github.com/llvm/llvm-project/commit/ab7896231e176e52801702b7221bcac2f4ffbd59 DIFF:

[clang] [clang][modules] Move `SLocEntry` search into `ASTReader` (PR #66966)

2023-09-22 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 ready_for_review https://github.com/llvm/llvm-project/pull/66966 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][modules] Move `SLocEntry` search into `ASTReader` (PR #66966)

2023-09-22 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 edited https://github.com/llvm/llvm-project/pull/66966 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [libunwind][libc++][libc++abi] Add cross-compilation flags to tests (PR #67201)

2023-09-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-libunwind Changes There is currently only limited support for passing target-specific flags (e.g. -mabi= or -march=) to the testsuites if you don't have a compiler (or wrapper script) that defaults to the expected flags. However, some targets (e.g.

[libunwind] [libunwind][libc++][libc++abi] Add cross-compilation flags to tests (PR #67201)

2023-09-22 Thread Alexander Richardson via cfe-commits
https://github.com/arichardson created https://github.com/llvm/llvm-project/pull/67201 There is currently only limited support for passing target-specific flags (e.g. -mabi= or -march=) to the testsuites if you don't have a compiler (or wrapper script) that defaults to the expected flags.

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

2023-09-22 Thread Prabhu Karthikeyan Rajasekaran via Phabricator via cfe-commits
Prabhuk updated this revision to Diff 557263. Prabhuk added a comment. Updated the test name and added comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152206/new/ https://reviews.llvm.org/D152206 Files: llvm/lib/IR/DataLayout.cpp

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

2023-09-22 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay accepted this revision. MaskRay added inline comments. Comment at: llvm/unittests/IR/DataLayoutTest.cpp:108 +TEST(DataLayoutTest, TargetTripleManglingComponent) { + Triple TT = Triple("x86_64-unknown-uefi"); UEFI may be a better name in case we test

[clang] [Driver] Implement ToolChain on Haiku (PR #66038)

2023-09-22 Thread Brad Smith via cfe-commits
https://github.com/brad0 closed https://github.com/llvm/llvm-project/pull/66038 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 8ea7430 - [Driver] Implement ToolChain on Haiku (#66038)

2023-09-22 Thread via cfe-commits
Author: Brad Smith Date: 2023-09-22T18:17:44-04:00 New Revision: 8ea74302007465e4e824d420b103c2d23bd5838b URL: https://github.com/llvm/llvm-project/commit/8ea74302007465e4e824d420b103c2d23bd5838b DIFF: https://github.com/llvm/llvm-project/commit/8ea74302007465e4e824d420b103c2d23bd5838b.diff

[clang] [clang][modules] Move `SLocEntry` search into `ASTReader` (PR #66966)

2023-09-22 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 edited https://github.com/llvm/llvm-project/pull/66966 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][modules] Move `SLocEntry` search into `ASTReader` (PR #66966)

2023-09-22 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 updated https://github.com/llvm/llvm-project/pull/66966 >From 4edf9d8559339a12108d9c4d1e2f3bb062a5a768 Mon Sep 17 00:00:00 2001 From: Jan Svoboda Date: Wed, 20 Sep 2023 17:30:45 -0700 Subject: [PATCH 1/5] [clang][modules] Move `SLocEntry` search into `ASTReader`

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

2023-09-22 Thread Prabhu Karthikeyan Rajasekaran via Phabricator via cfe-commits
Prabhuk updated this revision to Diff 557261. Prabhuk added a comment. Add DataLayoutTest for UEFI target. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152206/new/ https://reviews.llvm.org/D152206 Files: llvm/lib/IR/DataLayout.cpp

[clang] Recommit "Implement [[msvc::no_unique_address]] (#65675)" (PR #67199)

2023-09-22 Thread Amy Huang via cfe-commits
amykhuang wrote: Previous commit attempt caused sphinx errors. Also, because we now have two attributes for the itanium and MSVC versions, there are two separate sections in the documentation, which I didn't realize before. https://github.com/llvm/llvm-project/pull/67199

[clang] Recommit "Implement [[msvc::no_unique_address]] (#65675)" (PR #67199)

2023-09-22 Thread Amy Huang via cfe-commits
https://github.com/amykhuang edited https://github.com/llvm/llvm-project/pull/67199 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Recommit "Implement [[msvc::no_unique_address]] (#65675)" (PR #67199)

2023-09-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Changes Change the attribute docs so that there is a separate one for the MSVC attribute. This reverts commit 71f9e7695b87298f9855d8890f0e6a3b89381eb5. --- Patch is 25.37 KiB, truncated to 20.00 KiB below, full version:

[clang] Recommit "Implement [[msvc::no_unique_address]] (#65675)" (PR #67199)

2023-09-22 Thread Amy Huang via cfe-commits
https://github.com/amykhuang created https://github.com/llvm/llvm-project/pull/67199 Change the attribute docs so that there is a separate one for the MSVC attribute. This reverts commit 71f9e7695b87298f9855d8890f0e6a3b89381eb5. >From b1f0feeaed93edfdd692858e9d63ab6bbb94c0a5 Mon Sep 17

[clang] [NVPTX] Add support for maxclusterrank in launch_bounds (PR #66496)

2023-09-22 Thread Artem Belevich via cfe-commits
@@ -537,59 +537,46 @@ void NVPTXAsmPrinter::emitKernelFunctionDirectives(const Function , raw_ostream ) const { // If the NVVM IR has some of reqntid* specified, then output // the reqntid directive, and set the

[clang] Revert "Implement [[msvc::no_unique_address]] (#65675)" (PR #67198)

2023-09-22 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 9779a731a65fd8daee4d0a4b6945e882263b062e 159cc6b5d3cea0c4b51bd5dac7728a3cfa379f28 --

[clang] Revert "Implement [[msvc::no_unique_address]] (#65675)" (PR #67198)

2023-09-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Changes This reverts commit 4a55d426967b9c70f5dea7b3a389e11393a4f4c4. Reverting because this breaks sphinx documentation, and even with it fixed the format of the attribute makes the no_unique_address documentation show up twice. --- Patch is

[clang] 71f9e76 - Revert "Implement [[msvc::no_unique_address]] (#65675)" (#67198)

2023-09-22 Thread via cfe-commits
Author: Amy Huang Date: 2023-09-22T14:39:00-07:00 New Revision: 71f9e7695b87298f9855d8890f0e6a3b89381eb5 URL: https://github.com/llvm/llvm-project/commit/71f9e7695b87298f9855d8890f0e6a3b89381eb5 DIFF: https://github.com/llvm/llvm-project/commit/71f9e7695b87298f9855d8890f0e6a3b89381eb5.diff

[clang] Revert "Implement [[msvc::no_unique_address]] (#65675)" (PR #67198)

2023-09-22 Thread Amy Huang via cfe-commits
https://github.com/amykhuang closed https://github.com/llvm/llvm-project/pull/67198 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Revert "Implement [[msvc::no_unique_address]] (#65675)" (PR #67198)

2023-09-22 Thread Amy Huang via cfe-commits
https://github.com/amykhuang created https://github.com/llvm/llvm-project/pull/67198 This reverts commit 4a55d426967b9c70f5dea7b3a389e11393a4f4c4. Reverting because this breaks sphinx documentation, and even with it fixed the format of the attribute makes the no_unique_address documentation

[PATCH] D145214: [TSAN] add support for riscv64

2023-09-22 Thread Aditya Kumar via Phabricator via cfe-commits
hiraditya accepted this revision. hiraditya added a comment. This revision is now accepted and ready to land. I tested it on a licheepi board (riscv64 debian) and all the tests passed. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145214/new/

[clang] [clang] Predefined macros for float128 support (PR #67196)

2023-09-22 Thread Pranav Kant via cfe-commits
https://github.com/pranavk updated https://github.com/llvm/llvm-project/pull/67196 >From 8c07729b195fa78133258b03a31e8668d70a922d Mon Sep 17 00:00:00 2001 From: Pranav Kant Date: Fri, 22 Sep 2023 20:50:32 + Subject: [PATCH 1/2] [clang] Predefined macros for float128 support ---

[clang] Implement [[msvc::no_unique_address]] (PR #65675)

2023-09-22 Thread Fangrui Song via cfe-commits
MaskRay wrote: The supposed doc fix (for `doc-clang-html`?) #67195 caused `error: Record `NoUniqueAddress', field `Documentation' exists but does not have a list value`. I have reverted #67195. https://github.com/llvm/llvm-project/pull/65675 ___

[clang] 2d27bf2 - Revert "Fix attr docs from previous no-unique-adderss change (#67195)"

2023-09-22 Thread Fangrui Song via cfe-commits
Author: Fangrui Song Date: 2023-09-22T14:04:16-07:00 New Revision: 2d27bf23369561e68456025aa24cb46fee130482 URL: https://github.com/llvm/llvm-project/commit/2d27bf23369561e68456025aa24cb46fee130482 DIFF: https://github.com/llvm/llvm-project/commit/2d27bf23369561e68456025aa24cb46fee130482.diff

[clang] [clang] Predefined macros for float128 support (PR #67196)

2023-09-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Changes Expose some predefined macros for Float128 support. --- Full diff: https://github.com/llvm/llvm-project/pull/67196.diff 1 Files Affected: - (modified) clang/lib/Frontend/InitPreprocessor.cpp (+2) ``diff diff --git

[clang] [clang] Predefined macros for float128 support (PR #67196)

2023-09-22 Thread Pranav Kant via cfe-commits
https://github.com/pranavk edited https://github.com/llvm/llvm-project/pull/67196 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Predefined macros for float128 support (PR #67196)

2023-09-22 Thread Pranav Kant via cfe-commits
https://github.com/pranavk created https://github.com/llvm/llvm-project/pull/67196 None >From 8c07729b195fa78133258b03a31e8668d70a922d Mon Sep 17 00:00:00 2001 From: Pranav Kant Date: Fri, 22 Sep 2023 20:50:32 + Subject: [PATCH] [clang] Predefined macros for float128 support ---

[clang] Fix attr docs from previous no-unique-adderss change (PR #67195)

2023-09-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Changes Previous change in https://github.com/llvm/llvm-project/pull/65675 broke the docs generation. --- Full diff: https://github.com/llvm/llvm-project/pull/67195.diff 1 Files Affected: - (modified) clang/include/clang/Basic/Attr.td (-1)

[clang] Fix attr docs from previous no-unique-adderss change (PR #67195)

2023-09-22 Thread Amy Huang via cfe-commits
https://github.com/amykhuang closed https://github.com/llvm/llvm-project/pull/67195 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 44f2db7 - Fix attr docs from previous no-unique-adderss change (#67195)

2023-09-22 Thread via cfe-commits
Author: Amy Huang Date: 2023-09-22T13:55:48-07:00 New Revision: 44f2db7493454b41d2f5c81b76bd30f2f035ed31 URL: https://github.com/llvm/llvm-project/commit/44f2db7493454b41d2f5c81b76bd30f2f035ed31 DIFF: https://github.com/llvm/llvm-project/commit/44f2db7493454b41d2f5c81b76bd30f2f035ed31.diff

[clang] Fix attr docs from previous no-unique-adderss change (PR #67195)

2023-09-22 Thread Amy Huang via cfe-commits
https://github.com/amykhuang edited https://github.com/llvm/llvm-project/pull/67195 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix attr docs from previous no-unique-adderss change (PR #67195)

2023-09-22 Thread Amy Huang via cfe-commits
https://github.com/amykhuang created https://github.com/llvm/llvm-project/pull/67195 None >From d5347c906ac7db40f9b31ad0c0bcd193df453e4e Mon Sep 17 00:00:00 2001 From: Amy Huang Date: Fri, 22 Sep 2023 13:54:28 -0700 Subject: [PATCH] Fix attr docs from previous no-unique-adderss change ---

[clang] [NVPTX] Add support for maxclusterrank in launch_bounds (PR #66496)

2023-09-22 Thread Artem Belevich via cfe-commits
@@ -537,59 +537,46 @@ void NVPTXAsmPrinter::emitKernelFunctionDirectives(const Function , raw_ostream ) const { // If the NVVM IR has some of reqntid* specified, then output // the reqntid directive, and set the

[clang] [NVPTX] Add support for maxclusterrank in launch_bounds (PR #66496)

2023-09-22 Thread Artem Belevich via cfe-commits
@@ -5607,6 +5607,21 @@ bool Sema::CheckRegparmAttr(const ParsedAttr , unsigned ) { return false; } +// Helper to get CudaArch. +static CudaArch getCudaArch(const TargetInfo ) { Artem-B wrote: You may need to verify that `TI->getTriple()->isNVPTX()` before

[clang] [clang][Interp] Handle CXXScalarValueInitExprs (PR #67147)

2023-09-22 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr resolved https://github.com/llvm/llvm-project/pull/67147 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [InstCombine] Add combines/simplifications for `llvm.ptrmask` (PR #67166)

2023-09-22 Thread via cfe-commits
https://github.com/goldsteinn updated https://github.com/llvm/llvm-project/pull/67166 >From 3982b40f82c6cb91c9bec407cea6b7a4cdc4220e Mon Sep 17 00:00:00 2001 From: Noah Goldstein Date: Fri, 22 Sep 2023 08:21:21 -0500 Subject: [PATCH 1/9] [InstSimplify] Add tests for simplify `llvm.ptrmask`;

[clang] [clang][Interp] Handle CXXScalarValueInitExprs (PR #67147)

2023-09-22 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/67147 >From aaf450faf7a26bb60de14b81fe7a661adb830273 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Fri, 22 Sep 2023 16:27:11 +0200 Subject: [PATCH] [clang][Interp] Handle CXXScalarValueInitExprs

[clang] [NVPTX] Add support for maxclusterrank in launch_bounds (PR #66496)

2023-09-22 Thread Artem Belevich via cfe-commits
https://github.com/Artem-B resolved https://github.com/llvm/llvm-project/pull/66496 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NVPTX] Add support for maxclusterrank in launch_bounds (PR #66496)

2023-09-22 Thread Artem Belevich via cfe-commits
https://github.com/Artem-B resolved https://github.com/llvm/llvm-project/pull/66496 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Fix detection of libc++ with empty sysroot. (PR #66947)

2023-09-22 Thread Sam McCall via cfe-commits
https://github.com/sam-mccall closed https://github.com/llvm/llvm-project/pull/66947 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 7ca8c21 - [Driver] Fix detection of libc++ with empty sysroot. (#66947)

2023-09-22 Thread via cfe-commits
Author: Sam McCall Date: 2023-09-22T22:29:25+02:00 New Revision: 7ca8c21af36acb117529e797b3d36e85a286ca47 URL: https://github.com/llvm/llvm-project/commit/7ca8c21af36acb117529e797b3d36e85a286ca47 DIFF: https://github.com/llvm/llvm-project/commit/7ca8c21af36acb117529e797b3d36e85a286ca47.diff

[clang] Implement [[msvc::no_unique_address]] (PR #65675)

2023-09-22 Thread Amy Huang via cfe-commits
https://github.com/amykhuang closed https://github.com/llvm/llvm-project/pull/65675 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 4a55d42 - Implement [[msvc::no_unique_address]] (#65675)

2023-09-22 Thread via cfe-commits
Author: Amy Huang Date: 2023-09-22T13:28:38-07:00 New Revision: 4a55d426967b9c70f5dea7b3a389e11393a4f4c4 URL: https://github.com/llvm/llvm-project/commit/4a55d426967b9c70f5dea7b3a389e11393a4f4c4 DIFF: https://github.com/llvm/llvm-project/commit/4a55d426967b9c70f5dea7b3a389e11393a4f4c4.diff

[clang] [Driver] Fix detection of libc++ with empty sysroot. (PR #66947)

2023-09-22 Thread Shoaib Meenai via cfe-commits
@@ -316,6 +318,52 @@ TEST(ToolChainTest, VFSSolarisMultiGCCInstallation) { } } +MATCHER_P(jobHasArgs, Substr, "") { + const driver::Command = arg; + std::string Args = ""; + llvm::ListSeparator Sep(" "); + for (const char *Arg : C.getArguments()) { +Args += Sep; +

[clang] [Driver] Fix detection of libc++ with empty sysroot. (PR #66947)

2023-09-22 Thread Shoaib Meenai via cfe-commits
https://github.com/smeenai resolved https://github.com/llvm/llvm-project/pull/66947 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [InstCombine] Add combines/simplifications for `llvm.ptrmask` (PR #67166)

2023-09-22 Thread Florian Hahn via cfe-commits
@@ -183,8 +183,7 @@ define <16 x i8> @ptrmask_align8_ptr_align1(ptr align 1 %ptr) { ; TODO: Should be able to drop the ptrmask fhahn wrote: remove TODO now? https://github.com/llvm/llvm-project/pull/67166 ___

[clang] [InstCombine] Add combines/simplifications for `llvm.ptrmask` (PR #67166)

2023-09-22 Thread Florian Hahn via cfe-commits
@@ -196,8 +195,7 @@ define <16 x i8> @ptrmask_align8_ptr_align8(ptr align 8 %ptr) { ; TODO: Should be able to drop the ptrmask fhahn wrote: remove TODO now https://github.com/llvm/llvm-project/pull/67166 ___

[PATCH] D153485: [dataflow] use true/false literals in formulas, rather than variables

2023-09-22 Thread Vlad Vereschaka via Phabricator via cfe-commits
vvereschaka added a comment. Hi @sammccall, also failed `FAIL: Clang-Unit::69` test on these builders - https://lab.llvm.org/buildbot/#/builders/86/builds/65581 - https://lab.llvm.org/buildbot/#/builders/60/builds/14027 - https://lab.llvm.org/buildbot/#/builders/119/builds/15226 Repository:

[clang] [InstCombine] Add combines/simplifications for `llvm.ptrmask` (PR #67166)

2023-09-22 Thread via cfe-commits
https://github.com/goldsteinn edited https://github.com/llvm/llvm-project/pull/67166 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Add combines/simplifications for `llvm.ptrmask` (PR #67166)

2023-09-22 Thread via cfe-commits
https://github.com/goldsteinn updated https://github.com/llvm/llvm-project/pull/67166 >From 3982b40f82c6cb91c9bec407cea6b7a4cdc4220e Mon Sep 17 00:00:00 2001 From: Noah Goldstein Date: Fri, 22 Sep 2023 08:21:21 -0500 Subject: [PATCH 1/9] [InstSimplify] Add tests for simplify `llvm.ptrmask`;

[clang] [libc] Refactor scanf reader to match printf (PR #66023)

2023-09-22 Thread via cfe-commits
https://github.com/michaelrj-google resolved https://github.com/llvm/llvm-project/pull/66023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [libc] Refactor scanf reader to match printf (PR #66023)

2023-09-22 Thread via cfe-commits
https://github.com/michaelrj-google resolved https://github.com/llvm/llvm-project/pull/66023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libc] Refactor scanf reader to match printf (PR #66023)

2023-09-22 Thread via cfe-commits
https://github.com/michaelrj-google resolved https://github.com/llvm/llvm-project/pull/66023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [libc] Refactor scanf reader to match printf (PR #66023)

2023-09-22 Thread via cfe-commits
https://github.com/michaelrj-google resolved https://github.com/llvm/llvm-project/pull/66023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libc] Refactor scanf reader to match printf (PR #66023)

2023-09-22 Thread via cfe-commits
https://github.com/michaelrj-google resolved https://github.com/llvm/llvm-project/pull/66023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [libc] Refactor scanf reader to match printf (PR #66023)

2023-09-22 Thread via cfe-commits
https://github.com/michaelrj-google resolved https://github.com/llvm/llvm-project/pull/66023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [libc] Refactor scanf reader to match printf (PR #66023)

2023-09-22 Thread via cfe-commits
https://github.com/michaelrj-google resolved https://github.com/llvm/llvm-project/pull/66023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libc] Refactor scanf reader to match printf (PR #66023)

2023-09-22 Thread via cfe-commits
https://github.com/michaelrj-google resolved https://github.com/llvm/llvm-project/pull/66023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libc] Refactor scanf reader to match printf (PR #66023)

2023-09-22 Thread via cfe-commits
https://github.com/michaelrj-google resolved https://github.com/llvm/llvm-project/pull/66023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [libc] Refactor scanf reader to match printf (PR #66023)

2023-09-22 Thread via cfe-commits
https://github.com/michaelrj-google resolved https://github.com/llvm/llvm-project/pull/66023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libc++] Prevent calling the projection more than three times (PR #66315)

2023-09-22 Thread Jocelyn Castellano via cfe-commits
pandaninjas wrote: It seems like tests are still failing because there is a double move. https://github.com/llvm/llvm-project/pull/66315 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] [libc++] Prevent calling the projection more than three times (PR #66315)

2023-09-22 Thread Jocelyn Castellano via cfe-commits
pandaninjas wrote: It seems like tests are still failing because there is a double move. https://github.com/llvm/llvm-project/pull/66315 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [Driver] Fix detection of libc++ with empty sysroot. (PR #66947)

2023-09-22 Thread Sam McCall via cfe-commits
@@ -316,6 +318,52 @@ TEST(ToolChainTest, VFSSolarisMultiGCCInstallation) { } } +MATCHER_P(jobHasArgs, Substr, "") { + const driver::Command = arg; + std::string Args = ""; + llvm::ListSeparator Sep(" "); + for (const char *Arg : C.getArguments()) { +Args += Sep; +

  1   2   3   >