https://github.com/phyBrackets edited
https://github.com/llvm/llvm-project/pull/67232
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/phyBrackets commented:
Tested locally, LGTM!
https://github.com/llvm/llvm-project/pull/67232
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff e057d8973cc6a9d0bcc5cc385f318a607d117693
c5779c1142936db45c1d0e2046ee5015a7d02fe9 --
https://github.com/orcguru resolved
https://github.com/llvm/llvm-project/pull/66316
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -10,8 +10,10 @@ link_flags = []
if @LIBUNWIND_ENABLE_CET@:
compile_flags.append('-fcf-protection=full')
-if '@CMAKE_SYSTEM_NAME@' == 'Linux':
-link_flags.append('-Wl,--export-dynamic')
+# Add -Wl,--export-dynamic if supported by the linker (this CMake variable will
https://github.com/brad0 updated https://github.com/llvm/llvm-project/pull/67222
>From 3ae9d2d3d6e0683764c3bcbbe158b968aab4ace5 Mon Sep 17 00:00:00 2001
From: Brad Smith
Date: Sat, 23 Sep 2023 03:22:18 -0400
Subject: [PATCH] [Driver] Hook up Haiku ARM support
---
clang/lib/Basic/Targets.cpp
@@ -0,0 +1,83 @@
+//===- IRPartitionLayer.h - Partition IR module on lookup ---*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
llvmbot wrote:
@llvm/pr-subscribers-clang
Changes
The entry point symbol handling matches our GCC link spec..
```%{!shared:%{!nostdlib:%{!r:%{!e*:-e __start```
Came up in discussion here https://github.com/llvm/llvm-project/pull/65644
---
Full diff:
https://github.com/brad0 created https://github.com/llvm/llvm-project/pull/67254
The entry point symbol handling matches our GCC link spec..
```%{!shared:%{!nostdlib:%{!r:%{!e*:-e __start```
Came up in discussion here https://github.com/llvm/llvm-project/pull/65644
>From
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 186a4b3b657878ae2aea23caf684b6e103901162
4e3adab12b509610d81502bb640accbaea39b9f9 --
https://github.com/sunho closed https://github.com/llvm/llvm-project/pull/67253
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sunho wrote:
Oh mistake
https://github.com/llvm/llvm-project/pull/67253
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-libunwind
Changes
Avoid following prototype related warning.
Unwind-sjlj.c:85:75: warning: a function declaration without a prototype is
deprecated in all versions of C [-Wstrict-prototypes]
---
Full diff:
aeubanks wrote:
> Ok. We should change the default to a non zero value to match gcc, too, but
> that can be a follow-up.
Yes, I was planning on sending out an RFC for this
https://github.com/llvm/llvm-project/pull/66839
___
cfe-commits mailing list
https://github.com/kaz7 created https://github.com/llvm/llvm-project/pull/67250
Avoid following prototype related warning.
Unwind-sjlj.c:85:75: warning: a function declaration without a prototype is
deprecated in all versions of C [-Wstrict-prototypes]
>From
jaredgrubb added a comment.
@MyDeveloperDay addressed your comments. Thanks!
Would love to get this in before Phabricator closes. Anything else I can do to
help?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150083/new/
https://reviews.llvm.org/D150083
jaredgrubb updated this revision to Diff 557275.
jaredgrubb added a comment.
Rebased and adjusted docs to reflect that this patch would appear in
clang-format 18 (not 17 now).
Removed extraneous comment change (will do NFC later for that)
Removed other build-system changes (as requested).
jaredgrubb marked an inline comment as done.
jaredgrubb added inline comments.
Comment at: clang/unittests/Format/FormatTestObjC.cpp:1619
+ // Reflow after first macro.
+ // FIXME: these should indent but don't.
+ verifyFormat("- (id)init ATTRIBUTE_MACRO(X)\n"
jaredgrubb updated this revision to Diff 557274.
jaredgrubb added a comment.
Hopefully this will satisfy and we can merge! I didn't notice the Phabricator
timeline and I'm hoping we can finish this before Oct 1.
Rebased.
Removed extraneous doc comment not related to patch (as requested).
https://github.com/owenca approved this pull request.
LGTM, but please wait for @mydeveloperday.
https://github.com/llvm/llvm-project/pull/66755
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/owenca resolved
https://github.com/llvm/llvm-project/pull/66755
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca resolved
https://github.com/llvm/llvm-project/pull/66755
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca resolved
https://github.com/llvm/llvm-project/pull/66755
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Kazu Hirata
Date: 2023-09-23T13:30:16-07:00
New Revision: f435f55d58542ecde0e66460555ccbcbca355cc5
URL:
https://github.com/llvm/llvm-project/commit/f435f55d58542ecde0e66460555ccbcbca355cc5
DIFF:
https://github.com/llvm/llvm-project/commit/f435f55d58542ecde0e66460555ccbcbca355cc5.diff
https://github.com/huixie90 edited
https://github.com/llvm/llvm-project/pull/66963
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/huixie90 edited
https://github.com/llvm/llvm-project/pull/66963
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,145 @@
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
https://github.com/huixie90 edited
https://github.com/llvm/llvm-project/pull/66963
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,145 @@
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
@@ -0,0 +1,145 @@
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
@@ -0,0 +1,145 @@
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
@@ -0,0 +1,145 @@
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
@@ -0,0 +1,145 @@
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
@@ -0,0 +1,145 @@
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
https://github.com/huixie90 edited
https://github.com/llvm/llvm-project/pull/66963
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Timm =?utf-8?q?Bäder?=
Message-ID:
In-Reply-To:
https://github.com/shafik edited https://github.com/llvm/llvm-project/pull/67147
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Timm =?utf-8?q?B=C3=A4der?=
Message-ID:
In-Reply-To:
https://github.com/shafik commented:
Thank you for the additions, almost there :-)
https://github.com/llvm/llvm-project/pull/67147
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Timm =?utf-8?q?B=C3=A4der?=
Message-ID:
In-Reply-To:
@@ -31,6 +31,28 @@ static_assert(b, "");
constexpr int one = true;
static_assert(one == 1, "");
+constexpr bool b2 = bool();
+static_assert(!b2, "");
+
+namespace ScalarTypes {
+ constexpr int ScalarInitInt = int();
+
https://github.com/jyknight approved this pull request.
Ok. We should change the default to a non zero value to match gcc, too, but
that can be a follow-up.
https://github.com/llvm/llvm-project/pull/66839
___
cfe-commits mailing list
AlexYzhov added a comment.
Add command without backend wrapper destroys the compatibility to different
linkers.
Some people will use gcc driver instead of ld/lld itself as linker, a "-Wl,"
prefix is needed in this situation.
i've met familiar issue that corrupts the link step:
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff b8b4ee6b450766796b162b4811a6b3f723d07268
d07486764071679c8cbcd5e7c4905eb41b4770b3 --
llvmbot wrote:
@llvm/pr-subscribers-mlir-llvm
Changes
I think this is very helpful for reading generated `.inc` files.
---
Patch is 31.85 KiB, truncated to 20.00 KiB below, full version:
https://github.com/llvm/llvm-project/pull/65744.diff
22 Files Affected:
- (modified)
https://github.com/sunshaoce updated
https://github.com/llvm/llvm-project/pull/65744
>From 23d0b738bf40ea44e159f4f8d7355d4d6bc0688d Mon Sep 17 00:00:00 2001
From: Shao-Ce SUN
Date: Sat, 23 Sep 2023 11:38:33 +0800
Subject: [PATCH 1/2] [llvm][tblgen] Add `SourcePath` for
`emitSourceFileHeader`
RIscRIpt updated this revision to Diff 557270.
RIscRIpt added a comment.
Rebase onto main. Run lit clang/test. Bump.
Any chance we continue the review? I know it looked stale for a while I
couldn't address review comments, but now I have time to work at this patch.
Repository:
rG LLVM
eopXD wrote:
> Does this mean the backend register allocation will pick a large LMUL
> register the same size as the whole tuple and force the register to be overly
> aligned? For example an lmul=1 seg2 tuple can use v0+v1, or v1+v2, or v2+v3,
> etc. But lmul=2 can only use v0+v1, v2+v3,
Author: Timm Bäder
Date: 2023-09-23T16:11:57+02:00
New Revision: f1128f3782363ca26e0bdf9323a0d16570dcfba0
URL:
https://github.com/llvm/llvm-project/commit/f1128f3782363ca26e0bdf9323a0d16570dcfba0
DIFF:
https://github.com/llvm/llvm-project/commit/f1128f3782363ca26e0bdf9323a0d16570dcfba0.diff
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG2641d9b2807d: Propagate the volatile qualifier of exp to
store /load operations . (authored by umesh.kalappa0, committed by long5hot).
Herald
Author: Umesh Kalappa
Date: 2023-09-23T19:40:24+05:30
New Revision: 2641d9b2807ded4b712f4dca809d63c138c91361
URL:
https://github.com/llvm/llvm-project/commit/2641d9b2807ded4b712f4dca809d63c138c91361
DIFF:
https://github.com/llvm/llvm-project/commit/2641d9b2807ded4b712f4dca809d63c138c91361.diff
Author: Timm Bäder
Date: 2023-09-23T14:15:40+02:00
New Revision: d437e68b5b5a1f0291a0eaa72a07712e7aaccd10
URL:
https://github.com/llvm/llvm-project/commit/d437e68b5b5a1f0291a0eaa72a07712e7aaccd10
DIFF:
https://github.com/llvm/llvm-project/commit/d437e68b5b5a1f0291a0eaa72a07712e7aaccd10.diff
https://github.com/tbaederr created
https://github.com/llvm/llvm-project/pull/67232
None
>From ed30d89a3c8f0ec5296561e128b2af8b05ade5ca Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Timm=20B=C3=A4der?=
Date: Fri, 22 Sep 2023 21:26:51 +0200
Subject: [PATCH] [clang][Interp] Fix compiling undefined
Timm =?utf-8?q?Bäder?=
Message-ID:
In-Reply-To:
https://github.com/tbaederr updated
https://github.com/llvm/llvm-project/pull/67147
>From 9c0cc7fde8473c9b02733720149343c4b2dcddae Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Timm=20B=C3=A4der?=
Date: Sat, 23 Sep 2023 11:41:52 +0200
Subject:
sr-tream wrote:
> I'm not an expert on ABI
I too. I use exists function `ASTContext::getTypeAlign` - it must work
correctly, if other functions like `ASTContext::getTypeSizeInCharsIfKnown`
return correct results, because `ASTContext::getTypeSizeInCharsIfKnown` returns
size with paddings for
@@ -1001,6 +1001,8 @@ void addLayoutInfo(const NamedDecl , HoverInfo ) {
if (auto *RD = llvm::dyn_cast()) {
if (auto Size = Ctx.getTypeSizeInCharsIfKnown(RD->getTypeForDecl()))
HI.Size = Size->getQuantity() * 8;
+if (!RD->isInvalidDecl() &&
https://github.com/sr-tream updated
https://github.com/llvm/llvm-project/pull/67213
>From df0b44379ab2a4ba50458db0979bddff67c3e4b5 Mon Sep 17 00:00:00 2001
From: SR_team
Date: Sat, 23 Sep 2023 03:49:23 +0300
Subject: [PATCH] [clangd] Show alignment for records and fields decls
---
https://github.com/zyn0217 edited
https://github.com/llvm/llvm-project/pull/67213
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zyn0217 commented:
Thanks! This looks nice, but I think it's better to have more opinions from
others.
Moreover, I have a question regarding the test: It seems the alignment for a
field depends on the ABI spec, i.e., it could be different across MS ABI and
Itanium ABI. Is
@@ -1001,6 +1001,8 @@ void addLayoutInfo(const NamedDecl , HoverInfo ) {
if (auto *RD = llvm::dyn_cast()) {
if (auto Size = Ctx.getTypeSizeInCharsIfKnown(RD->getTypeForDecl()))
HI.Size = Size->getQuantity() * 8;
+if (!RD->isInvalidDecl() &&
https://github.com/zyn0217 edited
https://github.com/llvm/llvm-project/pull/67213
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Changes
isLive() is false for null pointers, so we need to special-case this here.
---
Full diff: https://github.com/llvm/llvm-project/pull/67229.diff
2 Files Affected:
- (modified) clang/lib/AST/Interp/Interp.h (+1-1)
- (modified)
https://github.com/tbaederr created
https://github.com/llvm/llvm-project/pull/67229
isLive() is false for null pointers, so we need to special-case this here.
>From 60a6eade88991e9f80627cb52eb55c1aecbbc1cd Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Timm=20B=C3=A4der?=
Date: Sat, 23 Sep 2023
Author: Timm Bäder
Date: 2023-09-23T11:45:30+02:00
New Revision: 658b655191e997258ac0e5f3308c59e51c2a1ee3
URL:
https://github.com/llvm/llvm-project/commit/658b655191e997258ac0e5f3308c59e51c2a1ee3
DIFF:
https://github.com/llvm/llvm-project/commit/658b655191e997258ac0e5f3308c59e51c2a1ee3.diff
https://github.com/sam-mccall created
https://github.com/llvm/llvm-project/pull/67228
Loosely, the "associated header" of `foo.cpp` is `foo.h`.
It should be included, many styles include it first.
So far we haven't special cased it in any way, and require this include
to be justified. e.g. if
https://github.com/brad0 created https://github.com/llvm/llvm-project/pull/67222
None
>From e12c178d95d2a12d76c292b3af757b1b293af83b Mon Sep 17 00:00:00 2001
From: Brad Smith
Date: Sat, 23 Sep 2023 03:22:18 -0400
Subject: [PATCH] [Driver] Hook up Haiku ARM support
---
@@ -0,0 +1,307 @@
+//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++
+//-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+//
carlosgalvezp added a comment.
@shafik @aaron.ballman @dblaikie
Hello! Just wanted to check if there's any blockers for merging this patch? We
are now on Clang 18, i.e. 2 releases after the warning was introduced, so IMO I
believe it's a good time to turn it into a hard error and test it in
carlosgalvezp wrote:
Thanks @shafik , I wasn't aware! I will then close this PR and continue the
discussion on Phab.
https://github.com/llvm/llvm-project/pull/67170
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/carlosgalvezp closed
https://github.com/llvm/llvm-project/pull/67170
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang-format
Changes
Fixes #67116.
---
Full diff: https://github.com/llvm/llvm-project/pull/67221.diff
2 Files Affected:
- (modified) clang/lib/Format/WhitespaceManager.cpp (+1-1)
- (modified) clang/unittests/Format/FormatTestComments.cpp (+6)
https://github.com/owenca created
https://github.com/llvm/llvm-project/pull/67221
Fixes #67116.
>From 9fa6ed9430896ee9164260227f0791986c750f0f Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Fri, 22 Sep 2023 23:47:23 -0700
Subject: [PATCH] [clang-format] Fix a bug in aligning trailing comments
@@ -10,8 +10,10 @@ link_flags = []
if @LIBUNWIND_ENABLE_CET@:
compile_flags.append('-fcf-protection=full')
-if '@CMAKE_SYSTEM_NAME@' == 'Linux':
-link_flags.append('-Wl,--export-dynamic')
+# Add -Wl,--export-dynamic if supported by the linker (this CMake variable will
https://github.com/MaskRay edited
https://github.com/llvm/llvm-project/pull/67205
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MaskRay approved this pull request.
https://github.com/llvm/llvm-project/pull/67205
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
MaskRay wrote:
> the missing -Wl,--export dynamic flag
typo: missing `-`
https://github.com/llvm/llvm-project/pull/67205
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
73 matches
Mail list logo
